GNU bug report logs - #44561
[PATCH] 28.0; cperl-mode: Test file makeover

Previous Next

Package: emacs;

Reported by: haj <at> posteo.de (Harald Jörg)

Date: Tue, 10 Nov 2020 22:05:01 UTC

Severity: normal

Tags: fixed, patch

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44561 in the body.
You can then email your comments to 44561 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#44561; Package emacs. (Tue, 10 Nov 2020 22:05:01 GMT) Full text and rfc822 format available.
Acknowledgement sent to haj <at> posteo.de (Harald Jörg):
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Tue, 10 Nov 2020 22:05:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: haj <at> posteo.de (Harald Jörg)
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] 28.0; cperl-mode: Test file makeover
Date: Tue, 10 Nov 2020 23:04:34 +0100

[Message part 1 (text/plain, inline)]
As the number of tests for (c)perl mode increases, the test file turns
out to be somewhat untidy.  The patch establishes a consistent naming
scheme, factors out a piece of code which is used in several tests, and
reorders the tests.

The patch also eliminates a warning caused by using (next-line) instead
of (forward-line 1), and allows the tests to run under Emacs 26.

[0001-Cleanup-of-the-test-file-for-cperl-mode.patch (text/x-diff, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#44561; Package emacs. (Wed, 11 Nov 2020 09:44:02 GMT) Full text and rfc822 format available.

Message #8 received at 44561 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: haj <at> posteo.de (Harald Jörg)
Cc: 44561 <at> debbugs.gnu.org
Subject: Re: bug#44561: [PATCH] 28.0; cperl-mode: Test file makeover
Date: Wed, 11 Nov 2020 10:43:01 +0100

haj <at> posteo.de (Harald Jörg) writes:

> As the number of tests for (c)perl mode increases, the test file turns
> out to be somewhat untidy.  The patch establishes a consistent naming
> scheme, factors out a piece of code which is used in several tests, and
> reorders the tests.
>
> The patch also eliminates a warning caused by using (next-line) instead
> of (forward-line 1), and allows the tests to run under Emacs 26.

Thanks; applied to the trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
Added tag(s) fixed. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Wed, 11 Nov 2020 09:44:02 GMT) Full text and rfc822 format available.
bug marked as fixed in version 28.1, send any further explanations to 44561 <at> debbugs.gnu.org and haj <at> posteo.de (Harald Jörg) Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Wed, 11 Nov 2020 09:44:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 09 Dec 2020 12:24:10 GMT) Full text and rfc822 format available.
This bug report was last modified 4 years and 244 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.