From unknown Wed Jun 18 23:03:23 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#44542 <44542@debbugs.gnu.org> To: bug#44542 <44542@debbugs.gnu.org> Subject: Status: [PATCH] Only use nbutlast when we actually want to modify the original list Reply-To: bug#44542 <44542@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:03:23 +0000 retitle 44542 [PATCH] Only use nbutlast when we actually want to modify the= original list reassign 44542 emacs submitter 44542 Steven Allen severity 44542 normal tag 44542 patch thanks From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 09 18:53:41 2020 Received: (at submit) by debbugs.gnu.org; 9 Nov 2020 23:53:41 +0000 Received: from localhost ([127.0.0.1]:35910 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcGyj-0005mE-61 for submit@debbugs.gnu.org; Mon, 09 Nov 2020 18:53:41 -0500 Received: from lists.gnu.org ([209.51.188.17]:38788) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcGyg-0005m4-4Z for submit@debbugs.gnu.org; Mon, 09 Nov 2020 18:53:39 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:36500) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kcGyf-00006Y-Rn for bug-gnu-emacs@gnu.org; Mon, 09 Nov 2020 18:53:37 -0500 Received: from outgoing-stata.csail.mit.edu ([128.30.2.210]:57956) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kcGyd-0006wS-Gd for bug-gnu-emacs@gnu.org; Mon, 09 Nov 2020 18:53:36 -0500 Received: from cpe-66-75-240-41.san.res.rr.com ([66.75.240.41] helo=localhost) by outgoing-stata.csail.mit.edu with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kcGya-000KDd-Ss; Mon, 09 Nov 2020 18:53:33 -0500 From: Steven Allen To: bug-gnu-emacs@gnu.org Subject: [PATCH] Only use nbutlast when we actually want to modify the original list Date: Mon, 9 Nov 2020 15:53:31 -0800 Message-Id: <20201109235331.50177-1-steven@stebalien.com> X-Mailer: git-send-email 2.29.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=128.30.2.210; envelope-from=steven@stebalien.com; helo=outgoing-stata.csail.mit.edu X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/09 18:53:33 X-ACL-Warn: Detected OS = Linux 3.11 and newer X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Michael Albinus X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * lisp/net/tramp-gvfs.el (tramp-gvfs-dbus-byte-array-to-string): Don't modify the byte array. lisp/net/tramp-integration.el (tramp-eshell-directory-change): Don't modify the underlying exec-path. --- lisp/net/tramp-gvfs.el | 2 +- lisp/net/tramp-integration.el | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lisp/net/tramp-gvfs.el b/lisp/net/tramp-gvfs.el index 8f8e628ab9d..86fb45a43b7 100644 --- a/lisp/net/tramp-gvfs.el +++ b/lisp/net/tramp-gvfs.el @@ -876,7 +876,7 @@ Return nil for null BYTE-ARRAY." byte-array (car byte-array)))) (dbus-byte-array-to-string (if (and (consp byte-array) (zerop (car (last byte-array)))) - (nbutlast byte-array) byte-array)))) + (butlast byte-array) byte-array)))) (defun tramp-gvfs-stringify-dbus-message (message) "Convert a D-Bus MESSAGE into readable UTF8 strings, used for traces." diff --git a/lisp/net/tramp-integration.el b/lisp/net/tramp-integration.el index f712600072e..7e4a9bf05e5 100644 --- a/lisp/net/tramp-integration.el +++ b/lisp/net/tramp-integration.el @@ -132,7 +132,7 @@ been set up by `rfn-eshadow-setup-minibuffer'." ;; Use `path-separator' as it does eshell. (setq eshell-path-env (mapconcat - #'identity (nbutlast (tramp-compat-exec-path)) path-separator))) + #'identity (butlast (tramp-compat-exec-path)) path-separator))) (with-eval-after-load 'esh-util (add-hook 'eshell-mode-hook -- 2.29.2 From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 10 03:28:33 2020 Received: (at control) by debbugs.gnu.org; 10 Nov 2020 08:28:33 +0000 Received: from localhost ([127.0.0.1]:36276 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcP0z-0003DS-9K for submit@debbugs.gnu.org; Tue, 10 Nov 2020 03:28:33 -0500 Received: from mout.gmx.net ([212.227.17.20]:39211) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcP0x-0003DB-RS for control@debbugs.gnu.org; Tue, 10 Nov 2020 03:28:32 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1604996903; bh=qHR7K/Sda6TDoIrdVziBYvvr5qC7quTXCDpOsRRc3PQ=; h=X-UI-Sender-Class:Date:To:From:Subject; b=XxAhW454l4PHW4i7k2zIlCw/ETVdAD+zv3OMsxSaBiF1sMYlnFgsLkbW2SvCtoSEV AxddDuvh17PHJyNfxcs1sTM6T9H+zSIOntB526lw/c8QB3N9bLat2H98gwy62BXC+3 hTnRuMqf2A5hEo57bQQHS2TUeONQ7J1q41sfgMPo= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([213.220.147.6]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1Ml6qC-1jtSsF12dw-00lRoD for ; Tue, 10 Nov 2020 09:28:23 +0100 Date: Tue, 10 Nov 2020 09:28:22 +0100 Message-Id: <87pn4lfwex.fsf@gmx.de> To: control@debbugs.gnu.org From: Michael Albinus Subject: control message for bug #44539 X-Provags-ID: V03:K1:vwfcV7l50jHG5uVS0DNc+3R8sDFyRLqZF4KmbLlc3uf9HIyICAg mLerheiDi9vPWJL+YGF/aPYYFiAPpKV3uM2e9c4nLcG3yS3uU7lrU+PghzVL0hHcULhoFZH Yh+yxvWKLtZf3UXKHjjRmezzrUTtiVQk4f0H2SPePI8wiVsoe2nShyzLNs/+PBkaLdcfvdJ cpmNeGTxfLeGWlkeViBOw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:WWq76udBTtE=:MfOfILBuX5pNFw4hSdwe/A ePfjv50w2bXUV+LmSs32sISl9ng8YPflc7coMjZkdif9JVyGAnRO0it8xOlHVUYXlqyjk/p/e OhoY249fLRyUjGAlSoo4twnX/SwYYQenCc2abKRZqX9pxVj7J2yrROeAjTYqa27y0Pi5qyjH6 KM1zCYYfODmSTyMKA/UbpN1qt1UnF3rhpLjb90kOhv8NvgVHEhxwANxQMLqCj4BYyB8c0jEEC tbwZRTnHjdGE/b+iiD7RQTnvaiBqmme4gd2ySvt54Iz+SFRhfUHMohpqEInccBeAopeFnzBBn V6aq7EFryH2BCkezg1/05SWy7QiwXukQPVSOK+pqR7505h3Fs2juV/tPQSn/8msnI3B8R9HiM 6+b3mGOZAvicc+shE43LuZRhrB2OTyCcwziyXqgk2PI6SNyct8Tfi6wXa7s9E5Iu8buqjQoU6 kjT8nWssKAJIRfaPiScGAXAOFemfNv8m4gszdLQ4wWVY/Zp0PNk9EwqGYICp7S03buH7KU4J3 3ps0k92TPIOz9Xz0RWqQNeGszTKKjbREQWDHgSzHbCV6PV/SnX+XQgH/4TBcF4C1oP0kLdRue mJNfhbe+u316L3hmXAF4KRyeAfnV3CweZA7+zCNLhbF5H8SJ2AbC5QWFTB9jApuWj0AavUGc7 vW+JTtmqg46IEGcBiXrIPWCkMy3zgREIFw8QNjJITi3U6Hgv6cYjL1wevHzlhol5zjU9pw9Tx mIevaLpWlBtkywF8MRLidZs39Uqn8ua9afsOpHbusQsvEUaaCoO8Og1YddS37G8cwaHMXP/gK 4eWgOyGvFrSD7fwRpCzMAUeWiHHYoNigIibzNj40kdjeTQ5eU/AmRaBJmTqVll5UmYks74QWk IMGYB1T9EaHGz3+eWGLQ== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) merge 44539 44542 quit From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 10 04:08:30 2020 Received: (at 44542-done) by debbugs.gnu.org; 10 Nov 2020 09:08:30 +0000 Received: from localhost ([127.0.0.1]:36307 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcPdd-0006HO-Uz for submit@debbugs.gnu.org; Tue, 10 Nov 2020 04:08:30 -0500 Received: from mout.gmx.net ([212.227.15.15]:38309) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcPdc-0006HC-Gs for 44542-done@debbugs.gnu.org; Tue, 10 Nov 2020 04:08:29 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1604999300; bh=FWw1+B2Mc1HV3vmSnCq0sTJsq27ZA5ubMGsz/TBYmf0=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=Ky3McXFSVxaeNiWsTBJDlPEKer9gOtGahD5WQSopNpy/o3wdUHsyx81OAZ4C9xLSk oce6oSxmgtWBCVmL+Rufn09UObnI70e98NNT6OV9CJ39g60yIOj3TB/MlSb9p/eSzp w5liAzbJPN7FC4pI+rP9F2V7xGpb/g2e65vZegQ8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([213.220.147.6]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MUGi9-1kkuFE3ne7-00RFhy; Tue, 10 Nov 2020 10:08:20 +0100 From: Michael Albinus To: Steven Allen Subject: Re: bug#44542: [PATCH] Only use nbutlast when we actually want to modify the original list References: <20201109235331.50177-1-steven@stebalien.com> Date: Tue, 10 Nov 2020 10:08:18 +0100 In-Reply-To: <20201109235331.50177-1-steven@stebalien.com> (Steven Allen's message of "Mon, 9 Nov 2020 15:53:31 -0800") Message-ID: <87lff9fukd.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:0BzQ90aXyuT7bt2uHGSU7yox0S+1q29yGGajCIan6pS1MDUyO/y oupETmYECTKk0D4llrf+itt+5xEZvVfW4vBbMIshZmbw2vwfQAhVC8H/SY4EwIPYLn92zML Uw2eoAg2Kt6JBEaxMZECFI2WhfuHKVkuEmdRtq5R2YZs9z8w9/c5rMLePQ3xnlXh3RiylVk SiNqtNR5yA2mzG3ctUYFA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:gJQuXpEog+c=:sREYO4flXXVSw2Hw32tS8o 4oFTbNjy0DmzfTriZ+B121+up6hJcfH+Z8GV0Egq3J2WXtjGGHMpEeH8tycr7fVxQeOy3xScW yXft2eoLu5adED4BJB+3qugJ6TITH34peI/rKo1naQd4yPxVg2bCjeMleIK+DbY2Da37OGRZF AfS1aa3G4n39lX8d/CUGWpRjRyEYs7bLjUJZJltqtPW/CPOsdYKzH/1ZnaSEBeaB/PbpuGJuH Ppqkv7fKT9XSsU+wfYRU0SiQT6NjEG8qU2M3ni4pjHFe3KMpWikmHswbh+h9VszOPyXobMJzX HzftMjNncDjxeeK1N3Bi+I7DukbFbV8S43rjwmRftfLyJGrd0eRImRdKs8Xz5L4YpaToneqq6 FWVfHXjW/PK5v7a3YYQAJStfLBLsBUZLV8hRJL+WO3p6b7OgOkD6ooNUcoooj/bG0pR9f4S5v yHszOm0S46Ik1mL1L31sZjiALDXWq4D34cPM79a8cLyiC7jQNKeJaWunS9VNhjCD4JArCg9Ai Kh9jb1KPgwrG6AcrDG92e7MmaYn5dU20oltKtCRXShQUJqp+73NCGI09TYICKeuEOvKGrNDNI OuHgvtijl/jw1Qq5JuxSJS96U1NfgkJdkTL39DxmH3nEdpBza4Hlh31o9yUYNQKG03XKvlEEe 1p6lC8zI9uoBmdPCQv3LRano2DqcX+ZCK5/l8GQyL0LlgMx1R/5GrI9mA5JEBrEUbD88uU+y+ o0W3MEA0xMruH8LZwNhr32tHtr92NDImCFwvRvuH8ONoOjI7u69MMHuTL753nEfb+xXEulKOU HvFJJjvfbQ28wpjV20ELGoVJHdoerx6rG94fyi6phQwWDvP83UnTg1VMMs1jg4bI9KImEmTkf 2dmdqDl2bTGgDXUap3dg== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44542-done Cc: 44542-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Steven Allen writes: Hi Steven, > * lisp/net/tramp-gvfs.el (tramp-gvfs-dbus-byte-array-to-string): Don't > modify the byte array. > lisp/net/tramp-integration.el (tramp-eshell-directory-change): Don't > modify the underlying exec-path. Thanks for the patch, it fixes a thinko I've introduced recently. Also reported as bug#44539. I've applied the patch to master, closing both bugs. Best regards, Michael. From unknown Wed Jun 18 23:03:23 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Tue, 08 Dec 2020 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator