From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 09 11:13:03 2020 Received: (at submit) by debbugs.gnu.org; 9 Nov 2020 16:13:03 +0000 Received: from localhost ([127.0.0.1]:35321 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kc9mx-00009s-80 for submit@debbugs.gnu.org; Mon, 09 Nov 2020 11:13:03 -0500 Received: from lists.gnu.org ([209.51.188.17]:55770) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kc9mv-00009X-OT for submit@debbugs.gnu.org; Mon, 09 Nov 2020 11:13:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44390) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kc9mv-0005sY-Jm for bug-grep@gnu.org; Mon, 09 Nov 2020 11:13:01 -0500 Received: from mx2.suse.de ([195.135.220.15]:47026) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kc9mt-0004iB-5z for bug-grep@gnu.org; Mon, 09 Nov 2020 11:13:01 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id C85C2AB95 for ; Mon, 9 Nov 2020 16:12:54 +0000 (UTC) From: Andreas Schwab To: bug-grep@gnu.org Subject: Re: grep-3.6 released [stable] References: X-Yow: I just bought FLATBUSH from MICKEY MANTLE! Date: Mon, 09 Nov 2020 17:12:54 +0100 In-Reply-To: (Jim Meyering's message of "Sun, 08 Nov 2020 21:41:32 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=195.135.220.15; envelope-from=schwab@suse.de; helo=mx2.suse.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/08 21:17:38 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x (no timestamps) [generic] X-Spam_score_int: -41 X-Spam_score: -4.2 X-Spam_bar: ---- X-Spam_report: (-4.2 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) grep 3.6 fails to build: test-nl_langinfo-mt.c: In function 'threadN_func': test-nl_langinfo-mt.c:185:1: error: no return statement in function returning non-void [-Werror=return-type] 185 | } | ^ cc1: some warnings being treated as errors make[4]: *** [Makefile:4221: test-nl_langinfo-mt.o] Error 1 Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 09 11:45:25 2020 Received: (at 44535) by debbugs.gnu.org; 9 Nov 2020 16:45:26 +0000 Received: from localhost ([127.0.0.1]:35457 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcAIH-0005e8-I9 for submit@debbugs.gnu.org; Mon, 09 Nov 2020 11:45:25 -0500 Received: from mail-wr1-f51.google.com ([209.85.221.51]:43150) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcAIF-0005XL-Ti for 44535@debbugs.gnu.org; Mon, 09 Nov 2020 11:45:24 -0500 Received: by mail-wr1-f51.google.com with SMTP id s8so2304096wrw.10 for <44535@debbugs.gnu.org>; Mon, 09 Nov 2020 08:45:23 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=2yuQnmz0KqBPxRE3eW6L+mS85Q+08CGRMJXClIN6YR4=; b=XMKNqIXw9n/Z2iOrYa6PN/Mwrqv9/uNzlez+nAKOEbn2odSsWjse+Su+qk2k51a6wQ UgMf8E0aocH9SXJiNWBfo6tg+pIWLPOjIN/YMXvurpDNchYqxQOj/KBbLjSbHK+bA+HM 9S6SI3kwMvlbW+4gAczzxCIDWra+M9boEDIaQUcC2LFRy7EijwU/TnUxU9U37nSEzPRn I/zogOTVV97Fh39eyAFQDZGa0xmjZJ1cVFZWSwDjrEcuzf8I+tJqMWs89CJ2yDtL2lYx dUrIJdIjgW5hZ4RbZ3JagaE2jFMIlKVz163SXG73BGkwA7L/Bt9Tqv2/Q4JEEMBffFIk Ax8g== X-Gm-Message-State: AOAM530/IbJj0GWBIMKtfC+hntYAUNaD3Jy0AXTuwaxtxpMggQuvRKDV wpQsPKVPtStafWhM+5miV2759d/X9J8vsBN9to0= X-Google-Smtp-Source: ABdhPJz7ygPmMPiOMMjNLIdohSjMbedTQwY1DYeXIHpo3zMeubcen/y6zXkIZ89FbIpgWYnLDl3VeXCpgnN4IyW3ls8= X-Received: by 2002:a05:6000:345:: with SMTP id e5mr18219702wre.333.1604940318132; Mon, 09 Nov 2020 08:45:18 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Jim Meyering Date: Mon, 9 Nov 2020 08:45:06 -0800 Message-ID: Subject: Re: bug#44535: grep-3.6 released [stable] To: Andreas Schwab Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 44535 Cc: 44535@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On Mon, Nov 9, 2020 at 8:14 AM Andreas Schwab wrote: > grep 3.6 fails to build: > > test-nl_langinfo-mt.c: In function 'threadN_func': > test-nl_langinfo-mt.c:185:1: error: no return statement in function returning non-void [-Werror=return-type] > 185 | } > | ^ > cc1: some warnings being treated as errors > make[4]: *** [Makefile:4221: test-nl_langinfo-mt.o] Error 1 Thanks for the report. Please also tell us which compiler you're using. Note that for most this would only be a warning. In order to make it a build-blocking error, you must have run configure with --enable-gcc-warnings. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 10 06:02:57 2020 Received: (at 44535) by debbugs.gnu.org; 10 Nov 2020 11:02:57 +0000 Received: from localhost ([127.0.0.1]:36565 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcRQO-0000kW-Rw for submit@debbugs.gnu.org; Tue, 10 Nov 2020 06:02:57 -0500 Received: from mx2.suse.de ([195.135.220.15]:38014) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcRQN-0000kK-HT for 44535@debbugs.gnu.org; Tue, 10 Nov 2020 06:02:55 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id BBFAFAC1F; Tue, 10 Nov 2020 11:02:49 +0000 (UTC) From: Andreas Schwab To: Jim Meyering Subject: Re: bug#44535: grep-3.6 released [stable] References: X-Yow: I'm not available for comment.. Date: Tue, 10 Nov 2020 12:02:49 +0100 In-Reply-To: (Jim Meyering's message of "Mon, 9 Nov 2020 08:45:06 -0800") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44535 Cc: 44535@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) https://build.opensuse.org/package/live_build_log/home:Andreas_Schwab:Factory/grep/f/x86_64 Andreas. -- Andreas Schwab, SUSE Labs, schwab@suse.de GPG Key fingerprint = 0196 BAD8 1CE9 1970 F4BE 1748 E4D4 88E3 0EEA B9D7 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 13 02:39:48 2020 Received: (at 44535) by debbugs.gnu.org; 13 Nov 2020 07:39:48 +0000 Received: from localhost ([127.0.0.1]:46531 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdTgR-0004ZU-O4 for submit@debbugs.gnu.org; Fri, 13 Nov 2020 02:39:47 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:55370) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdTgO-0004ZE-8O for 44535@debbugs.gnu.org; Fri, 13 Nov 2020 02:39:46 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 8DD0816010E; Thu, 12 Nov 2020 23:39:37 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id MISPN20eKvkb; Thu, 12 Nov 2020 23:39:36 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 8DC2716011F; Thu, 12 Nov 2020 23:39:36 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id XUfAVXHiLD3b; Thu, 12 Nov 2020 23:39:36 -0800 (PST) Received: from [192.168.1.9] (cpe-23-243-218-95.socal.res.rr.com [23.243.218.95]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 563F516010E; Thu, 12 Nov 2020 23:39:36 -0800 (PST) From: Paul Eggert Subject: Re: bug#44535: grep-3.6 released [stable] To: Andreas Schwab References: Autocrypt: addr=eggert@cs.ucla.edu; prefer-encrypt=mutual; keydata= mQINBEyAcmQBEADAAyH2xoTu7ppG5D3a8FMZEon74dCvc4+q1XA2J2tBy2pwaTqfhpxxdGA9 Jj50UJ3PD4bSUEgN8tLZ0san47l5XTAFLi2456ciSl5m8sKaHlGdt9XmAAtmXqeZVIYX/UFS 96fDzf4xhEmm/y7LbYEPQdUdxu47xA5KhTYp5bltF3WYDz1Ygd7gx07Auwp7iw7eNvnoDTAl KAl8KYDZzbDNCQGEbpY3efZIvPdeI+FWQN4W+kghy+P6au6PrIIhYraeua7XDdb2LS1en3Ss mE3QjqfRqI/A2ue8JMwsvXe/WK38Ezs6x74iTaqI3AFH6ilAhDqpMnd/msSESNFt76DiO1ZK QMr9amVPknjfPmJISqdhgB1DlEdw34sROf6V8mZw0xfqT6PKE46LcFefzs0kbg4GORf8vjG2 Sf1tk5eU8MBiyN/bZ03bKNjNYMpODDQQwuP84kYLkX2wBxxMAhBxwbDVZudzxDZJ1C2VXujC OJVxq2kljBM9ETYuUGqd75AW2LXrLw6+MuIsHFAYAgRr7+KcwDgBAfwhPBYX34nSSiHlmLC+ KaHLeCLF5ZI2vKm3HEeCTtlOg7xZEONgwzL+fdKo+D6SoC8RRxJKs8a3sVfI4t6CnrQzvJbB n6gxdgCu5i29J1QCYrCYvql2UyFPAK+do99/1jOXT4m2836j1wARAQABtCBQYXVsIEVnZ2Vy dCA8ZWdnZXJ0QGNzLnVjbGEuZWR1PokCVQQTAQgAPwIbAwYLCQgHAwIGFQgCCQoLBBYCAwEC HgECF4AWIQR+N5Kp2Kz31jO8FYjtl+kOYqp+NAUCXyW9lwUJFK4LswAKCRDtl+kOYqp+NKNV D/9HMsI1606n0UuTXHwITsyOjAI9SDOT+C3DUv6qlM5BH2nWAMTiIiyA5uglsJv93oi2vNtF f/Q/m/1cnZWgnVnExkyLI4ENSd1uBvr0/lCSdPlP0Mg6GWSpXMu+x0vdT0AaZNOTE0FnPuol dc3XD76C2qg8sX/iaxXTKHy9P+BlAq/Cs7/pxDQ0EzSn0USZ2C0l5vv4PMpA/picnS6K609J vDGaORmwZeXIZqQNZV+ZQs+UYtVoguDTqby3IUY1I8BlXHRptaj9AMn4Uoh/CqpQlVojoyWl HqaFnnJBKeF0hvJ9SAyalwuzAjG7vQW07MYncaOFm0woiKbg5JLO8F4SBTIkuO0DCf9nLAay 6VsB4rzwdEfRwjPLYAn7MR3fvHCEzfrkldTraiBO1T0ieDK80I7sLf6pMeCYI19pUlx0/NRM GCddiFIQdfthKWXGRS5LAs8jwBf8H6G5PWinPrEIaomIP21ivuhQD07bYq9IiIdeljjUdHcG I0i/B4M56Zaa8Ff38iniOlrDYCmYWR4dCWZiuQeZ3OgqeQs9a6jTvgdDGVmRVqY+jzk8PlaH fcok8ROhFcHKkcfhuBhL25hlRIshRDOEskXqKwnzrbqga3GXZXfsXAoFbzNhLdLv9A+LJAYS kXP6/5qdTpELVGosyH884VdbBpkGI04oYVqulbkCDQRMgHJkARAApoXrvxP3DIfjCNOtXU/P dwMShKdX/RlSs5PfunV1wbKP8herXHrvQdFVqECaTSxmlhzbk8X0PkY9gcVaU2O49T3qsOd1 cHeF52YFGEt0LhsBeMjgNX5uZ1V76r8gyeVlFpWWb0SIwJUBHrDXexF67upeRb2vdHBjYDNe ySn+0B7gFEqvVmZu+LadudDp6kQLjatFvHQHUSGNshBnkkcaTbiI9Pst0GCc2aiznBiPPA2W QxAPlPRh3OGTsn5THADmbjqY6FEMLasVX8DSCblMvLwNeO/8SxziBidhqLpJCqdQRWHku5Xx gIkGeKOz5OLDvXHWJyafrEYjjkS6Ak6B5z6svKliClWnjHQcjlPzyoFFgKTEfcqDxCj4RY0D 0DgtFD0NfyeOidrSB/SzTe2hwryQE3rpSiqo+0cGdzh4yAHKYJ+UrXZ4p93ZhjGfKD1xlrNY DlWyW9PGmbvqFuDmiIAQf9WD/wzEfICc+F+uDDI+uYkRxUFp92ykmdhDEFg1yjYsU8iGU69a Hyvhq36z4zctvbqhRNzOWB1bVJ/dIMDvsExGcXQVDIT7sDNXv0wE3jKSKpp7NDG1oXUXL+2+ SF99Kjy753AbQSAmH617fyBNwhJWvQYg+mUvPpiGOtses9EXUI3lS4v0MEaPG43flEs1UR+1 rpFQWVHo1y1OO+sAEQEAAYkCPAQYAQgAJgIbDBYhBH43kqnYrPfWM7wViO2X6Q5iqn40BQJf Jb2zBQkUrgvPAAoJEO2X6Q5iqn40cnMP/17CgUkXT9aIJriPM8wbceYrcl7+bdYEf79SlwSb bHN7R4CoIJFOlN9S/34typGVYvpgmCJDYFTBxyPO92iMXDgA4+cWHzt5T1aYO9hsKhh7vDtK +6ProZGc+08gUTXHhb97hMMQhknJlnfjpSEC9em906FU+I93T1fTGupnBa3aWcK8jM0JaBGb y2hG1S3olaDLSTtBINNBYmvuWR9MKOhhqDrlk5cwFDJLh5NrXteEY08WAzcLzG3pkrXPHkFe MQtfqk0jLdGGvGC3NCIkqYrdLhiRvGpru38C26REn5f4I0vGE3VfIXHe8TMCNmQut1NtMuUm pDIy1aLxGzuptUhnOJN//r+VjDPoi3LOySNYphqe/dMubsfUr6ohP41mKF81FuwI4amqJtrq IL2yqax3a0qlfwCxXftieqJcuekX+eCPDCKrYMXR0FYgwpG2ITZUGtrEjESlE6Dscx734HKd r5ORIocLUUKEOGeiU6DGhGFdb5Twu0Sn+u1mUPDN0M++CdMvClIE8klo4G91EOImu1Upb8xc OPQwxh1jwqSrU5QwoNmSYegQSHLpIUurFz1iQUh1vpPXzKinkWEqv4IqA1ciL+LyySuLkp7M sJpVRMbWJCNWOOSbaH4oDBJ5dHMGc35x5mosCk90PXknuFDDsYHfDo5smf9lo6YXx7N9 Organization: UCLA Computer Science Department Message-ID: <1db801ad-69db-45e0-8615-fbd69fcf86f2@cs.ucla.edu> Date: Thu, 12 Nov 2020 23:39:36 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44535 Cc: 44535@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) On 11/9/20 8:12 AM, Andreas Schwab wrote: > grep 3.6 fails to build: > > test-nl_langinfo-mt.c: In function 'threadN_func': > test-nl_langinfo-mt.c:185:1: error: no return statement in function returning non-void [-Werror=return-type] > 185 | } > | ^ > cc1: some warnings being treated as errors > make[4]: *** [Makefile:4221: test-nl_langinfo-mt.o] Error 1 We have dueling compilers here, as Sun C complains if the return statements are present[1], whereas gcc -Wreturn-type complains if they're absent. Since the return statements are clearly bogus and unnecessary I'm inclined to continue to omit them. > https://build.opensuse.org/package/live_build_log/home:Andreas_Schwab:Factory/grep/f/x86_64 This says you're configuring with CFLAGS='... -Werror=return-type ...'. If you omit the "-Werror=return-type" option the problem should go away. For 'grep', that option is more trouble than it's worth. (Perhaps someone should file a GCC bug report....) For the recommended set of warning options for compiling 'grep', you can use './configure --enable-gcc-warnings' instead. [1] https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=bd90572c031a25e559907ae0c2b9fd3aa632893b From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 13 13:27:24 2020 Received: (at 44535) by debbugs.gnu.org; 13 Nov 2020 18:27:24 +0000 Received: from localhost ([127.0.0.1]:49313 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kddn9-0002Jp-V9 for submit@debbugs.gnu.org; Fri, 13 Nov 2020 13:27:24 -0500 Received: from mail-wr1-f49.google.com ([209.85.221.49]:32853) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kddn8-0002Jc-49 for 44535@debbugs.gnu.org; Fri, 13 Nov 2020 13:27:23 -0500 Received: by mail-wr1-f49.google.com with SMTP id u12so3786498wrt.0 for <44535@debbugs.gnu.org>; Fri, 13 Nov 2020 10:27:22 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=OoJNE+u+uj0llnDUkcVdQ4ZOlGqFhLvlTSQ2arfPJrk=; b=N+T8HfDWSkb2eiMSTZqSzgf1ejkblIkFcD4D8wxOPUKhvv9/bmsmzP1ZB4IB3/kfY9 lBts7y7iOiqX8zzBVH6qmfdVIRkchI3s/yooIIEV5+oZWwTR96GOuYivF0+zKAYRj+CN DWcHwxS9gJ26EVlr0pqJo4B+Q2NJvTT+MusCl5kuJg41I0WhqJfeVxiakNTNDJ5QxjFV QvkfGH17vLYVjgTjoKd+F3qzAgp1T1Zdin50dRqvzw7t7QWV5WnBAEPLyMeWXmI1B/QK WNFOJfUg9nZiaPVoudpGF2siB4Gutd3WC/BJo7K1tvyDQqKLA6dBS8H/mY76Od7DE+/1 eRnw== X-Gm-Message-State: AOAM530xpIqDoJiWfTzaXFYMEbOJbTRNMSvMVhDfK+xGAxm7rAPYEbCn 1pL2osvGX5Q8PnmqumhaZ26T+xAZvuN9k5QQc4o= X-Google-Smtp-Source: ABdhPJxSoOdgaDkSsXjv/hiL29n03P/Zt4QGDIUhu+KbqfZWs6O2vMbQD+jpesMB2Y/ZZmTUVD4Rl7O5Ec5t/wDg/4c= X-Received: by 2002:adf:f90f:: with SMTP id b15mr5096642wrr.343.1605292035788; Fri, 13 Nov 2020 10:27:15 -0800 (PST) MIME-Version: 1.0 References: <1db801ad-69db-45e0-8615-fbd69fcf86f2@cs.ucla.edu> In-Reply-To: <1db801ad-69db-45e0-8615-fbd69fcf86f2@cs.ucla.edu> From: Jim Meyering Date: Fri, 13 Nov 2020 10:27:03 -0800 Message-ID: Subject: Re: bug#44535: grep-3.6 released [stable] To: Paul Eggert Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 44535 Cc: Andreas Schwab , 44535@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) On Thu, Nov 12, 2020 at 11:40 PM Paul Eggert wrote: > On 11/9/20 8:12 AM, Andreas Schwab wrote: > > grep 3.6 fails to build: > > > > test-nl_langinfo-mt.c: In function 'threadN_func': > > test-nl_langinfo-mt.c:185:1: error: no return statement in function returning non-void [-Werror=return-type] > > 185 | } > > | ^ > > cc1: some warnings being treated as errors > > make[4]: *** [Makefile:4221: test-nl_langinfo-mt.o] Error 1 > > We have dueling compilers here, as Sun C complains if the return statements are > present[1], whereas gcc -Wreturn-type complains if they're absent. Since the > return statements are clearly bogus and unnecessary I'm inclined to continue to > omit them. > > > https://build.opensuse.org/package/live_build_log/home:Andreas_Schwab:Factory/grep/f/x86_64 > > This says you're configuring with CFLAGS='... -Werror=return-type ...'. If you > omit the "-Werror=return-type" option the problem should go away. For 'grep', > that option is more trouble than it's worth. (Perhaps someone should file a GCC > bug report....) > > For the recommended set of warning options for compiling 'grep', you can use > './configure --enable-gcc-warnings' instead. > > [1] > https://git.savannah.gnu.org/cgit/gnulib.git/commit/?id=bd90572c031a25e559907ae0c2b9fd3aa632893b This led me to realize that grep had not enabled warnings on its compilation of gnulib-tests/. I've begun to fix that, which has including filing this gcc bug: https://gcc.gnu.org/bugzilla/show_bug.cgi?id=97817 From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 21 21:15:33 2020 Received: (at 44535-done) by debbugs.gnu.org; 22 Nov 2020 02:15:34 +0000 Received: from localhost ([127.0.0.1]:46733 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kgeub-0000u2-7a for submit@debbugs.gnu.org; Sat, 21 Nov 2020 21:15:33 -0500 Received: from zimbra.cs.ucla.edu ([131.179.128.68]:55182) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kgeuZ-0000na-3g for 44535-done@debbugs.gnu.org; Sat, 21 Nov 2020 21:15:32 -0500 Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id A108B1600D6; Sat, 21 Nov 2020 18:15:25 -0800 (PST) Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id L8s_BnHP3bQT; Sat, 21 Nov 2020 18:15:24 -0800 (PST) Received: from localhost (localhost [127.0.0.1]) by zimbra.cs.ucla.edu (Postfix) with ESMTP id 6CE8F1600DB; Sat, 21 Nov 2020 18:15:24 -0800 (PST) X-Virus-Scanned: amavisd-new at zimbra.cs.ucla.edu Received: from zimbra.cs.ucla.edu ([127.0.0.1]) by localhost (zimbra.cs.ucla.edu [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id BEFIGp7eJH8v; Sat, 21 Nov 2020 18:15:24 -0800 (PST) Received: from [192.168.1.9] (cpe-23-243-218-95.socal.res.rr.com [23.243.218.95]) by zimbra.cs.ucla.edu (Postfix) with ESMTPSA id 1E7141600D6; Sat, 21 Nov 2020 18:15:24 -0800 (PST) Subject: Re: bug#44535: grep-3.6 released [stable] From: Paul Eggert To: Andreas Schwab References: <1db801ad-69db-45e0-8615-fbd69fcf86f2@cs.ucla.edu> Organization: UCLA Computer Science Department Message-ID: Date: Sat, 21 Nov 2020 18:15:20 -0800 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.2 MIME-Version: 1.0 In-Reply-To: <1db801ad-69db-45e0-8615-fbd69fcf86f2@cs.ucla.edu> Content-Type: multipart/mixed; boundary="------------05DC9370CEFE7C53BAF1B585" Content-Language: en-US X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44535-done Cc: Gnulib bugs , 44535-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This is a multi-part message in MIME format. --------------05DC9370CEFE7C53BAF1B585 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 11/12/20 11:39 PM, Paul Eggert wrote: > We have dueling compilers here, as Sun C complains if the return statements are > present[1], whereas gcc -Wreturn-type complains if they're absent. Since the > return statements are clearly bogus and unnecessary I'm inclined to continue to > omit them. I looked into this some more, and found out that it's a known GCC bug. I installed the attached patch into Gnulib to work around the bug. Thanks for reporting the problem. --------------05DC9370CEFE7C53BAF1B585 Content-Type: text/x-patch; charset=UTF-8; name="0001-nl_langinfo-tests-work-around-GCC-bug-44511.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="0001-nl_langinfo-tests-work-around-GCC-bug-44511.patch" >From f60dd0747ad75c2971cc314111c8fc2b8a38ce19 Mon Sep 17 00:00:00 2001 From: Paul Eggert Date: Sat, 21 Nov 2020 18:09:29 -0800 Subject: [PATCH] nl_langinfo-tests: work around GCC bug 44511 * tests/test-nl_langinfo-mt.c: Ignore -Wreturn-type, to work around a GCC bug . Problem reported for GNU grep by Andreas Schwab . --- ChangeLog | 6 ++++++ tests/test-nl_langinfo-mt.c | 5 +++++ 2 files changed, 11 insertions(+) diff --git a/ChangeLog b/ChangeLog index 745a90097..d46bfbb1a 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,5 +1,11 @@ 2020-11-21 Paul Eggert + nl_langinfo-tests: work around GCC bug 44511 + * tests/test-nl_langinfo-mt.c: Ignore -Wreturn-type, to work + around a GCC bug . + Problem reported for GNU grep by Andreas Schwab + . + selinux-h: add stubs for selabel_open etc. Coreutils with --enable-gcc-warnings does not build on Ubuntu 20.10 because matchpathcon is deprecated in favor of selabel_open etc., diff --git a/tests/test-nl_langinfo-mt.c b/tests/test-nl_langinfo-mt.c index 4d207f1be..751008ff9 100644 --- a/tests/test-nl_langinfo-mt.c +++ b/tests/test-nl_langinfo-mt.c @@ -18,6 +18,11 @@ #include +/* Work around GCC bug 44511. */ +#if 4 < __GNUC__ + (3 <= __GNUC_MINOR__) +# pragma GCC diagnostic ignored "-Wreturn-type" +#endif + #if USE_ISOC_THREADS || USE_POSIX_THREADS || USE_ISOC_AND_POSIX_THREADS || USE_WINDOWS_THREADS /* Specification. */ -- 2.27.0 --------------05DC9370CEFE7C53BAF1B585-- From unknown Sun Jun 22 00:16:12 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 20 Dec 2020 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator