From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 09 10:25:34 2020 Received: (at submit) by debbugs.gnu.org; 9 Nov 2020 15:25:35 +0000 Received: from localhost ([127.0.0.1]:35196 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kc930-00034G-Fg for submit@debbugs.gnu.org; Mon, 09 Nov 2020 10:25:34 -0500 Received: from lists.gnu.org ([209.51.188.17]:48148) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kc5kg-0008MV-EG for submit@debbugs.gnu.org; Mon, 09 Nov 2020 06:54:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:32844) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kc5kg-0007kn-5I for bug-gnu-emacs@gnu.org; Mon, 09 Nov 2020 06:54:26 -0500 Received: from mail-lf1-x133.google.com ([2a00:1450:4864:20::133]:37534) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kc5ke-0006N4-Cs for bug-gnu-emacs@gnu.org; Mon, 09 Nov 2020 06:54:25 -0500 Received: by mail-lf1-x133.google.com with SMTP id s30so11997730lfc.4 for ; Mon, 09 Nov 2020 03:54:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=/lu/IYFAjSDDJcLrrQTfU9NGlKLZp+t3F9qiik/R7Lw=; b=sLt8TYr/3rQOIRAIhKeNRb49fS3CXSL85z0KcIzy/tJ1hww9Y436vMMA+xCof40O2P 0n5iGumM5STwtO3p7F1CiBU9ApDbIoNH0dadgQ4PsOnKFvtNRYBfCp/B0798zDitjMa4 6F3tJZsZIpF6AWr4xEGT82XdI1Uemwm1ildQIFfO4A5xJ6bxLP9uCb3YsmxZtTgFNzpr G2GlMGIbyVT/kRPuhx4sgS/FHYRd+Gc+J0ZClXSGgUaV7wxXoyPMz93YviS+Z7FP99Mg VIFqWZ/9qyrc2Y2SipCB6tSyn8UFJ63ZyMHWtsNyTuExevFxNVowmT/bMk+jE2Mi/5Iq ktzA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=/lu/IYFAjSDDJcLrrQTfU9NGlKLZp+t3F9qiik/R7Lw=; b=sBQok0oPAg4AmRYe1x7t3Ak31uVoz17MEqY0NGINykg7hVw2KAzIZJmboUYgtoethi x9NuG9uLlS5XzSu/FfWvLb1jO1EjcuCva31cSMDUi41WfCN3uAbsr7S00v5YemmYuLsy 4qbdLlRRyBiCZzVQYY/JJxqOEJBAx+1I9h10bERrc75mAjdXqeRchQ9gzXaYjYWCBySw 6zgmCCZxabeitPZ/TUY4pajNz49LdxlRhKUSISUdGQyahFYUmHtEsjtIleKhXuHhjgCN FYHg0crweMxTNuA8JyOIDjlrax0LjQKaSv9gcXiU708BCyxJ85s+wqrksZxkR7HBduda JQ/g== X-Gm-Message-State: AOAM532/dBl8fcWdxHdZ+n3QQQPvTT0DKucZWW3evDob3ESoK3qzZXTN gZ19sHhDIXM0MS0+fbXQGRtdFNWGMZRvR3OvQaM8+8CkD1IjuA== X-Google-Smtp-Source: ABdhPJxnteeLQNCS6QB5Uccs03O2ZIy5LLXsXS1P8HruWqQL6gmoR3nJP0LAxdcD5z1oPsZo2ZtofB57VKQUZyiZOQY= X-Received: by 2002:a05:6512:3156:: with SMTP id s22mr5185321lfi.273.1604922860498; Mon, 09 Nov 2020 03:54:20 -0800 (PST) MIME-Version: 1.0 From: Tom Fitzhenry Date: Mon, 9 Nov 2020 11:54:09 +0000 Message-ID: Subject: [PATCH] Remove extra process call from vc-hg-registered To: bug-gnu-emacs@gnu.org Content-Type: multipart/mixed; boundary="000000000000fead0805b3ab38eb" Received-SPF: pass client-ip=2a00:1450:4864:20::133; envelope-from=tomfitzhenry@google.com; helo=mail-lf1-x133.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -175 X-Spam_score: -17.6 X-Spam_bar: ----------------- X-Spam_report: (-17.6 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_MED=-0.001, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, ENV_AND_HDR_SPF_MATCH=-0.5, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001, USER_IN_DEF_DKIM_WL=-7.5, USER_IN_DEF_SPF_WL=-7.5 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Mon, 09 Nov 2020 10:25:32 -0500 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --000000000000fead0805b3ab38eb Content-Type: multipart/alternative; boundary="000000000000fead0705b3ab38e9" --000000000000fead0705b3ab38e9 Content-Type: text/plain; charset="UTF-8" Prefer calling vc-state (rather than vc-hg-state) to benefit from the caching in vc-state. This same technique is used in vc-git.el, per commit "2018-06-28 "Remove extra process call from vc-git-find-file-hook" 93c41ce6aa64b14fc9bd7bdd0d909915a79191cd. --000000000000fead0705b3ab38e9 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Prefer calling vc-state (rather than vc-hg-state) to benef= it from the caching in vc-state.

This same technique is used in vc-g= it.el, per commit "2018-06-28 "Remove extra process call from vc-= git-find-file-hook" 93c41ce6aa64b14fc9bd7bdd0d909915a79191cd.
--000000000000fead0705b3ab38e9-- --000000000000fead0805b3ab38eb Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Remove-extra-process-call-from-vc-hg-registered.patch" Content-Disposition: attachment; filename="0001-Remove-extra-process-call-from-vc-hg-registered.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_khahctoh0 RnJvbSA2NzZiZmFmODlkZGQ4NDUwZTM5NTI1MTc2MmE0MTUzNTU2ZGVmMmYyIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUb20gRml0emhlbnJ5IDx0b21maXR6aGVucnlAZ29vZ2xlLmNv bT4KRGF0ZTogTW9uLCA5IE5vdiAyMDIwIDIyOjE5OjEwICsxMTAwClN1YmplY3Q6IFtQQVRDSF0g UmVtb3ZlIGV4dHJhIHByb2Nlc3MgY2FsbCBmcm9tIHZjLWhnLXJlZ2lzdGVyZWQKClByZWZlciB2 Yy1zdGF0ZSB0byBiZW5lZml0IGZyb20gaXRzIGNhY2hpbmcuCgpUaGlzIHNhbWUgdGVjaG5pcXVl IGlzIHVzZWQgaW4gdmMtZ2l0LmVsLCBwZXIgY29tbWl0ICIyMDE4LTA2LTI4ICJSZW1vdmUgZXh0 cmEgcHJvY2VzcyBjYWxsIGZyb20gdmMtZ2l0LWZpbmQtZmlsZS1ob29rIiA5M2M0MWNlNmFhNjRi MTRmYzliZDdiZGQwZDkwOTkxNWE3OTE5MWNkLgoKKiBsaXNwL3ZjL3ZjLWhnLmVsICh2Yy1oZy1y ZWdpc3RlcmVkKTogVXNlIHZjLXN0YXRlIHJhdGhlciB0aGFuIHZjLWhnLXN0YXRlLgotLS0KIGxp c3AvdmMvdmMtaGcuZWwgfCAyICstCiAxIGZpbGUgY2hhbmdlZCwgMSBpbnNlcnRpb24oKyksIDEg ZGVsZXRpb24oLSkKCmRpZmYgLS1naXQgYS9saXNwL3ZjL3ZjLWhnLmVsIGIvbGlzcC92Yy92Yy1o Zy5lbAppbmRleCBjYjA2NTdlNzBhLi5jYWNkZWUyMjI2IDEwMDY0NAotLS0gYS9saXNwL3ZjL3Zj LWhnLmVsCisrKyBiL2xpc3AvdmMvdmMtaGcuZWwKQEAgLTIyMiw3ICsyMjIsNyBAQCBJZiBgYXNr JywgeW91IHdpbGwgYmUgcHJvbXB0ZWQgZm9yIGEgYnJhbmNoIHR5cGUuIgogKGRlZnVuIHZjLWhn LXJlZ2lzdGVyZWQgKGZpbGUpCiAgICJSZXR1cm4gbm9uLW5pbCBpZiBGSUxFIGlzIHJlZ2lzdGVy ZWQgd2l0aCBoZy4iCiAgICh3aGVuICh2Yy1oZy1yb290IGZpbGUpICAgICAgICAgICA7IHNob3J0 IGN1dAotICAgIChsZXQgKChzdGF0ZSAodmMtaGctc3RhdGUgZmlsZSkpKSAgOyBleHBlbnNpdmUK KyAgICAobGV0ICgoc3RhdGUgKHZjLXN0YXRlIGZpbGUgJ0hnKSkpICA7IGV4cGVuc2l2ZQogICAg ICAgKGFuZCBzdGF0ZSAobm90IChtZW1xIHN0YXRlICcoaWdub3JlZCB1bnJlZ2lzdGVyZWQpKSkp KSkpCiAKIChkZWZ1biB2Yy1oZy1zdGF0ZSAoZmlsZSkKLS0gCjIuMjkuMi4yMjIuZzVkMmE5MmQx MGY4LWdvb2cKCg== --000000000000fead0805b3ab38eb-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 10 10:45:39 2020 Received: (at 44534-done) by debbugs.gnu.org; 10 Nov 2020 15:45:39 +0000 Received: from localhost ([127.0.0.1]:38682 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcVpz-0006JD-4b for submit@debbugs.gnu.org; Tue, 10 Nov 2020 10:45:39 -0500 Received: from mail-ed1-f42.google.com ([209.85.208.42]:35681) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcVpx-0006J1-OB for 44534-done@debbugs.gnu.org; Tue, 10 Nov 2020 10:45:38 -0500 Received: by mail-ed1-f42.google.com with SMTP id ay21so13219705edb.2 for <44534-done@debbugs.gnu.org>; Tue, 10 Nov 2020 07:45:37 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=PB2fQ5kttTGTFbmXrcvzSu4NE+eQx22bkUeBpch8lqo=; b=n4vxZNVVdfMygitvG7lq+pUxwgmQjwAKQO/n9icmbyv50mKzxUwTkxghF+PF3MKLRt wpMzVjJszmpXuodThhCW7pTlhClXqnkXCelzjqmU/inKxgoU5g7CMSWDP2c7T7KamCPe mroQ3OONkBMvJ+NVB5alV3sC+o1G4R6u3PLiZvxvLCG9/zEW4/U3WGdA1YaH0t+uJuiy Eeo9hcRisyi96Y4rzymKtTAxV/WXiHbNy7y+pMAIngPlUjEAl37YGmxrVRBsnBobECdS nad/WzhpK9wvC6ISXNl9uzH62BlsYX7hdut4K+Cg0SosQd2HqGdxV0vCqupcK7NM6Fq3 Dm8w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=PB2fQ5kttTGTFbmXrcvzSu4NE+eQx22bkUeBpch8lqo=; b=BG4+kgDYyX6IUN2CB13E2JKNFS/QFNqR2vgWajvUhS9vLJapRAo7d5rA2diRGZDZSM R2QNIEvH5zYw94rVebdAAYcA/sjfrVxHr4diPDvpv2j8vM9EYFzVIMymnkoJD7i/ZGoA DFLgln+ig82+P3e5vdvwrYu9YWDRPbYFvfbajOv0zjiJHs/9dAZcAq5x6h+VafGxea+Y AYMfiqKkM3t9qqoR8NHYRDG79I4rvQAFk94MRdyUxg/JvLQ4rTqUtUQBVwiiGTzHFgKX zNsFMtsDY2skmQlrhbduEDOxEvteHEQnlE5wbdJRwcPmfobQzo7115hBu/5s9bY0Q0sZ jlTQ== X-Gm-Message-State: AOAM5320FLBFvdYsM9wQZpsOFQMQG42/PB+AbUahUBF+dACX//s/Muwk 74r2MSn+8JIJTkF9CDpnT4FbJdV2DT19cw== X-Google-Smtp-Source: ABdhPJyrDXzkCZfUY/U8Lo+x5bynbvDvD4tFqLlrZJmd4Jlqb1Tqksx6oz4xAKjHbouBCH3D5TNh4w== X-Received: by 2002:aa7:dd45:: with SMTP id o5mr20633374edw.243.1605023131393; Tue, 10 Nov 2020 07:45:31 -0800 (PST) Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id b6sm11400724edu.21.2020.11.10.07.45.30 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Nov 2020 07:45:30 -0800 (PST) Subject: Re: bug#44534: [PATCH] Remove extra process call from vc-hg-registered To: Tom Fitzhenry , 44534-done@debbugs.gnu.org References: From: Dmitry Gutov Message-ID: Date: Tue, 10 Nov 2020 17:45:28 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 44534-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Version: 28.1 On 09.11.2020 13:54, Tom Fitzhenry via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > Prefer calling vc-state (rather than vc-hg-state) to benefit from the > caching in vc-state. > > This same technique is used in vc-git.el, per commit "2018-06-28 "Remove > extra process call from vc-git-find-file-hook" > 93c41ce6aa64b14fc9bd7bdd0d909915a79191cd. Makes sense, thanks! Pushed. P.S. Next time please try to keep the line width within usual limits, I had to fix the following linter errors: Line longer than 78 characters in commit message Word longer than 140 characters in commit message Commit aborted; please see the file CONTRIBUTE From unknown Sat Jun 21 05:00:34 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 09 Dec 2020 12:24:07 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator