GNU bug report logs - #44529
[PATCH] Convert apropos-internal from C to Lisp

Previous Next

Package: emacs;

Reported by: Stefan Kangas <stefan <at> marxist.se>

Date: Mon, 9 Nov 2020 10:40:01 UTC

Severity: wishlist

Tags: fixed, patch

Fixed in version 28.1

Done: Stefan Kangas <stefan <at> marxist.se>

Bug is archived. No further changes may be made.

Full log

View this message in rfc822 format

From: Eli Zaretskii <eliz <at> gnu.org>
To: Stefan Kangas <stefan <at> marxist.se>
Cc: 44529 <at> debbugs.gnu.org, monnier <at> iro.umontreal.ca
Subject: bug#44529: [PATCH] Convert apropos-internal from C to Lisp
Date: Mon, 16 Nov 2020 19:52:46 +0200

> From: Stefan Kangas <stefan <at> marxist.se>
> Date: Sun, 15 Nov 2020 17:07:14 -0800
> Cc: 44529 <at> debbugs.gnu.org
> 
> The attached patch moves it to subr.el instead, as requested.

Thanks.

> This runs insignificantly faster in C, and is already fast enough on
> reasonably modern hardware.  We might as well lift it to Lisp.
> This benchmark can be used to verify:
> 
>   (benchmark-run 10 (apropos-command "test"))
>   => (0.12032415399999999 2 0.014772391999999995) ; C
>   => (0.13513192100000002 2 0.017216643000000004) ; Lisp

Btw, did you try with less trivial strings?  E.g., what happens if you
replace "test" with "set" or "file"?
This bug report was last modified 4 years and 214 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.