GNU bug report logs - #44524
28.0.50; Wrong place saved in org file with save-place-mode

Previous Next

Packages: org-mode, emacs;

Reported by: Juri Linkov <juri <at> linkov.net>

Date: Sun, 8 Nov 2020 19:49:02 UTC

Severity: normal

Tags: fixed

Fixed in version 28.0.50

Done: Juri Linkov <juri <at> linkov.net>

Bug is archived. No further changes may be made.

Full log


Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; Wrong place saved in org file with save-place-mode
Date: Sun, 08 Nov 2020 21:41:30 +0200
[Message part 1 (text/plain, inline)]
Package: emacs,org-mode

0. emacs -Q
1. enable save-place-mode
2. visit an org file with a single line:

#+DATE: 2020-11-08

The cursor always jumps to the fixed place inside the date,
and doesn't remember its previous position.  Here is a fix
to not set buffer-file-name (that causes save-place-mode to save
wrong place for that file name) in a temporary buffer:

[org-element-parse-secondary-string.patch (text/x-diff, inline)]
diff --git a/lisp/org/org-element.el b/lisp/org/org-element.el
index be74dfdbef..d1fa777aa6 100644
--- a/lisp/org/org-element.el
+++ b/lisp/org/org-element.el
@@ -4144,7 +4144,8 @@ org-element-parse-secondary-string
 	  (dolist (v local-variables)
 	    (ignore-errors
 	      (if (symbolp v) (makunbound v)
-		(set (make-local-variable (car v)) (cdr v)))))
+		(unless (memq (car v) '(buffer-file-name buffer-file-truename))
+                  (set (make-local-variable (car v)) (cdr v))))))
 	  ;; Transferring local variables may put the temporary buffer
 	  ;; into a read-only state.  Make sure we can insert STRING.
 	  (let ((inhibit-read-only t)) (insert string))

This bug report was last modified 4 years and 252 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.