From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 08 14:48:17 2020 Received: (at submit) by debbugs.gnu.org; 8 Nov 2020 19:48:17 +0000 Received: from localhost ([127.0.0.1]:33090 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kbqfh-0001lz-5N for submit@debbugs.gnu.org; Sun, 08 Nov 2020 14:48:17 -0500 Received: from lists.gnu.org ([209.51.188.17]:42518) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kbqff-0001lq-Qo for submit@debbugs.gnu.org; Sun, 08 Nov 2020 14:48:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44740) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kbqff-00048h-IZ for bug-gnu-emacs@gnu.org; Sun, 08 Nov 2020 14:48:15 -0500 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:45293) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kbqfd-0002Ez-Ff for bug-gnu-emacs@gnu.org; Sun, 08 Nov 2020 14:48:15 -0500 X-Originating-IP: 91.129.97.46 Received: from mail.gandi.net (m91-129-97-46.cust.tele2.ee [91.129.97.46]) (Authenticated sender: juri@linkov.net) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id B73A71BF203 for ; Sun, 8 Nov 2020 19:48:10 +0000 (UTC) From: Juri Linkov To: bug-gnu-emacs@gnu.org Subject: 28.0.50; Wrong place saved in org file with save-place-mode Organization: LINKOV.NET Date: Sun, 08 Nov 2020 21:41:30 +0200 Message-ID: <87lffbycdx.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=217.70.183.201; envelope-from=juri@linkov.net; helo=relay8-d.mail.gandi.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/08 14:48:11 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) --=-=-= Content-Type: text/plain Package: emacs,org-mode 0. emacs -Q 1. enable save-place-mode 2. visit an org file with a single line: #+DATE: 2020-11-08 The cursor always jumps to the fixed place inside the date, and doesn't remember its previous position. Here is a fix to not set buffer-file-name (that causes save-place-mode to save wrong place for that file name) in a temporary buffer: --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=org-element-parse-secondary-string.patch diff --git a/lisp/org/org-element.el b/lisp/org/org-element.el index be74dfdbef..d1fa777aa6 100644 --- a/lisp/org/org-element.el +++ b/lisp/org/org-element.el @@ -4144,7 +4144,8 @@ org-element-parse-secondary-string (dolist (v local-variables) (ignore-errors (if (symbolp v) (makunbound v) - (set (make-local-variable (car v)) (cdr v))))) + (unless (memq (car v) '(buffer-file-name buffer-file-truename)) + (set (make-local-variable (car v)) (cdr v)))))) ;; Transferring local variables may put the temporary buffer ;; into a read-only state. Make sure we can insert STRING. (let ((inhibit-read-only t)) (insert string)) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 10 14:31:39 2020 Received: (at 44524) by debbugs.gnu.org; 10 Nov 2020 19:31:39 +0000 Received: from localhost ([127.0.0.1]:38901 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcZMg-0004v9-NR for submit@debbugs.gnu.org; Tue, 10 Nov 2020 14:31:38 -0500 Received: from relay8-d.mail.gandi.net ([217.70.183.201]:56265) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcZMe-0004no-Cm; Tue, 10 Nov 2020 14:31:37 -0500 X-Originating-IP: 91.129.97.46 Received: from mail.gandi.net (m91-129-97-46.cust.tele2.ee [91.129.97.46]) (Authenticated sender: juri@linkov.net) by relay8-d.mail.gandi.net (Postfix) with ESMTPSA id D30C11BF209; Tue, 10 Nov 2020 19:31:28 +0000 (UTC) From: Juri Linkov To: 44524@debbugs.gnu.org Subject: Re: bug#44524: 28.0.50; Wrong place saved in org file with save-place-mode Organization: LINKOV.NET References: <87lffbycdx.fsf@mail.linkov.net> Date: Tue, 10 Nov 2020 21:28:54 +0200 In-Reply-To: <87lffbycdx.fsf@mail.linkov.net> (Juri Linkov's message of "Sun, 08 Nov 2020 21:41:30 +0200") Message-ID: <87361hko3t.fsf@mail.linkov.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 44524 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 44524 fixed close 44524 28.0.50 quit > Package: emacs,org-mode > > 0. emacs -Q > 1. enable save-place-mode > 2. visit an org file with a single line: > > #+DATE: 2020-11-08 > > The cursor always jumps to the fixed place inside the date, > and doesn't remember its previous position. Here is a fix > to not set buffer-file-name (that causes save-place-mode to save > wrong place for that file name) in a temporary buffer: > > diff --git a/lisp/org/org-element.el b/lisp/org/org-element.el > index be74dfdbef..d1fa777aa6 100644 > --- a/lisp/org/org-element.el > +++ b/lisp/org/org-element.el > @@ -4144,7 +4144,8 @@ org-element-parse-secondary-string > (dolist (v local-variables) > (ignore-errors > (if (symbolp v) (makunbound v) > - (set (make-local-variable (car v)) (cdr v))))) > + (unless (memq (car v) '(buffer-file-name buffer-file-truename)) > + (set (make-local-variable (car v)) (cdr v)))))) > ;; Transferring local variables may put the temporary buffer > ;; into a read-only state. Make sure we can insert STRING. > (let ((inhibit-read-only t)) (insert string)) Pushed to Emacs master, and closed. From unknown Sun Aug 17 00:57:36 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 09 Dec 2020 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator