GNU bug report logs - #44518
gnu: Add matterhorn.

Previous Next

Full log

Message #17 received at 44518 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: Romain GARBAGE <romain.garbage <at> inria.fr>
Cc: 71938 <at> debbugs.gnu.org, 44518 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: Add matterhorn.
Date: Sun, 07 Jul 2024 01:07:25 +0200

Hi Romain,

> * gnu/packages/haskell-apps.scm (matterhorn): New variable.
> * gnu/packages/haskell-crypto.scm (ghc-crypton, ghc-crypton-x509,
> ghc-crypton-x509-store, ghc-crypton-x509-system,
> ghc-crypton-x509-validation, ghc-tls-1.9): New variables.
> * gnu/packages/haskell-web.scm (ghc-crypton-connection,
> ghc-mattermost-api, ghc-mattermost-api-qc, ghc-modern-uri): New variables.
> * gnu/packages/haskell-xyz.scm (ghc-aspell-pipe, ghc-bimap,
> ghc-checkers, ghc-monad-parallel, ghc-text-zipper-13, ghc-stm-delay,
> ghc-unique, ghc-unix-compat-7, ghc-vty-6, ghc-vty-crossplatform,
> ghc-vty-unix, ghc-hclip, ghc-brick, ghc-brick-skylighting): New variables.

thank you for the patch!  This looks all pretty good.

There are a few minor quibbles:

* Please make one commit for every added package.
* matterhorn: Please sort inputs alphabetically.
* ghc-crypton: please use Texinfo syntax such as @itemize for the list
  of features.
* ghc-crypton-x509: it would be good to know if there is something we
  can do to make tests pass.  If the tests are pointless it would be
  good to record that.  Please also make sure that the description is
  ... descriptive.
* ghc-tls-1.9, ghc-unix-compat-7, ghc-vty-6, ghc-text-zipper-13: Is it
  desirable to have these packages instead of upgrading the existing
  packages?  Is there pending work on the Haskell team branch(es) that
  would make the use of these versioned variants obsolete?
* Please check whether potentially unwanted changes should really be
  included, such as the cosmetic changes to ghc-githash.

I also just found that there's an old patch set for matterhorn; I cc'd
the issue email address.

-- 
Ricardo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.