GNU bug report logs - #44515
[PATCH] gnu: xmlstarlet: Install symlink to xmlstarlet binary.

Previous Next

Full log

View this message in rfc822 format

From: Ludovic Courtès <ludo <at> gnu.org>
To: Pierre Langlois <pierre.langlois <at> gmx.com>
Cc: 44515 <at> debbugs.gnu.org
Subject: [bug#44515] [PATCH] gnu: xmlstarlet: Install symlink to xmlstarlet binary.
Date: Wed, 18 Nov 2020 23:42:35 +0100

Hi,

Pierre Langlois <pierre.langlois <at> gmx.com> skribis:

> I recently encountered a small script incompatibility between Guix and
> other distros (Arch, Fedora, Debian) because the `xml' binary is often
> either moved or symlinked to `xmlstarlet'.
>
> So here's a patch that adds the symlink, is that OK to commit?

Sure!  Maybe add a comment above stating that several other distros do
that.

>>From a285bc89eb37a5aa56d444c195d9ef013a30aeec Mon Sep 17 00:00:00 2001
> From: Pierre Langlois <pierre.langlois <at> gmx.com>
> Date: Fri, 30 Oct 2020 11:57:35 +0000
> Subject: [PATCH] gnu: xmlstarlet: Install symlink to xmlstarlet binary.
>
> * gnu/packages/xml.scm (xmlstarlet)[arguments]: Add 'symlink-xmlstarlet
> phase.

[...]

> +       (add-after 'install 'symlink-xmlstarlet
> +         (lambda* (#:key outputs #:allow-other-keys)
> +           (let* ((out (assoc-ref outputs "out"))
> +                  (bin (string-append out "/bin")))
> +             (symlink (string-append bin "/xml")
                         ^
"xml" is enough.

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.