GNU bug report logs -
#44502
28.0.50; Emacs crash using new frame
Previous Next
Reported by: Andy Moreton <andrewjmoreton <at> gmail.com>
Date: Sat, 7 Nov 2020 13:28:02 UTC
Severity: normal
Found in version 28.0.50
Fixed in version 28.1
Done: Lars Ingebrigtsen <larsi <at> gnus.org>
Bug is archived. No further changes may be made.
Full log
View this message in rfc822 format
Hello, Eli.
On Fri, Aug 19, 2022 at 13:45:57 +0300, Eli Zaretskii wrote:
> Ping! Any progress with this bug?
I haven't been able to reproduce the bug, but understand fairly well what
must have caused it.
I also haven't heard back from the OP since sending him a proposed patch
last Sunday.
Since the patch is fairly simple and obvious, also non-dangerous, how
about just installing it on the release branch?
> > I think the following fix to the assert should indeed be a "safe" fix,
> > suitable for Emacs-28. Could you possibly apply it, please, and try to
> > recreate the error. If you don't manage to recreate the error, the bug
> > is probably "fixed".
> > diff --git a/src/window.c b/src/window.c
> > index 2576b66a18..35ec2a1f90 100644
> > --- a/src/window.c
> > +++ b/src/window.c
> > @@ -554,7 +554,9 @@ select_window (Lisp_Object window, Lisp_Object norecord,
> > frame is active. */
> > Fselect_frame (frame, norecord);
> > /* Fselect_frame called us back so we've done all the work already. */
> > - eassert (EQ (window, selected_window));
> > + eassert (EQ (window, selected_window)
> > + || (EQ (window, f->minibuffer_window)
> > + && NILP (Fminibufferp (XWINDOW (window)->contents, Qt))));
> > return window;
> > }
> > else
--
Alan Mackenzie (Nuremberg, Germany).
This bug report was last modified 2 years and 280 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.