From unknown Mon Aug 18 04:42:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44471: [PATCH] Simplify text-quoting-style Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Nov 2020 16:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 44471 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 44471@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.160459311829570 (code B ref -1); Thu, 05 Nov 2020 16:19:02 +0000 Received: (at submit) by debbugs.gnu.org; 5 Nov 2020 16:18:38 +0000 Received: from localhost ([127.0.0.1]:53951 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kahy9-0007gs-KV for submit@debbugs.gnu.org; Thu, 05 Nov 2020 11:18:38 -0500 Received: from lists.gnu.org ([209.51.188.17]:41228) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kahy8-0007gl-4F for submit@debbugs.gnu.org; Thu, 05 Nov 2020 11:18:36 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41300) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kahy7-0007yc-UZ for bug-gnu-emacs@gnu.org; Thu, 05 Nov 2020 11:18:35 -0500 Received: from mail-ej1-f43.google.com ([209.85.218.43]:44980) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kahy5-00017f-V6 for bug-gnu-emacs@gnu.org; Thu, 05 Nov 2020 11:18:35 -0500 Received: by mail-ej1-f43.google.com with SMTP id o23so2465196ejn.11 for ; Thu, 05 Nov 2020 08:18:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:mime-version:date:message-id:subject:to; bh=+82XWLp3bfYfbmYsqAyEy9BuUkx2joalCjTIK0/9P6U=; b=U2rR78nSU/Fu/nXkGbpT97qeUBNY7MpP5bD48T/2PEqhO8RKeTSs1oRhP75yINfaCS mtuHO0z72xUPgCsBppXzhqVY+CA0qtuC0Z4SfmvQHznwLrssta61cS0u18BlMfNQqi0h T85Zfof3DQCV9ObHGznKOfuGJvt/icrdEcCYHcjZDCYfSogb6boUo+tdlCa9pecjuN20 bxj4XJTk5iL/RihpgLBdQQN7u3ZbqMIPGdU/MdmrfRYmewCJXg/PLdphtx2bnbhQMYsJ meZ2hcHa1auANM4yW1WFxpHr/R/PwlrhQYmTmB0JUeuhqSZeG3vN7aLRNKFsBa6RezMC 2JLg== X-Gm-Message-State: AOAM533P10iB9PvJlGzIyZNhM9BALo8XJoZ6Y5TOJhOna0CRVcNmU1Hu kLL4UhBiFRbq1U8eOXItbDPgBjsnL8EgbGICnwCcwusM X-Google-Smtp-Source: ABdhPJx9GUVdTCfhWCP+CPkp0YywV6GIhWkJUhJ1Olcwpu9WbAYWZo9N1Bwk83XHRK6VLC3XaNWTn+vDtNVPfS6DkZY= X-Received: by 2002:a17:906:8058:: with SMTP id x24mr3149949ejw.272.1604593110731; Thu, 05 Nov 2020 08:18:30 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 5 Nov 2020 08:18:21 -0800 From: Stefan Kangas MIME-Version: 1.0 Date: Thu, 5 Nov 2020 08:18:21 -0800 Message-ID: Content-Type: multipart/mixed; boundary="000000000000600faf05b35e729f" Received-SPF: pass client-ip=209.85.218.43; envelope-from=stefankangas@gmail.com; helo=mail-ej1-f43.google.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/05 11:18:32 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -13 X-Spam_score: -1.4 X-Spam_bar: - X-Spam_report: (-1.4 / 5.0 requ) BAYES_00=-1.9, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 1.2 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: I found an opportunity to simplify the code for text-quoting-style. See the attached patch. The patch also improves the name of the defun `get-quoting-style' by changing it to `text-quoting-style'. (This new name matches the old C function name and the existing variable name.) Content analysis details: (1.2 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.2 HEADER_FROM_DIFFERENT_DOMAINS From and EnvelopeFrom 2nd level mail domains are different 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (stefankangas[at]gmail.com) -0.0 SPF_HELO_PASS SPF: HELO matches SPF record 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [209.51.188.17 listed in wl.mailspike.net] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 0.0 UNPARSEABLE_RELAY Informational: message has unparseable relay lines 0.2 FREEMAIL_FORGED_FROMDOMAIN 2nd level domains in From and EnvelopeFrom freemail headers are different 2.0 SPOOFED_FREEMAIL No description available. X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) --000000000000600faf05b35e729f Content-Type: text/plain; charset="UTF-8" I found an opportunity to simplify the code for text-quoting-style. See the attached patch. The patch also improves the name of the defun `get-quoting-style' by changing it to `text-quoting-style'. (This new name matches the old C function name and the existing variable name.) Any comments? --000000000000600faf05b35e729f Content-Type: text/x-diff; charset="utf-8"; name="0001-Simplify-text-quoting-style.patch" Content-Disposition: attachment; filename="0001-Simplify-text-quoting-style.patch" Content-Transfer-Encoding: base64 X-Attachment-Id: 288afcc6886207e4_0.1 RnJvbSA2NjMxODkwY2M3NGMwYzc5YTJhZTIwZmU5ZjBiMWJkNjY3MDZiNGM5IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBTdGVmYW4gS2FuZ2FzIDxzdGVmYW5AbWFyeGlzdC5zZT4KRGF0 ZTogVGh1LCA1IE5vdiAyMDIwIDE1OjMyOjQ1ICswMTAwClN1YmplY3Q6IFtQQVRDSF0gU2ltcGxp ZnkgdGV4dC1xdW90aW5nLXN0eWxlCgoqIHNyYy9kb2MuYyAodGV4dF9xdW90aW5nX3N0eWxlKTog UmVtb3ZlIGZ1bmN0aW9uIGJ5IG1lcmdpbmcgaXQuLi4KKEZ0ZXh0X3F1b3Rpbmdfc3R5bGUpOiAu Li5oZXJlLiAgUmVuYW1lIGZyb20gRmdldF9xdW90aW5nX3N0eWxlLgooc3ltc19vZl9kb2MpOiBV cGRhdGUgZGVmc3ViciBmb3IgRnRleHRfcXVvdGluZ19zdHlsZS4KKiBzcmMvbGlzcC5oIChlbnVt IHRleHRfcXVvdGluZ19zdHlsZSk6IFJlbW92ZSBlbnVtLgoqIHNyYy9kb3BybnQuYyAoZG9wcm50 KToKKiBzcmMvZWRpdGZucy5jIChzdHlsZWRfZm9ybWF0KToKKiBsaXNwL2hlbHAuZWwgKHN1YnN0 aXR1dGUtY29tbWFuZC1rZXlzKTogVXBkYXRlIGNhbGxlcnMgdG8gdXNlCnRleHQtcXVvdGluZy1z dHlsZS4KLS0tCiBsaXNwL2hlbHAuZWwgIHwgIDQgKystLQogc3JjL2RvYy5jICAgICB8IDQwICsr KysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0KIHNyYy9kb3BybnQuYyAgfCAg OCArKysrLS0tLQogc3JjL2VkaXRmbnMuYyB8ICA2ICsrKy0tLQogc3JjL2xpc3AuaCAgICB8IDEy IC0tLS0tLS0tLS0tLQogNSBmaWxlcyBjaGFuZ2VkLCAyMyBpbnNlcnRpb25zKCspLCA0NyBkZWxl dGlvbnMoLSkKCmRpZmYgLS1naXQgYS9saXNwL2hlbHAuZWwgYi9saXNwL2hlbHAuZWwKaW5kZXgg NDY2ZmYyMWViMi4uMzJlZTg0YjVmOSAxMDA2NDQKLS0tIGEvbGlzcC9oZWxwLmVsCisrKyBiL2xp c3AvaGVscC5lbApAQCAtMTEwMywxMyArMTEwMywxMyBAQCBzdWJzdGl0dXRlLWNvbW1hbmQta2V5 cwogICAgICAgICAgICAgICAgICAgICAgIChkZXNjcmliZS1tYXAtdHJlZSB0aGlzLWtleW1hcCB0 IChucmV2ZXJzZSBlYXJsaWVyLW1hcHMpCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIG5pbCBuaWwgdCBuaWwgbmlsIHQpKSkpKSkpKQogICAgICAgICAgICAgIDs7IDIu IEhhbmRsZSBxdW90ZXMuCi0gICAgICAgICAgICAgKChhbmQgKGVxIChnZXQtcXVvdGluZy1zdHls ZSkgJ2N1cnZlKQorICAgICAgICAgICAgICgoYW5kIChlcSAodGV4dC1xdW90aW5nLXN0eWxlKSAn Y3VydmUpCiAgICAgICAgICAgICAgICAgICAgKG9yIChhbmQgKD0gKGZvbGxvd2luZy1jaGFyKSA/ XGApCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgKHByb2cxIHQgKGluc2VydCAi4oCYIikp KQogICAgICAgICAgICAgICAgICAgICAgICAoYW5kICg9IChmb2xsb3dpbmctY2hhcikgPycpCiAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgKHByb2cxIHQgKGluc2VydCAi4oCZIikpKSkpCiAg ICAgICAgICAgICAgIChkZWxldGUtY2hhciAxKSkKLSAgICAgICAgICAgICAoKGFuZCAoZXEgKGdl dC1xdW90aW5nLXN0eWxlKSAnc3RyYWlnaHQpCisgICAgICAgICAgICAgKChhbmQgKGVxICh0ZXh0 LXF1b3Rpbmctc3R5bGUpICdzdHJhaWdodCkKICAgICAgICAgICAgICAgICAgICAoPSAoZm9sbG93 aW5nLWNoYXIpID9cYCkpCiAgICAgICAgICAgICAgIChpbnNlcnQgIiciKQogICAgICAgICAgICAg ICAoZGVsZXRlLWNoYXIgMSkpCmRpZmYgLS1naXQgYS9zcmMvZG9jLmMgYi9zcmMvZG9jLmMKaW5k ZXggZjFjZTI2NmQzOS4uNWYyM2UzZDBiYiAxMDA2NDQKLS0tIGEvc3JjL2RvYy5jCisrKyBiL3Ny Yy9kb2MuYwpAQCAtNjgyLDM3ICs2ODIsMjUgQEAgZGVmYXVsdF90b19ncmF2ZV9xdW90aW5nX3N0 eWxlICh2b2lkKQogCSAgJiYgRVEgKEFSRUYgKGR2LCAwKSwgbWFrZV9maXhudW0gKCdgJykpKTsK IH0KIAotLyogUmV0dXJuIHRoZSBjdXJyZW50IGVmZmVjdGl2ZSB0ZXh0IHF1b3Rpbmcgc3R5bGUu ICAqLwotZW51bSB0ZXh0X3F1b3Rpbmdfc3R5bGUKLXRleHRfcXVvdGluZ19zdHlsZSAodm9pZCkK K0RFRlVOICgidGV4dC1xdW90aW5nLXN0eWxlIiwgRnRleHRfcXVvdGluZ19zdHlsZSwKKyAgICAg ICBTdGV4dF9xdW90aW5nX3N0eWxlLCAwLCAwLCAwLAorICAgICAgIGRvYzogLyogUmV0dXJuIHRo ZSBjdXJyZW50IGVmZmVjdGl2ZSB0ZXh0IHF1b3Rpbmcgc3R5bGUuCitTZWUgdmFyaWFibGUgYHRl eHQtcXVvdGluZy1zdHlsZScuICAqLykKKyAgKHZvaWQpCiB7CisgIC8qIFVzZSBncmF2ZSBhY2Nl bnQgYW5kIGFwb3N0cm9waGUgYGxpa2UgdGhpcycuICAqLwogICBpZiAoTklMUCAoVnRleHRfcXVv dGluZ19zdHlsZSkKICAgICAgID8gZGVmYXVsdF90b19ncmF2ZV9xdW90aW5nX3N0eWxlICgpCiAg ICAgICA6IEVRIChWdGV4dF9xdW90aW5nX3N0eWxlLCBRZ3JhdmUpKQotICAgIHJldHVybiBHUkFW RV9RVU9USU5HX1NUWUxFOworICAgIHJldHVybiBRZ3JhdmU7CisKKyAgLyogVXNlIGFwb3N0cm9w aGVzICdsaWtlIHRoaXMnLiAgKi8KICAgZWxzZSBpZiAoRVEgKFZ0ZXh0X3F1b3Rpbmdfc3R5bGUs IFFzdHJhaWdodCkpCi0gICAgcmV0dXJuIFNUUkFJR0hUX1FVT1RJTkdfU1RZTEU7Ci0gIGVsc2UK LSAgICByZXR1cm4gQ1VSVkVfUVVPVElOR19TVFlMRTsKLX0KKyAgICByZXR1cm4gUXN0cmFpZ2h0 OwogCi0vKiBUaGlzIGlzIGp1c3QgYSBMaXNwIHdyYXBwZXIgZm9yIHRleHRfcXVvdGluZ19zdHls ZSBhYm92ZS4gICovCi1ERUZVTiAoImdldC1xdW90aW5nLXN0eWxlIiwgRmdldF9xdW90aW5nX3N0 eWxlLAotICAgICAgIFNnZXRfcXVvdGluZ19zdHlsZSwgMCwgMCwgMCwKLSAgICAgICBkb2M6IC8q IFJldHVybiB0aGUgY3VycmVudCBlZmZlY3RpdmUgdGV4dCBxdW90aW5nIHN0eWxlLgotU2VlIHZh cmlhYmxlIGB0ZXh0LXF1b3Rpbmctc3R5bGUnLiAgKi8pCi0gICh2b2lkKQotewotICBzd2l0Y2gg KHRleHRfcXVvdGluZ19zdHlsZSAoKSkKLSAgICB7Ci0gICAgY2FzZSBTVFJBSUdIVF9RVU9USU5H X1NUWUxFOgotICAgICAgcmV0dXJuIFFzdHJhaWdodDsKLSAgICBjYXNlIENVUlZFX1FVT1RJTkdf U1RZTEU6Ci0gICAgICByZXR1cm4gUWN1cnZlOwotICAgIGNhc2UgR1JBVkVfUVVPVElOR19TVFlM RToKLSAgICBkZWZhdWx0OgotICAgICAgcmV0dXJuIFFncmF2ZTsKLSAgICB9CisgIC8qIFVzZSBj dXJ2ZWQgc2luZ2xlIHF1b3RlcyDigJhsaWtlIHRoaXPigJkuICAqLworICBlbHNlCisgICAgcmV0 dXJuIFFjdXJ2ZTsKIH0KIAogDApAQCAtNzU1LDUgKzc0Myw1IEBAIHN5bXNfb2ZfZG9jICh2b2lk KQogICBkZWZzdWJyICgmU2RvY3VtZW50YXRpb24pOwogICBkZWZzdWJyICgmU2RvY3VtZW50YXRp b25fcHJvcGVydHkpOwogICBkZWZzdWJyICgmU3NuYXJmX2RvY3VtZW50YXRpb24pOwotICBkZWZz dWJyICgmU2dldF9xdW90aW5nX3N0eWxlKTsKKyAgZGVmc3ViciAoJlN0ZXh0X3F1b3Rpbmdfc3R5 bGUpOwogfQpkaWZmIC0tZ2l0IGEvc3JjL2RvcHJudC5jIGIvc3JjL2RvcHJudC5jCmluZGV4IGNl MjU5ZDA3Y2YuLjkzMTY0OTc3MjAgMTAwNjQ0Ci0tLSBhL3NyYy9kb3BybnQuYworKysgYi9zcmMv ZG9wcm50LmMKQEAgLTE5OSw3ICsxOTksNyBAQCBkb3BybnQgKGNoYXIgKmJ1ZmZlciwgcHRyZGlm Zl90IGJ1ZnNpemUsIGNvbnN0IGNoYXIgKmZvcm1hdCwKICAgLyogQnVmZmVyIHdlIGhhdmUgZ290 IHdpdGggbWFsbG9jLiAgKi8KICAgY2hhciAqYmlnX2J1ZmZlciA9IE5VTEw7CiAKLSAgZW51bSB0 ZXh0X3F1b3Rpbmdfc3R5bGUgcXVvdGluZ19zdHlsZSA9IHRleHRfcXVvdGluZ19zdHlsZSAoKTsK KyAgTGlzcF9PYmplY3QgcXVvdGluZ19zdHlsZSA9IEZ0ZXh0X3F1b3Rpbmdfc3R5bGUgKCk7CiAK ICAgYnVmc2l6ZS0tOwogCkBAIC00ODIsMTMgKzQ4MiwxMyBAQCBkb3BybnQgKGNoYXIgKmJ1ZmZl ciwgcHRyZGlmZl90IGJ1ZnNpemUsIGNvbnN0IGNoYXIgKmZvcm1hdCwKIAogICAgICAgY2hhciBj b25zdCAqc3JjOwogICAgICAgcHRyZGlmZl90IHNyY2xlbjsKLSAgICAgIGlmIChxdW90aW5nX3N0 eWxlID09IENVUlZFX1FVT1RJTkdfU1RZTEUgJiYgZm10Y2hhciA9PSAnYCcpCisgICAgICBpZiAo RVEgKHF1b3Rpbmdfc3R5bGUsIFFjdXJ2ZSkgJiYgZm10Y2hhciA9PSAnYCcpCiAJc3JjID0gdUxT UU0sIHNyY2xlbiA9IHNpemVvZiB1TFNRTSAtIDE7Ci0gICAgICBlbHNlIGlmIChxdW90aW5nX3N0 eWxlID09IENVUlZFX1FVT1RJTkdfU1RZTEUgJiYgZm10Y2hhciA9PSAnXCcnKQorICAgICAgZWxz ZSBpZiAoRVEgKHF1b3Rpbmdfc3R5bGUsIFFjdXJ2ZSkgJiYgZm10Y2hhciA9PSAnXCcnKQogCXNy YyA9IHVSU1FNLCBzcmNsZW4gPSBzaXplb2YgdVJTUU0gLSAxOwogICAgICAgZWxzZQogCXsKLQkg IGlmIChxdW90aW5nX3N0eWxlID09IFNUUkFJR0hUX1FVT1RJTkdfU1RZTEUgJiYgZm10Y2hhciA9 PSAnYCcpCisJICBpZiAoRVEgKHF1b3Rpbmdfc3R5bGUsIFFzdHJhaWdodCkgJiYgZm10Y2hhciA9 PSAnYCcpCiAJICAgIGZtdGNoYXIgPSAnXCcnOwogCSAgZWFzc2VydCAoQVNDSUlfQ0hBUl9QIChm bXRjaGFyKSk7CiAJICAqYnVmcHRyKysgPSBmbXRjaGFyOwpkaWZmIC0tZ2l0IGEvc3JjL2VkaXRm bnMuYyBiL3NyYy9lZGl0Zm5zLmMKaW5kZXggY2E2Yjg5ODFlYi4uMzIwZmJkYzY2OSAxMDA2NDQK LS0tIGEvc3JjL2VkaXRmbnMuYworKysgYi9zcmMvZWRpdGZucy5jCkBAIC0zMTQ3LDcgKzMxNDcs NyBAQCBzdHlsZWRfZm9ybWF0IChwdHJkaWZmX3QgbmFyZ3MsIExpc3BfT2JqZWN0ICphcmdzLCBi b29sIG1lc3NhZ2UpCiAgICAgaWYgKFNUUklOR1AgKGFyZ3NbaV0pICYmIFNUUklOR19NVUxUSUJZ VEUgKGFyZ3NbaV0pKQogICAgICAgbXVsdGlieXRlID0gdHJ1ZTsKIAotICBpbnQgcXVvdGluZ19z dHlsZSA9IG1lc3NhZ2UgPyB0ZXh0X3F1b3Rpbmdfc3R5bGUgKCkgOiAtMTsKKyAgTGlzcF9PYmpl Y3QgcXVvdGluZ19zdHlsZSA9IG1lc3NhZ2UgPyBGdGV4dF9xdW90aW5nX3N0eWxlICgpIDogUW5p bDsKIAogICBwdHJkaWZmX3QgaXNwZWM7CiAgIHB0cmRpZmZfdCBuc3BlYyA9IDA7CkBAIC0zNzY3 LDcgKzM3NjcsNyBAQCBzdHlsZWRfZm9ybWF0IChwdHJkaWZmX3QgbmFyZ3MsIExpc3BfT2JqZWN0 ICphcmdzLCBib29sIG1lc3NhZ2UpCiAJICB1bnNpZ25lZCBjaGFyIHN0cltNQVhfTVVMVElCWVRF X0xFTkdUSF07CiAKIAkgIGlmICgoZm9ybWF0X2NoYXIgPT0gJ2AnIHx8IGZvcm1hdF9jaGFyID09 ICdcJycpCi0JICAgICAgJiYgcXVvdGluZ19zdHlsZSA9PSBDVVJWRV9RVU9USU5HX1NUWUxFKQor CSAgICAgICYmIEVRIChxdW90aW5nX3N0eWxlLCBRY3VydmUpKQogCSAgICB7CiAJICAgICAgaWYg KCEgbXVsdGlieXRlKQogCQl7CkBAIC0zNzc4LDcgKzM3NzgsNyBAQCBzdHlsZWRfZm9ybWF0IChw dHJkaWZmX3QgbmFyZ3MsIExpc3BfT2JqZWN0ICphcmdzLCBib29sIG1lc3NhZ2UpCiAJICAgICAg Y29udmJ5dGVzID0gMzsKIAkgICAgICBuZXdfcmVzdWx0ID0gdHJ1ZTsKIAkgICAgfQotCSAgZWxz ZSBpZiAoZm9ybWF0X2NoYXIgPT0gJ2AnICYmIHF1b3Rpbmdfc3R5bGUgPT0gU1RSQUlHSFRfUVVP VElOR19TVFlMRSkKKwkgIGVsc2UgaWYgKGZvcm1hdF9jaGFyID09ICdgJyAmJiBFUSAocXVvdGlu Z19zdHlsZSwgUXN0cmFpZ2h0KSkKIAkgICAgewogCSAgICAgIGNvbnZzcmMgPSAiJyI7CiAJICAg ICAgbmV3X3Jlc3VsdCA9IHRydWU7CmRpZmYgLS1naXQgYS9zcmMvbGlzcC5oIGIvc3JjL2xpc3Au aAppbmRleCBhM2NmYjUwNDRkLi5jNmViNDRkNzRlIDEwMDY0NAotLS0gYS9zcmMvbGlzcC5oCisr KyBiL3NyYy9saXNwLmgKQEAgLTQ0OTUsMTggKzQ0OTUsNiBAQCAjZGVmaW5lIERBRU1PTl9SVU5O SU5HICh3MzJfZGFlbW9uX2V2ZW50ICE9IElOVkFMSURfSEFORExFX1ZBTFVFKQogZXh0ZXJuIHZv aWQgc3ltc19vZl9jYWxscHJvYyAodm9pZCk7CiAKIC8qIERlZmluZWQgaW4gZG9jLmMuICAqLwot ZW51bSB0ZXh0X3F1b3Rpbmdfc3R5bGUKLSAgewotICAgIC8qIFVzZSBjdXJ2ZWQgc2luZ2xlIHF1 b3RlcyDigJhsaWtlIHRoaXPigJkuICAqLwotICAgIENVUlZFX1FVT1RJTkdfU1RZTEUsCi0KLSAg ICAvKiBVc2UgZ3JhdmUgYWNjZW50IGFuZCBhcG9zdHJvcGhlICBgbGlrZSB0aGlzJy4gICovCi0g ICAgR1JBVkVfUVVPVElOR19TVFlMRSwKLQotICAgIC8qIFVzZSBhcG9zdHJvcGhlcyAnbGlrZSB0 aGlzJy4gICovCi0gICAgU1RSQUlHSFRfUVVPVElOR19TVFlMRQotICB9OwotZXh0ZXJuIGVudW0g dGV4dF9xdW90aW5nX3N0eWxlIHRleHRfcXVvdGluZ19zdHlsZSAodm9pZCk7CiBleHRlcm4gTGlz cF9PYmplY3QgcmVhZF9kb2Nfc3RyaW5nIChMaXNwX09iamVjdCk7CiBleHRlcm4gTGlzcF9PYmpl Y3QgZ2V0X2RvY19zdHJpbmcgKExpc3BfT2JqZWN0LCBib29sLCBib29sKTsKIGV4dGVybiB2b2lk IHN5bXNfb2ZfZG9jICh2b2lkKTsKLS0gCjIuMjguMAoK --000000000000600faf05b35e729f-- From unknown Mon Aug 18 04:42:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44471: [PATCH] Simplify text-quoting-style Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 Nov 2020 15:57:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44471 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Stefan Kangas Cc: 44471@debbugs.gnu.org Received: via spool by 44471-submit@debbugs.gnu.org id=B44471.160493739923062 (code B ref 44471); Mon, 09 Nov 2020 15:57:01 +0000 Received: (at 44471) by debbugs.gnu.org; 9 Nov 2020 15:56:39 +0000 Received: from localhost ([127.0.0.1]:35278 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kc9X5-0005zu-44 for submit@debbugs.gnu.org; Mon, 09 Nov 2020 10:56:39 -0500 Received: from quimby.gnus.org ([95.216.78.240]:43390) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kc9X3-0005zi-Qh for 44471@debbugs.gnu.org; Mon, 09 Nov 2020 10:56:38 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=+HyLUtao4lMW0C/20N8RZrvrOWRFH9NZ2eQZhsxLurc=; b=E7/7J6n2CixkBUtRCYQH27opnm XKUGAoaC2BPAkBnmI7aLFYL/OOtO458hrYy7RrfC0Oe/tgPvXJhq8MeeAGmxgPdRJHXUXe20Of8zr S9gWHAqE3Ve+cbp3CRz1scYCmWyJU/bfofhEdp3Waay8kYSDTt7wDusEmBpVZeGgkhOQ=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kc9Wr-0007cp-W6; Mon, 09 Nov 2020 16:56:31 +0100 From: Lars Ingebrigtsen References: X-Now-Playing: Irreversible Entanglements's _Irreversible Entanglements_: "Chicago To Texas" Date: Mon, 09 Nov 2020 16:56:24 +0100 In-Reply-To: (Stefan Kangas's message of "Thu, 5 Nov 2020 08:18:21 -0800") Message-ID: <87zh3qjzh3.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Kangas writes: > I found an opportunity to simplify the code for text-quoting-style. See > the attached patch. > > The patch also improves the name of the defun `get-quoting-style' by > changing it to `text-quoting- [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: > I found an opportunity to simplify the code for text-quoting-style. See > the attached patch. > > The patch also improves the name of the defun `get-quoting-style' by > changing it to `text-quoting-style'. (This new name matches the old C > function name and the existing variable name.) > > Any comments? Makes sense to me. And since get-quoting-style is new in Emacs 28 (I think?), no deprecation should be necessary. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Mon Aug 18 04:42:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44471: [PATCH] Simplify text-quoting-style Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 Nov 2020 20:14:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44471 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Lars Ingebrigtsen Cc: 44471@debbugs.gnu.org Received: via spool by 44471-submit@debbugs.gnu.org id=B44471.160495281215008 (code B ref 44471); Mon, 09 Nov 2020 20:14:01 +0000 Received: (at 44471) by debbugs.gnu.org; 9 Nov 2020 20:13:32 +0000 Received: from localhost ([127.0.0.1]:35655 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcDXg-0003tz-42 for submit@debbugs.gnu.org; Mon, 09 Nov 2020 15:13:32 -0500 Received: from mail-ed1-f46.google.com ([209.85.208.46]:39238) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcDXe-0003tg-2N for 44471@debbugs.gnu.org; Mon, 09 Nov 2020 15:13:30 -0500 Received: by mail-ed1-f46.google.com with SMTP id e18so10151198edy.6 for <44471@debbugs.gnu.org>; Mon, 09 Nov 2020 12:13:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=k/k55n7gMetp/Q0Wd94NX7PIhIi+K+xBkgL/1NynGi8=; b=qjcEynuP5KLkxiPZF5meB4YpZvE17qqTjmBhhgO2rHhRzYlxmTfZa6LljiQctmWNWw 1n5uzNW+QsSnznhOz7LxM86MH5sYCrb+sQjY/JOp0Z0CRVLLHKBuww5N+dWeMEQ1BJiY D5iku2rTGWosZW4iMzbUoR/hnp3srGAMU/pNDZJXbp8xLaNAodRJ49N452vPP7P3PxRY oVKM7pWrq9pBNcCT0qXAfzsQK9gMvhtFGL4E+XbkPeNlerSxwIovhXdnlxf2nLZ6fVAA 8lg1U+or6ccsanYokXXjGo9NbfJJDjiLefNrULeu58T0sVvVemLBI1DlDVMGHQ8E3Xkh KOMQ== X-Gm-Message-State: AOAM533yAd2oIh1ETbWLW9o1EvoTWxWGgkEOKWrIav4yZp+6KHWXG55J s6Kzcjy/6SNYJ61afpk1TFLjRtmUVfDnD3bglI0= X-Google-Smtp-Source: ABdhPJxkm4s82pZ3CJR7mJOZJ/uGQrLLlYZNH1i2rPWje4w5BotOeKIqCewDf2m2QKON90S/BNOj3Ir07xtq+75Fgv8= X-Received: by 2002:a05:6402:1114:: with SMTP id u20mr14541543edv.377.1604952804251; Mon, 09 Nov 2020 12:13:24 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Mon, 9 Nov 2020 12:13:23 -0800 From: Stefan Kangas In-Reply-To: <87zh3qjzh3.fsf@gnus.org> References: <87zh3qjzh3.fsf@gnus.org> MIME-Version: 1.0 Date: Mon, 9 Nov 2020 12:13:23 -0800 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) tags 44471 fixed close 44471 28.1 thanks Lars Ingebrigtsen writes: > Stefan Kangas writes: > >> I found an opportunity to simplify the code for text-quoting-style. See >> the attached patch. >> >> The patch also improves the name of the defun `get-quoting-style' by >> changing it to `text-quoting-style'. (This new name matches the old C >> function name and the existing variable name.) >> >> Any comments? > > Makes sense to me. Thanks. There have been no other comments, so I've pushed this to master as commit 95c04675ab. > And since get-quoting-style is new in Emacs 28 (I think?), no > deprecation should be necessary. Yes, it is not even a month old (and added by yours truly). From unknown Mon Aug 18 04:42:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44471: [PATCH] Simplify text-quoting-style Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 Nov 2020 14:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44471 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch To: Stefan Kangas Cc: 44471@debbugs.gnu.org Received: via spool by 44471-submit@debbugs.gnu.org id=B44471.160501862115297 (code B ref 44471); Tue, 10 Nov 2020 14:31:02 +0000 Received: (at 44471) by debbugs.gnu.org; 10 Nov 2020 14:30:21 +0000 Received: from localhost ([127.0.0.1]:36883 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcUf6-0003yf-M1 for submit@debbugs.gnu.org; Tue, 10 Nov 2020 09:30:20 -0500 Received: from quimby.gnus.org ([95.216.78.240]:53954) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcUf5-0003yP-Lm for 44471@debbugs.gnu.org; Tue, 10 Nov 2020 09:30:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=zxCE3Y62oFBwSRwFcLC2E3Bg/RVZlUzWSzqoptVM25A=; b=BfelfQZR+rGlxqJA5jcp/1yO0c z0l6MRNVvpnFDzXaOxh9Vj7OYanwleCinPDN4dXOoR9F9PcbHOKVlXuhk0zsCSJbYsMppx1q737Ou 4naBB9Qm71wsEneM1B1hEzcH3Je1W4s7kM/jg1Na9dWvDep02iJZ7vXVcCPMdP6w3JbQ=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kcUew-0003Bz-Vp; Tue, 10 Nov 2020 15:30:13 +0100 From: Lars Ingebrigtsen References: <87zh3qjzh3.fsf@gnus.org> X-Now-Playing: Deathcrush's _The Single Series_: "Lesson #14 for Bethan Peters: Smooth" Date: Tue, 10 Nov 2020 15:30:09 +0100 In-Reply-To: (Stefan Kangas's message of "Mon, 9 Nov 2020 12:13:23 -0800") Message-ID: <87zh3pgu8e.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Kangas writes: > Yes, it is not even a month old (and added by yours truly). Right. :-) Perhaps this function should have a NEWS entry? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: > Yes, it is not even a month old (and added by yours truly). Right. :-) Perhaps this function should have a NEWS entry? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Mon Aug 18 04:42:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44471: [PATCH] Simplify text-quoting-style Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 10 Nov 2020 16:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44471 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch To: Stefan Kangas Cc: larsi@gnus.org, 44471@debbugs.gnu.org Received: via spool by 44471-submit@debbugs.gnu.org id=B44471.160502474927004 (code B ref 44471); Tue, 10 Nov 2020 16:13:01 +0000 Received: (at 44471) by debbugs.gnu.org; 10 Nov 2020 16:12:29 +0000 Received: from localhost ([127.0.0.1]:38732 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcWFx-00071S-Bt for submit@debbugs.gnu.org; Tue, 10 Nov 2020 11:12:29 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33610) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcWFw-00071H-2Q for 44471@debbugs.gnu.org; Tue, 10 Nov 2020 11:12:28 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35272) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kcWFq-0006ng-9V; Tue, 10 Nov 2020 11:12:22 -0500 Received: from [176.228.60.248] (port=2843 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kcWFo-0008Pt-SA; Tue, 10 Nov 2020 11:12:21 -0500 Date: Tue, 10 Nov 2020 18:12:31 +0200 Message-Id: <831rh12ntc.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Stefan Kangas on Mon, 9 Nov 2020 12:13:23 -0800) References: <87zh3qjzh3.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Mon, 9 Nov 2020 12:13:23 -0800 > Cc: 44471@debbugs.gnu.org > > Lars Ingebrigtsen writes: > > > Stefan Kangas writes: > > > >> I found an opportunity to simplify the code for text-quoting-style. See > >> the attached patch. > >> > >> The patch also improves the name of the defun `get-quoting-style' by > >> changing it to `text-quoting-style'. (This new name matches the old C > >> function name and the existing variable name.) > >> > >> Any comments? > > > > Makes sense to me. > > Thanks. There have been no other comments, so I've pushed this to > master as commit 95c04675ab. Please in the future allow more than just a couple of days for people to comment on non-trivial patches. As it happens, I do have a few issues with the change: . it slows down code of two very popular functions, because we now use EQ instead of a C-level equality operator; . it introduces a function that has the same name as a variable, which adds a bit to confusion, and also defeats our method of reporting in what version was the function/variable introduced (try "C-h f"); and . I don't think I see the simplification that justifies these (admittedly quite minor) downsides Thanks. From unknown Mon Aug 18 04:42:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44471: [PATCH] Simplify text-quoting-style Resent-From: Stefan Kangas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Nov 2020 19:13:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44471 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch To: Eli Zaretskii Cc: larsi@gnus.org, 44471@debbugs.gnu.org Received: via spool by 44471-submit@debbugs.gnu.org id=B44471.160512195324861 (code B ref 44471); Wed, 11 Nov 2020 19:13:01 +0000 Received: (at 44471) by debbugs.gnu.org; 11 Nov 2020 19:12:33 +0000 Received: from localhost ([127.0.0.1]:42850 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcvXl-0006Sv-Eq for submit@debbugs.gnu.org; Wed, 11 Nov 2020 14:12:33 -0500 Received: from mail-ej1-f47.google.com ([209.85.218.47]:46610) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcvXi-0006Sh-Ur for 44471@debbugs.gnu.org; Wed, 11 Nov 2020 14:12:31 -0500 Received: by mail-ej1-f47.google.com with SMTP id w13so4205182eju.13 for <44471@debbugs.gnu.org>; Wed, 11 Nov 2020 11:12:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=aRn4RbSZJUGSr3wrsU0+tIBn0kIZmPDN5bJm5nc/Fv0=; b=Pkigzsb8ajGx9HkILvXToAwqUx7zpTRE78FKzrBA4SQrbwEn8gspTAPJcwJjPqH4E+ pbhE9JdLqNBRC8jJGettuOyacd687Z6CZBlc/5MnLYRLnbch1vLKhbFcn4tbv62B0wr2 9UvekKIZ0GPUfvqsuORBaRvJMAoVACCz7CY0ILM3W8eHPnKfHxnvxJtdT0JjK4R86uJ2 QMwZnaKehLM7ghRP/orrRqTzEV+LtH6G7f+wXtZcDLBjUA+Qps/iz/JNDQNrCIy0t2yF 5eONJoW9PiglwDIrsXNvE6DzTzXOrfPvs083GMBT5cxKeERoCL+FwjVCTboKwFvsQZaA 5ZCQ== X-Gm-Message-State: AOAM531HzX5StH4OK9Obiu3v8XDtkBPCAAlAp1tlapC2Ogezfh1eXgC6 b41rkSh4rVzToge29pljF0ZSCWmVJXswUXqJD7g= X-Google-Smtp-Source: ABdhPJxbMeAPSswu1QnxaorNerb40K+2xh5AaiYhwZ42xhl3kBAHYYHjkPPBk5epin6Z2GO5/epv1J3A8J+OD93MsFc= X-Received: by 2002:a17:906:1246:: with SMTP id u6mr26351503eja.432.1605121945122; Wed, 11 Nov 2020 11:12:25 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Wed, 11 Nov 2020 14:12:24 -0500 From: Stefan Kangas In-Reply-To: <831rh12ntc.fsf@gnu.org> References: <87zh3qjzh3.fsf@gnus.org> <831rh12ntc.fsf@gnu.org> MIME-Version: 1.0 Date: Wed, 11 Nov 2020 14:12:24 -0500 Message-ID: Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Eli Zaretskii writes: > Please in the future allow more than just a couple of days for people > to comment on non-trivial patches. OK. > As it happens, I do have a few issues with the change: > > . it slows down code of two very popular functions, because we now > use EQ instead of a C-level equality operator; If I understand correctly, EQ(x, y) ends up in a C-level equality operator and a typecast. Is that correct? If yes, is it the typecast that you think will cause a slowdown, or is it something else? I naively thought that this would not make much of a difference, and that, to the extent that it did, the relevant functions are hardly called often enough to matter in the end. But I assume you know more than me here, so please tell me where I'm wrong. > . it introduces a function that has the same name as a variable, > which adds a bit to confusion, and also defeats our method of > reporting in what version was the function/variable introduced > (try "C-h f"); and This is not without precedent, see e.g. `user-full-name'. But if we want to keep my patch we could of course just use the previous name `get-text-style' instead. > . I don't think I see the simplification that justifies these > (admittedly quite minor) downsides I agree it is minor, but I see one function less, one less enum, and overall fewer lines of code. I'm happy to revert it if the change is not wanted. From unknown Mon Aug 18 04:42:06 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44471: [PATCH] Simplify text-quoting-style Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 11 Nov 2020 19:25:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44471 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch To: Stefan Kangas Cc: larsi@gnus.org, 44471@debbugs.gnu.org Received: via spool by 44471-submit@debbugs.gnu.org id=B44471.160512268326280 (code B ref 44471); Wed, 11 Nov 2020 19:25:02 +0000 Received: (at 44471) by debbugs.gnu.org; 11 Nov 2020 19:24:43 +0000 Received: from localhost ([127.0.0.1]:42872 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcvjW-0006po-T7 for submit@debbugs.gnu.org; Wed, 11 Nov 2020 14:24:43 -0500 Received: from eggs.gnu.org ([209.51.188.92]:56300) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcvjU-0006pS-Rn for 44471@debbugs.gnu.org; Wed, 11 Nov 2020 14:24:41 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35411) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kcvjP-0007Gr-BA; Wed, 11 Nov 2020 14:24:35 -0500 Received: from [176.228.60.248] (port=4246 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kcvjO-0006YF-HQ; Wed, 11 Nov 2020 14:24:34 -0500 Date: Wed, 11 Nov 2020 21:24:46 +0200 Message-Id: <83y2j7zog1.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: (message from Stefan Kangas on Wed, 11 Nov 2020 14:12:24 -0500) References: <87zh3qjzh3.fsf@gnus.org> <831rh12ntc.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Stefan Kangas > Date: Wed, 11 Nov 2020 14:12:24 -0500 > Cc: larsi@gnus.org, 44471@debbugs.gnu.org > > > . it slows down code of two very popular functions, because we now > > use EQ instead of a C-level equality operator; > > If I understand correctly, EQ(x, y) ends up in a C-level equality > operator and a typecast. Is that correct? No. EQ either expands to a call to lisp_h_EQ, or calls lisp_h_EQ, which does: #define lisp_h_EQ(x, y) (XLI (x) == XLI (y)) Depending on how Lisp_Object is represented, this could be a typecast or an access to a struct member. > If yes, is it the typecast > that you think will cause a slowdown, or is it something else? the function call and the struct access. > I naively thought that this would not make much of a difference, and > that, to the extent that it did, the relevant functions are hardly > called often enough to matter in the end. The difference is very minor, but the point is that it's a (minor) disadvantage. > > . it introduces a function that has the same name as a variable, > > which adds a bit to confusion, and also defeats our method of > > reporting in what version was the function/variable introduced > > (try "C-h f"); and > > This is not without precedent, see e.g. `user-full-name'. But if we > want to keep my patch we could of course just use the previous name > `get-text-style' instead. > > > . I don't think I see the simplification that justifies these > > (admittedly quite minor) downsides > > I agree it is minor, but I see one function less, one less enum, and > overall fewer lines of code. > > I'm happy to revert it if the change is not wanted. I don't have strong opinions, so I will leave it to you and others. My point, though, is that minor cleanups should preferably not have adverse effects, otherwise their benefit is questionable.