Subject: [bug#44457] [PATCH]: gnu: Add hunspell-dict-it-it.

From: Ludovic Courtès <[email-masked]>
Date: Wed, 23 Dec 2020 17:29:55 +0100

Hi!

paul <[email-masked]> skribis:

> From 17a476dd234fa4a128eb90ccc8ac9a565045bfa1 Mon Sep 17 00:00:00 2001
> From: Giacomo Leidi <[email-masked]>
> Date: Thu, 5 Nov 2020 02:04:20 +0100
> Subject: [PATCH] gnu: Add hunspell-dict-it-it.
>
> * gnu/packages/hunspell.scm: New file;
> (hunspell-dictionary): New variable;
> (hunspell-dict-it-it): New variable.
> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.

I’m picking up this patch as it seems to have fallen through the
cracks.  :-)

Overall it LGTM; a couple of comments below.

Apparently this is different from the Hunspell dictionaries made from
Aspell word lists that appear in (gnu packages aspell), right?

Should we name the packages differently to avoid collisions with the
existing ‘hunspell-dict-*’ packages?

[...]

> +    (synopsis
> +     (string-append "Hunspell dictionary for " full-name " (" dict-name ")"))

This is recommended against as this prevents i18n:

  https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html

You can work around it by writing the string in full, as in:

  (define-public hunspell-dict-it-it
    (let ((synopsis identity))
      (hunspell-dictionary "it_IT" "Italian"
                           #:synopsis (synopsis "Hunspell dictionary for Italian")
                           #:home-page "https://libreitalia.org/"
                           #:license license:gpl3)))

> +                       #:license license:gpl3))

It wondered whether this might be ‘gpl3+’, but
<https://cgit.freedesktop.org/libreoffice/dictionaries/tree/it_IT/README_it_IT.txt>
confirms that this is “version 3 only”; all good!  :-)

Could you send an updated patch?

Thanks,
Ludo’.