GNU bug report logs - #44451
27.1; doc string of `read-char-from-minibuffer'

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Eli Zaretskii <eliz <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#44451: closed (27.1; doc string of `read-char-from-minibuffer')
Date: Sat, 07 Nov 2020 09:14:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Sat, 07 Nov 2020 11:12:53 +0200
with message-id <83mtzt7coa.fsf <at> gnu.org>
and subject line Re: bug#44451: 27.1; doc string of `read-char-from-minibuffer'
has caused the debbugs.gnu.org bug report #44451,
regarding 27.1; doc string of `read-char-from-minibuffer'
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
44451: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=44451
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Drew Adams <drew.adams <at> oracle.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 27.1; doc string of `read-char-from-minibuffer'
Date: Wed, 4 Nov 2020 10:40:01 -0800 (PST)

 "Read a character from the minibuffer, prompting for PROMPT."

You are not prompted for PROMPT.  You are prompted (for a char)
with PROMPT.

 "When HISTORY is a symbol, then allows navigating in a history."

English: it should be "When...symbol, allow navigating..."

But it's not clear what "navigating in a history" means.  The
description of `M-n' etc. isn't clear - or needed.  And what if
HISTORY is non-nil but not a symbol?

In any case, I suggest you just say that HISTORY is passed to
`read-from-minibuffer', which is the case.  That function's HISTORY
description is clear and complete, and it involves more than what is
described here.


In GNU Emacs 27.1 (build 1, x86_64-w64-mingw32)
 of 2020-08-12 built on CIRROCUMULUS
Repository revision: 86d8d76aa36037184db0b2897c434cdaab1a9ae8
Repository branch: HEAD
Windowing system distributor 'Microsoft Corp.', version 10.0.18362
System Description: Microsoft Windows 10 Pro (v10.0.1903.18362.1082)

[Message part 3 (message/rfc822, inline)]

From: Eli Zaretskii <eliz <at> gnu.org>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 44451-done <at> debbugs.gnu.org
Subject: Re: bug#44451: 27.1; doc string of `read-char-from-minibuffer'
Date: Sat, 07 Nov 2020 11:12:53 +0200

> Date: Wed, 4 Nov 2020 10:40:01 -0800 (PST)
> From: Drew Adams <drew.adams <at> oracle.com>
> 
>  "Read a character from the minibuffer, prompting for PROMPT."
> 
> You are not prompted for PROMPT.  You are prompted (for a char)
> with PROMPT.

Fixed.

>  "When HISTORY is a symbol, then allows navigating in a history."
> 
> English: it should be "When...symbol, allow navigating..."

Fixed.

> But it's not clear what "navigating in a history" means.  The
> description of `M-n' etc. isn't clear - or needed.  And what if
> HISTORY is non-nil but not a symbol?

You get an error, I think.

> In any case, I suggest you just say that HISTORY is passed to
> `read-from-minibuffer', which is the case.

That isn't accurate: this function really expects HISTORY to be a
symbol of a history variable.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.