From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 03 10:38:53 2020 Received: (at submit) by debbugs.gnu.org; 3 Nov 2020 15:38:53 +0000 Received: from localhost ([127.0.0.1]:46093 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZyOb-0001ip-Do for submit@debbugs.gnu.org; Tue, 03 Nov 2020 10:38:53 -0500 Received: from lists.gnu.org ([209.51.188.17]:54832) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZyOZ-0001ih-V6 for submit@debbugs.gnu.org; Tue, 03 Nov 2020 10:38:52 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53466) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZyOZ-0001pf-Bv for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2020 10:38:51 -0500 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]:53464) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kZyOU-0003Bv-K7 for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2020 10:38:50 -0500 Received: by mail-wm1-x330.google.com with SMTP id p22so13202661wmg.3 for ; Tue, 03 Nov 2020 07:38:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd-ie.20150623.gappssmtp.com; s=20150623; h=from:to:subject:date:message-id:mime-version; bh=tazjinw3o1Wkcm2vL60DrSZJ1c963t7VXJmX3TO2Vq8=; b=IvfVW/AC6X0T/OVMu879aGFWIhqHCUnRhbRrrQn+BgeXy5xDTY0fUhfq/qnoMu8HLj 3PfgQVjonoRTLFphQHxhTH9ZuwfT8oM2VlN0SR/3DnGLe4fohtyUjf7fHAtj8rMX32DU dh+By2zmFfgdQSVjA6iKHJ7rQ+VQmxAWKvaLHy7VaPanGzR7kub2ickBolwNv9HEdVks ALbdh44DnU1Zsjv8sgFkDoNzx6EqmatNxMUMxO5RUZEUDhLzSutSk+d1drJIBV97pzpZ IhNvti3Ac/MepPVxR/CczxoI3H3dh9wDWM827VINp9ZBuolke6O2LnXefkclDlCnCFG/ GOMQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:mime-version; bh=tazjinw3o1Wkcm2vL60DrSZJ1c963t7VXJmX3TO2Vq8=; b=l3Iu7Te1VlkrVTvUjW2OCJpd8VI6Kh5hYjJovQWykfcaC8r/wXjckAw1a8mnxmh8MP eM7weCkSeev2Uff/s2lM59hfMJjJIuC35JGovgLmlabjgmUPssAfnZtKgLaX7lfxNt95 wxwu6vTq1rUnQWm9DDkoYvobV+dDEemZM+Qe3KgYted15mY/h/WHFNPs3cOKpKNpIbua IDxWw7JdLTfYQulB6t1G/YPyuGMatLiMBmlWLBCEGeX32ec+m0QFoQHePNa/58y1WLkJ qFoeSt/bSxdDI8tQ1KWbjbnj1oXyICPV8a5LpW0+LODlf0wcGQXl2tU5dkZUcBkc2L8t vYtw== X-Gm-Message-State: AOAM533y5Gcab6TkXBV5WyV209YwbIq0acuPCcQTBa0aaEhMAuCTB2Nd 6BmDirwx+EVJacNAuYloESA+Fsrtl8Uo4g== X-Google-Smtp-Source: ABdhPJwWTQA+l8GxzRy64FtpP3S2z0dJlmae8SSmxieTZmojJ0r2Ws+VvwDbl2/bg8iuUEAVK0tJJg== X-Received: by 2002:a1c:5a86:: with SMTP id o128mr306720wmb.129.1604417918046; Tue, 03 Nov 2020 07:38:38 -0800 (PST) Received: from localhost ([2a02:8084:20e2:c380:92bd:1bfd:38fc:fae2]) by smtp.gmail.com with ESMTPSA id o17sm1937523wmd.34.2020.11.03.07.38.37 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Nov 2020 07:38:37 -0800 (PST) From: "Basil L. Contovounesios" To: bug-gnu-emacs@gnu.org Subject: 28.0.50; Spliced variable not matched as symbol in isearch Date: Tue, 03 Nov 2020 15:38:36 +0000 Message-ID: <87zh3yh2mb.fsf@tcd.ie> MIME-Version: 1.0 Content-Type: text/plain Received-SPF: none client-ip=2a00:1450:4864:20::330; envelope-from=contovob@tcd.ie; helo=mail-wm1-x330.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Severity: minor 0. emacs -Q 1. (let (x) `(,@x)) 2. M-s _ x This highlights the bound x, but not the spliced x. The same happens with 'M-s .' or the equivalent 'C-M-s'. This is because lisp--mode-syntax-table gives 'prefix' syntax to ?, and 'symbol' syntax to ?@. Is it possible to give 'prefix' syntax to ",@" as a whole, and in general? [This behaviour exists since at least as far back as Emacs 24.5.1. I wouldn't be surprised if this has been reported before, but my searches came up dry.] Thanks, -- Basil In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, X toolkit, cairo version 1.16.0, Xaw3d scroll bars) of 2020-11-02 built on thunk Repository revision: 95f7a2835a79c1f12b5dc86230405e8040910c72 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12008000 System Description: Debian GNU/Linux bullseye/sid Configured using: 'configure 'CC=ccache gcc' 'CFLAGS=-O2 -march=native' --config-cache --prefix=/home/blc/.local --with-x-toolkit=lucid --with-file-notification=yes --with-x' Configured features: XAW3D XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GSETTINGS GLIB NOTIFY INOTIFY ACL LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF ZLIB TOOLKIT_SCROLL_BARS LUCID X11 XDBE XIM MODULES THREADS LIBSYSTEMD JSON PDUMPER LCMS2 Important settings: value of $LANG: en_IE.UTF-8 value of $XMODIFIERS: @im=ibus locale-coding-system: utf-8-unix Major mode: Lisp Interaction Minor modes in effect: tooltip-mode: t global-eldoc-mode: t eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs rfc822 mml easymenu mml-sec epa derived epg epg-config gnus-util rmail rmail-loaddefs auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json map text-property-search time-date subr-x seq byte-opt gv bytecomp byte-compile cconv mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader cl-loaddefs cl-lib sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils misearch multi-isearch tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 52709 5287) (symbols 48 6786 1) (strings 32 19027 1309) (string-bytes 1 616874) (vectors 16 12242) (vector-slots 8 168612 9829) (floats 8 23 45) (intervals 56 231 0) (buffers 992 10)) From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 07 06:30:09 2022 Received: (at 44418) by debbugs.gnu.org; 7 Jun 2022 10:30:09 +0000 Received: from localhost ([127.0.0.1]:38178 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyWTQ-000493-Ov for submit@debbugs.gnu.org; Tue, 07 Jun 2022 06:30:09 -0400 Received: from quimby.gnus.org ([95.216.78.240]:51348) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyWTK-00044j-1W for 44418@debbugs.gnu.org; Tue, 07 Jun 2022 06:30:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=AkHh3eJWK2udFUurJpk5zggSAAii5gQgQ0Wpls63De8=; b=ZIA51Kk4Mb3ltE3XY7+UnWByUc aWAsg0oEinNeCWKiqRwj4OfBrfZK0IRp9QXz440uKo87zir5uBsIYD+6X/sXWbRdbt8rk3m/M0skc 2afyj+DN568v7fgKQGJZ0TpkbvlaMEI0RonDsmZzuuEbelYRKKc5uQxPoKxRuKdl72zw=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nyWT9-0001IY-V4; Tue, 07 Jun 2022 12:29:54 +0200 From: Lars Ingebrigtsen To: "Basil L. Contovounesios" Subject: Re: bug#44418: 28.0.50; Spliced variable not matched as symbol in isearch References: <87zh3yh2mb.fsf@tcd.ie> X-Now-Playing: Blaine L. Reininger's _Commissions 2 (1)_: "Atomium Sunrise" Date: Tue, 07 Jun 2022 12:29:51 +0200 In-Reply-To: <87zh3yh2mb.fsf@tcd.ie> (Basil L. Contovounesios's message of "Tue, 03 Nov 2020 15:38:36 +0000") Message-ID: <87v8tclqao.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: "Basil L. Contovounesios" writes: > 0. emacs -Q > 1. (let (x) `(,@x)) > 2. M-s _ x > > This highlights the bound x, but not the spliced x. The same happens > with 'M-s .' or the equivalent 'C-M-s'. > > This is because lisp--mode-synta [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44418 Cc: 44418@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) "Basil L. Contovounesios" writes: > 0. emacs -Q > 1. (let (x) `(,@x)) > 2. M-s _ x > > This highlights the bound x, but not the spliced x. The same happens > with 'M-s .' or the equivalent 'C-M-s'. > > This is because lisp--mode-syntax-table gives 'prefix' syntax to ?, and > 'symbol' syntax to ?@. Is it possible to give 'prefix' syntax to ",@" > as a whole, and in general? (This is still present in Emacs 29.) I'm not sure whether that is possible or not -- perhaps Stefan knows; added to the CCs. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 07 08:05:43 2022 Received: (at 44418) by debbugs.gnu.org; 7 Jun 2022 12:05:43 +0000 Received: from localhost ([127.0.0.1]:38885 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyXxu-0005I7-Nj for submit@debbugs.gnu.org; Tue, 07 Jun 2022 08:05:42 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:19286) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyXxs-0005Hs-K2 for 44418@debbugs.gnu.org; Tue, 07 Jun 2022 08:05:41 -0400 Received: from pmg2.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id BB1558108D; Tue, 7 Jun 2022 08:05:33 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg2.iro.umontreal.ca (Proxmox) with ESMTP id 45213808E1; Tue, 7 Jun 2022 08:05:32 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1654603532; bh=Li1i9lqnwLeSLVvGGNVWnD61fybJQyDFQlkiELBhVgY=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=GgDcT8kE9vhFwJ6mTc7x1aeGtZwYSmHWZhvE0pFOm0/4cdkvem5ib/JHsRFxjjXbV 7QMgHPz8RcWbOsSOQpJLDQQCPlWY8iEOMwqXwz4Ygg5/DeNHKzE7rWPFKIcYMuy0O3 cU2AxyJpAOJ/GaN+W+d25l1yCJfCOXEtREUOe7/dhH2O5Sl/KRDX+9t19Q4b2zWqYE wuPCJYaCkh2WJiWSE1bu7fuVHm5mxTTPvRED9uRv5nNCRBMk36QPadWYB4sBQvLNQ0 tFI8BqO72eseJFdGZPx62uDFL+ohgW00WwwiKQQHj8mRJZ5IRg2C7fgly7cQOg+WXu 7V4MBylCzeVzw== Received: from pastel (unknown [45.72.221.51]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 0F78F1202AF; Tue, 7 Jun 2022 08:05:32 -0400 (EDT) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#44418: 28.0.50; Spliced variable not matched as symbol in isearch Message-ID: References: <87zh3yh2mb.fsf@tcd.ie> <87v8tclqao.fsf@gnus.org> Date: Tue, 07 Jun 2022 08:05:31 -0400 In-Reply-To: <87v8tclqao.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 07 Jun 2022 12:29:51 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.056 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44418 Cc: "Basil L. Contovounesios" , 44418@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> 0. emacs -Q >> 1. (let (x) `(,@x)) >> 2. M-s _ x >> >> This highlights the bound x, but not the spliced x. The same happens >> with 'M-s .' or the equivalent 'C-M-s'. >> >> This is because lisp--mode-syntax-table gives 'prefix' syntax to ?, and >> 'symbol' syntax to ?@. Is it possible to give 'prefix' syntax to ",@" >> as a whole, and in general? > > (This is still present in Emacs 29.) > > I'm not sure whether that is possible or not -- perhaps Stefan knows; > added to the CCs. `@x` is a valid symbol, which is why `?@` is given symbol syntax. If we want to fix the above search we need to use `syntax-propertize-function` to change the syntax of those `@` that follow a comma. Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 07 13:45:32 2022 Received: (at 44418) by debbugs.gnu.org; 7 Jun 2022 17:45:32 +0000 Received: from localhost ([127.0.0.1]:41425 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nydGl-0004RA-Vc for submit@debbugs.gnu.org; Tue, 07 Jun 2022 13:45:32 -0400 Received: from quimby.gnus.org ([95.216.78.240]:56246) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nydGi-0004Qx-W6 for 44418@debbugs.gnu.org; Tue, 07 Jun 2022 13:45:30 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=pL+eu3iIZ+KCB8XkRwRNyGsk2FYK7H+eq0l3R9nt9H0=; b=ZR5SfQe3F3yUP1s7uB0irCFQpF KeoulpD7oZLhJ9Ul6J3onzOyQFHnhRjU6Zu2v9x1XvilR3iVlaMigE8dEQTzg3sSKKicO3QZcRjC5 mFMtrJyRHl1avvDclLp0+mt9w96xcXXV1cAU+Osiz3PE8SQcQ0Xaq/CI8UI+3Nqcmm5c=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nydGX-0006Gf-Qg; Tue, 07 Jun 2022 19:45:20 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#44418: 28.0.50; Spliced variable not matched as symbol in isearch References: <87zh3yh2mb.fsf@tcd.ie> <87v8tclqao.fsf@gnus.org> Date: Tue, 07 Jun 2022 19:45:16 +0200 In-Reply-To: (Stefan Monnier's message of "Tue, 07 Jun 2022 08:05:31 -0400") Message-ID: <871qw0e5ar.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: > `@x` is a valid symbol, which is why `?@` is given symbol syntax. > If we want to fix the above search we need to use > `syntax-propertize-function` to change the syntax of those `@` that > follow a [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44418 Cc: "Basil L. Contovounesios" , 44418@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Monnier writes: > `@x` is a valid symbol, which is why `?@` is given symbol syntax. > If we want to fix the above search we need to use > `syntax-propertize-function` to change the syntax of those `@` that > follow a comma. The following seems to do the trick -- does this look OK to you? diff --git a/lisp/progmodes/elisp-mode.el b/lisp/progmodes/elisp-mode.el index 77bf3f1ed1..210270bc67 100644 --- a/lisp/progmodes/elisp-mode.el +++ b/lisp/progmodes/elisp-mode.el @@ -245,6 +245,9 @@ elisp-mode-syntax-propertize ;; Empty symbol. ("##" (0 (unless (nth 8 (syntax-ppss)) (string-to-syntax "_")))) + ;; Give ,@ a prefix syntax. + (",@" (0 (unless (ppss-comment-or-string-start (syntax-ppss)) + (string-to-syntax "'")))) ;; Unicode character names. (The longest name is 88 characters ;; long.) ("\\?\\\\N{[-A-Za-z0-9 ]\\{,100\\}}" -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 07 14:20:53 2022 Received: (at 44418) by debbugs.gnu.org; 7 Jun 2022 18:20:53 +0000 Received: from localhost ([127.0.0.1]:41453 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nydoz-0007YS-7g for submit@debbugs.gnu.org; Tue, 07 Jun 2022 14:20:53 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:14552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nydok-0007Xt-A4 for 44418@debbugs.gnu.org; Tue, 07 Jun 2022 14:20:52 -0400 Received: from pmg1.iro.umontreal.ca (localhost.localdomain [127.0.0.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id D7672100E70; Tue, 7 Jun 2022 14:20:32 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg1.iro.umontreal.ca (Proxmox) with ESMTP id 4F52810048C; Tue, 7 Jun 2022 14:20:30 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1654626030; bh=uzpNfThg75SlFfY0usr3xZ5efYbFs16lHdmwY4/1wHk=; h=From:To:Cc:Subject:References:Date:In-Reply-To:From; b=nJaYxqrczXhvBdeJsnzlQ8/59pSXIxO5vEaGROTjlGnOMLLJ0tZqZvbdTdaD0reQM 8ch+T37L9QTnNYd1YAdAsCvXPpQkKg43QpHdxRyVdSGYrp8f6aNXd94zy1RjA8qdO3 YLSSGHmN8NiliROGt0YncOugLF8PT6nrkvpRvhN+E4BjvLxPApu652NfYTO5y8DErl bK2+CvvXNqyFVCs0rRIAVQE31eGBiTpL9nINxAn9rsY6mdEGvenTBP4S/JTg68EPUn 6mTlm9WMi9SQspe+dKEaDiRXHXJOr5v86ikUJfjnJOoAZyEknSuF+J4H7cpRyc2mXI v+FtLknWzF9vg== Received: from alfajor (unknown [45.44.229.252]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 218F7120246; Tue, 7 Jun 2022 14:20:30 -0400 (EDT) From: Stefan Monnier To: Lars Ingebrigtsen Subject: Re: bug#44418: 28.0.50; Spliced variable not matched as symbol in isearch Message-ID: References: <87zh3yh2mb.fsf@tcd.ie> <87v8tclqao.fsf@gnus.org> <871qw0e5ar.fsf@gnus.org> Date: Tue, 07 Jun 2022 14:20:29 -0400 In-Reply-To: <871qw0e5ar.fsf@gnus.org> (Lars Ingebrigtsen's message of "Tue, 07 Jun 2022 19:45:16 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.042 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 44418 Cc: "Basil L. Contovounesios" , 44418@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > The following seems to do the trick -- does this look OK to you? Fine by me, Stefan From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 07 14:28:28 2022 Received: (at 44418) by debbugs.gnu.org; 7 Jun 2022 18:28:28 +0000 Received: from localhost ([127.0.0.1]:41464 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nydwK-0007k7-E9 for submit@debbugs.gnu.org; Tue, 07 Jun 2022 14:28:28 -0400 Received: from quimby.gnus.org ([95.216.78.240]:56608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nydwG-0007jl-U3 for 44418@debbugs.gnu.org; Tue, 07 Jun 2022 14:28:26 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=hW1tFElVdZ+xoWFYkCDw4YxOgC73dXb9OoIfSWtapgY=; b=fPXoOJh5FFr2pnXAiUBhU78apQ WqP5j1N8bDZDcq6JJ9Nn21Q/Q1fbok4oXiQ0gJnUgmqBycSm8sUmw+HRcO2xMeikfZAjce65hgr6q pgqw1aUZ72trylXkWK+RLgHweo7UlsoDcTEfPwxtkVfpvDYrvFOESPypRVpEdArIxkZE=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nydw6-0006nu-75; Tue, 07 Jun 2022 20:28:16 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#44418: 28.0.50; Spliced variable not matched as symbol in isearch References: <87zh3yh2mb.fsf@tcd.ie> <87v8tclqao.fsf@gnus.org> <871qw0e5ar.fsf@gnus.org> Date: Tue, 07 Jun 2022 20:28:13 +0200 In-Reply-To: (Stefan Monnier's message of "Tue, 07 Jun 2022 14:20:29 -0400") Message-ID: <87fskgcoqq.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Monnier writes: >> The following seems to do the trick -- does this look OK to you? > > Fine by me, OK; now pushed to Emacs 29. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44418 Cc: "Basil L. Contovounesios" , 44418@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Stefan Monnier writes: >> The following seems to do the trick -- does this look OK to you? > > Fine by me, OK; now pushed to Emacs 29. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Jun 07 14:28:30 2022 Received: (at control) by debbugs.gnu.org; 7 Jun 2022 18:28:30 +0000 Received: from localhost ([127.0.0.1]:41467 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nydwM-0007kG-L0 for submit@debbugs.gnu.org; Tue, 07 Jun 2022 14:28:30 -0400 Received: from quimby.gnus.org ([95.216.78.240]:56624) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nydwJ-0007jp-Iw for control@debbugs.gnu.org; Tue, 07 Jun 2022 14:28:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=GdznN4K4ayC/oPedPSqv/ncJDde74gjm6EruQRxAb4M=; b=VrOsDLJpMduGUxmHLtRlpvc40c w2vljYYjhCu7SqrFa6JAu60LUxLeJWJTZpSV2i/c6Jw6ESkSnV1Sr1MhNGNiJjoHKVIWOF8MzTug/ 2FtWbw6ZwBsMLobZMYDAlLAL3kzaKgpAVXqQBZCoKIOuUlBLJmX8yxaW4rjYotha1Bfg=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nydwB-0006o5-MI for control@debbugs.gnu.org; Tue, 07 Jun 2022 20:28:21 +0200 Date: Tue, 07 Jun 2022 20:28:19 +0200 Message-Id: <87ee00coqk.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #44418 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: close 44418 29.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) close 44418 29.1 quit From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 08 08:29:20 2022 Received: (at 44418) by debbugs.gnu.org; 8 Jun 2022 12:29:20 +0000 Received: from localhost ([127.0.0.1]:42707 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyuoK-0006I9-CG for submit@debbugs.gnu.org; Wed, 08 Jun 2022 08:29:20 -0400 Received: from quimby.gnus.org ([95.216.78.240]:36752) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1nyuoH-0006Hp-DY for 44418@debbugs.gnu.org; Wed, 08 Jun 2022 08:29:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=TvkR7DoMnqFy5A6NdtroYP7SfaZyrJHdvaeE4DTEOZA=; b=qoITYVvQNK2rJJgYo+o2XX1fs8 IO1bxnfghLNqKxv37InXBlwSvZJ+YiHmyMwv8QpGI2O1A5zXdBNmWBWRil6G8qAvpdGT0t4Stk58K 3t6iHRWHncsYTPxXF6Q4/PcBuNWx5t73s/5qcE+sh425SNJDVOHQ1Ddbvrg7HyXc33hM=; Received: from [84.212.220.105] (helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1nyuo7-0006nB-Ap; Wed, 08 Jun 2022 14:29:09 +0200 From: Lars Ingebrigtsen To: Stefan Monnier Subject: Re: bug#44418: 28.0.50; Spliced variable not matched as symbol in isearch References: <87zh3yh2mb.fsf@tcd.ie> <87v8tclqao.fsf@gnus.org> <871qw0e5ar.fsf@gnus.org> Date: Wed, 08 Jun 2022 14:29:06 +0200 In-Reply-To: (Stefan Monnier's message of "Tue, 07 Jun 2022 14:20:29 -0400") Message-ID: <87h74v9w4t.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/29.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: This led to edebug tests hanging, so I've reverted the change for now and am reopening this bug report. The offending change was d003848b5e3ad2dfbe84cc62b99776fdc6734325. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44418 Cc: "Basil L. Contovounesios" , 44418@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) This led to edebug tests hanging, so I've reverted the change for now and am reopening this bug report. The offending change was d003848b5e3ad2dfbe84cc62b99776fdc6734325. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Mon Aug 18 07:45:34 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug No longer marked as fixed in versions 29.1 and reopened. Date: Wed, 08 Jun 2022 12:30:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug No longer marked as fixed in versions 29.1 and reopened. thanks # This fakemail brought to you by your local debbugs # administrator From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 21 11:59:53 2023 Received: (at 44418) by debbugs.gnu.org; 21 Jun 2023 15:59:53 +0000 Received: from localhost ([127.0.0.1]:34133 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qC0FN-0002fL-HA for submit@debbugs.gnu.org; Wed, 21 Jun 2023 11:59:53 -0400 Received: from mail-lf1-f44.google.com ([209.85.167.44]:53308) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qC0FL-0002f7-8g for 44418@debbugs.gnu.org; Wed, 21 Jun 2023 11:59:52 -0400 Received: by mail-lf1-f44.google.com with SMTP id 2adb3069b0e04-4f640e48bc3so8209138e87.2 for <44418@debbugs.gnu.org>; Wed, 21 Jun 2023 08:59:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687363185; x=1689955185; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:sender:from:to:cc:subject:date :message-id:reply-to; bh=TE001Z9gk1cagnXjZijl6umBJ7KqhdaHZLDm7FYar/Y=; b=jxc962vgjfpKq/PuyoPxFSO2cdCylVNBCz/kVij5xwULrMjmRnp6BG0aSLXQ8ci60a Wqgv3AP2TLEgXRpZsL76COrtU+s1ri/2wNDi/bNVQLNBqMpX+7Qll24a9/fRXEbzbuLm 5EcvCp67gGZAyz+hYWolPw6j0cj9K3V9B+V/fxgKgkekCBF8w21276QTS3DWALLE3jBT 6IKkiXFQ2+47nGQQ1KcciGfX2gevWyRVdAWvsSDJdZJpEKSt6YwqvAXwrnX5gpm5UGoI 6qWeMLz8MVvnAVNSgSxIyPN1yrUnmRitbR0ygkg+4Isokroe/W8JuQs6JHH9IuWvSun3 IgNQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687363185; x=1689955185; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:sender:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=TE001Z9gk1cagnXjZijl6umBJ7KqhdaHZLDm7FYar/Y=; b=gR74qVBdoAQicb41Zmso+kwLJk+Ky3wysMzA3RAi7cKbH/RhnZ8r+hrfNeHzu19rEa Sjh33agHGJwWuuA9Yth4lIL3IF5TBzLwZkCbpjO3j9vYcz2pC/VNL+xDjatF8yj0FwX8 d1tMdTm/1UvNj04lTZPM2hN7aNo0u0bTwSdpC/iZ6rEitycf1q1gRWeGwAQeOB+fius9 /zjwyxWUOQ7HiHkW+otQGpQiN944uZ5BtpzJxrsgrHHYYjubOy63Xn2KWoKzSIUWN4J6 hsN4Wjl71jEeCu2oNlKCxQZqnAff00+8h8i4woVeSnHxr5C6vG5dR6GYU9D1K0SKrr/a 5vcA== X-Gm-Message-State: AC+VfDz4IucdaJiEOEFx/2OGnzdwa3H7Qrz0qyV+7ee8o6ATg2JjF9hP k2Fls7GQJNGBKyK+3izqHntgCK7xXfk= X-Google-Smtp-Source: ACHHUZ6zC/GEljFwfe+FEb5ToB3cNajWg17MZeALKYIz09xcPCJ5m0zD7nAJu8JYot+YqeOfw3pykQ== X-Received: by 2002:a19:d609:0:b0:4f3:a71a:9e5f with SMTP id n9-20020a19d609000000b004f3a71a9e5fmr9787130lfg.65.1687363185208; Wed, 21 Jun 2023 08:59:45 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id eo13-20020a056512480d00b004f84226f0b5sm819381lfb.59.2023.06.21.08.59.44 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Jun 2023 08:59:44 -0700 (PDT) From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: bug#44418: 28.0.50; Spliced variable not matched as symbol in isearch Message-Id: <16025AD0-9B58-4020-AEBF-C518D1CDE51A@gmail.com> Date: Wed, 21 Jun 2023 17:59:44 +0200 To: Lars Ingebrigtsen X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44418 Cc: Basil Contovounesios , 44418@debbugs.gnu.org, Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) A tentative fix has been pushed to master. I didn't bother with a NEWS = entry but will be happy to add one if someone thinks it would be useful. From debbugs-submit-bounces@debbugs.gnu.org Wed Jun 21 13:15:28 2023 Received: (at 44418) by debbugs.gnu.org; 21 Jun 2023 17:15:28 +0000 Received: from localhost ([127.0.0.1]:34172 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qC1QW-0005Fu-8n for submit@debbugs.gnu.org; Wed, 21 Jun 2023 13:15:28 -0400 Received: from eggs.gnu.org ([209.51.188.92]:44620) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qC1QR-0005FT-Cb for 44418@debbugs.gnu.org; Wed, 21 Jun 2023 13:15:26 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qC1QL-00020j-Hc; Wed, 21 Jun 2023 13:15:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=SZA8M/y6rpLUhxXRqq3OgEw5AohZNMLHpaMnum/ZUMo=; b=nJ5uepaAK5lmEqSRQqKG lwKg0sUKUVe51Kbici3/nyQdC2JGbkVqC0wR6CNU7izPsNc/DrXKmYN8lfqIZ34VPFylJMl9In+SP sOYoCRcgJPVIXUTifwKxzahgLsZFEla+gOHzJaGHxRrpfUJY2br+sSGBwXVe+u5LwG+/T/rg8NjdE Wivam2KG59N4jxn5OY28Qd8IzMOCqE5ZCkigPHURitBrs+5Z0mJ/bZRfgaY4MPa9fxO6/vRNVA03s vUJXSLedS5xBAqIWh2bNk0Hfev2W5OYQdXbBgmVb3akeiDVZtvmmiK+MyVmos0s8KymBGtA++9bNc xZTX1keCRWxIiA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qC1QL-0000Sl-19; Wed, 21 Jun 2023 13:15:17 -0400 Date: Wed, 21 Jun 2023 20:15:26 +0300 Message-Id: <83fs6k4tzl.fsf@gnu.org> From: Eli Zaretskii To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <16025AD0-9B58-4020-AEBF-C518D1CDE51A@gmail.com> (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Wed, 21 Jun 2023 17:59:44 +0200) Subject: Re: bug#44418: 28.0.50; Spliced variable not matched as symbol in isearch References: <87zh3yh2mb.fsf@tcd.ie> <16025AD0-9B58-4020-AEBF-C518D1CDE51A@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44418 Cc: contovob@tcd.ie, 44418@debbugs.gnu.org, larsi@gnus.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: Basil Contovounesios , 44418@debbugs.gnu.org, > Stefan Monnier > From: Mattias Engdegård > Date: Wed, 21 Jun 2023 17:59:44 +0200 > > A tentative fix has been pushed to master. I didn't bother with a NEWS entry but will be happy to add one if someone thinks it would be useful. If this changes user-facing behavior or behavior of public functions, I think we must call this out in NEWS, under "incompatible changes". Thanks. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 22 04:50:28 2023 Received: (at 44418) by debbugs.gnu.org; 22 Jun 2023 08:50:28 +0000 Received: from localhost ([127.0.0.1]:34796 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCG1M-0000ix-GR for submit@debbugs.gnu.org; Thu, 22 Jun 2023 04:50:28 -0400 Received: from mail-lf1-f53.google.com ([209.85.167.53]:57522) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCG1K-0000ib-LL for 44418@debbugs.gnu.org; Thu, 22 Jun 2023 04:50:27 -0400 Received: by mail-lf1-f53.google.com with SMTP id 2adb3069b0e04-4f86a7a5499so7094987e87.2 for <44418@debbugs.gnu.org>; Thu, 22 Jun 2023 01:50:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687423820; x=1690015820; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=pQd1Bgo3bDivMbds4kNC+yAAyxfytuHePsG2VApbP9s=; b=UoxTNeCkGQf6vEpcaiOCjdJi/pI4LDuu6jHnhH2Yo+rhAktvu5lL515oDTa9AHilEa Tz60NZk1WpInzCkRCgs1craS/Pvlq6n+/sgzXTqHnYv1s8hbucGbjKP1sTgbq208ZiUR sVNQQbBvQjVhNYTAIxYTVQe0WIQnxv7wCeGBHEvtzz47P5g9Ri1eEL04vDIG4yvy3fQ4 z+ogKLjOchxtW5XjNlcCLcZUeVE4I6oTGH7c/fhd/24E6eoI+Mf59oSz8krM69rwrFn5 3KIXPRt3EfA0d5pW/o87QRMuXMj2omWApJA1EGCsgmA3Lgx/QEeE4puY6FlOxYzBOZbE RnFA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687423820; x=1690015820; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=pQd1Bgo3bDivMbds4kNC+yAAyxfytuHePsG2VApbP9s=; b=PxsCMdDmql5MGuJPPkhRBvLlYwMotG6gL1SvOkAbG/dv69FFVTaa1HzHIunhLQFDJe 41wOoEzmf/9YBeLU0mxcaLfMmzj1zawa8n8lK6B5NS72yHQwCln2fwxVTIHBAGMfBGum j+3z5JugIGQ0Dams+gbzttrHJox2HpKbRi+g16eIvxwOPx1+6tw7Rxhzsd2d4V6ZXxBv nroEBlSVXK9hUXbFtMAzS98Ir5bCFE1WnlR662kDPBN8vTeVOBo6ks4O3eslgoDmhCLz Z6D1Oqt3agv5y7e22opiMR0nBUlTbAS2J3JbWNJMITjph+KtbND9APjWxwBwDRfuJ3qC N00A== X-Gm-Message-State: AC+VfDy8QaMZrvB1Pt6RFCc3dllA+7nXGZZ5tS8a7h0foqJ1jlrpnEy3 RsjZ2EklCvgbDcWxM8D59HI= X-Google-Smtp-Source: ACHHUZ4MiEwy8jTDyxYxJSTW8RfLi/CoMypf5UhZEB58HEdZyLxOzRMdtIVJMpA9F2wHA10dyZDR/Q== X-Received: by 2002:a05:6512:ea7:b0:4f6:1433:fca0 with SMTP id bi39-20020a0565120ea700b004f61433fca0mr11286914lfb.0.1687423819676; Thu, 22 Jun 2023 01:50:19 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id a18-20020ac25212000000b004f122a378d4sm1027201lfl.163.2023.06.22.01.50.19 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Jun 2023 01:50:19 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#44418: 28.0.50; Spliced variable not matched as symbol in isearch From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <83fs6k4tzl.fsf@gnu.org> Date: Thu, 22 Jun 2023 10:50:18 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <14B98A43-88FF-49DE-A67C-ACD045E97CCA@gmail.com> References: <87zh3yh2mb.fsf@tcd.ie> <16025AD0-9B58-4020-AEBF-C518D1CDE51A@gmail.com> <83fs6k4tzl.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44418 Cc: contovob@tcd.ie, 44418@debbugs.gnu.org, larsi@gnus.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > If this changes user-facing behavior or behavior of public functions, > I think we must call this out in NEWS, under "incompatible changes". This is just a bug fix, not a change to documented or otherwise intended = behaviour. Maybe announcing it NEWS would make some people happy to know that the = bug has finally been fixed. From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 22 06:11:59 2023 Received: (at 44418) by debbugs.gnu.org; 22 Jun 2023 10:11:59 +0000 Received: from localhost ([127.0.0.1]:34925 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCHIF-0002xj-2O for submit@debbugs.gnu.org; Thu, 22 Jun 2023 06:11:59 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60590) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCHIC-0002xT-JD for 44418@debbugs.gnu.org; Thu, 22 Jun 2023 06:11:57 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qCHI5-0001nH-5Q; Thu, 22 Jun 2023 06:11:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=iFZgSoDPMXAPqdeh/VOTSnnhG7y1pujO3TTWMdcRbLY=; b=F8qyxm4HKaMSU7CUDlX9 lZ5t3sCMvqDIf3V5MYElrS0Zh7ox+/FStz8RHmP5PyPH7Szx70cR98oDBloDT/PKDAepJ1tAyowa4 fuGLJLxoLeFQrPmRJ9EYL4HufRRnG/7e1eba1LePwovrjuP5JmctlpvWQHbWLjHbTpNq1igTJrfYd TUuIJWhq6C9lpsGyLciMI2MSGoXaZDVkIGZWrbD1uyMbaZBd2bJyFmLLg1mMZM1akU1F3pxcsYLno b2073Iq46RBYRchMNJliGUgQArf9ZO178v04tOa5Ej/8vI2BiPzB+UcW6FfuRD4Fdj9nR/Qdqh3nt 6zXIqr8EP1rjrg==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qCHI4-0006pd-9d; Thu, 22 Jun 2023 06:11:48 -0400 Date: Thu, 22 Jun 2023 13:11:59 +0300 Message-Id: <83zg4r3ixc.fsf@gnu.org> From: Eli Zaretskii To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= In-Reply-To: <14B98A43-88FF-49DE-A67C-ACD045E97CCA@gmail.com> (message from Mattias =?utf-8?Q?Engdeg=C3=A5rd?= on Thu, 22 Jun 2023 10:50:18 +0200) Subject: Re: bug#44418: 28.0.50; Spliced variable not matched as symbol in isearch References: <87zh3yh2mb.fsf@tcd.ie> <16025AD0-9B58-4020-AEBF-C518D1CDE51A@gmail.com> <83fs6k4tzl.fsf@gnu.org> <14B98A43-88FF-49DE-A67C-ACD045E97CCA@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44418 Cc: contovob@tcd.ie, 44418@debbugs.gnu.org, larsi@gnus.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Mattias Engdegård > Date: Thu, 22 Jun 2023 10:50:18 +0200 > Cc: larsi@gnus.org, > contovob@tcd.ie, > 44418@debbugs.gnu.org, > monnier@iro.umontreal.ca > > > If this changes user-facing behavior or behavior of public functions, > > I think we must call this out in NEWS, under "incompatible changes". > > This is just a bug fix, not a change to documented or otherwise intended behaviour. Whether it was intended is not necessarily relevant. It could be known long-standing behavior that became a de-facto standard. Which is why I think we should call it out. If you are unwilling to mention this in NEWS, please describe the change and I will add to NEWS what I think needs to be added. TIA From debbugs-submit-bounces@debbugs.gnu.org Thu Jun 22 07:25:06 2023 Received: (at 44418-done) by debbugs.gnu.org; 22 Jun 2023 11:25:07 +0000 Received: from localhost ([127.0.0.1]:34997 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCIR0-00056h-N9 for submit@debbugs.gnu.org; Thu, 22 Jun 2023 07:25:06 -0400 Received: from mail-lj1-f172.google.com ([209.85.208.172]:54576) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCIQz-000565-0e for 44418-done@debbugs.gnu.org; Thu, 22 Jun 2023 07:25:05 -0400 Received: by mail-lj1-f172.google.com with SMTP id 38308e7fff4ca-2b45c289615so94472301fa.1 for <44418-done@debbugs.gnu.org>; Thu, 22 Jun 2023 04:25:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687433099; x=1690025099; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=UN5ev3FI69TNtiYfKvJEiFuV5P+xGCh2t534bmCRGhQ=; b=mGXv9/OsmLQzmNDT70bBmup7IjyrWnLU/u0cJiJUtYBPUl3e3BonkBy2NfJugxt64v 1BY9pKptDPNOqI9AVeuW95FfItQ49dSHsHBxKd25SKWn5UUuvJbL+9hYhtwzw5dBd5XN G2ieKwEzgIJ0x62he1naH896GoYR8B87L5lIhIII/SxPaq9YHy90q++PPTY+WV/2k+cc /Wn15RNUIHw74n+nYQeXl05I4eXyH3029RHZm7l8thERbn7DLYPiR4oMneWIpglyKELE otUz4rDyeiIMLgr1soWO2ptX1XV5NuSLEi0onWfmdmgGFdPQ5b2xGPrRt2KZP9jKac58 z4iA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687433099; x=1690025099; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=UN5ev3FI69TNtiYfKvJEiFuV5P+xGCh2t534bmCRGhQ=; b=dhgq7CzOoKBwpGF3oGLOw1U4VG+NCrWPtjTNUXwXMIV3VUBpLX4C9ggVvf3CDzxX4n GAbqoLNz9jB4zdTzxYTiQnYHQJwfw43i7x7UaIQUdIbZ/Zor4PQeWW5b5Qs7yiFwztsA wkTBwafkWkmKLyEyeNknCqnTOgUO7yKBXPGmKb9mBY3TNWBeGNRoJm1XqdF8wdUZGPf5 BymAbdKxL5OV56183cozRib/Porw2AWrorhUToA9zqhDZjvHnqr668hZDzHm1Y5kDOFQ 9u9Pa+0HVS1rF4VZMFPYxb9fyzhKTlxo5aiafj25u1ofdHzsH8ALfRTKyyPfpUuG/bSI uQMQ== X-Gm-Message-State: AC+VfDxzRhP7aYZWOWplJ/PaJ5nC2BQrZGeNiDB5JHAAwhlXbidGRpeZ RfLk2zvAz4ClTC7D8Uz9/oc= X-Google-Smtp-Source: ACHHUZ7mCq+slYt3LE9pADG2WQvBDB8G5oIQTRZLx4G72x1nDvy2ODg7D3KRSkoRwmF7IDEaTRmqjg== X-Received: by 2002:a05:6512:3d94:b0:4f9:5d8d:ccb8 with SMTP id k20-20020a0565123d9400b004f95d8dccb8mr3190969lfv.17.1687433098403; Thu, 22 Jun 2023 04:24:58 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id c15-20020a19760f000000b004f391a2028dsm1073458lff.265.2023.06.22.04.24.57 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 22 Jun 2023 04:24:58 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#44418: 28.0.50; Spliced variable not matched as symbol in isearch From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <83zg4r3ixc.fsf@gnu.org> Date: Thu, 22 Jun 2023 13:24:57 +0200 Content-Transfer-Encoding: 7bit Message-Id: References: <87zh3yh2mb.fsf@tcd.ie> <16025AD0-9B58-4020-AEBF-C518D1CDE51A@gmail.com> <83fs6k4tzl.fsf@gnu.org> <14B98A43-88FF-49DE-A67C-ACD045E97CCA@gmail.com> <83zg4r3ixc.fsf@gnu.org> To: Eli Zaretskii X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44418-done Cc: Basil Contovounesios , 44418-done@debbugs.gnu.org, Lars Ingebrigtsen , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > Whether it was intended is not necessarily relevant. It could be > known long-standing behavior that became a de-facto standard. Which > is why I think we should call it out. That's fine with me -- now done. Closing bug. From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 23 07:58:40 2023 Received: (at 44418) by debbugs.gnu.org; 23 Jun 2023 11:58:40 +0000 Received: from localhost ([127.0.0.1]:37809 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCfR2-0004H3-Bi for submit@debbugs.gnu.org; Fri, 23 Jun 2023 07:58:40 -0400 Received: from mail-lf1-f54.google.com ([209.85.167.54]:46246) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCfQx-0004Gg-Ju for 44418@debbugs.gnu.org; Fri, 23 Jun 2023 07:58:38 -0400 Received: by mail-lf1-f54.google.com with SMTP id 2adb3069b0e04-4f957a45b10so637006e87.0 for <44418@debbugs.gnu.org>; Fri, 23 Jun 2023 04:58:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1687521509; x=1690113509; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=0cdpUcfCUGLp1vJpi7WFYBwMHkGcg1jz9r9kL3wLroU=; b=H7E+eGTkIGYNXH8bjTJO/+CsRj3LQ5mYGqi8P0Tssw3K71Oe/bHfDubZZLbdmMi71M gjHNvg7qfofAfc4sU3N8IjWKmfTkF9TcEjaNSIlOFKKlnxHzjnh9g8RVULUhMQ3EFryD 83B7gIal3OPFsoZd4ClmDYKV4AJd/FkGl5LsQCKyCHivqOymPxOAGPoEG6mwz1VJd7qS wKIAwt35p9jaYhQNGpb6DF6AKVFAKMi0NMpD/32hBMYsoN1SjFGMXvMVi5tO0GEvFgrW Iio+gD6QnmbE2eKthLmvPqv9a5cKFC55yKaghB4IyclmlIG2aYjFjtBwwj4cQ4pwbD2k +apw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687521509; x=1690113509; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=0cdpUcfCUGLp1vJpi7WFYBwMHkGcg1jz9r9kL3wLroU=; b=Y2IOzBKjefAyi2x5iNxuZ74qF3G/qe9fQeZVWvpOAk5zjTP33Q0BYuKOfUtEXQVUyn 6yM+qr4NfgV2MLyrtqftg/w7YXThl6/dcz2n8IMP2Fc1hnJCoPrCPfd58qKsmi0L+ArB rafTmk9viAzqIzUixNuf8Semc2U0NWkFVmr0Qyi/ajsi/XjPCCugGbaGK1+GZgISJBG0 rByi2zxIm2CGsYVYO751w3povHfVX/HPcgpp2AfIkvi7ZHIf6cWCp4ugal4uUt40em4t +wjqahFY3vQF9qwa00dVcFzw+PKyS/EtUQHBipGTxuoRFW84wLNdEMrDDH9Z78g9WMUb FZbA== X-Gm-Message-State: AC+VfDyqPnFT7iPSZcVSOAgvOv6lOTpwSMRpCQKtYuSlXKLAbXVCJHkK X8+73YD4tBX4SKu1AaiJLKAo1A== X-Google-Smtp-Source: ACHHUZ7n8uOc4Nc8/E90pdGJT9mRgpTrseoeGSI+w29/eRnZrakWoMiI447EYMe94ziEjIFqdwl93g== X-Received: by 2002:a19:6702:0:b0:4f8:770d:6d7d with SMTP id b2-20020a196702000000b004f8770d6d7dmr8231647lfc.6.1687521509407; Fri, 23 Jun 2023 04:58:29 -0700 (PDT) Received: from localhost (vpn-254-066.epfl.ch. [128.179.254.66]) by smtp.gmail.com with ESMTPSA id t24-20020aa7d4d8000000b0051a4a1abdbbsm5127298edr.49.2023.06.23.04.58.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Jun 2023 04:58:28 -0700 (PDT) From: Basil Contovounesios To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Subject: Re: bug#44418: 28.0.50; Spliced variable not matched as symbol in isearch In-Reply-To: <16025AD0-9B58-4020-AEBF-C518D1CDE51A@gmail.com> ("Mattias =?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Wed, 21 Jun 2023 17:59:44 +0200") References: <16025AD0-9B58-4020-AEBF-C518D1CDE51A@gmail.com> Date: Fri, 23 Jun 2023 12:58:27 +0100 Message-ID: <87fs6itmos.fsf@epfl.ch> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 44418 Cc: 44418@debbugs.gnu.org, Lars Ingebrigtsen , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mattias Engdeg=C3=A5rd [2023-06-21 17:59 +0200] wrote: > A tentative fix has been pushed to master. Thanks. Too bad the same can't be done for tree-sitter capture names such as @font-lock-foo-face or @my--fontify-foo :). --=20 Basil From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 23 08:06:28 2023 Received: (at 44418) by debbugs.gnu.org; 23 Jun 2023 12:06:29 +0000 Received: from localhost ([127.0.0.1]:37819 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCfYa-0004Vk-Mi for submit@debbugs.gnu.org; Fri, 23 Jun 2023 08:06:28 -0400 Received: from mail-lf1-f41.google.com ([209.85.167.41]:44377) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCfYW-0004VQ-8P for 44418@debbugs.gnu.org; Fri, 23 Jun 2023 08:06:26 -0400 Received: by mail-lf1-f41.google.com with SMTP id 2adb3069b0e04-4f8792d2e86so709145e87.1 for <44418@debbugs.gnu.org>; Fri, 23 Jun 2023 05:06:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687521978; x=1690113978; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=trykWcNKvUpMYvEiTJOtbMCujzdqbTLnsH1J8l0qFO8=; b=kHLNpnQ51YjL05YxuBRRNhWjxZhrd1Yv2lVaLHmgCIFTRA3pb7xOvee8vy2pi+loDe VWlCs1PpU/mUq9zU+5xpKbyLdNxDXrTcX+IxruR/kOr22YLa0SvSZM69pvRJwFcrLAqw 0a6IoxMRw2Rs7LFMMPAg4Ss0UV+h8DGC0Z0ejl0Vngl+HNTJYON1QwUCTh7trwhR1rEy tlqOqug/HxIxx0InjXBMiwstd/CnGOrkVs0FS/vBieHHaj3fwS94oLIj1/9EefF2ias7 g+F1ZcFSw/HbJQTCQ1mKY+zKh7so1KDlGIczmb+X4/RrkVy78TtERgjORCxsPyKZP5Ad C0TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687521978; x=1690113978; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=trykWcNKvUpMYvEiTJOtbMCujzdqbTLnsH1J8l0qFO8=; b=irrkkh6OYggFSJDZqOy9/Km31TQ/SKcOZh/qz589xZFK2YNRF4sTKouK+pNXcsntI7 md1DjirSkkV6660NVpWI1R1B/8FDr7DOucuS/wglpG2AGmWIRFGh6Okfq3BszolnWkPA 2sfdGBb+iOKVepff9hXj48s+O7gB7ru3zTSBMXbfB3UA6S20zapJ6EnQmu5rzoggRW5f V7cIlzsEKoLqFZwYL8xTTTVsU/gzVsIJTpNm3NLX+tnOsKSXOElnyZhDrwoz6/t1IwQM NGQY6ZM+6XmwGPfyVa4DBIU7mkVb7lrczUY92yNRzu3cE7qLH/gN0TIy2SXSi6UBPq/G S06w== X-Gm-Message-State: AC+VfDyarXTJsNN7Nd83E3YGqMPHATXboQz6kNJF0+p5dE/CDlLW9FnI G+uDS2CZ6xUblSwBCQfLdMQ= X-Google-Smtp-Source: ACHHUZ4syQnJPMXLl5S5/m/4J10VAw4OPx4gTNYDQADB2ZYAAo48rhXAMz/k87ICSkvJycLzbqlNBw== X-Received: by 2002:a05:6512:551:b0:4f8:675c:3667 with SMTP id h17-20020a056512055100b004f8675c3667mr10277831lfl.21.1687521978041; Fri, 23 Jun 2023 05:06:18 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id a28-20020ac2521c000000b004f624d998c3sm1415898lfl.136.2023.06.23.05.06.17 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Jun 2023 05:06:17 -0700 (PDT) Content-Type: text/plain; charset=us-ascii Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#44418: 28.0.50; Spliced variable not matched as symbol in isearch From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <87fs6itmos.fsf@epfl.ch> Date: Fri, 23 Jun 2023 14:06:16 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <1C3E6B87-79B5-4360-BC39-DC9F6381E7B3@gmail.com> References: <16025AD0-9B58-4020-AEBF-C518D1CDE51A@gmail.com> <87fs6itmos.fsf@epfl.ch> To: Basil Contovounesios X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44418 Cc: 44418@debbugs.gnu.org, Lars Ingebrigtsen , Yuan Fu , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 23 juni 2023 kl. 13.58 skrev Basil Contovounesios : > Too bad the same can't be done for tree-sitter capture names > such as @font-lock-foo-face or @my--fontify-foo :). Yes, I think that's a bit unfortunate. Maybe we can introduce (@ NAME) = as alternative syntax? From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 23 12:54:56 2023 Received: (at 44418) by debbugs.gnu.org; 23 Jun 2023 16:54:56 +0000 Received: from localhost ([127.0.0.1]:39443 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCk3k-0004AU-76 for submit@debbugs.gnu.org; Fri, 23 Jun 2023 12:54:56 -0400 Received: from mail-lj1-f170.google.com ([209.85.208.170]:59792) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCk3g-0004AF-80 for 44418@debbugs.gnu.org; Fri, 23 Jun 2023 12:54:54 -0400 Received: by mail-lj1-f170.google.com with SMTP id 38308e7fff4ca-2b46773e427so14656761fa.3 for <44418@debbugs.gnu.org>; Fri, 23 Jun 2023 09:54:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687539286; x=1690131286; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:sender:from:to:cc:subject:date:message-id:reply-to; bh=7oGEX8IKxHEkOxRg1YqdHq3J5MuEguL20PioX6WU6vg=; b=n541XY2ZppyVV4WCuf4qk0qgczGyHZB9w3wb2hHQUTo2eKpT1V4Zgh8zB0cBivxB0v eANbIE3c7Cg8FYcBFjcQzasBpbYFdxLzLJWyWPc+u+bk73gpjcK6AhFgm8ZH7IXiwexQ ihJF1DzR9jrDct1q05X4FcxU2nvF45rwqrE0rJ7jCiIOMHDA3JlH2lM6oO2UEqUbuUMl zGdzojy0WAnWuZaL+2vvNLZrJ2doAkcPrBbgySplxn/pK+ECf97PQFXpXQTnC9ORGk11 c5lzYbWAzdUDeaHO4GxabqOzPWPFZwpHAsKtj0VlUhuOuKBgq5WAUrZ7g1s2k+0/8mpi PfBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687539286; x=1690131286; h=references:to:cc:in-reply-to:date:subject:mime-version:message-id :from:sender:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=7oGEX8IKxHEkOxRg1YqdHq3J5MuEguL20PioX6WU6vg=; b=Z6P9T1I8LXACti0xgs2zxVVqOL8DNz4nZFSGpqkhYv9acRG76p5gPORy/7Lg/hHbxJ 1swKHXO5637aCLJkWMVk6BiSekwpU3QCGETo/l74Or1p07A1fzKAt6e35983jy797Qdn luPhf4p6iWe3UJbZ9g2eB+sIzRjWVNw2VtXW0ejKExYPXblvqeO30OBB/WSaLi/eS/fJ ZAZNxvZtc2xAQo5Al1vxar2XioDrPWy3pIOTEj/t5ufJuR3KUpPfkVc4XzQVhPm5RINd bJfZWq+IbmBCKqJLAkqqU45yzlbH3wUh6yBkUkkgntVb2wTmigSUGoOpmAFYRI5DhX1O Gdow== X-Gm-Message-State: AC+VfDzURUsyY/GF+9MJC2R/ZbutUXUcdWJUTVm4SpuBP21CZ0YOCcFB z83SH8RG3KrGjrBY6X5DIko= X-Google-Smtp-Source: ACHHUZ7+UXUF/7Tgp8omQly5D1cc20ih8UMz8a+royguyvWAHsUVv7PoNb99oZlpS1Q7FRekUNvq4A== X-Received: by 2002:a2e:9e44:0:b0:2a7:7055:97f5 with SMTP id g4-20020a2e9e44000000b002a7705597f5mr15124075ljk.0.1687539285827; Fri, 23 Jun 2023 09:54:45 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id h19-20020a2eb0f3000000b002b3318c8d6fsm1792748ljl.28.2023.06.23.09.54.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Jun 2023 09:54:45 -0700 (PDT) From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= Message-Id: <6A3C260E-F112-446C-A2DF-C2351709475A@gmail.com> Content-Type: multipart/mixed; boundary="Apple-Mail=_0042F261-D2A2-4267-8248-DED7BEEFA952" Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#44418: 28.0.50; Spliced variable not matched as symbol in isearch Date: Fri, 23 Jun 2023 18:54:44 +0200 In-Reply-To: <1C3E6B87-79B5-4360-BC39-DC9F6381E7B3@gmail.com> To: Basil Contovounesios References: <16025AD0-9B58-4020-AEBF-C518D1CDE51A@gmail.com> <87fs6itmos.fsf@epfl.ch> <1C3E6B87-79B5-4360-BC39-DC9F6381E7B3@gmail.com> X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44418 Cc: 44418@debbugs.gnu.org, Lars Ingebrigtsen , Yuan Fu , Stefan Monnier X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --Apple-Mail=_0042F261-D2A2-4267-8248-DED7BEEFA952 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=us-ascii > Maybe we can introduce (@ NAME) as alternative syntax? Here is a proof-of-concept (missing tests and documentation), but it = works and I think it's a definite improvement. Maybe we can get a blessing from Yuan Fu. To recap, this permits the = syntax (@ symbol-name) as an alternative to @symbol-name in treesit = queries because that allows symbol searching to match the symbol-name, = and this can be really helpful. --Apple-Mail=_0042F261-D2A2-4267-8248-DED7BEEFA952 Content-Disposition: attachment; filename=treesit-alt-capture-construct.diff Content-Type: application/octet-stream; x-unix-mode=0644; name="treesit-alt-capture-construct.diff" Content-Transfer-Encoding: 7bit diff --git a/src/treesit.c b/src/treesit.c index 87aa1eeb377..64570094347 100644 --- a/src/treesit.c +++ b/src/treesit.c @@ -2358,6 +2358,7 @@ DEFUN ("treesit-pattern-expand", (TYPE PATTERN...) [PATTERN...] FIELD-NAME: + (@ CAPTURE-NAME) @CAPTURE-NAME (_) _ @@ -2380,18 +2381,27 @@ DEFUN ("treesit-pattern-expand", return Vtreesit_str_pound_match; if (BASE_EQ (pattern, QCpred)) return Vtreesit_str_pound_pred; - Lisp_Object opening_delimeter - = VECTORP (pattern) - ? Vtreesit_str_open_bracket : Vtreesit_str_open_paren; - Lisp_Object closing_delimiter - = VECTORP (pattern) - ? Vtreesit_str_close_bracket : Vtreesit_str_close_paren; + + /* (@ X) -> @Y where X -> Y */ + if (CONSP (pattern) && BASE_EQ (XCAR (pattern), Qat) + && CONSP (XCDR (pattern)) && NILP (XCDR (XCDR (pattern)))) + return concat2 (build_string ("@"), + Ftreesit_pattern_expand (XCAR (XCDR (pattern)))); + if (VECTORP (pattern) || CONSP (pattern)) + { + Lisp_Object opening_delimeter + = VECTORP (pattern) + ? Vtreesit_str_open_bracket : Vtreesit_str_open_paren; + Lisp_Object closing_delimiter + = VECTORP (pattern) + ? Vtreesit_str_close_bracket : Vtreesit_str_close_paren; return concat3 (opening_delimeter, Fmapconcat (Qtreesit_pattern_expand, pattern, Vtreesit_str_space), closing_delimiter); + } if (STRINGP (pattern)) return treesit_query_string_string (pattern); @@ -2414,6 +2424,7 @@ DEFUN ("treesit-query-expand", (TYPE PATTERN...) [PATTERN...] FIELD-NAME: + (@ CAPTURE-NAME) @CAPTURE-NAME (_) _ @@ -4101,4 +4112,6 @@ syms_of_treesit (void) defsubr (&Streesit_subtree_stat); #endif /* HAVE_TREE_SITTER */ defsubr (&Streesit_available_p); + + DEFSYM (Qat, "@"); } --Apple-Mail=_0042F261-D2A2-4267-8248-DED7BEEFA952 Content-Transfer-Encoding: 7bit Content-Type: text/plain; charset=us-ascii --Apple-Mail=_0042F261-D2A2-4267-8248-DED7BEEFA952-- From debbugs-submit-bounces@debbugs.gnu.org Fri Jun 23 18:39:43 2023 Received: (at 44418) by debbugs.gnu.org; 23 Jun 2023 22:39:43 +0000 Received: from localhost ([127.0.0.1]:39677 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCpRP-0005wX-5g for submit@debbugs.gnu.org; Fri, 23 Jun 2023 18:39:43 -0400 Received: from mail-pf1-f174.google.com ([209.85.210.174]:48157) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCpRL-0005wG-7c for 44418@debbugs.gnu.org; Fri, 23 Jun 2023 18:39:41 -0400 Received: by mail-pf1-f174.google.com with SMTP id d2e1a72fcca58-666ed230c81so860823b3a.0 for <44418@debbugs.gnu.org>; Fri, 23 Jun 2023 15:39:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687559973; x=1690151973; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:from:to:cc:subject:date:message-id :reply-to; bh=ASMvJ5E/6LBBu5slJ2LABdEyiyan8EoD8pVhda+NnY0=; b=rT27qMB2UpiMzu6VNPEN6gMD2tHDbXf/qmhsLH1bu5/SnIRTwa4iik3+JuaB8l22tZ yJXemfoTph/JbMzCUXjqXipwZqA7dh2ldg3YS2bhW2sgee0zj0Z+SJtg/n2RITYMEGwW 8nUVFgis4uNUT+0EVwVm7ucafiog8Go9aW39DR6wvZAXjD+HFAhtpLsvXHrU+VF0abLN Ms5fF0DJ8fw/VDgGoC+48N4T46JZDtsub09P534ZlKNpSyReh6PELO+frhDSZ5dtRemj QDBSR9vCzs8jZ/sMvewJci9l4xQy189p4tRrVAyBF4jjPWkx4vadYuOfUbo2tFTD7/Sw tO1A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687559973; x=1690151973; h=to:cc:date:message-id:subject:mime-version :content-transfer-encoding:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ASMvJ5E/6LBBu5slJ2LABdEyiyan8EoD8pVhda+NnY0=; b=HDsABe32MpvcIC7vB0AEGH0lYGF6krcTAiXLqu0TeMvh1ppWhURlqU7wAGWI8q8yV4 LgsaQ0LbFn/Njm6wnEWz06EleIS6PU0Wsogh8+enUJteoKRQ2GLAL+PULoxu/2HL963o UoeuPRA1P/I0HP8G0nh6gKifEb8ziJPds90o0ML2gwqsqPE4+H2HBYeHZT74hN4pg6JN FSB5CEsIgX2EhDBdQhMCdT6VIjIVjvasNT/BdN4MhuLR7SOxjodGj7l0zHRn1B9lTUSf JqHQwgT9RavW76fEFnDk984S3kuQFn8JXIZ7lolO8vL+HmTKNQmepAGnhO/ATrbinoIJ aanA== X-Gm-Message-State: AC+VfDzblDNHNzU4q5zK40I2o8tukQKSWw5SgZ+Fo1gOuzQoeLnxejsK UtLQodF+sUBeyu8AgzsfWQ0= X-Google-Smtp-Source: ACHHUZ6/WUMvqjHeAgqoNP/Yg2fla2SaxtCkMYWL0uWmH9dn0kOchKuGpSKG0H5k8BnZCI80gYasAg== X-Received: by 2002:a05:6a20:a10d:b0:121:c2f7:df3e with SMTP id q13-20020a056a20a10d00b00121c2f7df3emr17517442pzk.12.1687559973266; Fri, 23 Jun 2023 15:39:33 -0700 (PDT) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id e17-20020a62ee11000000b0066a4e561beesm28342pfi.173.2023.06.23.15.39.32 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Fri, 23 Jun 2023 15:39:32 -0700 (PDT) From: Yuan Fu Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\)) Subject: Re: bug#44418: 28.0.50; Spliced variable not matched as symbol in isearch Message-Id: Date: Fri, 23 Jun 2023 15:39:20 -0700 To: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= X-Mailer: Apple Mail (2.3731.600.7) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44418 Cc: contovob@tcd.ie, 44418@debbugs.gnu.org, larsi@gnus.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mattias Engdeg=C3=A5rd writes: >> Maybe we can introduce (@ NAME) as alternative syntax? > > Here is a proof-of-concept (missing tests and documentation), but it = works and I think it's a definite improvement. > > Maybe we can get a blessing from Yuan Fu. To recap, this permits the > syntax (@ symbol-name) as an alternative to @symbol-name in treesit > queries because that allows symbol searching to match the symbol-name, > and this can be really helpful. I want to point out that a) this will add complexity and make the syntax harder to read and learn (however minuscule the impact might be); b) is not enough by itself to make isearch symbol work with capture names: whoever write the code must _use_ this syntax; and c) I don=E2=80=99t = think isearch symbol itself is popular/important enough to justify the change. Yuan From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 24 02:39:50 2023 Received: (at 44418) by debbugs.gnu.org; 24 Jun 2023 06:39:50 +0000 Received: from localhost ([127.0.0.1]:39874 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCww1-0002Do-TL for submit@debbugs.gnu.org; Sat, 24 Jun 2023 02:39:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60606) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qCwvy-0002DV-IM for 44418@debbugs.gnu.org; Sat, 24 Jun 2023 02:39:48 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qCwvp-0008Tu-If; Sat, 24 Jun 2023 02:39:40 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=DYGWyoyjZPHyz1pncfOXqTbgT0YGUhg5sJuj1GmqItw=; b=ALbHH4/ySmALkhq83GZ+ ZlINncnU6F3T+A0QSM9wYFvHcBvN5A8H4pgh4gObtupm3w2q6DBMJj1HdNX2GW2mWXHfVnm1d5xvb p21SHEsXHH+v9/Rm0IZNO0wAEicKyJAHqAdGPqt8PoXMjoe87eKQ2EUe8cjplqSLLGh/AC+7RwHVc VFeu1Uq4amIjLeL/zqzt+l1k7H7oJOQkje3yqCRmJ+QS++Mg3P7b1G0ZbjIny+FEkDEIjEyObiBar vT3wypmKJjL8VZrCncTD3GSAjLBOJslOBSB+oJwrVQZgqhGLTFHnIr5ObeRjQpnMSO2rXFnSAz8M9 qUOb2gNZaqhMFw==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qCwvp-0000kG-2j; Sat, 24 Jun 2023 02:39:37 -0400 Date: Sat, 24 Jun 2023 09:39:52 +0300 Message-Id: <831qi11hzb.fsf@gnu.org> From: Eli Zaretskii To: Yuan Fu In-Reply-To: (message from Yuan Fu on Fri, 23 Jun 2023 15:39:20 -0700) Subject: Re: bug#44418: 28.0.50; Spliced variable not matched as symbol in isearch References: <87zh3yh2mb.fsf@tcd.ie> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44418 Cc: contovob@tcd.ie, 44418@debbugs.gnu.org, mattias.engdegard@gmail.com, larsi@gnus.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: contovob@tcd.ie, 44418@debbugs.gnu.org, larsi@gnus.org, > monnier@iro.umontreal.ca > From: Yuan Fu > Date: Fri, 23 Jun 2023 15:39:20 -0700 > > > Mattias Engdegård writes: > > >> Maybe we can introduce (@ NAME) as alternative syntax? > > > > Here is a proof-of-concept (missing tests and documentation), but it works and I think it's a definite improvement. > > > > Maybe we can get a blessing from Yuan Fu. To recap, this permits the > > syntax (@ symbol-name) as an alternative to @symbol-name in treesit > > queries because that allows symbol searching to match the symbol-name, > > and this can be really helpful. > > I want to point out that a) this will add complexity and make the syntax > harder to read and learn (however minuscule the impact might be); b) is > not enough by itself to make isearch symbol work with capture names: > whoever write the code must _use_ this syntax; and c) I don’t think > isearch symbol itself is popular/important enough to justify the change. Given what Yuan says, I think we should drop this for now. Let's collect some real-world use experience, once Emacs 29 is released, before planning any such changes. From debbugs-submit-bounces@debbugs.gnu.org Sat Jun 24 06:12:56 2023 Received: (at 44418) by debbugs.gnu.org; 24 Jun 2023 10:12:56 +0000 Received: from localhost ([127.0.0.1]:39940 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qD0GG-0000Jg-Gx for submit@debbugs.gnu.org; Sat, 24 Jun 2023 06:12:56 -0400 Received: from mail-lf1-f47.google.com ([209.85.167.47]:62681) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qD0GC-0000JL-Fi for 44418@debbugs.gnu.org; Sat, 24 Jun 2023 06:12:54 -0400 Received: by mail-lf1-f47.google.com with SMTP id 2adb3069b0e04-4f8689fbf59so3242401e87.0 for <44418@debbugs.gnu.org>; Sat, 24 Jun 2023 03:12:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1687601566; x=1690193566; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=PCY6Z8ZjjqUX75jOGsgTCgN/T3Q7Zc+zUfvcYuI7iHk=; b=mb96llv3OFv8tay/fb6QXi868ne18tQ9Of0eAG6uiPZTB67Aw32fUF+Oeu7uhMUcos oQKcLQmhrzgXVqxxF77SlBg518SG93towsWlARTTJMQk016wmzVWt5QzXBaytOWlTR2I SGo5T2lHPK39oeWJ8o+UNSvKPguXRyJSstipTy0VP5VjLpUqWLeep8GbTswjXsRU8ljG 3Ih+Ux4K+qITWOmAvuDI0XuEBgWRByIppjA4Y1K3xxTSwNPBRdSlCCy+nv331onnIMmv sGe1xVNi6w/O5q71zG2/PKyBMEoPSPkMB40AgAjqO7C+2d00T7A7dlEdL4yZC+AqjBF3 NOBw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687601566; x=1690193566; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=PCY6Z8ZjjqUX75jOGsgTCgN/T3Q7Zc+zUfvcYuI7iHk=; b=Ptlj0Ns9L/UpTW9F8OBgvPtSUGikSctOacpaoClvvp0vV4aXnIN+Kvuuhf7r8BTw3D phEAkzjIJteZ84QCSF4+VFhLoOJ2W53tNohwBxlVEvmPMERpJxU9CmVxOXaq/o0td+8a Q0PVSGMVZpmHNiSPqLG2EMhJOv38KiLgHLRBlVPJT/neM9xV1dNNWBOSijU0H9a3qVmh r+RZboL9Al2owq6y6kHtBHZGGUICRU5PrpTLsYWq2+BPIlTH1FlJBG/B8P6S20ZQwF4I XxFEOWq7i1B0PX7Zm2r9WbDzemoB6vevNlEKwVPsBLaS6dbLnjyBuMKCGEZ/xU3EdG/H 4YLg== X-Gm-Message-State: AC+VfDwyyLc41YYUQxdMOKMW5zkqxQGlDUn3fUKSa8n22JdPiuz20ZDd i2SxfqgvouvvntBPe14xKnM= X-Google-Smtp-Source: ACHHUZ6W3bx1SbIHG7qa47R6g9+K+Ve6CD+A774t/amJGE3lvJ4pT8hDS1HRz19OfmNa3MegxE5BNQ== X-Received: by 2002:a05:6512:454:b0:4f8:565f:8ec7 with SMTP id y20-20020a056512045400b004f8565f8ec7mr8250486lfk.27.1687601565790; Sat, 24 Jun 2023 03:12:45 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id t5-20020ac243a5000000b004eb44c2ab6bsm214364lfl.294.2023.06.24.03.12.45 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 24 Jun 2023 03:12:45 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#44418: 28.0.50; Spliced variable not matched as symbol in isearch From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: Date: Sat, 24 Jun 2023 12:12:44 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: References: To: Yuan Fu X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44418 Cc: contovob@tcd.ie, 44418@debbugs.gnu.org, larsi@gnus.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 24 juni 2023 kl. 00.39 skrev Yuan Fu : > I want to point out that a) this will add complexity and make the = syntax > harder to read and learn (however minuscule the impact might be); b) = is > not enough by itself to make isearch symbol work with capture names: > whoever write the code must _use_ this syntax; and c) I don=E2=80=99t = think > isearch symbol itself is popular/important enough to justify the = change. Well, you are the treesit maintainer and get to decide, but perhaps I = could try to sway your opinion. First note that the change is very small = with no increase in complexity -- most treesit users would never bother = to learn that there is an alternative @SYMBOL notation in addition to = the standard (@ SYMBOL). Furthermore, the @SYMBOL notation is quite un-Lisp-like and alien to = Lisp programmers who definitely tend to make use of symbol search, which = is why this bug (about the ,@ prefix) was so annoying: it not only = prevented us from effectively finding all occurrences of a symbol, but = deprived us of a common way to check that the spelling of name is = correct and corresponds to its definition. A pity if we now introduce = the same kind of bug again, unforced. I did a quick translation of some treesit patterns in various language = modes from @SYMBOL to (@ SYMBOL) and the result was no less readable. = Try it yourself. Your decision to expose treesit queries as Elisp S-expressions was = fortunate, as can be seen by the fact that no Emacs editing mode seems = to use the other (string) syntax, and the modes make frequent use of = backquote forms to interpolate Lisp values into patterns. From debbugs-submit-bounces@debbugs.gnu.org Sun Jun 25 07:38:32 2023 Received: (at 44418) by debbugs.gnu.org; 25 Jun 2023 11:38:32 +0000 Received: from localhost ([127.0.0.1]:42105 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDO4d-0005XH-Pm for submit@debbugs.gnu.org; Sun, 25 Jun 2023 07:38:32 -0400 Received: from mail-wm1-f53.google.com ([209.85.128.53]:49454) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qDO4Y-0005Wz-6O for 44418@debbugs.gnu.org; Sun, 25 Jun 2023 07:38:29 -0400 Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-3fa74d06d72so22690085e9.3 for <44418@debbugs.gnu.org>; Sun, 25 Jun 2023 04:38:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1687693100; x=1690285100; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FM6Y9w+QxzWaoVjDuMjdMgxbhZo48ieM9VHFUn/Y6E8=; b=CsaTK7XgThGU+GxAHYL9wfkKaEHfKKbVtXT2UYlLViGl0sp7420ArhWQ6Jt3o4R36S tzv5mcFjLAH7PpI9/nOMkvqkVEGDXPMdc1j6TpMdxSQfQTe7CcGKK9frqOLcmq+DoGKO rgtW4gRk6Lsz6LIp9zPgPJLxV5uEOUHXExhAVQYGnGzdaeYPxYrbs7t9CwTUhXFkX6nZ BHUAdCOxOxk3YI4nff44IFCwi2iLtRvHHl0qDNkzFnJWkuTpFAe5A0zfLToMMp4frnYY 52esbUhFzeJeVX6CzR0U8pAdhY/h+SNRUO1waTvJxMR+y9UntoKQ/89yq+z5SZ+OAFdv PFvg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1687693100; x=1690285100; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=FM6Y9w+QxzWaoVjDuMjdMgxbhZo48ieM9VHFUn/Y6E8=; b=MvbC93naebyOb51sIjuE038xCPjlbXEeZ6Ss0gFmkCJyRsAo8CU7+Ul270U34uAQBL uvhvqQE+gRY0yMcspm7L76cLQ+8HVAZjZM82gMylWDuH5QwSfSIIwLYkxWa6YoJJnN0s Ii6auLxPM58XJX23nVnP6RpZ9XQ2VcXShxoXfN+pYlcB2Sj4CsOmoUrA1pLPzB+3s5OM JpqJHADIDI7X2WI3lcJ1fK/27g+2cAMP5ZKXfUUh889W3itop2Zp4ziG+eDEfpXEwhIb Ps4p380HTaeqdkLgpMSNWjHUMlFLCgwdqibC+3yPdN3qWKKKjmW4OiNlhxB5T0O1jH48 pSZA== X-Gm-Message-State: AC+VfDx8Y6XCAoNryZn/PwsaeJ3k9g30ACAI36UexgwURoF2UnIUxV1H kToCi7Z+Ttvg/9RaGr2D2XCGFA== X-Google-Smtp-Source: ACHHUZ56SirAPQE5zqcY0qBBBI5yr0SO7tEdpfBU6ScRZFjdq+A/4GXdsjP5lFDxmIqd+5toRLu5vA== X-Received: by 2002:a7b:c387:0:b0:3fa:85fd:4ca5 with SMTP id s7-20020a7bc387000000b003fa85fd4ca5mr2086820wmj.4.1687693100386; Sun, 25 Jun 2023 04:38:20 -0700 (PDT) Received: from localhost ([78.152.249.199]) by smtp.gmail.com with ESMTPSA id u13-20020a5d514d000000b0030e56a9ff25sm4356335wrt.31.2023.06.25.04.38.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Jun 2023 04:38:19 -0700 (PDT) From: Basil Contovounesios To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Subject: Re: bug#44418: 28.0.50; Spliced variable not matched as symbol in isearch In-Reply-To: ("Mattias =?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Sat, 24 Jun 2023 12:12:44 +0200") References: Date: Sun, 25 Jun 2023 12:38:19 +0100 Message-ID: <874jmv3h78.fsf@epfl.ch> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 44418 Cc: 44418@debbugs.gnu.org, Yuan Fu , larsi@gnus.org, monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mattias Engdeg=C3=A5rd [2023-06-24 12:12 +0200] wrote: > Furthermore, the @SYMBOL notation is quite un-Lisp-like and alien to Lisp > programmers who definitely tend to make use of symbol search, which is wh= y this > bug (about the ,@ prefix) was so annoying: it not only prevented us from > effectively finding all occurrences of a symbol, but deprived us of a com= mon way > to check that the spelling of name is correct and corresponds to its > definition. A pity if we now introduce the same kind of bug again, unforc= ed. FWIW, as a workaround I'm trying to use 'M-s M-.' in place of 'M-s .'. I may eventually be compelled to customise isearch-forward-thing-at-point with a custom 'thing' specifically for @-prefixed Elisp symbols. --=20 Basil From debbugs-submit-bounces@debbugs.gnu.org Sat Jul 08 19:49:18 2023 Received: (at 44418) by debbugs.gnu.org; 8 Jul 2023 23:49:18 +0000 Received: from localhost ([127.0.0.1]:45346 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qIHfy-0003na-9n for submit@debbugs.gnu.org; Sat, 08 Jul 2023 19:49:18 -0400 Received: from mail-pf1-f179.google.com ([209.85.210.179]:49585) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qIHfv-0003nJ-Ac for 44418@debbugs.gnu.org; Sat, 08 Jul 2023 19:49:16 -0400 Received: by mail-pf1-f179.google.com with SMTP id d2e1a72fcca58-666eec46206so2693823b3a.3 for <44418@debbugs.gnu.org>; Sat, 08 Jul 2023 16:49:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1688860149; x=1691452149; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=U/LTL72J2wyb3sET58R1zambUYBWkc90BQgyvPDfJVk=; b=Fizvv4p7XIfX88bRFmT4UaoOjXaZDpHDrcaVrWy3h+jVhpufuyZortf4YKJ6QeIF7w M+S5i23jSN6A5TkhGM7w9yQr5cKCcDVj7fE40imzaoVrwQhQ7i6DttRCX+RFXR4crcyV Urp8CI+6A8/Uxeciyamz2P2+I+IDaEI3UvTnReH2YqbCZK8rTNIbvYOiJ34+kx86M78c FInk7PqMijOklRu30hp8mBtLS7wX/g1rF6LVBHyceV6g621bW8w9gsaejkND6OSGC0z6 UylsT3VodpwHva8jNDQkTplRlA3sOel5R4xkugeWKrgQXumTfOltGMAHNIzamCT0yVrS NT6g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1688860149; x=1691452149; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=U/LTL72J2wyb3sET58R1zambUYBWkc90BQgyvPDfJVk=; b=R3ePMDLvcdgliTWEb3xmXo2YaIOi9BNr2Sn1ZBML+todI0ChOK+BYVYo8Tj3tgdjux rUBToAveku46Im6lHIghM3V7bte3SB3YQB7U32zfPPPU4oL4snvSyVzIUQkIarNnDp6/ nuF6ANK7APwyi+TulYz1pmCvfPNg2Am144UgNxcLEWIsnkuHurjJW0tS4PK0ne5mXoxa NiKMF+6BR6goRRDaxZlOnkfT96YUfYv20no4UIqws8usMYy7mZ+4tBTswPtytz9rSb8r Y3BBGa2FdG/pj6imhe85Hd9KmLEJr0m29qHlTJdrM9h/iTKA1T62JoHSVhhBmsRJAMM4 pA9Q== X-Gm-Message-State: ABy/qLanjnuSt0O2JlPbNXBNZtGu5plC48WGWJqXokJEmmAtGg+obdEr OMELho81nFDu8CkMbaMMx4M= X-Google-Smtp-Source: APBJJlEFy9HI4Q5zO6jsFMx2m2A2VBOu0Lr+P9ISBqJR+487dfAzMXXWlTCIaJSEpDfVhiU0zoztVw== X-Received: by 2002:a05:6a20:1394:b0:122:4a16:dfa4 with SMTP id hn20-20020a056a20139400b001224a16dfa4mr8326385pzc.10.1688860149100; Sat, 08 Jul 2023 16:49:09 -0700 (PDT) Received: from smtpclient.apple (cpe-172-117-161-177.socal.res.rr.com. [172.117.161.177]) by smtp.gmail.com with ESMTPSA id x7-20020a62fb07000000b006828ee9fa69sm4755191pfm.206.2023.07.08.16.49.08 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Sat, 08 Jul 2023 16:49:08 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3731.600.7\)) Subject: Re: bug#44418: 28.0.50; Spliced variable not matched as symbol in isearch From: Yuan Fu In-Reply-To: Date: Sat, 8 Jul 2023 16:48:57 -0700 Content-Transfer-Encoding: quoted-printable Message-Id: <9289047B-5BD7-493A-8A89-E2B0B38A8364@gmail.com> References: To: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= X-Mailer: Apple Mail (2.3731.600.7) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44418 Cc: Basil Contovounesios , 44418@debbugs.gnu.org, Lars Ingebrigtsen , monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > On Jun 24, 2023, at 3:12 AM, Mattias Engdeg=C3=A5rd = wrote: >=20 > 24 juni 2023 kl. 00.39 skrev Yuan Fu : >=20 >> I want to point out that a) this will add complexity and make the = syntax >> harder to read and learn (however minuscule the impact might be); b) = is >> not enough by itself to make isearch symbol work with capture names: >> whoever write the code must _use_ this syntax; and c) I don=E2=80=99t = think >> isearch symbol itself is popular/important enough to justify the = change. >=20 > Well, you are the treesit maintainer and get to decide, but perhaps I = could try to sway your opinion. First note that the change is very small = with no increase in complexity -- most treesit users would never bother = to learn that there is an alternative @SYMBOL notation in addition to = the standard (@ SYMBOL). >=20 > Furthermore, the @SYMBOL notation is quite un-Lisp-like and alien to = Lisp programmers who definitely tend to make use of symbol search, which = is why this bug (about the ,@ prefix) was so annoying: it not only = prevented us from effectively finding all occurrences of a symbol, but = deprived us of a common way to check that the spelling of name is = correct and corresponds to its definition. A pity if we now introduce = the same kind of bug again, unforced. >=20 > I did a quick translation of some treesit patterns in various language = modes from @SYMBOL to (@ SYMBOL) and the result was no less readable. = Try it yourself. >=20 > Your decision to expose treesit queries as Elisp S-expressions was = fortunate, as can be seen by the fact that no Emacs editing mode seems = to use the other (string) syntax, and the modes make frequent use of = backquote forms to interpolate Lisp values into patterns. Sorry for taking so long, I never decided against other people for = important things in Emacs, and I certainly don=E2=80=99t want to make a = wrong decision and regret it later, so I struggled a bit and kept = procrastinating =F0=9F=98=83 I agree that it=E2=80=99s easy to figure out what does the detached @ = syntax mean. I mainly just don=E2=80=99t like having two ways to do the = same thing. Since I don=E2=80=99t use search symbol myself, I can=E2=80=99t grasp = the importance of it. You apparently care about it enough to go this = far, and I=E2=80=99m willing to take your word for it. You mentioned sexp queries, which reminded me that using the detached = syntax would allow people to interpolate capture names with quasi = quotes. That=E2=80=99s a plus for the detached syntax. Ultimately I=E2=80=99m still on the fence for this. But if you still = want to add it, please go ahead :-) Yuan= From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 09 02:07:31 2023 Received: (at 44418) by debbugs.gnu.org; 9 Jul 2023 06:07:31 +0000 Received: from localhost ([127.0.0.1]:45637 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qINZz-0006eF-EU for submit@debbugs.gnu.org; Sun, 09 Jul 2023 02:07:31 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50616) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qINZu-0006dz-9k for 44418@debbugs.gnu.org; Sun, 09 Jul 2023 02:07:29 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qINZo-0001Sj-Hg; Sun, 09 Jul 2023 02:07:20 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-version:References:Subject:In-Reply-To:To:From: Date; bh=ibTst3zcHOunNonDCNplco5mxkTG6IxvArgIyKuJf2o=; b=ISId1/bJ8Jcb0UHWOpx0 qQxxMJliD/m5Ajw8nU6Pq66kVkEplIUQ7Ax8hKPJVHBsyX5YgKCEMbFw0mplL4qLiABKaIg+NGUng /V2KbRPiP2kyAPLUHiPDYkhxx2KLpnAoteIdcllGR+hFmKpDgWxwkD5wc+RfVFKjgQb4btTFB6B+a sZooDUtHROPhpBqOrLi/I8LPtp+6qIi9cFoQZmKrIqRBndT927DsdW91ue7yxVLQOPxxV9RsHVIR8 QCHmz2hLUH8emIjhae4QS/YH/OFjXPa9NrY/gsrXaXRGtc2dF6rvGY3Ye/pcFB4qz7w85E95/Jnlh 7uTMihybw/LHCA==; Received: from [87.69.77.57] (helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1qINZo-0003td-11; Sun, 09 Jul 2023 02:07:20 -0400 Date: Sun, 09 Jul 2023 09:07:26 +0300 Message-Id: <83ilatbotd.fsf@gnu.org> From: Eli Zaretskii To: Yuan Fu , Stefan Monnier In-Reply-To: <9289047B-5BD7-493A-8A89-E2B0B38A8364@gmail.com> (message from Yuan Fu on Sat, 8 Jul 2023 16:48:57 -0700) Subject: Re: bug#44418: 28.0.50; Spliced variable not matched as symbol in isearch References: <9289047B-5BD7-493A-8A89-E2B0B38A8364@gmail.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44418 Cc: contovob@tcd.ie, 44418@debbugs.gnu.org, mattias.engdegard@gmail.com, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Cc: Basil Contovounesios , 44418@debbugs.gnu.org, > Lars Ingebrigtsen , monnier@iro.umontreal.ca > From: Yuan Fu > Date: Sat, 8 Jul 2023 16:48:57 -0700 > > I agree that it’s easy to figure out what does the detached @ syntax mean. I mainly just don’t like having two ways to do the same thing. > > Since I don’t use search symbol myself, I can’t grasp the importance of it. You apparently care about it enough to go this far, and I’m willing to take your word for it. > > You mentioned sexp queries, which reminded me that using the detached syntax would allow people to interpolate capture names with quasi quotes. That’s a plus for the detached syntax. > > Ultimately I’m still on the fence for this. But if you still want to add it, please go ahead :-) I'd like to hear Stefan's opinion on this, before we make such a change (if we make it). From debbugs-submit-bounces@debbugs.gnu.org Sun Jul 09 08:36:54 2023 Received: (at 44418) by debbugs.gnu.org; 9 Jul 2023 12:36:54 +0000 Received: from localhost ([127.0.0.1]:45930 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qITeo-0002nQ-F9 for submit@debbugs.gnu.org; Sun, 09 Jul 2023 08:36:54 -0400 Received: from mailscanner.iro.umontreal.ca ([132.204.25.50]:41207) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qITei-0002n0-88 for 44418@debbugs.gnu.org; Sun, 09 Jul 2023 08:36:52 -0400 Received: from pmg3.iro.umontreal.ca (localhost [127.0.0.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 9CDC444093E; Sun, 9 Jul 2023 08:36:42 -0400 (EDT) Received: from mail01.iro.umontreal.ca (unknown [172.31.2.1]) by pmg3.iro.umontreal.ca (Proxmox) with ESMTP id 5CF4D44031F; Sun, 9 Jul 2023 08:36:41 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=iro.umontreal.ca; s=mail; t=1688906201; bh=VFTQ0sLtIJXmYSTH3Jeyd5jwIaB/BP3TENXExaBJnI0=; h=From:To:Cc:Subject:In-Reply-To:References:Date:From; b=GjLkXVDd9wP843hfC+Spvk/jfJ6KGUf2u4WGF8YRepaeQrg7e9tPxBzA49FHT+3QZ xaebjAa68lRFucVnXMpY+mw5GdtN00ihU2yKhTApSVIqJtuE8o88pAbMwEKabhKhVs ecN4MhBxbynNDYXiNpiGwMr9MUPKMvY9mCb3RTqpDYTmMbdGIm0B8egjSl8ykLuQC0 WMMmJvbwRcscb49IfAQSFBnpUMKCV0Dj8pd6OEyk3jb0VLbA0U5r56d8xQgnSQaJRK FTQvtG733oTf4I+WYBTdz73T5EaSZdM7yO6oAkDNYJeXQ4FZYl0vIqa7J+DPd1/n3/ WWa6sJIYtHf/Q== Received: from pastel (unknown [24.140.234.50]) by mail01.iro.umontreal.ca (Postfix) with ESMTPSA id 254FD120208; Sun, 9 Jul 2023 08:36:41 -0400 (EDT) From: Stefan Monnier To: Eli Zaretskii Subject: Re: bug#44418: 28.0.50; Spliced variable not matched as symbol in isearch In-Reply-To: <83ilatbotd.fsf@gnu.org> (Eli Zaretskii's message of "Sun, 09 Jul 2023 09:07:26 +0300") Message-ID: References: <9289047B-5BD7-493A-8A89-E2B0B38A8364@gmail.com> <83ilatbotd.fsf@gnu.org> Date: Sun, 09 Jul 2023 08:36:39 -0400 User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-SPAM-INFO: Spam detection results: 0 ALL_TRUSTED -1 Passed through trusted hosts only via SMTP AWL -0.444 Adjusted score from AWL reputation of From: address BAYES_00 -1.9 Bayes spam probability is 0 to 1% DKIM_SIGNED 0.1 Message has a DKIM or DK signature, not necessarily valid DKIM_VALID -0.1 Message has at least one valid DKIM or DK signature DKIM_VALID_AU -0.1 Message has a valid DKIM or DK signature from author's domain DKIM_VALID_EF -0.1 Message has a valid DKIM or DK signature from envelope-from domain T_SCC_BODY_TEXT_LINE -0.01 - X-SPAM-LEVEL: X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44418 Cc: contovob@tcd.ie, 44418@debbugs.gnu.org, Yuan Fu , larsi@gnus.org, mattias.engdegard@gmail.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) >> I agree that it=E2=80=99s easy to figure out what does the detached @ sy= ntax >> mean. I mainly just don=E2=80=99t like having two ways to do the same th= ing. >>=20 >> Since I don=E2=80=99t use search symbol myself, I can=E2=80=99t grasp th= e importance of >> it. You apparently care about it enough to go this far, and I=E2=80=99m = willing to >> take your word for it. >>=20 >> You mentioned sexp queries, which reminded me that using the detached >> syntax would allow people to interpolate capture names with quasi >> quotes. That=E2=80=99s a plus for the detached syntax. >>=20 >> Ultimately I=E2=80=99m still on the fence for this. But if you still wan= t to add it, please go ahead :-) > > I'd like to hear Stefan's opinion on this, before we make such a > change (if we make it). Yuan knows this area much better than I do, and I fully trust his judgment on this. The only I'd point out is that if we introduce a (@ ...) syntax here we should try and phase out the old @... syntax, i.e. emit an obsolescence warning when we bump into such code. Stefan From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 12 10:47:03 2023 Received: (at 44418) by debbugs.gnu.org; 12 Jul 2023 14:47:03 +0000 Received: from localhost ([127.0.0.1]:52741 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJb7P-0001MU-BG for submit@debbugs.gnu.org; Wed, 12 Jul 2023 10:47:03 -0400 Received: from mail-lf1-f46.google.com ([209.85.167.46]:62917) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJb7N-0001Ly-Ac for 44418@debbugs.gnu.org; Wed, 12 Jul 2023 10:47:02 -0400 Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-4fb7373dd35so1072616e87.1 for <44418@debbugs.gnu.org>; Wed, 12 Jul 2023 07:47:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20221208; t=1689173215; x=1691765215; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:from:to:cc:subject :date:message-id:reply-to; bh=cajqHwc2gjserWB5akwW5HXLYsxxfRNQkx3K+B71Z/E=; b=FZw1zDKTHa+F54Bba1KLJu/agQSLTHsPn9qCvwCtvF+DgnndtXleUiGdUDig9gReIy YvQUwYoKB48A3JkP75VxIaHGctRyOoAE+e63qRaCxZG+nvwpAy6TwBCjycqWb9pCqcSG cEitLL9w5NJl2Ex/Rroij/t+EYUgpync4WrmbHCSxTZMvNlPUL1F00SNJETJqADUd5zB G4DPNuhzBhsMiCjb9UKaQoYkfGgqs0vDx3qnilTOvBkg0qIicf4sriWZ5p8/+0vsRM0R vHlO9otSEeVPrmkC4eQW7fHmXPYvVWF5UlN9nMDVP7lC9oo+6BSlDtDdhd9mUmqkD8/g y4Ww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689173215; x=1691765215; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:sender:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=cajqHwc2gjserWB5akwW5HXLYsxxfRNQkx3K+B71Z/E=; b=SBH/qzJuxaOaznuz7uTCVYUEQUisp/RectuiMc5ajWwE/z4ihFvSD20QchqtOnSqGs U8/he+qUnm+jbvi3fkiGLSlTtfv1sKfC/SZXhDbqM7Fo3obuzZkueYCbjnyYWjyMcqU1 xzMvll6wFpedSgFdhkvdfiTjjcnZs1EQoVsngFmA5k3zu/NeVyFyLSorLvzmQg9qPmJ8 YnQTDCJMMwBE9qYCOTmXo7iX3W3X6RYmuZUXxnCcz0mEn5d9WTEQK+//u51HK1LZpXTe NdOxzr48RBT2bu/ySne9VeC5JjUcmrLUXtvdZTLUduBPrMbPbHJgnRQo4moZi1wEUUsE tBHw== X-Gm-Message-State: ABy/qLZrfiUivOXN0Quuq0UgoWPNKachDEKdZrzAI6quAARWmi2qvUOE exxVOSc8SnHJrAZ1N78INU0= X-Google-Smtp-Source: APBJJlGL9YMqab9U4FAE6W08f9VWXNuMDJZyhur5TVEdLza0hF9G/yt5gdFQ0K3w9tBPG3AW8kWcxQ== X-Received: by 2002:ac2:5e26:0:b0:4fa:d522:a38f with SMTP id o6-20020ac25e26000000b004fad522a38fmr694477lfg.26.1689173214967; Wed, 12 Jul 2023 07:46:54 -0700 (PDT) Received: from smtpclient.apple (c188-150-165-235.bredband.tele2.se. [188.150.165.235]) by smtp.gmail.com with ESMTPSA id z1-20020ac25de1000000b004fbc0c7218bsm743734lfq.118.2023.07.12.07.46.54 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 12 Jul 2023 07:46:54 -0700 (PDT) Content-Type: text/plain; charset=utf-8 Mime-Version: 1.0 (Mac OS X Mail 14.0 \(3654.120.0.1.15\)) Subject: Re: bug#44418: 28.0.50; Spliced variable not matched as symbol in isearch From: =?utf-8?Q?Mattias_Engdeg=C3=A5rd?= In-Reply-To: <9289047B-5BD7-493A-8A89-E2B0B38A8364@gmail.com> Date: Wed, 12 Jul 2023 16:46:53 +0200 Content-Transfer-Encoding: quoted-printable Message-Id: <015A93AD-A7C2-45A6-B5B3-4133F3EE7159@gmail.com> References: <9289047B-5BD7-493A-8A89-E2B0B38A8364@gmail.com> To: Yuan Fu X-Mailer: Apple Mail (2.3654.120.0.1.15) X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44418 Cc: Basil Contovounesios , 44418@debbugs.gnu.org, Lars Ingebrigtsen , monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) 9 juli 2023 kl. 01.48 skrev Yuan Fu : > Sorry for taking so long, I never decided against other people for = important things in Emacs, and I certainly don=E2=80=99t want to make a = wrong decision and regret it later, so I struggled a bit and kept = procrastinating No, I'm the one to apologise here: in no way did I intend to heap = pressure on you. The native tree-sitter query syntax is actually not using S-expressions = at all -- the parsing is completely ad-hoc, and the query data is = constructed directly during parsing. But it looks very much like S-expressions and that's the problem. If the = syntax had been less Lisp-like then we would have been able to choose = our own S-expressions freely and all would be well, but now it's a bit = too close so that it's really tempting to use something with almost = identical printed appearance. I think you have done a fine job under the = circumstances. > Since I don=E2=80=99t use search symbol myself, I can=E2=80=99t grasp = the importance of it. You apparently care about it enough to go this = far, and I=E2=80=99m willing to take your word for it. It probably isn't much of a problem in practice. I just thought that it = would be a pity to forego the opportunity to deal with it from the = start, but I definitely won't complain if you keep it the way it is. From debbugs-submit-bounces@debbugs.gnu.org Wed Jul 12 11:09:59 2023 Received: (at 44418) by debbugs.gnu.org; 12 Jul 2023 15:09:59 +0000 Received: from localhost ([127.0.0.1]:52786 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJbTb-00023b-9P for submit@debbugs.gnu.org; Wed, 12 Jul 2023 11:09:59 -0400 Received: from out5-smtp.messagingengine.com ([66.111.4.29]:60185) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJbTV-000233-Ej for 44418@debbugs.gnu.org; Wed, 12 Jul 2023 11:09:57 -0400 Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id CF2025C0124; Wed, 12 Jul 2023 11:09:47 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Wed, 12 Jul 2023 11:09:47 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1689174587; x=1689260987; bh=epdGScZqtdsasNowg9dQyr3THNM4EljuX+C hNdWNtVI=; b=C8T8PVyc6/4f9KI6V/J7vqoYsRLEsQQ/ZGYn3kjut9/zzLuguab r7b9/K4cDPYacg6B/AMVXgehUTPhOZGgOpHjoip5o0B/iX7zr/hutVqAbjfW0doC k4wrP7ak9Hlcgv8QwCMxosk4hA1lCCUs7ek5vrWjVB+dE35jQUJSIkqlYFi2F01X 5tm20KI7KVxoyIE4UXOdI1L1QlEX3MJWLAZ6DIFMNbf3XeKMLmUr78qVJyDAL9TT Hc7i15FyrJGKtMyD9YvZ8uxZima78chus8xsubm9KMjzhg16JMs78TvS8w+NKy63 GDxWsD6oh67nZZrOTx1iqbnqzmpWxyVtZeA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1689174587; x=1689260987; bh=epdGScZqtdsasNowg9dQyr3THNM4EljuX+C hNdWNtVI=; b=o4hozst+4HAQCq4PflybFKhHNgxEoUs2LJALozWuI/CwZ0IHvJ3 ga4bjiFHl2KLHJrMbqatHNA/VYbsW0UwCt3wGyzduwB4ZKawWq8pygJRSbmFVPRr dZz7kq1KD2kmCSIQ+WYUMAWfyIAURa74F6gteWiCt6BZ6UMNsjlzve2EJbifzb0W uYM7gX/2mR7LqCRBKfEOap9wluvp9TWUmRR+Hp2xZ1Wc2bioNp3X845Wb8JeNE63 zqerQRfhTorq18fdhebZR9gLIOVPzG6uDKAJb5ZS/2KcJ1nNEwd0+onJjqe7kKxZ +CGSt2nAVsIMOlDGnHVHegc9kywmMl0revw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrfedvgdekiecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpeeigfetveehveevffehledtueekieeikeeufeegudfgfeeghfdulefgfeevledv veenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 12 Jul 2023 11:09:45 -0400 (EDT) Message-ID: Date: Wed, 12 Jul 2023 18:09:43 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: bug#44418: 28.0.50; Spliced variable not matched as symbol in isearch Content-Language: en-US To: Stefan Monnier , Eli Zaretskii References: <9289047B-5BD7-493A-8A89-E2B0B38A8364@gmail.com> <83ilatbotd.fsf@gnu.org> From: Dmitry Gutov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -1.8 (-) X-Debbugs-Envelope-To: 44418 Cc: contovob@tcd.ie, 44418@debbugs.gnu.org, Yuan Fu , mattias.engdegard@gmail.com, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.8 (--) On 09/07/2023 15:36, Stefan Monnier via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > The only I'd point out is that if we introduce a (@ ...) syntax here > we should try and phase out the old @... syntax, i.e. emit an > obsolescence warning when we bump into such code. IMO that's indeed the biggest problem with the proposal: if we could swap @ in the current syntax for something else, that might be ideal. But as proposed (and at this stage of Emacs 29 development) we'll likely carry two different syntaxes for a number of years, and only one of them will show up in symbol searches (such as xref-find-references or isearch for "\\_) id 1qJbk7-0002WH-DG for submit@debbugs.gnu.org; Wed, 12 Jul 2023 11:27:03 -0400 Received: from mail-pl1-f180.google.com ([209.85.214.180]:54355) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qJbk4-0002Vg-3M for 44418@debbugs.gnu.org; Wed, 12 Jul 2023 11:27:01 -0400 Received: by mail-pl1-f180.google.com with SMTP id d9443c01a7336-1b8ad8383faso52309385ad.0 for <44418@debbugs.gnu.org>; Wed, 12 Jul 2023 08:27:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1689175614; x=1691767614; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=dLo6Qktbw8/nKWkYvcp0Afjiemp9t2j+OIDqcJ5v8yU=; b=HytvBn7r7FZcOCtBOvadmjMOXcJERzcSowhgbyHnGYviCpmkBX8B0Q+2wIVOkNBDAN 29kB9S/Jl4uqVIwdTreLpxG9K0atgYQkTw0jtn56TtNcqU1gs307tq2z3ORjkiexW3NW gk2fYnCZVYQtTZPeASiZQdC0OCi8CwFsEM2ijd5odv+3kICGY8M/6LN9CfGSiy3s13Z9 vAn5+nC8VT2AXSR5Bo6hx2zpCbnz/gmqXNRSQsFx2J8Ud7eriaJpO5AnoPR0iNl+larJ EJ8H+BPmcbuwUQreJh9A0YeWFCuap/OOEVYneAbkCGcME/W/tPHoU3XAktmB354qQwhI jnyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689175614; x=1691767614; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=dLo6Qktbw8/nKWkYvcp0Afjiemp9t2j+OIDqcJ5v8yU=; b=QuT0z6KR94W0n05ITvOzK6vjVpVpSGmiL1OaAW078/PfiSRpmX5qqAZ/N7BO+aezkc q6/49ZNhNGuEVnkvsOxHdQWBshP6N/u3ej1MdfmPf6Hnh+puO12bPSxRKrU8DMTvcBXH v79PcSCLn0VMDTXaop5tDFurgw2Vj4WhqeUJuCQ+i8GbrVtWZWx6z98gYLivRSk6oYJ9 Z4VSur2k37liaGphCfj8vgoF5pJrmeuHHzlmWYaYQD2du7gqonns9WD/UZ6uElOWb7zD Iu/+FoNkpEWrp43vzTBW6zvkCOoqkbqOqbLokTKRfkZX1+Yms4tb0+DgHRxgNGawE7xZ 37bA== X-Gm-Message-State: ABy/qLaC1B/NGtmQ1XAtpKCETc3EZbL7v55t1TNaglG0+BP2zxLSbsz4 S0vlMa59wx/85XpIfmJoC+ksYg== X-Google-Smtp-Source: APBJJlG/ReNfKu79haJ4CO5+9MiBrmrT+KDPguz9RtzESojMZ0FEfR+GGK9J6jBWaYcP4CIWkeeMRQ== X-Received: by 2002:a17:902:d892:b0:1b8:36a8:faf9 with SMTP id b18-20020a170902d89200b001b836a8faf9mr19342029plz.38.1689175613975; Wed, 12 Jul 2023 08:26:53 -0700 (PDT) Received: from localhost ([109.79.32.154]) by smtp.gmail.com with ESMTPSA id w14-20020a170902a70e00b001b9c5e0393csm4126890plq.225.2023.07.12.08.26.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 12 Jul 2023 08:26:53 -0700 (PDT) From: Basil Contovounesios To: Mattias =?utf-8?Q?Engdeg=C3=A5rd?= Subject: Re: bug#44418: 28.0.50; Spliced variable not matched as symbol in isearch In-Reply-To: <015A93AD-A7C2-45A6-B5B3-4133F3EE7159@gmail.com> ("Mattias =?utf-8?Q?Engdeg=C3=A5rd=22's?= message of "Wed, 12 Jul 2023 16:46:53 +0200") References: <9289047B-5BD7-493A-8A89-E2B0B38A8364@gmail.com> <015A93AD-A7C2-45A6-B5B3-4133F3EE7159@gmail.com> Date: Wed, 12 Jul 2023 16:26:50 +0100 Message-ID: <87r0pdf8w5.fsf@epfl.ch> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44418 Cc: 44418@debbugs.gnu.org, Yuan Fu , Lars Ingebrigtsen , monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mattias Engdeg=C3=A5rd [2023-07-12 16:46 +0200] wrote: > But it looks very much like S-expressions and that's the problem. If the = syntax > had been less Lisp-like then we would have been able to choose our own > S-expressions freely and all would be well, but now it's a bit too close = so that > it's really tempting to use something with almost identical printed > appearance. I think you have done a fine job under the circumstances. Agreed. >> Since I don=E2=80=99t use search symbol myself, I can=E2=80=99t grasp th= e importance of >> it. You apparently care about it enough to go this far, and I=E2=80=99m = willing to >> take your word for it. > > It probably isn't much of a problem in practice. I just thought that it w= ould be > a pity to forego the opportunity to deal with it from the start, but I > definitely won't complain if you keep it the way it is. And agreed. I wouldn't be too confident straying far from the familiar upstream syntax either. FWIW, another result of the @-prefix capture syntax in the case of font lock is that it is a bit harder to detect invalid capture names, such as function names that are no longer defined: :feature 'foo :language 'bar '((foo @my-baz)) Where my-baz may or may not be defined as a function, and if not is silently ignored. There's probably more than one way to warn about such cases in treesit.el (or catch them with testing), but my current downstream workaround is: (defun my--@ (name) (intern (concat "@" (symbol-name name)))) (defvar my--font-lock-rules (let ((baz (my--@ #'my-baz))) `( :feature foo :language bar ((foo ,baz))))) Sadly I couldn't find a convenient compile-time way of achieving the same (the byte-compiler doesn't see the arguments to inline functions, and my-baz isn't known to be defined at macroexpansion time). --=20 Basil From debbugs-submit-bounces@debbugs.gnu.org Mon Jul 17 21:54:53 2023 Received: (at 44418) by debbugs.gnu.org; 18 Jul 2023 01:54:53 +0000 Received: from localhost ([127.0.0.1]:51276 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLZvR-0007iu-9I for submit@debbugs.gnu.org; Mon, 17 Jul 2023 21:54:53 -0400 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:53237) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLZvN-0007ib-Ci for 44418@debbugs.gnu.org; Mon, 17 Jul 2023 21:54:52 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id BC81D5C00F2; Mon, 17 Jul 2023 21:54:43 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Mon, 17 Jul 2023 21:54:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gutov.dev; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm1; t= 1689645283; x=1689731683; bh=LbdFDXhj04Lgf4SDe8e96jUMSjq6Wst+kPL TgLiPBbw=; b=Jcp7j1gG3mXQhaZTyN2rE20YEcsw9bLVoLO0a72ctDXhDn5zqkU c2mGLGR57cCsJwqbUYxXXY9XXFpdxxSXNepZVA6iwbuIUNDKsKPi27qXJgREvh4q RHOx0+YJ42aRkliRlC02xAvfCFaC1wFdof7FTWx4ClyvqNtw6B8yBtAj/+CyTiV4 VrrP1GmF18iCEPfZmrsqQn2EXe6U/Nm/5/IZRf6HmeMGIaaosrKM6Zp4gjpTd09j CdWL1qKIGavyHN3mPGINCdPSXG+aj+hI99/Y7I+BnHmWDZzx/Ag0XUPdHCI/Lq2r RNi9bL4EKQgXbJqQgXhS7Na6/tUucVx66ww== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm3; t= 1689645283; x=1689731683; bh=LbdFDXhj04Lgf4SDe8e96jUMSjq6Wst+kPL TgLiPBbw=; b=Cv6UEy2byOLmuQ3pI7JJOgqZg0Oj06VFoLC5eSBpHjCIFxBfOif l7iWEFGM53nYmdCEhF6oKf8SbyxHkwqcWIzxIcbDgKUXfdzq4quDhwRJmCCJ1ed2 nqUpQPCOMVr3pppwlwDpyc3WnI3Ec2fD4IoIGXct9XgR+9XjL2ClAlxeOdnQJprj PHiVJNM+FlWf6mGkX47af5vSSc2QmrqM2iE+P0bJwhOv/NIOq9LHbYJJVXQR4Ktw 6MZcgeqaKYAMh1ISJOEGxjfG0Y6wbuuz51OfdqjhzvCd7o0DKoosfuwXdCTmw+ih C78V9tyj842tFJU2teDk8ubHlN6Yh0MTuvA== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedviedrgeefgdehvdcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomhepffhmihht rhihucfiuhhtohhvuceoughmihhtrhihsehguhhtohhvrdguvghvqeenucggtffrrghtth gvrhhnpeeigfetveehveevffehledtueekieeikeeufeegudfgfeeghfdulefgfeevledv veenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpegumh hithhrhiesghhuthhovhdruggvvh X-ME-Proxy: Feedback-ID: i0e71465a:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Mon, 17 Jul 2023 21:54:40 -0400 (EDT) Message-ID: <81b69bc7-30d8-481c-d531-8bb051b53299@gutov.dev> Date: Tue, 18 Jul 2023 04:54:39 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.13.0 Subject: Re: bug#44418: 28.0.50; Spliced variable not matched as symbol in isearch Content-Language: en-US To: Basil Contovounesios , =?UTF-8?Q?Mattias_Engdeg=c3=a5rd?= References: <9289047B-5BD7-493A-8A89-E2B0B38A8364@gmail.com> <015A93AD-A7C2-45A6-B5B3-4133F3EE7159@gmail.com> <87r0pdf8w5.fsf@epfl.ch> From: Dmitry Gutov In-Reply-To: <87r0pdf8w5.fsf@epfl.ch> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Spam-Score: -0.8 (/) X-Debbugs-Envelope-To: 44418 Cc: 44418@debbugs.gnu.org, Yuan Fu , Lars Ingebrigtsen , monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) On 12/07/2023 18:26, Basil Contovounesios via Bug reports for GNU Emacs, the Swiss army knife of text editors wrote: > Where my-baz may or may not be defined as a function, and if not is > silently ignored. @captures can also be face names directly, not always functions. From debbugs-submit-bounces@debbugs.gnu.org Tue Jul 18 04:35:36 2023 Received: (at 44418) by debbugs.gnu.org; 18 Jul 2023 08:35:36 +0000 Received: from localhost ([127.0.0.1]:51491 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLgBE-0001sZ-Cv for submit@debbugs.gnu.org; Tue, 18 Jul 2023 04:35:36 -0400 Received: from mail-wm1-x333.google.com ([2a00:1450:4864:20::333]:47613) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qLgBB-0001sK-92 for 44418@debbugs.gnu.org; Tue, 18 Jul 2023 04:35:35 -0400 Received: by mail-wm1-x333.google.com with SMTP id 5b1f17b1804b1-3fbc63c2e84so53735965e9.3 for <44418@debbugs.gnu.org>; Tue, 18 Jul 2023 01:35:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1689669327; x=1692261327; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to; bh=kNsgTQWa4eyS/R+X/lANPYvIAFzNEbY4+UHhBbhMrm0=; b=SANUnVw4LtG5wYgYT2XLjmJ5HrXM4teLyE9wFm7Q1p/TTbmcgISMtDbG7aittQURH5 DbbdZCFJj/Hw4rcN7mMPWfer9thSI2w+HkwK/vomtJCeXlFbibGao1lqHRZg2too1GqS ULE18ghIzP5d+j3LOh0LTV+veoqDw2x0DJFhN6jMh2fElWue6XyJfz22gJwSH1rbM4qV Vc6c+KLeeOtcGxxfQzc+lOrzHkMYv9xotgkY6CFipEO79sMlO8n8uX9XGbbpmCqR1EVs L0isVyMPzj/Z4nJB0SM/d69MkvCRAZUSxmJmrZX4uuocOBSTahk3Ja8ocIpCcSIDvUb1 mpUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1689669327; x=1692261327; h=mime-version:user-agent:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=kNsgTQWa4eyS/R+X/lANPYvIAFzNEbY4+UHhBbhMrm0=; b=OXAiCWKPQY6KP3J2b7C0u8NdcR3AdBmy5pxC7aGQ+mWrapo+GGBzl4gI5zMa3e9hti exgQldtQO82j5DrvcsAAYPm7J0udozXizXgwu2x/O7oZk9agKIneHbdiDNKdQlpUOK3e 4PV9eR46gquQDfOeKs/fIKyMCqAd2Qd5QvZy1jKhUnbiWvbEdV8WVPpEr3CW27R7QMjB /50h/p3fX9gHpbUUy1rJE9nnG/yspNtlE9peUzopI7Fzx9tmNu3Xc4yzy3U6cu8GLHkY omqTIyOFaWpnbjGhoGTw/TEq7LPyCJJVMszzXxDN9HDJKb1LMW/1LKp5zSxnl+U+Sfwx gYKw== X-Gm-Message-State: ABy/qLboeJs0DQySmrDD9+eSmUE5NoJjfNL6fgpIlkZ7Ml6vpxsoy9bh V3L38jCDAjKc2pBPi5UEBzK2eA== X-Google-Smtp-Source: APBJJlHkHjt7J3Ksv9sTBgH9ZOxxkPOb2VOGbc++g/3aPz8iRyaqNkIF5L3ObGlAAVeaAjaHQsxFIg== X-Received: by 2002:a7b:c397:0:b0:3fb:b008:2002 with SMTP id s23-20020a7bc397000000b003fbb0082002mr1252690wmj.0.1689669326881; Tue, 18 Jul 2023 01:35:26 -0700 (PDT) Received: from localhost ([109.78.31.65]) by smtp.gmail.com with ESMTPSA id x13-20020a05600c21cd00b003fa8158135esm9872108wmj.11.2023.07.18.01.35.26 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 18 Jul 2023 01:35:26 -0700 (PDT) From: Basil Contovounesios To: Dmitry Gutov Subject: Re: bug#44418: 28.0.50; Spliced variable not matched as symbol in isearch In-Reply-To: <81b69bc7-30d8-481c-d531-8bb051b53299@gutov.dev> (Dmitry Gutov's message of "Tue, 18 Jul 2023 04:54:39 +0300") References: <9289047B-5BD7-493A-8A89-E2B0B38A8364@gmail.com> <015A93AD-A7C2-45A6-B5B3-4133F3EE7159@gmail.com> <87r0pdf8w5.fsf@epfl.ch> <81b69bc7-30d8-481c-d531-8bb051b53299@gutov.dev> Date: Tue, 18 Jul 2023 09:35:25 +0100 Message-ID: <87ilahvcqa.fsf@epfl.ch> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 44418 Cc: 44418@debbugs.gnu.org, Lars Ingebrigtsen , Mattias =?utf-8?Q?Engdeg=C3=A5rd?= , Yuan Fu , monnier@iro.umontreal.ca X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Dmitry Gutov [2023-07-18 04:54 +0300] wrote: > On 12/07/2023 18:26, Basil Contovounesios via Bug reports for GNU Emacs, the > Swiss army knife of text editors wrote: >> Where my-baz may or may not be defined as a function, and if not is >> silently ignored. > > @captures can also be face names directly, not always functions. Of course, that's why I said: > it is a bit harder to detect invalid capture names, such as ^^^^^^^ > function names that are no longer defined -- Basil From debbugs-submit-bounces@debbugs.gnu.org Fri Jul 28 04:05:32 2023 Received: (at control) by debbugs.gnu.org; 28 Jul 2023 08:05:32 +0000 Received: from localhost ([127.0.0.1]:43570 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPITc-0000kG-Fw for submit@debbugs.gnu.org; Fri, 28 Jul 2023 04:05:32 -0400 Received: from mail-ej1-x643.google.com ([2a00:1450:4864:20::643]:57515) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1qPITW-0000ji-Fl for control@debbugs.gnu.org; Fri, 28 Jul 2023 04:05:30 -0400 Received: by mail-ej1-x643.google.com with SMTP id a640c23a62f3a-99454855de1so244527366b.2 for ; Fri, 28 Jul 2023 01:05:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tcd.ie; s=google21; t=1690531520; x=1691136320; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=/I1di3ba9CQtV72mYXkKIMR9BD3HdSNq94VuInkkP7Y=; b=aCLopILhextZHtO++piOqRf+yBoNfge3cOR4zmPPt5HOsO7OPSp21wQPivdmdE40GC iF0/3w4Pp49vBKzprpYE6ui740bk9LbNaXqpzwmrjLiGKORVa7tkwC2zjFIA9N6WNXvB 0GHZcqTr+WyzXBCs2Yt6X0tduWHsBYdnDWvfT09+nd9g+QzeB1li4vc6ofvH0z1hqwYh usg002k1cZb8dfnP9vctJcW+6E3oBqp1pMuQFJrwe/W6sC7SChDud6LHA+Rx0AoAMJvM jgSYQ++UBPd8+x0g7mqkbF6voOKODqFTHXLjm/S6z0Zlfb9oZppKZiBVz14V667gMMxG 9kyw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1690531520; x=1691136320; h=content-transfer-encoding:mime-version:user-agent:message-id:date :references:in-reply-to:subject:cc:to:from:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=/I1di3ba9CQtV72mYXkKIMR9BD3HdSNq94VuInkkP7Y=; b=FbmTy57gmQTjrwRUbgNFBbfe15wikp+Z4YJbBcjH9zajxfHPDRW2O0p3nFJisQmBPY 3jTakVx0rK7kzVizAel+I4pYvQP6KEzdDOfJtXJvcA9TUKBZ5FyoNj4P4aKWDfZSbQdM fbTXbs9eix2ZzLXzJIzyKaumm8jo6fMEBhY7aTLmWySF47h+HQocaDUFNPY1oab8wuAK k81Aa1JoekIjW5jhb/Plj2Xns4LXZJBQp5ILP1D0bYpCGbQrXJrsA2q8o7lUqURYedYB 4WtxWUyOfYZmeIh0SkEyJJe32Zh+HVB1jJ+aGSFaMiDv9JJkz8kFTZghblaaLOv52juy +c9Q== X-Gm-Message-State: ABy/qLYTbVDH6xGU2JhkbI5t/YzmLXbpl49nmUEWU3t+tujaMEjmtFcC 4dGfAWAsuHjaFwB6hZ/wXTnPFnYTDK/5byjHjusq9I4C3MnmiA== X-Google-Smtp-Source: APBJJlH+uWWt7U6iI1qT0M31p7AsGiK7XO+CmauEImwdVRf/jCsofPnK3U3Z1b10/F1QMzy79ODJqQ== X-Received: by 2002:a17:906:2cd:b0:99b:c845:791d with SMTP id 13-20020a17090602cd00b0099bc845791dmr1433110ejk.76.1690531520322; Fri, 28 Jul 2023 01:05:20 -0700 (PDT) Received: from localhost ([2001:620:618:590:2:80b3:0:e5c]) by smtp.gmail.com with ESMTPSA id f5-20020a1709064dc500b0098f33157e7dsm1763660ejw.82.2023.07.28.01.05.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Jul 2023 01:05:19 -0700 (PDT) From: "Basil L. Contovounesios" To: 22238@debbugs.gnu.org Subject: Re: bug#22238: 25.0.50; isearch symbol search can't find ,@symbol In-Reply-To: <87fs58bzom.fsf@web.de> (Michael Heerdegen's message of "Fri, 28 Jul 2023 03:19:21 +0200") References: <87io3mtdxw.fsf@web.de> <87fs58bzom.fsf@web.de> Date: Fri, 28 Jul 2023 10:05:08 +0200 Message-ID: <874jloh363.fsf@epfl.ch> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: control Cc: michael_heerdegen@web.de X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) severity 22238 minor merge 22238 44418 quit [ Is there a pattern in the bug numbers? =F0=9F=A4=94 ] Michael Heerdegen [2023-07-28 03:19 +0200] wrote: > Michael Heerdegen writes: >> isearch's symbol search (M-s _) doesn't find symbols as in >> ,@symbol >> when searching for "symbol". This was already the case in Emacs 24.5. > Checking this again and: this seems to be fixed. Closing. Ah, I didn't find this report before submitting the duplicate https://bugs.gnu.org/44418 (although I claimed to find the behaviour in Emacs 24.5 as well). Let's see if merging works without the need for excessive force... Thanks, --=20 Basil From unknown Mon Aug 18 07:45:34 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 26 Aug 2023 11:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator