From unknown Tue Jun 17 01:50:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44411: 28.0.50; uudecode-decode-region-internal is broken Resent-From: Kazuhiro Ito Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 03 Nov 2020 08:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 44411 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 44411@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.160439207826821 (code B ref -1); Tue, 03 Nov 2020 08:28:02 +0000 Received: (at submit) by debbugs.gnu.org; 3 Nov 2020 08:27:58 +0000 Received: from localhost ([127.0.0.1]:43277 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZrfZ-0006yX-S2 for submit@debbugs.gnu.org; Tue, 03 Nov 2020 03:27:58 -0500 Received: from lists.gnu.org ([209.51.188.17]:33894) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZrfY-0006yQ-LC for submit@debbugs.gnu.org; Tue, 03 Nov 2020 03:27:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47798) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZrfY-0008F4-DX for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2020 03:27:56 -0500 Received: from snd00004.auone-net.jp ([111.86.247.4]:53920 helo=dmta0004.auone-net.jp) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZrfU-0002XV-Lw for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2020 03:27:55 -0500 Received: from kzhr.d1.dion.ne.jp by dmta0004.auone-net.jp with ESMTP id <20201103082743382.ZODW.95516.kzhr.d1.dion.ne.jp@dmta0004.auone-net.jp>; Tue, 3 Nov 2020 17:27:43 +0900 Date: Tue, 03 Nov 2020 17:27:41 +0900 Message-ID: <86y2ji6e0y.wl--xmue@d1.dion.ne.jp> From: Kazuhiro Ito X-Hashcash: 1:20:201103:bug-gnu-emacs@gnu.org::Q100fm868IIO3wC0:00000000000000000000000000000000000000007tF4 User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?Q?Goj=C5=8D?=) APEL-LB/10.8 Emacs/28.0.50 (x86_64-w64-mingw32) MULE/6.0 (HANACHIRUSATO) (with unibyte mode) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Received-SPF: pass client-ip=111.86.247.4; envelope-from=kzhr@d1.dion.ne.jp; helo=dmta0004.auone-net.jp X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/03 03:27:43 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) When I call uudecode-decode-region-internal in multibyte buffer, it fails to decode eight-bit characters. The function makes string from uuencoded text by passing unsigned char vlue (0-255) to char-to-string function, which makes multibyte-string. After that, string is decoded as binary. But eight-bit characters are never made in that way. (let ((ch #xc8)) (decode-coding-string (char-to-string ch) 'binary)) -> "8" Additionally, concat and char-to-string functions are called so frequently that deocder is very slow for large data. Please see the below patch. diff --git a/lisp/mail/uudecode.el b/lisp/mail/uudecode.el index bcbd571b53..f9254aee75 100644 --- a/lisp/mail/uudecode.el +++ b/lisp/mail/uudecode.el @@ -149,12 +149,10 @@ uudecode-decode-region-internal (setq counter (1+ counter) inputpos (1+ inputpos)) (cond ((= counter 4) - (setq result (cons - (concat - (char-to-string (ash bits -16)) - (char-to-string (logand (ash bits -8) 255)) - (char-to-string (logand bits 255))) - result)) + (setq result (cons (logand bits 255) + (cons (logand (ash bits -8) 255) + (cons (ash bits -16) + result)))) (setq bits 0 counter 0)) (t (setq bits (ash bits 6))))))) (cond @@ -166,26 +164,21 @@ uudecode-decode-region-internal ;;(error "uucode ends unexpectedly") (setq done t)) ((= counter 3) - (setq result (cons - (concat - (char-to-string (logand (ash bits -16) 255)) - (char-to-string (logand (ash bits -8) 255))) - result))) + (setq result (cons (logand (ash bits -8) 255) + (cons (logand (ash bits -16) 255) + result)))) ((= counter 2) - (setq result (cons - (char-to-string (logand (ash bits -10) 255)) - result)))) + (setq result (cons (logand (ash bits -10) 255) + result)))) (skip-chars-forward non-data-chars end)) + (setq result (apply #'unibyte-string (nreverse result))) (if file-name (with-temp-file file-name (set-buffer-multibyte nil) - (insert (apply #'concat (nreverse result)))) + (insert result)) (or (markerp end) (setq end (set-marker (make-marker) end))) (goto-char start) - (if enable-multibyte-characters - (dolist (x (nreverse result)) - (insert (decode-coding-string x 'binary))) - (insert (apply #'concat (nreverse result)))) + (insert result) (delete-region (point) end)))))) ;;;###autoload -- Kazuhiro Ito From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 03 10:07:50 2020 Received: (at control) by debbugs.gnu.org; 3 Nov 2020 15:07:50 +0000 Received: from localhost ([127.0.0.1]:46038 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZxuY-0007GZ-2x for submit@debbugs.gnu.org; Tue, 03 Nov 2020 10:07:50 -0500 Received: from quimby.gnus.org ([95.216.78.240]:60452) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZxuW-0007GM-PG for control@debbugs.gnu.org; Tue, 03 Nov 2020 10:07:49 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=VWORP7UrPbgIvcAyz+bcKNoTY03zWJRWQxVViqvkIQg=; b=LsT6rMxekYweQHJ5cVlYypbPGk zU8zrtcw+5JgTd2bKlBLTNP2lPTknhI3WiM8xpuGcMkM7p+VLa1XqVPiH/fdAgjSYGEGjAaTLFuRE CDsCWLVpzF7GCLNR8+dx7omx3UkXgKm6odkPbhGQQPqHJ0AlozVgNFL1ozQRA7NRw9fU=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kZxuP-0008OU-4c for control@debbugs.gnu.org; Tue, 03 Nov 2020 16:07:43 +0100 Date: Tue, 03 Nov 2020 16:07:39 +0100 Message-Id: <87a6vyv5qc.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #44411 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 44411 + patch quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 44411 + patch quit From unknown Tue Jun 17 01:50:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44411: 28.0.50; uudecode-decode-region-internal is broken Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 03 Nov 2020 15:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44411 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Kazuhiro Ito Cc: 44411@debbugs.gnu.org Received: via spool by 44411-submit@debbugs.gnu.org id=B44411.160441619328139 (code B ref 44411); Tue, 03 Nov 2020 15:10:02 +0000 Received: (at 44411) by debbugs.gnu.org; 3 Nov 2020 15:09:53 +0000 Received: from localhost ([127.0.0.1]:46043 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZxwX-0007Jn-Ex for submit@debbugs.gnu.org; Tue, 03 Nov 2020 10:09:53 -0500 Received: from quimby.gnus.org ([95.216.78.240]:60478) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZxwV-0007JZ-Cx for 44411@debbugs.gnu.org; Tue, 03 Nov 2020 10:09:51 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=uY0Cr+cRGi7sGRpaLg9xGY6MRaaYgJwihs7eiesjspo=; b=UAnXGE4M7DNN3eK4YcLq8pDOhR eC6SzFd/9WFsPyx0HJJm4j2OFbV72UFWkMLe0qsK6et2KAHazvze0BRv2q0Enck13DRRF50nHtMDh E5GQxWrmB+vfftq1D54xDHlPj/1G6q/bsjVtU86rfBsNL0r19vcf7nBpNP7uXRVBVwik=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kZxwL-0008SM-IH; Tue, 03 Nov 2020 16:09:44 +0100 From: Lars Ingebrigtsen References: <86y2ji6e0y.wl--xmue@d1.dion.ne.jp> X-Now-Playing: New Order's _Power, Corruption & Lies (2)_: "Ecstacy (Writing Session Recording)" Date: Tue, 03 Nov 2020 16:09:40 +0100 In-Reply-To: <86y2ji6e0y.wl--xmue@d1.dion.ne.jp> (Kazuhiro Ito's message of "Tue, 03 Nov 2020 17:27:41 +0900") Message-ID: <875z6mv5mz.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Kazuhiro Ito writes: > The function makes string from uuencoded text by passing unsigned char > vlue (0-255) to char-to-string function, which makes multibyte-string. > After that, string is decoded as binary. But eight-b [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Kazuhiro Ito writes: > The function makes string from uuencoded text by passing unsigned char > vlue (0-255) to char-to-string function, which makes multibyte-string. > After that, string is decoded as binary. But eight-bit characters are > never made in that way. > > (let ((ch #xc8)) > (decode-coding-string (char-to-string ch) 'binary)) > > -> "8" > > Additionally, concat and char-to-string functions are called so > frequently that deocder is very slow for large data. > > Please see the below patch. Thanks; looks good to me. This patch is slightly too large to apply without having an FSF copyright on file, and I don't see that in the assignment file for you. Would you be willing to sign such paperwork so that we can get the patch applied? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Tue Jun 17 01:50:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44411: 28.0.50; uudecode-decode-region-internal is broken Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 03 Nov 2020 15:37:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44411 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Kazuhiro Ito Cc: 44411@debbugs.gnu.org Received: via spool by 44411-submit@debbugs.gnu.org id=B44411.16044178056422 (code B ref 44411); Tue, 03 Nov 2020 15:37:01 +0000 Received: (at 44411) by debbugs.gnu.org; 3 Nov 2020 15:36:45 +0000 Received: from localhost ([127.0.0.1]:46089 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZyMX-0001fV-1k for submit@debbugs.gnu.org; Tue, 03 Nov 2020 10:36:45 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52670) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZyMV-0001fH-Jz for 44411@debbugs.gnu.org; Tue, 03 Nov 2020 10:36:43 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45607) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kZyMO-0002W2-L6; Tue, 03 Nov 2020 10:36:36 -0500 Received: from [176.228.60.248] (port=2564 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kZyMN-0006bg-Ni; Tue, 03 Nov 2020 10:36:36 -0500 Date: Tue, 03 Nov 2020 17:36:28 +0200 Message-Id: <83d00ucv0j.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <86y2ji6e0y.wl--xmue@d1.dion.ne.jp> (message from Kazuhiro Ito on Tue, 03 Nov 2020 17:27:41 +0900) References: <86y2ji6e0y.wl--xmue@d1.dion.ne.jp> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Tue, 03 Nov 2020 17:27:41 +0900 > From: Kazuhiro Ito > > When I call uudecode-decode-region-internal in multibyte buffer, it > fails to decode eight-bit characters. What do you mean by "decode eight-bit characters"? There's no such thing in the "real world", it is entirely an Emacs invention. How could such "characters" appear in uuencoded email message? Can you describe the real-life use case where this happened? > Additionally, concat and char-to-string functions are called so > frequently that deocder is very slow for large data. Please show only the changes to fix what you think is a bug. let's leave the optimization alone for a moment, so that it doesn't muddy the waters. Thanks. From unknown Tue Jun 17 01:50:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44411: 28.0.50; uudecode-decode-region-internal is broken Resent-From: Kazuhiro Ito Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Nov 2020 08:28:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44411 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 44411@debbugs.gnu.org Received: via spool by 44411-submit@debbugs.gnu.org id=B44411.160447842323813 (code B ref 44411); Wed, 04 Nov 2020 08:28:01 +0000 Received: (at 44411) by debbugs.gnu.org; 4 Nov 2020 08:27:03 +0000 Received: from localhost ([127.0.0.1]:47329 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kaE8E-0006C1-PZ for submit@debbugs.gnu.org; Wed, 04 Nov 2020 03:27:03 -0500 Received: from snd00005.auone-net.jp ([111.86.247.5]:24289 helo=dmta0002.auone-net.jp) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kaE8B-0006BV-N9 for 44411@debbugs.gnu.org; Wed, 04 Nov 2020 03:27:01 -0500 Received: from kzhr.d1.dion.ne.jp by dmta0002.auone-net.jp with ESMTP id <20201104082656798.SHW.69332.kzhr.d1.dion.ne.jp@dmta0002.auone-net.jp>; Wed, 4 Nov 2020 17:26:56 +0900 Date: Wed, 04 Nov 2020 17:26:56 +0900 Message-ID: <86wnz14je7.wl--xmue@d1.dion.ne.jp> From: Kazuhiro Ito In-Reply-To: <83d00ucv0j.fsf@gnu.org> References: <86y2ji6e0y.wl--xmue@d1.dion.ne.jp> <83d00ucv0j.fsf@gnu.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?Q?Goj=C5=8D?=) APEL-LB/10.8 Emacs/28.0.50 (x86_64-w64-mingw32) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > > When I call uudecode-decode-region-internal in multibyte buffer, it > > fails to decode eight-bit characters. > > What do you mean by "decode eight-bit characters"? I mean "decode uuencoded raw bytes 128-255 as eight-bit characters". > How could such "characters" appear in uuencoded email message? I did not said anything about uuencoded email message. What do you mean? > Can you describe the real-life use case where this happened? 1. Yank below uuencoded string into multibyte buffer. begin 644 c8c8c8c8.bin $R,C(R```@ `` end size 4 2. C-SPC at the beginning of uuencoded text and move point to the end of uuencoded text. 3. M-x uudecode-decode-region-internal 4. decoded result is broken. Original data is 4bytes of 0xc8, but inserted text is "8888". uudecode-decode-region-external returns expected result. > Please show only the changes to fix what you think is a bug. Here is. diff --git a/lisp/mail/uudecode.el b/lisp/mail/uudecode.el index bcbd571b53..81a0a8ae0d 100644 --- a/lisp/mail/uudecode.el +++ b/lisp/mail/uudecode.el @@ -151,9 +151,9 @@ uudecode-decode-region-internal (cond ((= counter 4) (setq result (cons (concat - (char-to-string (ash bits -16)) - (char-to-string (logand (ash bits -8) 255)) - (char-to-string (logand bits 255))) + (unibyte-string (ash bits -16)) + (unibyte-string (logand (ash bits -8) 255)) + (unibyte-string (logand bits 255))) result)) (setq bits 0 counter 0)) (t (setq bits (ash bits 6))))))) @@ -168,12 +168,12 @@ uudecode-decode-region-internal ((= counter 3) (setq result (cons (concat - (char-to-string (logand (ash bits -16) 255)) - (char-to-string (logand (ash bits -8) 255))) + (unibyte-string (logand (ash bits -16) 255)) + (unibyte-string (logand (ash bits -8) 255))) result))) ((= counter 2) (setq result (cons - (char-to-string (logand (ash bits -10) 255)) + (unibyte-string (logand (ash bits -10) 255)) result)))) (skip-chars-forward non-data-chars end)) (if file-name @@ -184,7 +184,7 @@ uudecode-decode-region-internal (goto-char start) (if enable-multibyte-characters (dolist (x (nreverse result)) - (insert (decode-coding-string x 'binary))) + (insert x)) (insert (apply #'concat (nreverse result)))) (delete-region (point) end)))))) -- Kazuhiro Ito From unknown Tue Jun 17 01:50:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44411: 28.0.50; uudecode-decode-region-internal is broken Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 04 Nov 2020 15:28:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44411 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Kazuhiro Ito Cc: 44411@debbugs.gnu.org Received: via spool by 44411-submit@debbugs.gnu.org id=B44411.160450362812096 (code B ref 44411); Wed, 04 Nov 2020 15:28:02 +0000 Received: (at 44411) by debbugs.gnu.org; 4 Nov 2020 15:27:08 +0000 Received: from localhost ([127.0.0.1]:50282 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kaKgm-000392-2m for submit@debbugs.gnu.org; Wed, 04 Nov 2020 10:27:08 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33508) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kaKgk-00038l-V3 for 44411@debbugs.gnu.org; Wed, 04 Nov 2020 10:27:07 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41394) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kaKge-0000d7-Ld; Wed, 04 Nov 2020 10:27:00 -0500 Received: from [176.228.60.248] (port=3283 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kaKga-0000m2-N5; Wed, 04 Nov 2020 10:26:58 -0500 Date: Wed, 04 Nov 2020 17:26:52 +0200 Message-Id: <83o8kdb0sj.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <86wnz14je7.wl--xmue@d1.dion.ne.jp> (message from Kazuhiro Ito on Wed, 04 Nov 2020 17:26:56 +0900) References: <86y2ji6e0y.wl--xmue@d1.dion.ne.jp> <83d00ucv0j.fsf@gnu.org> <86wnz14je7.wl--xmue@d1.dion.ne.jp> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Wed, 04 Nov 2020 17:26:56 +0900 > From: Kazuhiro Ito > Cc: 44411@debbugs.gnu.org > > > What do you mean by "decode eight-bit characters"? > > I mean "decode uuencoded raw bytes 128-255 as eight-bit characters". > > > How could such "characters" appear in uuencoded email message? > > I did not said anything about uuencoded email message. What do you > mean? Sorry, it looks like I misunderstood the use case. Ignore that question. > 1. Yank below uuencoded string into multibyte buffer. > > begin 644 c8c8c8c8.bin > $R,C(R```@ > `` > end > size 4 > > 2. C-SPC at the beginning of uuencoded text and move point to the end > of uuencoded text. > > 3. M-x uudecode-decode-region-internal > > 4. decoded result is broken. Original data is 4bytes of 0xc8, but > inserted text is "8888". uudecode-decode-region-external returns > expected result. OK, I see the problem now: it's the call to decode-coding-string, which replaced string-as-unibyte of yore. > > Please show only the changes to fix what you think is a bug. > > Here is. OK, I agree also to your other optimizations, but can we please go a step further and avoid consing a string here? 'insert' is perfectly capable of inserting characters, not only strings. So in the unibyte-buffer case, just something like (apply #'insert (nreverse result)) with 'result' being a list of bytes, will produce what you want. And in the multibyte-buffer case you just need to convert each byte to its Unicode-compatible codepoint, by using (decode-char 'eight-bit CH) probably in 'mapcar' or somesuch, and then call 'insert'. Can you augment your patch along these lines, please? Thanks. From unknown Tue Jun 17 01:50:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44411: 28.0.50; uudecode-decode-region-internal is broken Resent-From: Kazuhiro Ito Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Nov 2020 10:49:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44411 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 44411@debbugs.gnu.org Received: via spool by 44411-submit@debbugs.gnu.org id=B44411.16045732973005 (code B ref 44411); Thu, 05 Nov 2020 10:49:01 +0000 Received: (at 44411) by debbugs.gnu.org; 5 Nov 2020 10:48:17 +0000 Received: from localhost ([127.0.0.1]:51811 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kacoS-0000mP-RD for submit@debbugs.gnu.org; Thu, 05 Nov 2020 05:48:17 -0500 Received: from snd20014.auone-net.jp ([27.86.5.238]:16928 helo=dmta0004.auone-net.jp) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kacoP-0000mD-3F for 44411@debbugs.gnu.org; Thu, 05 Nov 2020 05:48:15 -0500 Received: from kzhr.d1.dion.ne.jp by dmta0004.auone-net.jp with ESMTP id <20201105104810481.BPCM.95516.kzhr.d1.dion.ne.jp@dmta0004.auone-net.jp>; Thu, 5 Nov 2020 19:48:10 +0900 Date: Thu, 05 Nov 2020 19:48:08 +0900 Message-ID: <86mtzw84gn.wl--xmue@d1.dion.ne.jp> From: Kazuhiro Ito In-Reply-To: <83o8kdb0sj.fsf@gnu.org> References: <86y2ji6e0y.wl--xmue@d1.dion.ne.jp> <83d00ucv0j.fsf@gnu.org> <86wnz14je7.wl--xmue@d1.dion.ne.jp> <83o8kdb0sj.fsf@gnu.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?Q?Goj=C5=8D?=) APEL-LB/10.8 Emacs/28.0.50 (x86_64-w64-mingw32) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > OK, I agree also to your other optimizations, but can we please go a > step further and avoid consing a string here? 'insert' is perfectly > capable of inserting characters, not only strings. So in the > unibyte-buffer case, just something like > > (apply #'insert (nreverse result)) > > with 'result' being a list of bytes, will produce what you want. And > in the multibyte-buffer case you just need to convert each byte to its > Unicode-compatible codepoint, by using > > (decode-char 'eight-bit CH) > > probably in 'mapcar' or somesuch, and then call 'insert'. > > Can you augment your patch along these lines, please? Here is a revised one. diff --git a/lisp/mail/uudecode.el b/lisp/mail/uudecode.el index bcbd571b53..0dce9b7b72 100644 --- a/lisp/mail/uudecode.el +++ b/lisp/mail/uudecode.el @@ -149,12 +149,10 @@ uudecode-decode-region-internal (setq counter (1+ counter) inputpos (1+ inputpos)) (cond ((= counter 4) - (setq result (cons - (concat - (char-to-string (ash bits -16)) - (char-to-string (logand (ash bits -8) 255)) - (char-to-string (logand bits 255))) - result)) + (setq result (cons (logand bits 255) + (cons (logand (ash bits -8) 255) + (cons (ash bits -16) + result)))) (setq bits 0 counter 0)) (t (setq bits (ash bits 6))))))) (cond @@ -166,26 +164,26 @@ uudecode-decode-region-internal ;;(error "uucode ends unexpectedly") (setq done t)) ((= counter 3) - (setq result (cons - (concat - (char-to-string (logand (ash bits -16) 255)) - (char-to-string (logand (ash bits -8) 255))) - result))) + (setq result (cons (logand (ash bits -8) 255) + (cons (logand (ash bits -16) 255) + result)))) ((= counter 2) - (setq result (cons - (char-to-string (logand (ash bits -10) 255)) - result)))) + (setq result (cons (logand (ash bits -10) 255) + result)))) (skip-chars-forward non-data-chars end)) (if file-name (with-temp-file file-name (set-buffer-multibyte nil) - (insert (apply #'concat (nreverse result)))) + (apply #'insert (nreverse result))) (or (markerp end) (setq end (set-marker (make-marker) end))) (goto-char start) - (if enable-multibyte-characters - (dolist (x (nreverse result)) - (insert (decode-coding-string x 'binary))) - (insert (apply #'concat (nreverse result)))) + (apply #'insert + (nreverse + (if enable-multibyte-characters + (mapcar (lambda (ch) + (or (decode-char 'eight-bit ch) ch)) + result) + result))) (delete-region (point) end)))))) ;;;###autoload -- Kazuhiro Ito From unknown Tue Jun 17 01:50:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44411: 28.0.50; uudecode-decode-region-internal is broken Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 05 Nov 2020 13:49:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44411 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Kazuhiro Ito Cc: 44411@debbugs.gnu.org Received: via spool by 44411-submit@debbugs.gnu.org id=B44411.160458410112733 (code B ref 44411); Thu, 05 Nov 2020 13:49:02 +0000 Received: (at 44411) by debbugs.gnu.org; 5 Nov 2020 13:48:21 +0000 Received: from localhost ([127.0.0.1]:52020 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kafcj-0003JD-0X for submit@debbugs.gnu.org; Thu, 05 Nov 2020 08:48:21 -0500 Received: from eggs.gnu.org ([209.51.188.92]:59982) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kafch-0003In-MF for 44411@debbugs.gnu.org; Thu, 05 Nov 2020 08:48:20 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56895) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kafca-0006IR-QL; Thu, 05 Nov 2020 08:48:12 -0500 Received: from [176.228.60.248] (port=2501 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kafcZ-0005Qu-4H; Thu, 05 Nov 2020 08:48:12 -0500 Date: Thu, 05 Nov 2020 15:48:09 +0200 Message-Id: <835z6jc3ty.fsf@gnu.org> From: Eli Zaretskii In-Reply-To: <86mtzw84gn.wl--xmue@d1.dion.ne.jp> (message from Kazuhiro Ito on Thu, 05 Nov 2020 19:48:08 +0900) References: <86y2ji6e0y.wl--xmue@d1.dion.ne.jp> <83d00ucv0j.fsf@gnu.org> <86wnz14je7.wl--xmue@d1.dion.ne.jp> <83o8kdb0sj.fsf@gnu.org> <86mtzw84gn.wl--xmue@d1.dion.ne.jp> X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 05 Nov 2020 19:48:08 +0900 > From: Kazuhiro Ito > Cc: 44411@debbugs.gnu.org > > Here is a revised one. Thanks, this LGTM. I will wait for a couple of days, and push then in your name if no new comments are voiced. From unknown Tue Jun 17 01:50:12 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Kazuhiro Ito Subject: bug#44411: closed (Re: bug#44411: 28.0.50; uudecode-decode-region-internal is broken) Message-ID: References: <83imah7ba5.fsf@gnu.org> <86y2ji6e0y.wl--xmue@d1.dion.ne.jp> X-Gnu-PR-Message: they-closed 44411 X-Gnu-PR-Package: emacs X-Gnu-PR-Keywords: patch Reply-To: 44411@debbugs.gnu.org Date: Sat, 07 Nov 2020 09:44:02 +0000 Content-Type: multipart/mixed; boundary="----------=_1604742242-25161-1" This is a multi-part message in MIME format... ------------=_1604742242-25161-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #44411: 28.0.50; uudecode-decode-region-internal is broken which was filed against the emacs package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 44411@debbugs.gnu.org. --=20 44411: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D44411 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1604742242-25161-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 44411-done) by debbugs.gnu.org; 7 Nov 2020 09:43:07 +0000 Received: from localhost ([127.0.0.1]:57966 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kbKkV-0006Wb-E9 for submit@debbugs.gnu.org; Sat, 07 Nov 2020 04:43:07 -0500 Received: from eggs.gnu.org ([209.51.188.92]:52782) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kbKkT-0006W7-Br for 44411-done@debbugs.gnu.org; Sat, 07 Nov 2020 04:43:05 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55874) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kbKkM-0004V7-Ew; Sat, 07 Nov 2020 04:42:58 -0500 Received: from [176.228.60.248] (port=2509 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kbKkL-0002D3-Tf; Sat, 07 Nov 2020 04:42:58 -0500 Date: Sat, 07 Nov 2020 11:42:58 +0200 Message-Id: <83imah7ba5.fsf@gnu.org> From: Eli Zaretskii To: Kazuhiro Ito In-Reply-To: <86mtzw84gn.wl--xmue@d1.dion.ne.jp> (message from Kazuhiro Ito on Thu, 05 Nov 2020 19:48:08 +0900) Subject: Re: bug#44411: 28.0.50; uudecode-decode-region-internal is broken References: <86y2ji6e0y.wl--xmue@d1.dion.ne.jp> <83d00ucv0j.fsf@gnu.org> <86wnz14je7.wl--xmue@d1.dion.ne.jp> <83o8kdb0sj.fsf@gnu.org> <86mtzw84gn.wl--xmue@d1.dion.ne.jp> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44411-done Cc: 44411-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Thu, 05 Nov 2020 19:48:08 +0900 > From: Kazuhiro Ito > Cc: 44411@debbugs.gnu.org > > > Can you augment your patch along these lines, please? > > Here is a revised one. Thanks, pushed to the emacs-27 branch. Since with this patch you have exhausted the amount of changes we can accept from you without copyright assignment, would you like to start the assignment process at this time? ------------=_1604742242-25161-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 3 Nov 2020 08:27:58 +0000 Received: from localhost ([127.0.0.1]:43277 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZrfZ-0006yX-S2 for submit@debbugs.gnu.org; Tue, 03 Nov 2020 03:27:58 -0500 Received: from lists.gnu.org ([209.51.188.17]:33894) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZrfY-0006yQ-LC for submit@debbugs.gnu.org; Tue, 03 Nov 2020 03:27:56 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47798) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZrfY-0008F4-DX for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2020 03:27:56 -0500 Received: from snd00004.auone-net.jp ([111.86.247.4]:53920 helo=dmta0004.auone-net.jp) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kZrfU-0002XV-Lw for bug-gnu-emacs@gnu.org; Tue, 03 Nov 2020 03:27:55 -0500 Received: from kzhr.d1.dion.ne.jp by dmta0004.auone-net.jp with ESMTP id <20201103082743382.ZODW.95516.kzhr.d1.dion.ne.jp@dmta0004.auone-net.jp>; Tue, 3 Nov 2020 17:27:43 +0900 Date: Tue, 03 Nov 2020 17:27:41 +0900 Message-ID: <86y2ji6e0y.wl--xmue@d1.dion.ne.jp> From: Kazuhiro Ito To: bug-gnu-emacs@gnu.org Subject: 28.0.50; uudecode-decode-region-internal is broken X-Hashcash: 1:20:201103:bug-gnu-emacs@gnu.org::Q100fm868IIO3wC0:00000000000000000000000000000000000000007tF4 User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?ISO-8859-4?Q?Goj=F2?=) APEL-LB/10.8 Emacs/28.0.50 (x86_64-w64-mingw32) MULE/6.0 (HANACHIRUSATO) (with unibyte mode) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Received-SPF: pass client-ip=111.86.247.4; envelope-from=kzhr@d1.dion.ne.jp; helo=dmta0004.auone-net.jp X-detected-operating-system: by eggs.gnu.org: First seen = 2020/11/03 03:27:43 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) When I call uudecode-decode-region-internal in multibyte buffer, it fails to decode eight-bit characters. The function makes string from uuencoded text by passing unsigned char vlue (0-255) to char-to-string function, which makes multibyte-string. After that, string is decoded as binary. But eight-bit characters are never made in that way. (let ((ch #xc8)) (decode-coding-string (char-to-string ch) 'binary)) -> "8" Additionally, concat and char-to-string functions are called so frequently that deocder is very slow for large data. Please see the below patch. diff --git a/lisp/mail/uudecode.el b/lisp/mail/uudecode.el index bcbd571b53..f9254aee75 100644 --- a/lisp/mail/uudecode.el +++ b/lisp/mail/uudecode.el @@ -149,12 +149,10 @@ uudecode-decode-region-internal (setq counter (1+ counter) inputpos (1+ inputpos)) (cond ((= counter 4) - (setq result (cons - (concat - (char-to-string (ash bits -16)) - (char-to-string (logand (ash bits -8) 255)) - (char-to-string (logand bits 255))) - result)) + (setq result (cons (logand bits 255) + (cons (logand (ash bits -8) 255) + (cons (ash bits -16) + result)))) (setq bits 0 counter 0)) (t (setq bits (ash bits 6))))))) (cond @@ -166,26 +164,21 @@ uudecode-decode-region-internal ;;(error "uucode ends unexpectedly") (setq done t)) ((= counter 3) - (setq result (cons - (concat - (char-to-string (logand (ash bits -16) 255)) - (char-to-string (logand (ash bits -8) 255))) - result))) + (setq result (cons (logand (ash bits -8) 255) + (cons (logand (ash bits -16) 255) + result)))) ((= counter 2) - (setq result (cons - (char-to-string (logand (ash bits -10) 255)) - result)))) + (setq result (cons (logand (ash bits -10) 255) + result)))) (skip-chars-forward non-data-chars end)) + (setq result (apply #'unibyte-string (nreverse result))) (if file-name (with-temp-file file-name (set-buffer-multibyte nil) - (insert (apply #'concat (nreverse result)))) + (insert result)) (or (markerp end) (setq end (set-marker (make-marker) end))) (goto-char start) - (if enable-multibyte-characters - (dolist (x (nreverse result)) - (insert (decode-coding-string x 'binary))) - (insert (apply #'concat (nreverse result)))) + (insert result) (delete-region (point) end)))))) ;;;###autoload -- Kazuhiro Ito ------------=_1604742242-25161-1-- From unknown Tue Jun 17 01:50:12 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44411: 28.0.50; uudecode-decode-region-internal is broken Resent-From: Kazuhiro Ito Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 09 Nov 2020 15:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44411 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Eli Zaretskii Cc: 44411@debbugs.gnu.org Received: via spool by 44411-submit@debbugs.gnu.org id=B44411.160493682820580 (code B ref 44411); Mon, 09 Nov 2020 15:48:02 +0000 Received: (at 44411) by debbugs.gnu.org; 9 Nov 2020 15:47:08 +0000 Received: from localhost ([127.0.0.1]:35242 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kc9Nr-0005Lf-Ox for submit@debbugs.gnu.org; Mon, 09 Nov 2020 10:47:07 -0500 Received: from snd20006.auone-net.jp ([27.86.5.230]:64480 helo=dmta0008.auone-net.jp) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kc9No-0005Gd-8o for 44411@debbugs.gnu.org; Mon, 09 Nov 2020 10:47:06 -0500 Received: from kzhr.d1.dion.ne.jp by dmta0008.auone-net.jp with ESMTP id <20201109154701219.FGYH.12092.kzhr.d1.dion.ne.jp@dmta0008.auone-net.jp>; Tue, 10 Nov 2020 00:47:01 +0900 Date: Tue, 10 Nov 2020 00:47:01 +0900 Message-ID: <86imaeleh6.wl--xmue@d1.dion.ne.jp> From: Kazuhiro Ito In-Reply-To: <83imah7ba5.fsf@gnu.org> References: <86y2ji6e0y.wl--xmue@d1.dion.ne.jp> <83d00ucv0j.fsf@gnu.org> <86wnz14je7.wl--xmue@d1.dion.ne.jp> <83o8kdb0sj.fsf@gnu.org> <86mtzw84gn.wl--xmue@d1.dion.ne.jp> <83imah7ba5.fsf@gnu.org> User-Agent: Wanderlust/2.15.9 (Almost Unreal) SEMI-EPG/1.14.7 (Harue) FLIM-LB/1.14.9 (=?UTF-8?Q?Goj=C5=8D?=) APEL-LB/10.8 Emacs/28.0.50 (x86_64-w64-mingw32) MULE/6.0 (HANACHIRUSATO) MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) > > > Can you augment your patch along these lines, please? > > > > Here is a revised one. > > Thanks, pushed to the emacs-27 branch. Thank you. > Since with this patch you have exhausted the amount of changes we can > accept from you without copyright assignment, would you like to start > the assignment process at this time? I've stared the process and requested the assignment form. -- Kazuhiro Ito