From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 31 12:47:43 2020 Received: (at submit) by debbugs.gnu.org; 31 Oct 2020 16:47:43 +0000 Received: from localhost ([127.0.0.1]:34418 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYu2Z-0006RS-0m for submit@debbugs.gnu.org; Sat, 31 Oct 2020 12:47:43 -0400 Received: from lists.gnu.org ([209.51.188.17]:35454) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYu2X-0006RL-Ky for submit@debbugs.gnu.org; Sat, 31 Oct 2020 12:47:41 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51198) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYu2X-0003si-B6 for bug-guix@gnu.org; Sat, 31 Oct 2020 12:47:41 -0400 Received: from mail-pj1-x1035.google.com ([2607:f8b0:4864:20::1035]:53778) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kYu2V-00007W-OP for bug-guix@gnu.org; Sat, 31 Oct 2020 12:47:41 -0400 Received: by mail-pj1-x1035.google.com with SMTP id m17so955047pjz.3 for ; Sat, 31 Oct 2020 09:47:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=to:from:subject:message-id:date:user-agent:mime-version :content-language; bh=fUpgaZ2jQ/BBcjdMF3K2Y2aeodqOx/dSdjHHNNgUkbM=; b=rpZeI5WnuWzMH6oTzPDK9sfdy2rFtGhBD63gODO6laMBA/T/vbILtkir1O+g81SrYz ZUvtql7roLN7q2qS93hUtLMn6L1CvYxaP6l7okPlBl6f0PeN3aMt6k5x2uFp4Nl43edh 6uBQIIJlrbP6OwR1Z8l6Saue4LH9BeN3pfTEztQ5AxaIeHIZrmJXgV/I7OBKWm4rGZ4J D74BdvcKNDTNhmc05GU8nx94i9U3RRI35C+62p1UVUZk+4K9OeunqbDepW5UqaU0XSvE E3BphjNwuStZ5ts0aIUdArZ1527EgDi1Xw+j3ugt3NJZhIkgkB2La5v83O/dXEW43eoy wxjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:to:from:subject:message-id:date:user-agent :mime-version:content-language; bh=fUpgaZ2jQ/BBcjdMF3K2Y2aeodqOx/dSdjHHNNgUkbM=; b=NmNvsVYOe1v3yCYGgxeIV2jO8hnAYTw32lb9PQpvzxY80N38ZzEfpAwPBQ+FBrBCiX ZYSbkDI6BUl2Wp2cDrL+hTjCaPMykjnl6bxO9EFOPEYdc7dXlcIX3akGKExmObfUw1Dv hVt+WbNZijPMfR2kJb8YSuD4gYlseDtLG6RAU003TJ5zuipL/cu8zZiRScQCCGnrN66U Y1R9DzX2TM/ocpPAYGqEfrflprcmATBDBvSnLOPQ0zsot8KyNHXJe08J6kD3L9na/9Ss hPkCH+eGH4g6zvOWbC2Gwg/bRW0gGXwX+Mq67SOYeiy07M1VXRJMwMATn4EA+w1d1cX2 rztQ== X-Gm-Message-State: AOAM5310o/c3tffPWA25WhqMACSY8UweLDuTWJkm4F70f0bDAVk+mxej ou5Vze1k7Ggf153jFZKz+OCU+SQ0goj9hg== X-Google-Smtp-Source: ABdhPJx6p9Wkut85QyKEis0pOiadc7zMFEvcQI+2OktVYxX19paqC5WUauqzRY+C6svsp622D/HMRQ== X-Received: by 2002:a17:90b:4a10:: with SMTP id kk16mr9327614pjb.77.1604162857847; Sat, 31 Oct 2020 09:47:37 -0700 (PDT) Received: from [192.168.1.25] ([38.141.58.134]) by smtp.gmail.com with ESMTPSA id e5sm9346937pfl.216.2020.10.31.09.47.36 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 31 Oct 2020 09:47:36 -0700 (PDT) To: bug-guix@gnu.org From: Jesse Gibbons Subject: guix system disk-image -t raw fails with grub-efi-bootloader Message-ID: <1e589f3b-47f8-fd53-b750-d2beff8d91f5@gmail.com> Date: Sat, 31 Oct 2020 10:47:35 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Icedove/78.4.0 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="------------1EB564483C7B9A3A2B7477C6" Content-Language: en-US Received-SPF: pass client-ip=2607:f8b0:4864:20::1035; envelope-from=jgibbons2357@gmail.com; helo=mail-pj1-x1035.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: 15 X-Spam_score: 1.5 X-Spam_bar: + X-Spam_report: (1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_ENVFROM_END_DIGIT=0.25, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_NONE=-0.0001, RCVD_IN_SBL_CSS=3.335, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 4.5 (++++) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: To replicate: cd to a git checkout of the source code, gnu/system/examples The hash for my current checkout is d7e033b9a153a9e60f52ff64f4eb355c1c3d0a6e which is also the hash for my current version of [...] Content analysis details: (4.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [38.141.58.134 listed in zen.spamhaus.org] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (jgibbons2357[at]gmail.com) 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (jgibbons2357[at]gmail.com) 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [209.51.188.17 listed in wl.mailspike.net] -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders 2.0 SPOOFED_FREEMAIL No description available. X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: 1.5 (+) X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see the administrator of that system for details. Content preview: To replicate: cd to a git checkout of the source code, gnu/system/examples The hash for my current checkout is d7e033b9a153a9e60f52ff64f4eb355c1c3d0a6e which is also the hash for my current version of [...] Content analysis details: (1.5 points, 10.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- 0.0 RCVD_IN_MSPIKE_H4 RBL: Very Good reputation (+4) [209.51.188.17 listed in wl.mailspike.net] -2.3 RCVD_IN_DNSWL_MED RBL: Sender listed at https://www.dnswl.org/, medium trust [209.51.188.17 listed in list.dnswl.org] 3.6 RCVD_IN_SBL_CSS RBL: Received via a relay in Spamhaus SBL-CSS [38.141.58.134 listed in zen.spamhaus.org] 1.0 SPF_SOFTFAIL SPF: sender does not match SPF record (softfail) 0.0 SPF_HELO_NONE SPF: HELO does not publish an SPF Record 0.2 FREEMAIL_ENVFROM_END_DIGIT Envelope-from freemail username ends in digit (jgibbons2357[at]gmail.com) 0.0 FREEMAIL_FROM Sender email is commonly abused enduser mail provider (jgibbons2357[at]gmail.com) 0.0 RCVD_IN_MSPIKE_WL Mailspike good senders -1.0 MAILING_LIST_MULTI Multiple indicators imply a widely-seen list manager This is a multi-part message in MIME format. --------------1EB564483C7B9A3A2B7477C6 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit To replicate: cd to a git checkout of the source code, gnu/system/examples The hash for my current checkout is d7e033b9a153a9e60f52ff64f4eb355c1c3d0a6e which is also the hash for my current version of guix. guix system disk-image -t raw lightweight-desktop.tmpl lightweight-desktop.tmpl defines an operating-system that uses grub-efi-bootloader, and is embedded in the info pages as an example operating system. Since it is lightweight, it doesn't take as long to build as desktop.tmpl. Expected results: guix builds the raw image just fine, and that image can be copied to an SD card and run on a computer with an efi bootloader, just like the counterpart with grub-bootloader. There is nothing in the documentation suggesting that this should not work by design. Actual results: guix fails, see attached log. -Jesse --------------1EB564483C7B9A3A2B7477C6 Content-Type: application/octet-stream; name="1zv1w0vbd4yvnmnnyn06ajkllx21gc-partition.img.drv.bz2" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="1zv1w0vbd4yvnmnnyn06ajkllx21gc-partition.img.drv.bz2" QlpoOTFBWSZTWWywZcgAAhx/0X/////////1MmjUiv////BAAAEAEABgCd8AfAEEABAdIsAD u6oIQakgAAAAAAAAAAAA0ADQAAElECNBiNDKehqeQUxNAABoAAANGjTQ02pk0OBoDQaNAyaA A0ABiaGmgaaAGjRoAGjQ4GgNBo0DJoADQAGJoaaBpoAaNGgAaNBNVVP9VU/9VKA0aNNAZDQA 0Bv/1VUMI0ADIAAA//VVAAClKKaYSn6Iaj1NTwnqmIyaPUyDQZNNNAAB6mgDNHqE9E9OJ6Lx mRNImRMEyJlRgmRMqMiZEwTImRMSYJkTBME+v7Hkae4bImmmvb1tc5RNvi2iaxMEwT9+3ISm ZEUzAlNYmomCZExJgmCYkwTBMEwTBMEyJgmRMiYJkTBMEyJgmCZEwTBMidSpQaCaCZEwTBMS YJgmVUQ48+PZyefGk2OE8eOSanJPHjhNjhPY2x4pNjxE9pHJNjkmpyjyI5Jsck2OE2OSbHKN jkmxyTU4TY5JscJscJsck2OSbHCanCbHJNjhNjkmxyT4cco90pbHik2PET36ck2OSbHKNjkm xyTY4TY5JqcJscJsck2OSeRHCeEeMTwqX4iySxL0hFOOJZivXVkvZlksVignu4l7mUvwZ+L3 fapKDUr76sS2SylksieP2bSo/5r/Jfb/PsE/HrpSL8nve9+X3/mO509rekXRhKf3VKDtnO1k iHVLKjzJYJktne+DjrvtOjl0piYmRiYmRiZGRiYmRkYmRiZGRiYmJiYmRiZGRkYmRiYmRiZG RiYmRiYmJkZGRiYmRiYmRiZGRiYmRkZGRiYmRiYmJiZGRiYmRkYmRiZGRiYmRiYmRiZGJkYm RiYmRiZGRiYmRiYmRkZGRiYmRiZGJiYmRiYmRkZGRiYmRiYmRiZGRiYmJkYmRiZGRiYmRiYm RiZHhHgmRiYmRiZGJiYmYmJ4eHjX2MlFNmx8emzTd0vNzSo5omCcj5zWU1lVJ6CsksS0aKqU 0ViWUsClMEyqMVBMSZKpMqqo0PzWiJNNDKTQTEmCYJkTBN2gn8dYmlUwl+zpuG/TZE5rsOQ4 7hNgmRMEwTImCZE4+gdDkibLr77y7P+7uxrPS5hM42spiyW2jB1AixwlkBDgCHaKdWguVTs/ DBq03FY5961ubil9rm8Jz9b1Ok29wTj5dNUthEp61w8aRTxebv3JeVwa9d0c/Lu3kSmnB2Of VCYxCvmEbhEIEh9tG3g4b70pNYMPHxT1VaYXSCIZb0SO3MQSPPZYzS/Jn04ro1+MSQkAPmEG hE2CPVAZb+CezBOX+TNyGQZd2+JuYMme5tOZhXtti4uuamKhh1BJKDn9j5dOz49pSg99UoOZ Xtq+srwR2Ox2PfJ9WPUjsdjse9j1E7Ht47HY7HY9zHU7HY7HY7HY6nY7HY7HY7HY6nzI7HY9 aOx2Op2Ox2PzR5ql+WPvJqamxqampqbGpqampsampqeSmxqampqbGpqampsampqamxqampqb GpqampsampqamxqeaK2NTY1NTY1NTY1NTY1NTY1NTY8lNjU1NjU1NjU1NjU1NjU1NjU2NTU2 NTU2NTU2NTU2NTSAjgEBBAAKGzD36DeL5ZeQIOU8hhzga1AGYgKwMKK961iF6HeukF9RYHLS /ogQkfRDm7v7xvuJ3UHA0msK9Ztgkp1O5u5DvbFua8u3kNLCop2lSgcVGzeDfeBJAkcjkxVS HjKgh9sbwDoRcBLTV8Dn6O+qUHDK8nd1fB4OvwlRTTqT0XnnNzeT4WbpbjKccpwoeuPbKGAk gSJhAhIrsOBFU5LUFEwJIEi6JISAL7+ux+1LoopwmtS20110yczCxFp0quwmUZCoLQx4q1xJ CQBos7UPHOxFnAXmhZ/jBoAkgCBgZWVOW8/NrrKbELRDHb8w+iEgaOjAnMQgQkOAkhIkfFiy k82aXBsrGpKDPWbWw29CJTp87t+m7O/u3NnenrdXd7nFEp1sXE8RUU5OG8qKbTwtZ5dvecub eNwPMVKDrcGndf7ug8/b4HncOcqKa7ESm5Z9LGjv9rbvOrN6pQaFRTOvPp5yeNw7W2KEiAK2 g7ZSySg5WYgeU8Q9liHoyXSZq5Yx9yoct43g2JayQQISLFWSN2KTHrcojlEa66M6KP+LuSKc KEg2WDLkAA== --------------1EB564483C7B9A3A2B7477C6-- From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 07 02:09:40 2020 Received: (at 44353) by debbugs.gnu.org; 7 Nov 2020 07:09:40 +0000 Received: from localhost ([127.0.0.1]:57842 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kbILz-0000n0-Tp for submit@debbugs.gnu.org; Sat, 07 Nov 2020 02:09:40 -0500 Received: from mail-qk1-f180.google.com ([209.85.222.180]:40511) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kbILx-0000ml-WA for 44353@debbugs.gnu.org; Sat, 07 Nov 2020 02:09:38 -0500 Received: by mail-qk1-f180.google.com with SMTP id y197so3292494qkb.7 for <44353@debbugs.gnu.org>; Fri, 06 Nov 2020 23:09:38 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=npzIU+klpXqY8oZf9eKb2xjRmDxApo/ZkFT004En1T4=; b=W0Y99sdezuaPRaLNNv6mT4jbSuqXYTol4LupEQsdzfz77elrpu31aVjoxdEGH67W32 r5+lpYobv/dlz2zzPzJO58W8Xp28m4ZJ/QWN1yMqjZgZ51ELMe7ZeCMycWHCcepmVe5D YZbMB+eUvoWHr1fUKF2YUKQcw81rL+QVOwNm5lFykrjxebRfUpnseq717MrVPdiSiqQd gxKYG5KxVTgFf5TO4f+zwsFs7u3em7wNfVAv+ui31EbyFn+yfwg83GTuQ7DMvWsDd+Pg Gm82fV/gQ8klQeaf52spjz8Nr21Gmh9lrl1Z0TipjNA77hl1LhkTdxnmmhC57gm4bVM4 fqdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=npzIU+klpXqY8oZf9eKb2xjRmDxApo/ZkFT004En1T4=; b=LaHw6TkgYg7XSIP/SkoypEealqeL4M+4ccabkkWiAzAuv6kmnRE3RLIWYKqSQ1cg8a UgO5UnD+3H4aOquUPLfyFe9a2ieB/vmuEY46bKW8Xu0xNwMVg8WsK3ym/r3ajgR/AvgN AFtauNPZjaD72NtxZCMjz0nSvTP5Us1DBOyTJpNmeZFck/895VLiwYO3USzuLR+FFdn+ sQ+ZrKBPAXWEc2974uygVsG5MdB6QKAFDxi9T6KAJKCKmxdIOQJXnwe0QTHDddkKHL9B 8lU8wbF9wRDpqnFFZeGT+yTLS8yZxXl6RQUPleGaMG5rbTTDL8V1f2rn0KfTDQ67fCnn i7pA== X-Gm-Message-State: AOAM531nQ4B7uvqu4ZUHwDSCFbkPx9IbM+hScIK3xno3JO9/nL3lFpS3 DqeeWtS4rV3RlVPMQGKQC3o= X-Google-Smtp-Source: ABdhPJw1uxN5FAn1/GYE+Dh+6JS/PCBgc8ZboqFwcoEORWrptucq6CZ2pXiDBGXoFNkdhtnbo7n4nA== X-Received: by 2002:a05:620a:230:: with SMTP id u16mr5140843qkm.212.1604732972521; Fri, 06 Nov 2020 23:09:32 -0800 (PST) Received: from hurd (dsl-236-123-209.b2b2c.ca. [207.236.123.209]) by smtp.gmail.com with ESMTPSA id a206sm2150828qkb.64.2020.11.06.23.09.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 23:09:31 -0800 (PST) From: Maxim Cournoyer To: Jesse Gibbons Subject: Re: bug#44353: guix system disk-image -t raw fails with grub-efi-bootloader References: <1e589f3b-47f8-fd53-b750-d2beff8d91f5@gmail.com> Date: Sat, 07 Nov 2020 02:09:30 -0500 In-Reply-To: <1e589f3b-47f8-fd53-b750-d2beff8d91f5@gmail.com> (Jesse Gibbons's message of "Sat, 31 Oct 2020 10:47:35 -0600") Message-ID: <87lffdtzh1.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44353 Cc: 44353@debbugs.gnu.org, Mathieu Othacehe X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Hello! Jesse Gibbons writes: > To replicate: > cd to a git checkout of the source code, gnu/system/examples > The hash for my current checkout is > d7e033b9a153a9e60f52ff64f4eb355c1c3d0a6e which is also the hash for my > current version of guix. > guix system disk-image -t raw lightweight-desktop.tmpl > > lightweight-desktop.tmpl defines an operating-system that uses > grub-efi-bootloader, and is embedded in the info pages as an example > operating system. Since it is lightweight, it doesn't take as long to > build as desktop.tmpl. > > Expected results: guix builds the raw image just fine, and that image > can be copied to an SD card and run on a computer with an efi > bootloader, just like the counterpart with grub-bootloader. There is > nothing in the documentation suggesting that this should not work by > design. > > Actual results: guix fails, see attached log. > > -Jesse Thank you for the report! I'm CC'ing Mathieu as he knows this part of the code much better than I do, having overhauled the generation of disk images recently! Below are two patches I made while investigating this. Mathieu, does that look like a proper fix? It allows images to be generated, but I'm unsure whether they'd be bootable (I couldn't successfully boot either EFI or MBR GRUB-based disk images in QEMU). Anyway, attached are the patches. Thank you! Maxim --=-=-= Content-Type: text/x-patch; charset=utf-8 Content-Disposition: attachment; filename=0001-build-image-Ensure-required-arguments-are-present.patch Content-Transfer-Encoding: quoted-printable >From 557a938633ed55c41aed8b41a0f93b6151f00943 Mon Sep 17 00:00:00 2001 From: Maxim Cournoyer Date: Fri, 6 Nov 2020 21:37:33 -0500 Subject: [PATCH 1/2] build: image: Ensure required arguments are present. * gnu/build/image.scm (initialize-root-partition): Validate arguments. [system-directory, references-graph]: Change from keyword to positional arguments. [doc]: Add space between sentences. * gnu/system/image.scm (system-iso9660-image): Adjust. --- gnu/build/image.scm | 17 ++++++++++++++++- 1 file changed, 16 insertions(+), 1 deletion(-) diff --git a/gnu/build/image.scm b/gnu/build/image.scm index 640a784204..053972166b 100644 --- a/gnu/build/image.scm +++ b/gnu/build/image.scm @@ -5,6 +5,7 @@ ;;; Copyright =C2=A9 2017 Marius Bakke ;;; Copyright =C2=A9 2020 Tobias Geerinckx-Rice ;;; Copyright =C2=A9 2020 Mathieu Othacehe +;;; Copyright =C2=A9 2020 Maxim Cournoyer ;;; ;;; This file is part of GNU Guix. ;;; @@ -179,7 +180,7 @@ to call-with-database." make-device-nodes (wal-mode? #t) #:allow-other-keys) - "Initialize the given ROOT directory. Use BOOTCFG and BOOTCFG-LOCATION to + "Initialize the given ROOT directory. Use BOOTCFG and BOOTCFG-LOCATION = to install the bootloader configuration. =20 If REGISTER-CLOSURES? is true, register REFERENCES-GRAPHS in the store. If @@ -187,6 +188,20 @@ DEDUPLICATE? is true, then also deduplicate files comm= on to CLOSURES and the rest of the store when registering the closures. SYSTEM-DIRECTORY is the = name of the directory of the 'system' derivation. Pass WAL-MODE? to register-closure." + + (define (validate-arguments) + (when bootcfg + (unless bootcfg-location + (error "Missing 'bootcfg-location' argument"))) + (when bootloader-installer + (unless bootloader-package + (error "Missing 'bootloader-package' argument"))) + (unless references-graphs + (error "Missing 'references-graphs' argument")) + (unless system-directory + (error "Missing 'system-directory' argument"))) + + (validate-arguments) (populate-root-file-system system-directory root) (populate-store references-graphs root) =20 --=20 2.28.0 --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0002-image-Only-attempt-bootloader-installation-when-supp.patch >From c642a6984d4961256f50ca5133d1eec5ca1af4e9 Mon Sep 17 00:00:00 2001 From: Maxim Cournoyer Date: Sat, 7 Nov 2020 00:20:49 -0500 Subject: [PATCH 2/2] image: Only attempt bootloader installation when supported. Fixes . The initialize-root-partition in (guix build image) attempts to install a bootloader when BOOTLOADER-INSTALLER is defined. Unfortunately, it relies on a special #f value for the second argument (device), which only the INSTALL-GRUB procedure from (gnu bootloader grub) supports. * gnu/system/image.scm (system-disk-image): Only pass the bootloader installer argument when the bootloader name is 'grub. Add comment. --- gnu/system/image.scm | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/gnu/system/image.scm b/gnu/system/image.scm index 4075a26552..d4932466e5 100644 --- a/gnu/system/image.scm +++ b/gnu/system/image.scm @@ -345,8 +345,16 @@ used in the image." #:grub-efi #+grub-efi #:bootloader-package #+(bootloader-package bootloader) + ;; Special case: most bootloaders can be copied + ;; directly at some fixed location on the image + ;; disk, but when installed to the master boot + ;; record (MBR), GRUB requires support files + ;; present under /boot/grub, which is handled by + ;; its 'installer' procedure. #:bootloader-installer - #+(bootloader-installer bootloader) + #+(if (eq? 'grub (bootloader-name bootloader)) + (bootloader-installer bootloader) + #f) #:bootcfg #$bootcfg #:bootcfg-location #$(bootloader-configuration-file bootloader)) -- 2.28.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 07 02:09:46 2020 Received: (at control) by debbugs.gnu.org; 7 Nov 2020 07:09:46 +0000 Received: from localhost ([127.0.0.1]:57845 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kbIM6-0000nJ-BN for submit@debbugs.gnu.org; Sat, 07 Nov 2020 02:09:46 -0500 Received: from mail-qk1-f175.google.com ([209.85.222.175]:37842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kbIM4-0000mu-0c for control@debbugs.gnu.org; Sat, 07 Nov 2020 02:09:44 -0500 Received: by mail-qk1-f175.google.com with SMTP id t191so2109992qka.4 for ; Fri, 06 Nov 2020 23:09:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:message-id:to:from:subject; bh=wQacqAtPRKJdaw302TKoV9MBR5mYyfdXVX38p0ceWuA=; b=jAVXNa1geFDc5fITulm+RomgWXqfhKG9tUQw6SI8v7ctXdc2zDlmNc65gSJ2xmHIVm 9gUe8wOZBjtCcVqTyaYncHEzRUmS/2wHc8EgRCo8fKPfNw+izY1H0kyCX5E8T2CSdopV BX7Rv9M0gV5HzbC2jEjS2Bwb5TbwXj6FsWv78leytYDg2fJWgx9txy3FvZSFf5rQiu3N XmnZWeNh9s0gqYhwgdtyrrs2T7X3HWbliQSpMd4Mk/tTyFiNrFJg4vHfLCFTzNj9QXTI rEBGwmOZcsRmqIbJ23/lRJPSH8lWTQqq5WvnlOVEd5IzGlQRxYFOPF4DLlvpaHPfak3H DJXQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:to:from:subject; bh=wQacqAtPRKJdaw302TKoV9MBR5mYyfdXVX38p0ceWuA=; b=Iotuce9FLjaGPkwAGSAEQl+KEkRPOeKzu/17tO8EoV+QodSeFPDlHSOwBqwGAsl+ig +Sjp65+V19MTTXGOTbk98BxUrqi0FEuGttH9/1hscBz9bNkoMiwrEKJhcUHRXkPOZbyi j3GgL0MRk9Y5aGiWLFHJb7evXdtH3Nrp+ZSvVM1Ji8J6dF3p5qEr1KykbyLF5/gD8Lic wSjhALRhJNjEKlJpFwICQ4VFsxFMEw/Eg7XnE3TKvGQIun7QiBIFk5Tl/bsd9cxnCsGf kAXnuyoINzJHAdC9apn0ac2vWE6er/3gV1poHGpLcMPnDV1FAU2+IikXAzyo2th7V3w1 +G0A== X-Gm-Message-State: AOAM530zxGMgUrAA7wQMcehhpvi2vZlcuvz/UaW5C+RaUQGr8ToMrufh cvJk5Lk+Q8bXDwXw3Sf9pK9Ic4jEiiE= X-Google-Smtp-Source: ABdhPJyk9wd16ewRfa0AK6sHzdH/ZUVpLRDTFFgtktXlI6qkoVJ3o3VwzoeEDVEHxcpsk2T1i3wyuw== X-Received: by 2002:a37:5f85:: with SMTP id t127mr4871737qkb.180.1604732978604; Fri, 06 Nov 2020 23:09:38 -0800 (PST) Received: from hurd (dsl-236-123-209.b2b2c.ca. [207.236.123.209]) by smtp.gmail.com with ESMTPSA id p48sm2238165qtp.67.2020.11.06.23.09.38 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 06 Nov 2020 23:09:38 -0800 (PST) Date: Sat, 07 Nov 2020 02:09:37 -0500 Message-Id: <87k0uxtzgu.fsf@gmail.com> To: control@debbugs.gnu.org From: Maxim Cournoyer Subject: control message for bug #44353 X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 44353 + patch quit From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 07 04:08:45 2020 Received: (at 44353) by debbugs.gnu.org; 7 Nov 2020 09:08:45 +0000 Received: from localhost ([127.0.0.1]:57938 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kbKDF-0005hf-DN for submit@debbugs.gnu.org; Sat, 07 Nov 2020 04:08:45 -0500 Received: from eggs.gnu.org ([209.51.188.92]:48152) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kbKDE-0005hS-00 for 44353@debbugs.gnu.org; Sat, 07 Nov 2020 04:08:44 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55470) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kbKD8-0000oT-Bk; Sat, 07 Nov 2020 04:08:38 -0500 Received: from [2a01:e0a:19b:d9a0:9dba:8b9f:8322:f2bc] (port=39664 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kbKD7-0004QX-QB; Sat, 07 Nov 2020 04:08:38 -0500 From: Mathieu Othacehe To: Maxim Cournoyer Subject: Re: bug#44353: guix system disk-image -t raw fails with grub-efi-bootloader References: <1e589f3b-47f8-fd53-b750-d2beff8d91f5@gmail.com> <87lffdtzh1.fsf@gmail.com> Date: Sat, 07 Nov 2020 10:08:36 +0100 In-Reply-To: <87lffdtzh1.fsf@gmail.com> (Maxim Cournoyer's message of "Sat, 07 Nov 2020 02:09:30 -0500") Message-ID: <875z6hmt4b.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44353 Cc: 44353@debbugs.gnu.org, Jesse Gibbons X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Hello Maxim, Thanks for your patch! It's hard to provide a reliable abstraction on top of all the exotic bootloader installation methods existing. Currently, each bootloader implements two methods: * bootloader-installer * bootloader-disk-image-installer The first one is dedicated to the installation of the bootloader on a mounted directory, while the second one is meant to work on a disk device such as "/dev/sda" or directly on a disk-image. When producing a disk-image with the "raw" type, we are always creating and populating an ESP partition (see raw-image-type), regardless of the selected bootloader. In fact, "raw" should be renamed to "hybrid-efi". The produced image can work on machines with legacy mbr boot or with EFI boot. Hence, calling "install-grub-efi" like it's done while building the lightweight-desktop operating-system is useless and fails. The attached patch fixes it. You can test it with: --8<---------------cut here---------------start------------->8--- qemu-system-x86_64 -m 1024 -bios $(guix build ovmf)/share/firmware/ovmf_x64.bin -hda disk.img --8<---------------cut here---------------end--------------->8--- > + ;; Special case: most bootloaders can be copied > + ;; directly at some fixed location on the image > + ;; disk, but when installed to the master boot > + ;; record (MBR), GRUB requires support files > + ;; present under /boot/grub, which is handled by > + ;; its 'installer' procedure. > #:bootloader-installer > - #+(bootloader-installer bootloader) > + #+(if (eq? 'grub (bootloader-name bootloader)) > + (bootloader-installer bootloader) > + #f) That would prevent other bootloaders relying on this procedure to work, such as extlinux. Thanks, Mathieu --=-=-= Content-Type: text/x-diff Content-Disposition: inline; filename=0001-bootloader-grub-Fix-EFI-installation.patch >From 2145fc40d3eb949885ce94883b09c7291c607be6 Mon Sep 17 00:00:00 2001 From: Mathieu Othacehe Date: Sat, 7 Nov 2020 10:03:53 +0100 Subject: [PATCH] bootloader: grub: Fix EFI installation. When producing a disk-image, "install-grub-efi" will be called with EFI-DIR set to false. The EFI bootloader is already installed by "initialize-efi-partition". In that case, do not proceed to bootloader installation. Fixes: . * gnu/bootloader/grub.scm (install-grub-efi): Do not install the bootloader if EFI-DIR is false. --- gnu/bootloader/grub.scm | 32 ++++++++++++++++++-------------- 1 file changed, 18 insertions(+), 14 deletions(-) diff --git a/gnu/bootloader/grub.scm b/gnu/bootloader/grub.scm index 0899fab61f..3404456df9 100644 --- a/gnu/bootloader/grub.scm +++ b/gnu/bootloader/grub.scm @@ -574,20 +574,24 @@ fi~%")))) (define install-grub-efi #~(lambda (bootloader efi-dir mount-point) ;; Install GRUB onto the EFI partition mounted at EFI-DIR, for the - ;; system whose root is mounted at MOUNT-POINT. - (let ((grub-install (string-append bootloader "/sbin/grub-install")) - (install-dir (string-append mount-point "/boot")) - ;; When installing Guix, it's common to mount EFI-DIR below - ;; MOUNT-POINT rather than /boot/efi on the live image. - (target-esp (if (file-exists? (string-append mount-point efi-dir)) - (string-append mount-point efi-dir) - efi-dir))) - ;; Tell 'grub-install' that there might be a LUKS-encrypted /boot or - ;; root partition. - (setenv "GRUB_ENABLE_CRYPTODISK" "y") - (invoke/quiet grub-install "--boot-directory" install-dir - "--bootloader-id=Guix" - "--efi-directory" target-esp)))) + ;; system whose root is mounted at MOUNT-POINT. When producing a + ;; disk-image, EFI-DIR is false and the EFI bootloader is already + ;; installed using "initialize-efi-partition". + (when efi-dir + (let ((grub-install (string-append bootloader "/sbin/grub-install")) + (install-dir (string-append mount-point "/boot")) + ;; When installing Guix, it's common to mount EFI-DIR below + ;; MOUNT-POINT rather than /boot/efi on the live image. + (target-esp (if (file-exists? + (string-append mount-point efi-dir)) + (string-append mount-point efi-dir) + efi-dir))) + ;; Tell 'grub-install' that there might be a LUKS-encrypted /boot or + ;; root partition. + (setenv "GRUB_ENABLE_CRYPTODISK" "y") + (invoke/quiet grub-install "--boot-directory" install-dir + "--bootloader-id=Guix" + "--efi-directory" target-esp))))) (define (install-grub-efi-netboot subdir) "Define a grub-efi-netboot bootloader installer for installation in SUBDIR, -- 2.29.2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 07 06:26:33 2020 Received: (at 44353) by debbugs.gnu.org; 7 Nov 2020 11:26:33 +0000 Received: from localhost ([127.0.0.1]:58013 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kbMMb-0000bB-An for submit@debbugs.gnu.org; Sat, 07 Nov 2020 06:26:33 -0500 Received: from imta-35.everyone.net ([216.200.145.35]:42178 helo=imta-38.everyone.net) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kbMMY-0000b0-Q3 for 44353@debbugs.gnu.org; Sat, 07 Nov 2020 06:26:31 -0500 Received: from pps.filterd (m0004961.ppops.net [127.0.0.1]) by imta-38.everyone.net (8.16.0.43/8.16.0.43) with SMTP id 0A7BNIHf007045; Sat, 7 Nov 2020 03:26:29 -0800 X-Eon-Originating-Account: fiUT2joAYjUzXTAaTB-qmLr3EftolQn-JjN6imnY_yg X-Eon-Dm: m0116952.ppops.net Received: by m0116952.mta.everyone.net (EON-AUTHRELAY2 - 5a81d734) id m0116952.5f8a0279.40ccae; Sat, 7 Nov 2020 03:26:28 -0800 X-Eon-Sig: AQMHrIJfpoRkNV5LJQIAAAAE,c7fe6215c83ccf5adc1636fab38e444e X-Eip: QqnzLoCV_-wcll0pc2Ah_rlu2vDYpIWN0KE7F-OgQTo Date: Sat, 7 Nov 2020 12:26:17 +0100 From: Bengt Richter To: Mathieu Othacehe Subject: Re: bug#44353: guix system disk-image -t raw fails with grub-efi-bootloader Message-ID: <20201107112617.GA2716@LionPure> References: <1e589f3b-47f8-fd53-b750-d2beff8d91f5@gmail.com> <87lffdtzh1.fsf@gmail.com> <875z6hmt4b.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <875z6hmt4b.fsf@gnu.org> User-Agent: Mutt/1.10.1 (2018-07-13) X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:6.0.312, 18.0.737 definitions=2020-11-07_04:2020-11-05, 2020-11-07 signatures=0 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 mlxlogscore=999 spamscore=0 phishscore=0 mlxscore=0 suspectscore=0 bulkscore=0 priorityscore=1501 impostorscore=0 clxscore=1034 adultscore=0 malwarescore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2011070075 X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: 44353 Cc: 44353@debbugs.gnu.org, Jesse Gibbons , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: Bengt Richter Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) Hi Mathieu, On +2020-11-07 10:08:36 +0100, Mathieu Othacehe wrote: > > Hello Maxim, > > Thanks for your patch! It's hard to provide a reliable abstraction on > top of all the exotic bootloader installation methods existing. > > Currently, each bootloader implements two methods: > > * bootloader-installer > * bootloader-disk-image-installer > > The first one is dedicated to the installation of the bootloader on a > mounted directory, while the second one is meant to work on a disk > device such as "/dev/sda" or directly on a disk-image. > > When producing a disk-image with the "raw" type, we are always creating > and populating an ESP partition (see raw-image-type), regardless of the > selected bootloader. In fact, "raw" should be renamed to "hybrid-efi". > > The produced image can work on machines with legacy mbr boot or with EFI > boot. Hence, calling "install-grub-efi" like it's done while building > the lightweight-desktop operating-system is useless and fails. The > attached patch fixes it. > > You can test it with: > > --8<---------------cut here---------------start------------->8--- > qemu-system-x86_64 -m 1024 -bios $(guix build ovmf)/share/firmware/ovmf_x64.bin -hda disk.img > --8<---------------cut here---------------end--------------->8--- > > > + ;; Special case: most bootloaders can be copied > > + ;; directly at some fixed location on the image > > + ;; disk, but when installed to the master boot > > + ;; record (MBR), GRUB requires support files > > + ;; present under /boot/grub, which is handled by > > + ;; its 'installer' procedure. > > #:bootloader-installer > > - #+(bootloader-installer bootloader) > > + #+(if (eq? 'grub (bootloader-name bootloader)) > > + (bootloader-installer bootloader) > > + #f) > > That would prevent other bootloaders relying on this procedure to work, > such as extlinux. > > Thanks, > > Mathieu Given that writing to "raw" disks is something the dd command is often used for, how much trouble would it be to provide an option for bootloader-disk-image-installer to output a shell script with the necessary dd commands, instead of doing the raw writing itself? I am imagining a tarball with separate binary block-sequence file images for the GPT or MBR header blocks, the embedded boot loader or UEFI partition image, and root partition etc.. I think the block-sequence images can be sliced out of the backing file of a loopback mount that fdisk and mkfs.* can format as desired, unless I'm missing something. I would like the script to use lsblk -o model,serial to identify the raw disk to write to, so there is no shooting the wrong foot ;) This is sketchy on the details, but ISTM a tarball like this would make it easy to prepare a USB-accessible disk using any laptop that was in a state where it was trusted to do sudo dd ... right. If the laptop didn't have all the tools, perhaps a minimal static busybox could be included in the tarball to guarantee existence of the dd and lsblk tools etc. There might be some file content that needs to be written with file i/o after dd has written the content-initialized monolith file system images. This could be interactive choices of alternate hostname, passwords, or whatever. Remember, this script is not burning a bootable installer (though it could), it is burning the bootable system an installer would install. The point of this is that it happens as the script with the dd commands executes on an arbitrary laptop with a raw USB disk attached, not as initialization dialog on first boot of the system whose image is being written to the USB disk. Obviously all files should be verifiable one way or another. Hopefully it would also make it easier to share/generate system images for raspberries or RISC-V ARM, etc. I guess you could call this a shell-script derivation, meant to talk to bash/dd instead of the guix daemon. Has anyone done this kind of factoring already? TIA for comment :) -- Regards, Bengt Richter From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 07 15:32:58 2020 Received: (at 44353) by debbugs.gnu.org; 7 Nov 2020 20:32:58 +0000 Received: from localhost ([127.0.0.1]:59318 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kbUtO-00089i-8P for submit@debbugs.gnu.org; Sat, 07 Nov 2020 15:32:58 -0500 Received: from mail-qv1-f42.google.com ([209.85.219.42]:37926) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kbUtN-00089S-FB for 44353@debbugs.gnu.org; Sat, 07 Nov 2020 15:32:57 -0500 Received: by mail-qv1-f42.google.com with SMTP id 13so2195824qvr.5 for <44353@debbugs.gnu.org>; Sat, 07 Nov 2020 12:32:57 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=Uk/cerZKCtzPT3UZ/YXpw3/dNZImqqRboHRApO63oNw=; b=ij54lsj3BIZklmHL83SUaGR6mog8whQJfI0m9eVtu0hU+NqeSChJhTyKB8iSOFRN/G BpJFGV5IcCKiencJ7tFjOJAGyWBpsczcEX5Esw1cm2G9qW1t4xxKcsXpitu00bKIKX+H kvzzSUd3rwdADZBeinH3CWinHpUAZNH+A/JpjnhFHkeSHGUM1lO5TMWZhj3EsHxBKr18 duLxNmG/NuHcpPAt/wYWn91e1LBFaylcOVTotx0UPqT2YmLr6/kB2Ip7V0pq/nAWMCv6 GsML9I75Zg4K61Rk5tA0pFmDmyeeX4bb62FfKixLZXvQ50vQ7PW2zQnI6k8DPrw57jFG bafw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=Uk/cerZKCtzPT3UZ/YXpw3/dNZImqqRboHRApO63oNw=; b=jFS2vjsEFt5+5f3aOP/Gl/wFjAOB/aWGWUbGCYMpUAhhGxQs+lzoV2wMHwIj7OuBFw M/lp95pHzePELX7t/qeSH9WO5SwQXhReX3SeRrlDUTEgb8aktNlfKt4em1Dwd17mvl2r u5kBJHrCo7avMO7NFw23yhZIjv7qSwomncdhi2g2LNo7QVjrP48IzKV10AqD1oB7dV4x FT7CCdfzIEronGopAsr7QDSZdIA2IDiyFAZrlPsPvpWvMa8gh0WSiZE8Q0RAsjjcE9uk y9TmrN03vXEbqT2EkcgfSxzF6KA7u1KeXwts3KfirT0brSEr/OliRs1z40pm3hoQFTTe fMYA== X-Gm-Message-State: AOAM530CVPAbkwUuBjuM8OgyoW9pigVsnIp+7mjn+H0GZ4mtWtm3FCw7 4ah757eDlRFDsmbm8atheDkfU8FPteE= X-Google-Smtp-Source: ABdhPJzayzGb3DonAqunN0AB9jVeTxaFq35EXQIsH/kQtaX14moXoPTc17iL7HtZgQVFEu/s4DY9hg== X-Received: by 2002:a0c:9719:: with SMTP id k25mr5861521qvd.42.1604781171656; Sat, 07 Nov 2020 12:32:51 -0800 (PST) Received: from hurd (dsl-236-123-209.b2b2c.ca. [207.236.123.209]) by smtp.gmail.com with ESMTPSA id y3sm3008288qto.2.2020.11.07.12.32.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 07 Nov 2020 12:32:50 -0800 (PST) From: Maxim Cournoyer To: Mathieu Othacehe Subject: Re: bug#44353: guix system disk-image -t raw fails with grub-efi-bootloader References: <1e589f3b-47f8-fd53-b750-d2beff8d91f5@gmail.com> <87lffdtzh1.fsf@gmail.com> <875z6hmt4b.fsf@gnu.org> Date: Sat, 07 Nov 2020 15:32:49 -0500 In-Reply-To: <875z6hmt4b.fsf@gnu.org> (Mathieu Othacehe's message of "Sat, 07 Nov 2020 10:08:36 +0100") Message-ID: <877dqwucum.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44353 Cc: 44353@debbugs.gnu.org, Jesse Gibbons X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Mathieu! Mathieu Othacehe writes: > Hello Maxim, > > Thanks for your patch! It's hard to provide a reliable abstraction on > top of all the exotic bootloader installation methods existing. > > Currently, each bootloader implements two methods: > > * bootloader-installer > * bootloader-disk-image-installer > > The first one is dedicated to the installation of the bootloader on a > mounted directory, while the second one is meant to work on a disk > device such as "/dev/sda" or directly on a disk-image. > > When producing a disk-image with the "raw" type, we are always creating > and populating an ESP partition (see raw-image-type), regardless of the > selected bootloader. In fact, "raw" should be renamed to "hybrid-efi". > > The produced image can work on machines with legacy mbr boot or with EFI > boot. Hence, calling "install-grub-efi" like it's done while building > the lightweight-desktop operating-system is useless and fails. The > attached patch fixes it. Thank you for the clarifications! > You can test it with: > > qemu-system-x86_64 -m 1024 -bios $(guix build > ovmf)/share/firmware/ovmf_x64.bin -hda disk.img Thank you! I hadn't realized that the default SeaBIOS BIOS used by QEMU wasn't EFI-capable! The image now boots, but fails bringing up its file systems for some reason. Perhaps I'm supposed to edit the file system definitions of the template before use? Here's how I tested it: $ time ./pre-inst-env guix system disk-image gnu/system/examples/lightweight-desktop.tmpl --verbosity=2 --no-offload That took 38 minutes on my system and produced /gnu/store/...-disk-image. $ cp /gnu/store/...-disk-image /tmp/lightweight-desktop.img $ chmod +rw /tmp/lightweight-desktop.img Then I tried running it with the suggested command: $ qemu-system-x86_64 -m 1024 -bios $(guix build ovmf)/share/firmware/ovmf_x64.bin -hda /tmp/lightweight-desktop.img >> + ;; Special case: most bootloaders can be copied >> + ;; directly at some fixed location on the image >> + ;; disk, but when installed to the master boot >> + ;; record (MBR), GRUB requires support files >> + ;; present under /boot/grub, which is handled by >> + ;; its 'installer' procedure. >> #:bootloader-installer >> - #+(bootloader-installer bootloader) >> + #+(if (eq? 'grub (bootloader-name bootloader)) >> + (bootloader-installer bootloader) >> + #f) > > That would prevent other bootloaders relying on this procedure to work, > such as extlinux. I pondered about such solution, but when I verified the bootloaders under gnu/bootloaders, it appeared that *only* the install-grub procedure supported being passed #f as its mount point; the others would fail because of the unexpected #f boolean value. For example, the install-extlinux procedure from (gnu bootloaders extlinux): --8<---------------cut here---------------start------------->8--- (define (install-extlinux mbr) #~(lambda (bootloader device mount-point) (let ((extlinux (string-append bootloader "/sbin/extlinux")) (install-dir (string-append mount-point "/boot/extlinux")) (syslinux-dir (string-append bootloader "/share/syslinux"))) (for-each (lambda (file) (install-file file install-dir)) (find-files syslinux-dir "\\.c32$")) (invoke/quiet extlinux "--install" install-dir) (write-file-on-device (string-append syslinux-dir "/" #$mbr) 440 device 0)))) --8<---------------cut here---------------end--------------->8--- Would break if device was set to #f, as is done in (guix build image)'s initialize-efi-partition: --8<---------------cut here---------------start------------->8--- (when bootloader-installer (display "installing bootloader...\n") (bootloader-installer bootloader-package #f root)) --8<---------------cut here---------------end--------------->8--- Is my analysis correct? If so, the patch I sent yesterday would fix the problem more thoroughly. Thank you, Maxim From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 08 06:05:04 2020 Received: (at 44353) by debbugs.gnu.org; 8 Nov 2020 11:05:04 +0000 Received: from localhost ([127.0.0.1]:59780 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kbiVM-0005yA-7m for submit@debbugs.gnu.org; Sun, 08 Nov 2020 06:05:04 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54044) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kbiVK-0005xE-V8 for 44353@debbugs.gnu.org; Sun, 08 Nov 2020 06:05:03 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:47932) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kbiVF-0004Qu-OK; Sun, 08 Nov 2020 06:04:57 -0500 Received: from [2a01:e0a:19b:d9a0:d4db:33d7:9f57:7a64] (port=46884 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kbiVF-0007Fj-8s; Sun, 08 Nov 2020 06:04:57 -0500 From: Mathieu Othacehe To: Maxim Cournoyer Subject: Re: bug#44353: guix system disk-image -t raw fails with grub-efi-bootloader References: <1e589f3b-47f8-fd53-b750-d2beff8d91f5@gmail.com> <87lffdtzh1.fsf@gmail.com> <875z6hmt4b.fsf@gnu.org> <877dqwucum.fsf@gmail.com> Date: Sun, 08 Nov 2020 12:04:55 +0100 In-Reply-To: <877dqwucum.fsf@gmail.com> (Maxim Cournoyer's message of "Sat, 07 Nov 2020 15:32:49 -0500") Message-ID: <87h7q0cdns.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44353 Cc: 44353@debbugs.gnu.org, Jesse Gibbons X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hey, > $ time ./pre-inst-env guix system disk-image > gnu/system/examples/lightweight-desktop.tmpl --verbosity=2 --no-offload > > That took 38 minutes on my system and produced /gnu/store/...-disk-image. Strange, only 8 minutes for me. Does it include the time necessary to fetch all substitutes? Are you using a SSD drive? > $ qemu-system-x86_64 -m 1024 -bios $(guix build > ovmf)/share/firmware/ovmf_x64.bin -hda /tmp/lightweight-desktop.img It tries to mount the EFI file-system with UUID "1234-ABCD" and fails. You can remove this one for the lightweight-desktop configuration to obtain a bootable system. > Would break if device was set to #f, as is done in (guix build image)'s > initialize-efi-partition: > > (when bootloader-installer > (display "installing bootloader...\n") > (bootloader-installer bootloader-package #f root)) > > Is my analysis correct? If so, the patch I sent yesterday would fix the > problem more thoroughly. Yes it is probably broken too. However, I would prefer not to introduce bootloader specific stuff in (gnu system image). I think the bootloaders should try to do their best with the DEVICE and MOUNT-POINT arguments passed to bootloader-installer procedure. It means, trying to install themselves using only MOUNT-POINT argument or bailing out. WDYT? Thanks, Mathieu From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 11 22:57:38 2020 Received: (at 44353) by debbugs.gnu.org; 12 Nov 2020 03:57:38 +0000 Received: from localhost ([127.0.0.1]:43360 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kd3js-0005Ns-CF for submit@debbugs.gnu.org; Wed, 11 Nov 2020 22:57:38 -0500 Received: from mail-qk1-f193.google.com ([209.85.222.193]:40668) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kd3jq-0005Nb-15 for 44353@debbugs.gnu.org; Wed, 11 Nov 2020 22:57:35 -0500 Received: by mail-qk1-f193.google.com with SMTP id y197so4137871qkb.7 for <44353@debbugs.gnu.org>; Wed, 11 Nov 2020 19:57:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=c9BN8zswRGwbQ2JwxGzehLM0mTZbyqipFVh6R17/nJs=; b=rl+hZKXtIJjiS1FHBLJkzGUJpO7IjUPC22zQi5Bat2UdR/LDXt5NRb6nXo4UC85SnY jix60SZ5g53rbznbW3p9d9zwDEw7Hc/aENHYWLzTT5WXSLZmt/tykLgfIHJTkY2sBjGi zMEBLRyOs/AVsNe9hXEg4UHRiVEhDj2QKBF14o/L26SX7WtqCBuOVRlDwx6zQ8BlQxsL RLWSum52yAGKoel2sDzg2HQBkgoY9L6gIb3sm4kq6/2IE2K+A46zYNQFGUPBSqHk72VS ZtbNpg1LqD6aKLXZ2hFgtYKX08GQNZ9ZM0YjGpfsD973OJgbd0Yx51aSJZPvqsrfjrSW b1Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=c9BN8zswRGwbQ2JwxGzehLM0mTZbyqipFVh6R17/nJs=; b=R1Nq2G7a0XE383qSDP7btVQ7HJDDIjr4QHU+gyEtFqf//BKOzSIIGdYcgNBsdPrTzc OilZPqqcOjuLoqUsHk3u7XnzF6lotaeR4/BtvWCQbhtRSyYc14Q1xNzQelqwUFHEZRBL Dmo7NlrZLPUTAkuScthKEl35g6np0lVid/2Q18Cd0sjIROm8apVm3EaStkloqlkCZ1xW 3Qiya+LMXxDH+HNy15CxxDlS0Ll/XbJAas+y82m4Swq0STo7OVBaYvVV/RT15Qqe+y75 jTwQQe7S3Paaa57wOCpavOnAQRmkKMbL0jocbDtupBZlN7dqn160vUia6fj6rCeSdeP3 aFMw== X-Gm-Message-State: AOAM533Qar4EExkh+c0YeCv+thW77uXmZ9Qh6TSHrfr/cZLB0gjJRt00 1i/ugT8nC1HJnTvKVtsxpMEck0AcnmU= X-Google-Smtp-Source: ABdhPJwL4X3Ur5ASgsASa6vkVQIZyxQIfKz/IxaxmxOU3qVeNQuKMMEAiICD1NyPnSPSz7I0bQHObw== X-Received: by 2002:a37:9b17:: with SMTP id d23mr29298217qke.254.1605153448192; Wed, 11 Nov 2020 19:57:28 -0800 (PST) Received: from localhost.localdomain (dsl-10-133-153.b2b2c.ca. [72.10.133.153]) by smtp.gmail.com with ESMTPSA id m15sm4630009qtc.90.2020.11.11.19.57.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Nov 2020 19:57:27 -0800 (PST) From: Maxim Cournoyer To: 44353@debbugs.gnu.org Subject: [PATCH version-1.2.0 v2 1/3] image: Remove conflicting user-provided EFI file system. Date: Wed, 11 Nov 2020 22:57:11 -0500 Message-Id: <20201112035713.3789-1-maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <87h7q0cdns.fsf@gnu.org> References: <87h7q0cdns.fsf@gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44353 Cc: Mathieu Othacehe , Jesse Gibbons , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) When the bootloader used is grub-efi-bootloader, an ESP partition and file system is already added by the image generator. If a conflicting user-provided EFI file system is provided, it will (likely) cause the boot to fail, as happens for the lightweight-desktop.tmpl and desktop.tmpl templates under gnu/system/examples. * gnu/system/image.scm (operating-system-for-image): Also remove file systems whose mount point is "/boot/efi". --- gnu/system/image.scm | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/gnu/system/image.scm b/gnu/system/image.scm index 81152f0fc4..4972d9067b 100644 --- a/gnu/system/image.scm +++ b/gnu/system/image.scm @@ -576,7 +576,9 @@ it can be used for bootloading." (file-systems-to-keep (srfi-1:remove (lambda (fs) - (string=? (file-system-mount-point fs) "/")) + (let ((mount-point (file-system-mount-point fs))) + (or (string=? mount-point "/") + (string=? mount-point "/boot/efi")))) (operating-system-file-systems base-os))) (format (image-format image)) (os -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 11 22:57:39 2020 Received: (at 44353) by debbugs.gnu.org; 12 Nov 2020 03:57:39 +0000 Received: from localhost ([127.0.0.1]:43362 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kd3jv-0005OD-Fv for submit@debbugs.gnu.org; Wed, 11 Nov 2020 22:57:39 -0500 Received: from mail-qv1-f65.google.com ([209.85.219.65]:42789) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kd3jr-0005Nh-Jp for 44353@debbugs.gnu.org; Wed, 11 Nov 2020 22:57:37 -0500 Received: by mail-qv1-f65.google.com with SMTP id b11so2147010qvr.9 for <44353@debbugs.gnu.org>; Wed, 11 Nov 2020 19:57:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=SQTfGgKe81CfinD4MNs+lFk23JliSXX1IGTIGpxA1Go=; b=Kdv8WsLDzKXpwmNC+c0kIuu3ilgWkiVs9xMX2YVNNyZLrT7P11sMVyjUdwBzP8jG3a 7Lg/damaf/UT5Go5GZa6per5W3P0j6gc65OjWVliyHorEavqg8AaEb9LAsBzuLT+U+jx vMA7GQ7H/j3o9WP1gUTY45WLzWRknXf2rT0rY3Y6VwYQdf3V1aroUoBcmqiXvY7d7nDs 7ZGPq/JfvTaBr5dZdlascQn68sHaA5AYnHRhl5vZ4cT5eFYDoaA10uvgAI0rIjrMk25m o0fqHsbXulYhKY56/exRh6BgTCcq+20G3Kzo7qNxEfRAHRdq3rTFYQEFxw3NFcf1zkTN 82zw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=SQTfGgKe81CfinD4MNs+lFk23JliSXX1IGTIGpxA1Go=; b=q/kPveDZzmM3PrXxGRQ9lj2x03QKmtSiEPcuD5qAmJ3rWrsoqPpoT7rzSe4UZ54XSv QOGY+nnKIUbGS1XgjjqvJAKwgUQphV4N4KR8RY4mawvq6FvcwNCzG6wtYMwo8EPDMDiz Ov41WY+/WVpP+7iAlN7nCWpAoR7PsLgt2c6BS9r9lvvGBrB7zC9o4JrY6GRSCl45lYxc XRrvXCm75O528juQ9vHoC8OdCntpiXG+eepnCy4HEPutv+9vNQO10E8RKsDmEgZmz5dm ottxOwYw0Rxo7x9j9i+mbIec6M4YAEwfG301kJoovjMf5ml5x481IGleP0+hdQSOslYo TsCw== X-Gm-Message-State: AOAM533ny8kzP3O/A/+U5sTBVR/St3A4XO3EafOuio7eq1kwegjN5AQz pBz9P/9M14KWmcvZL7SrmbHGbyRUb+A= X-Google-Smtp-Source: ABdhPJwZvuG/L4droTleiw5SNr6XP0OrfW/pAz2Fw/iIgpE1RKLMDy1Lh70ikSDJ2D60jDH6dsGsNw== X-Received: by 2002:a05:6214:964:: with SMTP id do4mr262784qvb.18.1605153449867; Wed, 11 Nov 2020 19:57:29 -0800 (PST) Received: from localhost.localdomain (dsl-10-133-153.b2b2c.ca. [72.10.133.153]) by smtp.gmail.com with ESMTPSA id m15sm4630009qtc.90.2020.11.11.19.57.29 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Nov 2020 19:57:29 -0800 (PST) From: Maxim Cournoyer To: 44353@debbugs.gnu.org Subject: [PATCH version-1.2.0 v2 3/3] doc: Detail which bootloader get used with disk-image or vm-image. Date: Wed, 11 Nov 2020 22:57:13 -0500 Message-Id: <20201112035713.3789-3-maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201112035713.3789-1-maxim.cournoyer@gmail.com> References: <87h7q0cdns.fsf@gnu.org> <20201112035713.3789-1-maxim.cournoyer@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44353 Cc: Mathieu Othacehe , Jesse Gibbons , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * doc/guix.texi (Invoking guix system): Extend doc. --- doc/guix.texi | 31 ++++++++++++++++++++++++++----- 1 file changed, 26 insertions(+), 5 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index b7f1bc1f00..e15ee4092c 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -30909,11 +30909,25 @@ a value. Docker images are built to contain exactly what they need, so the @option{--image-size} option is ignored in the case of @code{docker-image}. +@cindex disk-image, creating disk images The @code{disk-image} command can produce various image types. The image type can be selected using the @command{--image-type} option. It -defaults to @code{raw}. When its value is @code{iso9660}, the +defaults to @code{raw}. When its value is @code{iso9660}, the @option{--label} option can be used to specify a volume ID with -@code{disk-image}. +@code{disk-image}. When using @code{disk-image}, the bootloader +installed on the generated image is taken from the provided +@code{operating-system} definition. The following example demonstrates +how to generate an image that uses the @code{grub-efi-bootloader} +bootloader and boot it with QEMU: + +@example +image=$(guix system disk-image --image-type=qcow2 \ + gnu/system/examples/lightweight-desktop.tmpl) +cp $image /tmp/my-image.qcow2 +chmod +rw /tmp/my-image.qcow2 +qemu-system-x86_64 -enable-kvm -hda /tmp/my-image.qcow2 -m 1000 + -bios $(guix build ovmf)/share/firmware/ovmf_x64.bin +@end example When using the @code{raw} image type, a raw disk image is produced; it can be copied as is to a USB stick, for instance. Assuming @@ -30927,10 +30941,17 @@ the image to it using the following command: The @code{--list-image-types} command lists all the available image types. +@cindex vm-image, creating virtual machine images When using @code{vm-image}, the returned image is in qcow2 format, which -the QEMU emulator can efficiently use. @xref{Running Guix in a VM}, -for more information on how to run the image in a virtual machine. - +the QEMU emulator can efficiently use. @xref{Running Guix in a VM}, for +more information on how to run the image in a virtual machine. The +@code{grub-bootloader} bootloader is always used independently of what +is declared in the @code{operating-system} file passed as argument. +This is to make it easier to work with QEMU, which uses the SeaBIOS BIOS +by default, expecting a bootloader to be installed in the Master Boot +Record (MBR). + +@cindex docker-image, creating docker images When using @code{docker-image}, a Docker image is produced. Guix builds the image from scratch, not from a pre-existing Docker base image. As a result, it contains @emph{exactly} what you define in the operating -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 11 22:57:42 2020 Received: (at 44353) by debbugs.gnu.org; 12 Nov 2020 03:57:42 +0000 Received: from localhost ([127.0.0.1]:43364 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kd3jx-0005OM-Q4 for submit@debbugs.gnu.org; Wed, 11 Nov 2020 22:57:42 -0500 Received: from mail-qk1-f195.google.com ([209.85.222.195]:39775) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kd3jq-0005Nd-OX for 44353@debbugs.gnu.org; Wed, 11 Nov 2020 22:57:38 -0500 Received: by mail-qk1-f195.google.com with SMTP id q22so4160279qkq.6 for <44353@debbugs.gnu.org>; Wed, 11 Nov 2020 19:57:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=wR265Tv7yjbBa+mGNjF1+reij/HZYvoloEleE5/bPi0=; b=Y8rSylqqyOBPujnYB0oDofh8FEtKqCi3aWNDocEzrKutMsGipt4bRybP4IN4qNpQbV pr5k6FgKrE8YpMspkgx6tEY7V0ShsBcJW4796r2Tg+qhDe4gkjxc71Mtpru02kZZA6vL 15zlj5SggvPoKwXOTBEtU7sSt7c33eaTes9N4x+9gOpn82d5P6I1Tkv7AxOa7umvvmI6 ptjCNkMjorjPnDzX1TPo/mMXCOem+7gvndIoqLC+p4TX4JU1ow63UYO5EYLMyuWjequK lJAQy/P99KvcMSGiwQc2/F/ryjjVWf4ahLixiMcpuhHBTvbOl94DqJ2pND635EXC8LrY BSEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=wR265Tv7yjbBa+mGNjF1+reij/HZYvoloEleE5/bPi0=; b=WFebl7eISglgCX08NS+UXkh3kjYCeCrvQCMWx4G+eRBuNDeaOdAOufFqGzK+q902d/ D3D+Scj8XiLIng4F6aFLGkjxnSPpJ3LRt/tVfi1e73gt9vPJDU/NuosFt+uacRFFNG4R 3Y2uTiETnxTB8h9Zu9Y7fWsc1JSEJ0bOoHubzpTkzl6jxAhmsXfZV0hgXc8qXQC4AKfR gQgP8PfkLOxZbQNlrzzqgNC9DPJ7x1pBil+ZLaOQoflltU5CBNqf5p7HJUB2S69H3NFC 330Q5FY4IEBM7u+RpuFHOVqP+4w58Dd+IEOKGFS6RgJV13kOVqcrDQ2Gaf9MmIVtMSc+ Z/Kg== X-Gm-Message-State: AOAM532GSrYUaeIByfzSp6KX+k5iam/y7sdXIVeK/of6pOVGSQorskNZ YOvKnaN5LnyK1WXGytA3TkBq/hFNkig= X-Google-Smtp-Source: ABdhPJwzsJFn+iYkJT+czS0e86hi8Xc9BYKHVQeKHEx0tzkUWzkZmeJMA9zRwbm0Qa7Lti/rOmGhMQ== X-Received: by 2002:a37:614b:: with SMTP id v72mr20575376qkb.355.1605153449109; Wed, 11 Nov 2020 19:57:29 -0800 (PST) Received: from localhost.localdomain (dsl-10-133-153.b2b2c.ca. [72.10.133.153]) by smtp.gmail.com with ESMTPSA id m15sm4630009qtc.90.2020.11.11.19.57.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Nov 2020 19:57:28 -0800 (PST) From: Maxim Cournoyer To: 44353@debbugs.gnu.org Subject: [PATCH version-1.2.0 v2 2/3] bootloader: grub: Skip install-grub-efi when producing a disk image. Date: Wed, 11 Nov 2020 22:57:12 -0500 Message-Id: <20201112035713.3789-2-maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <20201112035713.3789-1-maxim.cournoyer@gmail.com> References: <87h7q0cdns.fsf@gnu.org> <20201112035713.3789-1-maxim.cournoyer@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44353 Cc: Mathieu Othacehe , Jesse Gibbons , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Fixes . Every bootloader should try their best to install themselves using only the MOUNT-POINT and otherwise do nothing. This requirement comes from the necessity to call INSTALL-GRUB when installing the (non-EFI) GRUB bootloader, which needs to populate the root file system with extra modules that cannot be fit in the core.img file, limited in size to 491520 bytes (by the i386-pc format required for legacy BIOS compatibility). As introducing bootloader knowledge at the level of the image code is undesirable, every bootloader should be adapted to support this fall-back for their installation procedure (TODO). * gnu/bootloader/grub.scm (install-grub-efi)[efi-dir]: Skip when the EFI-DIR argument is set to #f. --- gnu/bootloader/grub.scm | 33 ++++++++++++++++++--------------- 1 file changed, 18 insertions(+), 15 deletions(-) diff --git a/gnu/bootloader/grub.scm b/gnu/bootloader/grub.scm index 0899fab61f..af7b7561ff 100644 --- a/gnu/bootloader/grub.scm +++ b/gnu/bootloader/grub.scm @@ -573,21 +573,24 @@ fi~%")))) (define install-grub-efi #~(lambda (bootloader efi-dir mount-point) - ;; Install GRUB onto the EFI partition mounted at EFI-DIR, for the - ;; system whose root is mounted at MOUNT-POINT. - (let ((grub-install (string-append bootloader "/sbin/grub-install")) - (install-dir (string-append mount-point "/boot")) - ;; When installing Guix, it's common to mount EFI-DIR below - ;; MOUNT-POINT rather than /boot/efi on the live image. - (target-esp (if (file-exists? (string-append mount-point efi-dir)) - (string-append mount-point efi-dir) - efi-dir))) - ;; Tell 'grub-install' that there might be a LUKS-encrypted /boot or - ;; root partition. - (setenv "GRUB_ENABLE_CRYPTODISK" "y") - (invoke/quiet grub-install "--boot-directory" install-dir - "--bootloader-id=Guix" - "--efi-directory" target-esp)))) + ;; There is nothing useful to do when called in the context of a disk + ;; image generation. + (when efi-dir + ;; Install GRUB onto the EFI partition mounted at EFI-DIR, for the + ;; system whose root is mounted at MOUNT-POINT. + (let ((grub-install (string-append bootloader "/sbin/grub-install")) + (install-dir (string-append mount-point "/boot")) + ;; When installing Guix, it's common to mount EFI-DIR below + ;; MOUNT-POINT rather than /boot/efi on the live image. + (target-esp (if (file-exists? (string-append mount-point efi-dir)) + (string-append mount-point efi-dir) + efi-dir))) + ;; Tell 'grub-install' that there might be a LUKS-encrypted /boot or + ;; root partition. + (setenv "GRUB_ENABLE_CRYPTODISK" "y") + (invoke/quiet grub-install "--boot-directory" install-dir + "--bootloader-id=Guix" + "--efi-directory" target-esp))))) (define (install-grub-efi-netboot subdir) "Define a grub-efi-netboot bootloader installer for installation in SUBDIR, -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 12 02:10:30 2020 Received: (at 44353) by debbugs.gnu.org; 12 Nov 2020 07:10:30 +0000 Received: from localhost ([127.0.0.1]:43448 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kd6kX-0001yZ-Ny for submit@debbugs.gnu.org; Thu, 12 Nov 2020 02:10:30 -0500 Received: from mail-io1-f65.google.com ([209.85.166.65]:46022) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kd6kW-0001yM-8f for 44353@debbugs.gnu.org; Thu, 12 Nov 2020 02:10:28 -0500 Received: by mail-io1-f65.google.com with SMTP id u21so4936884iol.12 for <44353@debbugs.gnu.org>; Wed, 11 Nov 2020 23:10:28 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=FBvPczlVj+1NC3a/UBE33PrvresG7Vog9JQV5a8BMsg=; b=eloeXqFEASuuf7O8u4n0GEFrfw+SaYq9EcZgAN0S7pxxEHGk4Dc7h6VoaQZ+L+CteG sMHNiUTUtMXXI75483/AQc0MF0aM0JGpD4oED3bBkmHRrInrdN446hC+Kg4MlOVqvDeq XI6+b17uccjqA6tQZ1lSsF/IPde8/0DQbPw0wPgVml/rWWhIAQsRX2ul8nyt/Sc40AU5 FRxOl7eTjeHv3kBt76l0PcHqjWi0O+i1Gk+7YlARKLIdiQedUsXFjGemkITvjM3giAg6 afLrry16DZzf0hLoGRcwDuBa6/makBToz7KpbjzAf3mx/29cHJzFlaX3FX7SxDHl57io H8VA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=FBvPczlVj+1NC3a/UBE33PrvresG7Vog9JQV5a8BMsg=; b=OMmQNgT5TU9t90vbM+c6a9KiDZEeNUAKnCmM4T+Z/PTpMlohuBmVncFY+4MnUjERJQ C9lri7Pnue5EFJ6jcJ7+VWlvKspuspQ3x5sjfZCXeCfAXHkLALO8Jr4eAieIyNmU4wtR SJnoqn8pcpZrhdjcZHVA6B4xoHSZ+BO70Elhi47PSoaCnAb6mc8IOuLuIOCXUAsTLnpY 1nJqb7nSOCHttORtB7lHzBt5thCgq00/+eWMQvhWXQJZ/gAVq9lPr4yUyx+yd/P5p42N xOgZHpohzS6Nu9VkJzWeqbgBvgE5EAnsd55sumhHfIbQ8UYKWeeOpDZfsS02/qe2bOKy FmYw== X-Gm-Message-State: AOAM531Sm62/KR9Ct/noErGYcmVupwUSgbczM22Q1EkNPOgFG4eoIIgM m9vaeHVMI0Do8SIGIAVbF9o1EpBEGYs= X-Google-Smtp-Source: ABdhPJy1ryo2gxe+3FYtmjeli9dZSAZXjYsrhP+vxH0/Bt1bK7MJ/Fpzfc0lQ2M1ayYwIN2I75xpyg== X-Received: by 2002:a02:5149:: with SMTP id s70mr5941664jaa.121.1605165022139; Wed, 11 Nov 2020 23:10:22 -0800 (PST) Received: from localhost.localdomain (dsl-10-133-153.b2b2c.ca. [72.10.133.153]) by smtp.gmail.com with ESMTPSA id c3sm2550601ila.47.2020.11.11.23.10.20 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 11 Nov 2020 23:10:21 -0800 (PST) From: Maxim Cournoyer To: 44353@debbugs.gnu.org Subject: [PATCH version-1.2.0 v2] guix: system: Add a new '--non-volatile' option for disk-image. Date: Thu, 12 Nov 2020 02:09:17 -0500 Message-Id: <20201112070917.11794-1-maxim.cournoyer@gmail.com> X-Mailer: git-send-email 2.28.0 In-Reply-To: <87h7q0cdns.fsf@gnu.org> References: <87h7q0cdns.fsf@gnu.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44353 Cc: Mathieu Othacehe , =?UTF-8?q?Ludovic=20Court=C3=A8s?= , Jesse Gibbons , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * guix/scripts/system.scm (%options)[volatile-root?]: New boolean option. (%default-options): Set its default value to #f. (show-help): Add help doc. * guix/scripts/system.scm (perform-action): Propagate option... (system-derivation-for-action): ...here. Use it to set the volatile-root? field of the image object passed to SYSTEM-IMAGE. * doc/guix.texi (Invoking guix system): Document it. --- doc/guix.texi | 18 ++++++++++++------ guix/scripts/system.scm | 21 +++++++++++++++++---- 2 files changed, 29 insertions(+), 10 deletions(-) diff --git a/doc/guix.texi b/doc/guix.texi index e15ee4092c..30efb7fc97 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -30911,14 +30911,20 @@ the @option{--image-size} option is ignored in the case of @cindex disk-image, creating disk images The @code{disk-image} command can produce various image types. The -image type can be selected using the @command{--image-type} option. It +image type can be selected using the @option{--image-type} option. It defaults to @code{raw}. When its value is @code{iso9660}, the @option{--label} option can be used to specify a volume ID with -@code{disk-image}. When using @code{disk-image}, the bootloader -installed on the generated image is taken from the provided -@code{operating-system} definition. The following example demonstrates -how to generate an image that uses the @code{grub-efi-bootloader} -bootloader and boot it with QEMU: +@code{disk-image}. By default, the root file system of a disk image is +mounted volatile; the @option{--non-volatile} option can be used to make +it persistent instead. The @option{--non-volatile} is useful to make +use of extra disk space that can be obtained by using a larger value for +the @option{--image-size} option; otherwise, the amount of physical +memory available determines the capacity of the volatile file system +overlay used for the root file system. When using @code{disk-image}, +the bootloader installed on the generated image is taken from the +provided @code{operating-system} definition. The following example +demonstrates how to generate an image that uses the +@code{grub-efi-bootloader} bootloader and boot it with QEMU: @example image=$(guix system disk-image --image-type=qcow2 \ diff --git a/guix/scripts/system.scm b/guix/scripts/system.scm index ad998156c2..004f1c9739 100644 --- a/guix/scripts/system.scm +++ b/guix/scripts/system.scm @@ -674,7 +674,8 @@ checking this by themselves in their 'check' procedure." (define* (system-derivation-for-action os action #:key image-size image-type full-boot? container-shared-network? - mappings label) + mappings label + volatile-root?) "Return as a monadic value the derivation for OS according to ACTION." (mlet %store-monad ((target (current-target-system))) (case action @@ -706,7 +707,8 @@ checking this by themselves in their 'check' procedure." base-image)) (target (or base-target target)) (size image-size) - (operating-system os)))))) + (operating-system os) + (volatile-root? volatile-root?)))))) ((docker-image) (system-docker-image os #:shared-network? container-shared-network?))))) @@ -761,6 +763,7 @@ and TARGET arguments." dry-run? derivations-only? use-substitutes? bootloader-target target image-size image-type + volatile-root? full-boot? label container-shared-network? (mappings '()) (gc-root #f)) @@ -768,7 +771,8 @@ and TARGET arguments." bootloader; BOOTLOADER-TAGET is the target for the bootloader; TARGET is the target root directory; IMAGE-SIZE is the size of the image to be built, for the 'vm-image' and 'disk-image' actions. IMAGE-TYPE is the type of image to -be built. +be built. When VOLATILE-ROOT? is #t, the root file system is mounted +volatile. FULL-BOOT? is used for the 'vm' action; it determines whether to boot directly to the kernel or to the bootloader. CONTAINER-SHARED-NETWORK? @@ -816,6 +820,7 @@ static checks." #:label label #:image-type image-type #:image-size image-size + #:volatile-root? volatile-root? #:full-boot? full-boot? #:container-shared-network? container-shared-network? #:mappings mappings)) @@ -974,6 +979,8 @@ Some ACTIONS support additional ARGS.\n")) --image-size=SIZE for 'vm-image', produce an image of SIZE")) (display (G_ " --no-bootloader for 'init', do not install a bootloader")) + (display (G_ " + --non-volatile for 'disk-image', persist root file system changes")) (display (G_ " --label=LABEL for 'disk-image', label disk image with LABEL")) (display (G_ " @@ -1048,6 +1055,9 @@ Some ACTIONS support additional ARGS.\n")) (option '("no-bootloader" "no-grub") #f #f (lambda (opt name arg result) (alist-cons 'install-bootloader? #f result))) + (option '("non-volatile") #f #f + (lambda (opt name arg result) + (alist-cons 'volatile-root? #f result))) (option '("label") #t #f (lambda (opt name arg result) (alist-cons 'label arg result))) @@ -1109,7 +1119,8 @@ Some ACTIONS support additional ARGS.\n")) (image-type . raw) (image-size . guess) (install-bootloader? . #t) - (label . #f))) + (label . #f) + (volatile-root? . #t))) (define (verbosity-level opts) "Return the verbosity level based on OPTS, the alist of parsed options." @@ -1206,6 +1217,8 @@ resulting from command-line parsing." #:image-type (lookup-image-type-by-name (assoc-ref opts 'image-type)) #:image-size (assoc-ref opts 'image-size) + #:volatile-root? + (assoc-ref opts 'volatile-root?) #:full-boot? (assoc-ref opts 'full-boot?) #:container-shared-network? (assoc-ref opts 'container-shared-network?) -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 12 03:37:15 2020 Received: (at 44353) by debbugs.gnu.org; 12 Nov 2020 08:37:15 +0000 Received: from localhost ([127.0.0.1]:43517 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kd86V-0006DR-0B for submit@debbugs.gnu.org; Thu, 12 Nov 2020 03:37:15 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40338) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kd86Q-0006DA-Vw for 44353@debbugs.gnu.org; Thu, 12 Nov 2020 03:37:13 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48635) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kd86L-0007yt-Mw; Thu, 12 Nov 2020 03:37:05 -0500 Received: from [2a01:e0a:19b:d9a0:a5e0:155b:c52:63c1] (port=37828 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kd86H-0005xu-5X; Thu, 12 Nov 2020 03:37:01 -0500 From: Mathieu Othacehe To: Maxim Cournoyer Subject: Re: bug#44353: [PATCH version-1.2.0 v2] guix: system: Add a new '--non-volatile' option for disk-image. References: <87h7q0cdns.fsf@gnu.org> <20201112070917.11794-1-maxim.cournoyer@gmail.com> Date: Thu, 12 Nov 2020 09:36:59 +0100 In-Reply-To: <20201112070917.11794-1-maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Thu, 12 Nov 2020 02:09:17 -0500") Message-ID: <877dqrvums.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44353 Cc: 44353@debbugs.gnu.org, Jesse Gibbons X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Maxim, > * guix/scripts/system.scm (%options)[volatile-root?]: New boolean option. > (%default-options): Set its default value to #f. > (show-help): Add help doc. > * guix/scripts/system.scm (perform-action): Propagate option... > (system-derivation-for-action): ...here. Use it to set the volatile-root? > field of the image object passed to SYSTEM-IMAGE. > * doc/guix.texi (Invoking guix system): Document it. This is a nice addition and it looks good to me. Thanks, Mathieu From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 12 03:39:59 2020 Received: (at 44353) by debbugs.gnu.org; 12 Nov 2020 08:39:59 +0000 Received: from localhost ([127.0.0.1]:43535 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kd898-0006He-Sz for submit@debbugs.gnu.org; Thu, 12 Nov 2020 03:39:59 -0500 Received: from eggs.gnu.org ([209.51.188.92]:40850) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kd897-0006HQ-3E for 44353@debbugs.gnu.org; Thu, 12 Nov 2020 03:39:57 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48647) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kd890-0000OB-Bb; Thu, 12 Nov 2020 03:39:51 -0500 Received: from [2a01:e0a:19b:d9a0:a5e0:155b:c52:63c1] (port=37834 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kd88y-00066i-SP; Thu, 12 Nov 2020 03:39:50 -0500 From: Mathieu Othacehe To: Maxim Cournoyer Subject: Re: bug#44353: [PATCH version-1.2.0 v2 1/3] image: Remove conflicting user-provided EFI file system. References: <87h7q0cdns.fsf@gnu.org> <20201112035713.3789-1-maxim.cournoyer@gmail.com> Date: Thu, 12 Nov 2020 09:39:47 +0100 In-Reply-To: <20201112035713.3789-1-maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Wed, 11 Nov 2020 22:57:11 -0500") Message-ID: <87361fvui4.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44353 Cc: 44353@debbugs.gnu.org, Jesse Gibbons X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hey Maxim, > When the bootloader used is grub-efi-bootloader, an ESP partition and file > system is already added by the image generator. If a conflicting > user-provided EFI file system is provided, it will (likely) cause the boot to > fail, as happens for the lightweight-desktop.tmpl and desktop.tmpl templates > under gnu/system/examples. Nice one. I would just clarify in the commit message that the ESP partition is added only when the selected image type is "raw". Otherwise, it looks fine! Thanks, Mathieu From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 12 03:42:19 2020 Received: (at 44353) by debbugs.gnu.org; 12 Nov 2020 08:42:19 +0000 Received: from localhost ([127.0.0.1]:43554 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kd8BP-0006Lv-5g for submit@debbugs.gnu.org; Thu, 12 Nov 2020 03:42:19 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41360) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kd8BN-0006Lj-0w for 44353@debbugs.gnu.org; Thu, 12 Nov 2020 03:42:17 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48661) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kd8BH-0001RP-Nq; Thu, 12 Nov 2020 03:42:11 -0500 Received: from [2a01:e0a:19b:d9a0:a5e0:155b:c52:63c1] (port=37836 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kd8BD-0006Ja-I2; Thu, 12 Nov 2020 03:42:08 -0500 From: Mathieu Othacehe To: Maxim Cournoyer Subject: Re: bug#44353: [PATCH version-1.2.0 v2 2/3] bootloader: grub: Skip install-grub-efi when producing a disk image. References: <87h7q0cdns.fsf@gnu.org> <20201112035713.3789-1-maxim.cournoyer@gmail.com> <20201112035713.3789-2-maxim.cournoyer@gmail.com> Date: Thu, 12 Nov 2020 09:42:05 +0100 In-Reply-To: <20201112035713.3789-2-maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Wed, 11 Nov 2020 22:57:12 -0500") Message-ID: <87y2j7uftu.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44353 Cc: 44353@debbugs.gnu.org, Jesse Gibbons X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Maxim, > As introducing bootloader knowledge at the level of the image code is > undesirable, every bootloader should be adapted to support this fall-back for > their installation procedure (TODO). Or maybe find a way to remove the need to call "bootloader-installer" when producing a disk-image as we discussed on IRC. Looks fine! Thanks, Mathieu From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 12 03:45:54 2020 Received: (at 44353) by debbugs.gnu.org; 12 Nov 2020 08:45:54 +0000 Received: from localhost ([127.0.0.1]:43558 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kd8Es-0006Re-Jv for submit@debbugs.gnu.org; Thu, 12 Nov 2020 03:45:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:41912) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kd8Eq-0006RQ-Fo for 44353@debbugs.gnu.org; Thu, 12 Nov 2020 03:45:52 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48676) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kd8Ej-0002bC-VJ; Thu, 12 Nov 2020 03:45:47 -0500 Received: from [2a01:e0a:19b:d9a0:a5e0:155b:c52:63c1] (port=37852 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kd8Ej-0006ZX-9c; Thu, 12 Nov 2020 03:45:45 -0500 From: Mathieu Othacehe To: Maxim Cournoyer Subject: Re: bug#44353: [PATCH version-1.2.0 v2 3/3] doc: Detail which bootloader get used with disk-image or vm-image. References: <87h7q0cdns.fsf@gnu.org> <20201112035713.3789-1-maxim.cournoyer@gmail.com> <20201112035713.3789-3-maxim.cournoyer@gmail.com> Date: Thu, 12 Nov 2020 09:45:43 +0100 In-Reply-To: <20201112035713.3789-3-maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Wed, 11 Nov 2020 22:57:13 -0500") Message-ID: <87tutvufns.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44353 Cc: 44353@debbugs.gnu.org, Jesse Gibbons X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hey, > +@example > +image=$(guix system disk-image --image-type=qcow2 \ > + gnu/system/examples/lightweight-desktop.tmpl) > +cp $image /tmp/my-image.qcow2 > +chmod +rw /tmp/my-image.qcow2 > +qemu-system-x86_64 -enable-kvm -hda /tmp/my-image.qcow2 -m 1000 > + -bios $(guix build ovmf)/share/firmware/ovmf_x64.bin > +@end example This looks good! Note that I plan to remove the "vm-image" command and rename "disk-image" command to "image" once the 1.2.0 is out. Thanks, Mathieu From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 12 09:59:29 2020 Received: (at 44353) by debbugs.gnu.org; 12 Nov 2020 14:59:29 +0000 Received: from localhost ([127.0.0.1]:45356 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdE4O-0005RK-Ow for submit@debbugs.gnu.org; Thu, 12 Nov 2020 09:59:29 -0500 Received: from mail-qk1-f175.google.com ([209.85.222.175]:36584) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdE4M-0005R6-0w for 44353@debbugs.gnu.org; Thu, 12 Nov 2020 09:59:27 -0500 Received: by mail-qk1-f175.google.com with SMTP id r7so5484303qkf.3 for <44353@debbugs.gnu.org>; Thu, 12 Nov 2020 06:59:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=xeBoIEGl5kOu+FCL+CYqdP9B5yBrqR1JLfbxMT1/jTw=; b=mREErsvscMryplnJZ3UYPwlxDy6AsQy1MWvp/TA1QRj7hxG/sqj9a2vrvH8Ytmr3TX Wbo7tJrGAbY6tApUkG8IOrFRZa+ym7ylzIduhJz3PsSpUh8wScmuBXQzCnSA++fInGtg R2xosCBLbgc0QArxNUOLpQwUM5zKhrnmyHSo7c6BLjHknWhv+vAKg2yjSF2l9Nunj6Al 3/h4mqV2HJvy8sg+d05g7q6ygF7e/BnlQr76jIOja7mSdNmmORnB0vSdqLtMrXzKVamI jfvSG+YP+kRzvcPeq4Z19D3eB3tp/I42wjBNndbmhP4IWkseu7S4iPQgnpjMNcVF8Tvp jW2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=xeBoIEGl5kOu+FCL+CYqdP9B5yBrqR1JLfbxMT1/jTw=; b=XUoJeHZWpbqVqUaPSK2OE+vroblAczXsWh3FBMbb6EdyHvW5bkvxQ/M/4fk3QJ/xN2 PYD6SMnxo8KSBV5nEFQ3bYWk3JqBu2gxMzH59MZ0ry0y8jE9Q9COGnGye/wXpQ6VuP1O Oqg4Lb+qSowWYO6nowlps2Gzzzq1bI/w9ZfIhTWxBWK/Egg92IQQVKQXezaDmRUNZ9KN ht4xDmbfPo2Nk3Q0NNwH1+KrkeJnICv0K57Gg+xbJ7bwK12JmtqIfI6LwR4mneFpuLoI iP1+H4cUeSVpwhEKWFSIx/kX4WP+gEz7LoUiCPOjPSFWDzLu6H1hQNlvo2iShMZPkz/+ aatg== X-Gm-Message-State: AOAM532Z+r+xLdiK8792dN3MITU1v9VpSm3fJ5LzksWNZf7XXDVD+RDc 0gXPO9QqYp/huB+veQCaAtc= X-Google-Smtp-Source: ABdhPJxlpFIZ7xGn1SobfbhKmNjOi53Cu1mmAQqmXKgGDOvtDcPS4MQ3Y3NpKNJo6a7WwBPtADjI9Q== X-Received: by 2002:a37:ac02:: with SMTP id e2mr92849qkm.243.1605193160230; Thu, 12 Nov 2020 06:59:20 -0800 (PST) Received: from hurd ([207.35.95.19]) by smtp.gmail.com with ESMTPSA id v6sm4708160qkh.83.2020.11.12.06.59.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Nov 2020 06:59:19 -0800 (PST) From: Maxim Cournoyer To: Mathieu Othacehe Subject: Re: bug#44353: [PATCH version-1.2.0 v2] guix: system: Add a new '--non-volatile' option for disk-image. References: <87h7q0cdns.fsf@gnu.org> <20201112070917.11794-1-maxim.cournoyer@gmail.com> <877dqrvums.fsf@gnu.org> Date: Thu, 12 Nov 2020 09:59:18 -0500 In-Reply-To: <877dqrvums.fsf@gnu.org> (Mathieu Othacehe's message of "Thu, 12 Nov 2020 09:36:59 +0100") Message-ID: <87h7pufwop.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44353 Cc: 44353@debbugs.gnu.org, Jesse Gibbons X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Mathieu, Mathieu Othacehe writes: > Hello Maxim, > >> * guix/scripts/system.scm (%options)[volatile-root?]: New boolean option. >> (%default-options): Set its default value to #f. >> (show-help): Add help doc. >> * guix/scripts/system.scm (perform-action): Propagate option... >> (system-derivation-for-action): ...here. Use it to set the volatile-root? >> field of the image object passed to SYSTEM-IMAGE. >> * doc/guix.texi (Invoking guix system): Document it. > > This is a nice addition and it looks good to me. > > Thanks, > > Mathieu One thing I wasn't sure was if it'd be better to implicitly derive volatile-root? #f when image-type was specified (not (eq? 'guess)). The rationale being that users specifying the image-size themselves probably want to make use of extra space (assumption) but can't unless volatile-root? is #t on the image. If we choose the above it'd lead to less code and one less switch; on the other hand it is not as explicit. What do you think? Maxim From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 12 12:06:55 2020 Received: (at 44353) by debbugs.gnu.org; 12 Nov 2020 17:06:55 +0000 Received: from localhost ([127.0.0.1]:45494 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdG3i-00009B-Qm for submit@debbugs.gnu.org; Thu, 12 Nov 2020 12:06:54 -0500 Received: from eggs.gnu.org ([209.51.188.92]:51678) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdG3e-00008v-VT for 44353@debbugs.gnu.org; Thu, 12 Nov 2020 12:06:54 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56216) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kdG3Z-0007IW-NT; Thu, 12 Nov 2020 12:06:45 -0500 Received: from [2a01:e0a:19b:d9a0:a5e0:155b:c52:63c1] (port=40702 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kdG3R-0006VB-2T; Thu, 12 Nov 2020 12:06:39 -0500 From: Mathieu Othacehe To: Maxim Cournoyer Subject: Re: bug#44353: [PATCH version-1.2.0 v2] guix: system: Add a new '--non-volatile' option for disk-image. References: <87h7q0cdns.fsf@gnu.org> <20201112070917.11794-1-maxim.cournoyer@gmail.com> <877dqrvums.fsf@gnu.org> <87h7pufwop.fsf@gmail.com> Date: Thu, 12 Nov 2020 18:06:34 +0100 In-Reply-To: <87h7pufwop.fsf@gmail.com> (Maxim Cournoyer's message of "Thu, 12 Nov 2020 09:59:18 -0500") Message-ID: <87r1oyjyhx.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44353 Cc: 44353@debbugs.gnu.org, Jesse Gibbons X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello Maxim, > One thing I wasn't sure was if it'd be better to implicitly derive > volatile-root? #f when image-type was specified (not (eq? 'guess)). The > rationale being that users specifying the image-size themselves probably > want to make use of extra space (assumption) but can't unless > volatile-root? is #t on the image. > > If we choose the above it'd lead to less code and one less switch; on > the other hand it is not as explicit. > > What do you think? When developing the image API, I hesitated keeping the default of using volatile root file systems by default. In most cases, I think that the user may prefer to have non volatile images. They already have to copy the image from the store and make it writable so that QEMU can use it with "-hda" argument. Switching the default to non volatile could be an option I think. Doing what you are proposing: setting volatile to false when image-size is passed could also be a first step. Thanks, Mathieu From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 12 16:17:06 2020 Received: (at 44353) by debbugs.gnu.org; 12 Nov 2020 21:17:06 +0000 Received: from localhost ([127.0.0.1]:45782 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdJxq-0008Fn-5W for submit@debbugs.gnu.org; Thu, 12 Nov 2020 16:17:06 -0500 Received: from eggs.gnu.org ([209.51.188.92]:54736) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdJxo-0008FA-3M for 44353@debbugs.gnu.org; Thu, 12 Nov 2020 16:17:05 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60886) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kdJxi-0008Dg-QP; Thu, 12 Nov 2020 16:16:58 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=58594 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kdJxh-0004NE-VW; Thu, 12 Nov 2020 16:16:58 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Mathieu Othacehe Subject: Re: bug#44353: [PATCH version-1.2.0 v2 3/3] doc: Detail which bootloader get used with disk-image or vm-image. References: <87h7q0cdns.fsf@gnu.org> <20201112035713.3789-1-maxim.cournoyer@gmail.com> <20201112035713.3789-3-maxim.cournoyer@gmail.com> <87tutvufns.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 22 Brumaire an 229 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 12 Nov 2020 22:16:56 +0100 In-Reply-To: <87tutvufns.fsf@gnu.org> (Mathieu Othacehe's message of "Thu, 12 Nov 2020 09:45:43 +0100") Message-ID: <87r1oyff7b.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44353 Cc: 44353@debbugs.gnu.org, Jesse Gibbons , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi, Mathieu Othacehe skribis: >> +@example >> +image=3D$(guix system disk-image --image-type=3Dqcow2 \ >> + gnu/system/examples/lightweight-desktop.tmpl) >> +cp $image /tmp/my-image.qcow2 >> +chmod +rw /tmp/my-image.qcow2 >> +qemu-system-x86_64 -enable-kvm -hda /tmp/my-image.qcow2 -m 1000 >> + -bios $(guix build ovmf)/share/firmware/ovmf_x64.bin >> +@end example > > This looks good! Note that I plan to remove the "vm-image" command and > rename "disk-image" command to "image" once the 1.2.0 is out. However note that the manual should not be change on =E2=80=98version-1.2.0= =E2=80=99 at this point, =E2=80=9Cthe strings are frozen=E2=80=9D, they say. Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Thu Nov 12 16:18:45 2020 Received: (at 44353) by debbugs.gnu.org; 12 Nov 2020 21:18:45 +0000 Received: from localhost ([127.0.0.1]:45790 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdJzQ-0008IN-Pb for submit@debbugs.gnu.org; Thu, 12 Nov 2020 16:18:44 -0500 Received: from eggs.gnu.org ([209.51.188.92]:55256) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdJzP-0008IA-Gj for 44353@debbugs.gnu.org; Thu, 12 Nov 2020 16:18:43 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:60922) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kdJzJ-0008V6-Up; Thu, 12 Nov 2020 16:18:38 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=58596 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kdJzJ-0004V3-1y; Thu, 12 Nov 2020 16:18:37 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Mathieu Othacehe Subject: Re: bug#44353: [PATCH version-1.2.0 v2] guix: system: Add a new '--non-volatile' option for disk-image. References: <87h7q0cdns.fsf@gnu.org> <20201112070917.11794-1-maxim.cournoyer@gmail.com> <877dqrvums.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 22 Brumaire an 229 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Thu, 12 Nov 2020 22:18:35 +0100 In-Reply-To: <877dqrvums.fsf@gnu.org> (Mathieu Othacehe's message of "Thu, 12 Nov 2020 09:36:59 +0100") Message-ID: <87mtzmff4k.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44353 Cc: 44353@debbugs.gnu.org, Jesse Gibbons , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Mathieu Othacehe skribis: >> * guix/scripts/system.scm (%options)[volatile-root?]: New boolean option. >> (%default-options): Set its default value to #f. >> (show-help): Add help doc. >> * guix/scripts/system.scm (perform-action): Propagate option... >> (system-derivation-for-action): ...here. Use it to set the volatile-roo= t? >> field of the image object passed to SYSTEM-IMAGE. >> * doc/guix.texi (Invoking guix system): Document it. > > This is a nice addition and it looks good to me. Can we keep it for =E2=80=98master=E2=80=99 only, notably because of the = =E2=80=9Cstring freeze=E2=80=9D? Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 15 16:45:27 2020 Received: (at 44353) by debbugs.gnu.org; 15 Nov 2020 21:45:27 +0000 Received: from localhost ([127.0.0.1]:54416 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kePpv-0006mF-3m for submit@debbugs.gnu.org; Sun, 15 Nov 2020 16:45:27 -0500 Received: from eggs.gnu.org ([209.51.188.92]:46284) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kePpr-0006m0-QV for 44353@debbugs.gnu.org; Sun, 15 Nov 2020 16:45:25 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:48726) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kePpm-0005Tj-Fn; Sun, 15 Nov 2020 16:45:18 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=45300 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kePpl-0007p8-Kt; Sun, 15 Nov 2020 16:45:17 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Maxim Cournoyer Subject: Re: [PATCH version-1.2.0 v2] guix: system: Add a new '--non-volatile' option for disk-image. References: <87h7q0cdns.fsf@gnu.org> <20201112070917.11794-1-maxim.cournoyer@gmail.com> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 25 Brumaire an 229 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Sun, 15 Nov 2020 22:45:15 +0100 In-Reply-To: <20201112070917.11794-1-maxim.cournoyer@gmail.com> (Maxim Cournoyer's message of "Thu, 12 Nov 2020 02:09:17 -0500") Message-ID: <878sb25m6s.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44353 Cc: 44353@debbugs.gnu.org, Mathieu Othacehe , Jesse Gibbons X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi Maxim, Maxim Cournoyer skribis: > * guix/scripts/system.scm (%options)[volatile-root?]: New boolean option. > (%default-options): Set its default value to #f. > (show-help): Add help doc. > * guix/scripts/system.scm (perform-action): Propagate option... > (system-derivation-for-action): ...here. Use it to set the volatile-root? > field of the image object passed to SYSTEM-IMAGE. > * doc/guix.texi (Invoking guix system): Document it. Due notably to the =E2=80=9Cstring freeze=E2=80=9D, I think we shouldn=E2= =80=99t apply it to =E2=80=98version-1.2.0=E2=80=99. Some comments: > +@code{disk-image}. By default, the root file system of a disk image is > +mounted volatile; the @option{--non-volatile} option can be used to make That=E2=80=99s not generally the case, though in (gnu system image), only t= wo image types have it set to false. Before the new image API though, =E2=80=98disk-image=E2=80=99 did not produ= ce a volatile root, IIRC. I=E2=80=99m tempted to think that we should set (volatile-root? #f) on image types where it makes sense, which is maybe all of them except ISO. (Then we need to make sure =E2=80=98guix system vm=E2=80=99 st= ill gets a volatile root.) WDYT, Mathieu? So apart from the sentence above, the patch LGTM for =E2=80=98master=E2=80= =99! Thanks, Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 15 21:48:13 2020 Received: (at 44353) by debbugs.gnu.org; 16 Nov 2020 02:48:13 +0000 Received: from localhost ([127.0.0.1]:54709 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keUYv-00085D-4L for submit@debbugs.gnu.org; Sun, 15 Nov 2020 21:48:13 -0500 Received: from mail-qt1-f172.google.com ([209.85.160.172]:45016) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keUYr-00084s-HS for 44353@debbugs.gnu.org; Sun, 15 Nov 2020 21:48:11 -0500 Received: by mail-qt1-f172.google.com with SMTP id m65so11864053qte.11 for <44353@debbugs.gnu.org>; Sun, 15 Nov 2020 18:48:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=IYDhbFT5tPeKUzIsUwWsD7kh1Xr4A4livRHuAQbKFR8=; b=Z22YrtESyAM1c8vXPx5t4SpIyIiEzJq6wVnux9V1fDeMJ5VmWFrf8md6Aqgk8Umi8e yzXCG91gBolQlyJ8i2TmGrrMbFUHoI8sxX0eGJJXFxnUxvP+Gz8i2Vo5u2ri35BeUjIN nhB0eePnVlv1VLzgd2z9ioA8q4uFMmLsMrtqlJj1mUq/o5F2JL3v7ArDSiwhknn6PSdg O3hxFJkB+v0i4KY9A46F1WPe0muXggXr5EQaJNwBWxdNnclxJnctX7S0cZ49/YzSdtoH i/+Eq/1I6yyxeTLjRcFyDWg0p1ETzTX6gKlNjLmm/A4hgqmSD1lFIroAMKAVvHttH5eG xT8A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=IYDhbFT5tPeKUzIsUwWsD7kh1Xr4A4livRHuAQbKFR8=; b=f0ngom+UkGVPVA+ByTkwjdLiVh8cBDZhJCKZtxMm9lviRdhgPKtEGL6t2CbcMkY/s7 0AnNIf4WgEaYmqDwE/hnsN9KyycCdpe1a1uxfWAGqXQDDnlTo6LTGEbevNlUbckhQQ9T iuhQxCwbInBEgi407jNKgdbX6pvwsb85JH7QB9TeBKkGFoWtQKb5d/bCZgirUvzrztXw ItnIQGiTnaExKeyeYbcq+ORNUiUtMccgI8QWFMVrdSZ/zH1kimD8YDY7IYLLCdNiqpV4 ECnKlP5F1yEs3+njKxhXROa4qLaR18uFiT6+FlDaqGKd0TISIU+FdaS64QqVZa3Z1Vya rmkQ== X-Gm-Message-State: AOAM532wYkRnZGQMYB1wptXBLZAT0jiwWzeuxqzPiNYXo1snI9ZpZl9i mbecxuzbc421/FJPLGFgsQ4= X-Google-Smtp-Source: ABdhPJynDPI1GItaoQm7mgCsNSNT/hFyaZp4b9bi/IWVqOVOaYhvMrYDWiLf1i3uK2zJw2/AHO03YQ== X-Received: by 2002:ac8:7b92:: with SMTP id p18mr12147402qtu.105.1605494884086; Sun, 15 Nov 2020 18:48:04 -0800 (PST) Received: from hurd (dsl-10-128-91.b2b2c.ca. [72.10.128.91]) by smtp.gmail.com with ESMTPSA id t60sm10867675qtd.65.2020.11.15.18.48.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Nov 2020 18:48:03 -0800 (PST) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#44353: [PATCH version-1.2.0 v2] guix: system: Add a new '--non-volatile' option for disk-image. References: <87h7q0cdns.fsf@gnu.org> <20201112070917.11794-1-maxim.cournoyer@gmail.com> <877dqrvums.fsf@gnu.org> <87mtzmff4k.fsf@gnu.org> Date: Sun, 15 Nov 2020 21:48:02 -0500 In-Reply-To: <87mtzmff4k.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Thu, 12 Nov 2020 22:18:35 +0100") Message-ID: <87r1oudnkt.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44353 Cc: 44353@debbugs.gnu.org, Mathieu Othacehe , Jesse Gibbons X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hey, Ludovic Court=C3=A8s writes: > Mathieu Othacehe skribis: > >>> * guix/scripts/system.scm (%options)[volatile-root?]: New boolean optio= n. >>> (%default-options): Set its default value to #f. >>> (show-help): Add help doc. >>> * guix/scripts/system.scm (perform-action): Propagate option... >>> (system-derivation-for-action): ...here. Use it to set the volatile-ro= ot? >>> field of the image object passed to SYSTEM-IMAGE. >>> * doc/guix.texi (Invoking guix system): Document it. >> >> This is a nice addition and it looks good to me. > > Can we keep it for =E2=80=98master=E2=80=99 only, notably because of the = =E2=80=9Cstring > freeze=E2=80=9D? Sure, let's do that! Maxim From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 15 22:47:30 2020 Received: (at 44353) by debbugs.gnu.org; 16 Nov 2020 03:47:30 +0000 Received: from localhost ([127.0.0.1]:54756 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keVUI-0001E1-3A for submit@debbugs.gnu.org; Sun, 15 Nov 2020 22:47:30 -0500 Received: from mail-qv1-f53.google.com ([209.85.219.53]:47081) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keVUD-0001Di-Le for 44353@debbugs.gnu.org; Sun, 15 Nov 2020 22:47:29 -0500 Received: by mail-qv1-f53.google.com with SMTP id r12so8153102qvq.13 for <44353@debbugs.gnu.org>; Sun, 15 Nov 2020 19:47:25 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=+QOM3XO1zMziJt+JQZS0z+7Zal7fBdC9V0INJbTsxio=; b=coR4UgBSty4xPabOy/3SxvT+zEs7mntlzcd5QLSCSh+xYMhe/w4cFT+gPQuxT2H/jr abYzspyztq0y5Isrs5w2amZScWvFiZt1ukshlqr/ChaoiZ19688TCmRzLOCZNjeAMKf8 1Gy9cQSeV5110/fFjR4wS1eOCyko2da4S3ft98up2PsD3/MErT+JvN8iBLZ6DyVv4WkG 8+APKQdVMbz0GpfqYJlx+sxiclvkGHvJSbT35eCXIJP8B/d32KneRV8ci2lvszFJg95N wTXV05i7fCkerfdf0OOeKnQun+PYUK+HumdcdlaCC88bsSzJUe2cVdsDcGwlyf88ntLF V8lQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=+QOM3XO1zMziJt+JQZS0z+7Zal7fBdC9V0INJbTsxio=; b=uBBiFSDOGmP3zJpOMRoRX87DaSdQHAA6wcwhnDEHA4MiVP3/8oS9M1Fff2U3MW8Mw3 PXxgbWO+oNbq0s3P+bl9gdIVQ/t5mZa4BLLK91QPY64ntBuUYyF9sM0CfmryefMzgxF3 1Iv8UbXph7ZlQgU2q7Y452afIffX7h+BripVpinPGtYxhx1fzGP9Mn3J3X5mkvpusdKQ dglmoX2vEh1WLD8Ez60KMwAFkjX15NiF87cuK29zXNJdh7dOOVAeCToLMS0tP2ePtnNS jdSMQ0sXV6e6qtCO/7m1PfkbEHvlBOhwn+FvjT0ok3s+7TLJoqEUHGBCP50lWCWS7ETb dhuw== X-Gm-Message-State: AOAM5323E9IfRcum5e5/exCLtKjW/ToqDCkWN4gJkMSz+Q0wZ4CyWj/S owITJNm+B3P+CGfnJX07S4I= X-Google-Smtp-Source: ABdhPJxRsrAeDho2P+KgHKPFFbM9CwlO1HpApk12LBxSSabfyAekKm2cbp8BmP99WYz70w6o9FD/cQ== X-Received: by 2002:ad4:4745:: with SMTP id c5mr14094639qvx.2.1605498440109; Sun, 15 Nov 2020 19:47:20 -0800 (PST) Received: from hurd (dsl-10-128-91.b2b2c.ca. [72.10.128.91]) by smtp.gmail.com with ESMTPSA id a1sm11142270qtw.11.2020.11.15.19.47.19 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 15 Nov 2020 19:47:19 -0800 (PST) From: Maxim Cournoyer To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: bug#44353: [PATCH version-1.2.0 v2] guix: system: Add a new '--non-volatile' option for disk-image. References: <87h7q0cdns.fsf@gnu.org> <20201112070917.11794-1-maxim.cournoyer@gmail.com> <878sb25m6s.fsf@gnu.org> Date: Sun, 15 Nov 2020 22:47:11 -0500 In-Reply-To: <878sb25m6s.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Sun, 15 Nov 2020 22:45:15 +0100") Message-ID: <87mtzidku8.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44353 Cc: 44353@debbugs.gnu.org, Mathieu Othacehe , Jesse Gibbons X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Ludovic Court=C3=A8s writes: > Hi Maxim, > > Maxim Cournoyer skribis: > >> * guix/scripts/system.scm (%options)[volatile-root?]: New boolean option. >> (%default-options): Set its default value to #f. >> (show-help): Add help doc. >> * guix/scripts/system.scm (perform-action): Propagate option... >> (system-derivation-for-action): ...here. Use it to set the volatile-roo= t? >> field of the image object passed to SYSTEM-IMAGE. >> * doc/guix.texi (Invoking guix system): Document it. > > Due notably to the =E2=80=9Cstring freeze=E2=80=9D, I think we shouldn=E2= =80=99t apply it to > =E2=80=98version-1.2.0=E2=80=99. > > Some comments: > >> +@code{disk-image}. By default, the root file system of a disk image is >> +mounted volatile; the @option{--non-volatile} option can be used to make > > That=E2=80=99s not generally the case, though in (gnu system image), only= two > image types have it set to false. Note that the only two images with volatile-root? #f are ARM, and not by intent but as a workaround: ;; FIXME: Deleting and creating "/var/run" and "/tmp" on the overlayfs ;; fails. > Before the new image API though, =E2=80=98disk-image=E2=80=99 did not pro= duce a volatile > root, IIRC. I=E2=80=99m tempted to think that we should set (volatile-ro= ot? > #f) on image types where it makes sense, which is maybe all of them > except ISO. (Then we need to make sure =E2=80=98guix system vm=E2=80=99 = still gets a > volatile root.) > > WDYT, Mathieu? Based on your comments and those of Mathieut, I've made volatile-root? #f the default for 'guix system disk-image', with a '--volatile' option to maintain the ability to have the rootfs mounted volatile, and adjusted the doc accordingly. > So apart from the sentence above, the patch LGTM for =E2=80=98master=E2= =80=99! Thanks for the review! Maxim From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 16 04:23:29 2020 Received: (at 44353) by debbugs.gnu.org; 16 Nov 2020 09:23:29 +0000 Received: from localhost ([127.0.0.1]:55056 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keajR-0001Xw-4j for submit@debbugs.gnu.org; Mon, 16 Nov 2020 04:23:29 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39368) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keajO-0001Xh-Ae for 44353@debbugs.gnu.org; Mon, 16 Nov 2020 04:23:27 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:59246) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1keajE-0004O2-RY; Mon, 16 Nov 2020 04:23:20 -0500 Received: from [2a01:e0a:19b:d9a0:e47a:2f88:af18:cc15] (port=46854 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1keajE-0001Fn-Do; Mon, 16 Nov 2020 04:23:16 -0500 From: Mathieu Othacehe To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [PATCH version-1.2.0 v2] guix: system: Add a new '--non-volatile' option for disk-image. References: <87h7q0cdns.fsf@gnu.org> <20201112070917.11794-1-maxim.cournoyer@gmail.com> <878sb25m6s.fsf@gnu.org> Date: Mon, 16 Nov 2020 10:23:14 +0100 In-Reply-To: <878sb25m6s.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Sun, 15 Nov 2020 22:45:15 +0100") Message-ID: <87o8jxlkot.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44353 Cc: 44353@debbugs.gnu.org, Jesse Gibbons , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hey Ludo, > Before the new image API though, =E2=80=98disk-image=E2=80=99 did not pro= duce a volatile > root, IIRC. I=E2=80=99m tempted to think that we should set (volatile-ro= ot? > #f) on image types where it makes sense, which is maybe all of them > except ISO. (Then we need to make sure =E2=80=98guix system vm=E2=80=99 = still gets a > volatile root.) > > WDYT, Mathieu? That's also what I proposed to Maxim. Note that "guix system vm" is still using the "old" VM based image production method and doesn't share the new image API volatile default. Thanks, Mathieu From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 16 08:09:17 2020 Received: (at 44353) by debbugs.gnu.org; 16 Nov 2020 13:09:17 +0000 Received: from localhost ([127.0.0.1]:55377 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keeFt-00031X-UY for submit@debbugs.gnu.org; Mon, 16 Nov 2020 08:09:17 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39916) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keeFs-00031I-FV for 44353@debbugs.gnu.org; Mon, 16 Nov 2020 08:09:12 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33358) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1keeFn-0002Eq-8g; Mon, 16 Nov 2020 08:09:07 -0500 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=47890 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1keeFk-0000J3-HM; Mon, 16 Nov 2020 08:09:04 -0500 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Mathieu Othacehe Subject: Re: [PATCH version-1.2.0 v2] guix: system: Add a new '--non-volatile' option for disk-image. References: <87h7q0cdns.fsf@gnu.org> <20201112070917.11794-1-maxim.cournoyer@gmail.com> <878sb25m6s.fsf@gnu.org> <87o8jxlkot.fsf@gnu.org> X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 26 Brumaire an 229 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0x090B11993D9AEBB5 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4 0CFB 090B 1199 3D9A EBB5 X-OS: x86_64-pc-linux-gnu Date: Mon, 16 Nov 2020 14:09:02 +0100 In-Reply-To: <87o8jxlkot.fsf@gnu.org> (Mathieu Othacehe's message of "Mon, 16 Nov 2020 10:23:14 +0100") Message-ID: <874klpxxch.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44353 Cc: 44353@debbugs.gnu.org, Jesse Gibbons , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Mathieu Othacehe skribis: >> Before the new image API though, =E2=80=98disk-image=E2=80=99 did not pr= oduce a volatile >> root, IIRC. I=E2=80=99m tempted to think that we should set (volatile-r= oot? >> #f) on image types where it makes sense, which is maybe all of them >> except ISO. (Then we need to make sure =E2=80=98guix system vm=E2=80=99= still gets a >> volatile root.) >> >> WDYT, Mathieu? > > That's also what I proposed to Maxim. Note that "guix system vm" is > still using the "old" VM based image production method and doesn't share > the new image API volatile default. Right. Speaking of which, can we remove =E2=80=98system-disk-image-in-vm=E2=80=99?= It has zero users now. Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 16 08:35:01 2020 Received: (at 44353) by debbugs.gnu.org; 16 Nov 2020 13:35:02 +0000 Received: from localhost ([127.0.0.1]:55403 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keeer-0003gy-FT for submit@debbugs.gnu.org; Mon, 16 Nov 2020 08:35:01 -0500 Received: from eggs.gnu.org ([209.51.188.92]:45860) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1keeem-0003gc-HQ for 44353@debbugs.gnu.org; Mon, 16 Nov 2020 08:34:59 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33841) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1keeeg-0002h8-0w; Mon, 16 Nov 2020 08:34:50 -0500 Received: from [2a01:e0a:19b:d9a0:3036:7cf3:6a95:6495] (port=39208 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1keeef-0006CZ-KA; Mon, 16 Nov 2020 08:34:49 -0500 From: Mathieu Othacehe To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [PATCH version-1.2.0 v2] guix: system: Add a new '--non-volatile' option for disk-image. References: <87h7q0cdns.fsf@gnu.org> <20201112070917.11794-1-maxim.cournoyer@gmail.com> <878sb25m6s.fsf@gnu.org> <87o8jxlkot.fsf@gnu.org> <874klpxxch.fsf@gnu.org> Date: Mon, 16 Nov 2020 14:34:47 +0100 In-Reply-To: <874klpxxch.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Mon, 16 Nov 2020 14:09:02 +0100") Message-ID: <87k0ull91k.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44353 Cc: 44353@debbugs.gnu.org, Jesse Gibbons , Maxim Cournoyer X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hey, > Speaking of which, can we remove =E2=80=98system-disk-image-in-vm=E2=80= =99? It has zero > users now. Sure, I also need to find some time to route "vm-image", "vm" and possibly "docker-image" commands to new image API. Thanks, Mathieu From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 17 09:44:59 2020 Received: (at 44353) by debbugs.gnu.org; 17 Nov 2020 14:44:59 +0000 Received: from localhost ([127.0.0.1]:58789 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kf2E7-0006z1-Cr for submit@debbugs.gnu.org; Tue, 17 Nov 2020 09:44:59 -0500 Received: from mail-qt1-f182.google.com ([209.85.160.182]:36562) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kf2E4-0006yl-9m for 44353@debbugs.gnu.org; Tue, 17 Nov 2020 09:44:58 -0500 Received: by mail-qt1-f182.google.com with SMTP id 3so15735068qtx.3 for <44353@debbugs.gnu.org>; Tue, 17 Nov 2020 06:44:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=UJVcDKqktQjdrv4nrai+l9ncPBgjLuq7xDNileg6dqo=; b=D2nxhOUMi+mhASqBeZItO5jIVEpzrH5D/v9VXi447++6EUPv2UG4w/7LbIfGOoYcBP 0WBcAXlYAkaDk2FW4pQLT56wgbn6/v1WvFkDJPDe9CgjEOwKTTdd/VtKqpP/pQOpJMnK 0kCYD989FklGxP7Dea9Gm49ELuh/3EUgqfYyyefOYRT2V7LP0uOXunKwzk4TyiE9AU+m QJg9fmY2PE0gFLLS4TrwWHpdoFNsmHi9RiqXxWTcZHCjCSKycEQRbijaep6/Q9D6fBW9 +hwaBvIGjRdVaRbNnYIBLSDauQzb6/dfmoGus8qolOfeg+MGkcpIpENM7Wimu0q5So38 HzIg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=UJVcDKqktQjdrv4nrai+l9ncPBgjLuq7xDNileg6dqo=; b=K/ebiHW6S/ZadbhhGKAQUEKjjuLuaVkEKEph2C/6sWFGaCzDzEBl+Lm1hYK9HwzOPF JprCzfUO3n3AQsq+Bp0IP0JMtCPLJmWtjyrk6qrXErUTgZ1Dtr2Iti1rKXZr3oDrJml+ HIPEIFZaM+FsEIZU/OS9qvoevVsT/UHTaJz1/sUNwQPt8EIFC0JGk59K6fotzKn6tetp xeEqCpAVKQKi6xnj2WWN13GFSEuQgLj06vHfo+t7Dt5iOwRaWH7YsdbBMGUksqIV06GF yo2ktfPLPkdIRdQ+8IzcWj62xyVyJl5iDN3WlcPuGabJxAc0Gz56iSkZYAiFCYO1EIIs pWSw== X-Gm-Message-State: AOAM533aJNWVE/d9/i05WKgsCcqKfVh28qdQHzul3OjBkAQgUL2rtiJL Rb97koYXtFrMOnnKBiSNo6I= X-Google-Smtp-Source: ABdhPJyss8uyHADZ897AWFj5IbCyv522sLSA2+OXSzk0WePC2r2QwwCl5my3oX7mXoykf8xNYypdqw== X-Received: by 2002:ac8:1288:: with SMTP id y8mr19350789qti.177.1605624290368; Tue, 17 Nov 2020 06:44:50 -0800 (PST) Received: from hurd (dsl-205-236-230-198.b2b2c.ca. [205.236.230.198]) by smtp.gmail.com with ESMTPSA id n125sm10598757qkd.85.2020.11.17.06.44.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2020 06:44:49 -0800 (PST) From: Maxim Cournoyer To: Mathieu Othacehe Subject: Re: bug#44353: [PATCH version-1.2.0 v2] guix: system: Add a new '--non-volatile' option for disk-image. References: <87h7q0cdns.fsf@gnu.org> <20201112070917.11794-1-maxim.cournoyer@gmail.com> <877dqrvums.fsf@gnu.org> <87h7pufwop.fsf@gmail.com> <87r1oyjyhx.fsf@gnu.org> Date: Tue, 17 Nov 2020 09:44:49 -0500 In-Reply-To: <87r1oyjyhx.fsf@gnu.org> (Mathieu Othacehe's message of "Thu, 12 Nov 2020 18:06:34 +0100") Message-ID: <87tutoavq6.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44353 Cc: 44353@debbugs.gnu.org, Jesse Gibbons X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Mathieu, Mathieu Othacehe writes: [...] > When developing the image API, I hesitated keeping the default of using > volatile root file systems by default. > > In most cases, I think that the user may prefer to have non volatile > images. They already have to copy the image from the store and make it > writable so that QEMU can use it with "-hda" argument. > > Switching the default to non volatile could be an option I think. Doing > what you are proposing: setting volatile to false when image-size is > passed could also be a first step. Hi Mathieu! As I mentioned in a reply to Ludovic and based from your feedback I'll make the disk-image produced to be non-volatile by default, with the switch to make them volatile becoming "--volatile". Thanks! Maxim From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 17 13:29:48 2020 Received: (at 44353) by debbugs.gnu.org; 17 Nov 2020 18:29:48 +0000 Received: from localhost ([127.0.0.1]:32908 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kf5jf-0002Se-Mo for submit@debbugs.gnu.org; Tue, 17 Nov 2020 13:29:48 -0500 Received: from mail-qk1-f181.google.com ([209.85.222.181]:38108) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kf5jc-0002SQ-TD for 44353@debbugs.gnu.org; Tue, 17 Nov 2020 13:29:45 -0500 Received: by mail-qk1-f181.google.com with SMTP id 11so21533399qkd.5 for <44353@debbugs.gnu.org>; Tue, 17 Nov 2020 10:29:44 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=e1LMbWa2c68wbNz0SA6sVs7Y0ljq3oLfm8/ZYvQyTsA=; b=k3LmKYMpkWFIx4be3v7gQgasnUDV/aq4l1HDDAHbGuWkNrwx4tpuOVJBx9JpqS22xh j9ZX4Iwyb0RgQeZhaMkndks+P5NMx8JjcoGmZpsGYC3EaPin6h43LFCrOdXG/xMpovXT gG56HqqVnibpkGIcw+khIIjlj6QdirNeeDU11/MkVZFiOTzsR7SQjY9seKCAkzP4yQRH uaU8QCQifEPczjosUGUljIPWqzMTxeI2TLQ1uQDT35mNRN13DDPqyzxVDyDgPEZcwTc9 1lLQA3GCG2OKsezemWQCYDPoEry/LVthn2bJ/q+LtfnLxRev6A1ZXrbr88di6ZWxt5LG ieOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=e1LMbWa2c68wbNz0SA6sVs7Y0ljq3oLfm8/ZYvQyTsA=; b=k4HbzW53+izNHycLfVHjxMMOqBR7I8emaUiOv+vwOehvLl+gjWMyZCwq+W6v9cvMnY RCwo41NhDuSMF5Hwa3IcZjeUHg94RDEy4D71yBjeOOHubBP4gtQNNkTzslhZElavHwuu OwxtJ82/bQK0T/zODuav6K0gucnrz74XHuGsidvb21b3OgonGCLBTTRXUu+W586/F65h ozKNBgd8DCqw3OKtu4tdGgTSjh48WW56dXzhJaf5AXG8fKhQ5L5Q/KvAcYCwBIIjYl65 +iyQR0K20C10CXK1EBCpa7AiG8zblA2ojcQfuyqv6iWP0Csj/rBCC/i71/RNRsIe373q PbgA== X-Gm-Message-State: AOAM530eXr/RWDJsVBpKmzrjAt0rd441D3Ln41LQ3J/QZ7gxi1H0mE94 837zcrzybfVBzWfg/NWH3zQ= X-Google-Smtp-Source: ABdhPJzpmY6dTONkguti/UWkFi4peEZpQPggAh/mU7YIbgWli4yPQraQ3u3nNkBkwtGZ7q+z+bkuew== X-Received: by 2002:a05:620a:882:: with SMTP id b2mr951129qka.118.1605637779265; Tue, 17 Nov 2020 10:29:39 -0800 (PST) Received: from hurd (dsl-205-236-230-198.b2b2c.ca. [205.236.230.198]) by smtp.gmail.com with ESMTPSA id m8sm2739437qkn.41.2020.11.17.10.29.38 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2020 10:29:38 -0800 (PST) From: Maxim Cournoyer To: Mathieu Othacehe Subject: Re: bug#44353: [PATCH version-1.2.0 v2 2/3] bootloader: grub: Skip install-grub-efi when producing a disk image. References: <87h7q0cdns.fsf@gnu.org> <20201112035713.3789-1-maxim.cournoyer@gmail.com> <20201112035713.3789-2-maxim.cournoyer@gmail.com> <87y2j7uftu.fsf@gnu.org> Date: Tue, 17 Nov 2020 13:29:37 -0500 In-Reply-To: <87y2j7uftu.fsf@gnu.org> (Mathieu Othacehe's message of "Thu, 12 Nov 2020 09:42:05 +0100") Message-ID: <875z63albi.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44353 Cc: 44353@debbugs.gnu.org, Jesse Gibbons X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Mathieu Othacehe writes: > Hello Maxim, > >> As introducing bootloader knowledge at the level of the image code is >> undesirable, every bootloader should be adapted to support this fall-back for >> their installation procedure (TODO). > > Or maybe find a way to remove the need to call "bootloader-installer" > when producing a disk-image as we discussed on IRC. I looked into this option, using GPT + a 1 MiB boot partition, hoping to produce a GRUB to put there with grub mkstandalone, but that is too big to fit for the i386-pc format requirements, sadly. Maxim From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 17 13:37:39 2020 Received: (at 44353) by debbugs.gnu.org; 17 Nov 2020 18:37:39 +0000 Received: from localhost ([127.0.0.1]:32921 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kf5rH-0002fp-7E for submit@debbugs.gnu.org; Tue, 17 Nov 2020 13:37:39 -0500 Received: from mail-qv1-f67.google.com ([209.85.219.67]:37610) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kf5rB-0002fZ-OE for 44353@debbugs.gnu.org; Tue, 17 Nov 2020 13:37:37 -0500 Received: by mail-qv1-f67.google.com with SMTP id v20so7918126qvx.4 for <44353@debbugs.gnu.org>; Tue, 17 Nov 2020 10:37:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=TLf2zLI6dFS3GtQd4shyBXqtakrURs4uUwTrXpqTDX4=; b=G8gKpcs9dhMkxAzpWyiaaqvzvC0HNl0iSY4YkIzfOvP74REBq1DL3iMYmWSP8gSUkK iwWgDQTTjHqbRB9NPBA93b0Av3wvBRXqXbPyUdJSiwMFeXNKg4goTA+FAfqziLNGAxM1 1Vd2A6FcNfecAr+M0rmPdk2UnU0j+swB50IKgehziO9zPXZUHh4OyD5PbsVIBVdAVmkn GkXrf0HKovEOGDk6WtDVFuPmbK00dd7Fw7mEkZ+M0A0vicbPJbN8GHOkUzCU8dQXoawd luBjGxaaKfTHN8mO8tembXenwlCaeeKbPPNF5QS+G5i8OKIqGeO3zGPg5M/mgQTjoY/f w/Aw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=TLf2zLI6dFS3GtQd4shyBXqtakrURs4uUwTrXpqTDX4=; b=PUOzK7ZRtEz5lG70Td8Gvd5AyFOvwLB/DKYRLuKIkM7kJ7kXp7LL/i2XB0rwEwCsgJ hpZmHAXdtSQg6EOZ/lMyG5DprCaJJkGKHQYtsyUJuKQZ/oAltX6a0ZUOoveQPu6WLIw0 7gzsEn2CFSzqGQ+R0Fvv+gvwZfAxmYGA2EoBUh/ZxP3OSZlgdIOkSDkBlM9Lp0MN+SSs oCMVJ5AWarlhCQiEe9OwBCz99DLS7rhHAiFr3IvrPfLJZUTgZDcFDaf9V1gc75h3Fpza 7q7MyB+9ZbvS30ei8EX6LIaeSbOADsmERUoIgXppL+8GCQnx3TSGv2JzqZgQaqN9H6dW Q9pg== X-Gm-Message-State: AOAM53214XGrKX3GyxDBZgLJIlucdUep2W+9LYihrNS/WGrYRbjwXJN8 CELt+aGyJ6D07NH/jH3wuXY= X-Google-Smtp-Source: ABdhPJzV5bpCp6yvyroyLFXQ+EnXKtVlQc/IVInDhRhFT7tFSNvU67Y+oLTpGYONzZRuTG+hOXp8gg== X-Received: by 2002:a0c:8143:: with SMTP id 61mr1052270qvc.6.1605638248221; Tue, 17 Nov 2020 10:37:28 -0800 (PST) Received: from hurd (dsl-205-236-230-198.b2b2c.ca. [205.236.230.198]) by smtp.gmail.com with ESMTPSA id 72sm9615166qtg.69.2020.11.17.10.37.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2020 10:37:27 -0800 (PST) From: Maxim Cournoyer To: Mathieu Othacehe Subject: Re: bug#44353: [PATCH version-1.2.0 v2 1/3] image: Remove conflicting user-provided EFI file system. References: <87h7q0cdns.fsf@gnu.org> <20201112035713.3789-1-maxim.cournoyer@gmail.com> <87361fvui4.fsf@gnu.org> Date: Tue, 17 Nov 2020 13:37:26 -0500 In-Reply-To: <87361fvui4.fsf@gnu.org> (Mathieu Othacehe's message of "Thu, 12 Nov 2020 09:39:47 +0100") Message-ID: <871rgrakyh.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44353 Cc: 44353@debbugs.gnu.org, Jesse Gibbons X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello Mathieu! Mathieu Othacehe writes: > Hey Maxim, > >> When the bootloader used is grub-efi-bootloader, an ESP partition and file >> system is already added by the image generator. If a conflicting >> user-provided EFI file system is provided, it will (likely) cause the boot to >> fail, as happens for the lightweight-desktop.tmpl and desktop.tmpl templates >> under gnu/system/examples. > > Nice one. I would just clarify in the commit message that the ESP > partition is added only when the selected image type is "raw". Done, thank you! Thank you! Maxim From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 17 15:21:53 2020 Received: (at 44353-done) by debbugs.gnu.org; 17 Nov 2020 20:21:53 +0000 Received: from localhost ([127.0.0.1]:33040 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kf7U9-0005Ci-0N for submit@debbugs.gnu.org; Tue, 17 Nov 2020 15:21:53 -0500 Received: from mail-qk1-f169.google.com ([209.85.222.169]:39697) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kf7U6-0005CT-Ah for 44353-done@debbugs.gnu.org; Tue, 17 Nov 2020 15:21:51 -0500 Received: by mail-qk1-f169.google.com with SMTP id q22so22039053qkq.6 for <44353-done@debbugs.gnu.org>; Tue, 17 Nov 2020 12:21:50 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=hpgsmq01vpId8tRT++bFUgHDDIykgkSK/kB6ZOebubk=; b=UtZfi1LJoXWKQxQci61ylo233RrRAjNWBwpH2vMa6WKQi9GwPrWDcijz0HMCo8nUP9 VI6gEOcQozzQ18WvjRvuC+Vc1/lLMKEUpRx7xjw3Us15iM6xIX4S6W76K4VEzHtMdhiz IgowKFIS8kCr3SRPGCfm/JhyTpJXVJ/KFukn6M77Am9usqKbrPiHfAwfzhAjmtaK7171 cGYGlZsJ3XAv3GjNa7sVkR+LvNu1I3GWp5zHtMkwiqJpY0kGyCdsDSfNt8vrjqC63WeD D1q2FqhzDvdhpFkuA4nYeBncrgBEOSfChOhFDRhp9NqehtkTH3EzTcQaveolIWsuK2hI EcUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=hpgsmq01vpId8tRT++bFUgHDDIykgkSK/kB6ZOebubk=; b=kmJQm1/Y0WCkQosRZgTT0RBKtZP7dhg2h//xGchjR5pbOm9U0EEfBtIk7OsdYuCjoc pVtWzJAQJ4KqduafOg6CYL5e1wQsSTA4m8UlH+AvykOAGZuixUQMey68tnracac57zs+ 8THQGWjy6QlbVkCSif1jZsRRBT0f8rFCsdOycGmWYvmfmCBavS9ddHs7RmxYAg5FRJe0 0BVk9o1TeN7V94iKgTSipraSp8G/r9e4Oz8Z7BgH/I2dyKOLC47Xi8KWTQrFJ8mFHmA2 tF7LW3QRWrjIfMmuyz6exp+iISyt0h0i72hq99y95uSiYKCifBIc8RWJojXqUHOS/1nU IFLA== X-Gm-Message-State: AOAM530kWBFIegVlKeiSKK6paMkXNcEFkmfe2PKnjLNxgK7EvVFlvY9k j6lkRWK4RT8SmPUiS07sgwA= X-Google-Smtp-Source: ABdhPJzbGvcQSeS37SnOHQVELcBET0sLSi19ZieqgJuV7W2NSSBrZ9Rn9gw3aVm7XsC4eKwIPh3I6g== X-Received: by 2002:a37:588:: with SMTP id 130mr1366154qkf.207.1605644504767; Tue, 17 Nov 2020 12:21:44 -0800 (PST) Received: from hurd (dsl-205-236-230-198.b2b2c.ca. [205.236.230.198]) by smtp.gmail.com with ESMTPSA id r55sm15398005qte.8.2020.11.17.12.21.43 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Nov 2020 12:21:44 -0800 (PST) From: Maxim Cournoyer To: Mathieu Othacehe Subject: Re: bug#44353: [PATCH version-1.2.0 v2] guix: system: Add a new '--non-volatile' option for disk-image. References: <87h7q0cdns.fsf@gnu.org> <20201112070917.11794-1-maxim.cournoyer@gmail.com> <878sb25m6s.fsf@gnu.org> <87o8jxlkot.fsf@gnu.org> <874klpxxch.fsf@gnu.org> <87k0ull91k.fsf@gnu.org> Date: Tue, 17 Nov 2020 15:21:43 -0500 In-Reply-To: <87k0ull91k.fsf@gnu.org> (Mathieu Othacehe's message of "Mon, 16 Nov 2020 14:34:47 +0100") Message-ID: <87wnyj91k8.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44353-done Cc: 44353-done@debbugs.gnu.org, Ludovic =?utf-8?Q?Court=C3=A8s?= , Jesse Gibbons X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hello, Mathieu Othacehe writes: > Hey, > >> Speaking of which, can we remove =E2=80=98system-disk-image-in-vm=E2=80= =99? It has zero >> users now. Done! This series has now been pushed to master. Closing. Thank you, Maxim From unknown Mon Aug 18 11:27:11 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 16 Dec 2020 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator