From unknown Sat Sep 06 05:55:22 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4435: move OTHER_FILES definition from cpp to autoconf (only affects NS) Reply-To: Dan Nicolaescu , 4435@debbugs.gnu.org Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Mon, 14 Sep 2009 19:40:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: report 4435 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.125295669630256 (code B ref -1); Mon, 14 Sep 2009 19:40:05 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 14 Sep 2009 19:31:36 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-5.1 required=4.0 tests=AWL,FOURLA,MURPHY_DRUGS_REL8, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8EJVYw8030249 for ; Mon, 14 Sep 2009 12:31:36 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MnHGw-0006hq-FO for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2009 15:31:34 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MnHGs-0006gi-Vs for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2009 15:31:34 -0400 Received: from [199.232.76.173] (port=52345 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MnHGs-0006gf-Ny for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2009 15:31:30 -0400 Received: from barrelv2.ics.uci.edu ([128.195.1.114]:47426) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1MnHGs-00061f-3d for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2009 15:31:30 -0400 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by barrelv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n8EJTq6D009712 for ; Mon, 14 Sep 2009 12:29:52 -0700 (PDT) Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n8EJTqap023924; Mon, 14 Sep 2009 12:29:52 -0700 (PDT) Date: Mon, 14 Sep 2009 12:29:52 -0700 (PDT) Message-Id: <200909141929.n8EJTqap023924@godzilla.ics.uci.edu> From: Dan Nicolaescu To: bug-gnu-emacs Lines: 69 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n8EJTq6D009712 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) This patch moves OTHER_FILES definition from cpp to autoconf, it only affects NS. [configure and src/config.in need to regenerated] OK to check in? Index: configure.in =================================================================== RCS file: /cvsroot/emacs/emacs/configure.in,v retrieving revision 1.607 diff -u -3 -p -u -p -r1.607 configure.in --- configure.in 23 Aug 2009 02:15:00 -0000 1.607 +++ configure.in 14 Sep 2009 18:46:36 -0000 @@ -2188,6 +2201,7 @@ if test "${HAVE_NS}" = "yes"; then fi # We also have mouse menus. HAVE_MENUS=yes + OTHER_FILES=ns-app fi @@ -2598,6 +2612,7 @@ AC_SUBST(GNUSTEP_SYSTEM_HEADERS) AC_SUBST(GNUSTEP_SYSTEM_LIBRARIES) AC_SUBST(GNU_OBJC_CFLAGS) AC_SUBST(LIB_SRC_EXTRA_INSTALLABLES) +AC_SUBST(OTHER_FILES) AC_DEFINE_UNQUOTED(EMACS_CONFIGURATION, "${canonical}", [Define to the canonical Emacs configuration name.]) @@ -2744,7 +2759,6 @@ AH_BOTTOM([ side does this in s/darwin.h and we cannot parallel this exactly since GNUstep is multi-OS. */ #ifdef HAVE_NS -#define OTHER_FILES ns-app # ifdef NS_IMPL_GNUSTEP /* See also .m.o rule in Makefile.in */ /* FIXME: are all these flags really needed? Document here why. */ Index: Makefile.in =================================================================== RCS file: /cvsroot/emacs/emacs/src/Makefile.in,v retrieving revision 1.446 diff -u -3 -p -u -p -r1.446 Makefile.in --- Makefile.in 26 Aug 2009 08:28:25 -0000 1.446 +++ Makefile.in 14 Sep 2009 19:27:36 -0000 @@ -886,9 +886,3 @@ LIBES = $(LOADLIBES) $(LIBS) $(LIBX) $(L @FREETYPE_LIBS@ @FONTCONFIG_LIBS@ @LIBOTF_LIBS@ @M17N_FLT_LIBS@ \ $(GNULIB_VAR) LIB_MATH LIB_STANDARD $(GNULIB_VAR) -/* Enable recompilation of certain other files depending on system type. */ - -#ifndef OTHER_FILES -#define OTHER_FILES -#endif - @@ -898,11 +889,10 @@ - #ifdef HAVE_SHM RUN_TEMACS = `/bin/pwd`/temacs -nl #else RUN_TEMACS = `/bin/pwd`/temacs #endif -all: emacs${EXEEXT} OTHER_FILES +all: emacs${EXEEXT} @OTHER_FILES@ emacs${EXEEXT}: temacs${EXEEXT} ${etc}DOC ${lisp} ${SOME_MACHINE_LISP} #ifdef CANNOT_DUMP From unknown Sat Sep 06 05:55:22 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4435: move OTHER_FILES definition from cpp to autoconf (only affects NS) Reply-To: Andreas Schwab , 4435@debbugs.gnu.org Resent-From: Andreas Schwab Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Mon, 14 Sep 2009 20:00:03 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 4435 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.12529580551976 (code B ref -1); Mon, 14 Sep 2009 20:00:03 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 14 Sep 2009 19:54:15 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-2.8 required=4.0 tests=AWL,HAS_BUG_NUMBER autolearn=unavailable version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8EJsEsH001971 for ; Mon, 14 Sep 2009 12:54:15 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MnHcr-0007VN-Th for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2009 15:54:13 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MnHcn-0007Ox-BO for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2009 15:54:13 -0400 Received: from [199.232.76.173] (port=46327 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MnHcn-0007Og-7Y for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2009 15:54:09 -0400 Received: from mail-out.m-online.net ([212.18.0.10]:39667) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MnHcm-0001le-On for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2009 15:54:08 -0400 Received: from mail01.m-online.net (mail.m-online.net [192.168.3.149]) by mail-out.m-online.net (Postfix) with ESMTP id A37C81C001CE; Mon, 14 Sep 2009 21:54:04 +0200 (CEST) Received: from localhost (dynscan2.mnet-online.de [192.168.1.215]) by mail.m-online.net (Postfix) with ESMTP id 4E7B690073; Mon, 14 Sep 2009 21:54:04 +0200 (CEST) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.3.149]) by localhost (dynscan2.mnet-online.de [192.168.1.215]) (amavisd-new, port 10024) with ESMTP id JMO1JH-Xyk3F; Mon, 14 Sep 2009 21:54:03 +0200 (CEST) Received: from igel.home (DSL01.83.171.177.104.ip-pool.NEFkom.net [83.171.177.104]) by mail.mnet-online.de (Postfix) with ESMTP; Mon, 14 Sep 2009 21:54:03 +0200 (CEST) Received: by igel.home (Postfix, from userid 501) id B54FA10D97A; Mon, 14 Sep 2009 21:54:01 +0200 (CEST) From: Andreas Schwab To: Dan Nicolaescu Cc: 4435@debbugs.gnu.org, bug-gnu-emacs References: <200909141929.n8EJTqap023924@godzilla.ics.uci.edu> X-Yow: I just remembered something about a TOAD! Date: Mon, 14 Sep 2009 21:54:01 +0200 In-Reply-To: <200909141929.n8EJTqap023924@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Mon, 14 Sep 2009 12:29:52 -0700 (PDT)") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) Dan Nicolaescu writes: > -all: emacs${EXEEXT} OTHER_FILES > +all: emacs${EXEEXT} @OTHER_FILES@ Please define a variable with the substituted value and refer to it here instead. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 58CA 54C7 6D53 942B 1756 01D3 44D5 214B 8276 4ED5 "And now for something completely different." From unknown Sat Sep 06 05:55:22 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4435: move OTHER_FILES definition from cpp to autoconf (only affects NS) Reply-To: Dan Nicolaescu , 4435@debbugs.gnu.org Resent-From: Dan Nicolaescu Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Mon, 14 Sep 2009 20:45:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 4435 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by 4435-submit@emacsbugs.donarmstrong.com id=B4435.125296053610567 (code B ref 4435); Mon, 14 Sep 2009 20:45:05 +0000 Received: (at 4435) by emacsbugs.donarmstrong.com; 14 Sep 2009 20:35:36 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-6.6 required=4.0 tests=AWL,HAS_BUG_NUMBER, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from sallyv2.ics.uci.edu (sallyv2.ics.uci.edu [128.195.1.120]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8EKZZw6010564 for <4435@emacsbugs.donarmstrong.com>; Mon, 14 Sep 2009 13:35:36 -0700 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by sallyv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n8EKZNZC000978; Mon, 14 Sep 2009 13:35:23 -0700 (PDT) Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n8EKZNKM024377; Mon, 14 Sep 2009 13:35:23 -0700 (PDT) Date: Mon, 14 Sep 2009 13:35:23 -0700 (PDT) Message-Id: <200909142035.n8EKZNKM024377@godzilla.ics.uci.edu> From: Dan Nicolaescu To: Andreas Schwab Cc: 4435@debbugs.gnu.org References: <200909141929.n8EJTqap023924@godzilla.ics.uci.edu> In-Reply-To: (Andreas Schwab's message of "Mon, 14 Sep 2009 21:54:01 +0200") Lines: 12 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n8EKZNZC000978 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu Andreas Schwab writes: > Dan Nicolaescu writes: > > > -all: emacs${EXEEXT} OTHER_FILES > > +all: emacs${EXEEXT} @OTHER_FILES@ > > Please define a variable with the substituted value and refer to it here > instead. Sure. OK, with that change? From unknown Sat Sep 06 05:55:22 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4435: move OTHER_FILES definition from cpp to autoconf (only affects NS) Reply-To: Stefan Monnier , 4435@debbugs.gnu.org Resent-From: Stefan Monnier Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Mon, 14 Sep 2009 22:10:04 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: followup 4435 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.125296569926596 (code B ref -1); Mon, 14 Sep 2009 22:10:04 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 14 Sep 2009 22:01:39 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-4.2 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8 autolearn=unavailable version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8EM1bOA026593 for ; Mon, 14 Sep 2009 15:01:38 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MnJc9-000257-G6 for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2009 18:01:37 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MnJc4-0001pV-Ka for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2009 18:01:36 -0400 Received: from [199.232.76.173] (port=52317 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MnJc4-0001pK-H7 for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2009 18:01:32 -0400 Received: from pruche.dit.umontreal.ca ([132.204.246.22]:52385) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1MnJc4-0001Ew-0G for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2009 18:01:32 -0400 Received: from faina.iro.umontreal.ca (faina.iro.umontreal.ca [132.204.26.177]) by pruche.dit.umontreal.ca (8.14.1/8.14.1) with ESMTP id n8EM1SnI017142; Mon, 14 Sep 2009 18:01:28 -0400 Received: by faina.iro.umontreal.ca (Postfix, from userid 20848) id AB33A3A28A; Mon, 14 Sep 2009 18:01:28 -0400 (EDT) From: Stefan Monnier To: Dan Nicolaescu Cc: 4435@debbugs.gnu.org, bug-gnu-emacs Message-ID: References: <200909141929.n8EJTqap023924@godzilla.ics.uci.edu> Date: Mon, 14 Sep 2009 18:01:28 -0400 In-Reply-To: <200909141929.n8EJTqap023924@godzilla.ics.uci.edu> (Dan Nicolaescu's message of "Mon, 14 Sep 2009 12:29:52 -0700 (PDT)") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-NAI-Spam-Score: 0 X-NAI-Spam-Rules: 1 Rules triggered RV3362=0 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) > This patch moves OTHER_FILES definition from cpp to autoconf, it only > affects NS. [configure and src/config.in need to regenerated] > OK to check in? Yes, please, thank you. Stefan From unknown Sat Sep 06 05:55:22 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.427 (Entity 5.427) X-Loop: owner@emacsbugs.donarmstrong.com From: help-debbugs@gnu.org (Emacs bug Tracking System) To: Dan Nicolaescu Subject: bug#4435 closed by Dan Nicolaescu (Re: bug#4435: move OTHER_FILES definition from cpp to autoconf (only affects NS)) Message-ID: References: <200909170615.n8H6FaUi020695@godzilla.ics.uci.edu> <200909141929.n8EJTqap023924@godzilla.ics.uci.edu> X-Emacs-PR-Message: they-closed 4435 X-Emacs-PR-Package: emacs Reply-To: 4435@debbugs.gnu.org Date: Thu, 17 Sep 2009 06:25:11 +0000 Content-Type: multipart/mixed; boundary="----------=_1253168711-16189-1" This is a multi-part message in MIME format... ------------=_1253168711-16189-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" This is an automatic notification regarding your bug report which was filed against the emacs package: #4435: move OTHER_FILES definition from cpp to autoconf (only affects NS) It has been closed by Dan Nicolaescu . Their explanation is attached below along with your original report. If this explanation is unsatisfactory and you have not received a better one in a separate message then please contact Dan Nicolaescu by replying to this email. --=20 4435: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D4435 Emacs Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1253168711-16189-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 4435-done) by emacsbugs.donarmstrong.com; 17 Sep 2009 06:15:50 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-6.6 required=4.0 tests=AWL,HAS_BUG_NUMBER, MURPHY_DRUGS_REL8,X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from barrelv2.ics.uci.edu (barrelv2.ics.uci.edu [128.195.1.114]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8H6Fneb014910 for <4435-done@emacsbugs.donarmstrong.com>; Wed, 16 Sep 2009 23:15:50 -0700 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by barrelv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n8H6FbUD002608; Wed, 16 Sep 2009 23:15:37 -0700 (PDT) Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n8H6FaUi020695; Wed, 16 Sep 2009 23:15:36 -0700 (PDT) Date: Wed, 16 Sep 2009 23:15:36 -0700 (PDT) Message-Id: <200909170615.n8H6FaUi020695@godzilla.ics.uci.edu> From: Dan Nicolaescu To: Stefan Monnier Cc: 4435-done@debbugs.gnu.org Subject: Re: bug#4435: move OTHER_FILES definition from cpp to autoconf (only affects NS) References: <200909141929.n8EJTqap023924@godzilla.ics.uci.edu> X-Debbugs-No-Ack: yes In-Reply-To: (Stefan Monnier's message of "Mon, 14 Sep 2009 18:01:28 -0400") Lines: 10 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n8H6FbUD002608 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu Stefan Monnier writes: > > This patch moves OTHER_FILES definition from cpp to autoconf, it only > > affects NS. [configure and src/config.in need to regenerated] > > > OK to check in? > > Yes, please, thank you. Thanks. Done. ------------=_1253168711-16189-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by emacsbugs.donarmstrong.com; 14 Sep 2009 19:31:36 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-5.1 required=4.0 tests=AWL,FOURLA,MURPHY_DRUGS_REL8, X_DEBBUGS_NO_ACK autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8EJVYw8030249 for ; Mon, 14 Sep 2009 12:31:36 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MnHGw-0006hq-FO for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2009 15:31:34 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MnHGs-0006gi-Vs for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2009 15:31:34 -0400 Received: from [199.232.76.173] (port=52345 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MnHGs-0006gf-Ny for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2009 15:31:30 -0400 Received: from barrelv2.ics.uci.edu ([128.195.1.114]:47426) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_3DES_EDE_CBC_SHA1:24) (Exim 4.60) (envelope-from ) id 1MnHGs-00061f-3d for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2009 15:31:30 -0400 Received: from godzilla.ics.uci.edu (godzilla.ics.uci.edu [128.195.10.101]) by barrelv2.ics.uci.edu (8.13.8+Sun/8.13.8) with ESMTP id n8EJTq6D009712 for ; Mon, 14 Sep 2009 12:29:52 -0700 (PDT) Received: (from dann@localhost) by godzilla.ics.uci.edu (8.13.8+Sun/8.13.6/Submit) id n8EJTqap023924; Mon, 14 Sep 2009 12:29:52 -0700 (PDT) Date: Mon, 14 Sep 2009 12:29:52 -0700 (PDT) Message-Id: <200909141929.n8EJTqap023924@godzilla.ics.uci.edu> From: Dan Nicolaescu To: bug-gnu-emacs Subject: move OTHER_FILES definition from cpp to autoconf (only affects NS) X-Debbugs-No-Ack: yes Lines: 69 MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-ICS-MailScanner-Information: Please contact the ISP for more information X-ICS-MailScanner-ID: n8EJTq6D009712 X-ICS-MailScanner: Found to be clean X-ICS-MailScanner-SpamCheck: not spam, SpamAssassin (score=-1.44, required 5, autolearn=disabled, ALL_TRUSTED -1.44) X-ICS-MailScanner-From: dann@godzilla.ics.uci.edu X-detected-operating-system: by monty-python.gnu.org: Solaris 10 (beta) This patch moves OTHER_FILES definition from cpp to autoconf, it only affects NS. [configure and src/config.in need to regenerated] OK to check in? Index: configure.in =================================================================== RCS file: /cvsroot/emacs/emacs/configure.in,v retrieving revision 1.607 diff -u -3 -p -u -p -r1.607 configure.in --- configure.in 23 Aug 2009 02:15:00 -0000 1.607 +++ configure.in 14 Sep 2009 18:46:36 -0000 @@ -2188,6 +2201,7 @@ if test "${HAVE_NS}" = "yes"; then fi # We also have mouse menus. HAVE_MENUS=yes + OTHER_FILES=ns-app fi @@ -2598,6 +2612,7 @@ AC_SUBST(GNUSTEP_SYSTEM_HEADERS) AC_SUBST(GNUSTEP_SYSTEM_LIBRARIES) AC_SUBST(GNU_OBJC_CFLAGS) AC_SUBST(LIB_SRC_EXTRA_INSTALLABLES) +AC_SUBST(OTHER_FILES) AC_DEFINE_UNQUOTED(EMACS_CONFIGURATION, "${canonical}", [Define to the canonical Emacs configuration name.]) @@ -2744,7 +2759,6 @@ AH_BOTTOM([ side does this in s/darwin.h and we cannot parallel this exactly since GNUstep is multi-OS. */ #ifdef HAVE_NS -#define OTHER_FILES ns-app # ifdef NS_IMPL_GNUSTEP /* See also .m.o rule in Makefile.in */ /* FIXME: are all these flags really needed? Document here why. */ Index: Makefile.in =================================================================== RCS file: /cvsroot/emacs/emacs/src/Makefile.in,v retrieving revision 1.446 diff -u -3 -p -u -p -r1.446 Makefile.in --- Makefile.in 26 Aug 2009 08:28:25 -0000 1.446 +++ Makefile.in 14 Sep 2009 19:27:36 -0000 @@ -886,9 +886,3 @@ LIBES = $(LOADLIBES) $(LIBS) $(LIBX) $(L @FREETYPE_LIBS@ @FONTCONFIG_LIBS@ @LIBOTF_LIBS@ @M17N_FLT_LIBS@ \ $(GNULIB_VAR) LIB_MATH LIB_STANDARD $(GNULIB_VAR) -/* Enable recompilation of certain other files depending on system type. */ - -#ifndef OTHER_FILES -#define OTHER_FILES -#endif - @@ -898,11 +889,10 @@ - #ifdef HAVE_SHM RUN_TEMACS = `/bin/pwd`/temacs -nl #else RUN_TEMACS = `/bin/pwd`/temacs #endif -all: emacs${EXEEXT} OTHER_FILES +all: emacs${EXEEXT} @OTHER_FILES@ emacs${EXEEXT}: temacs${EXEEXT} ${etc}DOC ${lisp} ${SOME_MACHINE_LISP} #ifdef CANNOT_DUMP ------------=_1253168711-16189-1--