From unknown Sat Jun 14 19:28:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44343: 28.0.50; wdired: spurious error message when changing permissions Resent-From: Michael Heerdegen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 31 Oct 2020 14:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 44343 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 44343@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.160415510928046 (code B ref -1); Sat, 31 Oct 2020 14:39:02 +0000 Received: (at submit) by debbugs.gnu.org; 31 Oct 2020 14:38:29 +0000 Received: from localhost ([127.0.0.1]:34185 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYs1V-0007II-84 for submit@debbugs.gnu.org; Sat, 31 Oct 2020 10:38:29 -0400 Received: from lists.gnu.org ([209.51.188.17]:36354) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYs1R-0007I9-Cx for submit@debbugs.gnu.org; Sat, 31 Oct 2020 10:38:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58768) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYs1R-0003ZX-5W for bug-gnu-emacs@gnu.org; Sat, 31 Oct 2020 10:38:25 -0400 Received: from mout.web.de ([212.227.15.3]:43869) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYs1P-0002Xo-7j for bug-gnu-emacs@gnu.org; Sat, 31 Oct 2020 10:38:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1604155099; bh=mRm++1bohLWhTT725X15Rf16jkEVOia8CceQ8hbA5gk=; h=X-UI-Sender-Class:From:To:Subject:Date; b=RxUQET1Y2RsMpXUFdLmjBoZ0VxMWTFszyUSqV5g77hk84z4wvoeJtj9qoK8eDXF+t M1WVjBjeI0lVuJ3KKZOalIrmgikrnShjOQ4rfYcwOMGjadTD99QJ+fmgDnJBnC7W2G cn6ct+n3Cdj5NqFRLdnEI4BuI/LK+uSUQTrVGgoE= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from drachen.dragon ([188.98.110.121]) by smtp.web.de (mrweb003 [213.165.67.108]) with ESMTPSA (Nemesis) id 0LshXV-1kNdha0GAz-012EXR for ; Sat, 31 Oct 2020 15:38:19 +0100 From: Michael Heerdegen Date: Sat, 31 Oct 2020 15:38:18 +0100 Message-ID: <87pn4ycvfp.fsf@web.de> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:l73k7h93c4NigcFRSPOzQ1j/3rn2QnQQK6lIjb+awQ9vWxeVT8v KdehzDVUFgt9YfcfsRJYhGk7HGrZnLa8f5BRjA94RcPi1LjffqA44SxKU094qy0k/CmiMmV kJkQgjw2FgwZqyg/QAq7h2VL9UYzxJGon+BqTcEjg/zq3DrYLJiXLjx4cIvGj+md8E42X5C kaz30SEzLr4sdqlh7iw+g== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:xp8zXnnzuco=:ZAH5WDr+9H1Od0Ll8MzYIw 5Va50mJ5Y3sCroow/aH1ZEIeC3b8lYXQfbw2MJ82qBdpaycpC4AzlhmuW+tfCzJCWIAamXpz/ eYrDZ8aN6So2E1ipRdkSKENE+z49rHJcuIJOcfFXASe5zZBqvGtlyFdHLe9ifCvcuiZ3DWWDr ot5BMZJSrUWHabigBsU1dhm+pJMXQ4fpfYeQqAoExx7zFa6XW70x+IJa3YyiWNw8k30NXGN76 DmUcQim55E7001tsAOvtmw50A/SIjmIAuJ+8b25Wi1Ljb88pR14X1Bldctfs8OgoTVD/poSnw YLFNIFEKtzL5B1AotndwctWP5QmBxHbiTR0T4RDX7tD0k6Wb/bnm0SAi3mJNPdsryDkXUU6SA 3TVmViZ4bRWS3/TV+qR2FMOgwEQTVZdpRcHT/PP45weLH/WtcLM659VmRpy+TTbCTM6dvzdDf Jg8zI0nIiWKUE5+7G9ufKsrSmny/Whos5C0zdmVUcyythBrut0RcoZ464seB9T91K5v6HWups KEHruA/HwxDiyOOCVmzti2HiEoKVtWZvD99V9VEGCLwSHaxFAkl3l68x7/prvt9F/tzAiR8hi Z72HqEt7jJHDtMP1IIRRcfB+dUd+ITqAggrAIR/DQD49W1EiI5H83UdMMEjYlN6ayINfTKOU7 8OFMLWahfIEwT0BRlddcBVE6omyFXj8g5sYAJDIQTsYPPjDAl5v0DcdqK/5V/F6b+weURoUnD wNomvwV8BY2oiTfgKpMJetO57o0K+EA/4ZDp/zmH+mQrwa1K+7qAfO2Afs+IBV5wK9ZWTwrf+ DppbR9/VNxRuxZJoXouq76Tdq0V2WmhvVHB7KlrYy/LRH34fKaaAH2+Mt0CnfhOfBrxaLTUbL v82BxCEx0w7nk9t4Q3FnPIGLU5/KarkbKxk2WiaLc= Received-SPF: pass client-ip=212.227.15.3; envelope-from=michael_heerdegen@web.de; helo=mout.web.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/31 10:38:19 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.6 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Hello, here is the recipe: #+begin_src emacs-lisp (require 'wdired) (setq wdired-allow-to-change-permissions 'advanced) #+end_src Then visit some (writable) directory with dired, M-x wdired-change-to-wdired-mode, and then change a permission bit of some file. Then C-c C-c. I get this error message: 1 rename actions failed--type ? for details *Dired log* contains: | chmod 416 =E2=80=98/home/micha/arena.result=E2=80=99 failed |=20=20 | 1 rename actions failed Actually there is no need for the error message; changing permission bits works fine, it succeeds without problems. But when I read the implementation of `wdired-do-perm-changes' correctly, it uses the return value of `set-file-modes' to decide whether setting modes succeeded. This function always returns nil, however. The second, minor issue is that a problem with changing permission bits is reported as a failed "rename action". TIA, Michael. In GNU Emacs 28.0.50 (build 85, x86_64-pc-linux-gnu, GTK+ Version 3.24.23, = cairo version 1.16.0) of 2020-10-31 built on drachen Repository revision: f9304de9e09ae621e8790b4f45ab716c43485ce9 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12008000 System Description: Debian GNU/Linux bullseye/sid From unknown Sat Jun 14 19:28:47 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44343: 28.0.50; wdired: spurious error message when changing permissions Resent-From: Andreas Schwab Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sat, 31 Oct 2020 15:46:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44343 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Michael Heerdegen Cc: 44343@debbugs.gnu.org Received: via spool by 44343-submit@debbugs.gnu.org id=B44343.16041591582173 (code B ref 44343); Sat, 31 Oct 2020 15:46:02 +0000 Received: (at 44343) by debbugs.gnu.org; 31 Oct 2020 15:45:58 +0000 Received: from localhost ([127.0.0.1]:34316 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYt4n-0000Yy-Ni for submit@debbugs.gnu.org; Sat, 31 Oct 2020 11:45:57 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:47018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYt4k-0000Yl-9h for 44343@debbugs.gnu.org; Sat, 31 Oct 2020 11:45:57 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4CNk6R5WJTz1qrfg; Sat, 31 Oct 2020 16:45:51 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4CNk6R3qq4z1qyXd; Sat, 31 Oct 2020 16:45:51 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id kyl0RmYFeeXj; Sat, 31 Oct 2020 16:45:50 +0100 (CET) X-Auth-Info: sExQK4QEYFAcJ0cKlRSuwGC1Lh+1oMVYFwZVi0YSdOdGCvgxbz9wloOjkre7Voyo Received: from igel.home (ppp-46-244-181-86.dynamic.mnet-online.de [46.244.181.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA; Sat, 31 Oct 2020 16:45:50 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id 26AA02C0944; Sat, 31 Oct 2020 16:45:50 +0100 (CET) From: Andreas Schwab References: <87pn4ycvfp.fsf@web.de> Date: Sat, 31 Oct 2020 16:45:50 +0100 In-Reply-To: <87pn4ycvfp.fsf@web.de> (Michael Heerdegen's message of "Sat, 31 Oct 2020 15:38:18 +0100") Message-ID: <87h7qa1jrl.fsf@igel.home> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.4 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) On Okt 31 2020, Michael Heerdegen wrote: > But when I read the implementation of `wdired-do-perm-changes' > correctly, it uses the return value of `set-file-modes' to decide > whether setting modes succeeded. This function always returns nil, > however. Right, it reports failures via error. > The second, minor issue is that a problem with changing permission bits > is reported as a failed "rename action". I have removed "rename" from the message, since wdired can already perform three different types of actions. Andreas. -- Andreas Schwab, schwab@linux-m68k.org GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510 2552 DF73 E780 A9DA AEC1 "And now for something completely different." From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 31 11:46:02 2020 Received: (at control) by debbugs.gnu.org; 31 Oct 2020 15:46:02 +0000 Received: from localhost ([127.0.0.1]:34319 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYt4r-0000ZK-Va for submit@debbugs.gnu.org; Sat, 31 Oct 2020 11:46:02 -0400 Received: from mail-out.m-online.net ([212.18.0.9]:53674) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYt4p-0000Z7-7m for control@debbugs.gnu.org; Sat, 31 Oct 2020 11:45:59 -0400 Received: from frontend01.mail.m-online.net (unknown [192.168.8.182]) by mail-out.m-online.net (Postfix) with ESMTP id 4CNk6Z520bz1qrfg for ; Sat, 31 Oct 2020 16:45:58 +0100 (CET) Received: from localhost (dynscan1.mnet-online.de [192.168.6.70]) by mail.m-online.net (Postfix) with ESMTP id 4CNk6Z4wnDz1qyXd for ; Sat, 31 Oct 2020 16:45:58 +0100 (CET) X-Virus-Scanned: amavisd-new at mnet-online.de Received: from mail.mnet-online.de ([192.168.8.182]) by localhost (dynscan1.mail.m-online.net [192.168.6.70]) (amavisd-new, port 10024) with ESMTP id 9yayi6vnQRyM for ; Sat, 31 Oct 2020 16:45:58 +0100 (CET) X-Auth-Info: tbofNScq63fgYCuLiv/YwqMXTq8HQuZ5iQBEESVKuhvVSO6/45MoptCcuvZmRgMX Received: from igel.home (ppp-46-244-181-86.dynamic.mnet-online.de [46.244.181.86]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.mnet-online.de (Postfix) with ESMTPSA for ; Sat, 31 Oct 2020 16:45:58 +0100 (CET) Received: by igel.home (Postfix, from userid 1000) id C8B2C2C0944; Sat, 31 Oct 2020 16:45:57 +0100 (CET) To: control@debbugs.gnu.org From: Andreas Schwab Subject: control message for bug #44343 Message-Id: <20201031154557.C8B2C2C0944@igel.home> Date: Sat, 31 Oct 2020 16:45:57 +0100 (CET) X-Spam-Score: -0.4 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.4 (-) tags 44343 fixed close 44343 28.1 quit