GNU bug report logs - #44342
[PATCH 0/6] Update rtags and add rtags related emacs packages.

Previous Next

Package: guix-patches;

Reported by: Malte Frank Gerdes <malte.f.gerdes <at> gmail.com>

Date: Sat, 31 Oct 2020 14:08:02 UTC

Severity: normal

Tags: patch

Full log

View this message in rfc822 format

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Malte Frank Gerdes <malte.f.gerdes <at> gmail.com>
Cc: 44342 <at> debbugs.gnu.org
Subject: [bug#44342] [PATCH 2/6] gnu: cpp: Update rct to e706998697b8d48fa9e5b9ab33aeded705129a66.
Date: Sat, 07 Nov 2020 11:03:27 +0100

Hello,

Malte Frank Gerdes <malte.f.gerdes <at> gmail.com> writes:

> * gnu/packages/cpp.scm (rct): Update variable.
> * gnu/packages/patches/rct-add-missing-headers.patch: Adjust
> accordingly.

Thank you.

> -  (let* ((commit "b3e6f41d9844ef64420e628e0c65ed98278a843a")
> -         (revision "2"))
> +  (let* ((commit "e706998697b8d48fa9e5b9ab33aeded705129a66")
> +         (revision "0"))

Why are you resetting revision here? This is going to break version
comparison, isn't it?

Otherwise, LGTM.

Regards,
-- 
Nicolas Goaziou
This bug report was last modified 4 years and 219 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.