GNU bug report logs - #44341
27.1; define-minor-mode generates inaccurate docstring

Previous Next

Package: emacs;

Reported by: Thibault Polge <thibault <at> thb.lt>

Date: Sat, 31 Oct 2020 11:01:02 UTC

Severity: normal

Tags: fixed

Found in version 27.1

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log

Message #18 received at 44341 <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 44341 <at> debbugs.gnu.org, Thibault Polge <thibault <at> thb.lt>
Subject: Re: bug#44341: 27.1; define-minor-mode generates inaccurate docstring
Date: Mon, 2 Nov 2020 13:28:06 +0100

Am So., 1. Nov. 2020 um 16:30 Uhr schrieb Stefan Monnier
<monnier <at> iro.umontreal.ca>:

> >     disable ; Should disable (as a random symbol)
> >     disable ; Again
> >     "What?" ; Same.
>
> These should be considered as errors.  Whether we catch them and signal
> an error or silently do something else is not particular important
> to me.

We should definitely signal an error here. A form such as (my-mode
'enable) actually disabling the mode is very confusing. The mode
function needs to check for the various cases anyway, it might as well
use `cond' and signal an error in the non-matching case.
This bug report was last modified 4 years and 293 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.