GNU bug report logs - #44333
27.1; macOS menu bar 2-clicks

Previous Next

Package: emacs;

Reported by: Viktor Kharitonovich <viktor.kharitonovich <at> gmail.com>

Date: Fri, 30 Oct 2020 17:58:02 UTC

Severity: normal

Merged with 24719, 32864, 34213

Found in versions 26.0.50, 26.1, 27.0.50, 27.1

Done: Alan Third <alan <at> idiocy.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Mattias Engdegård <mattiase <at> acm.org>
To: Alan Third <alan <at> idiocy.org>
Cc: 44333 <at> debbugs.gnu.org, Viktor Kharitonovich <viktor.kharitonovich <at> gmail.com>
Subject: bug#44333: 27.1; macOS menu bar 2-clicks 
Date: Sun, 27 Dec 2020 18:14:25 +0100
[Message part 1 (text/plain, inline)]
26 dec. 2020 kl. 22.52 skrev Alan Third <alan <at> idiocy.org>:

> It's actually almost possible to copy the Mac port code in verbatim,
> the NS port's code is based on it after all, but I feel it may be
> neater to use a custom view for the NSMenuItems. That would give us
> complete control over the layout.

We should, but because I was lazy and impatient, I wrote the attached (terrible) hack just to see what right-justification would look like.

The right margin is slightly ragged because I'm using plain spaces to offset the key binding from the menu text, but I still think it's better than what we have now. I tried using U+2009 THIN SPACE and even U+200A HAIR SPACE instead but somehow the result became worse; no doubt a silly mistake somewhere.

I also removed the special hack for s- bindings because it broke the nice alignment. If we want, we could translate modifiers into the standard symbols (⌘, ⌃, ⇧ and ⌥) depending on these are assigned, or just keep using the Emacs notation. We could also translate <right> into → and so on.

[right-justify-keys.diff (application/octet-stream, attachment)]

This bug report was last modified 4 years and 144 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.