GNU bug report logs - #44331
28.0.50; Customize won't save a face setting, if not set first

Previous Next

Package: emacs;

Reported by: Mauro Aranda <maurooaranda <at> gmail.com>

Date: Fri, 30 Oct 2020 15:56:01 UTC

Severity: normal

Tags: fixed, patch

Found in version 28.0.50

Done: Mauro Aranda <maurooaranda <at> gmail.com>

Bug is archived. No further changes may be made.

Full log

Message #8 received at 44331 <at> debbugs.gnu.org (full text, mbox):

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: 44331 <at> debbugs.gnu.org
Subject: Re: bug#44331: 28.0.50; Customize won't save a face setting, if not
 set first
Date: Fri, 30 Oct 2020 13:23:06 -0300

[Message part 1 (text/plain, inline)]
tags 44331 patch
quit

Looks like this was introduced in the fix for Bug#40866.  When only
customizing for the selected terminal, now we recreate the custom-face
widget for all kind of displays, but lose the user editions in the
process of doing that.

The attached patch fixes it, because it records the edited value in
the :shown-value property, which a custom widget prioritizes over
everything else, when finding out the value of the face.

[Message part 2 (text/html, inline)]
[0001-Fix-saving-a-face-setting-with-Customize.patch (text/x-patch, attachment)]
This bug report was last modified 4 years and 224 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.