From unknown Sun Jun 22 00:08:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44331: 28.0.50; Customize won't save a face setting, if not set first Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Oct 2020 15:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 44331 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 44331@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs Received: via spool by submit@debbugs.gnu.org id=B.160407334123261 (code B ref -1); Fri, 30 Oct 2020 15:56:01 +0000 Received: (at submit) by debbugs.gnu.org; 30 Oct 2020 15:55:41 +0000 Received: from localhost ([127.0.0.1]:59371 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYWkf-000637-44 for submit@debbugs.gnu.org; Fri, 30 Oct 2020 11:55:41 -0400 Received: from lists.gnu.org ([209.51.188.17]:59458) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYWkc-00062y-HI for submit@debbugs.gnu.org; Fri, 30 Oct 2020 11:55:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:42928) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYWkc-0006mf-8N for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 11:55:38 -0400 Received: from mail-wm1-x330.google.com ([2a00:1450:4864:20::330]:56316) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kYWkY-0004SA-41 for bug-gnu-emacs@gnu.org; Fri, 30 Oct 2020 11:55:37 -0400 Received: by mail-wm1-x330.google.com with SMTP id c9so1758871wml.5 for ; Fri, 30 Oct 2020 08:55:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=kbPEUzCNw75CRfzhBV92qtQjJmMM0XtdAvL+oTryd4s=; b=RxlfiQBfPmMsLwHf2PaSkXLCh0nHCgQW42rEHS+TJnf8EUESIOeMEizoycrqNbo22z QqzuejJXkJsfzkQT+j0/iS6cN0jCKmju56mwOJfzVL/a0LxWUij/KckmmEepB+hqhL/8 sONnG146iVw5OQ+ZcXpz7TdhTkj8ut2iOqZTNzob6UezMZKW8gmZMoXxK35fZ1ZQA3G5 m2MUjq+qP0hh4oNKvoCB6BvC+sm1Q2zyZE8CJl6smMuCa9V+6m/st/LlBjk8QG9q6fWe 9EWqKzUQdqhIbqPTztkj17HFT2slBYbidXIeOUVw6RqXiokhxyu0XcQp6Pd3DrAyva05 X6OA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=kbPEUzCNw75CRfzhBV92qtQjJmMM0XtdAvL+oTryd4s=; b=q/ZW+uZ1cJfEIpUfImBg7kzhrNyoo5HErCYQZM9hvJHkiXllMjZQs2SbMnCnhRJLvx pE8FMpVYXhDW6o9qlfRuVs1xi1fLDdmbmFIoR2UJlj9CH0FUF30yKXLEPxt0+3h6z2Yt nnvp6ZWOgi0sg9EnZcirykwanqYDl651o4DfI+cY4pWSoSDbk0eOl/7iU6KYIAVbPcZV Rdj4wP/pc40p2+IzMcZVty2dK68KrBK5TZp/EL+FVyj/dkI/2m2bpP2O5QEiefv8kVWX GpfJFQo1lXD1NA5UyiPVmX4hL6ewn6vA8EGkP0fpAnPSSupuH5nMSzT9IuicQ1K0r/hd VIBg== X-Gm-Message-State: AOAM530ZldtkVnu5KDCBige/AhP+pmYZbZ8dn+eX+cpJ23ZFA1F6kHcQ bKGB7846Mn2AVoJAY//RplIGAjUR/uhJpPDhkupvidGC3RI= X-Google-Smtp-Source: ABdhPJwe0qPGsmnrKOxNcWtsU2P7ZiUT3Zght59SbmSo/wBXLmD2vXGVtss8kWR9BXBhzWQ0kyZtzWp5HquOKawgAL8= X-Received: by 2002:a1c:20c6:: with SMTP id g189mr3572328wmg.6.1604073331682; Fri, 30 Oct 2020 08:55:31 -0700 (PDT) MIME-Version: 1.0 From: Mauro Aranda Date: Fri, 30 Oct 2020 12:55:18 -0300 Message-ID: Content-Type: multipart/alternative; boundary="00000000000020f27805b2e56d03" Received-SPF: pass client-ip=2a00:1450:4864:20::330; envelope-from=maurooaranda@gmail.com; helo=mail-wm1-x330.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -20 X-Spam_score: -2.1 X-Spam_bar: -- X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, HTML_MESSAGE=0.001, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --00000000000020f27805b2e56d03 Content-Type: text/plain; charset="UTF-8" Since this is about saving a Custom setting, it is not reproducible without emacs -Q. So, before following the recipe, make sure you backup your custom-file, or at least make sure it doesn't have any face settings for the face you choose to customize. If possible, use a face you don't have customized under a theme, or something like that. I'll use the error face for my recipe: Start emacs M-x customize-face RET error I see that the state is STANDARD, and the foreground is Red1. Then change foreground to some color, like orange. In the State button, choose "Save for Future Sessions". Don't choose "Set for Current Session", because that way there's no bug. Now Save For Future Sessions should *set* the setting, and save it into the custom file. I see that the state says THEMED, which I don't think is right: it should say SAVED and SET. There is no theme (other than the user theme) that is customizing the error face in this session. I see that the foreground value came back to being Red1. So, it didn't set the face. I get a message that says "Wrote /path/to/custom-file" C-x C-f "/path/to/custom-file" And when I look at the custom-set-faces entry, I see no setting at all. If in another session, I choose "Set for Current Session" and then "Save for Future Sessions", Customize saves the setting just fine. In GNU Emacs 28.0.50 (build 10, x86_64-pc-linux-gnu, cairo version 1.15.10) of 2020-10-30 built on tbb-desktop Repository revision: 0d8c6df6c1f5e1150b34d4a57acee25471b47340 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12008000 System Description: Ubuntu 18.04.5 LTS Configured using: 'configure --with-x-toolkit=no' Configured features: XPM JPEG TIFF GIF PNG CAIRO SOUND DBUS GSETTINGS GLIB NOTIFY INOTIFY LIBSELINUX GNUTLS LIBXML2 FREETYPE HARFBUZZ ZLIB OLDXMENU X11 XDBE XIM MODULES THREADS PDUMPER Important settings: value of $LC_MONETARY: es_AR.UTF-8 value of $LC_NUMERIC: es_AR.UTF-8 value of $LC_TIME: es_AR.UTF-8 value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: Custom Minor modes in effect: global-ede-mode: t tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow mail-extr emacsbug message rmc puny rfc822 mml mml-sec epa epg epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail color help-mode crm cus-edit emms-librefm-stream emms-librefm-scrobbler emms-playlist-limit emms-volume emms-volume-mixerctl emms-volume-pulse emms-volume-amixer emms-i18n emms-history emms-score emms-stream-info emms-metaplaylist-mode emms-bookmarks emms-cue emms-mode-line-icon emms-browser sort emms-playlist-sort emms-last-played emms-player-xine emms-player-mpd tq emms-playing-time emms-lyrics emms-url emms-streams emms-show-all emms-tag-editor emms-mark emms-mode-line emms-cache emms-info-tinytag emms-info-metaflac emms-info-opusinfo emms-info-ogginfo emms-info-mp3info emms-info later-do emms-playlist-mode emms-player-vlc emms-player-mpv emms-player-mplayer emms-player-simple emms-source-playlist emms-source-file locate dired dired-loaddefs emms-setup emms emms-compat gnus nnheader gnus-util rmail rmail-loaddefs rfc2047 rfc2045 ietf-drums mail-utils mm-util mail-prsvr cus-start cus-load org-capture deeper-blue-theme init-org org-clock org ob ob-tangle ob-ref ob-lob ob-table ob-exp org-macro org-footnote org-src ob-comint org-pcomplete pcomplete org-list org-faces org-entities org-version ob-emacs-lisp ob-core ob-eval org-table ol org-keys org-compat advice org-macs org-loaddefs format-spec find-func cal-menu calendar cal-loaddefs init-social newsticker newst-treeview tree-widget newst-plainview newst-reader newst-ticker newst-backend iso8601 time-date xml derived init-cedet ede/speedbar ede/files ede ede/detect ede/base ede/auto ede/source eieio-base eieio-speedbar speedbar ezimage dframe eieio-custom wid-edit cedet init-octave init-rmail init-vc vc vc-dispatcher init-cc-mode init-c init-yasnippet init-eshell eshell esh-cmd esh-ext esh-opt esh-proc esh-io esh-arg esh-module esh-groups esh-util init-lisp slime compile text-property-search etags fileloop generator xref project arc-mode archive-mode noutline outline easy-mmode pp comint ansi-color ring hyperspec thingatpt init-global finder-inf init-package slime-autoloads info package easymenu browse-url url url-proxy url-privacy url-expand url-methods url-history url-cookie url-domsuf url-util mailcap url-handlers url-parse auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs password-cache json subr-x map url-vars seq byte-opt gv bytecomp byte-compile cconv cl-loaddefs cl-lib tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify dynamic-setting system-font-setting font-render-setting cairo x multi-tty make-network-process emacs) Memory information: ((conses 16 394955 20573) (symbols 48 27006 1) (strings 32 118231 5862) (string-bytes 1 3318356) (vectors 16 45818) (vector-slots 8 1259408 184943) (floats 8 225 329) (intervals 56 4361 402) (buffers 992 14)) --00000000000020f27805b2e56d03 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
Since this is about saving a Custom setting, it is not rep= roducible
without emacs -Q.=C2=A0 So, before following the recipe, make = sure you backup
your custom-file, or at least make sure it doesn't h= ave any face
settings for the face you choose to customize.

If po= ssible, use a face you don't have customized under a theme, or
somet= hing like that.=C2=A0 I'll use the error face for my recipe:

Sta= rt emacs
M-x customize-face RET error
I see that the state is STANDAR= D, and the foreground is Red1.
Then change foreground to some color, lik= e orange.
In the State button, choose "Save for Future Sessions&quo= t;.=C2=A0 Don't choose
"Set for Current Session", because = that way there's no bug.
Now Save For Future Sessions should *set* t= he setting, and save it into
the custom file.

I see that the stat= e says THEMED, which I don't think is right: it
should say SAVED and= SET.=C2=A0 There is no theme (other than the user theme)
that is custom= izing the error face in this session.

I see that the foreground valu= e came back to being Red1.=C2=A0 So, it didn't
set the face.

= I get a message that says "Wrote /path/to/custom-file"

C-x= C-f "/path/to/custom-file"
And when I look at the custom-set-= faces entry, I see no setting at all.


If in another session, I c= hoose "Set for Current Session" and then "Save
for Future= Sessions", Customize saves the setting just fine.


In GNU E= macs 28.0.50 (build 10, x86_64-pc-linux-gnu, cairo version 1.15.10)
=C2= =A0of 2020-10-30 built on tbb-desktop
Repository revision: 0d8c6df6c1f5e= 1150b34d4a57acee25471b47340
Repository branch: master
Windowing syste= m distributor 'The X.Org Foundation', version 11.0.12008000
Syst= em Description: Ubuntu 18.04.5 LTS

Configured using:
=C2=A0'c= onfigure --with-x-toolkit=3Dno'

Configured features:
XPM JPEG= TIFF GIF PNG CAIRO SOUND DBUS GSETTINGS GLIB NOTIFY INOTIFY
LIBSELINUX = GNUTLS LIBXML2 FREETYPE HARFBUZZ ZLIB OLDXMENU X11 XDBE XIM
MODULES THRE= ADS PDUMPER

Important settings:
=C2=A0 value of $LC_MONETARY: es_= AR.UTF-8
=C2=A0 value of $LC_NUMERIC: es_AR.UTF-8
=C2=A0 value of $LC= _TIME: es_AR.UTF-8
=C2=A0 value of $LANG: en_US.UTF-8
=C2=A0 locale-c= oding-system: utf-8-unix

Major mode: Custom

Minor modes in ef= fect:
=C2=A0 global-ede-mode: t
=C2=A0 tooltip-mode: t
=C2=A0 glob= al-eldoc-mode: t
=C2=A0 electric-indent-mode: t
=C2=A0 mouse-wheel-mo= de: t
=C2=A0 tool-bar-mode: t
=C2=A0 menu-bar-mode: t
=C2=A0 file-= name-shadow-mode: t
=C2=A0 global-font-lock-mode: t
=C2=A0 font-lock-= mode: t
=C2=A0 auto-composition-mode: t
=C2=A0 auto-encryption-mode: = t
=C2=A0 auto-compression-mode: t
=C2=A0 line-number-mode: t
=C2= =A0 transient-mark-mode: t

Load-path shadows:
None found.

= Features:
(shadow mail-extr emacsbug message rmc puny rfc822 mml mml-sec= epa epg
epg-config mm-decode mm-bodies mm-encode mail-parse rfc2231 mai= labbrev
gmm-utils mailheader sendmail color help-mode crm cus-edit
em= ms-librefm-stream emms-librefm-scrobbler emms-playlist-limit
emms-volume= emms-volume-mixerctl emms-volume-pulse emms-volume-amixer
emms-i18n emm= s-history emms-score emms-stream-info
emms-metaplaylist-mode emms-bookma= rks emms-cue emms-mode-line-icon
emms-browser sort emms-playlist-sort em= ms-last-played emms-player-xine
emms-player-mpd tq emms-playing-time emm= s-lyrics emms-url emms-streams
emms-show-all emms-tag-editor emms-mark e= mms-mode-line emms-cache
emms-info-tinytag emms-info-metaflac emms-info-= opusinfo
emms-info-ogginfo emms-info-mp3info emms-info later-do
emms-= playlist-mode emms-player-vlc emms-player-mpv emms-player-mplayer
emms-p= layer-simple emms-source-playlist emms-source-file locate dired
dired-lo= addefs emms-setup emms emms-compat gnus nnheader gnus-util rmail
rmail-l= oaddefs rfc2047 rfc2045 ietf-drums mail-utils mm-util mail-prsvr
cus-sta= rt cus-load org-capture deeper-blue-theme init-org org-clock org
ob ob-t= angle ob-ref ob-lob ob-table ob-exp org-macro org-footnote
org-src ob-co= mint org-pcomplete pcomplete org-list org-faces
org-entities org-version= ob-emacs-lisp ob-core ob-eval org-table ol
org-keys org-compat advice o= rg-macs org-loaddefs format-spec find-func
cal-menu calendar cal-loaddef= s init-social newsticker newst-treeview
tree-widget newst-plainview news= t-reader newst-ticker newst-backend
iso8601 time-date xml derived init-c= edet ede/speedbar ede/files ede
ede/detect ede/base ede/auto ede/source = eieio-base eieio-speedbar
speedbar ezimage dframe eieio-custom wid-edit = cedet init-octave
init-rmail init-vc vc vc-dispatcher init-cc-mode init-= c init-yasnippet
init-eshell eshell esh-cmd esh-ext esh-opt esh-proc esh= -io esh-arg
esh-module esh-groups esh-util init-lisp slime compile
te= xt-property-search etags fileloop generator xref project arc-mode
archiv= e-mode noutline outline easy-mmode pp comint ansi-color ring
hyperspec t= hingatpt init-global finder-inf init-package slime-autoloads
info packag= e easymenu browse-url url url-proxy url-privacy url-expand
url-methods u= rl-history url-cookie url-domsuf url-util mailcap
url-handlers url-parse= auth-source cl-seq eieio eieio-core cl-macs
eieio-loaddefs password-cac= he json subr-x map url-vars seq byte-opt gv
bytecomp byte-compile cconv = cl-loaddefs cl-lib tooltip eldoc electric
uniquify ediff-hook vc-hooks l= isp-float-type mwheel term/x-win x-win
term/common-win x-dnd tool-bar dn= d fontset image regexp-opt fringe
tabulated-list replace newcomment text= -mode elisp-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-= eshadow isearch timer
select scroll-bar mouse jit-lock font-lock syntax = facemenu font-core
term/tty-colors frame minibuffer cl-generic cham geor= gian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean ja= panese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethi= opic indian
cyrillic chinese composite charscript charprop case-table ep= a-hook
jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice but= ton
loaddefs faces cus-face macroexp files window text-properties overla= y
sha1 md5 base64 format env code-pages mule custom widget
hashtable-= print-readable backquote threads dbusbind inotify
dynamic-setting system= -font-setting font-render-setting cairo x
multi-tty make-network-process= emacs)

Memory information:
((conses 16 394955 20573)
=C2=A0(s= ymbols 48 27006 1)
=C2=A0(strings 32 118231 5862)
=C2=A0(string-bytes= 1 3318356)
=C2=A0(vectors 16 45818)
=C2=A0(vector-slots 8 1259408 18= 4943)
=C2=A0(floats 8 225 329)
=C2=A0(intervals 56 4361 402)
=C2= =A0(buffers 992 14))
--00000000000020f27805b2e56d03-- From unknown Sun Jun 22 00:08:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44331: 28.0.50; Customize won't save a face setting, if not set first References: In-Reply-To: Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Oct 2020 16:24:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44331 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 44331@debbugs.gnu.org Received: via spool by 44331-submit@debbugs.gnu.org id=B44331.160407500626271 (code B ref 44331); Fri, 30 Oct 2020 16:24:02 +0000 Received: (at 44331) by debbugs.gnu.org; 30 Oct 2020 16:23:26 +0000 Received: from localhost ([127.0.0.1]:59464 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYXBW-0006pe-96 for submit@debbugs.gnu.org; Fri, 30 Oct 2020 12:23:26 -0400 Received: from mail-wm1-f43.google.com ([209.85.128.43]:56244) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYXBU-0006pJ-DQ for 44331@debbugs.gnu.org; Fri, 30 Oct 2020 12:23:24 -0400 Received: by mail-wm1-f43.google.com with SMTP id c9so1844591wml.5 for <44331@debbugs.gnu.org>; Fri, 30 Oct 2020 09:23:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:from:date:message-id:subject:to; bh=U1xLviD3UiSxibdP9+jULi3FOPKfergYezd87Gdo0ys=; b=B3btCT2NuAMrabUYtms0a9luBKSVzmqs5UhXqheEku1m7Sy6gkSYM1Pzq+/hxaUvM6 ACJlrz0epEYg7zRA5OHeTeIWMMSEIOSEaR6XxnJK2KsmQha06Mb31VXpFL1eB3ZswU4w Dg20vAnYgqs7Gjul62iohR+17VJum9tJ6g3VOPQQC5at2N5bJygXxrJYSOyPdASDotCj M6wog4QLsQirTeuhDg9EGfGKcIXJwo+32H8QMlrXFgQ3UbFAbxUo7q0SG8J/cV1S8tE9 Fu/Vo3LVXBFXyRqsOGziyljQsktMleqc50LfdPkA73oYnDSQ2Sv2U8mDjqnVXZnz849z J3bQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=U1xLviD3UiSxibdP9+jULi3FOPKfergYezd87Gdo0ys=; b=EaqzneJCciIokkI27/+tgFEL19iCZQJINwKP+ywbvgWcpFCyPEi56CwAAkbm/y/kvf O107v8cG2ffXBoo0+edqG//aHXBfrrCETZajFDspNQyeDgZyUvUU8ouVXx+/shrfI++l M/aL+9utoCAMBEyMKTkeD3Lliz/5LszrnKewTHxApa/3JrhgVnuZ8Ql9owOaTk+8NDqn u5ZLMez11T2IsxgKAjCENgSn6x2TTMf3qRLsApTdzXdWcywJWVi0eBgpmP5/6PpgHZVE AR8FeRavTJh0UsX1cPKW87VSISmfHzgvPfKaeCsvHArR/fhat8z9GnMxt489M7yiwukF 3Rgg== X-Gm-Message-State: AOAM5320jCpGEir8NljidOfuvEaE8saY5lI7nzmnnyEpQsOpyBigFoPa MP0XasmDaweprIfHe7zgVLNKr4eMxm4rf0f9o9J9Gfo0lKI= X-Google-Smtp-Source: ABdhPJz1gANFGXFlTfOU97/DOGNDfpdjMVR7ECVIn0S5KxfDSLx2mBUsDGrXmTISRpZL9xKaQviEzeY6KjjadpO60GY= X-Received: by 2002:a7b:cc8b:: with SMTP id p11mr3681689wma.100.1604074998493; Fri, 30 Oct 2020 09:23:18 -0700 (PDT) MIME-Version: 1.0 From: Mauro Aranda Date: Fri, 30 Oct 2020 13:23:06 -0300 Message-ID: Content-Type: multipart/mixed; boundary="0000000000007a9ce105b2e5d07a" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000007a9ce105b2e5d07a Content-Type: multipart/alternative; boundary="0000000000007a9cdf05b2e5d078" --0000000000007a9cdf05b2e5d078 Content-Type: text/plain; charset="UTF-8" tags 44331 patch quit Looks like this was introduced in the fix for Bug#40866. When only customizing for the selected terminal, now we recreate the custom-face widget for all kind of displays, but lose the user editions in the process of doing that. The attached patch fixes it, because it records the edited value in the :shown-value property, which a custom widget prioritizes over everything else, when finding out the value of the face. --0000000000007a9cdf05b2e5d078 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
tags 44331 patch
quit

Looks like this was introd= uced in the fix for Bug#40866.=C2=A0 When only
customizing for the selec= ted terminal, now we recreate the custom-face
widget for all kind of dis= plays, but lose the user editions in the
process of doing that.

T= he attached patch fixes it, because it records the edited value in
the := shown-value property, which a custom widget prioritizes over
everything = else, when finding out the value of the face.
--0000000000007a9cdf05b2e5d078-- --0000000000007a9ce105b2e5d07a Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Fix-saving-a-face-setting-with-Customize.patch" Content-Disposition: attachment; filename="0001-Fix-saving-a-face-setting-with-Customize.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kgwgsy3f0 RnJvbSBjM2Y5MmE1NDMxZGVmZmY2NGM2OTU2YmJjYmVlMTI2MzhhZTRlY2VmIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFpbC5jb20+ CkRhdGU6IEZyaSwgMzAgT2N0IDIwMjAgMTM6MDU6MDggLTAzMDAKU3ViamVjdDogW1BBVENIXSBG aXggc2F2aW5nIGEgZmFjZSBzZXR0aW5nIHdpdGggQ3VzdG9taXplCgoqIGxpc3AvY3VzLWVkaXQu ZWwgKGN1c3RvbS1mYWNlLXNhdmUpOiBNYWtlIHN1cmUgd2UgYmFjayB1cCBpbnRvIHRoZQo6c2hv d24tdmFsdWUgcHJvcGVydHkgd2hhdCB0aGUgdXNlciBoYXMgZWRpdGVkIHNvIGZhciwgaWYgd2Ug YXJlIGdvaW5nCnRvIHJlY3JlYXRlIHRoZSBjdXN0b20tZmFjZSB3aWRnZXQuICAoQnVnIzQ0MzMx KQotLS0KIGxpc3AvY3VzLWVkaXQuZWwgfCA0ICsrKysKIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2Vy dGlvbnMoKykKCmRpZmYgLS1naXQgYS9saXNwL2N1cy1lZGl0LmVsIGIvbGlzcC9jdXMtZWRpdC5l bAppbmRleCA3NjlhNjlhNTBmLi4wMWRlYzY5NjRkIDEwMDY0NAotLS0gYS9saXNwL2N1cy1lZGl0 LmVsCisrKyBiL2xpc3AvY3VzLWVkaXQuZWwKQEAgLTM5MzEsNiArMzkzMSwxMCBAQCBjdXN0b20t ZmFjZS1zYXZlCiAgICAgICAgIChjdXN0b20tZmFjZS1tYXJrLXRvLXNhdmUgd2lkZ2V0KQogICAg ICAgOzsgVGhlIHVzZXIgaXMgd29ya2luZyBvbiBvbmx5IGEgc2VsZWN0ZWQgdGVybWluYWwgdHlw ZTsKICAgICAgIDs7IG1ha2Ugc3VyZSB3ZSBzYXZlIHRoZSBlbnRpcmUgc3BlYyB0byBgY3VzdG9t LWZpbGUnLiAoQnVnICM0MDg2NikKKyAgICAgIDs7IElmIHJlY3JlYXRpbmcgYSB3aWRnZXQgdGhh dCBtYXkgaGF2ZSBiZWVuIGVkaXRlZCBieSB0aGUgdXNlciwgcmVtZW1iZXIKKyAgICAgIDs7IHRv IGFsd2F5cyBzYXZlIHRoZSBlZGl0ZWQgdmFsdWUgaW50byB0aGUgOnNob3duLXZhbHVlIHByb3Bl cnR5LCBzbworICAgICAgOzsgd2UgdXNlIHRoYXQgdmFsdWUgZm9yIHRoZSByZWNyZWF0ZWQgd2lk Z2V0LiAgKEJ1ZyM0NDMzMSkKKyAgICAgICh3aWRnZXQtcHV0IHdpZGdldCA6c2hvd24tdmFsdWUg KGN1c3RvbS1mYWNlLXdpZGdldC10by1zcGVjIHdpZGdldCkpCiAgICAgICAoY3VzdG9tLWZhY2Ut ZWRpdC1hbGwgd2lkZ2V0KQogICAgICAgKGN1c3RvbS1mYWNlLW1hcmstdG8tc2F2ZSB3aWRnZXQp CiAgICAgICAoaWYgKGVxIGZvcm0gJ3NlbGVjdGVkKQotLSAKMi4yOS4wCgo= --0000000000007a9ce105b2e5d07a-- From unknown Sun Jun 22 00:08:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44331: 28.0.50; Customize won't save a face setting, if not set first Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Fri, 30 Oct 2020 17:44:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44331 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: 44331@debbugs.gnu.org Received: via spool by 44331-submit@debbugs.gnu.org id=B44331.16040798299819 (code B ref 44331); Fri, 30 Oct 2020 17:44:01 +0000 Received: (at 44331) by debbugs.gnu.org; 30 Oct 2020 17:43:49 +0000 Received: from localhost ([127.0.0.1]:59602 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYYRI-0002YJ-OK for submit@debbugs.gnu.org; Fri, 30 Oct 2020 13:43:48 -0400 Received: from mail-wm1-f46.google.com ([209.85.128.46]:39403) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYYRH-0002Y6-LY for 44331@debbugs.gnu.org; Fri, 30 Oct 2020 13:43:48 -0400 Received: by mail-wm1-f46.google.com with SMTP id d3so3688892wma.4 for <44331@debbugs.gnu.org>; Fri, 30 Oct 2020 10:43:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to; bh=j4903mRns6a1HhEn96HK3ticinyhXc+C+tdLxFq2uX4=; b=AmSfsqntiKaerGKLSSJ6Do6APoPb503zw01l9W06UecFu0Jb0jp3mYOTxKbcB+mpqs wzYvZ0N89cMlkgRXSIRYsBe4pnkWGkdXtBae1O5+HeUcnMNlvOXJZVIFAfb2Zp7oky+K WzZtho2HWC7HZA4eOY5CWweSi9qh/QTrlnOsPaC+jfgFPi0jgem/HL1VqfnbzJY6OAZS j4zqiXnSc1oxUZ06shSWPSkq0716xAugGRWvQIomYtkAcmh95ndVGvsjmDPcb5+jFEVC eu+u7lflN1vagrFhgrA2MRBa6/FwcSbFGQUDgXqnxBGIjx9J7s1g9UxqNAZPzdNooOVZ liQg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to; bh=j4903mRns6a1HhEn96HK3ticinyhXc+C+tdLxFq2uX4=; b=EdskFPao05jgMt3EbeMM3zeLvmHmR/sAwhlu6hLzLSCJSrdbhl0/ml5/aVBY6s81GL e2yT34qSFkH2gwF0T0cdGHAoo6TvXeERjS+m40B3w5f8SiD5QawblpQoO4cn0rtqZSxn GWwrrCHnci0ZThnV+WMVoAP/MBH8oBoz3nBMs0bbR6fDnnniIRSfPizoXmtZKjQD42yA WBC08VXpwMYaq9KEGoSjjHvJKYaEDkRcBeRe2GPi/+dw5JdR2scgQSKWAsaRTO578uqG 9YB9w1YF2/XQoznOHakbASLR2iCt4XSk7XvoWtOLPzYmHxgSHmK5eEt1b/2kMy1IbxvM tirw== X-Gm-Message-State: AOAM533TszDVO/2QxxX4mWHO9hmAHRpg27oSPaGEYERD5NtfvZ5cKJbd 0DjyFKpFLjwNV4XDgX898LyhJCSAsBCaHkPatBBNHd57AkdhMg== X-Google-Smtp-Source: ABdhPJyerjlNnzBtAl+G2TdpiD89D5DPZpolchKBibD2ISPudLpTghj0xZb7ObcY6u2xrgxMfkzWBjv/b2ecuOZJDMg= X-Received: by 2002:a1c:f311:: with SMTP id q17mr3848686wmq.28.1604079821688; Fri, 30 Oct 2020 10:43:41 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Mauro Aranda Date: Fri, 30 Oct 2020 14:43:29 -0300 Message-ID: Content-Type: multipart/mixed; boundary="000000000000f6f6be05b2e6ef7b" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000f6f6be05b2e6ef7b Content-Type: multipart/alternative; boundary="000000000000f6f6bc05b2e6ef79" --000000000000f6f6bc05b2e6ef79 Content-Type: text/plain; charset="UTF-8" Sending a better patch, that cleans up the :shown-value property after using it. --000000000000f6f6bc05b2e6ef79 Content-Type: text/html; charset="UTF-8"
Sending a better patch, that cleans up the :shown-value property after
using it.
--000000000000f6f6bc05b2e6ef79-- --000000000000f6f6be05b2e6ef7b Content-Type: text/x-patch; charset="US-ASCII"; name="0001-Fix-saving-a-face-setting-with-Customize.patch" Content-Disposition: attachment; filename="0001-Fix-saving-a-face-setting-with-Customize.patch" Content-Transfer-Encoding: base64 Content-ID: X-Attachment-Id: f_kgwjovz60 RnJvbSA0YTI3NjRjNzM2NjNiYzJkMGM2YThhMGZjYmVhNTViODVhYWE5YTdlIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBNYXVybyBBcmFuZGEgPG1hdXJvb2FyYW5kYUBnbWFpbC5jb20+ CkRhdGU6IEZyaSwgMzAgT2N0IDIwMjAgMTM6MDU6MDggLTAzMDAKU3ViamVjdDogW1BBVENIXSBG aXggc2F2aW5nIGEgZmFjZSBzZXR0aW5nIHdpdGggQ3VzdG9taXplCgoqIGxpc3AvY3VzLWVkaXQu ZWwgKGN1c3RvbS1mYWNlLXNhdmUpOiBNYWtlIHN1cmUgd2UgYmFjayB1cCBpbnRvIHRoZQo6c2hv d24tdmFsdWUgcHJvcGVydHkgd2hhdCB0aGUgdXNlciBoYXMgZWRpdGVkIHNvIGZhciwgaWYgd2Ug YXJlIGdvaW5nCnRvIHJlY3JlYXRlIHRoZSBjdXN0b20tZmFjZSB3aWRnZXQuICAoQnVnIzQ0MzMx KQotLS0KIGxpc3AvY3VzLWVkaXQuZWwgfCA1ICsrKysrCiAxIGZpbGUgY2hhbmdlZCwgNSBpbnNl cnRpb25zKCspCgpkaWZmIC0tZ2l0IGEvbGlzcC9jdXMtZWRpdC5lbCBiL2xpc3AvY3VzLWVkaXQu ZWwKaW5kZXggNzY5YTY5YTUwZi4uM2VlZjQ0NjgzOSAxMDA2NDQKLS0tIGEvbGlzcC9jdXMtZWRp dC5lbAorKysgYi9saXNwL2N1cy1lZGl0LmVsCkBAIC0zOTMxLDcgKzM5MzEsMTIgQEAgY3VzdG9t LWZhY2Utc2F2ZQogICAgICAgICAoY3VzdG9tLWZhY2UtbWFyay10by1zYXZlIHdpZGdldCkKICAg ICAgIDs7IFRoZSB1c2VyIGlzIHdvcmtpbmcgb24gb25seSBhIHNlbGVjdGVkIHRlcm1pbmFsIHR5 cGU7CiAgICAgICA7OyBtYWtlIHN1cmUgd2Ugc2F2ZSB0aGUgZW50aXJlIHNwZWMgdG8gYGN1c3Rv bS1maWxlJy4gKEJ1ZyAjNDA4NjYpCisgICAgICA7OyBJZiByZWNyZWF0aW5nIGEgd2lkZ2V0IHRo YXQgbWF5IGhhdmUgYmVlbiBlZGl0ZWQgYnkgdGhlIHVzZXIsIHJlbWVtYmVyCisgICAgICA7OyB0 byBhbHdheXMgc2F2ZSB0aGUgZWRpdGVkIHZhbHVlIGludG8gdGhlIDpzaG93bi12YWx1ZSBwcm9w ZXJ0eSwgc28KKyAgICAgIDs7IHdlIHVzZSB0aGF0IHZhbHVlIGZvciB0aGUgcmVjcmVhdGVkIHdp ZGdldC4gIChCdWcjNDQzMzEpCisgICAgICAod2lkZ2V0LXB1dCB3aWRnZXQgOnNob3duLXZhbHVl IChjdXN0b20tZmFjZS13aWRnZXQtdG8tc3BlYyB3aWRnZXQpKQogICAgICAgKGN1c3RvbS1mYWNl LWVkaXQtYWxsIHdpZGdldCkKKyAgICAgICh3aWRnZXQtcHV0IHdpZGdldCA6c2hvd24tdmFsdWUg bmlsKSA7IFJlc2V0IGl0IGFmdGVyIHdlIHVzZWQgaXQuCiAgICAgICAoY3VzdG9tLWZhY2UtbWFy ay10by1zYXZlIHdpZGdldCkKICAgICAgIChpZiAoZXEgZm9ybSAnc2VsZWN0ZWQpCiAgICAgICAg ICAgKGN1c3RvbS1mYWNlLWVkaXQtc2VsZWN0ZWQgd2lkZ2V0KQotLSAKMi4yOS4wCgo= --000000000000f6f6be05b2e6ef7b-- From unknown Sun Jun 22 00:08:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44331: 28.0.50; Customize won't save a face setting, if not set first Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Nov 2020 12:58:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44331 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Mauro Aranda Cc: 44331@debbugs.gnu.org Received: via spool by 44331-submit@debbugs.gnu.org id=B44331.160423545814419 (code B ref 44331); Sun, 01 Nov 2020 12:58:02 +0000 Received: (at 44331) by debbugs.gnu.org; 1 Nov 2020 12:57:38 +0000 Received: from localhost ([127.0.0.1]:35915 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZCvS-0003kV-EH for submit@debbugs.gnu.org; Sun, 01 Nov 2020 07:57:38 -0500 Received: from quimby.gnus.org ([95.216.78.240]:33914) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZCvR-0003kJ-52 for 44331@debbugs.gnu.org; Sun, 01 Nov 2020 07:57:37 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=EyWB9nxy94bOaV7okZ8mEaI6RPLfqJhHXN3EXsoV71E=; b=TTjEOeMdz0ImV3QYUmPIPb4mYC +onOIT8QPx3CxNLRmpkNpWldGUHNoWsegzQbRBf83r/nNiLneOndGPXxHuT/geC9p6AwdBMA1Z2k3 xDZEGxJOU264hzxRGjr6D5+Ymck9LmuYdPKM3rmf3PiQug6gagnG+Igng/cD+EfUTxBQ=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kZCvI-00007z-PP; Sun, 01 Nov 2020 13:57:31 +0100 From: Lars Ingebrigtsen References: Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAG1BMVEXZ2NDFw7qal4+B fXX9/fhuamQaFxWIhHv///8X+IUoAAAAAWJLR0QIht6VegAAAAd0SU1FB+QLAQweBFRbp+IAAAGk SURBVDjLddPBUoMwEAZgrBm9FlvHq01ac7YZmyswO+NZKfVsK/Gqibiv7yZYSwD3xORj84cFkoTq an2bJOz6wPkiS44FAAW3nEFhPMCxPEiu5QfcmVryzy7ka67RZoYAI3hE1OguhzALcBfgPgarlNp5 sFHHxpiDUlWpntqldJrSYQno3ndEhcd9kmnSdrRQ/cH0jHVhh53kLmyeB7BpoZZjHUrvTNWHs3RV KnWfpqwHUNCT4xLi8iA8fA0h1/plFGi64xCmOwY38h/4NmabsAnnt34h5wt2esAtwPnvrITTn6eR EFy2UGhh5XwEZigw7NkHiUKHF9yDDNFZa//C3yjcecgtAefH6aaUdkFfCacvMSuMMawdYigPDtfU RAA9kNgEqIewmnt4HYE3D9sRqAlqgEF4Y/aFWUYQ/rFJU1WNqebV/AQBpZB2Zb6Adotggg5xtQfw b6gLIsDWw3sXMssFwdKD6YKfIJ2YDUFj47RmkPWgKNUDLVku6SLqoAACidJaGYXrFrik37t3XA8z dBrXEZyrhoCitPqIIC99eCZcqdgP/xVBdXbH/HEAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjAtMTEt MDFUMTI6MzA6MDQrMDA6MDCAj1pSAAAAJXRFWHRkYXRlOm1vZGlmeQAyMDIwLTExLTAxVDEyOjMw OjA0KzAwOjAw8dLi7gAAAABJRU5ErkJggg== X-Now-Playing: A Certain Ratio's _Loco_: "Get A Grip" Date: Sun, 01 Nov 2020 13:57:27 +0100 In-Reply-To: (Mauro Aranda's message of "Fri, 30 Oct 2020 14:43:29 -0300") Message-ID: <87wnz5ck08.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Mauro Aranda writes: > * lisp/cus-edit.el (custom-face-save): Make sure we back up into the > :shown-value property what the user has edited so far, if we are going > to recreate the custom-face widget. (Bug#44331) Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Mauro Aranda writes: > * lisp/cus-edit.el (custom-face-save): Make sure we back up into the > :shown-value property what the user has edited so far, if we are going > to recreate the custom-face widget. (Bug#44331) Sounds good to me. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Sun Jun 22 00:08:17 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44331: 28.0.50; Customize won't save a face setting, if not set first Resent-From: Mauro Aranda Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Sun, 01 Nov 2020 13:20:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44331 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: patch To: Lars Ingebrigtsen Cc: 44331@debbugs.gnu.org Received: via spool by 44331-submit@debbugs.gnu.org id=B44331.1604236779340 (code B ref 44331); Sun, 01 Nov 2020 13:20:01 +0000 Received: (at 44331) by debbugs.gnu.org; 1 Nov 2020 13:19:39 +0000 Received: from localhost ([127.0.0.1]:35954 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZDGl-00005K-EH for submit@debbugs.gnu.org; Sun, 01 Nov 2020 08:19:39 -0500 Received: from mail-wr1-f46.google.com ([209.85.221.46]:45407) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZDGi-0008WR-Tn for 44331@debbugs.gnu.org; Sun, 01 Nov 2020 08:19:38 -0500 Received: by mail-wr1-f46.google.com with SMTP id a9so11444835wrg.12 for <44331@debbugs.gnu.org>; Sun, 01 Nov 2020 05:19:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=S0Y4OVVAJhYhYwTmjqVlL9RtgmyOPlYmh9SZ5o8eONE=; b=vVn9KzIb3u+puAssPlNToeIzbkVfR5mpmlrerVfKv6oXXMbgUJ4qErZF1H6Mm+Rnza FasHiZmwcwEqhxoCe9J6kIMvaXFLlpaQd3jmEGH4cMPy38MaDkrxxby1LBVxAKmdv9o8 fIJ2L06E31uGQRg1PAsFVFy5+2Hzox39f5ouzYwzByMAjoRdw7t3txsxaRrn+7HiulXV TF7E5UqGq4k4cgD5hrotZlmt4I87HyO3KxrdYR0sK+8EhHi01LyCG9qNfvniAeiC61tj vYTpTfQMVifyfdsQmt92+1XKz9SzLSn/qX62uCUkMIdVTtD7XRLHlGpMaNqs1Ofm5xB6 rXCg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=S0Y4OVVAJhYhYwTmjqVlL9RtgmyOPlYmh9SZ5o8eONE=; b=EgZB2tMPAlSL6txoQOxRFFRN/7hTQzCinrF9FL7RgJTLFTaiTV8YgVsGWh+U7dWSin 8VWVgOrSIbUsR5l9ukJ4ohyUYtHxl0iT+WRJpepLnDiARVTdi6a3xL8JEbEZMobxw3Ri DypQf8YJ4mFWgKsVPUGOi5+oMle2kHi4pJUTPnjuI0qy5DxBNTClV0f+0hYPM+t0++fa vg3nuJ7nmJNkDlz53cMTGjYS6Mtb1+XI2Frb/7jsG10yTsAIWnrKW7kXx0YFbYX7HJhw 0BDGVrwdbrlgWR47crSG3uP5So0faMXeEF1QZw3BEagBWdqejMroYT1XfSjsQWf7r6Fx ai6Q== X-Gm-Message-State: AOAM5334mDEHfvsFy0kadcY1uNKJDXSz5eGbADj6URxcfe2sXaoLb4ha A688UMdQYMGHupTSHkHlcRJrPJ0H7fFdQPJokao= X-Google-Smtp-Source: ABdhPJygV4Hno6IsAwF78BisZ00ETy0li49ireuXsq/bjcw2oZDk0WkhxQMZqa2RrlDhHfVk2/Q9UY2tt9kdhge4rec= X-Received: by 2002:adf:dd8f:: with SMTP id x15mr15475652wrl.124.1604236771124; Sun, 01 Nov 2020 05:19:31 -0800 (PST) MIME-Version: 1.0 References: <87wnz5ck08.fsf@gnus.org> In-Reply-To: <87wnz5ck08.fsf@gnus.org> From: Mauro Aranda Date: Sun, 1 Nov 2020 10:19:18 -0300 Message-ID: Content-Type: multipart/alternative; boundary="000000000000e0e93705b30b7a09" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --000000000000e0e93705b30b7a09 Content-Type: text/plain; charset="UTF-8" tags 44331 fixed close 44331 quit Lars Ingebrigtsen writes: > Mauro Aranda writes: > >> * lisp/cus-edit.el (custom-face-save): Make sure we back up into the >> :shown-value property what the user has edited so far, if we are going >> to recreate the custom-face widget. (Bug#44331) > > Sounds good to me. Thanks. Pushed to master, and closing. --000000000000e0e93705b30b7a09 Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
tags 44331 fixed
close 44331
quit

Lars Ingebr= igtsen <larsi@gnus.org> writes:=

> Mauro Aranda <mau= rooaranda@gmail.com> writes:
>
>> * lisp/cus-edit.el = (custom-face-save): Make sure we back up into the
>> :shown-value = property what the user has edited so far, if we are going
>> to re= create the custom-face widget. =C2=A0(Bug#44331)
>
> Sounds goo= d to me.

Thanks.=C2=A0 Pushed to master, and closing.
--000000000000e0e93705b30b7a09--