Subject: Re: [bug#44321] [PATCH 4/6] guix build: Move transformation options to (guix transformations).

From: Ludovic Courtès <[email-masked]>
Date: Sat, 31 Oct 2020 11:04:37 +0100

Hi,

Miguel Ángel Arruga Vivas <[email-masked]> skribis:

> Ludovic Courtès <[email-masked]> writes:
>
>> * guix/transformations.scm: New file.
>
> The main comment regarding this patch is that file has to be added to
> po/guix/POTFILES.in, or the translations will be lost.

Indeed, I’ll add it to that file.

> I've seen that you've changed some code identifiers, here:
>> -           (else  (tarball-base-name (file-sans-extension file-name)))))
>> +           (_     (tarball-base-name (file-sans-extension file-name)))))
>
> And there:
>> -           (x
>> +           (_
>
> And these changes seem sensible as the match parameter is unused.

Yeah.

Thanks!

Ludo’.