Subject: [bug#44321] [PATCH 3/6] guix build: 'options->transformation' no longer takes a 'store' parameter.

From: Ludovic Courtès <[email-masked]>
Date: Sat, 31 Oct 2020 11:03:30 +0100

Hi Miguel,

Miguel Ángel Arruga Vivas <[email-masked]> skribis:

> Ludovic Courtès <[email-masked]> writes:
>> ("options->transformation, with-source")
>> ("options->transformation, with-source, replacement")
>> ("options->transformation, with-source, with version")
>> ("options->transformation, with-source, PKG=URI"): Use 'lower-object' to
>> compute the store file name of the source.
> [...]
>> @@ -64,12 +66,9 @@
>>    (let* ((p (dummy-package "guix.scm" (replacement coreutils)))
>>           (s (search-path %load-path "guix.scm"))
>>           (t (options->transformation `((with-source . ,s)))))
>> -    (with-store store
>> -      (let ((new (t store p)))
>> -        (and (not (eq? new p))
>> -             (string=? (package-source new)
>> -                       (add-to-store store "guix.scm" #t "sha256" s))
>> -             (not (package-replacement new)))))))
>> +    (let ((new (t p)))
>> +      (and (not (eq? new p))
>> +           (not (package-replacement new))))))
>>  
>>  (test-assert "options->transformation, with-source, with version"
>>    ;; Our pseudo-package is called 'guix.scm' so the 'guix.scm-2.0' source
>
> It's the only one that doesn't follow the same pattern as others, where
> the change look quite similar: instead of (t store p) -> (t p) (source
> (run-...)), also specified in the message.
>
> If removing that comparison is intended, I think the commit message
> should be changed.  Otherwise it LGTM.

Good catch!  I guess I was hesitant here.  I’ll re-introduce the test
using ‘run-with-store’ and all.

Thanks,
Ludo’.