Subject: Re: [bug#44321] [PATCH 4/6] guix build: Move transformation options to (guix transformations).

From: Miguel Ángel Arruga Vivas <[email-masked]>
Date: Sat, 31 Oct 2020 00:03:03 +0100

Hi Ludo,

Ludovic Courtès <[email-masked]> writes:

> * guix/transformations.scm: New file.

The main comment regarding this patch is that file has to be added to
po/guix/POTFILES.in, or the translations will be lost.

I've seen that you've changed some code identifiers, here:
> -           (else  (tarball-base-name (file-sans-extension file-name)))))
> +           (_     (tarball-base-name (file-sans-extension file-name)))))

And there:
> -           (x
> +           (_

And these changes seem sensible as the match parameter is unused.

Other than the first comment, the patch LGTM.

Happy hacking,
Miguel