From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 29 17:09:37 2020 Received: (at submit) by debbugs.gnu.org; 29 Oct 2020 21:09:37 +0000 Received: from localhost ([127.0.0.1]:55097 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYFAu-0001Qx-So for submit@debbugs.gnu.org; Thu, 29 Oct 2020 17:09:37 -0400 Received: from lists.gnu.org ([209.51.188.17]:41026) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYFAt-0001Qq-8y for submit@debbugs.gnu.org; Thu, 29 Oct 2020 17:09:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:32890) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYFAt-00059O-31 for bug-gnu-emacs@gnu.org; Thu, 29 Oct 2020 17:09:35 -0400 Received: from mout02.posteo.de ([185.67.36.66]:54625) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kYFAq-0007vj-Om for bug-gnu-emacs@gnu.org; Thu, 29 Oct 2020 17:09:34 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id BA4B72400FD for ; Thu, 29 Oct 2020 22:09:29 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.de; s=2017; t=1604005769; bh=XHVnitE4GYziWTNPueOcpBOmzCrFVWL9sEamnLQyJWA=; h=From:To:Subject:Date:From; b=HKD8Je9OP23GI10TFOjun+GW0q8xDGkcOd7TYbsRfCOqg2HyLfyujz/rkVOERs9lk TqoTL7rSoLcaond/1uWxM34ybgaQZraEhG+lFERBU5F4vGOKI/VzAqOsFeW4v80Ks6 8MeOqgw0gLXEadocflySE5TEek2bLt4p4T3nEaT25ZnoL2iWiDdxEq80xkRVSEf3W8 yKt45hCvjwTewmynzujkjGBj1xpj1kNxNPzhuV31/a0DonKitF61wZq7018pEAjCRH mFFwEnVeCxRI1RMGhWK4i8z1P+8gO7gwdsiYFFrX2c5e8FadSa+bSi6TTjdOXKlZhS LaqHzo/QYtEhg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4CMdNn2blVz6tmL for ; Thu, 29 Oct 2020 22:09:29 +0100 (CET) From: haj@posteo.de (Harald =?utf-8?Q?J=C3=B6rg?=) To: bug-gnu-emacs@gnu.org Subject: [PATCH] cperl-mode: Make timeout tests more robust User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Date: Thu, 29 Oct 2020 22:09:29 +0100 Message-ID: <87lffo3fjq.fsf@hajtower> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: pass client-ip=185.67.36.66; envelope-from=haj@posteo.de; helo=mout02.posteo.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/29 17:05:53 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) --=-=-= Content-Type: text/plain One of the tests in cperl-mode-tests.el starts an external Emacs process under timeout to check for an endless loop. It turns out that the timeout of 1 sec is rather short for slower machines. Thanks to recent ERT which now reports the run time in batch tests, I saw that it takes about 0.7 seconds on my machine, so I increased the timeout to 2 seconds. I also flagged the test as "expensive" and skip it under older Emacs versions (I run tests for Emacs version 26.1 and above). --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=0001-cperl-mode-Make-timeout-test-more-robust.patch Content-Description: cperl-mode: Make timeout tests more robust >From b169038b5d619907f2513de944e4515bf7524d53 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Harald=20J=C3=B6rg?= Date: Thu, 29 Oct 2020 22:06:56 +0100 Subject: [PATCH] cperl-mode: Make timeout test more robust * test/lisp/progmodes/cperl-mode-tests.el (cperl-mode-test-bug-10483): Increase the timeout to 2 seconds and mark the test as expensive. Also, suppress it for Emacs versions below 28, where the test times out though the function works quite fine in manual tests. --- test/lisp/progmodes/cperl-mode-tests.el | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/test/lisp/progmodes/cperl-mode-tests.el b/test/lisp/progmodes/cperl-mode-tests.el index e67678cf6b..9b486ae2e2 100644 --- a/test/lisp/progmodes/cperl-mode-tests.el +++ b/test/lisp/progmodes/cperl-mode-tests.el @@ -108,8 +108,10 @@ cperl-mode-test-bug-10483 without a statement terminator on the same line does not loop forever. The test starts an asynchronous Emacs batch process under timeout control." + :tags '(:expensive-test) (interactive) (skip-unless (not (getenv "EMACS_HYDRA_CI"))) ; FIXME times out + (skip-unless (not (< emacs-major-version 28))) ; times out in older Emacsen (let* ((emacs (concat invocation-directory invocation-name)) (test-function 'cperl-mode-test--run-bug-10483) (test-function-name (symbol-name test-function)) @@ -118,7 +120,7 @@ cperl-mode-test-bug-10483 (process-connection-type nil) runner) (with-temp-buffer - (with-timeout (1 + (with-timeout (2 (delete-process runner) (setq ran-out-of-time t)) (setq runner (start-process "speedy" -- 2.20.1 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 29 17:49:30 2020 Received: (at 44317) by debbugs.gnu.org; 29 Oct 2020 21:49:30 +0000 Received: from localhost ([127.0.0.1]:55201 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYFnW-0004dW-Cn for submit@debbugs.gnu.org; Thu, 29 Oct 2020 17:49:30 -0400 Received: from mail-ed1-f46.google.com ([209.85.208.46]:40785) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYFnU-0004dC-D9 for 44317@debbugs.gnu.org; Thu, 29 Oct 2020 17:49:28 -0400 Received: by mail-ed1-f46.google.com with SMTP id p93so4580137edd.7 for <44317@debbugs.gnu.org>; Thu, 29 Oct 2020 14:49:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:in-reply-to:references:mime-version:date:message-id:subject:to :content-transfer-encoding; bh=BoCFymSdkPW0fVl3VyD2lHSaxlb4HMSD9naLSu4Ssbw=; b=IvKIl+XeTndKz7iXv3w5kGvTGcgI/GhEqWeeIndTOBEcxV8Wh+AfYbGRtWn6gzySxl zpKbi76ymB0CrtYfQ7nM/ZusWeiR/D+iJpBJR6VBP1AxvnXZxMAv+UN62Y7jDX3Dtc/g 9+JuszxsRSaAWEwXnVMp1niRD+1BLZuduv2viS18NSpCw6tJhkiK6nNQqA2z5KItTnpP D++7heg7bAsdbHww6WfvLlVoguD5vP2teGr+siviQdytiCDaMypyIr/rWhDTYMnxInVb hbkUTfq/Tj5kyiPOWq9vKw8j+CeRUyeEjPH+kpZjZ7UvSZbl4qAbYXdEiX2aw5YnZKul wL+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:content-transfer-encoding; bh=BoCFymSdkPW0fVl3VyD2lHSaxlb4HMSD9naLSu4Ssbw=; b=lXY+hsLiPJ8d1axPfaW325K5VswSOl6gBURX8ac/cMRA6MJEpuxZoGLYTOiAMLly4m mxzbemi48R31gGaUBzIx8vk9eMVM0Ft1nteTAY7j+GBIDVLAV4PSQB+JbJcgB0DQnDfb 3ATGkjMYD1AiSZMppAYngVADc4VgSnK3utRLy3IZWgLzFj9fh1b+oh0IP9EzBcVnjMog QC8ZHc5+ZlFi9FfUPj0EYH57fVenhC/fUlq5Xtq8r5LJpjb62qUFXgFwVc4W+o99LPDF 6Ef9XKp0PY67VMJtj2mWbds483bqc7T2ONFRTixTkRjyQzpXbsr+5CjSRmqxCbHWKY8m pKwA== X-Gm-Message-State: AOAM532F0UeFx7Nt791EJ0gxJ/Vuzv+eQwtYF92vIzsZ9pRzEwK6qUmG Qdd0/SMSjDgSHymghKbMEs0CP6TPr6t8AMGSTgM= X-Google-Smtp-Source: ABdhPJxVdzAY8NuiJLrUV3S+4RDzd+867v/TOdrEC/YrxM6LbNvo98EoC6X1ix7MlVU6kzXWVAB1bXHzH6mNZtmIATA= X-Received: by 2002:aa7:d783:: with SMTP id s3mr6386677edq.214.1604008162577; Thu, 29 Oct 2020 14:49:22 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Thu, 29 Oct 2020 14:49:22 -0700 From: Stefan Kangas In-Reply-To: <87lffo3fjq.fsf@hajtower> References: <87lffo3fjq.fsf@hajtower> MIME-Version: 1.0 Date: Thu, 29 Oct 2020 14:49:22 -0700 Message-ID: Subject: Re: bug#44317: [PATCH] cperl-mode: Make timeout tests more robust To: =?UTF-8?B?SGFyYWxkIErDtnJn?= , 44317@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44317 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) close 44317 28.1 thanks haj@posteo.de (Harald J=C3=B6rg) writes: > One of the tests in cperl-mode-tests.el starts an external Emacs process > under timeout to check for an endless loop. It turns out that the > timeout of 1 sec is rather short for slower machines. Thanks to recent > ERT which now reports the run time in batch tests, I saw that it takes > about 0.7 seconds on my machine, so I increased the timeout to 2 > seconds. > > I also flagged the test as "expensive" and skip it under older Emacs > versions (I run tests for Emacs version 26.1 and above). Thanks, makes sense. Pushed to master as commit 96e371b44a. From unknown Sat Sep 20 21:09:14 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 27 Nov 2020 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator