GNU bug report logs - #44309
[PATCH] gnu: gnucash: Enable python bindings.

Previous Next

Package: guix-patches;

Reported by: Prafulla Giri <pratheblackdiamond <at> gmail.com>

Date: Thu, 29 Oct 2020 15:30:01 UTC

Severity: normal

Tags: patch

Done: Marius Bakke <marius <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44309 in the body.
You can then email your comments to 44309 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#44309; Package guix-patches. (Thu, 29 Oct 2020 15:30:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Prafulla Giri <pratheblackdiamond <at> gmail.com>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 29 Oct 2020 15:30:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Prafulla Giri <pratheblackdiamond <at> gmail.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: gnucash: Enable python bindings.
Date: Thu, 29 Oct 2020 21:14:00 +0545
[Message part 1 (text/plain, inline)]
Esteemed maintainers,

Attached is a patch that enables python bindings in gnucash.

I have also taken the liberty of adding native-search-paths field and
adding 'PYTHONPATH' to it for foreign distro users who might want to use
gnucash python bindings with host-os-supplied python.

Thanks!
[Message part 2 (text/html, inline)]
[0001-gnu-gnucash-Enable-python-bindings.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#44309; Package guix-patches. (Sun, 01 Nov 2020 04:45:01 GMT) Full text and rfc822 format available.

Message #8 received at 44309 <at> debbugs.gnu.org (full text, mbox):

From: Prafulla Giri <pratheblackdiamond <at> gmail.com>
To: 44309 <at> debbugs.gnu.org
Subject: Further Cleanups
Date: Sun, 1 Nov 2020 10:29:36 +0545
[Message part 1 (text/plain, inline)]
 I am wondering if the python bindings should be separated into an output.
gnucash:python perhaps. That is the route that the Ubuntu developers seem
to have taken. `apt show python3-gnucash`. It would actually make even more
sense with guix as one could use flatpak-installed gnucash for their daily
usage, and then from their /usr/bin/python3 or $GUIX_PROFILE/bin/python3
they could use gnucash programmatically via the bindings.

However, I am not sure if it is possible to specify a
search-path-specification for a particular output of a package. I don't
know much about splitting packages into outputs either. If we had
gnucash:python, and a user ran `guix install gnucash:python`, would that
only get the user /gnu/store/...-gnucash-x.y-python from the substitute
server and save them bandwidth?

If anybody is willing to give me some pointers as to how I could go about
cleanly splitting gnucash into gnucash:python - with the
native-search-path-specification for PYTHONPATH only being declared for
gnucash:python (and that will be an absolute must), I am more than happy to
clean this patch up.

Thank you.
[Message part 2 (text/html, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#44309; Package guix-patches. (Mon, 02 Nov 2020 13:53:02 GMT) Full text and rfc822 format available.

Message #11 received at 44309 <at> debbugs.gnu.org (full text, mbox):

From: Prafulla Giri <pratheblackdiamond <at> gmail.com>
To: 44309 <at> debbugs.gnu.org
Subject: New and Improved Patch
Date: Mon, 2 Nov 2020 19:37:37 +0545
[Message part 1 (text/plain, inline)]
Esteemed maintainers,

Attached is an updated version of the patch.

I have removed the native-search-paths specification of PYTHONPATH. I have
also created a new output "python" that contains the python bindings. A new
phase
has been added that splits the python bindings into it's own separate
output. With that, users who only want to use gnucash programmatically can
use it with `guix environment --ad-hoc python gnucash:python`.

Please do let me know if there are any further corrections that I can make.
Thank you.
[Message part 2 (text/html, inline)]
[0001-gnu-gnucash-Enable-python-bindings.patch (text/x-patch, attachment)]

Reply sent to Marius Bakke <marius <at> gnu.org>:
You have taken responsibility. (Tue, 10 Nov 2020 21:11:02 GMT) Full text and rfc822 format available.

Notification sent to Prafulla Giri <pratheblackdiamond <at> gmail.com>:
bug acknowledged by developer. (Tue, 10 Nov 2020 21:11:02 GMT) Full text and rfc822 format available.

Message #16 received at 44309-done <at> debbugs.gnu.org (full text, mbox):

From: Marius Bakke <marius <at> gnu.org>
To: Prafulla Giri <pratheblackdiamond <at> gmail.com>, 44309-done <at> debbugs.gnu.org
Subject: Re: [bug#44309] New and Improved Patch
Date: Tue, 10 Nov 2020 22:10:49 +0100
[Message part 1 (text/plain, inline)]
Prafulla Giri <pratheblackdiamond <at> gmail.com> writes:

> Esteemed maintainers,
>
> Attached is an updated version of the patch.
>
> I have removed the native-search-paths specification of PYTHONPATH. I have
> also created a new output "python" that contains the python bindings. A new
> phase
> has been added that splits the python bindings into it's own separate
> output. With that, users who only want to use gnucash programmatically can
> use it with `guix environment --ad-hoc python gnucash:python`.
>
> Please do let me know if there are any further corrections that I can make.

Looks great to me.  Applied, thanks!
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#44309; Package guix-patches. (Wed, 11 Nov 2020 09:28:02 GMT) Full text and rfc822 format available.

Message #19 received at 44309-done <at> debbugs.gnu.org (full text, mbox):

From: Prafulla Giri <pratheblackdiamond <at> gmail.com>
To: Marius Bakke <marius <at> gnu.org>
Cc: 44309-done <at> debbugs.gnu.org
Subject: Re: [bug#44309] New and Improved Patch
Date: Wed, 11 Nov 2020 15:11:45 +0545
[Message part 1 (text/plain, inline)]
Thank you!

On Wed, Nov 11, 2020 at 2:55 AM Marius Bakke <marius <at> gnu.org> wrote:

> Prafulla Giri <pratheblackdiamond <at> gmail.com> writes:
>
> > Esteemed maintainers,
> >
> > Attached is an updated version of the patch.
> >
> > I have removed the native-search-paths specification of PYTHONPATH. I
> have
> > also created a new output "python" that contains the python bindings. A
> new
> > phase
> > has been added that splits the python bindings into it's own separate
> > output. With that, users who only want to use gnucash programmatically
> can
> > use it with `guix environment --ad-hoc python gnucash:python`.
> >
> > Please do let me know if there are any further corrections that I can
> make.
>
> Looks great to me.  Applied, thanks!
>
[Message part 2 (text/html, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 09 Dec 2020 12:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 4 years and 250 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.