From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 29 06:00:14 2020 Received: (at submit) by debbugs.gnu.org; 29 Oct 2020 10:00:15 +0000 Received: from localhost ([127.0.0.1]:51928 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kY4j8-0002tU-Lc for submit@debbugs.gnu.org; Thu, 29 Oct 2020 06:00:14 -0400 Received: from lists.gnu.org ([209.51.188.17]:47274) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kY4j7-0002tN-5k for submit@debbugs.gnu.org; Thu, 29 Oct 2020 06:00:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:38544) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kY4j6-0007RX-T2 for bug-gnu-emacs@gnu.org; Thu, 29 Oct 2020 06:00:12 -0400 Received: from aibo.runbox.com ([91.220.196.211]:57302) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kY4j2-0007Da-FK for bug-gnu-emacs@gnu.org; Thu, 29 Oct 2020 06:00:10 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=selector1; h=Content-Type:MIME-Version:Message-ID:Date:Subject:To:From; bh=fUtOjYnTUnpQu5noWvLc7HmzSvEQvhzjyK0BNa8Go+o=; b=S7EzQ06WBabThvbbLbQdVtAgZ kVQMNoebN0FRjF3KmspzX24OeANwQt7xCiCyggpio8DVYXcG3mUIJWDD6Fk3QlmCQODTmXYYiacc1 8UalOuJWs4IugvS6OxfEsmMCnKrN1MEf0dLpJj+jV4TKrleIdzi/EUeZmbpXC45bzboyf7uZCswT9 SU+FStG3GQVxVQlDi5KXdVkbshFkl9q6G5TyEuLlWLXG1owgw9St58844OOuUK1r1h9rTV6kEWjJ4 oI4QjEs8IHFXgcR2Y1QPygU6zn/plrxrOCPSPuyTIolSglEVNZjSsYywfvkm400hjtER5dH1mnpXm yXWqNoDlg==; Received: from [10.9.9.74] (helo=submission03.runbox) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1kY4iu-0002as-Cn for bug-gnu-emacs@gnu.org; Thu, 29 Oct 2020 11:00:00 +0100 Received: by submission03.runbox with esmtpsa [Authenticated alias (963757)] (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) id 1kY4ij-0004l3-DB for bug-gnu-emacs@gnu.org; Thu, 29 Oct 2020 10:59:49 +0100 From: =?utf-8?Q?Simen_Heggest=C3=B8yl?= To: bug-gnu-emacs@gnu.org Subject: 28.0.50; json-pretty-print-buffer creates spurious lock file Date: Thu, 29 Oct 2020 10:59:48 +0100 Message-ID: <87wnz9pd2j.fsf@runbox.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Received-SPF: pass client-ip=91.220.196.211; envelope-from=simenheg@runbox.com; helo=aibo.runbox.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/29 06:00:00 X-ACL-Warn: Detected OS = ??? X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H3=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) Given a file named 'test.json' with the following content: {} >From 'emacs -Q', visit the file and call 'json-pretty-print-buffer'. The buffer stays unchanged as expected since the pretty printed content is identical to the original. The buffer is not marked as modified (also expected), but a spurious lock file '.#test.json' has been created. From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 30 09:29:20 2020 Received: (at 44303) by debbugs.gnu.org; 30 Oct 2020 13:29:20 +0000 Received: from localhost ([127.0.0.1]:56656 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYUT1-0007pv-PR for submit@debbugs.gnu.org; Fri, 30 Oct 2020 09:29:20 -0400 Received: from quimby.gnus.org ([95.216.78.240]:37856) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYUSz-0007pg-Av for 44303@debbugs.gnu.org; Fri, 30 Oct 2020 09:29:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=h6aO0YowkPyhY3X9MvCBARAfRDNWr6uje0VLaqFL2ys=; b=naKdNfTgD3r+sm9/mADZCEvo4a BbMtPi8tTk3C909U893Y9hpL6UKa1dvoc4+DdwudJYA+ic2ijklm16bTHFz4IO3VEzNLDDbPG8kHK +o08H942UgYVCzTlA3tT4Sd6P1CJILoX38I0dUvQ+dxMTt/mx5h8z1n/TE/3rBRNee9w=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kYUSj-0000ZQ-02; Fri, 30 Oct 2020 14:29:11 +0100 From: Lars Ingebrigtsen To: Simen =?utf-8?Q?Heggest=C3=B8yl?= Subject: Re: bug#44303: 28.0.50; json-pretty-print-buffer creates spurious lock file References: <87wnz9pd2j.fsf@runbox.com> X-Now-Playing: Noveller's _Arrow_: "Thorns" Date: Fri, 30 Oct 2020 14:28:59 +0100 In-Reply-To: <87wnz9pd2j.fsf@runbox.com> ("Simen =?utf-8?Q?Heggest=C3=B8yl?= =?utf-8?Q?=22's?= message of "Thu, 29 Oct 2020 10:59:48 +0100") Message-ID: <87o8kjhmg4.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Simen Heggestøyl writes: > Given a file named 'test.json' with the following content: {} > >>From 'emacs -Q', visit the file and call 'json-pretty-print-buffer'. > > The buffer stays unchanged as expected since the pretty pri [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44303 Cc: 44303@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Simen Heggest=C3=B8yl writes: > Given a file named 'test.json' with the following content: {} > >>>From 'emacs -Q', visit the file and call 'json-pretty-print-buffer'. > > The buffer stays unchanged as expected since the pretty printed content > is identical to the original. The buffer is not marked as modified (also > expected), but a spurious lock file '.#test.json' has been created. Yup. It's this code in Freplace_buffer_contents: if (!inhibit_modification_hooks) { prepare_to_modify_buffer (BEGV, ZV, NULL); specbind (Qinhibit_modification_hooks, Qt); modification_hooks_inhibited =3D true; } prepare_to_modify_buffer creates the backup file. But is that even needed here? Don't the later Finsert_buffer_substring/del_range_both functions do the necessary bookkeeping? --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 30 09:31:46 2020 Received: (at 44303) by debbugs.gnu.org; 30 Oct 2020 13:31:46 +0000 Received: from localhost ([127.0.0.1]:56664 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYUVO-0007vh-I9 for submit@debbugs.gnu.org; Fri, 30 Oct 2020 09:31:46 -0400 Received: from quimby.gnus.org ([95.216.78.240]:37878) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYUVN-0007vV-Fn for 44303@debbugs.gnu.org; Fri, 30 Oct 2020 09:31:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=kY4MaPc/gtmCAjgeTLFiNjXTpoZWBPJkSbfvF23gQKc=; b=GcJZtRI8bBSAGr3QYDwpbMEXRk F6RY4jBanmKbS7kR51k7m18TTlzK7dMMlZAG+bZtwc/VSp1oo6H9u3w41PBJgu3fmniAUBM3v5BZF JaML5A17xtcuMwmYXJO/b/33q0yK5L5KVJ2jqu3JC8ezhUfdnvN3VQl+jY0MXB/VvL+w=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kYUVB-0000aG-W4; Fri, 30 Oct 2020 14:31:39 +0100 From: Lars Ingebrigtsen To: Simen =?utf-8?Q?Heggest=C3=B8yl?= Subject: Re: bug#44303: 28.0.50; json-pretty-print-buffer creates spurious lock file References: <87wnz9pd2j.fsf@runbox.com> <87o8kjhmg4.fsf@gnus.org> X-Now-Playing: Noveller's _Arrow_: "Landscape" Date: Fri, 30 Oct 2020 14:31:32 +0100 In-Reply-To: <87o8kjhmg4.fsf@gnus.org> (Lars Ingebrigtsen's message of "Fri, 30 Oct 2020 14:28:59 +0100") Message-ID: <87k0v7hmbv.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Lars Ingebrigtsen writes: > But is that even needed here? Don't the later > Finsert_buffer_substring/del_range_both functions do the necessary > bookkeeping? Aha, it was previously: Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44303 Cc: 44303@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Lars Ingebrigtsen writes: > But is that even needed here? Don't the later > Finsert_buffer_substring/del_range_both functions do the necessary > bookkeeping? Aha, it was previously: - /* If k >= l, it means nothing needs to be deleted. */ - if (k < l) - prepare_to_modify_buffer (from, to, NULL); + prepare_to_modify_buffer (from, to, NULL); So it needs to be done in the del_range_both case? Which makes some sense. Perhaps it can just be moved down into the loop (and done once if it hasn't been done before)? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 30 09:35:18 2020 Received: (at 44303) by debbugs.gnu.org; 30 Oct 2020 13:35:18 +0000 Received: from localhost ([127.0.0.1]:56684 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYUYo-00082E-Bq for submit@debbugs.gnu.org; Fri, 30 Oct 2020 09:35:18 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37430) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYUYm-000821-Ck for 44303@debbugs.gnu.org; Fri, 30 Oct 2020 09:35:16 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:44334) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kYUYg-0000wQ-NM; Fri, 30 Oct 2020 09:35:10 -0400 Received: from [176.228.60.248] (port=2306 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kYUYe-0003xL-3D; Fri, 30 Oct 2020 09:35:09 -0400 Date: Fri, 30 Oct 2020 15:34:51 +0200 Message-Id: <83r1pfalc4.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-Reply-To: <87o8kjhmg4.fsf@gnus.org> (message from Lars Ingebrigtsen on Fri, 30 Oct 2020 14:28:59 +0100) Subject: Re: bug#44303: 28.0.50; json-pretty-print-buffer creates spurious lock file References: <87wnz9pd2j.fsf@runbox.com> <87o8kjhmg4.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44303 Cc: simenheg@runbox.com, 44303@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Date: Fri, 30 Oct 2020 14:28:59 +0100 > Cc: 44303@debbugs.gnu.org > > > The buffer stays unchanged as expected since the pretty printed content > > is identical to the original. The buffer is not marked as modified (also > > expected), but a spurious lock file '.#test.json' has been created. > > Yup. It's this code in Freplace_buffer_contents: > > if (!inhibit_modification_hooks) > { > prepare_to_modify_buffer (BEGV, ZV, NULL); > specbind (Qinhibit_modification_hooks, Qt); > modification_hooks_inhibited = true; > } > > prepare_to_modify_buffer creates the backup file. But we then have this: if (modification_hooks_inhibited) { signal_after_change (BEGV, size_a, ZV - BEGV); update_compositions (BEGV, ZV, CHECK_INSIDE); } Does this not work, or fail to unlock the file? > But is that even needed here? Don't the later > Finsert_buffer_substring/del_range_both functions do the necessary > bookkeeping? We disable that by binding inhibit_modification_hooks, and we do that for speed, see the comment before that code. From debbugs-submit-bounces@debbugs.gnu.org Sun Nov 01 07:06:14 2020 Received: (at 44303) by debbugs.gnu.org; 1 Nov 2020 12:06:14 +0000 Received: from localhost ([127.0.0.1]:35820 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZC7i-0004YH-D6 for submit@debbugs.gnu.org; Sun, 01 Nov 2020 07:06:14 -0500 Received: from quimby.gnus.org ([95.216.78.240]:33346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kZC7f-0004Y4-IW for 44303@debbugs.gnu.org; Sun, 01 Nov 2020 07:06:13 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=Fw5u6K/4DFHCa26emsWZpZSrDT/eEwCnOVApd87XRLM=; b=HSBf+zThczhGmlmZfaBSDEVyHJ D3JFlgBOlWPMjYCCzHhCK5UF9Srlkd4JDF4Jl14C2tCbO+xIj8A8+feJZm+L08z31vlWClYZJn/By cxxtdpaovARGMx93bkIktYp/kdn4D45RXfVIxZ8M8Ae7UXkpaqY9WG/QIHPgS5lur/1s=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kZC7W-00083i-0s; Sun, 01 Nov 2020 13:06:05 +0100 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#44303: 28.0.50; json-pretty-print-buffer creates spurious lock file References: <87wnz9pd2j.fsf@runbox.com> <87o8kjhmg4.fsf@gnus.org> <83r1pfalc4.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAJ1BMVEUIBQQiGhtHPjwx KypgWFUnHiCQiniooJHEuLGCenDZz8aMe4X///8w5ysyAAAAAWJLR0QMgbNRYwAAAAd0SU1FB+QL AQsmO/DtIKEAAAGrSURBVDjLjZK/T+NQDMftXqqu7xEiVmg6ICaSkIWpaqOrgOVClf8AFdgYqvrB hBCQiBmBxC0IEOllug3p7p/jvVKgJEZgOT/kT7527GcAAUIIAJDaUb4ZfG3uxOcB212A7mvU9uKd OOx40LPrZx3PvL3YTU6DNBukVq5ktpurQT4F10QjRUQWqZhGdE70Bs73M6JTi1Kkw8de7x0M9fc0 tGgk9XNvRqFIK3SNIzmmPKN0Cvqh33cDz8WuD82gq/0bDRoTjh6G+CUdpzQSISXG+h5L5zMtfrNG pSYXbAPUHjigx9gYc5KLv9AoWHAP1h8ulcpx4dhaZcB4vThotKuAsqPieIEBWyq7OFlZrILoiYpC MTVaW0/ZmKpx8CNfpUMGBG6NfncY0F+qRf+5E048sR1xQHrgz3kMcBJ9cbPCPhvVW5II4E1WAQaB +6IqWT1q6s6wskIIKEwQy7l+DH9eTYZUzoVusDZpGeOypp6EZtvQjktgvhWZ4tJ0zzWiwcdc1uXG zhT4H0GnZU7IkU643C4lMX9qB2GweTvTRmJHpjjYzWbr392sQAiUzxdMYtqOsupyAAAAJXRFWHRk YXRlOmNyZWF0ZQAyMDIwLTExLTAxVDExOjM4OjU5KzAwOjAwB6UZzAAAACV0RVh0ZGF0ZTptb2Rp ZnkAMjAyMC0xMS0wMVQxMTozODo1OSswMDowMHb4oXAAAAAASUVORK5CYII= X-Now-Playing: Melanie de Biasio's _A stomach is burning_: "Blue" Date: Sun, 01 Nov 2020 13:06:00 +0100 In-Reply-To: <83r1pfalc4.fsf@gnu.org> (Eli Zaretskii's message of "Fri, 30 Oct 2020 15:34:51 +0200") Message-ID: <874km9ffiv.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > But we then have this: > > if (modification_hooks_inhibited) > { > signal_after_change (BEGV, size_a, ZV - BEGV); > update_compositions (BEGV, ZV, CHECK_INSIDE); > } > > Does this not work, or fail [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44303 Cc: simenheg@runbox.com, 44303@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > But we then have this: > > if (modification_hooks_inhibited) > { > signal_after_change (BEGV, size_a, ZV - BEGV); > update_compositions (BEGV, ZV, CHECK_INSIDE); > } > > Does this not work, or fail to unlock the file? This does not unlock the file in the test case. >> But is that even needed here? Don't the later >> Finsert_buffer_substring/del_range_both functions do the necessary >> bookkeeping? > > We disable that by binding inhibit_modification_hooks, and we do that > for speed, see the comment before that code. Ah, I see. The missing piece of the puzzle was this bit, which I wasn't aware of: ---- Setting this variable non-nil also inhibits file locks and checks whether files are locked by another Emacs session, as well as handling of the active region per =E2=80=98select-active-regions=E2=80=99. ---- --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 07 05:32:27 2020 Received: (at 44303) by debbugs.gnu.org; 7 Nov 2020 10:32:27 +0000 Received: from localhost ([127.0.0.1]:57993 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kbLWF-0007iQ-0V for submit@debbugs.gnu.org; Sat, 07 Nov 2020 05:32:27 -0500 Received: from eggs.gnu.org ([209.51.188.92]:33098) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kbLWD-0007iE-7t for 44303@debbugs.gnu.org; Sat, 07 Nov 2020 05:32:25 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:56262) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kbLW6-0005Ln-1C; Sat, 07 Nov 2020 05:32:19 -0500 Received: from [176.228.60.248] (port=1738 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kbLW3-0005AL-CA; Sat, 07 Nov 2020 05:32:17 -0500 Date: Sat, 07 Nov 2020 12:32:14 +0200 Message-Id: <83h7q17901.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-Reply-To: <874km9ffiv.fsf@gnus.org> (message from Lars Ingebrigtsen on Sun, 01 Nov 2020 13:06:00 +0100) Subject: Re: bug#44303: 28.0.50; json-pretty-print-buffer creates spurious lock file References: <87wnz9pd2j.fsf@runbox.com> <87o8kjhmg4.fsf@gnus.org> <83r1pfalc4.fsf@gnu.org> <874km9ffiv.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44303 Cc: simenheg@runbox.com, 44303@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: simenheg@runbox.com, 44303@debbugs.gnu.org > Date: Sun, 01 Nov 2020 13:06:00 +0100 > > Eli Zaretskii writes: > > > But we then have this: > > > > if (modification_hooks_inhibited) > > { > > signal_after_change (BEGV, size_a, ZV - BEGV); > > update_compositions (BEGV, ZV, CHECK_INSIDE); > > } > > > > Does this not work, or fail to unlock the file? > > This does not unlock the file in the test case. Should be fixed now on master. I wonder whether we should actually cherry-pick this to the release branch. The original recipe doesn't trigger the problem there, but that's because json-pretty-print-buffer does modify the buffer on emacs-27. If it didn't, we'd probably have the same problem in Emacs 27. Thoughts? From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 09 03:24:13 2020 Received: (at 44303) by debbugs.gnu.org; 9 Nov 2020 08:24:13 +0000 Received: from localhost ([127.0.0.1]:33858 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kc2TE-0003CG-Ut for submit@debbugs.gnu.org; Mon, 09 Nov 2020 03:24:13 -0500 Received: from aibo.runbox.com ([91.220.196.211]:56518) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kc2TC-0003C7-TN for 44303@debbugs.gnu.org; Mon, 09 Nov 2020 03:24:12 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=selector1; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From; bh=eJM3+JY/gNIdSdeUEwKAIgQI1a+l6HIzgshzTb8gm7Q=; b=X5qvVF/TC+mADC24ZM9enmMVpg gQq/toZAUMlr+GAYIGNIEmJeClfhldHpZDoA67wXWh0/+M7UPf1/9jH5t6SUNNzQJcwfrWxu/VoAj mNM10/NupzUINyKJAM23d9f53jAogzrgzRdXNvd16t2aqVsVYEFiM7jBBQbxJDj9scUE8S8zqBDJ4 h13iCQJMYi5sevGFsXh9ZfgodqG/MO3FSK3di+mDiSKGrIqkHZVaqHpHNR3GSJOgtO/OrK8Wr88ls RcRzpRokkw6ylVxIdKkpyoZRac0uI/3abc++BGTPMUOEwl31uTcf55vRggiZBBhtJh5yjaJWul+7Z 3fIlXYeg==; Received: from [10.9.9.72] (helo=submission01.runbox) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1kc2TA-0006Wo-Ad; Mon, 09 Nov 2020 09:24:08 +0100 Received: by submission01.runbox with esmtpsa [Authenticated alias (963757)] (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) id 1kc2T6-0006xW-0P; Mon, 09 Nov 2020 09:24:04 +0100 From: =?utf-8?Q?Simen_Heggest=C3=B8yl?= To: Eli Zaretskii Subject: Re: bug#44303: 28.0.50; json-pretty-print-buffer creates spurious lock file References: <87wnz9pd2j.fsf@runbox.com> <87o8kjhmg4.fsf@gnus.org> <83r1pfalc4.fsf@gnu.org> <874km9ffiv.fsf@gnus.org> <83h7q17901.fsf@gnu.org> Date: Mon, 09 Nov 2020 09:24:03 +0100 In-Reply-To: <83h7q17901.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 07 Nov 2020 12:32:14 +0200") Message-ID: <87y2jblyzg.fsf@runbox.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44303 Cc: Lars Ingebrigtsen , 44303@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Eli Zaretskii writes: > Should be fixed now on master. Hm, did you push it? I'm still experiencing the bug on master (as of 795b7da16b). > I wonder whether we should actually cherry-pick this to the release > branch. The original recipe doesn't trigger the problem there, but > that's because json-pretty-print-buffer does modify the buffer on > emacs-27. If it didn't, we'd probably have the same problem in Emacs > 27. Right. You can see the bug in Emacs 27 too by using a test file like this instead: { } From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 09 09:03:25 2020 Received: (at 44303) by debbugs.gnu.org; 9 Nov 2020 14:03:25 +0000 Received: from localhost ([127.0.0.1]:34312 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kc7lV-000579-I0 for submit@debbugs.gnu.org; Mon, 09 Nov 2020 09:03:25 -0500 Received: from quimby.gnus.org ([95.216.78.240]:41976) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kc7lS-00056t-7u for 44303@debbugs.gnu.org; Mon, 09 Nov 2020 09:03:23 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=IXmWdGdJHqozJzZA+2WvawOSWuhtj8Ib3hC5Si404uM=; b=V79Z9CMkItCgESXZTaE/FsM85x qnF9Ol6mGVa/1WFWSyanN7wx0e7XvITV1k208Z6zPPlOj0SgkmHVzji+V1gRidkY0tKG+wyg8Z7Xb m6LEJ+yFj0Kx4uGui4PKeoSsFAMZfo7r++rcNPaanv2ryb7r9LGvGl2B4PBOQ3cTanRE=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kc7lE-0006V4-Hm; Mon, 09 Nov 2020 15:03:14 +0100 From: Lars Ingebrigtsen To: Eli Zaretskii Subject: Re: bug#44303: 28.0.50; json-pretty-print-buffer creates spurious lock file References: <87wnz9pd2j.fsf@runbox.com> <87o8kjhmg4.fsf@gnus.org> <83r1pfalc4.fsf@gnu.org> <874km9ffiv.fsf@gnus.org> <83h7q17901.fsf@gnu.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAGFBMVEWNcEWKazxBPTcZ GRhqVjalop5iW1D////0J7WRAAAAAWJLR0QHFmGI6wAAAAd0SU1FB+QLCQ0fOKZZqPwAAAF1SURB VDjLjdNLbsIwEAbgCSpdZ1BOMKZdV3EPUFo3ayph1mDA9z9C52EnQINUL6I4n//xIwkANOh8aW/I zXogjR6CuwYbBqjwHqQtDHQYNAK0VlgeAbApoGMq/Ghhegju33ApQH8BZXKNQMuQJtCeAt+1IV0D DlKLa2Lb5Tp5BSfQtCGfCzT8vBuSAWcMuuUWClCFI3aS2Foic60RUMESOU3QYLeRUtwR8LXUgd8j Fgg3oMUFUCC7aXIF3YfASaDFzXDuMFxD8vIcN1/nq50LZMcHwltw9UhkN+GZ4SSfVee9fQzLnVxj ZEgyNd7DnkUOcR5kulmQW1dhr6/LQNbzWSHKsj8Meo1U0IiB10hP0i5RI98GGvEKFC2SFSySFF4s ImfCv4BGssJrjLsKsNDIkOospRa0K1vSfQRgRT7MRARmIwBPNBthCHMRhZw1crv9AtZqJMofRTTB GBHoaT3CGBHgYYcRakTB0+sINWLQ0x3Qhe9+AZmV4HV5ZwfbAAAAJXRFWHRkYXRlOmNyZWF0ZQAy MDIwLTExLTA5VDEzOjMxOjU1KzAwOjAwL19ydgAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMC0xMS0w OVQxMzozMTo1NSswMDowMF4CysoAAAAASUVORK5CYII= X-Now-Playing: Chrome Hoof's _Chrome Black Gold_: "When the Lightning Strikes" Date: Mon, 09 Nov 2020 15:03:07 +0100 In-Reply-To: <83h7q17901.fsf@gnu.org> (Eli Zaretskii's message of "Sat, 07 Nov 2020 12:32:14 +0200") Message-ID: <87lffamxus.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > I wonder whether we should actually cherry-pick this to the release > branch. (You've possibly forgotten to push the change?) Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44303 Cc: simenheg@runbox.com, 44303@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > I wonder whether we should actually cherry-pick this to the release > branch. (You've possibly forgotten to push the change?) It's a somewhat obscure bug that'll basically only manifest in situations like this, so I'm not sure that it's worth it. But I haven't seen the patch -- if it's totally trivial, then sure. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 09 10:58:14 2020 Received: (at 44303) by debbugs.gnu.org; 9 Nov 2020 15:58:14 +0000 Received: from localhost ([127.0.0.1]:35287 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kc9Yb-00062s-Of for submit@debbugs.gnu.org; Mon, 09 Nov 2020 10:58:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:39984) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kc9Ya-00062g-99 for 44303@debbugs.gnu.org; Mon, 09 Nov 2020 10:58:12 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45657) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kc9YU-0007a2-QO; Mon, 09 Nov 2020 10:58:06 -0500 Received: from [176.228.60.248] (port=4626 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kc9YS-0004VE-Fg; Mon, 09 Nov 2020 10:58:05 -0500 Date: Mon, 09 Nov 2020 17:58:12 +0200 Message-Id: <83wnyu4j57.fsf@gnu.org> From: Eli Zaretskii To: Simen =?utf-8?Q?Heggest=C3=B8yl?= In-Reply-To: <87y2jblyzg.fsf@runbox.com> (message from Simen =?utf-8?Q?Heg?= =?utf-8?Q?gest=C3=B8yl?= on Mon, 09 Nov 2020 09:24:03 +0100) Subject: Re: bug#44303: 28.0.50; json-pretty-print-buffer creates spurious lock file References: <87wnz9pd2j.fsf@runbox.com> <87o8kjhmg4.fsf@gnus.org> <83r1pfalc4.fsf@gnu.org> <874km9ffiv.fsf@gnus.org> <83h7q17901.fsf@gnu.org> <87y2jblyzg.fsf@runbox.com> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44303 Cc: larsi@gnus.org, 44303@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Simen Heggestøyl > Cc: Lars Ingebrigtsen , 44303@debbugs.gnu.org > Date: Mon, 09 Nov 2020 09:24:03 +0100 > > Eli Zaretskii writes: > > > Should be fixed now on master. > > Hm, did you push it? I'm still experiencing the bug on master (as of > 795b7da16b). Sorry, I forgot to push. Done now, please check. > > I wonder whether we should actually cherry-pick this to the release > > branch. The original recipe doesn't trigger the problem there, but > > that's because json-pretty-print-buffer does modify the buffer on > > emacs-27. If it didn't, we'd probably have the same problem in Emacs > > 27. > > Right. You can see the bug in Emacs 27 too by using a test file like > this instead: > > { > } OK, will cherry-pick. Thanks. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 09 11:08:13 2020 Received: (at 44303) by debbugs.gnu.org; 9 Nov 2020 16:08:13 +0000 Received: from localhost ([127.0.0.1]:35317 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kc9iH-0008Ud-Kp for submit@debbugs.gnu.org; Mon, 09 Nov 2020 11:08:13 -0500 Received: from eggs.gnu.org ([209.51.188.92]:43154) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kc9iG-0008UQ-88 for 44303@debbugs.gnu.org; Mon, 09 Nov 2020 11:08:12 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45930) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kc9iA-0002uD-FC; Mon, 09 Nov 2020 11:08:06 -0500 Received: from [176.228.60.248] (port=1257 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kc9hz-0001QM-NL; Mon, 09 Nov 2020 11:07:56 -0500 Date: Mon, 09 Nov 2020 18:08:02 +0200 Message-Id: <83sg9i4iot.fsf@gnu.org> From: Eli Zaretskii To: Lars Ingebrigtsen In-Reply-To: <87lffamxus.fsf@gnus.org> (message from Lars Ingebrigtsen on Mon, 09 Nov 2020 15:03:07 +0100) Subject: Re: bug#44303: 28.0.50; json-pretty-print-buffer creates spurious lock file References: <87wnz9pd2j.fsf@runbox.com> <87o8kjhmg4.fsf@gnus.org> <83r1pfalc4.fsf@gnu.org> <874km9ffiv.fsf@gnus.org> <83h7q17901.fsf@gnu.org> <87lffamxus.fsf@gnus.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44303 Cc: simenheg@runbox.com, 44303@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: simenheg@runbox.com, 44303@debbugs.gnu.org > Date: Mon, 09 Nov 2020 15:03:07 +0100 > > Eli Zaretskii writes: > > > I wonder whether we should actually cherry-pick this to the release > > branch. > > (You've possibly forgotten to push the change?) > > It's a somewhat obscure bug that'll basically only manifest in > situations like this, so I'm not sure that it's worth it. But I haven't > seen the patch -- if it's totally trivial, then sure. I think it's totally trivial, yes. But I'm obviously biased. From debbugs-submit-bounces@debbugs.gnu.org Mon Nov 09 11:37:02 2020 Received: (at 44303-done) by debbugs.gnu.org; 9 Nov 2020 16:37:02 +0000 Received: from localhost ([127.0.0.1]:35404 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcAAA-00052b-5k for submit@debbugs.gnu.org; Mon, 09 Nov 2020 11:37:02 -0500 Received: from aibo.runbox.com ([91.220.196.211]:43160) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kcAA7-000525-86 for 44303-done@debbugs.gnu.org; Mon, 09 Nov 2020 11:37:00 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=selector1; h=Content-Transfer-Encoding:Content-Type:MIME-Version: Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From; bh=zhjNoKctHY1XRs8ejmEF5FQsWMbsoUHdetycR8LKriw=; b=Ovkrbd9Fa2xmJdHr/4nGfeT8ep UT9t5yafAKtPJNF+JunknutbexIvd7JWeuj9+f7T4b/1ni9ftHN8QEXyUIIRlBB486BzVzRv0vCP0 ul7m68X4h8S0uj/Ifo7lpqjVq+BAmU6ZWC5qF7CgdHK5lfqIXg9S3B0+uK/MGIAzwfx+EkURxOjeQ f1+80OkkqKa9KmTWszU6zWB80UnyAasiegV3x8JmVyvPcPrzxT12n7yccNpgVXsLIDCfnZMuHV3up ONLaMJHGmOJOoOBl3eVty2WCd2KG2P5scSrK6rrHsAhEdS+NFNKCZfKwxBeazjJP3rqepiOvuD09T II3SkKQA==; Received: from [10.9.9.73] (helo=submission02.runbox) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1kcAA5-0003WN-I5; Mon, 09 Nov 2020 17:36:57 +0100 Received: by submission02.runbox with esmtpsa [Authenticated alias (963757)] (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) id 1kcAA2-00086R-N5; Mon, 09 Nov 2020 17:36:54 +0100 From: =?utf-8?Q?Simen_Heggest=C3=B8yl?= To: Eli Zaretskii Subject: Re: bug#44303: 28.0.50; json-pretty-print-buffer creates spurious lock file References: <87wnz9pd2j.fsf@runbox.com> <87o8kjhmg4.fsf@gnus.org> <83r1pfalc4.fsf@gnu.org> <874km9ffiv.fsf@gnus.org> <83h7q17901.fsf@gnu.org> <87y2jblyzg.fsf@runbox.com> <83wnyu4j57.fsf@gnu.org> Date: Mon, 09 Nov 2020 17:36:54 +0100 In-Reply-To: <83wnyu4j57.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 09 Nov 2020 17:58:12 +0200") Message-ID: <87361itrkp.fsf@simenheg@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 44303-done Cc: 44303-done@debbugs.gnu.org, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Eli Zaretskii writes: >> From: Simen Heggest=C3=B8yl >> Cc: Lars Ingebrigtsen , 44303@debbugs.gnu.org >> Date: Mon, 09 Nov 2020 09:24:03 +0100 >> >> Eli Zaretskii writes: >> >> > Should be fixed now on master. >> >> Hm, did you push it? I'm still experiencing the bug on master (as of >> 795b7da16b). > > Sorry, I forgot to push. Done now, please check. Works for me. Thanks! From debbugs-submit-bounces@debbugs.gnu.org Sat Nov 14 08:26:15 2020 Received: (at 44303-done) by debbugs.gnu.org; 14 Nov 2020 13:26:15 +0000 Received: from localhost ([127.0.0.1]:50114 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdvZH-0004am-KW for submit@debbugs.gnu.org; Sat, 14 Nov 2020 08:26:15 -0500 Received: from eggs.gnu.org ([209.51.188.92]:58096) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kdvZF-0004aY-WE for 44303-done@debbugs.gnu.org; Sat, 14 Nov 2020 08:26:14 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:54279) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kdvZA-0001bE-FQ; Sat, 14 Nov 2020 08:26:08 -0500 Received: from [176.228.60.248] (port=2039 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kdvZ9-0001Kq-17; Sat, 14 Nov 2020 08:26:07 -0500 Date: Sat, 14 Nov 2020 15:25:55 +0200 Message-Id: <83wnyoul24.fsf@gnu.org> From: Eli Zaretskii To: simenheg@runbox.com In-Reply-To: <83wnyu4j57.fsf@gnu.org> (message from Eli Zaretskii on Mon, 09 Nov 2020 17:58:12 +0200) Subject: Re: bug#44303: 28.0.50; json-pretty-print-buffer creates spurious lock file References: <87wnz9pd2j.fsf@runbox.com> <87o8kjhmg4.fsf@gnus.org> <83r1pfalc4.fsf@gnu.org> <874km9ffiv.fsf@gnus.org> <83h7q17901.fsf@gnu.org> <87y2jblyzg.fsf@runbox.com> <83wnyu4j57.fsf@gnu.org> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44303-done Cc: 44303-done@debbugs.gnu.org, larsi@gnus.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > Date: Mon, 09 Nov 2020 17:58:12 +0200 > From: Eli Zaretskii > Cc: larsi@gnus.org, 44303@debbugs.gnu.org > > > > I wonder whether we should actually cherry-pick this to the release > > > branch. The original recipe doesn't trigger the problem there, but > > > that's because json-pretty-print-buffer does modify the buffer on > > > emacs-27. If it didn't, we'd probably have the same problem in Emacs > > > 27. > > > > Right. You can see the bug in Emacs 27 too by using a test file like > > this instead: > > > > { > > } > > OK, will cherry-pick. Now done. From unknown Sun Jun 22 00:54:33 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 13 Dec 2020 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator