From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 28 22:55:43 2020 Received: (at submit) by debbugs.gnu.org; 29 Oct 2020 02:55:43 +0000 Received: from localhost ([127.0.0.1]:51392 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXy6I-0005E6-Sn for submit@debbugs.gnu.org; Wed, 28 Oct 2020 22:55:43 -0400 Received: from lists.gnu.org ([209.51.188.17]:52852) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXy6H-0005Dz-J2 for submit@debbugs.gnu.org; Wed, 28 Oct 2020 22:55:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44224) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXy6H-0003LU-9j for bug-gnu-emacs@gnu.org; Wed, 28 Oct 2020 22:55:41 -0400 Received: from mail1.ccss.com ([159.203.255.73]:52402) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXy6F-0006TN-9Q for bug-gnu-emacs@gnu.org; Wed, 28 Oct 2020 22:55:41 -0400 Received: by mail1.ccss.com (Postfix, from userid 114) id 98705BF88E; Wed, 28 Oct 2020 19:55:37 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail1.ccss.com X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.2 Received: from ccss.com (unknown [192.168.76.11]) by mail1.ccss.com (Postfix) with ESMTP id D1D85BF651 for ; Wed, 28 Oct 2020 19:55:36 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by ccss.com (Postfix) with ESMTP id AD0D31761293 for ; Wed, 28 Oct 2020 19:55:36 -0700 (PDT) Received: from ccss.com ([127.0.0.1]) by localhost (ccss.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id HmeOjfmnnzhh for ; Wed, 28 Oct 2020 19:55:30 -0700 (PDT) Received: from klaatu (klaatu.lan [192.168.42.3]) (Authenticated sender: hugh) by ccss.com (Postfix) with ESMTPSA id 5F1D81760635 for ; Wed, 28 Oct 2020 19:55:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ccss.com; s=mail; t=1603940130; bh=0y/ZdCFTElSPfMyRAzPnk76vn0cHIr/UoRGkAdkaMjQ=; h=From:To:Subject:Date:From; b=SExhkWCzpsH7/PjwHfUWiDQrMSCH7jrdyUmitRW09cImvLojXWACdeHzwHjWjRfg0 hlE7bFrKGGskM9gzUHYvdgBdJr1k8Im27f48Z8cduTUvad++QKwCQYYwjoACt+RF68 tdNRm0cld/KRezZ766HKXSFxTxv2d+fMxM/K5iM5s8TUrR2TstzlK/DEP7nxcIqY96 ORIxNwK8ZO75SyI2sMPQznv/bSWFO7BNcEYQLkUOiDjlPDPDMd21hNDXWsAGyXFtXI M7gCO9PQttLb0u/PNlF1IVVTmFhrZim7uIzkPY1DinBe/SNv0DhFSY9/l7sBPT++jO PupsCQ4oA485w== User-agent: mu4e 1.5.5; emacs 27.1 From: Hugh Daschbach To: bug-gnu-emacs@gnu.org Subject: 28.0.50; D-Bus GetManagedObjects doesn't enumerate all paths. Message-ID: <87wnz9eo66.fsf@ccss.com> Date: Wed, 28 Oct 2020 19:55:29 -0700 MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" Received-SPF: permerror client-ip=159.203.255.73; envelope-from=hugh@ccss.com; helo=mail1.ccss.com X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/28 22:55:37 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -16 X-Spam_score: -1.7 X-Spam_bar: - X-Spam_report: (-1.7 / 5.0 requ) BAYES_00=-1.9, DKIM_INVALID=0.1, DKIM_SIGNED=0.1, SPF_HELO_NONE=0.001, T_SPF_PERMERROR=0.01 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain If a D-Bus interface is registered on more than one path, processing an incoming GetManagedObjects method call only reports a single path. The attached patch adds a test case to demonstrate this issue. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Add-tests-for-D-Bus-GetManagedObjects-inquiry.patch Content-Description: New test for GetManagedObjects. >From 43a446ce12485d669daed978796dc032113d73e5 Mon Sep 17 00:00:00 2001 From: Hugh Daschbach Date: Wed, 28 Oct 2020 19:36:19 -0700 Subject: [PATCH] Add tests for D-Bus GetManagedObjects inquiry. * test/lisp/net/dbus-tests.el (dbus-test09-get-managed-objects): New test. --- test/lisp/net/dbus-tests.el | 82 +++++++++++++++++++++++++++++++++++++ 1 file changed, 82 insertions(+) diff --git a/test/lisp/net/dbus-tests.el b/test/lisp/net/dbus-tests.el index 2186d454aee..3bb2264defb 100644 --- a/test/lisp/net/dbus-tests.el +++ b/test/lisp/net/dbus-tests.el @@ -1889,6 +1889,88 @@ dbus-test08-register-monitor ;; Cleanup. (dbus-unregister-service :session dbus--test-service))) +(ert-deftest dbus-test09-get-managed-objects () + "Check `dbus-get-all-managed-objects'." + (skip-unless dbus--test-enabled-session-bus) + (dbus-ignore-errors (dbus-unregister-service :session dbus--test-service)) + (dbus-register-service :session dbus--test-service) + + (unwind-protect + (let ((path1 (concat dbus--test-path "/path1")) + (path2 (concat dbus--test-path "/path2")) + (path3 (concat dbus--test-path "/path3"))) + + (should-not + (dbus-get-all-managed-objects :session dbus--test-service dbus--test-path)) + + (should + (equal + (dbus-register-property + :session dbus--test-service path1 dbus--test-interface + "Property1" :readwrite "Simple string one.") + `((:property :session ,dbus--test-interface "Property1") + (,dbus--test-service ,path1)))) + + (should + (equal + (dbus-get-property + :session dbus--test-service path1 dbus--test-interface + "Property1") + "Simple string one.")) + + (should + (equal + (dbus-register-property + :session dbus--test-service path2 dbus--test-interface + "Property1" :readwrite "Simple string two.") + `((:property :session ,dbus--test-interface "Property1") + (,dbus--test-service ,path2)))) + + (should + (equal + (dbus-register-property + :session dbus--test-service path3 dbus--test-interface + "Property1" :readwrite "Simple string three.") + `((:property :session ,dbus--test-interface "Property1") + (,dbus--test-service ,path3)))) + + (should + (equal + (dbus-get-property + :session dbus--test-service path1 dbus--test-interface + "Property1") + "Simple string one.")) + + (should + (equal + (dbus-get-property + :session dbus--test-service path2 dbus--test-interface + "Property1") + "Simple string two.")) + + (should + (equal + (dbus-get-property + :session dbus--test-service path3 dbus--test-interface + "Property1") + "Simple string three.")) + + (let ((result (dbus-get-all-managed-objects :session dbus--test-service dbus--test-path))) + (should + (= 3 (length result))) + + (should + (assoc-string path1 result)) + + (should + (assoc-string path2 result)) + + (should + (assoc-string path3 result)))) + + ;; Cleanup. + (dbus-unregister-service :session dbus--test-service))) + (defun dbus-test-all (&optional interactive) "Run all tests for \\[dbus]." (interactive "p") base-commit: bb3d13ac3586d3577605d3d8809d31c62a267c99 -- 2.28.0 --=-=-= Content-Type: text/plain Cheers, Hugh In GNU Emacs 28.0.50 (build 20, x86_64-pc-linux-gnu, X toolkit, cairo version 1.17.3, Xaw3d scroll bars) of 2020-10-11 built on klaatu Repository revision: 0f79544368c0dc343edcd97c3c7992aeab415b68 Repository branch: submission Windowing system distributor 'The X.Org Foundation', version 11.0.12009000 System Description: Artix Linux Configured using: 'configure --with-x-toolkit=lucid' Configured features: XAW3D XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GSETTINGS GLIB NOTIFY INOTIFY ACL GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF ZLIB TOOLKIT_SCROLL_BARS LUCID X11 XDBE XIM MODULES THREADS LIBSYSTEMD JSON PDUMPER LCMS2 Important settings: value of $LANG: en_US.UTF-8 locale-coding-system: utf-8-unix Major mode: ERT-Results Minor modes in effect: tooltip-mode: t global-eldoc-mode: t electric-indent-mode: t mouse-wheel-mode: t tool-bar-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t buffer-read-only: t line-number-mode: t transient-mark-mode: t Load-path shadows: None found. Features: (shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail rmail-loaddefs auth-source eieio eieio-core eieio-loaddefs password-cache json map text-property-search time-date mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils thingatpt edmacro kmacro cl-extra vc-git diff-mode easy-mmode bug-reference dbus-tests dbus cl-seq cl-macs pcase xml subr-x seq byte-opt gv bytecomp byte-compile cconv ert-x ert pp ewoc debug backtrace help-mode easymenu find-func cl-loaddefs cl-lib tooltip eldoc electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe tabulated-list replace newcomment text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer select scroll-bar mouse jit-lock font-lock syntax facemenu font-core term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech european ethiopic indian cyrillic chinese composite charscript charprop case-table epa-hook jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button loaddefs faces cus-face macroexp files window text-properties overlay sha1 md5 base64 format env code-pages mule custom widget hashtable-print-readable backquote threads dbusbind inotify lcms2 dynamic-setting system-font-setting font-render-setting cairo x-toolkit x multi-tty make-network-process emacs) Memory information: ((conses 16 122955 5639) (symbols 48 10363 1) (strings 32 26544 1387) (string-bytes 1 832865) (vectors 16 15402) (vector-slots 8 202326 11404) (floats 8 68 231) (intervals 56 612 0) (buffers 992 14)) --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 29 11:59:41 2020 Received: (at 44298) by debbugs.gnu.org; 29 Oct 2020 15:59:41 +0000 Received: from localhost ([127.0.0.1]:54754 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYAKz-0008UY-0v for submit@debbugs.gnu.org; Thu, 29 Oct 2020 11:59:41 -0400 Received: from mout.gmx.net ([212.227.15.18]:57649) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYAKw-0008UL-K1 for 44298@debbugs.gnu.org; Thu, 29 Oct 2020 11:59:39 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1603987170; bh=30KdULKB3B/yUl5tXuj8gL2yazseSf64MktJcAytus8=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=Kr0ZW1h2m8h4Lg25rFr6ImlfrNYIkQGf1nAgFNFn97Ewf4bRDvF27nyWoCoMbxfdC VLhgC53g8zQPQ5LMCnEouZ82cz1ecUnTKvWTG0dhpkHbAwHDAVVCoD9sU+7n7mvkTF 0TLso1CsbvBRvGPi2KBZRpXQTVVyewz4VmCR4/cg= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([79.140.118.53]) by mail.gmx.com (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MFsZ3-1kbB0P1t1j-00HO6B; Thu, 29 Oct 2020 16:59:30 +0100 From: Michael Albinus To: Hugh Daschbach Subject: Re: bug#44298: 28.0.50; D-Bus GetManagedObjects doesn't enumerate all paths. References: <87wnz9eo66.fsf@ccss.com> Date: Thu, 29 Oct 2020 16:59:28 +0100 In-Reply-To: <87wnz9eo66.fsf@ccss.com> (Hugh Daschbach's message of "Wed, 28 Oct 2020 19:55:29 -0700") Message-ID: <87d0113twf.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:kiwJbhCFcrAWdkv+K8sEObQ93vx00mOXkVVNCUxoj7+cA3kP6BD ZpnG4kGZ4/lObgp6iqCneRxLKRsG9Z090ZjfD1SNETsk3UqdXmMX1cyTMO+2pZtDUkBJt9U 2ZZkoN4lUvz7zyCA8IgHxY2ECQRrpkcYtkiRRDStC5QRR5cRRku9kMe6jIvlIMfiF6WcHXb O8VEEdo3hD40pXX8fMukw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:CYcQXaeEGrY=:IJZPsQ9tbsDffSGDShrB7L NKfDNl9jw1Qt5qbfvi/Xv2/9Tnh6zkbYh4ok+Vf1BiwZg8g27QFE5SOGx7XxMzImji4G7cPmh iNr6vjNHwV0iGLtzUbstOzKAWYIDA1lUKXd65gMQOw1E9MCu25Z3jTLQcgVrSEbfQQ/9/TKEJ kSdDSCIrk/7tVZ8wJ427DYOSahLtm+5KYZoKdZRezFp1lRsBTSAP7yNKBAHg0854UIHe29zqv OPUBPWaCa4aPtTHiDaUeWLeBYh/Ut6jEz+8C5qJbo83OjzBRDDSLvvCoYaiQ6SvrGbX3xg3MP PXsFyuKlvv6YRGTFlaS/LrXO+P8SlYLyQTJZTj0VgXJDK3xWu+zbRCqyOF/i7xuO0aFfu0Mim 3jeO02ar3UiHiVTrDBa0xTnOon7s7/fopLo7tDz+X5+iE0Rx9tafngJUSvQ1V9E+Z9OGEBCEj +iF/wywaESRl9WlCvE+OAQOZPlIBXDe92JC0JMRkzJZu9u+Ufu7Quj2P3oSxiFffLkYqyloKq US0S0ZW+ImU3KW0BOUeUE/DYBW5JSQIgQRmzS56NW26WqAmeFrC7DDL3xp8PlErtb2s0e3shZ jHKY18EaR1c1nVyzk6ccJwY1Tb0rIY70qPEzsMRcMTwwG1vNqw9Fdgn7uQtDGndAsgtYH30es G0mBmmpYliMVrt6TjV2Oc5CvrSaQJsBPjPv5XwEjJVNi8PM6OuQPtxif7ozqVtVlDFG+iUMGm R+62lgZh3q0SLkxOXiXT1/0xDSrhQMw3t9qitkL/337p7Jz0cdIsFMOqa1UddqbYNW7YZquQT y8JhhhpXBFNsR5slBJb/Q+1tyz1o58bBsZ3tBre3mlBW9f5mOZNGs2A6pJGET3PWjomZTwH8K weqfKCYdUuMSAyqGNuXA== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44298 Cc: 44298@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hugh Daschbach writes: Hi Hugh, > If a D-Bus interface is registered on more than one path, processing an > incoming GetManagedObjects method call only reports a single path. Thanks for the report! I've pushed a fix to master, which should solve it. > The attached patch adds a test case to demonstrate this issue. Thanks also for this. I've pushed it to master as well. > Cheers, > Hugh Best regards, Michael. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 29 23:04:03 2020 Received: (at 44298) by debbugs.gnu.org; 30 Oct 2020 03:04:03 +0000 Received: from localhost ([127.0.0.1]:55705 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYKhu-0008SV-UH for submit@debbugs.gnu.org; Thu, 29 Oct 2020 23:04:03 -0400 Received: from mail1.ccss.com ([159.203.255.73]:60216) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYKhs-0008Rw-Td; Thu, 29 Oct 2020 23:04:01 -0400 Received: by mail1.ccss.com (Postfix, from userid 114) id 3DC48BF8A7; Thu, 29 Oct 2020 20:03:55 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail1.ccss.com X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.2 Received: from ccss.com (unknown [192.168.76.11]) by mail1.ccss.com (Postfix) with ESMTP id 66AC2BF473; Thu, 29 Oct 2020 20:03:54 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by ccss.com (Postfix) with ESMTP id 34BB11761252; Thu, 29 Oct 2020 20:03:54 -0700 (PDT) Received: from ccss.com ([127.0.0.1]) by localhost (ccss.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id rRLGZ8KrVoo3; Thu, 29 Oct 2020 20:03:52 -0700 (PDT) Received: from klaatu (klaatu.lan [192.168.42.3]) (Authenticated sender: hugh) by ccss.com (Postfix) with ESMTPSA id 213D51760443; Thu, 29 Oct 2020 20:03:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ccss.com; s=mail; t=1604027032; bh=BqH3QElYyFfBVJ/oWAiwT+DaLSoQWcaU3CsM775RAZw=; h=References:From:To:Cc:Subject:In-reply-to:Date:From; b=axhfou9P3p6mIuyzobrPmO/CgdmVOadWN/63+YYV7CIym+tEtVNaL8N8E1UWPsqdJ 7OCgdwEKI5KmpZzNxz0HT5ZcNxvvgvNepotqCCFAIMKuqefsNu4lFwkRSoZtqRVHCF jXe9zEJQPOozofZGTwebFYFmpUYEmCMHTSt+wFfWYW5Vi8TN/TWkajetXzHeskzoxl MYB3DQ5F70Gsdt722L4hP2E45ou6RTkTDEvXYV8DxpT1uBjsHPM0ouA3/eqayOppAM 7BMHFR8NDjHdu2Nmt8D2WPjd9dODSdlF4YtGXO5h2tvZSshakok53PyDAYAeXHBc+e aUOaKYHNmxSwg== References: <87wnz9eo66.fsf@ccss.com> <87d0113twf.fsf@gmx.de> User-agent: mu4e 1.5.5; emacs 27.1 From: Hugh Daschbach To: Michael Albinus Subject: Re: bug#44298: 28.0.50; D-Bus GetManagedObjects doesn't enumerate all paths. In-reply-to: <87d0113twf.fsf@gmx.de> Date: Thu, 29 Oct 2020 20:03:51 -0700 Message-ID: <87o8kke7oo.fsf@ccss.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44298 Cc: Hugh Daschbach , 44298@debbugs.gnu.org, 44298+DONE@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Michael Albinus writes: >> If a D-Bus interface is registered on more than one path, processing an >> incoming GetManagedObjects method call only reports a single path. > > Thanks for the report! I've pushed a fix to master, which should solve it. Michael, many thanks. That fixes the issue. I've extended the test to cover multiple interfaces and multiple paths. I've attached a patch if you're interested. I've tried to follow your advice on closing the bug. If I missed the mark, please feel free to close it yourself. Thanks again, Hugh --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=0001-Extend-GetManagedObjects-test.patch Content-Description: Extend GetManagedObjects test. >From 1b2e74b26ebd925539a07b909cfd600a66c4ab82 Mon Sep 17 00:00:00 2001 From: Hugh Daschbach Date: Thu, 29 Oct 2020 19:46:26 -0700 Subject: [PATCH] Extend GetManagedObjects test. * test/lisp/net/dbus-tests.el (dbus-test09-get-managed-objects): Expand test. --- test/lisp/net/dbus-tests.el | 128 +++++++++++++++++++++--------------- 1 file changed, 76 insertions(+), 52 deletions(-) diff --git a/test/lisp/net/dbus-tests.el b/test/lisp/net/dbus-tests.el index d630f80706e..6363ca2aebe 100644 --- a/test/lisp/net/dbus-tests.el +++ b/test/lisp/net/dbus-tests.el @@ -1890,78 +1890,102 @@ dbus-test08-register-monitor (ert-deftest dbus-test09-get-managed-objects () "Check `dbus-get-all-managed-objects'." - :tags '(:expensive-test) (skip-unless dbus--test-enabled-session-bus) (dbus-ignore-errors (dbus-unregister-service :session dbus--test-service)) (dbus-register-service :session dbus--test-service) (unwind-protect - (let ((path1 (concat dbus--test-path "/path1")) - (path2 (concat dbus--test-path "/path2")) - (path3 (concat dbus--test-path "/path3"))) + (let ((interfaces + `((,(concat dbus--test-interface ".I0") + ((,(concat dbus--test-path "/obj1") + (("I0Property1" . "Zero one one") + ("I0Property2" . "Zero one two") + ("I0Property3" . "Zero one three"))) + (,(concat dbus--test-path "/obj0/obj2") + (("I0Property1" . "Zero two one") + ("I0Property2" . "Zero two two") + ("I0Property3" . "Zero two three"))) + (,(concat dbus--test-path "/obj0/obj3") + (("I0Property1" . "Zero three one") + ("I0Property2" . "Zero three two") + ("I0Property3" . "Zero three three"))))) + (,(concat dbus--test-interface ".I1") + ((,(concat dbus--test-path "/obj0/obj2") + (("I1Property1" . "One one one") + ("I1Property2" . "One one two"))) + (,(concat dbus--test-path "/obj0/obj3") + (("I1Property1" . "One two one") + ("I1Property2" . "One two two")))))))) (should-not (dbus-get-all-managed-objects :session dbus--test-service dbus--test-path)) - (should - (equal - (dbus-register-property - :session dbus--test-service path1 dbus--test-interface - "Property1" :readwrite "Simple string one.") - `((:property :session ,dbus--test-interface "Property1") - (,dbus--test-service ,path1)))) - - (should - (equal - (dbus-register-property - :session dbus--test-service path2 dbus--test-interface - "Property1" :readwrite "Simple string two.") - `((:property :session ,dbus--test-interface "Property1") - (,dbus--test-service ,path2)))) - - (should - (equal - (dbus-register-property - :session dbus--test-service path3 dbus--test-interface - "Property1" :readwrite "Simple string three.") - `((:property :session ,dbus--test-interface "Property1") - (,dbus--test-service ,path3)))) - - (should - (equal - (dbus-get-property - :session dbus--test-service path1 dbus--test-interface - "Property1") - "Simple string one.")) - - (should - (equal - (dbus-get-property - :session dbus--test-service path2 dbus--test-interface - "Property1") - "Simple string two.")) - - (should - (equal - (dbus-get-property - :session dbus--test-service path3 dbus--test-interface - "Property1") - "Simple string three.")) + (dolist (interface interfaces) + (pcase-let ((`(,iname ,objs) interface)) + (dolist (obj objs) + (pcase-let ((`(,path ,props) obj)) + (dolist (prop props) + (should + (equal + (dbus-register-property + :session dbus--test-service path iname + (car prop) :readwrite (cdr prop)) + `((:property :session ,iname ,(car prop)) + (,dbus--test-service ,path))))))))) (let ((result (dbus-get-all-managed-objects :session dbus--test-service dbus--test-path))) (should (= 3 (length result))) - (should - (assoc-string path1 result)) + (dolist (interface interfaces) + (pcase-let ((`(,iname ,objs) interface)) + (dolist (obj objs) + (pcase-let ((`(,path ,props) obj)) + (let* ((object (cadr (assoc-string path result))) + (iface (cadr (assoc-string iname object)))) + (should object) + (should iface) + (dolist (prop props) + (should (equal (cdr (assoc-string (car prop) iface)) + (cdr prop)))))))))) + (let ((result (dbus-get-all-managed-objects + :session dbus--test-service (concat dbus--test-path "/obj0")))) (should - (assoc-string path2 result)) + (= 2 (length result))) + + (dolist (interface interfaces) + (pcase-let ((`(,iname ,objs) interface)) + (dolist (obj objs) + (pcase-let ((`(,path ,props) obj)) + (when (string-prefix-p (concat dbus--test-path "/obj0/") path) + (let* ((object (cadr (assoc-string path result))) + (iface (cadr (assoc-string iname object)))) + (should object) + (should iface) + (dolist (prop props) + (should (equal (cdr (assoc-string (car prop) iface)) + (cdr prop))))))))))) + (let ((result (dbus-get-all-managed-objects + :session dbus--test-service (concat dbus--test-path "/obj0/obj2")))) (should - (assoc-string path3 result)))) + (= 1 (length result))) + + (dolist (interface interfaces) + (pcase-let ((`(,iname ,objs) interface)) + (dolist (obj objs) + (pcase-let ((`(,path ,props) obj)) + (when (string-prefix-p (concat dbus--test-path "/obj0/obj2") path) + (let* ((object (cadr (assoc-string path result))) + (iface (cadr (assoc-string iname object)))) + (should object) + (should iface) + (dolist (prop props) + (should (equal (cdr (assoc-string (car prop) iface)) + (cdr prop)))))))))))) ;; Cleanup. (dbus-unregister-service :session dbus--test-service))) -- 2.28.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 29 23:21:36 2020 Received: (at 44298-done) by debbugs.gnu.org; 30 Oct 2020 03:21:36 +0000 Received: from localhost ([127.0.0.1]:55716 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYKyu-0000Sf-40 for submit@debbugs.gnu.org; Thu, 29 Oct 2020 23:21:36 -0400 Received: from mail1.ccss.com ([159.203.255.73]:60260) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYKys-0000SP-DL for 44298-done@debbugs.gnu.org; Thu, 29 Oct 2020 23:21:34 -0400 Received: by mail1.ccss.com (Postfix, from userid 114) id CFF73BF818; Thu, 29 Oct 2020 20:21:28 -0700 (PDT) X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on mail1.ccss.com X-Spam-Level: X-Spam-Status: No, score=-0.9 required=5.0 tests=ALL_TRUSTED,DKIM_SIGNED, TVD_SPACE_RATIO,TVD_SPACE_RATIO_MINFP,T_DKIM_INVALID autolearn=no autolearn_force=no version=3.4.2 Received: from ccss.com (unknown [192.168.76.11]) by mail1.ccss.com (Postfix) with ESMTP id 5C290BF5AB for <44298-done@debbugs.gnu.org>; Thu, 29 Oct 2020 20:21:28 -0700 (PDT) Received: from localhost (localhost [127.0.0.1]) by ccss.com (Postfix) with ESMTP id 2FF1C17606CF for <44298-done@debbugs.gnu.org>; Thu, 29 Oct 2020 20:21:28 -0700 (PDT) Received: from ccss.com ([127.0.0.1]) by localhost (ccss.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id H0LMKxQNWygM for <44298-done@debbugs.gnu.org>; Thu, 29 Oct 2020 20:21:22 -0700 (PDT) Received: from klaatu (klaatu.lan [192.168.42.3]) (Authenticated sender: hugh) by ccss.com (Postfix) with ESMTPSA id A6EAA176057D for <44298-done@debbugs.gnu.org>; Thu, 29 Oct 2020 20:21:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ccss.com; s=mail; t=1604028082; bh=frcCV1k9oG9oKj3dpUqdJg1PxRT2RSN/XKdLCPjaYaY=; h=From:To:Subject:Date:From; b=GBOhr+c6Rew4OxYHLP/v7ZxhWRo+pdUfAaTtolfLyv7b7Q9De9tLAtG1H90SPsyin lw9DUGT1WyLtbaFZuOhLbQOWn9i/9DNq72SPxMHlHgQNta5V+R8NsBHUte5T4hGLT8 zvcY3n04oDMBV52gJEqpmJ90cDs5JAZCH13v4C0PIkhtumYE1cXF458zBf/94YJa7Z tr2PopKiAEZoGHBeU/iL+3/Caexnoh/hFj792H4BEe1QTiHcAUJzYgDG2GGtLNyUvn /T/kOFSHerfPE9wCvJgq0WOpT6rS/cWuqylaCzte/UXwMNNFvx/7iqmrlc+HtdmRdO vNkXgKIXLhIsA== User-agent: mu4e 1.5.5; emacs 27.1 From: Hugh Daschbach To: 44298-done@debbugs.gnu.org Subject: Resolved Date: Thu, 29 Oct 2020 20:21:22 -0700 Message-ID: <87lffoe6vh.fsf@ccss.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44298-done X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 30 04:07:50 2020 Received: (at 44298-done) by debbugs.gnu.org; 30 Oct 2020 08:07:50 +0000 Received: from localhost ([127.0.0.1]:55969 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYPRt-0001ZI-Sm for submit@debbugs.gnu.org; Fri, 30 Oct 2020 04:07:50 -0400 Received: from mout.gmx.net ([212.227.17.22]:33027) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYPRs-0001Z4-0j for 44298-done@debbugs.gnu.org; Fri, 30 Oct 2020 04:07:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1604045259; bh=IDqZZjAgqZ8S5FoN4nI6PJEt/zFnOA44U5gvsM3xejg=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=LD2MVxUmOtQoquKw8FvJuaz5zVtnVaxzWCFxfkc41EvuqUgAVkF7vfwHDJ2e0I5Ps A2x8IKjPOlFRcM7gI38Cj/uJK54GU//QkiRsMj6uRD9Lg3Qhsn1b2+0BppZyqXrVva GqIRvVDL/lZDDZzyNqvqvTsT3rd5k9kF2dlNaq0w= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([212.86.46.203]) by mail.gmx.com (mrgmx105 [212.227.17.168]) with ESMTPSA (Nemesis) id 1MsYqp-1kDZTM2Qd1-00u42q; Fri, 30 Oct 2020 09:07:39 +0100 From: Michael Albinus To: Hugh Daschbach Subject: Re: bug#44298: 28.0.50; D-Bus GetManagedObjects doesn't enumerate all paths. References: <87wnz9eo66.fsf@ccss.com> <87d0113twf.fsf@gmx.de> <87o8kke7oo.fsf@ccss.com> Date: Fri, 30 Oct 2020 09:07:37 +0100 In-Reply-To: <87o8kke7oo.fsf@ccss.com> (Hugh Daschbach's message of "Thu, 29 Oct 2020 20:03:51 -0700") Message-ID: <87zh44t9va.fsf@gmx.de> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:Skv2+jC1Mw+ram17kU9j4SfMWICWlALOqrn56zADB4NPIeWGu1n pRL3YLi38C9FVL8xRoOn3jebVd/ocWOj9y1iQUuXV6VU/16Kmr9vyws0nUtq+E7epvXY+Sg 1YYw8p9f5b4NBMhcWikAc+Pi6xakEpUX26DrJrNsHC9VO8LVbDniWhaSXFuFsbSDNBtxr4M sc71AGwYUkoLdTrHTokSw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:0BIPxyceTUo=:E8QO1/sxwMp5HZIrm3s6wb VrkfuuMAUxCQIhqnJL/+hfewKcLTt8OUsjIoRMMvhFFQ4azEfaxTEIGXxYDvW6UCP92UfxJhk aqBlJ1hX1WlH7D1Ag/A9DvjPeTTXg+/1tTyIIdse14UD6nMgQHZL05TZYvRerfHq3vaq+K+L0 E2ALwnDancDOI8wJZjfnVDGSQeIKA/HWTX+tMSurvLypxKI9nYKIfKYgIhpCm2e0aiFrnAq32 Ozdl8VHFUALkJ4SNKP8buGqPtkOY1xLiZLKHsTNvd7jGHf7aB6tbb1XwAFsT5vJZYuHfA3vsj LzaOS5JEqMQcJGICXsRoBcMogp4ELVCuiNfnHEtNAoYpmKQtcsnKbATxUjZsM8EAMOMsaSdrs 8dx+sx52dwC98WU/6FPHh7Coe472MgzT2Ht0H8U5HCxcBNRhTM3im72MdVt3vFZY/981IBLux MPvaARkaAnTj1ye7Bno00hfM3ly0d5KSz9xgAhpW3nPQCpGKTOFYrLTVRCQSnYvMckoXtmxyk mExnc10+OmraswJPqnKtgXi2D7D04Wb7HfXxem+2oludCB7Gms/ed9u3K/hBHPsDhhw9PW0Ns 1k2AQVvrxOmYqWofHUGnL8kL6YrTP0uj64m66jGhZRo9Xnbz4u0wlWT5MPZIz4HHmvy5H1BGM aU+gwgUuTSIWPBJkHSPNqpzze/lVYO3o5G6NZnl0qz7o9y90GPAXfausg12dai5AnNVNR+Hry PD6J7vhr4bYZBKOW22B7BTNxYH81YI6pUZRu4wYLscmLOG3KYFz6ha+wpUSfGiJqPRCZQ+Qfu 0NbIh13v693SuGD6vu07seM9IHOaBXi7FRYbxQ0DKkBwKNoUC5MFbefUsdNfLzdYjR9Bq5qal CwvONq4KIR0a4XjC18wQ== X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44298-done Cc: 44298-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Hugh Daschbach writes: Hi Hugh, > Michael, many thanks. That fixes the issue. I've extended the test to > cover multiple interfaces and multiple paths. I've attached a patch if > you're interested. Thanks, I've pushed it to master. Yesterday, I've also added the :expensive-test tag which is missing in your recent patch. So I've added it, again. > I've tried to follow your advice on closing the bug. If I missed the > mark, please feel free to close it yourself. You need just to edit the debbugs email address in Cc, from 44298@debbugs.gnu.org to 44298-done@debbugs.gnu.org, as I've done here. Read admin/notes/bugtracker for further information. You could also use the debbugs package from GNU ELPA. Disclaimer: I'm one of its authors. > Thanks again, > Hugh Best regards, Michael. From unknown Sun Jun 22 07:51:46 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Fri, 27 Nov 2020 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator