GNU bug report logs - #44298
28.0.50; D-Bus GetManagedObjects doesn't enumerate all paths.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44298 in the body.
You can then email your comments to 44298 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Hugh Daschbach <hugh <at> ccss.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; D-Bus GetManagedObjects doesn't enumerate all paths.
Date: Wed, 28 Oct 2020 19:55:29 -0700

[Message part 1 (text/plain, inline)]

If a D-Bus interface is registered on more than one path, processing an
incoming GetManagedObjects method call only reports a single path.

The attached patch adds a test case to demonstrate this issue.

[0001-Add-tests-for-D-Bus-GetManagedObjects-inquiry.patch (text/x-patch, attachment)]

[Message part 3 (text/plain, inline)]

Cheers,
Hugh


In GNU Emacs 28.0.50 (build 20, x86_64-pc-linux-gnu, X toolkit, cairo version 1.17.3, Xaw3d scroll bars)
 of 2020-10-11 built on klaatu
Repository revision: 0f79544368c0dc343edcd97c3c7992aeab415b68
Repository branch: submission
Windowing system distributor 'The X.Org Foundation', version 11.0.12009000
System Description: Artix Linux

Configured using:
 'configure --with-x-toolkit=lucid'

Configured features:
XAW3D XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND GPM DBUS GSETTINGS GLIB
NOTIFY INOTIFY ACL GNUTLS LIBXML2 FREETYPE HARFBUZZ M17N_FLT LIBOTF ZLIB
TOOLKIT_SCROLL_BARS LUCID X11 XDBE XIM MODULES THREADS LIBSYSTEMD JSON
PDUMPER LCMS2

Important settings:
  value of $LANG: en_US.UTF-8
  locale-coding-system: utf-8-unix

Major mode: ERT-Results

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  buffer-read-only: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc puny dired dired-loaddefs
rfc822 mml mml-sec epa derived epg epg-config gnus-util rmail
rmail-loaddefs auth-source eieio eieio-core eieio-loaddefs
password-cache json map text-property-search time-date mm-decode
mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader
sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils
thingatpt edmacro kmacro cl-extra vc-git diff-mode easy-mmode
bug-reference dbus-tests dbus cl-seq cl-macs pcase xml subr-x seq
byte-opt gv bytecomp byte-compile cconv ert-x ert pp ewoc debug
backtrace help-mode easymenu find-func cl-loaddefs cl-lib tooltip eldoc
electric uniquify ediff-hook vc-hooks lisp-float-type mwheel term/x-win
x-win term/common-win x-dnd tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode elisp-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch timer
select scroll-bar mouse jit-lock font-lock syntax facemenu font-core
term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese composite charscript charprop case-table epa-hook
jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button
loaddefs faces cus-face macroexp files window text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote threads dbusbind inotify lcms2
dynamic-setting system-font-setting font-render-setting cairo x-toolkit
x multi-tty make-network-process emacs)

Memory information:
((conses 16 122955 5639)
 (symbols 48 10363 1)
 (strings 32 26544 1387)
 (string-bytes 1 832865)
 (vectors 16 15402)
 (vector-slots 8 202326 11404)
 (floats 8 68 231)
 (intervals 56 612 0)
 (buffers 992 14))

Message #8 received at 44298 <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Hugh Daschbach <hugh <at> ccss.com>
Cc: 44298 <at> debbugs.gnu.org
Subject: Re: bug#44298: 28.0.50; D-Bus GetManagedObjects doesn't enumerate
 all paths.
Date: Thu, 29 Oct 2020 16:59:28 +0100

Hugh Daschbach <hugh <at> ccss.com> writes:

Hi Hugh,

> If a D-Bus interface is registered on more than one path, processing an
> incoming GetManagedObjects method call only reports a single path.

Thanks for the report! I've pushed a fix to master, which should solve it.

> The attached patch adds a test case to demonstrate this issue.

Thanks also for this. I've pushed it to master as well.

> Cheers,
> Hugh

Best regards, Michael.

Message #11 received at 44298 <at> debbugs.gnu.org (full text, mbox):

From: Hugh Daschbach <hugh <at> ccss.com>
To: Michael Albinus <michael.albinus <at> gmx.de>
Cc: Hugh Daschbach <hugh <at> ccss.com>, 44298 <at> debbugs.gnu.org,
 44298+DONE <at> debbugs.gnu.org
Subject: Re: bug#44298: 28.0.50; D-Bus GetManagedObjects doesn't enumerate
 all paths.
Date: Thu, 29 Oct 2020 20:03:51 -0700

[Message part 1 (text/plain, inline)]

Michael Albinus writes:

>> If a D-Bus interface is registered on more than one path, processing an
>> incoming GetManagedObjects method call only reports a single path.
>
> Thanks for the report! I've pushed a fix to master, which should solve it.

Michael, many thanks.  That fixes the issue.  I've extended the test to
cover multiple interfaces and multiple paths.  I've attached a patch if
you're interested.

I've tried to follow your advice on closing the bug.  If I missed the
mark, please feel free to close it yourself.

Thanks again,
Hugh

[0001-Extend-GetManagedObjects-test.patch (text/x-patch, attachment)]

Message #16 received at 44298-done <at> debbugs.gnu.org (full text, mbox):

From: Hugh Daschbach <hugh <at> ccss.com>
To: 44298-done <at> debbugs.gnu.org
Subject: Resolved
Date: Thu, 29 Oct 2020 20:21:22 -0700

Message #19 received at 44298-done <at> debbugs.gnu.org (full text, mbox):

From: Michael Albinus <michael.albinus <at> gmx.de>
To: Hugh Daschbach <hugh <at> ccss.com>
Cc: 44298-done <at> debbugs.gnu.org
Subject: Re: bug#44298: 28.0.50; D-Bus GetManagedObjects doesn't enumerate
 all paths.
Date: Fri, 30 Oct 2020 09:07:37 +0100

Hugh Daschbach <hugh <at> ccss.com> writes:

Hi Hugh,

> Michael, many thanks.  That fixes the issue.  I've extended the test to
> cover multiple interfaces and multiple paths.  I've attached a patch if
> you're interested.

Thanks, I've pushed it to master. Yesterday, I've also added the
:expensive-test tag which is missing in your recent patch. So I've added
it, again.

> I've tried to follow your advice on closing the bug.  If I missed the
> mark, please feel free to close it yourself.

You need just to edit the debbugs email address in Cc, from
44298 <at> debbugs.gnu.org to 44298-done <at> debbugs.gnu.org, as I've done
here. Read admin/notes/bugtracker for further information.

You could also use the debbugs package from GNU ELPA. Disclaimer: I'm
one of its authors.

> Thanks again,
> Hugh

Best regards, Michael.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.