From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 28 04:57:18 2020 Received: (at submit) by debbugs.gnu.org; 28 Oct 2020 08:57:18 +0000 Received: from localhost ([127.0.0.1]:47091 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXhGg-0004fP-AL for submit@debbugs.gnu.org; Wed, 28 Oct 2020 04:57:18 -0400 Received: from lists.gnu.org ([209.51.188.17]:43600) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXhGe-0004fG-Gk for submit@debbugs.gnu.org; Wed, 28 Oct 2020 04:57:16 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:44958) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXhGd-0005oU-Pw for guix-patches@gnu.org; Wed, 28 Oct 2020 04:57:15 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:39283) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXhGW-0007Xo-S2 for guix-patches@gnu.org; Wed, 28 Oct 2020 04:57:10 -0400 Received: from rafflesia.easter-eggs.fr (176-159-32-89.abo.bbox.fr [176.159.32.89]) (Authenticated sender: tanguy@bioneland.org) by relay11.mail.gandi.net (Postfix) with ESMTPA id 7179910000B; Wed, 28 Oct 2020 08:57:03 +0000 (UTC) From: Tanguy Le Carrour To: guix-patches@gnu.org Subject: [PATCH] gnu: Add python-pydub. Date: Wed, 28 Oct 2020 09:56:54 +0100 Message-Id: <20201028085654.18295-1-tanguy@bioneland.org> X-Mailer: git-send-email 2.29.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: none client-ip=217.70.178.231; envelope-from=tanguy@bioneland.org; helo=relay11.mail.gandi.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/28 04:57:04 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: Tanguy Le Carrour X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/python-xyz.scm (python-pydub): New variable. --- gnu/packages/python-xyz.scm | 22 ++++++++++++++++++++++ 1 file changed, 22 insertions(+) diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm index 6c5ccac647..55580a251b 100644 --- a/gnu/packages/python-xyz.scm +++ b/gnu/packages/python-xyz.scm @@ -16659,6 +16659,28 @@ ignoring formatting changes.") (define-public python2-pydiff (package-with-python2 python-pydiff)) +(define-public python-pydub + (package + (name "python-pydub") + (version "0.24.1") + (source + (origin + (method url-fetch) + (uri (pypi-uri "pydub" version)) + (sha256 + (base32 + "0sfwfq7yjv4bl3yqbmizszscafvwf4zr40hzbsy7rclvzyznh333")))) + (build-system python-build-system) + (home-page "http://pydub.com") + (propagated-inputs + `(("ffmpeg" ,ffmpeg) + ("python-scipy" ,python-scipy))) + (synopsis "Manipulate audio with an simple and easy high level interface") + (description + "@code{pydub} makes it easy to manipulate audio. It relies on +@code{ffmpeg} to open various audio formats.") + (license license:expat))) ; MIT license + (define-public python-tqdm (package (name "python-tqdm") -- 2.29.1 From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 28 12:35:01 2020 Received: (at 44275) by debbugs.gnu.org; 28 Oct 2020 16:35:01 +0000 Received: from localhost ([127.0.0.1]:50340 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXoPc-0004XU-Ny for submit@debbugs.gnu.org; Wed, 28 Oct 2020 12:35:00 -0400 Received: from wout1-smtp.messagingengine.com ([64.147.123.24]:42921) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXoPb-0004XI-DT for 44275@debbugs.gnu.org; Wed, 28 Oct 2020 12:34:59 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 85124A04; Wed, 28 Oct 2020 12:34:53 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Wed, 28 Oct 2020 12:34:53 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=TKomo3rQUf9gWQ6Tn5N50ktY AyPR6nIAabI+q9Y0oCM=; b=bKkb95NssVs7xFCs/hLJxHToyTBfUXtIAKw+x6Y2 lizJT6nR09L0ERSW1awUweVoG4K4t9K0lhFweYYce8SNe/JdAxgIpByAb3HEt6wL p7D1nX+oGKN0z487Ox59n9erRdQJsO+Y9D1/ZJyZqA4QDm5T60T/qxoT61rH0tun y4E= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=TKomo3 rQUf9gWQ6Tn5N50ktYAyPR6nIAabI+q9Y0oCM=; b=YqXeFavUXGxdthbcVuvUfX Udla5tPOkyymA8iR3KvuCykNL1QG7x5BhjkcAGnFqmiSjDFQPuqMFQwIywgTLz12 bWbN3EyZv8Gn66pvxvFRsHWhE25hq5teNaeyJhN+Ud2SvIZP/nu84cOnxqoj+oG3 DoAsb76PKZ1eYO5+/r4ErTAJSUwlDHt/m0EjKVVDMjARmAh3bGUoWIwIHCUe8n5u i1TdyX+RSjme+0pTvTA93H/nHOCnJ5gF07iThlrn7rAXFr/dFXr2dPZUq9PAw2kN wVsmmr94gGw/DHbLufqBvpw/ybiCjjSvwr2oJPDMBSLxAWyPntQLuZmlPcYAFXiQ == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrledugdekkecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepnfgvohcuhfgr mhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuggftrfgrthhtvg hrnhepueekkedtffdvtddugeejgedtvefhueefiedvjeeitdeigedtveejvdejheffvefg necukfhppeejfedrudeguddruddvjedrudegieenucevlhhushhtvghrufhiiigvpedune curfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: from localhost (c-73-141-127-146.hsd1.pa.comcast.net [73.141.127.146]) by mail.messagingengine.com (Postfix) with ESMTPA id 6ACA8328005D; Wed, 28 Oct 2020 12:34:52 -0400 (EDT) Date: Wed, 28 Oct 2020 12:34:50 -0400 From: Leo Famulari To: Tanguy Le Carrour Subject: Re: [bug#44275] [PATCH] gnu: Add python-pydub. Message-ID: <20201028163450.GE12095@jasmine.lan> References: <20201028085654.18295-1-tanguy@bioneland.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20201028085654.18295-1-tanguy@bioneland.org> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44275 Cc: 44275@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Wed, Oct 28, 2020 at 09:56:54AM +0100, Tanguy Le Carrour wrote: > * gnu/packages/python-xyz.scm (python-pydub): New variable. > + (propagated-inputs > + `(("ffmpeg" ,ffmpeg) > + ("python-scipy" ,python-scipy))) It would be good if store references to these programs could be "baked in" to the pydub code, rather than propagated. Can you take a look at how they are called and see if that is feasible? Often there is only one location that must be patched. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 29 04:27:08 2020 Received: (at 44275) by debbugs.gnu.org; 29 Oct 2020 08:27:08 +0000 Received: from localhost ([127.0.0.1]:51681 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kY3H1-0004lb-TJ for submit@debbugs.gnu.org; Thu, 29 Oct 2020 04:27:08 -0400 Received: from relay1-d.mail.gandi.net ([217.70.183.193]:14565) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kY3Gz-0004l5-L9 for 44275@debbugs.gnu.org; Thu, 29 Oct 2020 04:27:06 -0400 X-Originating-IP: 176.159.32.89 Received: from localhost (176-159-32-89.abo.bbox.fr [176.159.32.89]) (Authenticated sender: tanguy@bioneland.org) by relay1-d.mail.gandi.net (Postfix) with ESMTPSA id 73D86240010; Thu, 29 Oct 2020 08:26:57 +0000 (UTC) Date: Thu, 29 Oct 2020 09:26:57 +0100 From: Tanguy Le Carrour To: Leo Famulari Subject: Re: [bug#44275] [PATCH] gnu: Add python-pydub. Message-ID: <20201029082657.xb3we5aqncp7qqci@rafflesia> References: <20201028085654.18295-1-tanguy@bioneland.org> <20201028163450.GE12095@jasmine.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201028163450.GE12095@jasmine.lan> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44275 Cc: 44275@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Leo, Thanks for taking the time to review this! Le 10/28, Leo Famulari a écrit : > On Wed, Oct 28, 2020 at 09:56:54AM +0100, Tanguy Le Carrour wrote: > > * gnu/packages/python-xyz.scm (python-pydub): New variable. > > > + (propagated-inputs > > + `(("ffmpeg" ,ffmpeg) > > + ("python-scipy" ,python-scipy))) > > It would be good if store references to these programs could be "baked in" to > the pydub code, rather than propagated. Can you take a look at how they > are called and see if that is feasible? Often there is only one location > that must be patched. mmm… haven't done that so far, it would be my first time! Always good to learn new tricks! :-) I'll try to patch the call to `ffmpeg` and let you know. `python-scipy` is a different problem, though. This module is not listed as a requirement, but… it's required at run time. Event if I don't see the point of having SciPy loaded when you want to manipulate audio. But that's a different matter! Regards, -- Tanguy From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 29 05:09:52 2020 Received: (at 44275) by debbugs.gnu.org; 29 Oct 2020 09:09:52 +0000 Received: from localhost ([127.0.0.1]:51781 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kY3wN-0005oh-QN for submit@debbugs.gnu.org; Thu, 29 Oct 2020 05:09:51 -0400 Received: from relay5-d.mail.gandi.net ([217.70.183.197]:41607) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kY3wM-0005oA-27 for 44275@debbugs.gnu.org; Thu, 29 Oct 2020 05:09:50 -0400 X-Originating-IP: 176.159.32.89 Received: from rafflesia.easter-eggs.fr (176-159-32-89.abo.bbox.fr [176.159.32.89]) (Authenticated sender: tanguy@bioneland.org) by relay5-d.mail.gandi.net (Postfix) with ESMTPA id 2E46F1C0008; Thu, 29 Oct 2020 09:09:42 +0000 (UTC) From: Tanguy Le Carrour To: 44275@debbugs.gnu.org Subject: [PATCH v2] gnu: Add python-pydub. Date: Thu, 29 Oct 2020 10:09:29 +0100 Message-Id: <20201029090929.10508-1-tanguy@bioneland.org> X-Mailer: git-send-email 2.29.1 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44275 Cc: Tanguy Le Carrour , leo@famulari.name X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) * gnu/packages/python-xyz.scm (python-pydub): New variable. --- gnu/packages/python-xyz.scm | 38 +++++++++++++++++++++++++++++++++++++ 1 file changed, 38 insertions(+) diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm index 9f689d35b5..e938081d28 100644 --- a/gnu/packages/python-xyz.scm +++ b/gnu/packages/python-xyz.scm @@ -16683,6 +16683,44 @@ ignoring formatting changes.") (define-public python2-pydiff (package-with-python2 python-pydiff)) +(define-public python-pydub + (package + (name "python-pydub") + (version "0.24.1") + (source + (origin + (method url-fetch) + (uri (pypi-uri "pydub" version)) + (sha256 + (base32 + "0sfwfq7yjv4bl3yqbmizszscafvwf4zr40hzbsy7rclvzyznh333")))) + (build-system python-build-system) + (arguments + `(#:phases + (modify-phases %standard-phases + (add-after 'unpack 'fix-ffmpeg-path + (lambda* (#:key inputs #:allow-other-keys) + (let ((ffmpeg (assoc-ref inputs "ffmpeg"))) + (substitute* '("pydub/utils.py") + (("return \"ffmpeg\"") + (string-append "return \"" ffmpeg "/bin/ffmpeg\"")) + (("return \"ffplay\"") + (string-append "return \"" ffmpeg "/bin/ffplay\"")) + (("return \"ffprobe\"") + (string-append "return \"" ffmpeg "/bin/ffprobe\"")) + (("warn\\(\"Couldn't find ff") "# warn\\(\"Couldn't find ff")) + #t)))))) + (home-page "http://pydub.com") + (inputs + `(("ffmpeg" ,ffmpeg))) + (propagated-inputs + `(("python-scipy" ,python-scipy))) + (synopsis "Manipulate audio with an simple and easy high level interface") + (description + "@code{pydub} makes it easy to manipulate audio. It relies on +@code{ffmpeg} to open various audio formats.") + (license license:expat))) ; MIT license + (define-public python-tqdm (package (name "python-tqdm") -- 2.29.1 From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 29 10:14:36 2020 Received: (at 44275) by debbugs.gnu.org; 29 Oct 2020 14:14:36 +0000 Received: from localhost ([127.0.0.1]:54514 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kY8hH-0003by-VQ for submit@debbugs.gnu.org; Thu, 29 Oct 2020 10:14:36 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:58461) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kY8hG-0003bj-Hd for 44275@debbugs.gnu.org; Thu, 29 Oct 2020 10:14:34 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 692725C0117; Thu, 29 Oct 2020 10:14:29 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 29 Oct 2020 10:14:29 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=mesmtp; bh=q2tbY8nxuDMOmwZ1a5V7zgOwVkD9KYJ4+958COMqT24=; b=C+pfU1EKjQsD 63DVbNKtmSkaS+ohBa23GJLU8iz74UxnD/pgTXUgArRqN5v1DaB2CpQzBt0m8q93 YYQuBAWmi6SFbDe0dzNzcAegPlruS6ELa60MStgFEp5Gt5ZM63A50gOhR5d5RdbI Pc/6/8ClPz3ii3W1Z3uXv5NI633S7S8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=q2tbY8nxuDMOmwZ1a5V7zgOwVkD9KYJ4+958COMqT 24=; b=nTxSs6mICB4ZjFWM5CW/Wi3cM9idwArb0kHQqYbHmjeHBcUMkDxXiSGBS V/fEO+bBPO6ELQm0VSpvDFzYZ7NuQAPYkjOEkFm0QN8TtjbMhPP4oc0IsY9aRMND TNjvugHtYWbBijeHXMAkRILXwZYI0aSZpeVltTqSR71vdAR+e3aY4UGbeiu12AM5 Hq3EmhWKQr0X1+XxWr7Ko6v8qTvE3GfA3NeeKRJfJkYtGegUiexJbe5J6YPvLokf 2dzGYsbWFcftNeAypkQoEF0eRYRdbWN3FHVgtloMKbWXdr3IYM2K4CPggdTKgLg3 andIcuVbelIOM/EETDQZvbR60GEag== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrleefgdeiudcutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpeffhffvuffkfhggtggugfgjsehtkeertddttdejnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtth gvrhhnpeegjeeggeehtddugfffuddtvdfffeffjeekffffveffheegvddvuedtffekjeej jeenucfkphepjeefrddugedurdduvdejrddugeeinecuvehluhhsthgvrhfuihiivgepud enucfrrghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: from localhost (c-73-141-127-146.hsd1.pa.comcast.net [73.141.127.146]) by mail.messagingengine.com (Postfix) with ESMTPA id 367853064688; Thu, 29 Oct 2020 10:14:29 -0400 (EDT) Date: Thu, 29 Oct 2020 10:14:27 -0400 From: Leo Famulari To: Tanguy Le Carrour Subject: Re: [bug#44275] [PATCH] gnu: Add python-pydub. Message-ID: <20201029141427.GB8956@jasmine.lan> References: <20201028085654.18295-1-tanguy@bioneland.org> <20201028163450.GE12095@jasmine.lan> <20201029082657.xb3we5aqncp7qqci@rafflesia> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201029082657.xb3we5aqncp7qqci@rafflesia> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44275 Cc: 44275@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Thu, Oct 29, 2020 at 09:26:57AM +0100, Tanguy Le Carrour wrote: > Hi Leo, > > Thanks for taking the time to review this! > > Le 10/28, Leo Famulari a écrit : > > On Wed, Oct 28, 2020 at 09:56:54AM +0100, Tanguy Le Carrour wrote: > > > * gnu/packages/python-xyz.scm (python-pydub): New variable. > > > > > + (propagated-inputs > > > + `(("ffmpeg" ,ffmpeg) > > > + ("python-scipy" ,python-scipy))) > > > > It would be good if store references to these programs could be "baked in" to > > the pydub code, rather than propagated. Can you take a look at how they > > are called and see if that is feasible? Often there is only one location > > that must be patched. > > mmm… haven't done that so far, it would be my first time! Always good to > learn new tricks! :-) > I'll try to patch the call to `ffmpeg` and let you know. > > `python-scipy` is a different problem, though. This module is not listed > as a requirement, but… it's required at run time. Event if I don't see the > point of having SciPy loaded when you want to manipulate audio. But that's > a different matter! Okay, I will take a look at the scipy thing today. From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 29 10:39:18 2020 Received: (at 44275) by debbugs.gnu.org; 29 Oct 2020 14:39:18 +0000 Received: from localhost ([127.0.0.1]:54573 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kY95C-0004J9-FK for submit@debbugs.gnu.org; Thu, 29 Oct 2020 10:39:18 -0400 Received: from relay11.mail.gandi.net ([217.70.178.231]:43915) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kY95A-0004Ip-JH for 44275@debbugs.gnu.org; Thu, 29 Oct 2020 10:39:17 -0400 Received: from localhost (176-159-32-89.abo.bbox.fr [176.159.32.89]) (Authenticated sender: tanguy@bioneland.org) by relay11.mail.gandi.net (Postfix) with ESMTPSA id 7615310000C; Thu, 29 Oct 2020 14:39:09 +0000 (UTC) Date: Thu, 29 Oct 2020 15:39:08 +0100 From: Tanguy Le Carrour To: Leo Famulari Subject: Re: [bug#44275] [PATCH] gnu: Add python-pydub. Message-ID: <20201029143908.ay6nvhik5brjws7g@rafflesia> References: <20201028085654.18295-1-tanguy@bioneland.org> <20201028163450.GE12095@jasmine.lan> <20201029082657.xb3we5aqncp7qqci@rafflesia> <20201029141427.GB8956@jasmine.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201029141427.GB8956@jasmine.lan> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44275 Cc: 44275@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Le 10/29, Leo Famulari a écrit : > On Thu, Oct 29, 2020 at 09:26:57AM +0100, Tanguy Le Carrour wrote: > > […] > > > It would be good if store references to these programs could be "baked in" to > > > the pydub code, rather than propagated. Can you take a look at how they > > > are called and see if that is feasible? Often there is only one location > > > that must be patched. > > […] > > `python-scipy` is a different problem, though. This module is not listed > > as a requirement, but… it's required at run time. Event if I don't see the > > point of having SciPy loaded when you want to manipulate audio. But that's > > a different matter! > > Okay, I will take a look at the scipy thing today. Great, thanks! If it was up to me, I would remove altogether everything that is related to `scipy`, meaning the `pydub/scipy_effects.py` file. But it wouldn't be the same software any more, would it? ^_^' Regards, -- Tanguy From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 29 17:51:05 2020 Received: (at 44275) by debbugs.gnu.org; 29 Oct 2020 21:51:05 +0000 Received: from localhost ([127.0.0.1]:55213 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYFp3-0004h4-3h for submit@debbugs.gnu.org; Thu, 29 Oct 2020 17:51:05 -0400 Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:40353) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYFp0-0004gT-ED for 44275@debbugs.gnu.org; Thu, 29 Oct 2020 17:51:03 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.west.internal (Postfix) with ESMTP id 73D62300; Thu, 29 Oct 2020 17:50:56 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Thu, 29 Oct 2020 17:50:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=9tC/HF1V1eYZU51B/z7NtRBG 0+b2939hESHhvOMp+7Q=; b=S60T11s8JQXXTGm0jgaPYdrk9t2P3/TewqCh8C9v SSzW5lW58I5MmiV91TUYPFjE6am/0ONVSvZzAQmmyGhllOxrm8wYF9twf65WSjvw k9McC0esaP5VaL0HddGGz8xq9yVhmsn6XvqwoIpup+zJMQgkFGWPHYdt8CeGk3fF B1Y= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=9tC/HF 1V1eYZU51B/z7NtRBG0+b2939hESHhvOMp+7Q=; b=K/e9/0y02+s4OnzsTn0tjg wKNP592V0vGEKySnCP5CIbpRr7/DeqwROIA+ejBve4I5fUIRALYqzAaGRkKX8ypY hBcbmvY7HnFJE7o33yd54fgIFEQk0+ULvtNk4kSh3lsbz5mtBK0Tt+RznST5hgcP qQ/ziVyAkaQtdjbdBooqASescpzC8gWfhmPDnrOfIY/+nhuu20rNWZQgB6q0eX6q FjGCe9RXllPMAJmpnGq4Gxi1bPXoKUCwt5YTYxoKBjVNzO1HKqPa4sfjmWl0qdhx P4NCclOseQ7e1Y/NUWzjx5vaUAybGPxCJeT7cN7LLtczN6WWZ+e7nqKMXaN7JtVw == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrleefgdduhedvucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtth gvrhhnpeefgfefvedtieehkefgieeffefhfeeifeejheeitefhgeevfefhtddvhfeuveeh ieenucffohhmrghinhepphihughusgdrtghomhenucfkphepjeefrddugedurdduvdejrd dugeeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhep lhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: from localhost (c-73-141-127-146.hsd1.pa.comcast.net [73.141.127.146]) by mail.messagingengine.com (Postfix) with ESMTPA id 584C73064683; Thu, 29 Oct 2020 17:50:55 -0400 (EDT) Date: Thu, 29 Oct 2020 17:50:53 -0400 From: Leo Famulari To: Tanguy Le Carrour Subject: Re: [bug#44275] [PATCH] gnu: Add python-pydub. Message-ID: <20201029215053.GA11109@jasmine.lan> References: <20201028085654.18295-1-tanguy@bioneland.org> <20201028163450.GE12095@jasmine.lan> <20201029082657.xb3we5aqncp7qqci@rafflesia> <20201029141427.GB8956@jasmine.lan> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="AhhlLboLdkugWU4S" Content-Disposition: inline In-Reply-To: <20201029141427.GB8956@jasmine.lan> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44275 Cc: 44275@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --AhhlLboLdkugWU4S Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Oct 29, 2020 at 10:14:27AM -0400, Leo Famulari wrote: > Okay, I will take a look at the scipy thing today. I decided to let scipy be propagated since it's normal for Python things to be propagated. But I still think we should hard-code the reference to ffmpeg. I looked at the code, and it finds ffmpeg-related programs in 'pydub/utils.py', in the functions get_encoder_name(), get_player_name(), and get_prober_name(). I think it should be sufficient to substitute any mention of the words "ffmpeg", "ffplay", and "ffprobe" with the full store-path of those programs. I included a diff on your patch. You can see exactly what it does by adding (error "Stopping...") after the substitute*, building with --keep-failed, and then looking at the 'pydub/utils.py' file. diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm index 3c2d882003e..47ec542e6d1 100644 --- a/gnu/packages/python-xyz.scm +++ b/gnu/packages/python-xyz.scm @@ -16696,9 +16696,24 @@ ignoring formatting changes.") "0sfwfq7yjv4bl3yqbmizszscafvwf4zr40hzbsy7rclvzyznh333")))) (build-system python-build-system) (home-page "http://pydub.com") + (arguments + `(#:phases + (modify-phases %standard-phases + (add-after 'unpack 'patch-ffmpeg-references + (lambda* (#:key inputs #:allow-other-keys) + (let* ((ffmpeg-store-item (assoc-ref inputs "ffmpeg")) + (ffmpeg (string-append ffmpeg-store-item "/bin/ffmpeg")) + (ffplay (string-append ffmpeg-store-item "/bin/ffplay")) + (ffprobe (string-append ffmpeg-store-item "/bin/ffprobe"))) + (substitute* "pydub/utils.py" + (("ffmpeg") ffmpeg) + (("ffplay") ffplay) + (("ffprobe") ffprobe)) + #t)))))) + (inputs + `(("ffmpeg" ,ffmpeg))) (propagated-inputs - `(("ffmpeg" ,ffmpeg) - ("python-scipy" ,python-scipy))) + `(("python-scipy" ,python-scipy))) (synopsis "Manipulate audio with an simple and easy high level interface") (description "@code{pydub} makes it easy to manipulate audio. It relies on --AhhlLboLdkugWU4S Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAl+bOT0ACgkQJkb6MLrK fwhA7A//XPKxPB8OjVk/RIK3LSWe8nrnOkimu1nEt1YalsluhH9P7WHiqRPEP3rZ d4SjfWVGq/NlwFLPclIGZtY3ptKLM/L/ucqfDjK5MttyHOASJ3mdQxMkerH/tysz aKmbGl+uCfBuC8wHlW9s+fdTeUzjelI2Fxumd0nIXxVTe+CELenrjTUxZY2gI+IH D+BsxepRrIDfflJPn1rplM9BGpVGzLIT0FX9tsUW74UxmmCn6QhPTQbcbrEFDDF+ rIfU407h/AldsJlJPrjRGsqbT9K8UiZows8cU4BxisGFrHDxFOc7Jw/6tzg9XYPF j+q2ZnrSQ9V5uZENrPDxsn4paa7HXfhm6RQ721gHxRIhO9Zef5ubAadZQ0L1GAwN 4fMb1pNLwPIJR2VtSboYTi50hN0UFjIkEgGSpoP6e6ZJT1JchSKX8v5/vjjebdyh 6ehtVlFEe969js1PMjp2a1YdH4tqp9JqOv4zREVW/Kio+G8+lsZNfLxTDQo5kjw9 sbkgkZTfsvZEkuTLEhN1+KRznD9c744A+6OWJWaBAOVI0s9mmu5y+u0JuKhj0G9V c+KqmPLtcm1k1xtB8och39CB3VjUNxT5cpt2N+iNZpdbYX/RVHmScw7VvkKRMHoo UvfecOZxGIYLDmzOE18FkePX9vIxMSfv2t+FoZX7es/jik5LEmE= =SiXq -----END PGP SIGNATURE----- --AhhlLboLdkugWU4S-- From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 30 05:19:14 2020 Received: (at 44275) by debbugs.gnu.org; 30 Oct 2020 09:19:14 +0000 Received: from localhost ([127.0.0.1]:56062 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYQYz-0003NF-Rw for submit@debbugs.gnu.org; Fri, 30 Oct 2020 05:19:14 -0400 Received: from relay4-d.mail.gandi.net ([217.70.183.196]:47179) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYQYy-0003N1-Fs for 44275@debbugs.gnu.org; Fri, 30 Oct 2020 05:19:13 -0400 X-Originating-IP: 176.185.184.238 Received: from localhost (static-176-185-184-238.axione.abo.bbox.fr [176.185.184.238]) (Authenticated sender: tanguy@bioneland.org) by relay4-d.mail.gandi.net (Postfix) with ESMTPSA id 6D743E0015; Fri, 30 Oct 2020 09:19:02 +0000 (UTC) Date: Fri, 30 Oct 2020 10:19:01 +0100 From: Tanguy Le Carrour To: Leo Famulari Subject: Re: [bug#44275] [PATCH] gnu: Add python-pydub. Message-ID: <20201030091901.3wktfpjmup64kflh@melmoth> References: <20201028085654.18295-1-tanguy@bioneland.org> <20201028163450.GE12095@jasmine.lan> <20201029082657.xb3we5aqncp7qqci@rafflesia> <20201029141427.GB8956@jasmine.lan> <20201029215053.GA11109@jasmine.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201029215053.GA11109@jasmine.lan> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44275 Cc: 44275@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi Leo! Le 10/29, Leo Famulari a écrit : > On Thu, Oct 29, 2020 at 10:14:27AM -0400, Leo Famulari wrote: > > Okay, I will take a look at the scipy thing today. > > I decided to let scipy be propagated since it's normal for Python things > to be propagated. But I still think we should hard-code the reference to > ffmpeg. > > I looked at the code, and it finds ffmpeg-related programs in > 'pydub/utils.py', in the functions get_encoder_name(), > get_player_name(), and get_prober_name(). > > I think it should be sufficient to substitute any mention of the words > "ffmpeg", "ffplay", and "ffprobe" with the full store-path of those > programs. +1… > I included a diff on your patch. You can see exactly what it does by > adding (error "Stopping...") after the substitute*, building with > --keep-failed, and then looking at the 'pydub/utils.py' file. > > diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm > index 3c2d882003e..47ec542e6d1 100644 > --- a/gnu/packages/python-xyz.scm > +++ b/gnu/packages/python-xyz.scm > @@ -16696,9 +16696,24 @@ ignoring formatting changes.") > "0sfwfq7yjv4bl3yqbmizszscafvwf4zr40hzbsy7rclvzyznh333")))) > (build-system python-build-system) > (home-page "http://pydub.com") > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'patch-ffmpeg-references > + (lambda* (#:key inputs #:allow-other-keys) > + (let* ((ffmpeg-store-item (assoc-ref inputs "ffmpeg")) > + (ffmpeg (string-append ffmpeg-store-item "/bin/ffmpeg")) > + (ffplay (string-append ffmpeg-store-item "/bin/ffplay")) > + (ffprobe (string-append ffmpeg-store-item "/bin/ffprobe"))) > + (substitute* "pydub/utils.py" > + (("ffmpeg") ffmpeg) > + (("ffplay") ffplay) > + (("ffprobe") ffprobe)) > + #t)))))) > + (inputs > + `(("ffmpeg" ,ffmpeg))) > (propagated-inputs > - `(("ffmpeg" ,ffmpeg) > - ("python-scipy" ,python-scipy))) > + `(("python-scipy" ,python-scipy))) > (synopsis "Manipulate audio with an simple and easy high level interface") > (description > "@code{pydub} makes it easy to manipulate audio. It relies on So I guess you didn't see the one I submitted: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=44275#14 :-( I was really proud, because… it worked! :-) But yours is shorter and does the job (even if it "brute-force" replaces all the occurences of "ffmpeg", even in the comments!) and I'm totally fine with it! Thanks again for your help and your time! -- Tanguy From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 30 16:40:56 2020 Received: (at 44275-done) by debbugs.gnu.org; 30 Oct 2020 20:40:57 +0000 Received: from localhost ([127.0.0.1]:59880 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYbCi-0000mM-Lk for submit@debbugs.gnu.org; Fri, 30 Oct 2020 16:40:56 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:59649) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYbCg-0000mA-Qw for 44275-done@debbugs.gnu.org; Fri, 30 Oct 2020 16:40:55 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 7D1475C01CC; Fri, 30 Oct 2020 16:40:49 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Fri, 30 Oct 2020 16:40:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:in-reply-to; s=mesmtp; bh=er/58fUG3BIbadgYv7deuvuw i5Xv49Jf6y8ThmQHs5E=; b=XYZgAvNrqFmhGveUtXxzd9vB/TzlwmDej1Eableg nENqJUQvUvp5FTXtM+PUDe17C3a4PpEGSaQYTsnaDki3UcRWbyeu9+g8SVq4fmF1 0K5qWUQ5h0M5rw8GMzIphDmUnn/F/wxLsinS6XyAToHkE8K56YcHUA0CGZamn1g4 4pE= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; bh=er/58f UG3BIbadgYv7deuvuwi5Xv49Jf6y8ThmQHs5E=; b=RruU8EWpaCXr+wcH4lE8/r Yv0rZOynUuKagaltrhcQ517h5foykyQZWfxAe25pod9pCHXChOhxZGCTYZr7TaMC CBcoiPUScJIFvlSgMX8yddpkNg5T84A1TZ3nWmgDj0kLHDNKLak2tOzKVr9N9XTe BRxI4iN5J3Q000fPNgfF21wf7TzM4QEtdRxmSAThaTw/4wNamjiUH+ojgqcGyv0q /RWJqWmVw5x58NGs13r4JZtgQyxrN78zUtuBYuTbK6z95ijV/gPq87Rmvqi+Ckyk c4iNvWz8LGlp697OVGQEdj/uO5XwS6WYGSMXqG++T4a545HQKn9UyBdTsUKtE0og == X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrleehgddufeegucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefnvghoucfh rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtth gvrhhnpeefgfefvedtieehkefgieeffefhfeeifeejheeitefhgeevfefhtddvhfeuveeh ieenucffohhmrghinhepphihughusgdrtghomhenucfkphepjeefrddugedurdduvdejrd dugeeinecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomhep lhgvohesfhgrmhhulhgrrhhirdhnrghmvg X-ME-Proxy: Received: from localhost (c-73-141-127-146.hsd1.pa.comcast.net [73.141.127.146]) by mail.messagingengine.com (Postfix) with ESMTPA id 2D1D5328005A; Fri, 30 Oct 2020 16:40:49 -0400 (EDT) Date: Fri, 30 Oct 2020 16:40:47 -0400 From: Leo Famulari To: Tanguy Le Carrour Subject: Re: [PATCH v2] gnu: Add python-pydub. Message-ID: <20201030204047.GA10794@jasmine.lan> References: <20201029090929.10508-1-tanguy@bioneland.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="bp/iNruPH9dso1Pn" Content-Disposition: inline In-Reply-To: <20201029090929.10508-1-tanguy@bioneland.org> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44275-done Cc: 44275-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --bp/iNruPH9dso1Pn Content-Type: text/plain; charset=us-ascii Content-Disposition: inline On Thu, Oct 29, 2020 at 10:09:29AM +0100, Tanguy Le Carrour wrote: > * gnu/packages/python-xyz.scm (python-pydub): New variable. Thanks! Pushed as 96767739a1d2222ed802dd5dcfa2bda1df85df77 > + (add-after 'unpack 'fix-ffmpeg-path > + (lambda* (#:key inputs #:allow-other-keys) > + (let ((ffmpeg (assoc-ref inputs "ffmpeg"))) > + (substitute* '("pydub/utils.py") > + (("return \"ffmpeg\"") > + (string-append "return \"" ffmpeg "/bin/ffmpeg\"")) > + (("return \"ffplay\"") > + (string-append "return \"" ffmpeg "/bin/ffplay\"")) > + (("return \"ffprobe\"") > + (string-append "return \"" ffmpeg "/bin/ffprobe\"")) > + (("warn\\(\"Couldn't find ff") "# warn\\(\"Couldn't find ff")) > + #t)))))) This solution is more correct than the one I suggested. Thanks! > + (home-page "http://pydub.com") I made this use HTTPS. > + (synopsis "Manipulate audio with an simple and easy high level interface") > + (description > + "@code{pydub} makes it easy to manipulate audio. It relies on > +@code{ffmpeg} to open various audio formats.") And I tweaked these to avoid so-called "marketing language" and to clarify that pydub is in Python, which I think can be useful when searching for packages. --bp/iNruPH9dso1Pn Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAl+cek8ACgkQJkb6MLrK fwiMQw/5AV7OM2P/GXuHLo3DbNxCQYl1AEWOi10s0qEuaN2ftWRSGuDjN7h5hI26 SRXtT02SKMZ4eub09Ry9u0CMcu9LmHORp585bTPTbX+b4/i7pUCzMMweGqc5AgeP ScDpot+o8nxdrCwbc0xqiXOjDr9+3fiYnk6tZjWHCIYyl0H1o+wV/IxziJboBZ4D O9m+ie8221Up5sKxeTySth71YQ2Iw9FZbHXbBzG/FSe0F24iaHjQyMU7ra8t0LJQ ixvnH49fVMCGX/47lvCL1O2rhm1rClp4CU4yzN0rcWgy/PhA8LgXM1uwXDnlFkXJ igZImn3Hj5PwL9CTWvMQ22rlPMnCOo0kSOoaAZ3GfcZLhvQd6LU1YCCUqe42xZ8M F574nguDEgxpS5c7PDjIR3TVXIuNmoA1vb9bUwQ5khd/YNNjiPhgn2rydmfOLAJl BueSKhbLuVZiHENKE8LZX7MbE7qjE0VkWJUjZp/nAGwwUh2u2gYc7D2quNylZFe1 BxC443DRYC5DcmdwEU9EGIes04W7AzB5BMCNSXeC+F0TCvxZsEWreBAYVz/0LfD/ 6QDAQ0Vi9HQ93ZyMs2ng0/k0GIGXCT1KO8fDVurY4WCshP4SZamicK6fS+GTdpTk +9fZxEj4u4Iwf3k7PS9Ib+Fpq6o23OqevDmJqMvWYreIKXIdMhg= =PHOd -----END PGP SIGNATURE----- --bp/iNruPH9dso1Pn-- From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 30 16:42:27 2020 Received: (at 44275-done) by debbugs.gnu.org; 30 Oct 2020 20:42:27 +0000 Received: from localhost ([127.0.0.1]:59888 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYbEB-0000pG-2B for submit@debbugs.gnu.org; Fri, 30 Oct 2020 16:42:27 -0400 Received: from out3-smtp.messagingengine.com ([66.111.4.27]:42781) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYbE8-0000p1-P2 for 44275-done@debbugs.gnu.org; Fri, 30 Oct 2020 16:42:25 -0400 Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id 998905C015B; Fri, 30 Oct 2020 16:42:19 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute3.internal (MEProxy); Fri, 30 Oct 2020 16:42:19 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name; h=date:from:to:cc:subject:message-id:references:mime-version :content-type:content-transfer-encoding:in-reply-to; s=mesmtp; bh=NQ3Orh0xCkA81bCBvetMLbhfg/9OQX4sCcw9pNtImwo=; b=yXh8t1cwkH3s 8QdaAtQv/NozCLkkzVr4Mfc7BPg6gkjo1XyU93BN9XSGl4+UjIAp6AW2N16rf/F7 /pHqHNAZWviGmganjn8IpfpEepB1k4Hd1ayty6gTjiVmvvAuXGce/zzt9eke768l 9nDCcEX/QmyKepD3FxXJ3Kt6ffs6wo8= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; bh=NQ3Orh0xCkA81bCBvetMLbhfg/9OQX4sCcw9pNtIm wo=; b=KTb0GpbzmVyheyLcqoye9W2Eb0A1uwaSa/FpBizCnQugLBGieP4AVeQnu AiYWFwfFK8E3mCyfwI/Pv5fj83+0AHf1rRx0l8R/O/G1jma7Mqoc9y/XXsmvpdBl rLI3h7bkGGxrdLAXocpgEhOgsdMILjU/tmjScTRZEUbvaTo4ErPgVecO1whGNyiB OuB27xJHLfXxSsWnza3QV+qfW62Z8L2KJ3jTgHcQtOmVyaz4+IQhp3xaRvm/O6yG MqeU8CROQteh1dfFQLJZz9PNH+8+qUGaBs+QsDNeealZwhIlxF8S4kjfIe8Jzj5Q kh3wxdnJxVbKxggHastpLqirRnbRg== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedujedrleehgddufeehucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepfffhvffukfhfgggtugfgjgesthekredttddtjeenucfhrhhomhepnfgvohcu hfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuggftrfgrth htvghrnhepgfduffettedtkeekudfhgfefgfeifeegueeitedujeffleeiudeuieffgfdu gfdunecuffhomhgrihhnpehgnhhurdhorhhgnecukfhppeejfedrudeguddruddvjedrud egieenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehl vghosehfrghmuhhlrghrihdrnhgrmhgv X-ME-Proxy: Received: from localhost (c-73-141-127-146.hsd1.pa.comcast.net [73.141.127.146]) by mail.messagingengine.com (Postfix) with ESMTPA id 303C2328005D; Fri, 30 Oct 2020 16:42:19 -0400 (EDT) Date: Fri, 30 Oct 2020 16:42:17 -0400 From: Leo Famulari To: Tanguy Le Carrour Subject: Re: [bug#44275] [PATCH] gnu: Add python-pydub. Message-ID: <20201030204217.GA13279@jasmine.lan> References: <20201028085654.18295-1-tanguy@bioneland.org> <20201028163450.GE12095@jasmine.lan> <20201029082657.xb3we5aqncp7qqci@rafflesia> <20201029141427.GB8956@jasmine.lan> <20201029215053.GA11109@jasmine.lan> <20201030091901.3wktfpjmup64kflh@melmoth> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20201030091901.3wktfpjmup64kflh@melmoth> X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44275-done Cc: 44275-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) On Fri, Oct 30, 2020 at 10:19:01AM +0100, Tanguy Le Carrour wrote: > So I guess you didn't see the one I submitted: https://debbugs.gnu.org/cgi/bugreport.cgi?bug=44275#14 :-( Oops! I missed your v2 patch by mistake. > I was really proud, because… it worked! :-) And it's better than my solution! From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 30 17:10:41 2020 Received: (at 44275-done) by debbugs.gnu.org; 30 Oct 2020 21:10:41 +0000 Received: from localhost ([127.0.0.1]:59935 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYbfU-0001YG-T2 for submit@debbugs.gnu.org; Fri, 30 Oct 2020 17:10:41 -0400 Received: from relay6-d.mail.gandi.net ([217.70.183.198]:33309) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kYbfT-0001Y2-3v for 44275-done@debbugs.gnu.org; Fri, 30 Oct 2020 17:10:39 -0400 X-Originating-IP: 176.185.184.238 Received: from android-ca1f6f180ba97f5a (static-176-185-184-238.axione.abo.bbox.fr [176.185.184.238]) (Authenticated sender: tanguy@bioneland.org) by relay6-d.mail.gandi.net (Postfix) with ESMTPSA id ABD67C0004; Fri, 30 Oct 2020 21:10:31 +0000 (UTC) Date: Fri, 30 Oct 2020 22:10:12 +0100 User-Agent: K-9 Mail for Android In-Reply-To: <20201030204047.GA10794@jasmine.lan> References: <20201029090929.10508-1-tanguy@bioneland.org> <20201030204047.GA10794@jasmine.lan> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Subject: Re: [PATCH v2] gnu: Add python-pydub. To: Leo Famulari From: Tanguy LE CARROUR Message-ID: <2E87DEE0-ECF4-441F-B69D-51911ABDBD7C@bioneland.org> X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44275-done Cc: 44275-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Hi, Le 30 octobre 2020 21:40:47 CET, Leo Famulari a =C3= =A9crit : >On Thu, Oct 29, 2020 at 10:09:29AM +0100, Tanguy Le Carrour wrote: >> * gnu/packages/python-xyz=2Escm (python-pydub): New variable=2E > >Thanks! Pushed as 96767739a1d2222ed802dd5dcfa2bda1df85df77 > >> + (add-after 'unpack 'fix-ffmpeg-path >> + (lambda* (#:key inputs #:allow-other-keys) >> + (let ((ffmpeg (assoc-ref inputs "ffmpeg"))) >> + (substitute* '("pydub/utils=2Epy") >> + (("return \"ffmpeg\"") >> + (string-append "return \"" ffmpeg >"/bin/ffmpeg\"")) >> + (("return \"ffplay\"") >> + (string-append "return \"" ffmpeg >"/bin/ffplay\"")) >> + (("return \"ffprobe\"") >> + (string-append "return \"" ffmpeg >"/bin/ffprobe\"")) >> + (("warn\\(\"Couldn't find ff") "# warn\\(\"Couldn't >find ff")) >> + #t)))))) > >This solution is more correct than the one I suggested=2E Thanks! > >> + (home-page "http://pydub=2Ecom") > >I made this use HTTPS=2E > >> + (synopsis "Manipulate audio with an simple and easy high level >interface") >> + (description >> + "@code{pydub} makes it easy to manipulate audio=2E It relies on >> +@code{ffmpeg} to open various audio formats=2E") > >And I tweaked these to avoid so-called "marketing language" and to >clarify that pydub is in Python, which I think can be useful when >searching for packages=2E Thanks! --=20 Tanguy From unknown Fri Aug 08 15:17:58 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 28 Nov 2020 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator