GNU bug report logs - #44274
[PATCH] gnu: Add emacs-powershell.el

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44274 in the body.
You can then email your comments to 44274 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Adam Kandur <rndd <at> tuta.io>
To: Guix Patches <guix-patches <at> gnu.org>
Subject: [PATCH] gnu: Add emacs-powershell.el
Date: Wed, 28 Oct 2020 09:39:13 +0100 (CET)

[Message part 1 (text/plain, inline)]

Sometimes use it for work, would be great to have in guix,

Adam Kandur

[0001-gnu-Add-emacs-powershell.el.patch (text/x-patch, attachment)]

Message #8 received at 44274 <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Adam Kandur via Guix-patches via <guix-patches <at> gnu.org>
Cc: 44274 <at> debbugs.gnu.org, Adam Kandur <rndd <at> tuta.io>
Subject: Re: [bug#44274] [PATCH] gnu: Add emacs-powershell.el
Date: Wed, 28 Oct 2020 10:27:47 +0100

Hello,

Adam Kandur via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/emacs-xyz.scm (emacs-powershell.el): New variable.

Thank you. Some comments follow.

> +(define-public emacs-powershell.el

I suggest to rename it emacs-powershell.

> +  (let ((revision "0")
> +        (commit "d1b3f95669343399f199f291ef76c09a0ede5e60"))
> +    (package
> +      (name "emacs-powershell.el")

See above.

> +      (build-system emacs-build-system)
> +      (arguments
> +       `(#:include '("\\.el$")))
> +      (version "master") ;; tagged branch is outdated (2015)

Version is 0.3 per main Elisp file.

Also, end of line comments start with a single semicolon. Two semicolons
are used only for full line comments. In any case, I suggest to write
the comment above `package' instead.

> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +	       (url "https://github.com/jschaf/powershell.el")

There seem to be an issue with indentation here.

> +	       (commit version)))

This should be (commit commit)

> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32 "1cxhzaaig88zhylyycvb3849r85j1ijqklnh9zbqsfl2zhpb0g5c"))))
> +      (home-page "https://github.com/jschaf/powershell.el")
> +      (synopsis "Mode for editing PowerShell scripts")

I suggest:

  Emacs mode for editing PowerShell scripts

> +      (description "@code{powershell.el} Mode is an Emacs major mode for editing and running Microsoft PowerShell files.")

I suggest:

  Powershell is an Emacs major mode…

The library is really named Powershell, and the capitalization makes it
different from PowerShell.

Could you send an updated patch?

Regards,
-- 
Nicolas Goaziou

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Adam Kandur via Guix-patches via <guix-patches <at> gnu.org>
Cc: 44274 <at> debbugs.gnu.org, Adam Kandur <rndd <at> tuta.io>
Subject: Re: [bug#44274] [PATCH] gnu: Add emacs-powershell.el
Date: Wed, 28 Oct 2020 11:01:17 +0100

Adam Kandur via Guix-patches via <guix-patches <at> gnu.org> writes:

> +      (arguments
> +       `(#:include '("\\.el$")))

In addition to my other comments, I don't think the section above is
needed.

Regards,

Message #20 received at 44274 <at> debbugs.gnu.org (full text, mbox):

From: Adam Kandur <rndd <at> tuta.io>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 44274 <at> debbugs.gnu.org
Subject: Re: [bug#44274] [PATCH] gnu: Add emacs-powershell.el
Date: Wed, 28 Oct 2020 12:04:12 +0100 (CET)

[Message part 1 (text/plain, inline)]

hi, attached new patch. hope it is correct



Oct 28, 2020, 10:01 by mail <at> nicolasgoaziou.fr:

> Adam Kandur via Guix-patches via <guix-patches <at> gnu.org> writes:
>
>> +      (arguments
>> +       `(#:include '("\\.el$")))
>>
>
> In addition to my other comments, I don't think the section above is
> needed.
>
> Regards,
>

[0001-gnu-Add-emacs-powershell.patch (text/x-patch, attachment)]

Message #25 received at 44274-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: Adam Kandur <rndd <at> tuta.io>
Cc: 44274-done <at> debbugs.gnu.org
Subject: Re: [bug#44274] [PATCH] gnu: Add emacs-powershell.el
Date: Thu, 29 Oct 2020 10:20:07 +0100

Hello,

Adam Kandur <rndd <at> tuta.io> writes:

> hi, attached new patch. hope it is correct

I fixed indentation, the version tag, added a home-page, tweaked the
description, and pushed your patch.

Thanks.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.