From irieshinsuke@gmail.com Mon Sep 14 02:19:08 2009 Received: (at submit) by emacsbugs.donarmstrong.com; 14 Sep 2009 09:19:08 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.1 required=4.0 tests=FOURLA autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8E9J6rd011670 for ; Mon, 14 Sep 2009 02:19:07 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mn7iD-0004h5-Hg for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2009 05:19:05 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mn7i7-0004ZA-W9 for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2009 05:19:04 -0400 Received: from [199.232.76.173] (port=50471 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mn7i7-0004Yo-7T for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2009 05:18:59 -0400 Received: from mail-yw0-f190.google.com ([209.85.211.190]:64884) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mn7i6-0007E0-NM for bug-gnu-emacs@gnu.org; Mon, 14 Sep 2009 05:18:59 -0400 Received: by ywh28 with SMTP id 28so4303611ywh.15 for ; Mon, 14 Sep 2009 02:18:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :reply-to:user-agent:mime-version:to:subject:content-type :content-transfer-encoding; bh=St1YDpbRk2xHqTbVqZWlQsQf6PJryDUmtOOMBMxgT/o=; b=FkSGJWX5ZQ7hezX3PZRWR2toWs2uOn55pdOuz5/K1iUu2zeez4fGNX3CPx1EroAPQp yrlXoL1QGUDWIq3H5US9eYzAeU9l0PVelNk06gxLdAzvcAuUQjf8tNAZOo6j4Q6nEwDo O2RRqToWTBFSEfZS/wtoqaBbQSWseW1AZRd3c= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:reply-to:user-agent:mime-version:to :subject:content-type:content-transfer-encoding; b=vIEfmLql3xLPuYga+P0UrezJKQ1dBLyNtIFH5/EpCxwQbOhcI8gCU3pcGg2JqzJErL T54SjJocGUqNMTZF5knHQy28bQj73RFkz57e6Y+HqLHQIWPoK1eEUuVcJGcBQGglSEvQ 6LrjBcbi3lnfLBw96/VdaprVMWaVYJ76h0e4E= Received: by 10.90.188.17 with SMTP id l17mr3753212agf.30.1252919937349; Mon, 14 Sep 2009 02:18:57 -0700 (PDT) Received: from ?114.51.31.64? (EM114-51-31-64.pool.e-mobile.ne.jp [114.51.31.64]) by mx.google.com with ESMTPS id 10sm7995949agd.21.2009.09.14.02.18.54 (version=TLSv1/SSLv3 cipher=RC4-MD5); Mon, 14 Sep 2009 02:18:56 -0700 (PDT) Sender: IRIE Shinsuke Message-ID: <4AAE0A77.3010807@yahoo.co.jp> Date: Mon, 14 Sep 2009 18:18:47 +0900 From: IRIE Shinsuke Reply-To: irieshinsuke@yahoo.co.jp User-Agent: Thunderbird 2.0.0.23 (X11/20090817) MIME-Version: 1.0 To: bug-gnu-emacs@gnu.org Subject: 23.0.91; posn-at-point returns an incorrect value Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 2) I was going to acquire the width and height of a character the cursor is over, by using the following code: (posn-object-width-height (posn-at-point)) However, I found that this code gives back a wrong result when a header line is displayed such as tabbar-mode. This code returns the size of another character, which is in the position different from the exact one in the number of objects included in the header line. For example, when the cursor is in the top left corner of the window, the size of the object in the left end of the header line is obtained. Steps to reproduce: 1. Turn on tabbar-mode. 2. Evaluate the following expressions in *scratch*: (defun char-w-h () (message "%s" (posn-object-width-height (posn-at-point)))) (add-hook 'post-command-hook 'char-w-h) 3. Move a cursor from place to place in the window. In GNU Emacs 23.0.91.1 (i486-pc-linux-gnu, GTK+ Version 2.16.0) of 2009-04-05 on palmer, modified by Debian (emacs-snapshot package, version 1:20090320-1ubuntu1) Windowing system distributor `The X.Org Foundation', version 11.0.10600000 configured using `configure '--build' 'i486-linux-gnu' '--host' 'i486-linux-gnu' '--prefix=/usr' '--sharedstatedir=/var/lib' '--libexecdir=/usr/lib' '--localstatedir=/var' '--infodir=/usr/share/info' '--mandir=/usr/share/man' '--with-pop=yes' '--enable-locallisppath=/etc/emacs-snapshot:/etc/emacs:/usr/local/share/emacs/23.0.91/site-lisp:/usr/local/share/emacs/site-lisp:/usr/share/emacs/23.0.91/site-lisp:/usr/share/emacs/site-lisp' '--with-x=yes' '--with-x-toolkit=gtk' 'build_alias=i486-linux-gnu' 'host_alias=i486-linux-gnu' 'CFLAGS=-DDEBIAN -DSITELOAD_PURESIZE_EXTRA=5000 -g -O2' 'LDFLAGS=-g -Wl,--as-needed' 'CPPFLAGS='' Important settings: value of $LC_ALL: nil value of $LC_COLLATE: nil value of $LC_CTYPE: nil value of $LC_MESSAGES: nil value of $LC_MONETARY: nil value of $LC_NUMERIC: nil value of $LC_TIME: nil value of $LANG: ja_JP.UTF-8 value of $XMODIFIERS: @im=none locale-coding-system: utf-8-unix default-enable-multibyte-characters: t Major mode: Lisp Interaction Minor modes in effect: tabbar-mwheel-mode: t tabbar-mode: t tooltip-mode: t tool-bar-mode: t mouse-wheel-mode: t menu-bar-mode: t file-name-shadow-mode: t global-font-lock-mode: t font-lock-mode: t blink-cursor-mode: t global-auto-composition-mode: t auto-composition-mode: t auto-encryption-mode: t auto-compression-mode: t line-number-mode: t transient-mark-mode: t Recent input: u i r e SPC ' t C-p C-p C-p C-p C-p C-p C-p C-n C-n C-n C-n C-n C-f C-f C-f C-f C-f C-f C-f C-f C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-n C-n C-e a b b a r ) C-j ( t a b b a r - m o d e ) C-j C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-n C-p C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-n C-p C-p C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-b C-n C-n C-n C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-n C-n C-n C-p C-p C-p C-p C-p C-n C-n C-b C-p C-p C-n C-a C-f C-f C-f C-f C-f C-f C-p C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-p C-a C-a C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-f C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n C-n ( r e m o v e - h o o k SPC ' p o s t - c o m m a n d - h o o k SPC ' c h a r - w - h ) C-j M-x r e p o r t - e m a RET Recent messages: (7 . 14) [3 times] (0 . 14) (7 . 14) (0 . 14) (7 . 14) (0 . 14) (7 . 14) (0 . 14) (7 . 14) [3 times] (0 . 14) [41 times] -- IRIE Shinsuke, Ph.D. irieshinsuke@yahoo.co.jp From irieshinsuke@gmail.com Wed Sep 16 21:30:50 2009 Received: (at 4426) by emacsbugs.donarmstrong.com; 17 Sep 2009 04:30:50 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=-1.4 required=4.0 tests=AWL,FOURLA,HAS_BUG_NUMBER autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-yw0-f186.google.com (mail-yw0-f186.google.com [209.85.211.186]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8H4UnUR029827 for <4426@emacsbugs.donarmstrong.com>; Wed, 16 Sep 2009 21:30:50 -0700 Received: by ywh16 with SMTP id 16so8605302ywh.13 for <4426@emacsbugs.donarmstrong.com>; Wed, 16 Sep 2009 21:30:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :reply-to:user-agent:mime-version:to:subject:content-type :content-transfer-encoding; bh=WvHZlW0ND8mL39RR2ntQcixeGFCm5Ur74lOSDdhwMWI=; b=qGGROHk8/6yF5hxm87n68mce1nl8qxtlPobiZtTA5gR3Jl0OnWjwH4YB82EzefiEPH nIq2RNcBeHKfmqv1TeFuljqbXVGjFbda+Hb+Np1nE7oTX0wd0sNp0P0pcT0kDH9o6Ix1 YQOYeCSFZchdXNR1IBvecfUaDzkdz5fui3LK4= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:reply-to:user-agent:mime-version:to :subject:content-type:content-transfer-encoding; b=eq9Po2H+/c0QAhxX2Qa5Q69BBBtmL4eRc4suCeFEanYdtzTCy0t5raupsGqWMq32MH O14mbdFVmLEejwj/lWtmQfrXWd6nIOC4TznNoC/YVDg13LqaF11qgurwMxsPkRv4d9Fo imwLO9O6L66YQwfuM/7rmcE4DsOsDBrBUmuV0= Received: by 10.91.19.4 with SMTP id w4mr119700agi.0.1253161843489; Wed, 16 Sep 2009 21:30:43 -0700 (PDT) Received: from ?114.51.147.244? (EM114-51-147-244.pool.e-mobile.ne.jp [114.51.147.244]) by mx.google.com with ESMTPS id 7sm273069agb.41.2009.09.16.21.30.40 (version=TLSv1/SSLv3 cipher=RC4-MD5); Wed, 16 Sep 2009 21:30:42 -0700 (PDT) Sender: IRIE Shinsuke Message-ID: <4AB1BB6C.2000109@yahoo.co.jp> Date: Thu, 17 Sep 2009 13:30:36 +0900 From: IRIE Shinsuke Reply-To: irieshinsuke@yahoo.co.jp User-Agent: Thunderbird 2.0.0.23 (X11/20090817) MIME-Version: 1.0 To: 4426@debbugs.gnu.org Subject: bug#4426: Further information Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit I confirmed that this behavior also happens in Emacs 23.1.50.1, 23.1.1 and 22.2.1. -- IRIE Shinsuke, Ph.D. irieshinsuke@yahoo.co.jp From debbugs-submit-bounces@debbugs.gnu.org Wed Mar 17 00:01:45 2010 Received: (at 4426) by debbugs.gnu.org; 17 Mar 2010 04:01:45 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NrkS1-0003mo-Jt for submit@debbugs.gnu.org; Wed, 17 Mar 2010 00:01:45 -0400 Received: from mail-gw0-f44.google.com ([74.125.83.44]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1NrkS0-0003mj-AL for 4426@debbugs.gnu.org; Wed, 17 Mar 2010 00:01:45 -0400 Received: by gwj18 with SMTP id 18so298761gwj.3 for <4426@debbugs.gnu.org>; Tue, 16 Mar 2010 21:01:40 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:sender:message-id:date:from :reply-to:user-agent:mime-version:to:subject:x-enigmail-version :content-type; bh=Qwb/l8kM39OtgIYD2IwAe+eI4TaV9JroLCM1s3sCrpI=; b=kk9OzVjDcfzw0l5GEQGCMjmxxtzBVv3i/lHgoTZ3D1cAs/Oq1V5apSMaAFNzSFm5Gg JLBCMdLt6GDv8HEA3UEjRcHQc8iSvkce/W01gwGgtRUfT6OARo52YSLqIfwORbL+aDSo pK+WTo8Pc9FszQXybUaj2ysKRtCAXtFOQo20I= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=sender:message-id:date:from:reply-to:user-agent:mime-version:to :subject:x-enigmail-version:content-type; b=UEzV4YUtDphx2alN17d9nxXXYKT7NcZJmPdxzYKs8pewEdwf8zVVGoC21dURv5xPzv RjzbtpqzaRYT+Ysj/NwrmXMUZiFU1k3atOmG2RK+iEd4OQjOqbYvvjjkcamus7EoPYFz szTfYADzEtV1q5QTROnwOwfWehjIHMLQ3GjuI= Received: by 10.100.81.2 with SMTP id e2mr482238anb.332.1268798500585; Tue, 16 Mar 2010 21:01:40 -0700 (PDT) Received: from [114.51.157.58] (EM114-51-157-58.pool.e-mobile.ne.jp [114.51.157.58]) by mx.google.com with ESMTPS id 16sm4086764gxk.5.2010.03.16.21.01.37 (version=TLSv1/SSLv3 cipher=RC4-MD5); Tue, 16 Mar 2010 21:01:39 -0700 (PDT) Message-ID: <4BA05437.8000303@yahoo.co.jp> Date: Wed, 17 Mar 2010 13:01:59 +0900 From: IRIE Shinsuke User-Agent: Mozilla/5.0 (X11; U; Linux i686; ja; rv:1.9.1.8) Gecko/20100227 Thunderbird/3.0.3 MIME-Version: 1.0 To: 4426@debbugs.gnu.org Subject: bug#4426: [PATCH] posn-at-point returns an incorrect value X-Enigmail-Version: 1.0.1 Content-Type: multipart/mixed; boundary="------------010202010008050600060609" X-Spam-Score: -3.0 (---) X-Debbugs-Envelope-To: 4426 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: irieshinsuke@yahoo.co.jp List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -3.5 (---) This is a multi-part message in MIME format. --------------010202010008050600060609 Content-Type: text/plain; charset=ISO-2022-JP Content-Transfer-Encoding: 7bit 6 months ago I reported bug #4426, that is, `posn-at-point' returns incorrect value when header line is displayed. I've investigated this bug and found the solution. I describe again this bug: If header line is displayed, `posn-object-width-height' incorrectly returns the size of object in position different from specified one. For example, an expression (posn-object-width-height (posn-at-point (window-start))) must return the width and height of character on the top left corner of text area, but actually returns the ones on the beginning of header line. It turned out that this problem occurs as a result of confusion between it.vpos and MATRIX_ROW_VPOS in a function buffer_posn_from_coords (included in dispnew.c). So I wrote the small patch to fix this bug. Please check it. IRIE Shinsuke --------------010202010008050600060609 Content-Type: text/x-diff; name="fix_bug4426.patch" Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename="fix_bug4426.patch" === modified file 'src/dispnew.c' *** old/src/dispnew.c 2010-03-16 14:48:29 +0000 --- new/src/dispnew.c 2010-03-16 16:06:28 +0000 *************** *** 5937,5942 **** --- 5937,5943 ---- Lisp_Object old_current_buffer = Fcurrent_buffer (); struct text_pos startp; Lisp_Object string; + int matrix_vpos; struct glyph_row *row; #ifdef HAVE_WINDOW_SYSTEM struct image *img = 0; *************** *** 5974,5981 **** } #endif ! if (it.vpos < w->current_matrix->nrows ! && (row = MATRIX_ROW (w->current_matrix, it.vpos), row->enabled_p)) { if (it.hpos < row->used[TEXT_AREA]) --- 5975,5984 ---- } #endif ! /* it.vpos isn't the same as MATRIX_ROW_VPOS if header line is displayed */ ! matrix_vpos = (w->current_matrix->rows->mode_line_p ? 1 : 0) + it.vpos; ! if (matrix_vpos < w->current_matrix->nrows ! && (row = MATRIX_ROW (w->current_matrix, matrix_vpos), row->enabled_p)) { if (it.hpos < row->used[TEXT_AREA]) --------------010202010008050600060609-- From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 18 04:27:54 2011 Received: (at control) by debbugs.gnu.org; 18 Sep 2011 08:27:54 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R5CjB-0001Tg-Hb for submit@debbugs.gnu.org; Sun, 18 Sep 2011 04:27:54 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R5CjA-0001Ta-GH for control@debbugs.gnu.org; Sun, 18 Sep 2011 04:27:53 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1R5CeK-0005cg-Dl for control@debbugs.gnu.org; Sun, 18 Sep 2011 10:22:52 +0200 Date: Sun, 18 Sep 2011 10:19:32 +0200 Message-Id: To: control@debbugs.gnu.org From: Lars Magne Ingebrigtsen Subject: control message for bug #4426 X-MailScanner-ID: 1R5CeK-0005cg-Dl X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1316938972.62153@L5JLKDyuLOC+99OgP45M+A X-Spam-Status: No X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) tags 4426 patch From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 18 04:49:03 2011 Received: (at 4426) by debbugs.gnu.org; 18 Sep 2011 08:49:03 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R5D3c-0003To-SO for submit@debbugs.gnu.org; Sun, 18 Sep 2011 04:49:03 -0400 Received: from hermes.netfonds.no ([80.91.224.195]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R5D3X-0003TK-6J for 4426@debbugs.gnu.org; Sun, 18 Sep 2011 04:48:56 -0400 Received: from cm-84.215.51.58.getinternet.no ([84.215.51.58] helo=stories.gnus.org) by hermes.netfonds.no with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1R5Cyg-00061c-CN; Sun, 18 Sep 2011 10:43:54 +0200 From: Lars Magne Ingebrigtsen To: irieshinsuke@yahoo.co.jp Subject: Re: bug#4426: [PATCH] posn-at-point returns an incorrect value In-Reply-To: <4BA05437.8000303@yahoo.co.jp> (IRIE Shinsuke's message of "Wed, 17 Mar 2010 13:01:59 +0900") Date: Sun, 18 Sep 2011 10:21:43 +0200 Message-ID: References: <4BA05437.8000303@yahoo.co.jp> User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.50 (gnu/linux) X-Now-Playing: Eurythmics's _Touch_: "Cool Blue" MIME-Version: 1.0 Content-Type: text/plain X-MailScanner-ID: 1R5Cyg-00061c-CN X-Netfonds-MailScanner: Found to be clean X-Netfonds-MailScanner-From: larsi@gnus.org MailScanner-NULL-Check: 1316940234.71639@IbuWjF0kR0v0qcrJy9609w X-Spam-Status: No X-Spam-Score: -2.7 (--) X-Debbugs-Envelope-To: 4426 Cc: 4426@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.7 (--) IRIE Shinsuke writes: > If header line is displayed, `posn-object-width-height' incorrectly > returns the size of object in position different from specified one. > > For example, an expression > > (posn-object-width-height (posn-at-point (window-start))) > > must return the width and height of character on the top left corner > of text area, but actually returns the ones on the beginning of > header line. > > It turned out that this problem occurs as a result of confusion between > it.vpos and MATRIX_ROW_VPOS in a function buffer_posn_from_coords > (included in dispnew.c). > > So I wrote the small patch to fix this bug. Please check it. [...] > ! if (it.vpos < w->current_matrix->nrows > ! && (row = MATRIX_ROW (w->current_matrix, it.vpos), > row->enabled_p)) > { > if (it.hpos < row->used[TEXT_AREA]) > --- 5975,5984 ---- > } > #endif > > ! /* it.vpos isn't the same as MATRIX_ROW_VPOS if header line is displayed */ > ! matrix_vpos = (w->current_matrix->rows->mode_line_p ? 1 : 0) + it.vpos; > ! if (matrix_vpos < w->current_matrix->nrows > ! && (row = MATRIX_ROW (w->current_matrix, matrix_vpos), > row->enabled_p)) > { > if (it.hpos < row->used[TEXT_AREA]) As far as I can tell, this patch hasn't been applied yet. I'm not familiar enough with this code to say whether this looks correct or not. Could someone take a look? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog http://lars.ingebrigtsen.no/ From debbugs-submit-bounces@debbugs.gnu.org Sun Sep 18 05:27:31 2011 Received: (at 4426) by debbugs.gnu.org; 18 Sep 2011 09:27:32 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R5Det-0005Ys-Nb for submit@debbugs.gnu.org; Sun, 18 Sep 2011 05:27:31 -0400 Received: from fencepost.gnu.org ([140.186.70.10]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1R5Des-0005Yh-57 for 4426@debbugs.gnu.org; Sun, 18 Sep 2011 05:27:30 -0400 Received: from eliz by fencepost.gnu.org with local (Exim 4.71) (envelope-from ) id 1R5Da7-0003S0-GP; Sun, 18 Sep 2011 05:22:35 -0400 Date: Sun, 18 Sep 2011 05:22:35 -0400 Message-Id: From: Eli Zaretskii To: Lars Magne Ingebrigtsen In-reply-to: (message from Lars Magne Ingebrigtsen on Sun, 18 Sep 2011 10:21:43 +0200) Subject: Re: bug#4426: [PATCH] posn-at-point returns an incorrect value References: <4BA05437.8000303@yahoo.co.jp> X-Spam-Score: -6.6 (------) X-Debbugs-Envelope-To: 4426 Cc: irieshinsuke@yahoo.co.jp, 4426@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -6.6 (------) > From: Lars Magne Ingebrigtsen > Date: Sun, 18 Sep 2011 10:21:43 +0200 > Cc: 4426@debbugs.gnu.org > > As far as I can tell, this patch hasn't been applied yet. I'm not > familiar enough with this code to say whether this looks correct or > not. Could someone take a look? Is the original problem still present? AFAIR, Chong fixed something similar some time ago. From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 08 07:01:33 2011 Received: (at 4426-done) by debbugs.gnu.org; 8 Oct 2011 11:01:33 +0000 Received: from localhost ([127.0.0.1] helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RCUer-0007D5-4o for submit@debbugs.gnu.org; Sat, 08 Oct 2011 07:01:33 -0400 Received: from mtaout21.012.net.il ([80.179.55.169]) by debbugs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1RCUen-0007Cm-9P for 4426-done@debbugs.gnu.org; Sat, 08 Oct 2011 07:01:30 -0400 Received: from conversion-daemon.a-mtaout21.012.net.il by a-mtaout21.012.net.il (HyperSendmail v2007.08) id <0LSQ00100UI8BK00@a-mtaout21.012.net.il> for 4426-done@debbugs.gnu.org; Sat, 08 Oct 2011 13:01:03 +0200 (IST) Received: from HOME-C4E4A596F7 ([77.124.91.138]) by a-mtaout21.012.net.il (HyperSendmail v2007.08) with ESMTPA id <0LSQ000ZUULPB180@a-mtaout21.012.net.il>; Sat, 08 Oct 2011 13:01:03 +0200 (IST) Date: Sat, 08 Oct 2011 13:01:06 +0200 From: Eli Zaretskii Subject: Re: bug#4426: [PATCH] posn-at-point returns an incorrect value In-reply-to: X-012-Sender: halo1@inter.net.il To: Lars Magne Ingebrigtsen Message-id: <83zkhbeoi5.fsf@gnu.org> References: <4BA05437.8000303@yahoo.co.jp> X-Spam-Score: -2.1 (--) X-Debbugs-Envelope-To: 4426-done Cc: 4426-done@debbugs.gnu.org, irieshinsuke@yahoo.co.jp X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.11 Precedence: list Reply-To: Eli Zaretskii List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: debbugs-submit-bounces@debbugs.gnu.org Errors-To: debbugs-submit-bounces@debbugs.gnu.org X-Spam-Score: -2.1 (--) > From: Lars Magne Ingebrigtsen > Date: Sun, 18 Sep 2011 10:21:43 +0200 > Cc: 4426@debbugs.gnu.org > > As far as I can tell, this patch hasn't been applied yet. I'm not > familiar enough with this code to say whether this looks correct or > not. Could someone take a look? I took a look. The problem indeed was still there. I installed a fix (slightly different from what the OP suggested). Thanks. From unknown Tue Aug 19 14:23:27 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 05 Nov 2011 11:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator