From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 27 09:37:16 2020 Received: (at submit) by debbugs.gnu.org; 27 Oct 2020 13:37:16 +0000 Received: from localhost ([127.0.0.1]:43330 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXPA0-0002IC-B5 for submit@debbugs.gnu.org; Tue, 27 Oct 2020 09:37:16 -0400 Received: from lists.gnu.org ([209.51.188.17]:39336) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXP9u-0002Hy-GW for submit@debbugs.gnu.org; Tue, 27 Oct 2020 09:37:10 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:58318) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kXP9u-0004zi-9K for guix-patches@gnu.org; Tue, 27 Oct 2020 09:37:06 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:50548) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXP9t-0001M3-Lh; Tue, 27 Oct 2020 09:37:05 -0400 Received: from [2a01:e0a:19b:d9a0:50c1:4a69:300e:4531] (port=37184 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kXP9s-000346-Ki; Tue, 27 Oct 2020 09:37:05 -0400 From: Mathieu Othacehe To: guix-patches@gnu.org Subject: Add pinebook-pro support. Date: Tue, 27 Oct 2020 14:37:02 +0100 Message-ID: <878sbru6wx.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: submit Cc: ennoausberlin@mac.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) --=-=-= Content-Type: text/plain Hello, Here's a patch adding support for the pinebook-pro. As I do not own one of those, it would be nice if someone could test it with the following commands: --8<---------------cut here---------------start------------->8--- echo "(use-modules (gnu system images pinebook-pro)) pinebook-pro-barebones-os" > /tmp/os.scm ./pre-inst-env guix system disk-image -t pinebook-pro-raw /tmp/os.scm --8<---------------cut here---------------end--------------->8--- on top of f0c609323e or later. Thanks, Mathieu --=-=-= Content-Type: text/x-diff; charset=utf-8 Content-Disposition: inline; filename=0001-image-Add-pinebook-pro-support.patch Content-Transfer-Encoding: quoted-printable >From 9487a2fa3b148ce9b680f7490f436f7f917827bc Mon Sep 17 00:00:00 2001 From: Mathieu Othacehe Date: Tue, 27 Oct 2020 14:05:52 +0100 Subject: [PATCH] image: Add pinebook-pro support. * gnu/system/images/pinebook-pro.scm: New file. * gnu/local.mk (GNU_SYSTEM_MODULES): Add it. * gnu/ci.scm (%guix-system-images): Add pinebook-pro-barebones-raw-image. --- gnu/ci.scm | 3 +- gnu/local.mk | 1 + gnu/system/images/pinebook-pro.scm | 66 ++++++++++++++++++++++++++++++ 3 files changed, 69 insertions(+), 1 deletion(-) create mode 100644 gnu/system/images/pinebook-pro.scm diff --git a/gnu/ci.scm b/gnu/ci.scm index bf9952a450..8e78cae82c 100644 --- a/gnu/ci.scm +++ b/gnu/ci.scm @@ -205,7 +205,8 @@ SYSTEM." =20 (define %guix-system-images (list hurd-barebones-qcow2-image - pine64-barebones-raw-image)) + pine64-barebones-raw-image + pinebook-pro-barebones-raw-image)) =20 (define (image-jobs store system) "Return a list of jobs that build images for SYSTEM." diff --git a/gnu/local.mk b/gnu/local.mk index c6aa58b24f..be3043460e 100644 --- a/gnu/local.mk +++ b/gnu/local.mk @@ -650,6 +650,7 @@ GNU_SYSTEM_MODULES =3D \ \ %D%/system/images/hurd.scm \ %D%/system/images/pine64.scm \ + %D%/system/images/pinebook-pro.scm \ \ %D%/machine.scm \ \ diff --git a/gnu/system/images/pinebook-pro.scm b/gnu/system/images/pineboo= k-pro.scm new file mode 100644 index 0000000000..b038e262cb --- /dev/null +++ b/gnu/system/images/pinebook-pro.scm @@ -0,0 +1,66 @@ +;;; GNU Guix --- Functional package management for GNU +;;; Copyright =C2=A9 2020 Mathieu Othacehe +;;; +;;; This file is part of GNU Guix. +;;; +;;; GNU Guix is free software; you can redistribute it and/or modify it +;;; under the terms of the GNU General Public License as published by +;;; the Free Software Foundation; either version 3 of the License, or (at +;;; your option) any later version. +;;; +;;; GNU Guix is distributed in the hope that it will be useful, but +;;; WITHOUT ANY WARRANTY; without even the implied warranty of +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +;;; GNU General Public License for more details. +;;; +;;; You should have received a copy of the GNU General Public License +;;; along with GNU Guix. If not, see . + +(define-module (gnu system images pinebook-pro) + #:use-module (gnu bootloader) + #:use-module (gnu bootloader u-boot) + #:use-module (gnu image) + #:use-module (gnu packages linux) + #:use-module (gnu services) + #:use-module (gnu services base) + #:use-module (gnu system) + #:use-module (gnu system file-systems) + #:use-module (gnu system image) + #:use-module (srfi srfi-26) + #:export (pinebook-pro-barebones-os + pinebook-pro-image-type + pinebook-pro-barebones-raw-image)) + +(define pinebook-pro-barebones-os + (operating-system + (host-name "viso") + (timezone "Europe/Paris") + (locale "en_US.utf8") + (bootloader (bootloader-configuration + (bootloader u-boot-pinebook-pro-rk3399-bootloader) + (target "/dev/vda"))) + (initrd-modules '()) + (kernel linux-libre-arm64-generic) + (file-systems (cons (file-system + (device (file-system-label "my-root")) + (mount-point "/") + (type "ext4")) + %base-file-systems)) + (services (cons (service agetty-service-type + (agetty-configuration + (extra-options '("-L")) ; no carrier detect + (baud-rate "115200") + (term "vt100") + (tty "ttyS0"))) + %base-services)))) + +(define pinebook-pro-image-type + (image-type + (name 'pinebook-pro-raw) + (constructor (cut image-with-os arm64-disk-image <>)))) + +(define pinebook-pro-barebones-raw-image + (image + (inherit + (os->image pinebook-pro-barebones-os #:type pinebook-pro-image-type)) + (name 'pinebook-pro-barebones-raw-image))) --=20 2.28.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Wed Oct 28 11:23:57 2020 Received: (at 44255) by debbugs.gnu.org; 28 Oct 2020 15:23:57 +0000 Received: from localhost ([127.0.0.1]:50165 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXnIq-0002c4-SH for submit@debbugs.gnu.org; Wed, 28 Oct 2020 11:23:57 -0400 Received: from eggs.gnu.org ([209.51.188.92]:46174) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXnIp-0002bm-5h for 44255@debbugs.gnu.org; Wed, 28 Oct 2020 11:23:55 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46216) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kXnIj-000753-UF; Wed, 28 Oct 2020 11:23:49 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=44662 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kXnIi-00041C-3z; Wed, 28 Oct 2020 11:23:48 -0400 From: =?utf-8?Q?Ludovic_Court=C3=A8s?= To: Mathieu Othacehe Subject: Re: [bug#44255] Add pinebook-pro support. References: <878sbru6wx.fsf@gnu.org> Date: Wed, 28 Oct 2020 16:23:46 +0100 In-Reply-To: <878sbru6wx.fsf@gnu.org> (Mathieu Othacehe's message of "Tue, 27 Oct 2020 14:37:02 +0100") Message-ID: <87zh46z859.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44255 Cc: ennoausberlin@mac.com, 44255@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hi! Mathieu Othacehe skribis: > Here's a patch adding support for the pinebook-pro. As I do not own one > of those, it would be nice if someone could test it with the following > commands: > > echo "(use-modules (gnu system images pinebook-pro)) pinebook-pro-barebon= es-os" > /tmp/os.scm > ./pre-inst-env guix system disk-image -t pinebook-pro-raw /tmp/os.scm > > on top of f0c609323e or later. I do not have a Pinebook Pro either, but it looks like a great addition. Should it be mentioned in the manual? Otherwise LGTM, thanks! Ludo=E2=80=99. From debbugs-submit-bounces@debbugs.gnu.org Fri Nov 20 11:18:21 2020 Received: (at 44255-done) by debbugs.gnu.org; 20 Nov 2020 16:18:21 +0000 Received: from localhost ([127.0.0.1]:44209 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kg977-0005vA-CY for submit@debbugs.gnu.org; Fri, 20 Nov 2020 11:18:21 -0500 Received: from eggs.gnu.org ([209.51.188.92]:60712) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kg974-0005uw-PC for 44255-done@debbugs.gnu.org; Fri, 20 Nov 2020 11:18:20 -0500 Received: from fencepost.gnu.org ([2001:470:142:3::e]:36185) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kg96y-0004zT-U2; Fri, 20 Nov 2020 11:18:12 -0500 Received: from [2a01:e0a:19b:d9a0:b0e9:5d53:5d5c:ccf2] (port=59868 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kg96y-0004lz-2J; Fri, 20 Nov 2020 11:18:12 -0500 From: Mathieu Othacehe To: Ludovic =?utf-8?Q?Court=C3=A8s?= Subject: Re: [bug#44255] Add pinebook-pro support. References: <878sbru6wx.fsf@gnu.org> <87zh46z859.fsf@gnu.org> Date: Fri, 20 Nov 2020 17:18:08 +0100 In-Reply-To: <87zh46z859.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Wed, 28 Oct 2020 16:23:46 +0100") Message-ID: <87o8jsdmtb.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44255-done Cc: ennoausberlin@mac.com, 44255-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) Hello, No comments from pinebook owners so I went ahead. > Should it be mentioned in the manual? Yes I plan to write a manual section detailing the different image types. Thanks for reviewing, Mathieu From unknown Fri Jun 20 18:20:07 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sat, 19 Dec 2020 12:24:06 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator