Subject: Re: [bug#44251] [PATCH] gnu: Add pwclient.

From: Christopher Baines <[email-masked]>
Date: Wed, 28 Oct 2020 13:30:46 +0000

Leo Famulari <[email-masked]> writes:

> On Tue, Oct 27, 2020 at 09:46:02AM +0000, Christopher Baines wrote:
>> * gnu/packages/patchutils.scm (pwclient): New variable.
>
>> +         (add-after 'unpack 'patch
>> +           (lambda _
>> +             (substitute* "test-requirements.txt"
>> +               (("pytest>=3.0,<5.0;")
>> +                "pytest>=3.0,<6.0;"))
>> +             #t))
>
> I would call the phase 'patch-requirements' or similar and add a brief
> comment explaining it.

I've renamed the phase now, and added a comment.

>> +    (native-inputs
>> +     `(("npython-pbr" ,python-pbr)
>
> Typo here --^

Indeed, I've removed the rogue n.

I've sent an updated patch, which fixes a few more things as well.