GNU bug report logs - #44251
[PATCH] gnu: Add pwclient.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44251 in the body.
You can then email your comments to 44251 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add pwclient.
Date: Tue, 27 Oct 2020 09:46:02 +0000

* gnu/packages/patchutils.scm (pwclient): New variable.
---
 gnu/packages/patchutils.scm | 41 +++++++++++++++++++++++++++++++++++++
 1 file changed, 41 insertions(+)

diff --git a/gnu/packages/patchutils.scm b/gnu/packages/patchutils.scm
index 12dd472c68..e0ed30070b 100644
--- a/gnu/packages/patchutils.scm
+++ b/gnu/packages/patchutils.scm
@@ -468,3 +468,44 @@ patches, and displays the patches along with comments and state information.
 Users can login allowing them to change the state of patches.")
     (home-page "http://jk.ozlabs.org/projects/patchwork/")
     (license gpl2+)))
+
+(define-public pwclient
+  (package
+    (name "pwclient")
+    (version "1.3.0")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/getpatchwork/pwclient")
+                    (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1xckwvcqklzpyh3xs4k2zm40ifp0q5fdkj2vmgb8vhfvl1ivs6jv"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'patch
+           (lambda _
+             (substitute* "test-requirements.txt"
+               (("pytest>=3.0,<5.0;")
+                "pytest>=3.0,<6.0;"))
+             #t))
+         (add-before 'build 'set-PBR_VERSION
+           (lambda _
+             (setenv "PBR_VERSION"
+                     ,version)
+             #t)))))
+    (native-inputs
+     `(("npython-pbr" ,python-pbr)
+       ("python-pytest" ,python-pytest)
+       ("python-pytest-cov" ,python-pytest-cov)
+       ("python-mock" ,python-mock)))
+    (home-page
+     "https://github.com/getpatchwork/pwclient")
+    (synopsis "Command-line client for the Patchwork patch tracking tool")
+    (description
+     "pwclient is a VCS-agnostic tool for interacting with Patchwork, the
+web-based patch tracking system.")
+    (license gpl2+)))
-- 
2.28.0

Message #8 received at 44251 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 44251 <at> debbugs.gnu.org
Subject: Re: [bug#44251] [PATCH] gnu: Add pwclient.
Date: Tue, 27 Oct 2020 19:05:24 -0400

On Tue, Oct 27, 2020 at 09:46:02AM +0000, Christopher Baines wrote:
> * gnu/packages/patchutils.scm (pwclient): New variable.

> +         (add-after 'unpack 'patch
> +           (lambda _
> +             (substitute* "test-requirements.txt"
> +               (("pytest>=3.0,<5.0;")
> +                "pytest>=3.0,<6.0;"))
> +             #t))

I would call the phase 'patch-requirements' or similar and add a brief
comment explaining it.

> +    (native-inputs
> +     `(("npython-pbr" ,python-pbr)

Typo here --^

Message #11 received at 44251 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: 44251 <at> debbugs.gnu.org
Subject: [PATCH v2] gnu: Add pwclient.
Date: Wed, 28 Oct 2020 13:29:37 +0000

* gnu/packages/patchutils.scm (pwclient): New variable.
---
 gnu/packages/patchutils.scm | 54 +++++++++++++++++++++++++++++++++++++
 1 file changed, 54 insertions(+)

diff --git a/gnu/packages/patchutils.scm b/gnu/packages/patchutils.scm
index 12dd472c68..da0f13a01e 100644
--- a/gnu/packages/patchutils.scm
+++ b/gnu/packages/patchutils.scm
@@ -468,3 +468,57 @@ patches, and displays the patches along with comments and state information.
 Users can login allowing them to change the state of patches.")
     (home-page "http://jk.ozlabs.org/projects/patchwork/")
     (license gpl2+)))
+
+(define-public pwclient
+  (package
+    (name "pwclient")
+    (version "1.3.0")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://github.com/getpatchwork/pwclient")
+                    (commit version)))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "1xckwvcqklzpyh3xs4k2zm40ifp0q5fdkj2vmgb8vhfvl1ivs6jv"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'patch-requirements
+           (lambda _
+             (substitute* "test-requirements.txt"
+               ;; The pytest requirement is unnecessarily strict
+               (("pytest>=3.0,<5.0;")
+                "pytest>=3.0,<6.0;"))
+             #t))
+         (add-before 'build 'set-PBR_VERSION
+           (lambda _
+             (setenv "PBR_VERSION"
+                     ,version)
+             #t))
+         (replace 'check
+           (lambda* (#:key tests? #:allow-other-keys)
+             (when tests?
+               (invoke "pytest"))
+             #t))
+         (add-after 'install 'install-man-page
+           (lambda* (#:key outputs #:allow-other-keys)
+             (install-file "man/pwclient.1"
+                           (string-append
+                            (assoc-ref outputs "out")
+                            "/share/man/man1"))
+             #t)))))
+    (native-inputs
+     `(("python-pbr" ,python-pbr)
+       ("python-pytest" ,python-pytest)
+       ("python-pytest-cov" ,python-pytest-cov)
+       ("python-mock" ,python-mock)))
+    (home-page
+     "https://github.com/getpatchwork/pwclient")
+    (synopsis "Command-line client for the Patchwork patch tracking tool")
+    (description
+     "pwclient is a VCS-agnostic tool for interacting with Patchwork, the
+web-based patch tracking system.")
+    (license gpl2+)))
-- 
2.28.0

Message #14 received at 44251 <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Leo Famulari <leo <at> famulari.name>
Cc: 44251 <at> debbugs.gnu.org
Subject: Re: [bug#44251] [PATCH] gnu: Add pwclient.
Date: Wed, 28 Oct 2020 13:30:46 +0000

[Message part 1 (text/plain, inline)]

Leo Famulari <leo <at> famulari.name> writes:

> On Tue, Oct 27, 2020 at 09:46:02AM +0000, Christopher Baines wrote:
>> * gnu/packages/patchutils.scm (pwclient): New variable.
>
>> +         (add-after 'unpack 'patch
>> +           (lambda _
>> +             (substitute* "test-requirements.txt"
>> +               (("pytest>=3.0,<5.0;")
>> +                "pytest>=3.0,<6.0;"))
>> +             #t))
>
> I would call the phase 'patch-requirements' or similar and add a brief
> comment explaining it.

I've renamed the phase now, and added a comment.

>> +    (native-inputs
>> +     `(("npython-pbr" ,python-pbr)
>
> Typo here --^

Indeed, I've removed the rogue n.

I've sent an updated patch, which fixes a few more things as well.

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 44251 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Christopher Baines <mail <at> cbaines.net>
Cc: 44251 <at> debbugs.gnu.org
Subject: Re: [bug#44251] [PATCH] gnu: Add pwclient.
Date: Wed, 28 Oct 2020 11:36:19 -0400

[Message part 1 (text/plain, inline)]

On Wed, Oct 28, 2020 at 01:30:46PM +0000, Christopher Baines wrote:
> I've sent an updated patch, which fixes a few more things as well.

Alright, then you can push as you see fit :)

[signature.asc (application/pgp-signature, inline)]

Message #22 received at 44251-done <at> debbugs.gnu.org (full text, mbox):

From: Christopher Baines <mail <at> cbaines.net>
To: Leo Famulari <leo <at> famulari.name>
Cc: 44251-done <at> debbugs.gnu.org
Subject: Re: [bug#44251] [PATCH] gnu: Add pwclient.
Date: Wed, 28 Oct 2020 16:53:47 +0000

[Message part 1 (text/plain, inline)]

Leo Famulari <leo <at> famulari.name> writes:

> On Wed, Oct 28, 2020 at 01:30:46PM +0000, Christopher Baines wrote:
>> I've sent an updated patch, which fixes a few more things as well.
>
> Alright, then you can push as you see fit :)

Thanks for taking a look! I've pushed this to master as
f6839fed5f2052fd257b4af73effb10dcd9bf35b now.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.