GNU bug report logs - #44247
EWW: backtab is not defined in text and textarea keymaps

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44247 in the body.
You can then email your comments to 44247 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Graner <nicolas <at> graner.name>
To: bug-gnu-emacs <at> gnu.org
Subject: EWW: backtab is not defined in text and textarea keymaps
Date: Mon, 26 Oct 2020 23:46:55 +0100

In the main eww-mode-map, the function shr-previous-link is bound to
both \M-\t and backtab (aka shift+tab). However, in the more specific
eww-text-map and eww-textarea-map, that same function is only bound to
\M-\t. This makes the use of backtab inconsistent.

Patch to fix this in emacs 28:

diff --git a/lisp/net/eww.el b/lisp/net/eww.el
index 53835bb544..ebc75e0e8a 100644
--- a/lisp/net/eww.el
+++ b/lisp/net/eww.el
@@ -1190,6 +1190,7 @@ eww-text-map
     (define-key map [(control e)] 'eww-end-of-text)
     (define-key map [?\t] 'shr-next-link)
     (define-key map [?\M-\t] 'shr-previous-link)
+    (define-key map [backtab] 'shr-previous-link)
     map))
 
 (defvar eww-textarea-map
@@ -1199,6 +1200,7 @@ eww-textarea-map
     (define-key map [(control c) (control c)] 'eww-submit)
     (define-key map [?\t] 'shr-next-link)
     (define-key map [?\M-\t] 'shr-previous-link)
+    (define-key map [backtab] 'shr-previous-link)
     map))
 
 (defvar eww-select-map


--
Nicolas

Message #8 received at 44247 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Nicolas Graner <nicolas <at> graner.name>
Cc: 44247 <at> debbugs.gnu.org
Subject: Re: bug#44247: EWW: backtab is not defined in text and textarea
 keymaps
Date: Tue, 27 Oct 2020 08:15:37 +0100

Nicolas Graner <nicolas <at> graner.name> writes:

> In the main eww-mode-map, the function shr-previous-link is bound to
> both \M-\t and backtab (aka shift+tab). However, in the more specific
> eww-text-map and eww-textarea-map, that same function is only bound to
> \M-\t. This makes the use of backtab inconsistent.
>
> Patch to fix this in emacs 28:

Thanks; applied to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.