GNU bug report logs - #44239
[PATCH] Python double-digit version detection broken

Previous Next

Package: automake;

Reported by: Patrik Novotny <panovotn <at> redhat.com>

Date: Mon, 26 Oct 2020 15:29:02 UTC

Severity: normal

Tags: patch

Done: Karl Berry <karl <at> freefriends.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Patrik Novotny <panovotn <at> redhat.com>
Subject: bug#44239: closed (Re: bug#44239: [PATCH] Python double-digit
 version detection broken)
Date: Tue, 27 Oct 2020 21:37:02 +0000
[Message part 1 (text/plain, inline)]
Your bug report

#44239: [PATCH] Python double-digit version detection broken

which was filed against the automake package, has been closed.

The explanation is attached below, along with your original report.
If you require more details, please reply to 44239 <at> debbugs.gnu.org.

-- 
44239: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=44239
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems
[Message part 2 (message/rfc822, inline)]
From: Karl Berry <karl <at> freefriends.org>
To: miro <at> hroncok.cz
Cc: 44239 <at> debbugs.gnu.org, panovotn <at> redhat.com
Subject: Re: bug#44239: [PATCH] Python double-digit version detection broken
Date: Tue, 27 Oct 2020 15:36:50 -0600
    The patch is https://src.fedoraproject.org/fork/churchyard/rpms/automake/raw/f8af40fe1fa92a3ea0a1520a9d5f0797d0019f0f/f/automake-1.16.2-python-version-multiple-digits.patch

Thanks, I pushed it with some minor additional documentation updates.

    python3.10 -c 'import sys; print("%u.%u" % sys.version_info[:2])'

I also changed the invocation in python.m4 to be this (what you put in
t/python-vars.sh), instead of the sys.stdout.write('%d.%d') which you
had (following what was there before). Seemed better to have the two
invocations be exactly the same. At least, I couldn't discern any reason
why not, or any difference in the result, barring version numbers too
big to fit in signed integers :). --thanks, karl.

[Message part 3 (message/rfc822, inline)]
From: Patrik Novotny <panovotn <at> redhat.com>
To: bug-automake <at> gnu.org
Subject: [PATCH] Python double-digit version detection broken
Date: Mon, 26 Oct 2020 14:00:43 +0100
[Message part 4 (text/plain, inline)]
Hi,

we have encountered an issue[1] with the python double-digit version
detection.

The used `sys.version[:3]` used in automake strips digits from the python
version. For example '3.10' is detected as '3.1'.

To fix this issue, `sys.version[:3]` is changed to `sys.version_info[:2]`
in the attached patch.

Version: 1.16.2
How to reproduce: Use automake with python 3.10 (or any double-digit
version)

More details can be found in the bugzilla below if needed.

[1] https://bugzilla.redhat.com/show_bug.cgi?id=1889732

--
Patrik Novotný
Associate Software Engineer
Red Hat
panovotn <at> redhat.com
[Message part 5 (text/html, inline)]
[0001-Fix-double-digit-python-version-detection.patch (application/x-patch, attachment)]

This bug report was last modified 4 years and 209 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.