GNU bug report logs - #4423
[PATCH] lisp/vc-dispatcher.el: at the end of vc-log-operation run vc-start-logentry-hook

Previous Next

Full log

View this message in rfc822 format

From: help-debbugs <at> gnu.org (GNU bug Tracking System)
To: Glenn Morris <rgm <at> gnu.org>
Cc: tracker <at> debbugs.gnu.org
Subject: bug#4423: closed ([PATCH] lisp/vc-dispatcher.el: at the end of
 vc-log-operation run vc-start-logentry-hook)
Date: Tue, 12 Jul 2011 07:44:01 +0000

[Message part 1 (text/plain, inline)]

Your message dated Tue, 12 Jul 2011 03:43:45 -0400
with message-id <x9y6046j0u.fsf <at> fencepost.gnu.org>
and subject line Re: bug#4423: [PATCH] lisp/vc-dispatcher.el: at the end of vc-log-operation run vc-start-logentry-hook
has caused the GNU bug report #4423,
regarding [PATCH] lisp/vc-dispatcher.el: at the end of vc-log-operation run vc-start-logentry-hook
to be marked as done.

(If you believe you have received this mail in error, please contact
help-debbugs <at> gnu.org.)


-- 
4423: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=4423
GNU Bug Tracking System
Contact help-debbugs <at> gnu.org with problems

[Message part 2 (message/rfc822, inline)]

From: Jari Aalto <jari.aalto <at> cante.net>
To: Emacs bug BTS <submit <at> debbugs.gnu.org>
Subject: [PATCH] lisp/vc-dispatcher.el: at the end of vc-log-operation run vc-start-logentry-hook
Date: Sun, 13 Sep 2009 17:01:28 +0300

[Message part 3 (text/plain, inline)]

This new hook allows users to set up the initial contents of *VC-Log* buffer.

2009-09-13  Jari Aalto  <jari.aalto <at> cante.net>

    * vc-dispatcher.el (vc-start-logentry-hook): New user variable.
    (vc-start-logentry): run `vc-start-logentry-hook' at end.

[0001-lisp-vc-dispatcher.el-at-end-of-vc-log-operation-run.patch (text/x-diff, inline)]

From 623988d6819a83f897c218db8a637fc505afd1b6 Mon Sep 17 00:00:00 2001
From: Jari Aalto <jari.aalto <at> cante.net>
Date: Sun, 13 Sep 2009 16:56:51 +0300
Subject: [PATCH] lisp/vc-dispatcher.el: at end of vc-log-operation run vc-start-logentry-hook

Signed-off-by: Jari Aalto <jari.aalto <at> cante.net>
---
 lisp/vc-dispatcher.el |   14 ++++++++++++--
 1 files changed, 12 insertions(+), 2 deletions(-)

diff --git a/lisp/vc-dispatcher.el b/lisp/vc-dispatcher.el
index a209e13..4282e52 100644
--- a/lisp/vc-dispatcher.el
+++ b/lisp/vc-dispatcher.el
@@ -136,6 +136,13 @@ preserve the setting."
   :type 'boolean
   :group 'vc)
 
+(defcustom vc-start-logentry-hook nil
+  "Normal hook (list of functions) run after `vc-start-logentry'.
+See `run-hooks'."
+  :type 'hook
+  :group 'vc
+  :version "23.2")
+
 ;; Variables the user doesn't need to know about.
 
 (defvar vc-log-operation nil)
@@ -541,7 +548,9 @@ INITIAL-CONTENTS is nil, do action immediately as if the user had
 entered COMMENT.  If COMMENT is t, also do action immediately with an
 empty comment.  Remember the file's buffer in `vc-parent-buffer'
 \(current one if no file).  AFTER-HOOK specifies the local value
-for `vc-log-after-operation-hook'."
+for `vc-log-after-operation-hook'.
+
+At the end, runs the normal hook `vc-start-logentry-hook'."
   (let ((parent
          (if (vc-dispatcher-browsing)
              ;; If we are called from a directory browser, the parent buffer is
@@ -567,7 +576,8 @@ for `vc-log-after-operation-hook'."
       (when (stringp comment) (insert comment)))
     (if (or (not comment) initial-contents)
 	(message "%s  Type C-c C-c when done" msg)
-      (vc-finish-logentry (eq comment t)))))
+      (vc-finish-logentry (eq comment t)))
+    (run-hooks 'vc-start-logentry-hook)))
 
 (declare-function vc-dir-move-to-goal-column "vc-dir" ())
 
-- 
1.6.3.3

[Message part 5 (message/rfc822, inline)]

From: Glenn Morris <rgm <at> gnu.org>
To: 4423-done <at> debbugs.gnu.org
Subject: Re: bug#4423: [PATCH] lisp/vc-dispatcher.el: at the end of
	vc-log-operation run vc-start-logentry-hook
Date: Tue, 12 Jul 2011 03:43:45 -0400

Stefan Monnier wrote:

>> This new hook allows users to set up the initial contents of
>> *VC-Log* buffer.
[...]
> Why not use log-edit-hook or log-edit-mode-hook?

Indeed those hooks seem to make this proposed addition unecessary.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.