From unknown Tue Aug 19 23:13:00 2025 X-Loop: owner@emacsbugs.donarmstrong.com Subject: bug#4422: diff-switches is a bad idea Reply-To: Reuben Thomas , 4422@debbugs.gnu.org Resent-From: Reuben Thomas Resent-To: bug-submit-list@lists.donarmstrong.com Resent-CC: Emacs Bugs 2Resent-Date: Sun, 13 Sep 2009 12:25:05 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-Emacs-PR-Message: report 4422 X-Emacs-PR-Package: emacs X-Emacs-PR-Keywords: Received: via spool by submit@emacsbugs.donarmstrong.com id=B.12528442976761 (code B ref -1); Sun, 13 Sep 2009 12:25:05 +0000 Received: (at submit) by emacsbugs.donarmstrong.com; 13 Sep 2009 12:18:17 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=none autolearn=ham version=3.2.5-bugs.debian.org_2005_01_02 Received: from lists.gnu.org (lists.gnu.org [199.232.76.165]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n8DCIG01006758 for ; Sun, 13 Sep 2009 05:18:17 -0700 Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1Mmo23-0004Kk-Oa for bug-gnu-emacs@gnu.org; Sun, 13 Sep 2009 08:18:15 -0400 Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1Mmo1x-0004CQ-Bw for bug-gnu-emacs@gnu.org; Sun, 13 Sep 2009 08:18:14 -0400 Received: from [199.232.76.173] (port=38234 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Mmo1x-0004C3-6F for bug-gnu-emacs@gnu.org; Sun, 13 Sep 2009 08:18:09 -0400 Received: from fencepost.gnu.org ([140.186.70.10]:40272) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1Mmo1x-0005UU-0V for bug-gnu-emacs@gnu.org; Sun, 13 Sep 2009 08:18:09 -0400 Received: from mail.gnu.org ([199.232.76.166]:46267 helo=mx10.gnu.org) by fencepost.gnu.org with esmtp (Exim 4.67) (envelope-from ) id 1Mmo1w-0002Ua-Pd for bug-emacs@gnu.org; Sun, 13 Sep 2009 08:18:08 -0400 Received: from Debian-exim by monty-python.gnu.org with spam-scanned (Exim 4.60) (envelope-from ) id 1Mmo1v-0005UG-AL for bug-emacs@gnu.org; Sun, 13 Sep 2009 08:18:08 -0400 Received: from exprod7og124.obsmtp.com ([64.18.2.26]:35194) by monty-python.gnu.org with smtp (Exim 4.60) (envelope-from ) id 1Mmo1u-0005Tu-UF for bug-emacs@gnu.org; Sun, 13 Sep 2009 08:18:07 -0400 Received: from source ([209.85.220.209]) by exprod7ob124.postini.com ([64.18.6.12]) with SMTP ID DSNKSqzi+yek3lra3Vrc0iMrW+lJPz8PuygP@postini.com; Sun, 13 Sep 2009 05:18:06 PDT Received: by mail-fx0-f209.google.com with SMTP id 5so984790fxm.3 for ; Sun, 13 Sep 2009 05:18:03 -0700 (PDT) MIME-Version: 1.0 Received: by 10.223.7.21 with SMTP id b21mr1784247fab.104.1252844283696; Sun, 13 Sep 2009 05:18:03 -0700 (PDT) Date: Sun, 13 Sep 2009 13:18:03 +0100 Message-ID: From: Reuben Thomas To: bug-emacs Content-Type: text/plain; charset=ISO-8859-1 X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6, seldom 2.4 (older, 4) I'm using Emacs 23, and I have just been puzzling over why vc-diff stopped working in CVS checkouts. I eventually traced it to diff-switches: I have mine set to "-Nur", quite reasonably, I think, but of course "-r" means something quite different to CVS, and I ended up with a hard-to-understand error message about tags. I suggest not using diff-switches (this would also remove some special-case code, as no other vc command respects a non-vc option like this.) Yes, some users will have to configure the same thing in two places, but others will be saved the confusion I had. For the switches to be commoned up sensibly, a more structured approach to setting them is needed that takes semantics into account, and that way lies madness. -- http://rrt.sc3d.org Imagine someone who has only ever heard music once From lekktu@gmail.com Thu Oct 22 02:35:31 2009 Received: (at control) by emacsbugs.donarmstrong.com; 22 Oct 2009 09:35:32 +0000 X-Spam-Checker-Version: SpamAssassin 3.2.5-bugs.debian.org_2005_01_02 (2008-06-10) on rzlab.ucr.edu X-Spam-Level: X-Spam-Bayes: score:0.5 Bayes not run. spammytokens:Tokens not available. hammytokens:Tokens not available. X-Spam-Status: No, score=0.0 required=4.0 tests=AWL,MISSING_SUBJECT, MURPHY_DRUGS_REL8,NOSUBJECT,VALID_BTS_CONTROL autolearn=no version=3.2.5-bugs.debian.org_2005_01_02 Received: from mail-fx0-f213.google.com (mail-fx0-f213.google.com [209.85.220.213]) by rzlab.ucr.edu (8.14.3/8.14.3/Debian-5) with ESMTP id n9M9ZTNW004084 for ; Thu, 22 Oct 2009 02:35:31 -0700 Received: by fxm9 with SMTP id 9so9696363fxm.1 for ; Thu, 22 Oct 2009 02:35:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:mime-version:received:from:date:message-id :subject:to:content-type; bh=8EmqKmTQZFxRHmBqMf0mAHPBq3MFliknc0lztWoJq6Y=; b=HxQYupT4FFltZz1ItMJj0h3XTFYNK5e7ryT0Cek2T3YESYQLNQM8G9V9i2CKiMAEbc EvYuLj8f7w1qApk14qvzihjcYCGQUOU+1DBevO5UhGKLQhzQ6+vBiuihHNGFYaXeeEYe kJYg0CmwEGM5xp9e/Qz4pt4br7Ml4TcpNJkWo= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=mime-version:from:date:message-id:subject:to:content-type; b=Y5ybjjcxlLdLgAFAm7oQwPF4q6enZ/vhDgoBesbKLPsYfKZBy2gNxuVUArd1lZsA9C Mqc9bcUQhekOxrkhuBrM/oRLNjZDm8m0DPtCnEMhvvK6rKfs9H9j6QMJR6VObUwlfUeo 7VB35jQ8OYFrwvpcsbgPdQA8bmjmcb1XFRU14= MIME-Version: 1.0 Received: by 10.239.145.8 with SMTP id q8mr761204hba.122.1256204124158; Thu, 22 Oct 2009 02:35:24 -0700 (PDT) From: Juanma Barranquero Date: Thu, 22 Oct 2009 11:35:04 +0200 Message-ID: Subject: To: control@debbugs.gnu.org Content-Type: text/plain; charset=UTF-8 reassign 4326 emacs,ns merge 4261 4434 merge 1589 3359 4207 merge 3829 4077 tags 4781 + patch tags 4747 + patch tags 4579 + patch tags 4471 + patch tags 4434 + patch tags 4234 + patch tags 4221 + patch tags 4147 + patch tags 4144 + patch tags 4139 + patch tags 4023 + patch tags 4736 + moreinfo unreproducible tags 4547 + notabug tags 4451 + notabug tags 4448 + moreinfo tags 4427 + moreinfo tags 4373 + notabug tags 4360 + notabug tags 4271 + moreinfo tags 4236 + moreinfo tags 4143 + moreinfo unreproducible tags 4120 + moreinfo unreproducible tags 4070 + moreinfo unreproducible severity 4422 wishlist severity 4396 minor severity 4394 minor severity 4341 wishlist severity 4300 minor severity 4263 minor severity 4178 minor severity 4172 wishlist severity 4110 wishlist severity 4056 wishlist close 4772 close 4700 close 4599 close 4515 close 4463 close 4445 close 4395 close 4334 close 4289 close 4219 quit From unknown Tue Aug 19 23:13:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#4422: diff-switches is a bad idea Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Oct 2019 13:19:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 4422 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: Reuben Thomas Cc: 4422@debbugs.gnu.org Received: via spool by 4422-submit@debbugs.gnu.org id=B4422.156993591627542 (code B ref 4422); Tue, 01 Oct 2019 13:19:02 +0000 Received: (at 4422) by debbugs.gnu.org; 1 Oct 2019 13:18:36 +0000 Received: from localhost ([127.0.0.1]:32851 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFI31-0007AA-UG for submit@debbugs.gnu.org; Tue, 01 Oct 2019 09:18:36 -0400 Received: from quimby.gnus.org ([80.91.231.51]:50456) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFI2z-00079y-Dk for 4422@debbugs.gnu.org; Tue, 01 Oct 2019 09:18:33 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iFI2v-0003AG-7c; Tue, 01 Oct 2019 15:18:31 +0200 From: Lars Ingebrigtsen References: Date: Tue, 01 Oct 2019 15:18:29 +0200 In-Reply-To: (Reuben Thomas's message of "Sun, 13 Sep 2009 13:18:03 +0100") Message-ID: <87d0fg7gey.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Reuben Thomas writes: > I'm using Emacs 23, and I have just been puzzling over why vc-diff > stopped working in CVS checkouts. I eventually traced it to > diff-switches: I have mine set to "-Nur", quite reasonably, I think [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Reuben Thomas writes: > I'm using Emacs 23, and I have just been puzzling over why vc-diff > stopped working in CVS checkouts. I eventually traced it to > diff-switches: I have mine set to "-Nur", quite reasonably, I think, > but of course "-r" means something quite different to CVS, and I ended > up with a hard-to-understand error message about tags. > > I suggest not using diff-switches (this would also remove some > special-case code, as no other vc command respects a non-vc option > like this.) Yes, some users will have to configure the same thing in > two places, but others will be saved the confusion I had. For the > switches to be commoned up sensibly, a more structured approach to > setting them is needed that takes semantics into account, and that way > lies madness. (I'm going through old bug reports that unfortunately didn't get any response at the time.) I'm not extremely familiar with the vc code, but looking at it in Emacs 27, at least, the switches for diff in CVS comes from vc-cvs-diff-switches, if I read the `vc-switches' function correctly. So has this problem gone away in the years since this was reported? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 01 09:18:39 2019 Received: (at control) by debbugs.gnu.org; 1 Oct 2019 13:18:39 +0000 Received: from localhost ([127.0.0.1]:32854 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFI35-0007AS-7H for submit@debbugs.gnu.org; Tue, 01 Oct 2019 09:18:39 -0400 Received: from quimby.gnus.org ([80.91.231.51]:50470) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFI34-0007AL-9i for control@debbugs.gnu.org; Tue, 01 Oct 2019 09:18:38 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iFI31-0003AN-Lo for control@debbugs.gnu.org; Tue, 01 Oct 2019 15:18:37 +0200 Date: Tue, 01 Oct 2019 15:18:35 +0200 Message-Id: <87blv07ges.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #4422 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 4422 + moreinfo quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 4422 + moreinfo quit From unknown Tue Aug 19 23:13:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#4422: diff-switches is a bad idea Resent-From: Reuben Thomas Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Oct 2019 13:30:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 4422 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo To: Lars Ingebrigtsen Cc: 4422@debbugs.gnu.org Received: via spool by 4422-submit@debbugs.gnu.org id=B4422.156993659028592 (code B ref 4422); Tue, 01 Oct 2019 13:30:02 +0000 Received: (at 4422) by debbugs.gnu.org; 1 Oct 2019 13:29:50 +0000 Received: from localhost ([127.0.0.1]:32868 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFIDt-0007R3-Sd for submit@debbugs.gnu.org; Tue, 01 Oct 2019 09:29:50 -0400 Received: from mail-oi1-f170.google.com ([209.85.167.170]:34018) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFIDp-0007Ql-SG for 4422@debbugs.gnu.org; Tue, 01 Oct 2019 09:29:46 -0400 Received: by mail-oi1-f170.google.com with SMTP id 83so14413900oii.1 for <4422@debbugs.gnu.org>; Tue, 01 Oct 2019 06:29:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sc3d.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=I5CGQ5mP95dMbtOd87jVW1yyE7dRZEayblHAk3oMZjc=; b=N1EEWIUdWJrCMgKBLUXpQFxM1jBl5I47MLzy7aVJOiYauuvW04CqytIBAMxBJ5OIYM I4H4shIbs73caV+TT37bt/evgNnC/nzoAjo9VC7Ndu71Ihq3guWEqH5Bb2nZ/2huqwM6 zfRyXBkTOyEjNaoem4kF27KPphJrqIwHbbMoM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=I5CGQ5mP95dMbtOd87jVW1yyE7dRZEayblHAk3oMZjc=; b=UVPb/9Pe7e8P6uj8qlI8QBQ6E4kRdxP/ThkFQLW7sOtS0SBxkRVfXkz3IIHF9atW2g Q75A17RngpAd2YLS06BIncgbaIjkxeuVE3Ul2e3M4Um8cbJBNlk9wi+oZWd2zoaLBOn/ /J85nHO8qnSWAryRxGdxKEfzJZ2UUTUMuaDSkUlMdoVp4eOWd2QA7i74GiaQiDxcRQ2n 7o2VFh1tV9hb/WpgMGVGRXX4+kx9kyI9NvnEHf0aGQKtKAH2AXpvE4xXoWFbLGcH4bGs 4vXY4/Sgmom+AvIbPB+0hMBRGK/rQBxJVYaMQsJ8uNSfZRIRHnXXDKM+dczhXDjS3KqB g8rQ== X-Gm-Message-State: APjAAAV/FoONn/CdUoHBbm4+tH8F6OEtLEAcN9S2n9qAhnwjBIJ3wEHY XJ2DiaB3jL4eq/vk5D7MokHlmqQ+ppjdHG/fJAsSwg== X-Google-Smtp-Source: APXvYqwUgJZtWlkM0Vg0EdaxFoMNlF4Js+8zbudgdguzYb5jc6iSjmQf6gzJle/DYlTcJ83/Xqn9TLD2leXQAx7nlxM= X-Received: by 2002:aca:d408:: with SMTP id l8mr3732718oig.113.1569936580087; Tue, 01 Oct 2019 06:29:40 -0700 (PDT) MIME-Version: 1.0 References: <87d0fg7gey.fsf@gnus.org> In-Reply-To: <87d0fg7gey.fsf@gnus.org> From: Reuben Thomas Date: Tue, 1 Oct 2019 14:29:28 +0100 Message-ID: Content-Type: multipart/alternative; boundary="0000000000002d549b0593d958bb" X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --0000000000002d549b0593d958bb Content-Type: text/plain; charset="UTF-8" On Tue, 1 Oct 2019 at 14:18, Lars Ingebrigtsen wrote: > > I'm not extremely familiar with the vc code, but looking at it in Emacs > 27, at least, the switches for diff in CVS comes from > vc-cvs-diff-switches, if I read the `vc-switches' function correctly. > > So has this problem gone away in the years since this was reported? > Not as far as I can tell. It is still necessary for me to set `vc-diff-switches` explicitly, e.g. to `t`, meaning "no switches". From the docstring for vc-switches: In decreasing order of preference, return the value of: vc-BACKEND-OP-switches (e.g. `vc-cvs-diff-switches'); vc-OP-switches (e.g. `vc-diff-switches'); or, in the case of diff only, `diff-switches'. In other words, `diff-switches` is still used by vc.el, and I still think that's a bad idea. -- https://rrt.sc3d.org --0000000000002d549b0593d958bb Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable
On Tue, 1 Oct 2019 at 14:18, Lars Ingebrigtsen <larsi@gnus.org> wrote:

I'm not extremely familiar with the vc code, but looking at it in Emacs=
27, at least, the switches for diff in CVS comes from
vc-cvs-diff-switches, if I read the `vc-switches' function correctly.
So has this problem gone away in the years since this was reported?

Not as far as I can tell. I= t is still necessary for me to set `vc-diff-switches` explicitly, e.g. to `= t`, meaning "no switches". From the docstring for vc-switches:

In decreasing order of p= reference, return the value of:
vc-BACKEND-OP-switches (e.g. `vc-cvs-dif= f-switches');
vc-OP-switches (e.g. `vc-diff-switches'); or, in t= he case of
diff only, `diff-switches'.
=

In other words, `diff-switches= ` is still used by vc.el, and I still think that's a bad idea.

--
--0000000000002d549b0593d958bb-- From unknown Tue Aug 19 23:13:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#4422: diff-switches is a bad idea Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Tue, 01 Oct 2019 13:43:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 4422 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo To: Lars Ingebrigtsen Cc: 4422@debbugs.gnu.org, rrt@sc3d.org Received: via spool by 4422-submit@debbugs.gnu.org id=B4422.15699373425281 (code B ref 4422); Tue, 01 Oct 2019 13:43:02 +0000 Received: (at 4422) by debbugs.gnu.org; 1 Oct 2019 13:42:22 +0000 Received: from localhost ([127.0.0.1]:32904 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFIQ2-0001N7-4L for submit@debbugs.gnu.org; Tue, 01 Oct 2019 09:42:22 -0400 Received: from eggs.gnu.org ([209.51.188.92]:50216) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFIQ0-0001Mt-BT for 4422@debbugs.gnu.org; Tue, 01 Oct 2019 09:42:20 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:33259) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iFIPu-0006Mt-W5; Tue, 01 Oct 2019 09:42:15 -0400 Received: from [176.228.60.248] (port=4338 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iFIPu-0003Fp-8d; Tue, 01 Oct 2019 09:42:14 -0400 Date: Tue, 01 Oct 2019 16:42:14 +0300 Message-Id: <83h84sa8g9.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87d0fg7gey.fsf@gnus.org> (message from Lars Ingebrigtsen on Tue, 01 Oct 2019 15:18:29 +0200) References: <87d0fg7gey.fsf@gnus.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Date: Tue, 01 Oct 2019 15:18:29 +0200 > Cc: 4422@debbugs.gnu.org > > Reuben Thomas writes: > > > I'm using Emacs 23, and I have just been puzzling over why vc-diff > > stopped working in CVS checkouts. I eventually traced it to > > diff-switches: I have mine set to "-Nur", quite reasonably, I think, > > but of course "-r" means something quite different to CVS, and I ended > > up with a hard-to-understand error message about tags. > > > > I suggest not using diff-switches (this would also remove some > > special-case code, as no other vc command respects a non-vc option > > like this.) Yes, some users will have to configure the same thing in > > two places, but others will be saved the confusion I had. For the > > switches to be commoned up sensibly, a more structured approach to > > setting them is needed that takes semantics into account, and that way > > lies madness. > > (I'm going through old bug reports that unfortunately didn't get any > response at the time.) > > I'm not extremely familiar with the vc code, but looking at it in Emacs > 27, at least, the switches for diff in CVS comes from > vc-cvs-diff-switches, if I read the `vc-switches' function correctly. It uses vc-cvs-diff-switches, but if that's nil (the default), it will try to use vc-diff-switches (which is also nil by default) and diff-switches, using the first non-nil of these. I think the current situation is reasonable, since to resolve it the user could customize vc-diff-switches or vc-cvs-diff-switches to t to avoid this problem. From unknown Tue Aug 19 23:13:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#4422: diff-switches is a bad idea Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Oct 2019 11:48:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 4422 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo To: Eli Zaretskii Cc: 4422@debbugs.gnu.org, rrt@sc3d.org Received: via spool by 4422-submit@debbugs.gnu.org id=B4422.157001683727679 (code B ref 4422); Wed, 02 Oct 2019 11:48:02 +0000 Received: (at 4422) by debbugs.gnu.org; 2 Oct 2019 11:47:17 +0000 Received: from localhost ([127.0.0.1]:35601 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFd6C-0007C5-JU for submit@debbugs.gnu.org; Wed, 02 Oct 2019 07:47:16 -0400 Received: from quimby.gnus.org ([80.91.231.51]:47806) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFd6B-0007B4-MG for 4422@debbugs.gnu.org; Wed, 02 Oct 2019 07:47:16 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iFd68-0000jf-DJ; Wed, 02 Oct 2019 13:47:14 +0200 From: Lars Ingebrigtsen References: <87d0fg7gey.fsf@gnus.org> <83h84sa8g9.fsf@gnu.org> Date: Wed, 02 Oct 2019 13:47:12 +0200 In-Reply-To: <83h84sa8g9.fsf@gnu.org> (Eli Zaretskii's message of "Tue, 01 Oct 2019 16:42:14 +0300") Message-ID: <87d0ffv073.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: > I think the current situation is reasonable, since to resolve it the > user could customize vc-diff-switches or vc-cvs-diff-switches to t to > avoid this problem. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: > I think the current situation is reasonable, since to resolve it the > user could customize vc-diff-switches or vc-cvs-diff-switches to t to > avoid this problem. Perhaps we should mention this in the diff-switches doc string? That'd make it more obvious for the user how to resolve the problem. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Tue Aug 19 23:13:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#4422: diff-switches is a bad idea Resent-From: Eli Zaretskii Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Wed, 02 Oct 2019 15:17:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 4422 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo To: Lars Ingebrigtsen Cc: 4422@debbugs.gnu.org, rrt@sc3d.org Received: via spool by 4422-submit@debbugs.gnu.org id=B4422.15700294211418 (code B ref 4422); Wed, 02 Oct 2019 15:17:02 +0000 Received: (at 4422) by debbugs.gnu.org; 2 Oct 2019 15:17:01 +0000 Received: from localhost ([127.0.0.1]:38170 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFgNA-0000Mo-TX for submit@debbugs.gnu.org; Wed, 02 Oct 2019 11:17:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:38670) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iFgN8-0000Ma-MX for 4422@debbugs.gnu.org; Wed, 02 Oct 2019 11:16:59 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:55723) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1iFgN2-0007T0-V0; Wed, 02 Oct 2019 11:16:53 -0400 Received: from [176.228.60.248] (port=2274 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1iFgN0-00086K-Um; Wed, 02 Oct 2019 11:16:52 -0400 Date: Wed, 02 Oct 2019 18:16:35 +0300 Message-Id: <83eezv89f0.fsf@gnu.org> From: Eli Zaretskii In-reply-to: <87d0ffv073.fsf@gnus.org> (message from Lars Ingebrigtsen on Wed, 02 Oct 2019 13:47:12 +0200) References: <87d0fg7gey.fsf@gnus.org> <83h84sa8g9.fsf@gnu.org> <87d0ffv073.fsf@gnus.org> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > From: Lars Ingebrigtsen > Cc: rrt@sc3d.org, 4422@debbugs.gnu.org > Date: Wed, 02 Oct 2019 13:47:12 +0200 > > Eli Zaretskii writes: > > > I think the current situation is reasonable, since to resolve it the > > user could customize vc-diff-switches or vc-cvs-diff-switches to t to > > avoid this problem. > > Perhaps we should mention this in the diff-switches doc string? That'd > make it more obvious for the user how to resolve the problem. Fine with me, thanks. From unknown Tue Aug 19 23:13:00 2025 X-Loop: help-debbugs@gnu.org Subject: bug#4422: diff-switches is a bad idea Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 03 Oct 2019 14:34:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 4422 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: moreinfo To: Eli Zaretskii Cc: 4422@debbugs.gnu.org, rrt@sc3d.org Received: via spool by 4422-submit@debbugs.gnu.org id=B4422.157011320823379 (code B ref 4422); Thu, 03 Oct 2019 14:34:02 +0000 Received: (at 4422) by debbugs.gnu.org; 3 Oct 2019 14:33:28 +0000 Received: from localhost ([127.0.0.1]:40724 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iG2AY-000650-Mj for submit@debbugs.gnu.org; Thu, 03 Oct 2019 10:33:28 -0400 Received: from quimby.gnus.org ([80.91.231.51]:48856) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iG2AW-00064s-Q4 for 4422@debbugs.gnu.org; Thu, 03 Oct 2019 10:33:25 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iG2AT-0008Ui-7V; Thu, 03 Oct 2019 16:33:23 +0200 From: Lars Ingebrigtsen References: <87d0fg7gey.fsf@gnus.org> <83h84sa8g9.fsf@gnu.org> <87d0ffv073.fsf@gnus.org> <83eezv89f0.fsf@gnu.org> Date: Thu, 03 Oct 2019 16:33:21 +0200 In-Reply-To: <83eezv89f0.fsf@gnu.org> (Eli Zaretskii's message of "Wed, 02 Oct 2019 18:16:35 +0300") Message-ID: <87h84pucem.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Eli Zaretskii writes: >> Perhaps we should mention this in the diff-switches doc string? That'd >> make it more obvious for the user how to resolve the problem. > > Fine with me, thanks. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Eli Zaretskii writes: >> Perhaps we should mention this in the diff-switches doc string? That'd >> make it more obvious for the user how to resolve the problem. > > Fine with me, thanks. OK; done. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Thu Oct 03 10:33:14 2019 Received: (at control) by debbugs.gnu.org; 3 Oct 2019 14:33:14 +0000 Received: from localhost ([127.0.0.1]:40721 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iG2AM-00064b-CM for submit@debbugs.gnu.org; Thu, 03 Oct 2019 10:33:14 -0400 Received: from quimby.gnus.org ([80.91.231.51]:48842) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1iG2AK-00064T-NZ for control@debbugs.gnu.org; Thu, 03 Oct 2019 10:33:13 -0400 Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=marnie) by quimby.gnus.org with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1iG2AH-0008UZ-Lr for control@debbugs.gnu.org; Thu, 03 Oct 2019 16:33:11 +0200 Date: Thu, 03 Oct 2019 16:33:09 +0200 Message-Id: <87lfu1ucey.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #4422 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 4422 fixed close 4422 27.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 4422 fixed close 4422 27.1 quit