From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 25 16:41:44 2020 Received: (at submit) by debbugs.gnu.org; 25 Oct 2020 20:41:44 +0000 Received: from localhost ([127.0.0.1]:37760 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWmpk-0006MU-9V for submit@debbugs.gnu.org; Sun, 25 Oct 2020 16:41:44 -0400 Received: from lists.gnu.org ([209.51.188.17]:55086) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWmpi-0006MM-84 for submit@debbugs.gnu.org; Sun, 25 Oct 2020 16:41:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46856) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kWmpi-0004Bu-0X for bug-gnu-emacs@gnu.org; Sun, 25 Oct 2020 16:41:42 -0400 Received: from mail-wr1-x42e.google.com ([2a00:1450:4864:20::42e]:37666) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kWmpf-0005kq-W3 for bug-gnu-emacs@gnu.org; Sun, 25 Oct 2020 16:41:41 -0400 Received: by mail-wr1-x42e.google.com with SMTP id h7so10226446wre.4 for ; Sun, 25 Oct 2020 13:41:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:to:subject:from:message-id:date:user-agent:mime-version :content-language:content-transfer-encoding; bh=ZQV2SKRBMiSgmk70WMVzfhH73n/ZsLqcS6I7xr/L1fk=; b=jbHEQNvjtyFbbnVsRvYn4/xzpLHIBjLBxMLe4L+q0MY/4/cK/+bn8AynABLgUBvVMG bbnAXRC980xyi1XyL4Rw+bPTkIpPEPK3QcXz6KqTkV2Ts2FetOz/DTorji6lmo/jDyr6 gPIFt+YKJzxeTZH1KEsR3ERiAS7PmQJrHCiZQ68oLv0fMuaL/ChQ1graI1m1tvmjp9b9 DzsyZfEkdsYrvZ8hGx0nrKZ8c5QTC7Myl3AqZ1Kfq+h11d6DgGTzq0+OR68yPAIG2Woq pUp5Vqbhgo+3ZQW/4GpxLmY37jw0w/436DUyYsBGKzEv/fU4x6CLP7z9c0sz6olihoND xF/w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:to:subject:from:message-id:date :user-agent:mime-version:content-language:content-transfer-encoding; bh=ZQV2SKRBMiSgmk70WMVzfhH73n/ZsLqcS6I7xr/L1fk=; b=LXxr392cqpFEHZJ4ml+Xlwj3U/VD8TLOjD+//XD0tDEcRcO3738qcK5WSknGqxdIWv M1Y3B7QTgbqSQ3MlZ5DaEvyWEuGaX7+0dTa5x3jCpyMYobPqeTIfcQCVx45H4/FhE8DT Tjl5p88ULpUS2u+vCsrftsu4yWZO5bAo3te3tYIamogZ0pcXYBpzxfamjj+iNlmeokLd nI1nVp2avapb+6BcdqvIQtCfuJMDBJOicYd1SPev/00waCKCneFdbQbSOpJJJCja2C8O dfSmsuziU3vZkzq+qncPeo+iqLsbKQkEMK7MRuUPB6Qaxcv6iTS41HXOMWMC19gT7gjk 9rQw== X-Gm-Message-State: AOAM531c9J0YqYnVfqP8WNtdMqUstZ0YlPh3cYZOWZ6voYoCN60g3cAt x+xG32yOZqdDfgWa1gKBREeqYZqySiah7Q== X-Google-Smtp-Source: ABdhPJx/IEPpoycrF/udeYrKzSc17g3kiG2NH8UVA0BRap6lOVHgQP8ZCMj2bHAycYsfltkllvOmLA== X-Received: by 2002:adf:eb04:: with SMTP id s4mr15083459wrn.81.1603658497363; Sun, 25 Oct 2020 13:41:37 -0700 (PDT) Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id 30sm19474325wrs.84.2020.10.25.13.41.36 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sun, 25 Oct 2020 13:41:36 -0700 (PDT) To: bug-gnu-emacs@gnu.org Subject: 28.0.50; css-mode: no completion in declaration with newline after From: Dmitry Gutov Message-ID: <79614d56-6ce5-5471-fcc8-f0dc30467826@yandex.ru> Date: Sun, 25 Oct 2020 22:41:35 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=2a00:1450:4864:20::42e; envelope-from=raaahh@gmail.com; helo=mail-wr1-x42e.google.com X-detected-operating-system: by eggs.gnu.org: No matching host in p0f cache. That's all we know. X-Spam_score_int: -14 X-Spam_score: -1.5 X-Spam_bar: - X-Spam_report: (-1.5 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FORGED_FROMDOMAIN=0.249, FREEMAIL_FROM=0.001, HEADER_FROM_DIFFERENT_DOMAINS=0.25, RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=no autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.9 (/) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.8 (-) X-Debbugs-CC: Simen Heggestøyl 1. Create new buffer (or switch to scratch), then M-x css-mode. 2. Replace the contents with the following: div { transform: rota 3. Move the point to the end of 'rota' and type C-M-i. 4. See no completions. If there is no newline after the colon, before the attribute value, C-M-i does perform completion. Originally reported in https://github.com/company-mode/company-mode/issues/1029 In GNU Emacs 28.0.50 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.20, cairo version 1.16.0) of 2020-10-11 built on potemkin Repository revision: c66165b5c08e12c5dcf494fea42e61df693b80b9 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12008000 System Description: Ubuntu 20.04.1 LTS From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 26 05:24:40 2020 Received: (at 44214) by debbugs.gnu.org; 26 Oct 2020 09:24:40 +0000 Received: from localhost ([127.0.0.1]:38439 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWyk3-0002HN-W0 for submit@debbugs.gnu.org; Mon, 26 Oct 2020 05:24:40 -0400 Received: from aibo.runbox.com ([91.220.196.211]:33654) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWyk0-0002HC-PK for 44214@debbugs.gnu.org; Mon, 26 Oct 2020 05:24:38 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=selector1; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From; bh=zzdPwPTSXm2K4C0SKHS+sO5gCdgM9FAlaP/qK/qAbzk=; b=hAbfrt0UGZ1zXYtpApfZ4CvJ2o uAp45TrPtXFcx45S5u4AKo2vc1H3PTvKrHg1aPaHcWUKKdBMtRaP3WdcFpFkx3TsswBKmEuvdu4v+ 881tAVsm4VhQNiWUF1a8e1IwL3EsSSxnQD5zQgBIZxt7tgSvzKhGufvSdY8ZSJVsjz9Fqjt5XLLGP eMIl+U72xtNA9cr2A4t/qhLxCqKFcnj7+uZuhb11XPfnQCTRRec2zgkpvaEH4bAW2IdWV0ZZT7Cuo /Kx2ljBTyXWjZEC1swF9VxrHJImZmUb3Gju6HfHX7zpc40rVr4WHNXwf0ZoBB08yTeXNK9281pFF7 jlT06zmg==; Received: from [10.9.9.72] (helo=submission01.runbox) by mailtransmit03.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1kWyjz-000569-8n; Mon, 26 Oct 2020 10:24:35 +0100 Received: by submission01.runbox with esmtpsa [Authenticated alias (963757)] (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) id 1kWyjv-0001vW-7A; Mon, 26 Oct 2020 10:24:31 +0100 From: =?utf-8?Q?Simen_Heggest=C3=B8yl?= To: Dmitry Gutov Subject: Re: bug#44214: 28.0.50; css-mode: no completion in declaration with newline after References: <79614d56-6ce5-5471-fcc8-f0dc30467826@yandex.ru> Date: Mon, 26 Oct 2020 10:24:30 +0100 In-Reply-To: <79614d56-6ce5-5471-fcc8-f0dc30467826@yandex.ru> (Dmitry Gutov's message of "Sun, 25 Oct 2020 22:41:35 +0200") Message-ID: <87blgp731t.fsf@simenheg@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 44214 Cc: 44214@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) This seems sufficient to me. Would you like to test it out? diff --git a/lisp/textmodes/css-mode.el b/lisp/textmodes/css-mode.el index 0d1eeed561..748a561bab 100644 --- a/lisp/textmodes/css-mode.el +++ b/lisp/textmodes/css-mode.el @@ -1357,7 +1357,9 @@ css--property-values (defun css--complete-property-value () "Complete property value at point." (let ((property (and (looking-back "\\([[:alnum:]-]+\\):[^/][^;]*" - (line-beginning-position) t) + (or (ppss-innermost-start (syntax-ppss)) + (point-min)) + t) (member (match-string-no-properties 1) css-property-ids)))) (when property From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 26 17:57:51 2020 Received: (at 44214) by debbugs.gnu.org; 26 Oct 2020 21:57:51 +0000 Received: from localhost ([127.0.0.1]:41796 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXAUx-0005Wd-FR for submit@debbugs.gnu.org; Mon, 26 Oct 2020 17:57:51 -0400 Received: from mail-wm1-f46.google.com ([209.85.128.46]:35372) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXAUv-0005WQ-Lq for 44214@debbugs.gnu.org; Mon, 26 Oct 2020 17:57:50 -0400 Received: by mail-wm1-f46.google.com with SMTP id h22so2921673wmb.0 for <44214@debbugs.gnu.org>; Mon, 26 Oct 2020 14:57:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=PLr6+oe1jJXOLTSYw+ylLQaymgRX6LN1mr3RDChxLeM=; b=ZfU8uBYTT14Ftsz0nzn82QSoGFR8F1BlfHRPMwIgXJSjMkUK7B4KLGKKmxQYkcxRzJ mDzc3VJIQe8jhxZOsr3FOM2c/LQ7uLD7VgtChxBDgpMqcEWJypQny+7ZpP5lETHOezJG KoJrfJfl9HOxHH5+s0DjTw/Vt0dQEbDROSGiwSkkXO6YApEGFGS32WcFtmUn0ixgypgY Pbm7mCn9/KJJF+9PfcfZ+A+jZJ/Kujcpwtf7kLg4tHTaY5ugeReDx+akKspqIVNHOG7H Ol9xIlgcQNCQDQSTUmmxL0/BW1+sdaaj3X7tLfcFJQQRPEW+4vjukxplh0rnmdLxf4jM wJfQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=PLr6+oe1jJXOLTSYw+ylLQaymgRX6LN1mr3RDChxLeM=; b=GaspfMtbXMgtD0JDbIODVhvDIIh0CaKsNoZBl76o4M2hFrOa0WqJY/NSMiLA1KP0tv DOKPj0y1okd5TyVtPEv6Ptb0ENBOEOx4+une5f8BRtbi3/kB0V9MDRXkI0hSEpTjNxhU 3grM92p+StgrRbNn36gJo5wbtFsufHEkexiYpOYxuyM86zBLZroKsY4XgzODZ6/2QdWm 1k0saelYfmcHrK6dSZToD8iLvAzMOQK3aKu/beaeCzSI96+n/5n5fE8MAkzHZVtL5kZL yg3TMg/jdMj8nmSZAWGxvtN9iVmvqL0q5IK7n2BpVw/v8zVXBLQuo3vx7lkasOh6PxRx YwSQ== X-Gm-Message-State: AOAM5327Y0yxnyQEhjAU28K2CMxqsoDGwvPdKTuS9fQ3FmOc9VP+y7Kt pYfiMk0pwr/F6CewkrFDJiRblMO4TH9a2Q== X-Google-Smtp-Source: ABdhPJypp1BEdePjGUeoaZjtFjNUuis8q56FK3KYPSRkXmjjggT0Fd0t5lci+9WsO/yGQ2IKY7VH1A== X-Received: by 2002:a1c:de8a:: with SMTP id v132mr17711785wmg.173.1603749463690; Mon, 26 Oct 2020 14:57:43 -0700 (PDT) Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id w11sm23709480wrs.26.2020.10.26.14.57.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 26 Oct 2020 14:57:43 -0700 (PDT) Subject: Re: bug#44214: 28.0.50; css-mode: no completion in declaration with newline after To: =?UTF-8?Q?Simen_Heggest=c3=b8yl?= References: <79614d56-6ce5-5471-fcc8-f0dc30467826@yandex.ru> <87blgp731t.fsf@simenheg@gmail.com> From: Dmitry Gutov Message-ID: Date: Mon, 26 Oct 2020 23:57:41 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87blgp731t.fsf@simenheg@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: 44214 Cc: 44214@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) On 26.10.2020 11:24, Simen Heggestøyl wrote: > This seems sufficient to me. Would you like to test it out? Seems to work, yeah! Thank you. BTW, is the case when (ppss-innermost-start (syntax-ppss)) is nil, at all reachable? From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 27 10:21:58 2020 Received: (at 44214-done) by debbugs.gnu.org; 27 Oct 2020 14:21:58 +0000 Received: from localhost ([127.0.0.1]:45378 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXPrJ-0003vc-Ur for submit@debbugs.gnu.org; Tue, 27 Oct 2020 10:21:58 -0400 Received: from aibo.runbox.com ([91.220.196.211]:60112) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXPrI-0003vP-4p for 44214-done@debbugs.gnu.org; Tue, 27 Oct 2020 10:21:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=selector1; h=Content-Transfer-Encoding:Content-Type:MIME-Version: Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From; bh=v34U2vJRa16ANv1+EiccOMYOxcbujXaMVg0C9qqoWMY=; b=KBNm9kE6NKPzyhGwo8SI9lgLoO Ngw6trcYaODSABxqtReg8Wrj0nyCJSXE8tuBhigx4B+EnXn6YB8iZ6w54AFI5g00tMSm89oAaxLl9 Rnl9ZkdsVoxAUjMwsBnibZDi8mulc4iYy7m757exrbUIl7x9Y5AH+q+JDker/V2EwtZchu1nzAAFR q3Duvhe45OVX3t/lBOhDQXtdg9LOiXfQpOxqmw83h2Qf0NFQGpLma3pELdBeXY7Ut84sM3t2IUovI BbLFdEqc1zdha/hm8QeqJowHomXtdOwB5utSGSrSR40d8Zl+VKR+N5YgCT41a6EAxhG59oyt2x/Q9 Enseo9Xg==; Received: from [10.9.9.74] (helo=submission03.runbox) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1kXPrF-0005Ky-RN; Tue, 27 Oct 2020 15:21:54 +0100 Received: by submission03.runbox with esmtpsa [Authenticated alias (963757)] (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) id 1kXPr8-0000gF-Tn; Tue, 27 Oct 2020 15:21:46 +0100 From: =?utf-8?Q?Simen_Heggest=C3=B8yl?= To: Dmitry Gutov Subject: Re: bug#44214: 28.0.50; css-mode: no completion in declaration with newline after References: <79614d56-6ce5-5471-fcc8-f0dc30467826@yandex.ru> <87blgp731t.fsf@simenheg@gmail.com> Date: Tue, 27 Oct 2020 15:21:46 +0100 In-Reply-To: (Dmitry Gutov's message of "Mon, 26 Oct 2020 23:57:41 +0200") Message-ID: <87361zagw5.fsf@simenheg@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 44214-done Cc: 44214-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Dmitry Gutov writes: > On 26.10.2020 11:24, Simen Heggest=C3=B8yl wrote: >> This seems sufficient to me. Would you like to test it out? > > Seems to work, yeah! Nice, I've pushed the fix. > BTW, is the case when (ppss-innermost-start (syntax-ppss)) is nil, at > all reachable? Yes, when called from top level. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 27 17:06:19 2020 Received: (at 44214) by debbugs.gnu.org; 27 Oct 2020 21:06:19 +0000 Received: from localhost ([127.0.0.1]:46140 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXWAd-0007wF-JI for submit@debbugs.gnu.org; Tue, 27 Oct 2020 17:06:19 -0400 Received: from mail-ed1-f50.google.com ([209.85.208.50]:37481) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXWAb-0007w1-Bd for 44214@debbugs.gnu.org; Tue, 27 Oct 2020 17:06:17 -0400 Received: by mail-ed1-f50.google.com with SMTP id o18so2932517edq.4 for <44214@debbugs.gnu.org>; Tue, 27 Oct 2020 14:06:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=vZUR0TmK4HH55MHsxpAj0O664r91RTmWLVBe9kCih00=; b=UaG5ZjLbYuo5piykQri7Yi6S8VlfR8AVqXtgvIADeplEPSiX0/MYltcKuXXqHM0RA8 yF7y+JwYWAukUDJPAK/ndbyr65DkxMmJ+XrmQGelfxi4f/LGkBk/febQhiYAQEvv57yi 135kdxEzRCsj96dAA/KK99VvjYiLJra8YLce9w690ubVSZPfIqWkAAi7nBmXA7l9Z/VA pPs3VAZMb6AXtkDQR4o1OmHhYq4ZOkZyTsdhwDfBVGlSMmmdrI4uXs8SFDoiYtjjSBvB sIECDnW0x9usWsCgNzE0IQroZyRUHpNnBSgtUo+W+hJYNW8lAgkBdIPzhYUo0ZUWKmTp cG5Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=vZUR0TmK4HH55MHsxpAj0O664r91RTmWLVBe9kCih00=; b=LiQg8KrLQUcl73IYbPc0BuVVe0oSznfE4ucHjf3fpBUaWjpy08wIXDJjRcVivCe9Mo iCbXL3kkKVVg/M/FNAsHtn29XemENgiGNol0eeDQv6uJ5unLaOJi+hSQEi0Mkxdikeb9 eWniARQ9DKbyxxH+0vhusZq3//p/YmJSEZoE31yf0r55F/BH3jEUJ977l5WbN8mtB0Rj 5iSLB431ODtwP/60M2yYGNUjgk5AZiyzwmDUUmYoENa8mFvWrIY+cPtc24/l5jWEaCRk hwFRxNzrHXVAl84w4j8YhKWL9MbNIZUjuLqCqke0bMQyPe7Esp55JmEAedjM6n/eWZzm AihQ== X-Gm-Message-State: AOAM532v6p1H4fsrYyQkLPWoQHPvFKEAl6jYdlQdKar1JyVclPq+t6cZ 920hy4Wm7/i1d6JEXSOrZUo= X-Google-Smtp-Source: ABdhPJxBGgbLcUGyO2P2dezucsTElkBV9RsEbrI7LYPPXWwh/II2yttGK4CyOtbf7CGJkGHMqVTNcg== X-Received: by 2002:aa7:dd42:: with SMTP id o2mr4261467edw.53.1603832771580; Tue, 27 Oct 2020 14:06:11 -0700 (PDT) Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id s12sm1623603edu.28.2020.10.27.14.06.10 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Oct 2020 14:06:10 -0700 (PDT) Subject: Re: bug#44214: 28.0.50; css-mode: no completion in declaration with newline after To: 44214@debbugs.gnu.org, simenheg@runbox.com References: <79614d56-6ce5-5471-fcc8-f0dc30467826@yandex.ru> <87blgp731t.fsf@simenheg@gmail.com> <87361zagw5.fsf@simenheg@gmail.com> From: Dmitry Gutov Message-ID: <1b90d2bf-ec19-8ad7-64fe-391141c409fc@yandex.ru> Date: Tue, 27 Oct 2020 23:06:09 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87361zagw5.fsf@simenheg@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: 44214 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) On 27.10.2020 16:21, Simen Heggestøyl wrote: > Dmitry Gutov writes: > >> On 26.10.2020 11:24, Simen Heggestøyl wrote: >>> This seems sufficient to me. Would you like to test it out? >> >> Seems to work, yeah! > > Nice, I've pushed the fix. Thanks! Seems to work. >> BTW, is the case when (ppss-innermost-start (syntax-ppss)) is nil, at >> all reachable? > > Yes, when called from top level. Should the search ever succeed in this case, though? I would suggest to use (point) instead of (point-min) to auto-fail: diff --git a/lisp/textmodes/css-mode.el b/lisp/textmodes/css-mode.el index 748a561bab..747657b1ed 100644 --- a/lisp/textmodes/css-mode.el +++ b/lisp/textmodes/css-mode.el @@ -1358,7 +1358,7 @@ css--complete-property-value "Complete property value at point." (let ((property (and (looking-back "\\([[:alnum:]-]+\\):[^/][^;]*" (or (ppss-innermost-start (syntax-ppss)) - (point-min)) + (point)) t) (member (match-string-no-properties 1) css-property-ids)))) Otherwise, we both do the costly-ish search from the bob, and even risk it succeed in rare cases where the CSS in the previous rule is incomplete (or the semicolon is omitted), e.g.: a { animation-delay: inherit } cal| From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 27 17:11:45 2020 Received: (at 44214) by debbugs.gnu.org; 27 Oct 2020 21:11:45 +0000 Received: from localhost ([127.0.0.1]:46145 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXWFt-00083n-7b for submit@debbugs.gnu.org; Tue, 27 Oct 2020 17:11:45 -0400 Received: from aibo.runbox.com ([91.220.196.211]:38556) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXWFq-00083e-Dz for 44214@debbugs.gnu.org; Tue, 27 Oct 2020 17:11:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=runbox.com; s=selector1; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From; bh=GNYGiGf96DoyLzJE1WEqQOVYvKmXC/daTvGMDyXuOKY=; b=a+MWtmRlfRwHVkpxD3bTedfD3h 5kZTEV4EzB8zmb5O6BfityT3umGkQWDYQ3wSSvZhc8fkFLY7JDG9i78VC9cCShibRDuLMBlKAK+EA wUjtlfBrxifgGZ0bL19Dx0K6QCO7emFkMZ2vTg5cPCthrbu89Jp0fBJWCTAzJmlIVnSbnZKjyx7Yz 2J+Ap481uWSgNFX8WDoePm9k1AIsPJOzHx1GwI3FObKKZUH4+H3Ia+W5lC0roVV2YxdndGT6ABJDb lseX4Ufv6FrpsvP5RsWZBiewYpoz2o9TxENfSkSvBVVJ+17CKwMVL5rr3LUWND0CbHt0pFZI7jXT0 8feIkqqg==; Received: from [10.9.9.72] (helo=submission01.runbox) by mailtransmit02.runbox with esmtp (Exim 4.86_2) (envelope-from ) id 1kXWFo-0000JM-Op; Tue, 27 Oct 2020 22:11:40 +0100 Received: by submission01.runbox with esmtpsa [Authenticated alias (963757)] (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) id 1kXWFj-0005vc-3n; Tue, 27 Oct 2020 22:11:35 +0100 From: =?utf-8?Q?Simen_Heggest=C3=B8yl?= To: Dmitry Gutov Subject: Re: bug#44214: 28.0.50; css-mode: no completion in declaration with newline after References: <79614d56-6ce5-5471-fcc8-f0dc30467826@yandex.ru> <87blgp731t.fsf@simenheg@gmail.com> <87361zagw5.fsf@simenheg@gmail.com> <1b90d2bf-ec19-8ad7-64fe-391141c409fc@yandex.ru> Date: Tue, 27 Oct 2020 22:11:33 +0100 In-Reply-To: <1b90d2bf-ec19-8ad7-64fe-391141c409fc@yandex.ru> (Dmitry Gutov's message of "Tue, 27 Oct 2020 23:06:09 +0200") Message-ID: <87k0vb74sa.fsf@simenheg@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 44214 Cc: 44214@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.7 (/) Dmitry Gutov writes: >>> BTW, is the case when (ppss-innermost-start (syntax-ppss)) is nil, at >>> all reachable? >> Yes, when called from top level. > > Should the search ever succeed in this case, though? I would suggest > to use (point) instead of (point-min) to auto-fail: > > [...] > > Otherwise, we both do the costly-ish search from the bob, and even > risk it succeed in rare cases where the CSS in the previous rule is > incomplete (or the semicolon is omitted) Good point, I didn't think about that. Your proposed fixed looks good to me. From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 27 21:44:12 2020 Received: (at 44214) by debbugs.gnu.org; 28 Oct 2020 01:44:12 +0000 Received: from localhost ([127.0.0.1]:46523 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXaVY-0008ME-Ku for submit@debbugs.gnu.org; Tue, 27 Oct 2020 21:44:12 -0400 Received: from mail-ej1-f47.google.com ([209.85.218.47]:42799) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXaVW-0008M0-R3 for 44214@debbugs.gnu.org; Tue, 27 Oct 2020 21:44:11 -0400 Received: by mail-ej1-f47.google.com with SMTP id h24so4923821ejg.9 for <44214@debbugs.gnu.org>; Tue, 27 Oct 2020 18:44:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=qt49TThFNd2hSU2BmqG21ZWSEpIuvRGmaKmu0PDHo7c=; b=c4Zlp2XTUMZNHeLWeQ82d7RdzDNbclIh0AvK7eXc0HtfJ52zl3sq5cvGaw22IvB/hW 0shEqUfW8A1DVuZEj/TgwTvYxJtT//6rMBA20ahDK8yARZzQZD4hKAlFvfS9K9jETcMP Zn+p1zqpm51dYwCIjBe5/aghD8q36HewruatN7zBb90Ig04czfQbxXOUQ+5XaP+kFg94 iXpnGKOI4nVRNfA9mQtFFgElB+h3HDKEkfOP1ilo+6xKJ9njgRS6uGnpjbvh9eNSecGr qt9mddUXW6zXZE884DisQLt+5yBSybq9NG5jASmgJIPiuqSLRPj62lmMNU7MPu10lfCR zLvA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:subject:to:cc:references:from:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=qt49TThFNd2hSU2BmqG21ZWSEpIuvRGmaKmu0PDHo7c=; b=MyoyRRqmmNb/F32G/ga5mVPyDwEYADbhnzfdf10ddGzHrlXnl8h4eYvNFE6VX92I40 wf0xzvSjB/b3TaZ/EBUwDQhYmggRABbFYPvMqBPrZ9qvWB+EHRerOmNWGoCP9TkxJjuq BkucaHWGtvMzkzWdLs9yVdPsXEeGw0gqe/1O880GecKRVXU6sDGXRIjag9H0kHlhUDG8 gzF2/1a3/qxo5uE+a1i9kTAqB8/IFiaM7yOYeNVp/gCbj5k3I2YXEpiao8J67ZTkL3N8 YkB1cEbMwDkI0KnGZj3zjeJIwFl3iRrlNl2TMFD8710Qe5mGR3a+Y4j6zYxSeQ0CGL1J A4ig== X-Gm-Message-State: AOAM5316Ha8HJTtISlUPBP3zL1qh+fPZ/6TX0NNZbPXOZcsJtTt7+BLG X3q2dGf7/shqKqAJY68Vqk7ZPp0FS0LKQg== X-Google-Smtp-Source: ABdhPJyVMmOoMPdiru5N60Ahagczyo0fky4+8upmrFUru5flq4e7roYDMv78SR7XAi5AlTyJIiP0yA== X-Received: by 2002:a17:906:3641:: with SMTP id r1mr5054687ejb.405.1603849444671; Tue, 27 Oct 2020 18:44:04 -0700 (PDT) Received: from [192.168.0.4] ([66.205.71.3]) by smtp.googlemail.com with ESMTPSA id i3sm1735797edd.75.2020.10.27.18.44.03 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 27 Oct 2020 18:44:03 -0700 (PDT) Subject: Re: bug#44214: 28.0.50; css-mode: no completion in declaration with newline after To: =?UTF-8?Q?Simen_Heggest=c3=b8yl?= References: <79614d56-6ce5-5471-fcc8-f0dc30467826@yandex.ru> <87blgp731t.fsf@simenheg@gmail.com> <87361zagw5.fsf@simenheg@gmail.com> <1b90d2bf-ec19-8ad7-64fe-391141c409fc@yandex.ru> <87k0vb74sa.fsf@simenheg@gmail.com> From: Dmitry Gutov Message-ID: <3cd78db2-2ac8-1233-f9ae-8d3bbcf498c5@yandex.ru> Date: Wed, 28 Oct 2020 03:44:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <87k0vb74sa.fsf@simenheg@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-Spam-Score: -1.7 (-) X-Debbugs-Envelope-To: 44214 Cc: 44214@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.7 (--) On 27.10.2020 23:11, Simen Heggestøyl wrote: > Good point, I didn't think about that. > > Your proposed fixed looks good to me. Thanks, now pushed. From unknown Mon Aug 18 11:22:07 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 25 Nov 2020 12:24:05 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator