From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 25 04:52:15 2020 Received: (at submit) by debbugs.gnu.org; 25 Oct 2020 08:52:15 +0000 Received: from localhost ([127.0.0.1]:35736 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWbl9-00078B-Be for submit@debbugs.gnu.org; Sun, 25 Oct 2020 04:52:15 -0400 Received: from lists.gnu.org ([209.51.188.17]:57058) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWbl7-000783-3O for submit@debbugs.gnu.org; Sun, 25 Oct 2020 04:52:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35296) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kWbl6-0006xO-Pq for guix-patches@gnu.org; Sun, 25 Oct 2020 04:52:12 -0400 Received: from mira.cbaines.net ([212.71.252.8]:59964) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kWbl4-0001ou-Cp for guix-patches@gnu.org; Sun, 25 Oct 2020 04:52:12 -0400 Received: from localhost (92.41.179.191.threembb.co.uk [92.41.179.191]) by mira.cbaines.net (Postfix) with ESMTPSA id 6975827BBF0 for ; Sun, 25 Oct 2020 08:51:37 +0000 (GMT) Received: from localhost (localhost [local]) by localhost (OpenSMTPD) with ESMTPA id fc906c77 for ; Sun, 25 Oct 2020 08:51:34 +0000 (UTC) From: Christopher Baines To: guix-patches@gnu.org Subject: [PATCH] doc: Document the postgresql-config-file. Date: Sun, 25 Oct 2020 08:51:34 +0000 Message-Id: <20201025085134.14378-1-mail@cbaines.net> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=212.71.252.8; envelope-from=mail@cbaines.net; helo=mira.cbaines.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/25 04:51:37 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -18 X-Spam_score: -1.9 X-Spam_bar: - X-Spam_report: (-1.9 / 5.0 requ) BAYES_00=-1.9, SPF_HELO_PASS=-0.001, SPF_PASS=-0.001, UNPARSEABLE_RELAY=0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * doc/guix.texi (PostgreSQL): Document the postgresql-config-file record. --- doc/guix.texi | 48 ++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 48 insertions(+) diff --git a/doc/guix.texi b/doc/guix.texi index b5061877e2..726906c77d 100644 --- a/doc/guix.texi +++ b/doc/guix.texi @@ -18553,6 +18553,54 @@ required to add extensions provided by other packages. @end table @end deftp +@deftp {Data Type} postgresql-config-file +Data type representing the PostgreSQL configuration file. As shown in +the following example, this can be used to customise the configuration +of PostgreSQL. Note that you can use any G-expression or filename in +place of this record, if you already have a configuration file you'd +like to use for example. + +@lisp +(service postgresql-service-type + (postgresql-configuration + (config-file + (postgresql-config-file + (log-destination "stderr") + (hba-file + (plain-file "pg_hba.conf" + " +local all all trust +host all all 127.0.0.1/32 md5 +host all all ::1/128 md5")) + (extra-config + '(("session_preload_libraries" "'auto_explain'") + ("random_page_cost" "2") + ("auto_explain.log_min_duration" "'100ms'") + ("work_mem" "'500MB'") + ("logging_collector" "on") + ("log_directory" "'/var/log/postgresql'"))))))) +@end lisp + +@table @asis +@item @var{log-destination} (default: @code{"syslog"}) +The logging method to use for PostgreSQL. Multiple values are accepted, +separated by commas. + +@item @var{hba-file} (default: @code{%default-postgres-hba}) +Filename or G-expression for the host-based authentication +configuration. + +@item @var{ident-file} (default: @code{%default-postgres-ident}) +Filename or G-expression for the user name mapping configuration. + +@item @var{extra-config} (default: @code{'()}) +List of additional keys and values to include in the PostgreSQL config +file. Each entry in the list should be a list where the first element +is the key, and the remaining elements are the values. + +@end table +@end deftp + @subsubheading MariaDB/MySQL @deffn {Scheme Procedure} mysql-service [#:config (mysql-configuration)] -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 25 06:21:34 2020 Received: (at 44207) by debbugs.gnu.org; 25 Oct 2020 10:21:34 +0000 Received: from localhost ([127.0.0.1]:35785 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWd9Z-00011z-UZ for submit@debbugs.gnu.org; Sun, 25 Oct 2020 06:21:34 -0400 Received: from mail-wm1-f68.google.com ([209.85.128.68]:37953) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWd9W-00011j-Hf for 44207@debbugs.gnu.org; Sun, 25 Oct 2020 06:21:32 -0400 Received: by mail-wm1-f68.google.com with SMTP id l15so9315593wmi.3 for <44207@debbugs.gnu.org>; Sun, 25 Oct 2020 03:21:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version; bh=QopWx/r4pqTbwbgg88l6iOvusoegX3cm1OlA71zkREs=; b=b1znIVZare3HNtQtib+Gfc99fHl5u4j6FAc6Li/0CPZao3v5B6Waygr19hweCZDQLI G35LS3hR3b0Qm0gLQzEe+qMiJ0xXmcEPUSK2qWyE4x0KvAYx8YH1kwYzaP20A34/7AU7 7BxW/M4WRJ83fygP/filgXW3maLnPVoKk7qVvjC6rIvd1R2io19DKmwBAYLhIrWuxZ29 YkZE/Pi7OXUSduPJBEfeNWtezAJpXLmCz3aFpjKHE3BelOBD4o077XGlM695JW9e8mt+ S4bv/Qz18GaLxhzhkMjmu97r/jcv1ZWsGRzvHQEvC0UyWAsGxxHoPidUqAg3tdWAV5CH sfGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version; bh=QopWx/r4pqTbwbgg88l6iOvusoegX3cm1OlA71zkREs=; b=R38o3it5I29kjhQEnbqOt1pL0kmxlW9OFFwEgBPtiIXiFpMzRQFRygRSacn583g3mu qT72B3lf7bFX4tA9+1lOHXsIrAyt7mmr36uQEw5yixj3HreXjxwYb9cwn6fCQbyhHf/q 2S1Jw09SQQPnaWm4veoWxHjdDu3CeJlRi3JZi8bfKisIc0uFXXdkY2exVdw15vR1ArQn jCdzdONt4EmSXHcRvjByZtzK8YQvA7Q7wS2WLhf3hfchlnjEvV3a95FSpUcBN+TJaNfP 390PfqSCjm6r0vuN5cLvn+TDsdkZI6WlhEBt0fAxyDKcwOfR1QBx9Bng3bvwQhnk52EY 7O9g== X-Gm-Message-State: AOAM533woGKqcfJ9dV8k00mZWnrJj0Mkr4bR4drO8JUBjIh2jvuFtF8R 8+NitsijWH10/kvIdlnNrSopAySqSpyBGA== X-Google-Smtp-Source: ABdhPJwAuxNB7dPyCC0deAFHrh0D1svMHboua9vbQN5xz7JoST4mlTbX/r87pFOcGZg/ZmypxX5z6g== X-Received: by 2002:a1c:e2c1:: with SMTP id z184mr2884091wmg.36.1603621284530; Sun, 25 Oct 2020 03:21:24 -0700 (PDT) Received: from unfall (218.139.134.37.dynamic.jazztel.es. [37.134.139.218]) by smtp.gmail.com with ESMTPSA id s2sm14033260wmh.9.2020.10.25.03.21.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 25 Oct 2020 03:21:23 -0700 (PDT) From: =?utf-8?Q?Miguel_=C3=81ngel_Arruga_Vivas?= To: Christopher Baines Subject: Re: [bug#44207] [PATCH] doc: Document the postgresql-config-file. References: <20201025085134.14378-1-mail@cbaines.net> Date: Sun, 25 Oct 2020 11:21:23 +0100 In-Reply-To: <20201025085134.14378-1-mail@cbaines.net> (Christopher Baines's message of "Sun, 25 Oct 2020 08:51:34 +0000") Message-ID: <87eelm7gik.fsf@gmail.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: 0.2 (/) X-Debbugs-Envelope-To: 44207 Cc: 44207@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.8 (/) Hi! Some comments inline. Christopher Baines writes: > +@deftp {Data Type} postgresql-config-file > +Data type representing the PostgreSQL configuration file. As shown in > +the following example, this can be used to customise the configuration > +of PostgreSQL. Note that you can use any G-expression or filename in > +place of this record, if you already have a configuration file you'd > +like to use for example. I'm pretty sure you should s/customise/customize/, as the manual is written in US English. Also, I'd move the last sentence to the hba-file description as an example there, something like: "Filename or G-expression for the host-based authentication configuration. If you already have a configuration file, you can use it here." [...] > +@item @var{log-destination} (default: @code{"syslog"}) [...] > +@item @var{hba-file} (default: @code{%default-postgres-hba}) [...] > +@item @var{ident-file} (default: @code{%default-postgres-ident}) [...] > +@item @var{extra-config} (default: @code{'()}) These should be @code, not @var, because they represent symbols from the configuration. The typical use of @var is for arguments---e.g. @code{(call-something @var{param1} @var{param2})}---, whose names don't have a meaning outside the actual implementation, but these identifiers are symbols included in the API. Apart from that, LGTM. :-) Happy hacking! Miguel From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 25 07:06:29 2020 Received: (at 44207-done) by debbugs.gnu.org; 25 Oct 2020 11:06:29 +0000 Received: from localhost ([127.0.0.1]:35846 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWdr3-0004L5-Ej for submit@debbugs.gnu.org; Sun, 25 Oct 2020 07:06:29 -0400 Received: from mira.cbaines.net ([212.71.252.8]:34982) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWdr1-0004Kw-LW for 44207-done@debbugs.gnu.org; Sun, 25 Oct 2020 07:06:28 -0400 Received: from localhost (92.41.179.191.threembb.co.uk [92.41.179.191]) by mira.cbaines.net (Postfix) with ESMTPSA id 4BD2C27BBF0; Sun, 25 Oct 2020 11:06:26 +0000 (GMT) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id a2a90709; Sun, 25 Oct 2020 11:06:23 +0000 (UTC) References: <20201025085134.14378-1-mail@cbaines.net> <87eelm7gik.fsf@gmail.com> User-agent: mu4e 1.4.13; emacs 27.1 From: Christopher Baines To: Miguel =?utf-8?Q?=C3=81ngel?= Arruga Vivas Subject: Re: [bug#44207] [PATCH] doc: Document the postgresql-config-file. In-reply-to: <87eelm7gik.fsf@gmail.com> Date: Sun, 25 Oct 2020 11:06:20 +0000 Message-ID: <87imaya7kj.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 44207-done Cc: 44207-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Miguel =C3=81ngel Arruga Vivas writes: > Hi! > > Some comments inline. Hey, thanks for the quick comments :) > Christopher Baines writes: >> +@deftp {Data Type} postgresql-config-file >> +Data type representing the PostgreSQL configuration file. As shown in >> +the following example, this can be used to customise the configuration >> +of PostgreSQL. Note that you can use any G-expression or filename in >> +place of this record, if you already have a configuration file you'd >> +like to use for example. > > I'm pretty sure you should s/customise/customize/, as the manual is > written in US English. Indeed, old habits :) > Also, I'd move the last sentence to the hba-file description as an > example there, something like: "Filename or G-expression for the > host-based authentication configuration. If you already have a > configuration file, you can use it here." While the same is true for the hba-file, and ident-file bit, I wanted to make this point for the postgresql-config-file record as a whole. Hopefully that makes sense? > [...] >> +@item @var{log-destination} (default: @code{"syslog"}) > [...] >> +@item @var{hba-file} (default: @code{%default-postgres-hba}) > [...] >> +@item @var{ident-file} (default: @code{%default-postgres-ident}) > [...] >> +@item @var{extra-config} (default: @code{'()}) > > These should be @code, not @var, because they represent symbols from the > configuration. The typical use of @var is for arguments---e.g. > @code{(call-something @var{param1} @var{param2})}---, whose names > don't have a meaning outside the actual implementation, but these > identifiers are symbols included in the API. Ah, this is probably something I got wrong when documenting the postgresql-configuration record, I wonder if I copied that from somewhere else... anyway, I've fixed this now. > Apart from that, LGTM. :-) Great, I've pushed now with the above changes. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl+VXC1fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XfQqQ/+IaJelrvCq4fdm9X0KsBEkw0xq+zLauRh taI3G3FYh0+QbdpmCX8JzpBhEAZ+8jgh3QvzvCNXAnh6xa13UnKWGoi0AT1UJgsZ wK5GMcTQIDsP5O53TpCkWmM9bKeEea2xac6CB5qCTAkHecGt9fkV3Lnr9AxX9f/b Sa0X3HKM4j6O/2AYDOkPBmQCR/IQCkXfAZoVt+SKypc13tNbWeRpP3HcwPR8YkuM jJqxM4OE2uLjiMFGII0NxE6YMlLjIDut7pfTVTOgmPwUdFML4P70Lc0GAzzCX+ko F5EhIxlCNl9pPxoiFZlq9r+4JGPgIpeHimsVAkFCwy3lxaMSH/x+lWZZXr6B+FaY m5+k8JTmahwWXr52ZctecY/YDDM5pIYLZUXzzPxk4yaTugrsucCU6QrJxqLxuJqu v+R+JTo+zvV32zeAGjoWcH3r+nZgBlDacGn51L5DOjJLbJmBWnT4pMW8WHdI2IHv bB6S1APgRI7nAxfp7tw07jhSEOPTLOe+89XVh+UiLeZ+xs9xZ5r4DqZgGhXPoDX9 4Zq96ET/emCP3sX0a6JWc8n0virqJipxEmN7XB02KTV0dLkPf4/6CyyxljJwdqV4 5X0+3YrohEWNmAHQO81O7Qct/Hog9ZO9sD/VyOmA/pisgETu+aLI7VOq7hYnn9ey vhQCdKsAWdQ= =Og4a -----END PGP SIGNATURE----- --=-=-=-- From unknown Thu Aug 14 21:54:30 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Sun, 22 Nov 2020 12:24:04 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator