GNU bug report logs - #44202
[PATCH] Add variable to control confirmation of help-mode-revert-buffer

Previous Next

Package: emacs;

Reported by: Kevin Foley <kevin <at> kevinjfoley.me>

Date: Sat, 24 Oct 2020 23:13:01 UTC

Severity: normal

Tags: fixed, patch

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

Full log


View this message in rfc822 format

From: Stefan Kangas <stefan <at> marxist.se>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Kevin Foley <kevin <at> kevinjfoley.me>, Drew Adams <drew.adams <at> oracle.com>, 44202 <at> debbugs.gnu.org
Subject: bug#44202: [PATCH] Add variable to control confirmation of help-mode-revert-buffer
Date: Mon, 26 Oct 2020 15:59:45 +0100
Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> I've looked at some of the different usages of `revert-buffer-function',
> and the help-functions one seems to be an outlier -- very few of the
> non-file ones ask at all (I haven't found one yet, but I've only looked
> at a handful).  Which makes me wonder why the *Help* one does?  I've
> always found that pretty odd.  What's the use case for prompting the
> user when the user hits `g' here?

Thank you for looking into this more deeply.  I think not prompting
here could work, unless there is some important reason not to.

> I am a bit worried about incompatibles by hoisting that code up to
> `revert-buffer'...

Indeed, I missed to mention that in my previous email.  So it might
not be worth it if we can do the above instead.




This bug report was last modified 4 years and 177 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.