From unknown Wed Jun 18 23:14:06 2025 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 X-Mailer: MIME-tools 5.509 (Entity 5.509) Content-Type: text/plain; charset=utf-8 From: bug#44202 <44202@debbugs.gnu.org> To: bug#44202 <44202@debbugs.gnu.org> Subject: Status: [PATCH] Add variable to control confirmation of help-mode-revert-buffer Reply-To: bug#44202 <44202@debbugs.gnu.org> Date: Thu, 19 Jun 2025 06:14:06 +0000 retitle 44202 [PATCH] Add variable to control confirmation of help-mode-rev= ert-buffer reassign 44202 emacs submitter 44202 Kevin Foley severity 44202 normal tag 44202 patch fixed thanks From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 24 19:12:28 2020 Received: (at submit) by debbugs.gnu.org; 24 Oct 2020 23:12:28 +0000 Received: from localhost ([127.0.0.1]:35447 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWSi3-0001JD-C7 for submit@debbugs.gnu.org; Sat, 24 Oct 2020 19:12:28 -0400 Received: from lists.gnu.org ([209.51.188.17]:57866) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWQ6c-0005d0-MQ for submit@debbugs.gnu.org; Sat, 24 Oct 2020 16:25:39 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35546) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kWQ6c-0001yp-Fl for bug-gnu-emacs@gnu.org; Sat, 24 Oct 2020 16:25:38 -0400 Received: from mout-p-202.mailbox.org ([80.241.56.172]:31842) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_CHACHA20_POLY1305:256) (Exim 4.90_1) (envelope-from ) id 1kWQ6Z-0003kR-SN for bug-gnu-emacs@gnu.org; Sat, 24 Oct 2020 16:25:37 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [80.241.60.240]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4CJXfM0MB9zQkjT for ; Sat, 24 Oct 2020 22:25:31 +0200 (CEST) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp1.mailbox.org ([80.241.60.240]) by spamfilter04.heinlein-hosting.de (spamfilter04.heinlein-hosting.de [80.241.56.122]) (amavisd-new, port 10030) with ESMTP id CQnO1hCmuv63 for ; Sat, 24 Oct 2020 22:25:27 +0200 (CEST) From: Kevin Foley To: bug-gnu-emacs@gnu.org Subject: [PATCH] Add variable to control confirmation of help-mode-revert-buffer Date: Sat, 24 Oct 2020 16:25:24 -0400 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-MBO-SPAM-Probability: X-Rspamd-Score: -4.48 / 15.00 / 15.00 X-Rspamd-Queue-Id: 1625E17DF X-Rspamd-UID: 712a44 Received-SPF: pass client-ip=80.241.56.172; envelope-from=kevin@kevinjfoley.me; helo=mout-p-202.mailbox.org X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/24 16:25:31 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -25 X-Spam_score: -2.6 X-Spam_bar: -- X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.6 (-) X-Debbugs-Envelope-To: submit X-Mailman-Approved-At: Sat, 24 Oct 2020 19:12:25 -0400 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.6 (--) Allows users to control the `noconfirm' parameter of `help-mode-revert-buffer'. I've assigned copyright to FSF but this is my first patch on this list so please let me know if I've missed any standards. --- lisp/help-mode.el | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/lisp/help-mode.el b/lisp/help-mode.el index 0dc6c9ffae..458b959aec 100644 --- a/lisp/help-mode.el +++ b/lisp/help-mode.el @@ -98,6 +98,13 @@ The format is (FUNCTION ARGS...).") "Hook run by `help-mode'." :type 'hook :group 'help) + +(defcustom help-mode-revert-buffer-noconfirm nil + "Indicates whether to prompt for confirmation when reverting a +help buffer." + :type 'boolean + :group 'help + :version "28.1") ;; Button types used by help @@ -757,7 +764,12 @@ Show all docs for that symbol as either a variable, function or face." (user-error "No symbol here")))) (defun help-mode-revert-buffer (_ignore-auto noconfirm) - (when (or noconfirm (yes-or-no-p "Revert help buffer? ")) + "Revert help-mode buffer. See +`help-mode-revert-buffer-noconfirm' to control whether user is +prompted for confirmation." + (when (or noconfirm + help-mode-revert-buffer-noconfirm + (yes-or-no-p "Revert help buffer? ")) (let ((pos (point)) (item help-xref-stack-item) ;; Pretend there is no current item to add to the history. -- 2.28.0 From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 24 19:40:50 2020 Received: (at 44202) by debbugs.gnu.org; 24 Oct 2020 23:40:50 +0000 Received: from localhost ([127.0.0.1]:35459 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWT9W-0001zI-G1 for submit@debbugs.gnu.org; Sat, 24 Oct 2020 19:40:50 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:54726) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWT9T-0001z4-Jy for 44202@debbugs.gnu.org; Sat, 24 Oct 2020 19:40:48 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 09ONc4PK026340; Sat, 24 Oct 2020 23:40:41 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=mime-version : message-id : date : from : sender : to : subject : references : in-reply-to : content-type : content-transfer-encoding; s=corp-2020-01-29; bh=1KD0E/yNevcb1ugQwzPTIh4eO8Wrfb0z1wnP4Wy6f2U=; b=wOv6fJU9ofkHvOGwjQtz33OgP5/7frVw2TYRl91QzXWFV1r15Bu4Hb8lg3ffuURDbbY0 4oDG1e7fUqaq6Plg/BAi1tLU/NHS8eVFz0dwU/4XbV/8azb6yjRl7rhGxHGJxv1xvxL0 /mc5Mh4sO36DqITlyeRJzWoWMnHGXJzZguI3FgVEEX+I04sBlDTOnGFbonAtamIBfMSa NyM3Mnz5W25T7V/V5lU0GAITbMYUmVufhONKig0IJ+4I1gKOk8RcdDp+169/Gbn6538t keMZNFxWIo4fTkyPn8EeNR3Alx93zIqJE/3Cyrq5KxqB/I637nRfMij4Q5x+4vanG6eI fg== Received: from aserp3030.oracle.com (aserp3030.oracle.com [141.146.126.71]) by userp2120.oracle.com with ESMTP id 34ccwmh656-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=FAIL); Sat, 24 Oct 2020 23:40:41 +0000 Received: from pps.filterd (aserp3030.oracle.com [127.0.0.1]) by aserp3030.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 09ONeI5K129101; Sat, 24 Oct 2020 23:40:41 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by aserp3030.oracle.com with ESMTP id 34cwuj86cy-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Sat, 24 Oct 2020 23:40:41 +0000 Received: from abhmp0007.oracle.com (abhmp0007.oracle.com [141.146.116.13]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 09ONeeXZ013397; Sat, 24 Oct 2020 23:40:40 GMT MIME-Version: 1.0 Message-ID: <9b8f80b0-34ec-4ab9-8546-0c1e51da5696@default> Date: Sat, 24 Oct 2020 16:40:39 -0700 (PDT) From: Drew Adams To: Kevin Foley , 44202@debbugs.gnu.org Subject: RE: bug#44202: [PATCH] Add variable to control confirmation of help-mode-revert-buffer References: In-Reply-To: X-Priority: 3 X-Mailer: Oracle Beehive Extensions for Outlook 2.0.1.9.1 (1003210) [OL 16.0.5056.0 (x86)] Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9784 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxscore=0 bulkscore=0 spamscore=0 adultscore=0 malwarescore=0 mlxlogscore=999 suspectscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2010240183 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9784 signatures=668682 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxscore=0 adultscore=0 spamscore=0 mlxlogscore=999 clxscore=1011 malwarescore=0 priorityscore=1501 impostorscore=0 bulkscore=0 suspectscore=0 lowpriorityscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2009150000 definitions=main-2010240182 X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 44202 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) > +(defcustom help-mode-revert-buffer-noconfirm nil > + "Indicates whether to prompt for confirmation when reverting a > +help buffer." A minor comment (and others may disagree with me). I think the first line of the doc string should say what a true value means, because the option name does that. Or at least the doc string should somehow make clear which Boolean value means which behavior. E.g.: Non-nil means do not prompt for confirmation when reverting a help buffer. If you just say "whether" there's no way to know which value means what, except to guess from the option name, in which case the doc string doesn't add anything. From debbugs-submit-bounces@debbugs.gnu.org Sat Oct 24 20:01:29 2020 Received: (at 44202) by debbugs.gnu.org; 25 Oct 2020 00:01:29 +0000 Received: from localhost ([127.0.0.1]:35482 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWTTV-0002VL-8T for submit@debbugs.gnu.org; Sat, 24 Oct 2020 20:01:29 -0400 Received: from mail-ej1-f43.google.com ([209.85.218.43]:34265) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWTTR-0002V5-Mg for 44202@debbugs.gnu.org; Sat, 24 Oct 2020 20:01:27 -0400 Received: by mail-ej1-f43.google.com with SMTP id gs25so8075346ejb.1 for <44202@debbugs.gnu.org>; Sat, 24 Oct 2020 17:01:25 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to; bh=5weMhcL6AUu7eckEJChQ3gQcCkWkqTYBFwMz0ovKa8k=; b=mF8Bx1cJM4CMwDgNXY6HSMrplRSp2mf5uHO8KYrJRh6Dpw9ME3gR/MYcrRuE1l69Am 1GOXo0xSEG64l3XF5tWgjaRuHoz6ynD1hzlRSfjVph3B4/SKT7YrkV2u2Tw/e2QkUrHe NAVSwnwKjcxQjZ4V0LVpmjVTqcol4tBM+8FSfJIjwAZo/trV35ey6AtfgKuwefXEJK46 KHoADhJr8aASb7ZH3mfX4j1YKxrE6iEVRB2U7qUc9Tb8U80pYU5Q/+AcKiUbcNudCuLW TZD6V2acOflu0JLSdtco2FlsUKMYFnoXl94gfZqliK5EGpy2SoqxkFkw0P9ooMH0zQv0 8AAA== X-Gm-Message-State: AOAM5336a3JukdQqTkz+hTV/Ou4wFczWXRV5ZraJ52GNmOYm5AImII51 3EuclOcd20RW98cfYYZfXr3lCgz8AA7E7rBes/c= X-Google-Smtp-Source: ABdhPJwEpD5hwSj2AdePfr1IPp/DlIeSY3KKK74DAX8AfByCyunjtE9CLxjU5OT/Tw0B7sHOY3yJMkNFuqWgOqJuSpI= X-Received: by 2002:a17:906:3cd:: with SMTP id c13mr8641846eja.25.1603584079643; Sat, 24 Oct 2020 17:01:19 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sat, 24 Oct 2020 17:01:19 -0700 From: Stefan Kangas In-Reply-To: References: MIME-Version: 1.0 Date: Sat, 24 Oct 2020 17:01:19 -0700 Message-ID: Subject: Re: bug#44202: [PATCH] Add variable to control confirmation of help-mode-revert-buffer To: Kevin Foley , 44202@debbugs.gnu.org Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 44202 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Kevin Foley writes: > Allows users to control the `noconfirm' parameter of > `help-mode-revert-buffer'. > > I've assigned copyright to FSF but this is my first patch on this list > so please let me know if I've missed any standards. Thanks, it looks useful. I have added my comments below. Your patch seems to be lacking ChangeLog entries as described in etc/CONTRIBUTE. You would help us if you could add such entries, especially if you are planning to do more changes. > +(defcustom help-mode-revert-buffer-noconfirm nil This would change the default, right? Any rationale for that? Perhaps we could keep this new behavior optional for now? We could consider changing it later once we get some experience with it. > + "Indicates whether to prompt for confirmation when reverting a > +help buffer." The first sentence of a doc string should fit on one line. Perhaps you could use something like: "If non-nil, prompt before reverting a help buffer." > (defun help-mode-revert-buffer (_ignore-auto noconfirm) > - (when (or noconfirm (yes-or-no-p "Revert help buffer? ")) > + "Revert help-mode buffer. See > +`help-mode-revert-buffer-noconfirm' to control whether user is > +prompted for confirmation." The first line should be one sentence only, and the second sentence start on the second line. Other than those nits, the patch looks good to me. From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 25 09:39:44 2020 Received: (at 44202) by debbugs.gnu.org; 25 Oct 2020 13:39:44 +0000 Received: from localhost ([127.0.0.1]:36020 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWgFM-0003z7-0R for submit@debbugs.gnu.org; Sun, 25 Oct 2020 09:39:44 -0400 Received: from mout-p-103.mailbox.org ([80.241.56.161]:22652) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWgFJ-0003yu-OQ for 44202@debbugs.gnu.org; Sun, 25 Oct 2020 09:39:42 -0400 Received: from smtp2.mailbox.org (smtp2.mailbox.org [IPv6:2001:67c:2050:105:465:1:2:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-103.mailbox.org (Postfix) with ESMTPS id 4CJzbW3k1szQky8; Sun, 25 Oct 2020 14:39:35 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp2.mailbox.org ([80.241.60.241]) by spamfilter04.heinlein-hosting.de (spamfilter04.heinlein-hosting.de [80.241.56.122]) (amavisd-new, port 10030) with ESMTP id 2g2Ul8Hrb-Ph; Sun, 25 Oct 2020 14:39:27 +0100 (CET) From: Kevin Foley To: Stefan Kangas , 44202@debbugs.gnu.org, Drew Adams Subject: Re: bug#44202: [PATCH] Add variable to control confirmation of help-mode-revert-buffer In-Reply-To: References: Date: Sun, 25 Oct 2020 09:39:24 -0400 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-MBO-SPAM-Probability: X-Rspamd-Score: -7.75 / 15.00 / 15.00 X-Rspamd-Queue-Id: 3B03616FD X-Rspamd-UID: be2103 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44202 X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Drew Adams writes: > I think the first line of the doc string should > say what a true value means, because the option > name does that. > Or at least the doc string should somehow make > clear which Boolean value means which behavior. > E.g.: > Non-nil means do not prompt for confirmation when reverting a help > buffer. I agree this is better and also matches the recommendation in `(elisp)Documentation Tips', I've updated the patch to reflect this. Stefan Kangas writes: > Your patch seems to be lacking ChangeLog entries as described in > etc/CONTRIBUTE. You would help us if you could add such entries, > especially if you are planning to do more changes. I've updated the commit message per the CONTRIBUTE file, let me know if there are any changes needed. As a side note, it may be helpful to mention this file in the `(emacs)Sending Patches for GNU Emacs' info node. That was the page I was referencing for info before submitting this. >> +(defcustom help-mode-revert-buffer-noconfirm nil > > This would change the default, right? Any rationale for that? The default should be the same. I've updated the docstring which I think makes this clearer. >> + "Indicates whether to prompt for confirmation when reverting a >> +help buffer." > > The first sentence of a doc string should fit on one line. Updated with Drew's suggestion. >> (defun help-mode-revert-buffer (_ignore-auto noconfirm) >> - (when (or noconfirm (yes-or-no-p "Revert help buffer? ")) >> + "Revert help-mode buffer. See >> +`help-mode-revert-buffer-noconfirm' to control whether user is >> +prompted for confirmation." > > The first line should be one sentence only, and the second sentence > start on the second line. Updated to match these conventions. Thank you both for the feedback, let me know if there any other changes that should be made. --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Add-option-to-disable-confirmation-prompt-when-rever.patch Content-Description: patch >From 42f226804ac20c2650ccfb063668e24e915b2cb2 Mon Sep 17 00:00:00 2001 From: "Kevin J. Foley" Date: Sat, 24 Oct 2020 16:14:31 -0400 Subject: [PATCH] Add option to disable confirmation prompt when reverting help buffer * lisp/help-mode.el (help-mode-revert-buffer-noconfirm): (help-mode-revert-buffer): Add variable and reference it in revert function. --- lisp/help-mode.el | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/lisp/help-mode.el b/lisp/help-mode.el index 0dc6c9ffae..729529e4db 100644 --- a/lisp/help-mode.el +++ b/lisp/help-mode.el @@ -98,6 +98,12 @@ The format is (FUNCTION ARGS...).") "Hook run by `help-mode'." :type 'hook :group 'help) + +(defcustom help-mode-revert-buffer-noconfirm nil + "Non-nil means do not prompt for confirmation when reverting a help buffer." + :type 'boolean + :group 'help + :version "28.1") ;; Button types used by help @@ -757,7 +763,11 @@ Show all docs for that symbol as either a variable, function or face." (user-error "No symbol here")))) (defun help-mode-revert-buffer (_ignore-auto noconfirm) - (when (or noconfirm (yes-or-no-p "Revert help buffer? ")) + "Revert help-mode buffer. +See `help-mode-revert-buffer-noconfirm' to control confirmation prompt." + (when (or noconfirm + help-mode-revert-buffer-noconfirm + (yes-or-no-p "Revert help buffer? ")) (let ((pos (point)) (item help-xref-stack-item) ;; Pretend there is no current item to add to the history. -- 2.28.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 25 09:51:02 2020 Received: (at 44202) by debbugs.gnu.org; 25 Oct 2020 13:51:02 +0000 Received: from localhost ([127.0.0.1]:36049 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWgQI-0006O1-4b for submit@debbugs.gnu.org; Sun, 25 Oct 2020 09:51:02 -0400 Received: from quimby.gnus.org ([95.216.78.240]:59432) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWgQG-0006NY-It for 44202@debbugs.gnu.org; Sun, 25 Oct 2020 09:51:01 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=LI8UbNM42S0pA0XOZJnd8jw/r7MbI2KxcTTw841Lxro=; b=foOyioTbrW3n9uQUSwLDzrogn8 FA81IzUEAgEZxuKwIW+X9ubJ+MvkbpVlHdVPXOhWjvNpRHyHWOmnh68OyONlFUMhPwQYwQD9LS6az Duquy82IFpMt4aJmHmqeAPqohbF8HeuTcmBsUMcepVYyr28+rn8w4SnG05iE8dVj34aw=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kWgQ6-0001ay-Px; Sun, 25 Oct 2020 14:50:53 +0100 From: Lars Ingebrigtsen To: Kevin Foley Subject: Re: bug#44202: [PATCH] Add variable to control confirmation of help-mode-revert-buffer References: X-Now-Playing: Melanie de Biasio's _A stomach is burning_: "Let me love you" Date: Sun, 25 Oct 2020 14:50:49 +0100 In-Reply-To: (Kevin Foley's message of "Sun, 25 Oct 2020 09:39:24 -0400") Message-ID: <87lffu9zye.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Kevin Foley writes: > +(defcustom help-mode-revert-buffer-noconfirm nil In general, I think "negative" variables should be avoided, because doing the "not not" logic confuses people. So I'd rather have `help-mode-revert-buffer-confirm' (defaulting to t). Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44202 Cc: Stefan Kangas , Drew Adams , 44202@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Kevin Foley writes: > +(defcustom help-mode-revert-buffer-noconfirm nil In general, I think "negative" variables should be avoided, because doing the "not not" logic confuses people. So I'd rather have `help-mode-revert-buffer-confirm' (defaulting to t). -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 25 10:47:39 2020 Received: (at 44202) by debbugs.gnu.org; 25 Oct 2020 14:47:39 +0000 Received: from localhost ([127.0.0.1]:37272 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWhJ5-0001ib-HR for submit@debbugs.gnu.org; Sun, 25 Oct 2020 10:47:39 -0400 Received: from mout-p-202.mailbox.org ([80.241.56.172]:58440) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWhJ3-0001iN-5a for 44202@debbugs.gnu.org; Sun, 25 Oct 2020 10:47:37 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:105:465:1:1:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-202.mailbox.org (Postfix) with ESMTPS id 4CK15v07PrzQlPq; Sun, 25 Oct 2020 15:47:31 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp1.mailbox.org ([80.241.60.240]) by spamfilter02.heinlein-hosting.de (spamfilter02.heinlein-hosting.de [80.241.56.116]) (amavisd-new, port 10030) with ESMTP id sl5afsfzX9kX; Sun, 25 Oct 2020 15:47:24 +0100 (CET) From: Kevin Foley To: Lars Ingebrigtsen Subject: Re: bug#44202: [PATCH] Add variable to control confirmation of help-mode-revert-buffer In-Reply-To: <87lffu9zye.fsf@gnus.org> References: <87lffu9zye.fsf@gnus.org> Date: Sun, 25 Oct 2020 10:47:20 -0400 Message-ID: MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-MBO-SPAM-Probability: X-Rspamd-Score: -6.27 / 15.00 / 15.00 X-Rspamd-Queue-Id: F077917DB X-Rspamd-UID: 4f9137 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44202 Cc: Stefan Kangas , Drew Adams , 44202@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) --=-=-= Content-Type: text/plain Lars Ingebrigtsen writes: >> +(defcustom help-mode-revert-buffer-noconfirm nil > > In general, I think "negative" variables should be avoided, because > doing the "not not" logic confuses people. So I'd rather have > `help-mode-revert-buffer-confirm' (defaulting to t). I was trying to match the noconfirm argument of the revert function but I agree, `help-mode-revert-buffer-confirm' is less confusing. I've attached an updated patch. Kevin Foley --=-=-= Content-Type: text/x-patch Content-Disposition: inline; filename=0001-Add-option-to-disable-confirmation-prompt-when-rever.patch Content-Description: patch >From 9d5c29fc084d13837a5e8fb27f3948953b923605 Mon Sep 17 00:00:00 2001 From: "Kevin J. Foley" Date: Sat, 24 Oct 2020 16:14:31 -0400 Subject: [PATCH] Add option to disable confirmation prompt when reverting help buffer * lisp/help-mode.el (help-mode-revert-buffer-confirm): (help-mode-revert-buffer): Add variable and reference it in revert function. --- lisp/help-mode.el | 12 +++++++++++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/lisp/help-mode.el b/lisp/help-mode.el index 0dc6c9ffae..716924f312 100644 --- a/lisp/help-mode.el +++ b/lisp/help-mode.el @@ -98,6 +98,12 @@ The format is (FUNCTION ARGS...).") "Hook run by `help-mode'." :type 'hook :group 'help) + +(defcustom help-mode-revert-buffer-confirm t + "Non-nil means prompt for confirmation when reverting a help buffer." + :type 'boolean + :group 'help + :version "28.1") ;; Button types used by help @@ -757,7 +763,11 @@ Show all docs for that symbol as either a variable, function or face." (user-error "No symbol here")))) (defun help-mode-revert-buffer (_ignore-auto noconfirm) - (when (or noconfirm (yes-or-no-p "Revert help buffer? ")) + "Revert help-mode buffer. +See `help-mode-revert-buffer-confirm' to control confirmation prompt." + (when (or noconfirm + (not help-mode-revert-buffer-confirm) + (yes-or-no-p "Revert help buffer? ")) (let ((pos (point)) (item help-xref-stack-item) ;; Pretend there is no current item to add to the history. -- 2.28.0 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 25 12:51:07 2020 Received: (at 44202) by debbugs.gnu.org; 25 Oct 2020 16:51:07 +0000 Received: from localhost ([127.0.0.1]:37496 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWjEY-0006xZ-Rk for submit@debbugs.gnu.org; Sun, 25 Oct 2020 12:51:07 -0400 Received: from quimby.gnus.org ([95.216.78.240]:33040) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWjEW-0006x4-LC for 44202@debbugs.gnu.org; Sun, 25 Oct 2020 12:51:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=IoHozW/GmnV3GqqKssRk48U+tqjXDgvEgjOmD6LD5K0=; b=Wlfu2Ibrp0+ok25Y6dpF4AQ2PK KePruDy2W1rk/ebazF+pur+NykQp7X0O8nKfxVELtfp5OjNpyBya55ymXnlwXBNIiLuCEKBMsVi7x fVwJGLdVEJI4P7AjqarI90Q2ONWJFUoGrFH+HVg6+TXDJjwjt9AjZVXbOORH6dlRmGug=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kWjEL-000355-DZ; Sun, 25 Oct 2020 17:50:56 +0100 From: Lars Ingebrigtsen To: Kevin Foley Subject: Re: bug#44202: [PATCH] Add variable to control confirmation of help-mode-revert-buffer References: <87lffu9zye.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEWdypd5tIRkoHEY JSX////pchdQAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+QKGRAuK509oJwAAAGxSURBVDjLdZNhouMg CITFEwC9gOAFXsP977YDatLX3bXNj/g5DCBpJNJIWiNuTZjaXtSUiJS6sxiz5Q4vrIJtISEWlgHd ESVQuV+f5aLqBZjXjsE1FQZkfMxXqHy0pXn7e8EDv/8BhKUhYiOL4lWUZ6gsEek2rjq2wlyhUN0K 6rzMvTyQsaBAIyb0SAqYQrEAKmE5AJtproIw4r4KKoB3PM4wnxFhv8wdP6gil/xSkELxKjBOE/eC Yha4Tq+QxlbEDUpheRrpGiyuJPd9VFb5jyEOwF8KeLPofADalHUU4A/FThf90OAUPEALoH1h5T4O oG0uIfEDyc/dkjJHgeExAN6rwBxQ5ey1vIa0BVaovj2aDu5xgzVwWYejpGzwew+cYBjW7PZhrycr WOMsrTtXnx+gmo6s3KZks95y98prhFzmyMu69vi40BaZX3W7V0nCEfdco8e+LHwY955i23xuFA/I 488+gGT0HCC83bEKoA7MYsfh+QmQJnWrO415fYSy9blVzX7FA6jVJ1tBtuA6CnSz+3yibI+GMZTu 8bWQFSGrf4Icqn4CPZVjPBBK57fiDzF0aGQ0w9opAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIwLTEw LTI1VDE2OjQ2OjQyKzAwOjAwVGYy2AAAACV0RVh0ZGF0ZTptb2RpZnkAMjAyMC0xMC0yNVQxNjo0 Njo0MiswMDowMCU7imQAAAAASUVORK5CYII= X-Now-Playing: Blaine Reiniger's _Songs From The Rain Palace_: "My TV" Date: Sun, 25 Oct 2020 17:50:51 +0100 In-Reply-To: (Kevin Foley's message of "Sun, 25 Oct 2020 10:47:20 -0400") Message-ID: <87a6wa8d1w.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Kevin Foley writes: > I was trying to match the noconfirm argument of the revert function but > I agree, `help-mode-revert-buffer-confirm' is less confusing. > > I've attached an updated patch. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44202 Cc: Stefan Kangas , Drew Adams , 44202@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Kevin Foley writes: > I was trying to match the noconfirm argument of the revert function but > I agree, `help-mode-revert-buffer-confirm' is less confusing. > > I've attached an updated patch. Thanks. Looking at the code a bit more, I found it a bit odd that there'd be a need for this since there are other mechanisms to control this in general -- revert-without-query, in particular: --- Optional second argument NOCONFIRM means don't ask for confirmation at all. (The variable `revert-without-query' offers another way to revert buffers without querying for confirmation.) --- But the problem is that revert-buffer calls help-mode-revert-buffer, which doesn't heed that variable. Now, the documentation for revert-without-query says that it's about reverting files, so on one level that makes sense since the help buffers don't visit files. But... I think it would be helpful if help-mode-revert-buffer (and other similar functions) did heed that variable -- then there'd be one simple way to control all this. Or even perhaps have revert-buffer look at that variable and do the right thing instead of punting to revert-buffer--default. That is, it would look at file names for buffers visiting files, and buffer names for other buffers. Any opinions? -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 25 14:42:21 2020 Received: (at 44202) by debbugs.gnu.org; 25 Oct 2020 18:42:21 +0000 Received: from localhost ([127.0.0.1]:37645 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWkyD-0003Q9-Kr for submit@debbugs.gnu.org; Sun, 25 Oct 2020 14:42:21 -0400 Received: from mail-ed1-f52.google.com ([209.85.208.52]:42447) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWkyB-0003Pv-Io for 44202@debbugs.gnu.org; Sun, 25 Oct 2020 14:42:20 -0400 Received: by mail-ed1-f52.google.com with SMTP id v19so7114146edx.9 for <44202@debbugs.gnu.org>; Sun, 25 Oct 2020 11:42:19 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=3GibSml9NSPHXj1UstddlAesnxjoQoYG2fW/fN4HhEA=; b=UfL16Ru21wEaCvXXLeEc2bhLME7kJbRg48d95FPwxT2ajHmrSLZResXvoQtCKve9ro ZqrPngs3Jw6PUlO/9PrZjmql/U4+uRL+/DKcE6z7BU84IFoUK3Z1PkMBpivqydIrDuVC egMeR/yzcZBSBJtEhTZ18Q3QEmWVsyCOGuwjLUfxiZ+bkcWDVs0Eub03BHPJZKDWao7a ex7wWw3NFglk0v75psCXmKGjUqhU2wsHdxUJPWrZ0FF8IBlDR45QfpHdg75Gv672VSzM kcuZ7sKSu3co4XXz3JvG95F9vIAADIiDbBh11WdmOkTcPQcbHqyhPkJWC6h9iJEiFVvg exgA== X-Gm-Message-State: AOAM5316PI2fjpF3OkYPkQAwJNWjyEp4ReEwsT9AMm25kSNhi71q6m5p jjskiABj/TM0UzNpVQF+NCU7nztE/bX3M1L2xiQ= X-Google-Smtp-Source: ABdhPJyfR9UuOboqpy0H/4mjqrgvtQ/l2M0gY6hpUVAF3gy84GJ+Xv9rouU/l9hog7KvFx08xa1bbSX3jUnpiQRU9Vw= X-Received: by 2002:a05:6402:3133:: with SMTP id dd19mr12825420edb.100.1603651333692; Sun, 25 Oct 2020 11:42:13 -0700 (PDT) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Sun, 25 Oct 2020 11:42:13 -0700 From: Stefan Kangas In-Reply-To: <87a6wa8d1w.fsf@gnus.org> References: <87lffu9zye.fsf@gnus.org> <87a6wa8d1w.fsf@gnus.org> MIME-Version: 1.0 Date: Sun, 25 Oct 2020 11:42:13 -0700 Message-ID: Subject: Re: bug#44202: [PATCH] Add variable to control confirmation of help-mode-revert-buffer To: Lars Ingebrigtsen , Kevin Foley Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 44202 Cc: Drew Adams , 44202@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Lars Ingebrigtsen writes: > But... I think it would be helpful if help-mode-revert-buffer (and > other similar functions) did heed that variable -- then there'd be one > simple way to control all this. Agreed. It would seem logical to just be able to say: (add-to-list 'revert-without-query "\\`\\*Help\\*\\'") > Or even perhaps have revert-buffer look at that variable and do the > right thing instead of punting to revert-buffer--default. > > That is, it would look at file names for buffers visiting files, and > buffer names for other buffers. If we could get `revert-buffer' to handle this, it seems to me that it would be even better. From debbugs-submit-bounces@debbugs.gnu.org Sun Oct 25 16:08:23 2020 Received: (at 44202) by debbugs.gnu.org; 25 Oct 2020 20:08:23 +0000 Received: from localhost ([127.0.0.1]:37733 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWmJT-0005Xe-4r for submit@debbugs.gnu.org; Sun, 25 Oct 2020 16:08:23 -0400 Received: from mout-p-201.mailbox.org ([80.241.56.171]:50376) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWmJR-0005XQ-NS for 44202@debbugs.gnu.org; Sun, 25 Oct 2020 16:08:22 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:105:465:1:1:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-201.mailbox.org (Postfix) with ESMTPS id 4CK8Cz3k1PzQjVL; Sun, 25 Oct 2020 21:08:15 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp1.mailbox.org ([80.241.60.240]) by gerste.heinlein-support.de (gerste.heinlein-support.de [91.198.250.173]) (amavisd-new, port 10030) with ESMTP id A2AIqNMKHYja; Sun, 25 Oct 2020 21:08:11 +0100 (CET) From: Kevin Foley To: Stefan Kangas , Lars Ingebrigtsen Subject: Re: bug#44202: [PATCH] Add variable to control confirmation of help-mode-revert-buffer In-Reply-To: References: <87lffu9zye.fsf@gnus.org> <87a6wa8d1w.fsf@gnus.org> Date: Sun, 25 Oct 2020 16:08:07 -0400 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-MBO-SPAM-Probability: X-Rspamd-Score: -4.61 / 15.00 / 15.00 X-Rspamd-Queue-Id: 31C3717E0 X-Rspamd-UID: 118708 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44202 Cc: Drew Adams , 44202@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Stefan Kangas writes: > Lars Ingebrigtsen writes: > >> But... I think it would be helpful if help-mode-revert-buffer (and >> other similar functions) did heed that variable -- then there'd be one >> simple way to control all this. > > Agreed. It would seem logical to just be able to say: > > (add-to-list 'revert-without-query "\\`\\*Help\\*\\'") I also agree with this. I think this was how I originally tried to solve this problem (it was a while ago) but it didn't seem supported. >> Or even perhaps have revert-buffer look at that variable and do the >> right thing instead of punting to revert-buffer--default. >> >> That is, it would look at file names for buffers visiting files, and >> buffer names for other buffers. > > If we could get `revert-buffer' to handle this, it seems to me that it > would be even better. I could update `revert-buffer' to include the logic for IGNORE-AUTO and NOCONFIRM that are used in `revert-buffer--default' with some additional logic to handle buffers without associated files. Should I leave this logic in `revert-buffer--default' as well or have it only exist in `revert-buffer'? I believe that would also require changing `help-mode' to use `revert-buffer-function' and `revert-buffer' instead of binding `help-mode-revert-buffer', right? Kevin Foley From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 26 06:22:54 2020 Received: (at 44202) by debbugs.gnu.org; 26 Oct 2020 10:22:54 +0000 Received: from localhost ([127.0.0.1]:38525 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWzeP-0003hE-Nr for submit@debbugs.gnu.org; Mon, 26 Oct 2020 06:22:53 -0400 Received: from quimby.gnus.org ([95.216.78.240]:40622) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWzeN-0003h1-Sb for 44202@debbugs.gnu.org; Mon, 26 Oct 2020 06:22:52 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=S6mOyv2BoYy7S0A91Co4A9KkWnNcmaF4PoTnXn+96yM=; b=MOAz8n/dnilW7fbNhFvp4lRtQi XsjhRX1CAx7QcHDiZ0A3sRDIrZLW1SCjfzz6CuO6iNDmy1sOwgQ+yLQ6/DI0vX5FHNPy/ZrjHZPVH NdN9yDUw+iuaGD0FQkIBiiMrrJC74WDngVo9FsDa8f2UPZrNQJse80T2UnFyNrKTc5sw=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kWzeE-00088s-2y; Mon, 26 Oct 2020 11:22:44 +0100 From: Lars Ingebrigtsen To: Kevin Foley Subject: Re: bug#44202: [PATCH] Add variable to control confirmation of help-mode-revert-buffer References: <87lffu9zye.fsf@gnus.org> <87a6wa8d1w.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAKlBMVEWur7C5ubq/wMHG xsbOz9DV1da9v8GcnJ3+/v6hn56pp6bo6OfBwL7////g4hECAAAAAWJLR0QN9rRh9QAAAAd0SU1F B+QKGgoPNnGgUO4AAABUSURBVDjLY2AUBAEhI2MIcHFxcQ0NcXFOZ+jAAagqwTlhNZBeZbWKa+HK hYFHD9qIhBg7mwAltu6OAErsBoJQIN4BxN27d+ygruWjEqMSoxJDSwIAP3pcm63V4mUAAAAldEVY dGRhdGU6Y3JlYXRlADIwMjAtMTAtMjZUMTA6MTU6NTQrMDA6MDDoUXsSAAAAJXRFWHRkYXRlOm1v ZGlmeQAyMDIwLTEwLTI2VDEwOjE1OjU0KzAwOjAwmQzDrgAAAABJRU5ErkJggg== X-Now-Playing: Matmos's _The Consuming Flame: Open Exercises in Group Form (1): A Doughnut In The Sky_: "Athens New Guinea Gas Can Japan" Date: Mon, 26 Oct 2020 11:22:40 +0100 In-Reply-To: (Kevin Foley's message of "Sun, 25 Oct 2020 16:08:07 -0400") Message-ID: <87sga1477z.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Kevin Foley writes: > I could update `revert-buffer' to include the logic for IGNORE-AUTO and > NOCONFIRM that are used in `revert-buffer--default' with some additional > logic to handle buffers without associated files. Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44202 Cc: Stefan Kangas , Drew Adams , 44202@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Kevin Foley writes: > I could update `revert-buffer' to include the logic for IGNORE-AUTO and > NOCONFIRM that are used in `revert-buffer--default' with some additional > logic to handle buffers without associated files. Let's see... That would be this bit from --default, I guess: ((or noconfirm (and (not (buffer-modified-p)) (catch 'found (dolist (regexp revert-without-query) (when (string-match regexp file-name) (throw 'found t))))) (yes-or-no-p (format "Revert buffer from file %s? " file-name))) I am a bit worried about incompatibles by hoisting that code up to `revert-buffer'... I've looked at some of the different usages of `revert-buffer-function', and the help-functions one seems to be an outlier -- very few of the non-file ones ask at all (I haven't found one yet, but I've only looked at a handful). Which makes me wonder why the *Help* one does? I've always found that pretty odd. What's the use case for prompting the user when the user hits `g' here? > I believe that would also require changing `help-mode' to use > `revert-buffer-function' and `revert-buffer' instead of binding > `help-mode-revert-buffer', right? `help-mode' does bind `g' to `revert-buffer'? So I think I don't quite understand what you're asking. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 26 11:00:05 2020 Received: (at 44202) by debbugs.gnu.org; 26 Oct 2020 15:00:05 +0000 Received: from localhost ([127.0.0.1]:40763 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kX3ye-000765-UE for submit@debbugs.gnu.org; Mon, 26 Oct 2020 11:00:05 -0400 Received: from mail-ej1-f42.google.com ([209.85.218.42]:39779) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kX3yd-000752-2M for 44202@debbugs.gnu.org; Mon, 26 Oct 2020 11:00:03 -0400 Received: by mail-ej1-f42.google.com with SMTP id qh17so14021535ejb.6 for <44202@debbugs.gnu.org>; Mon, 26 Oct 2020 08:00:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=W2VQfT4uLECvb0P+zqcGycI9Jjc1D0fFJ063t8GFoIo=; b=dla9jKu3JXLlf4CHgyKgoa1T02iFuEV1nUK3BQjQHw1/Rtg6BUn4LxqFx5gE0d9efe um1HtUWn1fdkXZ4jR1TxtwEaw5G33HEAkRZjmqzQBLTs/c352Z9f/GE8hUKI80W7X4sD KxPM0zdnz/ccvIImRFiPGMr3SLHOzIopfmc2CGfGJ63Z9Ad6l65kwkORFeWhDeEK0N++ p44FESTDyn9EP4MoWy33uWOSObeJ39rm7SI7H0PsRwQro7yP7dnfAie1hBCcyV5tPMod EOzdcKV/BxVehkHV8sEEFw4Euz3GnImVCRQ5GtHw69bBdBzBcqBbQEmBHOjgEWuFFIEv DTMw== X-Gm-Message-State: AOAM5339P29Z1duSLEuOtPQCyjaJSYRD5JaCNFf7a34N/BfX4KRzoQgh K+cwlPjfU3Wk7R1B1Bs9IVb1F+1uz2g1/tekbo4= X-Google-Smtp-Source: ABdhPJxKyyR+tT4ee2BMMZ4iFnLfofuYYgHN8MsbAT+iQS87VWROka2V+FurSvZxMCzItdmCkrlSu8ehUIzR7Y7sCRI= X-Received: by 2002:a17:906:1246:: with SMTP id u6mr16104066eja.432.1603724397027; Mon, 26 Oct 2020 07:59:57 -0700 (PDT) MIME-Version: 1.0 References: <87lffu9zye.fsf@gnus.org> <87a6wa8d1w.fsf@gnus.org> <87sga1477z.fsf@gnus.org> In-Reply-To: <87sga1477z.fsf@gnus.org> From: Stefan Kangas Date: Mon, 26 Oct 2020 15:59:45 +0100 Message-ID: Subject: Re: bug#44202: [PATCH] Add variable to control confirmation of help-mode-revert-buffer To: Lars Ingebrigtsen Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 44202 Cc: Kevin Foley , Drew Adams , 44202@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Lars Ingebrigtsen writes: > I've looked at some of the different usages of `revert-buffer-function', > and the help-functions one seems to be an outlier -- very few of the > non-file ones ask at all (I haven't found one yet, but I've only looked > at a handful). Which makes me wonder why the *Help* one does? I've > always found that pretty odd. What's the use case for prompting the > user when the user hits `g' here? Thank you for looking into this more deeply. I think not prompting here could work, unless there is some important reason not to. > I am a bit worried about incompatibles by hoisting that code up to > `revert-buffer'... Indeed, I missed to mention that in my previous email. So it might not be worth it if we can do the above instead. From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 26 18:05:23 2020 Received: (at 44202) by debbugs.gnu.org; 26 Oct 2020 22:05:23 +0000 Received: from localhost ([127.0.0.1]:41809 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXAcE-0007r7-R5 for submit@debbugs.gnu.org; Mon, 26 Oct 2020 18:05:23 -0400 Received: from mout-p-101.mailbox.org ([80.241.56.151]:32556) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXAcD-0007qn-1X for 44202@debbugs.gnu.org; Mon, 26 Oct 2020 18:05:21 -0400 Received: from smtp1.mailbox.org (smtp1.mailbox.org [IPv6:2001:67c:2050:105:465:1:1:0]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-384) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mout-p-101.mailbox.org (Postfix) with ESMTPS id 4CKpmV5bWczQkJg; Mon, 26 Oct 2020 23:05:14 +0100 (CET) X-Virus-Scanned: amavisd-new at heinlein-support.de Received: from smtp1.mailbox.org ([80.241.60.240]) by spamfilter03.heinlein-hosting.de (spamfilter03.heinlein-hosting.de [80.241.56.117]) (amavisd-new, port 10030) with ESMTP id zIgk1OfHCc8S; Mon, 26 Oct 2020 23:05:07 +0100 (CET) From: Kevin Foley To: Stefan Kangas , Lars Ingebrigtsen Subject: Re: bug#44202: [PATCH] Add variable to control confirmation of help-mode-revert-buffer In-Reply-To: References: <87lffu9zye.fsf@gnus.org> <87a6wa8d1w.fsf@gnus.org> <87sga1477z.fsf@gnus.org> Date: Mon, 26 Oct 2020 18:05:03 -0400 Message-ID: MIME-Version: 1.0 Content-Type: text/plain X-MBO-SPAM-Probability: X-Rspamd-Score: -5.65 / 15.00 / 15.00 X-Rspamd-Queue-Id: 5076B17DD X-Rspamd-UID: c1a0e6 X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 44202 Cc: Drew Adams , 44202@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.7 (-) Lars Ingebrigtsen writes: > I am a bit worried about incompatibles by hoisting that code up to > `revert-buffer'... Fair point, that probably isn't a good approach. > `help-mode' does bind `g' to `revert-buffer'? So I think I don't quite > understand what you're asking. Never mind, I was mistaken about which function was bound. Stefan Kangas writes: > Lars Ingebrigtsen writes: > >> I've looked at some of the different usages of `revert-buffer-function', >> and the help-functions one seems to be an outlier -- very few of the >> non-file ones ask at all (I haven't found one yet, but I've only looked >> at a handful). Which makes me wonder why the *Help* one does? I've >> always found that pretty odd. What's the use case for prompting the >> user when the user hits `g' here? > > Thank you for looking into this more deeply. I think not prompting > here could work, unless there is some important reason not to. I agree, I've never found this useful which was the inspiration for the original patch. So would the solution be to remove the prompt all together? Or would it the approach used in the patch to provide an option to control it specifically for *Help*? Kevin Foley From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 27 03:27:24 2020 Received: (at 44202) by debbugs.gnu.org; 27 Oct 2020 07:27:25 +0000 Received: from localhost ([127.0.0.1]:42624 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXJO8-00019I-OP for submit@debbugs.gnu.org; Tue, 27 Oct 2020 03:27:24 -0400 Received: from quimby.gnus.org ([95.216.78.240]:53414) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXJO7-000193-Ix for 44202@debbugs.gnu.org; Tue, 27 Oct 2020 03:27:24 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ZO0QIR5FguMVdeGT8nF+hO6n5Azlfe9QEIyEjrJH2R4=; b=mpNw1oyCwQDN4d5geeiUb1oUna QQiwSNKJxqE37X/KAQXQtdTtuzD48IeEtIioahUOd9YwjyCxGOaJbEruajhvHJRm8aojSE2ttoAzA fAnjmrffCRB2nE+w2t7Qb4auMTZZdMN8reZyr2PE5fLzBHzkJfFmam88pK+kDkMhWwII=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kXJNx-0003fx-AD; Tue, 27 Oct 2020 08:27:16 +0100 From: Lars Ingebrigtsen To: Kevin Foley Subject: Re: bug#44202: [PATCH] Add variable to control confirmation of help-mode-revert-buffer References: <87lffu9zye.fsf@gnus.org> <87a6wa8d1w.fsf@gnus.org> <87sga1477z.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEWpYhtZLB7pohnu 0aH///80edrZAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+QKGwcXLcm69W0AAAGVSURBVDjLVVOBkcMw CAN+AfwT8M4Gzf67vQQ2tX29pkWRABlE6ujAEZk8eIjKqCNis04gHgB4EJ+z4/mtQAMydsT5OxmU tx3GD+MT2jEaqDwqBhExda3csfIjCBUK4eOdhMDAu6hI9awKefl/rD4kmmIqTu0CXL6cBEYSL6mp JkvKbwAyXl6xhiu5/CagN8PwWjKUzZwmoiCfDkDY4bwQj18qjsPdQozeKqo642Vmmu4ScgEBH7Jc i5uCu0hLPC/nRhLA9ZJ/SMEvISEmtNTim4N+7ZLwTisRkMzEptL5FC2AHg7ebwGBEIZhVlnrezti 4cHb0hW3LlUScBrs3tOb9iaD+kOOsY5hkSKunFXfhiHYgJ/e0/fY+1GWNdIAOZ0jb36Pj+49Y+u5 IQkIut8eRt1O7pmWI6tBkJ7P3DnYUiE27ZkHIH/LEyi9JNJbmMKWZHb6txiSyyY7O4Sedw31SIZJ ZSclh4EgWvUCsKbTXuEgYnH9u+3ZxlszSrT3CsCDHD+i69ZHlcu7TUaNg/aCcint+fwD5Chalzzb s+IAAAAldEVYdGRhdGU6Y3JlYXRlADIwMjAtMTAtMjdUMDc6MjM6NDUrMDA6MDBYZBDBAAAAJXRF WHRkYXRlOm1vZGlmeQAyMDIwLTEwLTI3VDA3OjIzOjQ1KzAwOjAwKTmofQAAAABJRU5ErkJggg== X-Now-Playing: Prince's _Sign 'O' the Times (2)_: "The Cross" Date: Tue, 27 Oct 2020 08:27:11 +0100 In-Reply-To: (Kevin Foley's message of "Mon, 26 Oct 2020 18:05:03 -0400") Message-ID: <87lffsruwg.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Kevin Foley writes: > So would the solution be to remove the prompt all together? Or would it > the approach used in the patch to provide an option to control it > specifically for *Help*? Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44202 Cc: Stefan Kangas , Drew Adams , 44202@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Kevin Foley writes: > So would the solution be to remove the prompt all together? Or would it > the approach used in the patch to provide an option to control it > specifically for *Help*? I looked at the VC log for the *Help* function to see whether there was a particular reason this function required confirmation (when most other non-file buffer reverting functions didn't), and I couldn't find anything. My guess is that since the revert-buffer functions have a NOCONFIRM parameter, then it was just implemented that way without, since that seems logical. (And it would be, if the NOCONFIRM parameter was more... logical.) So I've just removed the prompting in *Help* unconditionally on the trunk now. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Oct 27 03:27:34 2020 Received: (at control) by debbugs.gnu.org; 27 Oct 2020 07:27:34 +0000 Received: from localhost ([127.0.0.1]:42627 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXJOH-00019h-Vm for submit@debbugs.gnu.org; Tue, 27 Oct 2020 03:27:34 -0400 Received: from quimby.gnus.org ([95.216.78.240]:53432) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kXJOG-00019S-Hj for control@debbugs.gnu.org; Tue, 27 Oct 2020 03:27:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=HTeRXts8eN4IJWqNzRo7GUefzJHM5XeVrAPFizS67iA=; b=shCaVBlL74nioc0oAdXCoCCKqK z/3y6n62bh8vkI1wLNUNf1GVfTwfaGREx9yxt3RuLs9zPtFU9kh/waHMYeMXvDLn/3DSP5RvWb87H quulVXJIqYYY0gpAxjUhuY2RTq9Ifzyrd4zzIUNKUEARJN+RJUC8dBfyIgSm5J+6k098=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kXJO8-0003g6-Sc for control@debbugs.gnu.org; Tue, 27 Oct 2020 08:27:27 +0100 Date: Tue, 27 Oct 2020 08:27:23 +0100 Message-Id: <87k0vcruw4.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #44202 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 44202 fixed close 44202 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 44202 fixed close 44202 28.1 quit From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 17 08:04:39 2020 Received: (at 44202) by debbugs.gnu.org; 17 Nov 2020 13:04:39 +0000 Received: from localhost ([127.0.0.1]:58668 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kf0f0-0004YT-TU for submit@debbugs.gnu.org; Tue, 17 Nov 2020 08:04:39 -0500 Received: from mail-ej1-f45.google.com ([209.85.218.45]:40385) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kf0ey-0004YE-9P for 44202@debbugs.gnu.org; Tue, 17 Nov 2020 08:04:37 -0500 Received: by mail-ej1-f45.google.com with SMTP id oq3so29275993ejb.7 for <44202@debbugs.gnu.org>; Tue, 17 Nov 2020 05:04:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=ZbJT+fOP/pFP5FWTiYoR1Pr1M549DmYNAvoupiMjsD0=; b=sB0IGj0p3P9fwUO8mZENB0cTtMlSU9zsWZ0MXe747xfZjB1Y3TK0furTnvYx1Ca5Qh OUPwxnE1VYIfBaeQM0kAr5AIfvhodeK0zs4slrnlXsOQ3of4yx1TXuLUioa88osUpOJZ +9PN5+/Uddu0B9LkS/68lQPcqeT7MvESKQXeaLzUEE+xi83qFz98KkQXrXOXv4OjOCOS 4tWlZrJzqRyuAhrvkM2EzntRI2/CTwdSEEa7Hc03eOLS4ir1zNeCFE5/ZPxvFLBY+4wk eyup291Y/DaSvppHsRSFVSTPvHP/T3SSNLOtUtuItvYYFRjaL1ST5f1V0CX9/YPsN8f4 wOIw== X-Gm-Message-State: AOAM532ahEeXuEIPlwj2WTyS7UtD2uBBEsD70o04FT4bh75LDc3K1hBf fQ2c3oEwIstK7dmbLpqZvPwDgUotmu4j9F641p0= X-Google-Smtp-Source: ABdhPJwjnvmDH454qDlgixWND/NgaX8ViP9x4/JOf352Gyh06bBU2v1AFIUEJOkE/PbSsNYp12H0GzG2o/9SDPY1moc= X-Received: by 2002:a17:906:ce24:: with SMTP id sd4mr18750991ejb.432.1605618270558; Tue, 17 Nov 2020 05:04:30 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 17 Nov 2020 05:04:29 -0800 From: Stefan Kangas In-Reply-To: <87lffsruwg.fsf@gnus.org> References: <87lffu9zye.fsf@gnus.org> <87a6wa8d1w.fsf@gnus.org> <87sga1477z.fsf@gnus.org> <87lffsruwg.fsf@gnus.org> MIME-Version: 1.0 Date: Tue, 17 Nov 2020 05:04:29 -0800 Message-ID: Subject: Re: bug#44202: [PATCH] Add variable to control confirmation of help-mode-revert-buffer To: Lars Ingebrigtsen , Kevin Foley Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 44202 Cc: Drew Adams , 44202@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Lars Ingebrigtsen writes: > So I've just removed the prompting in *Help* unconditionally on the > trunk now. I like this change. But I have now run into the scenario where I type `g' to see the new value of a variable (where I expected a change) and nothing seemed to happen. The problem, of course, was that the value of the variable did not change as I expected. For me, this is fine, but I think this risks being confusing to beginners. And now I'm starting to think that perhaps this is why the prompt was added in the first place. So I wonder if it would perhaps make sense to show a message when the buffer is reverted? That way the user will get at least some feedback. From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 24 00:26:48 2020 Received: (at 44202) by debbugs.gnu.org; 24 Nov 2020 05:26:48 +0000 Received: from localhost ([127.0.0.1]:52126 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1khQqj-0003lK-Bs for submit@debbugs.gnu.org; Tue, 24 Nov 2020 00:26:48 -0500 Received: from quimby.gnus.org ([95.216.78.240]:48634) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1khQqi-0003l8-AM for 44202@debbugs.gnu.org; Tue, 24 Nov 2020 00:26:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=ihqRxhpbYCN2lE0UCxvJH/Ck1453z3wGUJStYG6NaSQ=; b=JK4eF1jeqYOfAjZurMTm5jMO+/ u5m8TOPUDsgIa4LTC8dXWzzJTwc0VPcbldxhE7NxwgftasruH29618UreEXxl2S4e7a0PKnyqB4rj xrciT9EF1mI1DX8oE4R7fzJsfHjmEyhgzY0jUX2+i6Gr45HFg+1pxcSuNKy6/PuwiFp0=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1khQqO-0008Io-Ug; Tue, 24 Nov 2020 06:26:37 +0100 From: Lars Ingebrigtsen To: Stefan Kangas Subject: Re: bug#44202: [PATCH] Add variable to control confirmation of help-mode-revert-buffer References: <87lffu9zye.fsf@gnus.org> <87a6wa8d1w.fsf@gnus.org> <87sga1477z.fsf@gnus.org> <87lffsruwg.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAD1BMVEWwcUThrmPKurLx 3uD///9ubg/NAAAAAWJLR0QEj2jZUQAAAAd0SU1FB+QLGAUYJ4KmUowAAAGWSURBVDjLZVSLscMw CMN9C9jOAqmYILD/bg9E/vWlvdRCQoBdkdYGviPW9Fh8maoqvcXrCdjgm0FlSOsi0mQsAVTEhPsB SO9/B2FMDWBfq/T4tRUAdUsREloCY1LL1TT2RkL4zlRSAoYCRhfgG4R18crhAHVayxKSYPQeKSD0 +iGwjYmhe6XlCQgjVUR8LwVE5WHiaEeKFdCXDbanSBU9Gcv0C1iYiUAblCkpbvVPARuC7/nYqIAw EnU0J8X8WhYmkabyh+6fgxJtH4sdDL3AGFT08hKygjkovcsrMaSreUkfBMtYeRiyfJSR4sW8iTHQ ngwiTArB1Od+2Qq701+MOG0Gr3N274eZ5thk+A+jXL0IYQXMIu/4dG/+A9Cp75Xfd1M+jsBDCroX XRXegJ3gmnN6MJwabmcTL6D69wKuKd6BOBiP8bLtNTTVB4AEVkl6umVuUC4BES9HOFhA5th4oXLc h5wVIPLRnMPlC+zVKjJjBmrnoajKLS46FJw1e1vXzuMvobUMrvHwpJOWV/NzmwVYVoT8AzyztIyi 6EgkAAAAJXRFWHRkYXRlOmNyZWF0ZQAyMDIwLTExLTI0VDA1OjI0OjM5KzAwOjAw6avpNAAAACV0 RVh0ZGF0ZTptb2RpZnkAMjAyMC0xMS0yNFQwNToyNDozOSswMDowMJj2UYgAAAAASUVORK5CYII= X-Now-Playing: Laraaji's _Ambient 3: Day Of Radiance_: "The Dance #1" Date: Tue, 24 Nov 2020 06:26:23 +0100 In-Reply-To: (Stefan Kangas's message of "Tue, 17 Nov 2020 05:04:29 -0800") Message-ID: <87wnybcolc.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Kangas writes: > I like this change. But I have now run into the scenario where I type > `g' to see the new value of a variable (where I expected a change) and > nothing seemed to happen. The problem, of course, was [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44202 Cc: Kevin Foley , Drew Adams , 44202@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: > I like this change. But I have now run into the scenario where I type > `g' to see the new value of a variable (where I expected a change) and > nothing seemed to happen. The problem, of course, was that the value of > the variable did not change as I expected. I don't quite follow you -- the only change was to remove the user query -- nothing else has changed. A `g' should update the buffer with the new value of the variable, as before. -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From debbugs-submit-bounces@debbugs.gnu.org Tue Nov 24 10:58:06 2020 Received: (at 44202) by debbugs.gnu.org; 24 Nov 2020 15:58:06 +0000 Received: from localhost ([127.0.0.1]:60970 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1khahi-0005yY-IR for submit@debbugs.gnu.org; Tue, 24 Nov 2020 10:58:06 -0500 Received: from mail-ej1-f49.google.com ([209.85.218.49]:41613) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1khahg-0005y1-6L for 44202@debbugs.gnu.org; Tue, 24 Nov 2020 10:58:04 -0500 Received: by mail-ej1-f49.google.com with SMTP id gj5so29213275ejb.8 for <44202@debbugs.gnu.org>; Tue, 24 Nov 2020 07:58:04 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:in-reply-to:references:mime-version:date :message-id:subject:to:cc; bh=MCJi4TINpB1V2VyDnCd2B9sUREUHR+oI6fgRc+jNt7w=; b=I9GdlaHvuQTf9vxBBdxTSEWWc2wq78OgYimCzKzDks60jAtMdYVlJvnY7FSGgpTCCQ ltoQEZAfXFG8kGA8Mo9phnpfA5spjaxZJYves5dwAQkARZo7ZEw6+tUKGbT7wrc1eRfH pCGK+xUHqc2UykIDqPpwldpQ4wiDybhfKnjMa+efEAk+R2VC5SWhjGQ/T6YhWf2wlCxU any0gnYBjePvuhvnS7cKgcleYrc8BkKqe3sYlZ1NumKZMqPLCVqDBsmH4Wlhtlf0l7ws njLw7zRrdH2ZBT9poq9422C5g+H9hGRss2PeySI5WEWTKJ5uIVmvrcQ/n2OGpVk461jg h9Jw== X-Gm-Message-State: AOAM530IFYucBtqgNQT8R8uOw/IjmYY0y5maPvWhWFtexYKiRMbS3koX naEXFGmzdWDl8RxIB2GEFWEcspJJC6Gw/bjyJ7E= X-Google-Smtp-Source: ABdhPJxl04Z8dMPB4a5VpN2oV0ZGvOAdwzCqXuALohsSqPoEsHZ0UQPkDIfV+n/1iK38b3i+OYIZv1hilVQqSpFeV4Y= X-Received: by 2002:a17:906:11d0:: with SMTP id o16mr4609978eja.25.1606233478292; Tue, 24 Nov 2020 07:57:58 -0800 (PST) Received: from 753933720722 named unknown by gmailapi.google.com with HTTPREST; Tue, 24 Nov 2020 07:57:57 -0800 From: Stefan Kangas In-Reply-To: <87wnybcolc.fsf@gnus.org> References: <87lffu9zye.fsf@gnus.org> <87a6wa8d1w.fsf@gnus.org> <87sga1477z.fsf@gnus.org> <87lffsruwg.fsf@gnus.org> <87wnybcolc.fsf@gnus.org> MIME-Version: 1.0 Date: Tue, 24 Nov 2020 07:57:57 -0800 Message-ID: Subject: Re: bug#44202: [PATCH] Add variable to control confirmation of help-mode-revert-buffer To: Lars Ingebrigtsen Content-Type: text/plain; charset="UTF-8" X-Spam-Score: 0.5 (/) X-Debbugs-Envelope-To: 44202 Cc: Kevin Foley , Drew Adams , 44202@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -0.5 (/) Lars Ingebrigtsen writes: > Stefan Kangas writes: > >> I like this change. But I have now run into the scenario where I type >> `g' to see the new value of a variable (where I expected a change) and >> nothing seemed to happen. The problem, of course, was that the value of >> the variable did not change as I expected. > > I don't quite follow you -- the only change was to remove the user > query -- nothing else has changed. A `g' should update the buffer with > the new value of the variable, as before. Absolutely, yes. But: My dumb brain was just used to seeing the confirmation and had to pause for half a second when I did not see it, thinking something was wrong. My idea was simply that we could perhaps show a message saying that the buffer was reverted, to not give other users reason for pause. WDYT? From debbugs-submit-bounces@debbugs.gnu.org Wed Nov 25 02:01:21 2020 Received: (at 44202) by debbugs.gnu.org; 25 Nov 2020 07:01:21 +0000 Received: from localhost ([127.0.0.1]:34003 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1khono-00071i-Tt for submit@debbugs.gnu.org; Wed, 25 Nov 2020 02:01:21 -0500 Received: from quimby.gnus.org ([95.216.78.240]:33906) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1khonn-00071V-TM for 44202@debbugs.gnu.org; Wed, 25 Nov 2020 02:01:20 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date: References:Subject:Cc:To:From:Sender:Reply-To:Content-Transfer-Encoding: Content-ID:Content-Description:Resent-Date:Resent-From:Resent-Sender: Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=71AcScoJ7FW1xw1f/f1V8/VJpm9av0tNwzn2EaBGTiw=; b=RFtM1/pedgL6VtixWhTXAvLbac uYZyHK8m7IeAz6TCVWJZ6/LrhR3aWqY/3iWCsoh7nGa96X+VbzvwEkDAZZ4EguYC7yhzDWnmQfGLc jyOYMpSkhjwBRXxiTZAxdiNPTP64VNtN1BQoDftuo8y3Yfkr3uCiYLcKKCpR+pNQ1E7g=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1khona-0004SM-SY; Wed, 25 Nov 2020 08:01:12 +0100 From: Lars Ingebrigtsen To: Stefan Kangas Subject: Re: bug#44202: [PATCH] Add variable to control confirmation of help-mode-revert-buffer References: <87lffu9zye.fsf@gnus.org> <87a6wa8d1w.fsf@gnus.org> <87sga1477z.fsf@gnus.org> <87lffsruwg.fsf@gnus.org> <87wnybcolc.fsf@gnus.org> Face: iVBORw0KGgoAAAANSUhEUgAAADAAAAAwBAMAAAClLOS0AAAABGdBTUEAALGPC/xhBQAAACBj SFJNAAB6JgAAgIQAAPoAAACA6AAAdTAAAOpgAAA6mAAAF3CculE8AAAAElBMVEUfHxglJRpMSDZY WUzCnHb///86tvQhAAAAAWJLR0QF+G/pxwAAAAd0SU1FB+QLGQY4HBzTRjYAAAGvSURBVDjLbZSB saQgDIYDbgEBLQDiFaCEAvZW+q/pEmAV3rvMLO7km/8PgSgYJ+HpiX1niQPqg7nmYmfR4QmpShwZ MC4iyF9NPKCI6rxUu+ADoijUITof6XUIgAjUFAgAshiDr3cD3coBVuAEICAKANeJAvltb13FagYG tuMBflAoMA3c1asCt7reVror1AVWXb7Fawba2oK6lQ1uSBujQPomt/2t5b8AUBUa2znYqDdJ7xUk mKMpEDbGKf9Ycfhp1UE6alW5i7rLG6zHWx/27AfXgRx/qNVX/gWQ5Zl2jhMA8EGO6FVSPn8oTr8g 5HLlT3yAHkawAv6Uki+awWk92nJxvniwMk5GIgSxSlyYfLxrIDCE3eTy2QsnisOuMrqFi3gpoKlz WEoNne8BwAlbAxcTjyBKex3wBGAEoYN22UvNZr54F8WqYG/1O5BOOmjzeSsyxzp2dw3TCsjRhxkA N0C/gM8VON+Af6ZDjjfRaeqwTkDe+RQJ/wMsJ0kbuMGCAdCCNSlZIggzkE8DxOQTu4QK3GAFcnmG qJQPLLAOHx5i1ual0w+Dvb843yFs4n/BFVwBr38MeAAAACV0RVh0ZGF0ZTpjcmVhdGUAMjAyMC0x MS0yNVQwNjo1NjoyOCswMDowML0a2v8AAAAldEVYdGRhdGU6bW9kaWZ5ADIwMjAtMTEtMjVUMDY6 NTY6MjgrMDA6MDDMR2JDAAAAAElFTkSuQmCC X-Now-Playing: Modern English's _Mesh & Lace_: "Move in Light" Date: Wed, 25 Nov 2020 08:01:05 +0100 In-Reply-To: (Stefan Kangas's message of "Tue, 24 Nov 2020 07:57:57 -0800") Message-ID: <87lfep2a4u.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stefan Kangas writes: > Absolutely, yes. But: My dumb brain was just used to seeing the > confirmation and had to pause for half a second when I did not see it, > thinking something was wrong. My idea was simply that we co [...] Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 44202 Cc: Kevin Foley , Drew Adams , 44202@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stefan Kangas writes: > Absolutely, yes. But: My dumb brain was just used to seeing the > confirmation and had to pause for half a second when I did not see it, > thinking something was wrong. My idea was simply that we could perhaps > show a message saying that the buffer was reverted, to not give other > users reason for pause. WDYT? I'm not against showing a message, but I don't really see the need: The user hit the `g' command, and having Emacs do what you ask surely shouldn't come as a surprise. :-) -- (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no From unknown Wed Jun 18 23:14:06 2025 Received: (at fakecontrol) by fakecontrolmessage; To: internal_control@debbugs.gnu.org From: Debbugs Internal Request Subject: Internal Control Message-Id: bug archived. Date: Wed, 23 Dec 2020 12:24:03 +0000 User-Agent: Fakemail v42.6.9 # This is a fake control message. # # The action: # bug archived. thanks # This fakemail brought to you by your local debbugs # administrator