From unknown Mon Aug 18 15:40:48 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#44181] [PATCH] gnu: Add atomicparsley. Resent-From: Alexandru-Sergiu Marton Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 23 Oct 2020 18:25:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 44181 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 44181@debbugs.gnu.org Cc: Alexandru-Sergiu Marton X-Debbugs-Original-To: guix-patches@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.16034774426782 (code B ref -1); Fri, 23 Oct 2020 18:25:01 +0000 Received: (at submit) by debbugs.gnu.org; 23 Oct 2020 18:24:02 +0000 Received: from localhost ([127.0.0.1]:58355 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kW1jJ-0001kw-P8 for submit@debbugs.gnu.org; Fri, 23 Oct 2020 14:24:02 -0400 Received: from lists.gnu.org ([209.51.188.17]:46392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kW1jG-0001kn-TP for submit@debbugs.gnu.org; Fri, 23 Oct 2020 14:23:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47572) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kW1jG-0000HX-Ny for guix-patches@gnu.org; Fri, 23 Oct 2020 14:23:54 -0400 Received: from mout01.posteo.de ([185.67.36.65]:58967) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kW1j9-0008Dw-Tt for guix-patches@gnu.org; Fri, 23 Oct 2020 14:23:54 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id E2472160061 for ; Fri, 23 Oct 2020 20:23:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.ro; s=2017; t=1603477423; bh=+ZwVwmzxUk4XLdtBJbQVoMuIWfxt4g92lLx28s/j27U=; h=From:To:Cc:Subject:Date:From; b=bd/Jof7hvL3nMpRyt3nHBWzGIa+H0oU92CCfNIcZqsXOs/tj9rmhN2RbxpKHLx0Ix YUeMLZvB1i8C5KF5UzKcx8unEx+JlMz052FfVZDxzeS+1fwTQmnD6+d/yFcLqz+jOd FHyAOaumXfFwcDrryCgDZ4zx3gLEHXqTH0JQRT2PorH2ioNibOgkH7FJCEsTOxKf5C Xs+42uQ1gVrZB+C20xYp4uLNzYksiNUlfpyygH9dvfArnuLyNcjK1OX54vDTbnEsqH /lL5u8UTT1tlDRSFmTKPRaKrZQXZfwvRphxvzZDcfd+8WXLBtLTSS/FQoYOCDHgqK3 nNbelAh78yzXg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4CHt0F31gYz6tn0; Fri, 23 Oct 2020 20:23:41 +0200 (CEST) From: Alexandru-Sergiu Marton Date: Sat, 24 Oct 2020 00:23:46 +0300 Message-Id: <20201023212346.26664-1-brown121407@posteo.ro> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=185.67.36.65; envelope-from=brown121407@posteo.ro; helo=mout01.posteo.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/23 14:17:02 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/video.scm (atomicparsley): New variable. --- gnu/packages/video.scm | 39 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index bdccb6fdb7..5cf8b56ae1 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -44,6 +44,7 @@ ;;; Copyright © 2020 Michael Rohleder ;;; Copyright © 2020 Vinicius Monego ;;; Copyright © 2020 Brett Gilio +;;; Copyright © 2020 Alexandru-Sergiu Marton ;;; ;;; This file is part of GNU Guix. ;;; @@ -4806,3 +4807,41 @@ BBC iPlayer output.") includes @code{dvdxchap} tool for extracting chapter information from DVD.") (license license:gpl2) (home-page "https://www.bunkus.org/videotools/ogmtools/"))) + +(define-public atomicparsley + (package + (name "atomicparsley") + (version "20200701.154658.b0d6223") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/wez/atomicparsley") + (commit version))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "1kym2l5y34nmbrrlkfmxsf1cwrvch64kb34jp0hpa0b89idbhwqh")))) + (build-system cmake-build-system) + (arguments + `(#:tests? #f + #:phases + (modify-phases %standard-phases + (add-before 'configure 'set-cmake-version + (lambda* _ + (substitute* "CMakeLists.txt" + (("VERSION 3.17") "VERSION 3.16")) + #t)) + (replace 'install + (lambda* (#:key outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (bin (string-append out "/bin"))) + (install-file "AtomicParsley" bin)) + #t))))) + (inputs + `(("zlib" ,zlib))) + (synopsis "Metadata editor for MPEG-4 files") + (description "AtomicParsley is a lightweight command line program for +reading, parsing and setting metadata into MPEG-4 files, in particular, +iTunes-style metadata.") + (home-page "https://github.com/wez/atomicparsley") + (license license:gpl2))) -- 2.28.0 From unknown Mon Aug 18 15:40:48 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#44181] [PATCH] gnu: Add atomicparsley. Resent-From: Christopher Baines Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 24 Oct 2020 20:31:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44181 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Alexandru-Sergiu Marton Cc: 44181@debbugs.gnu.org Received: via spool by 44181-submit@debbugs.gnu.org id=B44181.160357145422207 (code B ref 44181); Sat, 24 Oct 2020 20:31:02 +0000 Received: (at 44181) by debbugs.gnu.org; 24 Oct 2020 20:30:54 +0000 Received: from localhost ([127.0.0.1]:35276 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWQBe-0005m1-Gw for submit@debbugs.gnu.org; Sat, 24 Oct 2020 16:30:54 -0400 Received: from mira.cbaines.net ([212.71.252.8]:43346) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWQBb-0005lp-E8 for 44181@debbugs.gnu.org; Sat, 24 Oct 2020 16:30:48 -0400 Received: from localhost (92.41.179.191.threembb.co.uk [92.41.179.191]) by mira.cbaines.net (Postfix) with ESMTPSA id 2F9CF27BBF0; Sat, 24 Oct 2020 21:30:46 +0100 (BST) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id fd3528fa; Sat, 24 Oct 2020 20:30:42 +0000 (UTC) References: <20201023212346.26664-1-brown121407@posteo.ro> User-agent: mu4e 1.4.13; emacs 27.1 From: Christopher Baines In-reply-to: <20201023212346.26664-1-brown121407@posteo.ro> Date: Sat, 24 Oct 2020 21:30:35 +0100 Message-ID: <87h7qjbc44.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Hi! Thanks for the patch, I've put some comments inline below. Alexandru-Sergiu Marton writes: > * gnu/packages/video.scm (atomicparsley): New variable. > --- > gnu/packages/video.scm | 39 +++++++++++++++++++++++++++++++++++++++ > 1 file changed, 39 insertions(+) > > diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm > index bdccb6fdb7..5cf8b56ae1 100644 > --- a/gnu/packages/video.scm > +++ b/gnu/packages/video.scm > @@ -44,6 +44,7 @@ > ;;; Copyright =C2=A9 2020 Michael Rohleder > ;;; Copyright =C2=A9 2020 Vinicius Monego > ;;; Copyright =C2=A9 2020 Brett Gilio > +;;; Copyright =C2=A9 2020 Alexandru-Sergiu Marton > ;;; > ;;; This file is part of GNU Guix. > ;;; > @@ -4806,3 +4807,41 @@ BBC iPlayer output.") > includes @code{dvdxchap} tool for extracting chapter information from DV= D.") > (license license:gpl2) > (home-page "https://www.bunkus.org/videotools/ogmtools/"))) Looks like this is at the end of video.scm. That's OK, but often unwise as if everyone adds new packages to the end of the modules, the patches will often conflict. For that reason, it's normally helpful to add packages not at the end, I usually add it close to related packages, or those with a name close by in the alphabet. > + > +(define-public atomicparsley > + (package > + (name "atomicparsley") > + (version "20200701.154658.b0d6223") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/wez/atomicparsley") > + (commit version))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "1kym2l5y34nmbrrlkfmxsf1cwrvch64kb34jp0hpa0b89idbhwqh"))= )) > + (build-system cmake-build-system) > + (arguments > + `(#:tests? #f So that someone looking at the package definition can tell why the tests are disabled, it would be good to add a comment saying why. If it's that the tests don't pass, then it can be a TODO comment. > + #:phases > + (modify-phases %standard-phases > + (add-before 'configure 'set-cmake-version > + (lambda* _ > + (substitute* "CMakeLists.txt" > + (("VERSION 3.17") "VERSION 3.16")) > + #t)) > + (replace 'install > + (lambda* (#:key outputs #:allow-other-keys) > + (let* ((out (assoc-ref outputs "out")) > + (bin (string-append out "/bin"))) > + (install-file "AtomicParsley" bin)) > + #t))))) > + (inputs > + `(("zlib" ,zlib))) > + (synopsis "Metadata editor for MPEG-4 files") > + (description "AtomicParsley is a lightweight command line program for > +reading, parsing and setting metadata into MPEG-4 files, in particular, > +iTunes-style metadata.") > + (home-page "https://github.com/wez/atomicparsley") > + (license license:gpl2))) I had a look at the few source files, and they suggested that this is gpl2+, maybe there's a bit that's gpl2 only though? Would you be able to send an updated patch? Thanks, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl+UjutfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XdKsQ/+JvIb0ar5vDZgHTO5Vx0LrZ2aZHdR61ed 1vehgNFvSIPxtgP5JwXZ+UkCwxQTLZIARt3cEbYltWu6TyxMTNBA5zuxF3u6DIiU cv0Bx43D+BOWEW/7U6egBtBouhEu/tWzcu2ZHF+lV4QeltED1VW04WT2Gck9QiQ2 bnQB51FUAFuBKhtjKKCgc7o7IrqggWq0fqzGojnNcXNvoHqiTm9lV7AiOktc248C tI42JGGoaPm/KlSp5ZXDE7gxrSBYIrlWGaqIrkP0FwYv1gXVLGBT6Jbo74HVBbac YoEXxOjUgQ3nKUpMR2I9bB4cMMO30dspPxRgnTmadO4Lg9KgUMFgPeAp2FkJEiK5 TGQb4YW2bCVgksdArh5VUzEmOx5k0zwTH7CJYUp/kVy9KAvfsrSOXhXLSsWQSvuD hLO19FXQKfXt6qumuS7Sr/Szud0sdfOGnMVDTuvcVGkaXHPHtJSE0DNd2YvVerOm BSo1PGpIY2SVP2HU1V9yZxH3er66PbkO2lw88J9UPexQHJI5tITQoQatVpYw4JMP HmqihdE2yFw9Sk7uW4hFH9WjL9NIuoyS3OlbBX9f8MlPj8ZH+zjOQs/OfAR/UzZA tq/E2QBUI7nu5x+aRxG9hiUmup3Sr7ZgZSNWaka5VtNG71Olmp9mvN19xaZCp/JF lw33axVx9tA= =ozaC -----END PGP SIGNATURE----- --=-=-=-- From unknown Mon Aug 18 15:40:48 2025 X-Loop: help-debbugs@gnu.org Subject: [bug#44181] [PATCH v2] gnu: Add atomicparsley. Resent-From: Alexandru-Sergiu Marton Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 24 Oct 2020 20:56:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44181 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 44181@debbugs.gnu.org Cc: Alexandru-Sergiu Marton , Christopher Baines Received: via spool by 44181-submit@debbugs.gnu.org id=B44181.160357290124312 (code B ref 44181); Sat, 24 Oct 2020 20:56:01 +0000 Received: (at 44181) by debbugs.gnu.org; 24 Oct 2020 20:55:01 +0000 Received: from localhost ([127.0.0.1]:35283 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWQZ3-0006K0-9x for submit@debbugs.gnu.org; Sat, 24 Oct 2020 16:55:01 -0400 Received: from mout01.posteo.de ([185.67.36.65]:54641) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWQYz-0006Je-O8 for 44181@debbugs.gnu.org; Sat, 24 Oct 2020 16:54:59 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id 2C1C9160060 for <44181@debbugs.gnu.org>; Sat, 24 Oct 2020 22:54:50 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.ro; s=2017; t=1603572891; bh=wO16reGUMWryCx9TTZwIyWTTcHpRXA4B/MgS5cciF9w=; h=From:To:Cc:Subject:Date:From; b=fTh6TduhkXF4kED9SJn7d9TBN3xxcJ0dJEERA+z6OCqbM35xzaYNyvlXbkWGXMOYG A+8g8oqqfXMtvOcqK2UDKizJ1jqwalRmA8geIrySgzcuRciNZd0PcQx4vjXBr39wiK 8+JKWDouEHa3zQlgORHAp294E9BW3CFiVSfwu3e7iPkSmGqboB1II7zTO9E+xw331n uZM1dJIEt9AxaD4VS+l9D8UZI0bXy50bx+5jp+F1XrA4edm7bac3XWHJq9oNT3Vk9Q OVER9ErC7apokIQlSBWeEEKgYg7c7nDd5f/2is3YYEEKv8+k959bbW+GM59lJ1tIk9 JGVUkSR70SHKw== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4CJYJ566yhz6tmW; Sat, 24 Oct 2020 22:54:45 +0200 (CEST) From: Alexandru-Sergiu Marton Date: Sun, 25 Oct 2020 02:54:47 +0300 Message-Id: <20201024235447.20487-1-brown121407@posteo.ro> X-Mailer: git-send-email 2.28.0 In-Reply-To: <87h7qjbc44.fsf@cbaines.net> References: <87h7qjbc44.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -3.3 (---) * gnu/packages/video.scm (atomicparsley): New variable. --- This patch doesn't place atomicparsley at the end of video.scm anymore, to prevent possible conflicts, explains why the tests are disabled and why the CMake required version is modified, and corrects the license field. gnu/packages/video.scm | 42 ++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 42 insertions(+) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index bdccb6fdb7..5908bc764b 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -44,6 +44,7 @@ ;;; Copyright © 2020 Michael Rohleder ;;; Copyright © 2020 Vinicius Monego ;;; Copyright © 2020 Brett Gilio +;;; Copyright © 2020 Alexandru-Sergiu Marton ;;; ;;; This file is part of GNU Guix. ;;; @@ -3722,6 +3723,47 @@ information and other metadata about audio or video files. It supports the many codecs and formats supported by libmediainfo.") (license license:bsd-2))) +(define-public atomicparsley + (package + (name "atomicparsley") + (version "20200701.154658.b0d6223") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/wez/atomicparsley") + (commit version))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "1kym2l5y34nmbrrlkfmxsf1cwrvch64kb34jp0hpa0b89idbhwqh")))) + (build-system cmake-build-system) + (arguments + `(#:tests? #f ;; no tests included + #:phases + (modify-phases %standard-phases + (add-before 'configure 'set-cmake-version + (lambda* _ + (substitute* "CMakeLists.txt" + ;; At the time of writing, Guix has CMake at 3.16, but + ;; AtomicParsley uses 3.17. This brings the required CMake + ;; version down to what Guix can afford. + (("VERSION 3.17") "VERSION 3.16")) + #t)) + (replace 'install + (lambda* (#:key outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (bin (string-append out "/bin"))) + (install-file "AtomicParsley" bin)) + #t))))) + (inputs + `(("zlib" ,zlib))) + (synopsis "Metadata editor for MPEG-4 files") + (description "AtomicParsley is a lightweight command line program for +reading, parsing and setting metadata into MPEG-4 files, in particular, +iTunes-style metadata.") + (home-page "https://github.com/wez/atomicparsley") + (license license:gpl2+))) + (define-public livemedia-utils (package (name "livemedia-utils") -- 2.28.0 From unknown Mon Aug 18 15:40:48 2025 MIME-Version: 1.0 X-Mailer: MIME-tools 5.505 (Entity 5.505) X-Loop: help-debbugs@gnu.org From: help-debbugs@gnu.org (GNU bug Tracking System) To: Alexandru-Sergiu Marton Subject: bug#44181: closed (Re: [PATCH v2] gnu: Add atomicparsley.) Message-ID: References: <87tuuj9tjl.fsf@cbaines.net> <20201023212346.26664-1-brown121407@posteo.ro> X-Gnu-PR-Message: they-closed 44181 X-Gnu-PR-Package: guix-patches X-Gnu-PR-Keywords: patch Reply-To: 44181@debbugs.gnu.org Date: Sat, 24 Oct 2020 21:58:01 +0000 Content-Type: multipart/mixed; boundary="----------=_1603576681-30307-1" This is a multi-part message in MIME format... ------------=_1603576681-30307-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Your bug report #44181: [PATCH] gnu: Add atomicparsley. which was filed against the guix-patches package, has been closed. The explanation is attached below, along with your original report. If you require more details, please reply to 44181@debbugs.gnu.org. --=20 44181: http://debbugs.gnu.org/cgi/bugreport.cgi?bug=3D44181 GNU Bug Tracking System Contact help-debbugs@gnu.org with problems ------------=_1603576681-30307-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at 44181-done) by debbugs.gnu.org; 24 Oct 2020 21:57:10 +0000 Received: from localhost ([127.0.0.1]:35369 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWRXB-0007ra-OA for submit@debbugs.gnu.org; Sat, 24 Oct 2020 17:57:09 -0400 Received: from mira.cbaines.net ([212.71.252.8]:45650) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kWRX8-0007rP-AW for 44181-done@debbugs.gnu.org; Sat, 24 Oct 2020 17:57:08 -0400 Received: from localhost (92.41.179.191.threembb.co.uk [92.41.179.191]) by mira.cbaines.net (Postfix) with ESMTPSA id 5569E27BBF0; Sat, 24 Oct 2020 22:57:05 +0100 (BST) Received: from capella (localhost [127.0.0.1]) by localhost (OpenSMTPD) with ESMTP id b5d0fcc9; Sat, 24 Oct 2020 21:57:03 +0000 (UTC) References: <87h7qjbc44.fsf@cbaines.net> <20201024235447.20487-1-brown121407@posteo.ro> User-agent: mu4e 1.4.13; emacs 27.1 From: Christopher Baines To: Alexandru-Sergiu Marton Subject: Re: [PATCH v2] gnu: Add atomicparsley. In-reply-to: <20201024235447.20487-1-brown121407@posteo.ro> Date: Sat, 24 Oct 2020 22:57:02 +0100 Message-ID: <87tuuj9tjl.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -0.0 (/) X-Debbugs-Envelope-To: 44181-done Cc: 44181-done@debbugs.gnu.org X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) --=-=-= Content-Type: text/plain Alexandru-Sergiu Marton writes: > * gnu/packages/video.scm (atomicparsley): New variable. > --- > This patch doesn't place atomicparsley at the end of video.scm anymore, to > prevent possible conflicts, explains why the tests are disabled and why the > CMake required version is modified, and corrects the license field. Awesome, I've pushed this to master as 6a3b4765f9dfcefa89e65406177d3442b7958c28. Thanks again, Chris --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKlBAEBCgCPFiEEPonu50WOcg2XVOCyXiijOwuE9XcFAl+Uoy5fFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcRHG1haWxAY2Jh aW5lcy5uZXQACgkQXiijOwuE9XdEOw//fu40/MBUHWT8mjroqCL63cra0WEyExA4 fXiICaLwVlsUMxtLRm+QLvGlZtRzF6ezLOtTsvvd228kZngyWBZgJzt9H/cbMJpA 0f6xrtYT25AWzqKhaa5d4jtMJnwFN4Q3WgPOy4ErJyvV/TTS9Dynl5wS2iS/laZW 60xv/+VZMtBudLKplAgs+0v6CSaC9lIJ6yCKwizqlttElXwGHBbX/fz25EKEMSKK oYO2HBbc9ArOCKBGnKVH2WswPCgV+cyawH4/2o9QJi48rxOqrN0KrVt/r3QSymMQ 3EkGrcWXmp+aZUD+Z+msy1zHgD2rZYV7VXL6V6jwy+AAngSVDWXSLoCfPeUAWArN 2LrKSuEQGdqcbz4Kj47XQJnpjj14Dd87N5a5GxdHxzxyp/V3FP7z2CYa13qiLoPJ G+sIULztikfOC9wPs5RzquRtZwlGqLvmVBsXfgjrJYgXuVi/Cr/QNIr9qRKHPI23 61R7MjBlT+pbd2O7VcMzZcwhs+GBebidL1b33EQvhbPsuZBNT4SHYQdzePgHSf65 7gm/loYdhCtoem4lIXQq4C2Oex9O62XotvjLPdbmvjfkp0Got1Cd2O07bA5UPTHg ogc12ZOMnVNSNVwbwCleusaPR77t8taZzEZFXknWDqrKw8tdeOTfKGcE04kBY7ft aItj3V7wfAs= =l4yW -----END PGP SIGNATURE----- --=-=-=-- ------------=_1603576681-30307-1 Content-Type: message/rfc822 Content-Disposition: inline Content-Transfer-Encoding: 7bit Received: (at submit) by debbugs.gnu.org; 23 Oct 2020 18:24:02 +0000 Received: from localhost ([127.0.0.1]:58355 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kW1jJ-0001kw-P8 for submit@debbugs.gnu.org; Fri, 23 Oct 2020 14:24:02 -0400 Received: from lists.gnu.org ([209.51.188.17]:46392) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kW1jG-0001kn-TP for submit@debbugs.gnu.org; Fri, 23 Oct 2020 14:23:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:47572) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kW1jG-0000HX-Ny for guix-patches@gnu.org; Fri, 23 Oct 2020 14:23:54 -0400 Received: from mout01.posteo.de ([185.67.36.65]:58967) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kW1j9-0008Dw-Tt for guix-patches@gnu.org; Fri, 23 Oct 2020 14:23:54 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout01.posteo.de (Postfix) with ESMTPS id E2472160061 for ; Fri, 23 Oct 2020 20:23:43 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.ro; s=2017; t=1603477423; bh=+ZwVwmzxUk4XLdtBJbQVoMuIWfxt4g92lLx28s/j27U=; h=From:To:Cc:Subject:Date:From; b=bd/Jof7hvL3nMpRyt3nHBWzGIa+H0oU92CCfNIcZqsXOs/tj9rmhN2RbxpKHLx0Ix YUeMLZvB1i8C5KF5UzKcx8unEx+JlMz052FfVZDxzeS+1fwTQmnD6+d/yFcLqz+jOd FHyAOaumXfFwcDrryCgDZ4zx3gLEHXqTH0JQRT2PorH2ioNibOgkH7FJCEsTOxKf5C Xs+42uQ1gVrZB+C20xYp4uLNzYksiNUlfpyygH9dvfArnuLyNcjK1OX54vDTbnEsqH /lL5u8UTT1tlDRSFmTKPRaKrZQXZfwvRphxvzZDcfd+8WXLBtLTSS/FQoYOCDHgqK3 nNbelAh78yzXg== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4CHt0F31gYz6tn0; Fri, 23 Oct 2020 20:23:41 +0200 (CEST) From: Alexandru-Sergiu Marton To: guix-patches@gnu.org Subject: [PATCH] gnu: Add atomicparsley. Date: Sat, 24 Oct 2020 00:23:46 +0300 Message-Id: <20201023212346.26664-1-brown121407@posteo.ro> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Received-SPF: pass client-ip=185.67.36.65; envelope-from=brown121407@posteo.ro; helo=mout01.posteo.de X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/23 14:17:02 X-ACL-Warn: Detected OS = Linux 3.11 and newer [fuzzy] X-Spam_score_int: -43 X-Spam_score: -4.4 X-Spam_bar: ---- X-Spam_report: (-4.4 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_MED=-2.3, RCVD_IN_MSPIKE_H4=0.001, RCVD_IN_MSPIKE_WL=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: -1.3 (-) X-Debbugs-Envelope-To: submit Cc: Alexandru-Sergiu Marton X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.3 (--) * gnu/packages/video.scm (atomicparsley): New variable. --- gnu/packages/video.scm | 39 +++++++++++++++++++++++++++++++++++++++ 1 file changed, 39 insertions(+) diff --git a/gnu/packages/video.scm b/gnu/packages/video.scm index bdccb6fdb7..5cf8b56ae1 100644 --- a/gnu/packages/video.scm +++ b/gnu/packages/video.scm @@ -44,6 +44,7 @@ ;;; Copyright © 2020 Michael Rohleder ;;; Copyright © 2020 Vinicius Monego ;;; Copyright © 2020 Brett Gilio +;;; Copyright © 2020 Alexandru-Sergiu Marton ;;; ;;; This file is part of GNU Guix. ;;; @@ -4806,3 +4807,41 @@ BBC iPlayer output.") includes @code{dvdxchap} tool for extracting chapter information from DVD.") (license license:gpl2) (home-page "https://www.bunkus.org/videotools/ogmtools/"))) + +(define-public atomicparsley + (package + (name "atomicparsley") + (version "20200701.154658.b0d6223") + (source (origin + (method git-fetch) + (uri (git-reference + (url "https://github.com/wez/atomicparsley") + (commit version))) + (file-name (git-file-name name version)) + (sha256 + (base32 + "1kym2l5y34nmbrrlkfmxsf1cwrvch64kb34jp0hpa0b89idbhwqh")))) + (build-system cmake-build-system) + (arguments + `(#:tests? #f + #:phases + (modify-phases %standard-phases + (add-before 'configure 'set-cmake-version + (lambda* _ + (substitute* "CMakeLists.txt" + (("VERSION 3.17") "VERSION 3.16")) + #t)) + (replace 'install + (lambda* (#:key outputs #:allow-other-keys) + (let* ((out (assoc-ref outputs "out")) + (bin (string-append out "/bin"))) + (install-file "AtomicParsley" bin)) + #t))))) + (inputs + `(("zlib" ,zlib))) + (synopsis "Metadata editor for MPEG-4 files") + (description "AtomicParsley is a lightweight command line program for +reading, parsing and setting metadata into MPEG-4 files, in particular, +iTunes-style metadata.") + (home-page "https://github.com/wez/atomicparsley") + (license license:gpl2))) -- 2.28.0 ------------=_1603576681-30307-1--