Subject: Re: [bug#44174] [PATCH 04/16] gnu: Upgrade ghc-doctest.

From: Christopher Baines <[email-masked]>
Date: Sat, 24 Oct 2020 22:29:28 +0100

Carlo Holl <[email-masked]> writes:

> ---
>  gnu/packages/haskell-xyz.scm | 35 ++++++++++++++++++++---------------
>  1 file changed, 20 insertions(+), 15 deletions(-)

For the commit message for this package, I'd write:

gnu: ghc-doctest: Update to 0.16.3.

* gnu/packages/haskell-xyz.scm (ghc-doctest): Update to 0.16.3.
[inputs,native-inputs]: Replace with what is generated by guix import.

> diff --git a/gnu/packages/haskell-xyz.scm b/gnu/packages/haskell-xyz.scm
> index 803ee995c0..ad9c49ddeb 100644
> --- a/gnu/packages/haskell-xyz.scm
> +++ b/gnu/packages/haskell-xyz.scm
> @@ -3416,7 +3416,7 @@ Writer monad), where list append quickly becomes too expensive.")
>  (define-public ghc-doctest
>    (package
>      (name "ghc-doctest")
> -    (version "0.16.2")
> +    (version "0.16.3")
>      (source
>       (origin
>         (method url-fetch)
> @@ -3426,26 +3426,31 @@ Writer monad), where list append quickly becomes too expensive.")
>               ".tar.gz"))
>         (sha256
>          (base32
> -         "0lk4cjfzi5bx2snfzw1zi06li0gvgz3ckfh2kwa98l7nxfdl39ag"))))
> +         "1y1l7aa80qkib1z8lsizgg7fpfdmdwhxvi5m255a42jdkjgn5sfg"))))
>      (build-system haskell-build-system)
>      (arguments `(#:tests? #f))          ; FIXME: missing test framework
>      (inputs
> -     `(("ghc-syb" ,ghc-syb)
> -       ("ghc-paths" ,ghc-paths)
> -       ("ghc-base-compat" ,ghc-base-compat)
> -       ("ghc-code-page" ,ghc-code-page)
> -       ("ghc-hunit" ,ghc-hunit)
> -       ("ghc-hspec" ,ghc-hspec)
> -       ("ghc-quickcheck" ,ghc-quickcheck)
> -       ("ghc-stringbuilder" ,ghc-stringbuilder)
> -       ("ghc-silently" ,ghc-silently)
> -       ("ghc-setenv" ,ghc-setenv)))
> +      `(("ghc-base-compat" ,ghc-base-compat)
> +        ("ghc-code-page" ,ghc-code-page)
> +        ("ghc-paths" ,ghc-paths)
> +        ("ghc-syb" ,ghc-syb)))
> +    (native-inputs
> +      `(("ghc-hunit" ,ghc-hunit)
> +        ("ghc-quickcheck" ,ghc-quickcheck)
> +        ("ghc-hspec" ,ghc-hspec)
> +        ("ghc-hspec-core" ,ghc-hspec-core)
> +        ("ghc-mockery" ,ghc-mockery)
> +        ("ghc-setenv" ,ghc-setenv)
> +        ("ghc-silently" ,ghc-silently)
> +        ("ghc-stringbuilder" ,ghc-stringbuilder)))

Here you can see the slightly off indentation, the previous level of
indentation is what I'd use.

>      (home-page
>       "https://github.com/sol/doctest#readme")
>      (synopsis "Test interactive Haskell examples")
> -    (description "The doctest program checks examples in source code comments.
> -It is modeled after doctest for Python, see
> -@uref{https://docs.python.org/library/doctest.html, the Doctest website}.")
> +    (description
> +      "The doctest program checks examples in source code comments.  It is modeled
> +after doctest for Python (@url{http://docs.python.org/library/doctest.html}).
> +
> +Documentation is at @url{https://github.com/sol/doctest#readme}.")
>      (license license:expat)))

I'd keep the previous description, as I think it's better.