From unknown Tue Aug 19 23:15:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44157: 28.0.50; skeleton bug due to lexical-binding Resent-From: Stephen Berman Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Thu, 22 Oct 2020 23:10:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: report 44157 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: To: 44157@debbugs.gnu.org X-Debbugs-Original-To: bug-gnu-emacs@gnu.org Received: via spool by submit@debbugs.gnu.org id=B.160340819925547 (code B ref -1); Thu, 22 Oct 2020 23:10:02 +0000 Received: (at submit) by debbugs.gnu.org; 22 Oct 2020 23:09:59 +0000 Received: from localhost ([127.0.0.1]:54152 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVjiZ-0006dy-5K for submit@debbugs.gnu.org; Thu, 22 Oct 2020 19:09:59 -0400 Received: from lists.gnu.org ([209.51.188.17]:59190) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVjiX-0006dr-Mm for submit@debbugs.gnu.org; Thu, 22 Oct 2020 19:09:58 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51824) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kVjiX-0000td-Hw for bug-gnu-emacs@gnu.org; Thu, 22 Oct 2020 19:09:57 -0400 Received: from mout.gmx.net ([212.227.15.19]:47403) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kVjiQ-0003wM-5a for bug-gnu-emacs@gnu.org; Thu, 22 Oct 2020 19:09:56 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1603408186; bh=uA9zbtdfN8M4a+eV50xyNTm5J7r15jwQ9aHq1okI64Y=; h=X-UI-Sender-Class:From:To:Subject:Date; b=fuBuFyEgfFo9pT7cxMP0u1yueFGEfV8kxsyfWoldkasWAMVEYt8jW2ZqEDbw1DANi GhAxHNObjvo1eNhYjm8uANyEHI6nKaPw271bQrqiRjeJ7oBXmr4G/JyQA1i3o0Y3f5 E174fPITbNZoiSB+4ttIVGRoL6Ezf5EHHeKXv/oY= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from strobe-jhalfs ([178.9.97.57]) by mail.gmx.com (mrgmx005 [212.227.17.190]) with ESMTPSA (Nemesis) id 1M6UZv-1kTnlY464f-0070Ld for ; Fri, 23 Oct 2020 01:09:46 +0200 From: Stephen Berman Date: Fri, 23 Oct 2020 01:09:43 +0200 Message-ID: <87r1ppeu2w.fsf@gmx.net> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Provags-ID: V03:K1:rAqOXCgjKxioCUMsmyTH3pEweB6ifo53jnZhA14nJILJUxl6eAc a0P6BG64+tUbDg2AVwDf55fDSPYUIN/VZSmFL7vkOzVbVrMXDFm3OkRmCXn4N1YMU10nz/I QtOML9HklYl4ZscK0bpnKcwCQGsHiP4kGF4XG8+0DmrIsp26IzmXJPlybedCCW7h6wPUBKd by2oBgO03BoeXyGEJYAOw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:44cFm/k0baw=:q+3mavUSS4MHxzTQrKxZtY 5+EBj+yWINvhnZuD8KVVqYlyx9XWtTNfnaY/WV+GNKjOqNTP0gq6pD1BDpwd2oXAR2x/eE+yC 1KgJNTS5j4cRM5oF4RpUjijw+Z33D6rbJ+mogx2zn7gxDLAF/dzwk2Fu2Q1lBShQEAkrE7Csc ax5elr8DbmH/SjVNIlXD/gJeDiq0A3poAOcXHnvyrnzUo0ay7YPM7J96ONg2fWr7CKuN7MiN8 5tZfPujcd34AUSPl2JNCUiH+q4fIHP1U1VwAOMUABTPWZaqspzYdDfGO6dXwe9ZhvUsVQ4Lx0 hBtOYEbGkpaPeWQgMbojCPqvd82Qcdlq70HQ9kQAgwmxQN53HwAVw0ak9itKCXxSgPFyz0V6B vNAMoIJ+TrZpuw039ApTRxNLI3pnYZkVgEMEm0CfftXbv8b6LUzp6SmGcAApN66fgxbiv2zLh fctr7dLxZLsS9U/3VGSWIz4wCptPWd0A+mx3dlbVg8hHAiK5EwSJCDhLoza004XaSdBMFRG+C 5JNPyPUBDvwXfDt0KDJKvtGKGYcpyqbx11mU6SDFeIDerbkdKv77KYcpkNZHus+3UUJ3/jdAp lNJIGupRDeX8aBJHCQMOZzA+68YgPEzROK1xMMFOI6mfJwSmBaIcHZgZuXECrn4j0MLwf8Ou2 aigGfTF4DF1XTh4WeuDKrh8sXYj70TncfOQApOHNSHSVEkQ0qlA1rJEeWAa0nTZKREAuIGOJ7 pkWvJceFS+MZjTUPCms3haYDs3swzwdg2Nw5MixzL+xCiC0hCfS0pJaFiC3TTXV5+CtJvRrkU D5x+YHH9DsVf+EnZZAppbYScZmR1K59M5+3JuzJLZGeHb6STQJO5zF7bura0SW7kwe6ICNRLu 2g8Zsbk9Vk3M7vDFXkrg== Received-SPF: pass client-ip=212.227.15.19; envelope-from=stephen.berman@gmx.net; helo=mout.gmx.net X-detected-operating-system: by eggs.gnu.org: First seen = 2020/10/22 19:09:46 X-ACL-Warn: Detected OS = Linux 2.2.x-3.x [generic] [fuzzy] X-Spam_score_int: -27 X-Spam_score: -2.8 X-Spam_bar: -- X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-Spam-Score: 0.6 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -2.4 (--) --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable 0. emacs -Q 1. C-x C-f test.html RET 2. C-c C-t html RET Test RET =3D> error in skeleton-internal-1: Symbol=E2=80=99s value as variable is vo= id: resume: I believe this bug was introduced by this commit: commit e038a7571ddb9ec2110533fdd1b359150939c58c Author: Stefan Monnier Commit: Stefan Monnier CommitDate: Thu Aug 6 18:45:33 2020 -0400 * lisp/skeleton.el: Use lexical-binding The following patch fixes the bug, at least for the above recipe. --=-=-= Content-Type: text/x-patch Content-Disposition: inline Content-Description: skeleton-internal-list patch diff --git a/lisp/skeleton.el b/lisp/skeleton.el index ea4e5dbc22..6e2c10d971 100644 --- a/lisp/skeleton.el +++ b/lisp/skeleton.el @@ -339,7 +339,8 @@ skeleton-internal-list (dlet ((str (or str `(setq str (skeleton-read ',(car skeleton-il) - nil ,recursive))))) + nil ,recursive)))) + resume:) (when (and (eq (cadr skeleton-il) '\n) (not recursive) (save-excursion (skip-chars-backward " \t") (bolp))) (setq skeleton-il (cons nil (cons '> (cddr skeleton-il))))) --=-=-= Content-Type: text/plain In GNU Emacs 28.0.50 (build 38, x86_64-pc-linux-gnu, GTK+ Version 3.24.17, cairo version 1.17.3) of 2020-10-21 built on strobe-jhalfs Repository revision: 39271ed108380494667ab680fc71b800f9ea5097 Repository branch: master Windowing system distributor 'The X.Org Foundation', version 11.0.12008000 System Description: Linux From Scratch SVN-20200401 Configured using: 'configure --with-xwidgets 'CFLAGS=-Og -g3'' Configured features: XPM JPEG TIFF GIF PNG RSVG CAIRO SOUND DBUS GSETTINGS GLIB NOTIFY INOTIFY ACL GNUTLS LIBXML2 FREETYPE HARFBUZZ ZLIB TOOLKIT_SCROLL_BARS GTK3 X11 XDBE XIM MODULES THREADS XWIDGETS LIBSYSTEMD PDUMPER LCMS2 --=-=-=-- From debbugs-submit-bounces@debbugs.gnu.org Fri Oct 23 07:30:33 2020 Received: (at control) by debbugs.gnu.org; 23 Oct 2020 11:30:33 +0000 Received: from localhost ([127.0.0.1]:55702 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVvHE-0001S2-SD for submit@debbugs.gnu.org; Fri, 23 Oct 2020 07:30:33 -0400 Received: from quimby.gnus.org ([95.216.78.240]:54146) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kVvHC-0001KI-Og for control@debbugs.gnu.org; Fri, 23 Oct 2020 07:30:31 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=jaovFDs9ZmYYGeLUjQSo3gKKuEktFf5HlRLZeq+IM9s=; b=SlNxXR/8fU3TDPWg93jRiLArDq QAHm1y42/Dy10Ukh5RYPz6RPY349c3bnNGDJkO6xI8vMVaot+IoxoAHjvZkkdXF8x7nOpQa0ePVP0 p7KFzn2VjPv2H0pQ0PZr3/0IrQ6tZbPqOAYAfsDK6vn7THDUSymsfdkyZj/He+3cwZ0M=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kVvH4-0000F4-Pw for control@debbugs.gnu.org; Fri, 23 Oct 2020 13:30:24 +0200 Date: Fri, 23 Oct 2020 13:30:21 +0200 Message-Id: <877drhgoxe.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #44157 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 44157 + patch quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 44157 + patch quit From debbugs-submit-bounces@debbugs.gnu.org Mon Oct 26 17:22:58 2020 Received: (at control) by debbugs.gnu.org; 26 Oct 2020 21:22:58 +0000 Received: from localhost ([127.0.0.1]:41690 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kX9xB-0000K3-UA for submit@debbugs.gnu.org; Mon, 26 Oct 2020 17:22:58 -0400 Received: from quimby.gnus.org ([95.216.78.240]:47818) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kX9xA-0000Jo-QK for control@debbugs.gnu.org; Mon, 26 Oct 2020 17:22:57 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Subject:From:To:Message-Id:Date:Sender:Reply-To:Cc: MIME-Version:Content-Type:Content-Transfer-Encoding:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:In-Reply-To:References:List-Id:List-Help:List-Unsubscribe: List-Subscribe:List-Post:List-Owner:List-Archive; bh=lR7yrN6HI/NFF01wmIiRUM0pC/CGctbxTFkkt2OeYbc=; b=gz4TbcS78f9j5mXQQ553BqErVz 4O7RtPDO125f3s+tBZ3SEsQ47QA0fp+dDVkhvI1pttPcHT4mzW0cA67TuuK25FmtVUdGH0HlR8e8t YPQLPG34b8JAYP8tB8c08iOrmHaaZn8aYA8wmG2G3GnqWRwHbqTwzvpiLEJdCgkX64N4=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kX9x3-00060k-4r for control@debbugs.gnu.org; Mon, 26 Oct 2020 22:22:51 +0100 Date: Mon, 26 Oct 2020 22:22:47 +0100 Message-Id: <87sga0u1g8.fsf@gnus.org> To: control@debbugs.gnu.org From: Lars Ingebrigtsen Subject: control message for bug #44157 X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: tags 44157 fixed close 44157 28.1 quit Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: control X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) tags 44157 fixed close 44157 28.1 quit From unknown Tue Aug 19 23:15:37 2025 X-Loop: help-debbugs@gnu.org Subject: bug#44157: 28.0.50; skeleton bug due to lexical-binding Resent-From: Lars Ingebrigtsen Original-Sender: "Debbugs-submit" Resent-CC: bug-gnu-emacs@gnu.org Resent-Date: Mon, 26 Oct 2020 21:24:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 44157 X-GNU-PR-Package: emacs X-GNU-PR-Keywords: fixed patch To: Stephen Berman Cc: 44157@debbugs.gnu.org Received: via spool by 44157-submit@debbugs.gnu.org id=B44157.16037473851326 (code B ref 44157); Mon, 26 Oct 2020 21:24:01 +0000 Received: (at 44157) by debbugs.gnu.org; 26 Oct 2020 21:23:05 +0000 Received: from localhost ([127.0.0.1]:41696 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kX9xI-0000LK-Hg for submit@debbugs.gnu.org; Mon, 26 Oct 2020 17:23:05 -0400 Received: from quimby.gnus.org ([95.216.78.240]:47804) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kX9x4-0000Jf-NN for 44157@debbugs.gnu.org; Mon, 26 Oct 2020 17:23:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnus.org; s=20200322; h=Content-Transfer-Encoding:Content-Type:MIME-Version:Message-ID :In-Reply-To:Date:References:Subject:Cc:To:From:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=6y7Sq9ACDpqicBpJozifm2wxgPBnLaohwnA2xOez+9s=; b=dj/oS+yJa46I/VUftoZrU75Mrl whBouuMWFQlfQY2ZAg1kpCeEcZVjcWoU1M6J6H7l6rMqAlqv7osHUMPXLDAYoaXewT18LqTHgErzS 15kV5fnhUi9y/l4/7HUzJylUPsxnw1MJmLOLWAGPDP8DFiwUkCEqsSUDfZW0W1YP1rCI=; Received: from cm-84.212.202.86.getinternet.no ([84.212.202.86] helo=xo) by quimby.gnus.org with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kX9wv-00060b-T3; Mon, 26 Oct 2020 22:22:44 +0100 From: Lars Ingebrigtsen References: <87r1ppeu2w.fsf@gmx.net> X-Now-Playing: Blaine Reiniger's _Songs From The Rain Palace_: "Where Are You" Date: Mon, 26 Oct 2020 22:22:40 +0100 In-Reply-To: <87r1ppeu2w.fsf@gmx.net> (Stephen Berman's message of "Fri, 23 Oct 2020 01:09:43 +0200") Message-ID: <87tuugu1gf.fsf@gnus.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Report: Spam detection software, running on the system "quimby.gnus.org", has NOT identified this incoming email as spam. The original message has been attached to this so you can view it or label similar future email. If you have any questions, see @@CONTACT_ADDRESS@@ for details. Content preview: Stephen Berman writes: > 0. emacs -Q > 1. C-x C-f test.html RET > 2. C-c C-t html RET Test RET > => error in skeleton-internal-1: =?UTF-8?Q?Symbol=E2=80=99s?= value as variable is void: resume: Content analysis details: (-2.9 points, 5.0 required) pts rule name description ---- ---------------------- -------------------------------------------------- -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP -1.9 BAYES_00 BODY: Bayes spam probability is 0 to 1% [score: 0.0000] X-Spam-Score: 0.0 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: debbugs-submit-bounces@debbugs.gnu.org Sender: "Debbugs-submit" X-Spam-Score: -1.0 (-) Stephen Berman writes: > 0. emacs -Q > 1. C-x C-f test.html RET > 2. C-c C-t html RET Test RET > =3D> error in skeleton-internal-1: Symbol=E2=80=99s value as variable is = void: resume: Yup. > The following patch fixes the bug, at least for the above recipe. > > diff --git a/lisp/skeleton.el b/lisp/skeleton.el > index ea4e5dbc22..6e2c10d971 100644 > --- a/lisp/skeleton.el > +++ b/lisp/skeleton.el > @@ -339,7 +339,8 @@ skeleton-internal-list > (dlet ((str (or str > `(setq str > (skeleton-read ',(car skeleton-il) > - nil ,recursive))))) > + nil ,recursive)))) > + resume:) So I've applied the patch to Emacs 28, but I guess there may be similar things lurking in the skeleton code, if I understand it correctly (but I probably don't). --=20 (domestic pets only, the antidote for overdose, milk.) bloggy blog: http://lars.ingebrigtsen.no