GNU bug report logs - #44156
26.3; ERC: Fix ERC's IBuffer format "crash" on killed server buffer

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44156 in the body.
You can then email your comments to 44156 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Olivier Certner <ocert.dev <at> free.fr>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.3; ERC: Fix ERC's IBuffer format "crash" on killed server buffer
Date: Thu, 22 Oct 2020 23:50:27 +0200

[Message part 1 (text/plain, inline)]

Applies to 26.3, but also to all more recent versions as well.

Bug trigger:
1. Load ERC (e.g., open some IRC connection).
2. Open some channel or query, to have another ERC buffer.
3. Quit the server.
4. Make sure to kill the server buffer, if still there.
5. Launch ibuffer (e.g., type "M-x ibuffer"). Display stops mid-line on a line 
listing some ERC buffer linked to the quit server. Further buffer updates 
(typing 'g') trigger a crash for another reason (another fix to follow-up).

Root cause:
The erc-ibuffer's server column code will return nil in this case, since
the buffer associated to its process has been killed, making the server
information inacessible, and this is not tested properly.

Patch:
Attached.

-- 
Olivier Certner

[0001-ERC-Fix-ERC-s-IBuffer-format-crash-on-killed-server-.patch (text/x-patch, attachment)]

Message #8 received at 44156 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Olivier Certner <ocert.dev <at> free.fr>
Cc: 44156 <at> debbugs.gnu.org
Subject: Re: bug#44156: 26.3; ERC: Fix ERC's IBuffer format "crash" on
 killed server buffer
Date: Fri, 23 Oct 2020 14:40:54 +0200

Olivier Certner <ocert.dev <at> free.fr> writes:

> Root cause:
> The erc-ibuffer's server column code will return nil in this case, since
> the buffer associated to its process has been killed, making the server
> information inacessible, and this is not tested properly.
>
> Patch:
> Attached.

Thanks; looks good to me, so I've applied it to Emacs 28.

It was small enough to apply without getting copyright assignment papers
for the FSF, but any subsequent patches (that aren't very small) can't
be applied without such paperwork.  Would you be willing to sign such
paperwork?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #15 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Olivier Certner <ocert.dev <at> free.fr>
To: bug-gnu-emacs <at> gnu.org
Subject: Re: bug#44156: 26.3;
 ERC: Fix ERC's IBuffer format "crash" on killed server buffer
Date: Fri, 23 Oct 2020 15:00:36 +0200

> Thanks; looks good to me, so I've applied it to Emacs 28.

	Small question from a noob on GNU projects. I don't see any commit from 
you applying this.	My origin repo is: https://git.savannah.gnu.org/git/
emacs.git. Could this be because it is not the official repo? I'm looking at 
'master'. Or maybe you didn't push there yet?

-- 
Olivier Certner

Message #18 received at 44156 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Olivier Certner <ocert.dev <at> free.fr>
Cc: 44156 <at> debbugs.gnu.org
Subject: Re: bug#44156: 26.3; ERC: Fix ERC's IBuffer format "crash" on
 killed server buffer
Date: Fri, 23 Oct 2020 15:12:06 +0200

Olivier Certner <ocert.dev <at> free.fr> writes:

> 	Small question from a noob on GNU projects. I don't see any commit from 
> you applying this.	My origin repo is: https://git.savannah.gnu.org/git/
> emacs.git. Could this be because it is not the official repo? I'm looking at 
> 'master'. Or maybe you didn't push there yet?

Yup; forgot to push.  Should be done now.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.