GNU bug report logs - #44154
26.3; Customize Face buffer: be able to click an inherited face, to customize it

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 44154 in the body.
You can then email your comments to 44154 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Drew Adams <drew.adams <at> oracle.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 26.3; Customize Face buffer: be able to click an inherited face, to
 customize it
Date: Thu, 22 Oct 2020 14:07:20 -0700 (PDT)

In Customize Face, if attribute Inherit is checked then be able to click
the name of an inherited face, to customize it, or at least to see its
attributes/definition.  

That is, have a link on it, which invokes either `customize-face' or
`describe-face' for it.

Without this, you can't directly see what the effective attributes are
for the inheriting face.

In GNU Emacs 26.3 (build 1, x86_64-w64-mingw32)
 of 2019-08-29
Repository revision: 96dd0196c28bc36779584e47fffcca433c9309cd
Windowing system distributor `Microsoft Corp.', version 10.0.18362
Configured using:
 `configure --without-dbus --host=x86_64-w64-mingw32
 --without-compress-install 'CFLAGS=-O2 -static -g3''

Message #8 received at 44154 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Drew Adams <drew.adams <at> oracle.com>
Cc: 44154 <at> debbugs.gnu.org
Subject: Re: bug#44154: 26.3; Customize Face buffer: be able to click an
 inherited face, to customize it
Date: Tue, 27 Oct 2020 11:32:32 +0100

Drew Adams <drew.adams <at> oracle.com> writes:

> In Customize Face, if attribute Inherit is checked then be able to click
> the name of an inherited face, to customize it, or at least to see its
> attributes/definition.  
>
> That is, have a link on it, which invokes either `customize-face' or
> `describe-face' for it.

Makes sense.  I've now added this to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #15 received at 44154 <at> debbugs.gnu.org (full text, mbox):

From: Mauro Aranda <maurooaranda <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 44154 <at> debbugs.gnu.org, Drew Adams <drew.adams <at> oracle.com>
Subject: Re: bug#44154: 26.3; Customize Face buffer: be able to click an
 inherited face, to customize it
Date: Tue, 27 Oct 2020 12:32:58 -0300

[Message part 1 (text/plain, inline)]

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Drew Adams <drew.adams <at> oracle.com> writes:
>
>> In Customize Face, if attribute Inherit is checked then be able to click
>> the name of an inherited face, to customize it, or at least to see its
>> attributes/definition.
>>
>> That is, have a link on it, which invokes either `customize-face' or
>> `describe-face' for it.
>
> Makes sense.  I've now added this to Emacs 28.

> +(defun cus--face-link (widget _format)
> +  (let ((face (intern (widget-get widget :value))))
> +    (widget-create-child-and-convert
> +     widget 'face-link
> +     :button-face 'link
> +     :tag "link"
> +     :action (lambda (&rest _x)
> +               (customize-face face)))))
> +

I think this could become confusing if one edits the value of the
inherited face, because the link always points to the widget's value at
creation time.

I suggest making the link always point to the widget's current value,
like in the attached patch.

[Message part 2 (text/html, inline)]

[0001-Small-fix-to-the-new-link-for-inherited-faces-in-Cus.patch (text/x-patch, attachment)]

Message #18 received at 44154 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Mauro Aranda <maurooaranda <at> gmail.com>
Cc: 44154 <at> debbugs.gnu.org, Drew Adams <drew.adams <at> oracle.com>
Date: Tue, 27 Oct 2020 18:35:04 +0100

Mauro Aranda <maurooaranda <at> gmail.com> writes:

> I think this could become confusing if one edits the value of the
> inherited face, because the link always points to the widget's value at
> creation time.
>
> I suggest making the link always point to the widget's current value,
> like in the attached patch.

Ah, right.  Thanks; applied to the trunk.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.